reek 1.5.1 → 1.6.0

data/features/reports/yaml.feature

@@ -11,78 +11,50 @@ Feature: Report smells using simple YAML layout
     --- []
     """
 
-  @masking
-  Scenario: masked smells always appear
-    When I run reek --yaml spec/samples/masked/dirty.rb
+  Scenario: Indicate smells and print them as yaml when using files
+    When I run reek --yaml spec/samples/standard_smelly/minimal_dirty.rb
     Then the exit status indicates smells
     And it reports this yaml:
       """
       ---
-      - !ruby/object:Reek::SmellWarning
-        location:
-          lines:
-          - 4
-          - 6
-          context: Dirty#a
-          source: spec/samples/masked/dirty.rb
-        smell:
-          class: Duplication
-          occurrences: 2
-          subclass: DuplicateMethodCall
-          call: "@s.title"
-          message: calls @s.title twice
-        status:
-          is_active: true
-      - !ruby/object:Reek::SmellWarning
-        location:
-          lines:
-          - 5
-          - 7
-          context: Dirty#a
-          source: spec/samples/masked/dirty.rb
-        smell:
-          class: Duplication
-          occurrences: 2
-          subclass: DuplicateMethodCall
-          call: puts(@s.title)
-          message: calls puts(@s.title) twice
-        status:
-          is_active: true
-      - !ruby/object:Reek::SmellWarning
-        location:
-          lines:
-          - 5
-          context: Dirty#a
-          source: spec/samples/masked/dirty.rb
-        smell:
-          class: NestedIterators
-          depth: 2
-          subclass: NestedIterators
-          message: contains iterators nested 2 deep
-        status:
-          is_active: true
-
+      - smell_category: IrresponsibleModule
+        smell_type: IrresponsibleModule
+        source: spec/samples/standard_smelly/minimal_dirty.rb
+        context: C
+        lines:
+        - 1
+        message: has no descriptive comment
+        name: C
+      - smell_category: UncommunicativeName
+        smell_type: UncommunicativeModuleName
+        source: spec/samples/standard_smelly/minimal_dirty.rb
+        context: C
+        lines:
+        - 1
+        message: has the name 'C'
+        name: C
+      - smell_category: UncommunicativeName
+        smell_type: UncommunicativeMethodName
+        source: spec/samples/standard_smelly/minimal_dirty.rb
+        context: C#m
+        lines:
+        - 2
+        message: has the name 'm'
+        name: m
       """
 
-  @stdin
-  Scenario: return non-zero status when there are smells
+  Scenario: Indicate smells and print them as yaml when using STDIN
     When I pass "class Turn; end" to reek --yaml
     Then the exit status indicates smells
     And it reports this yaml:
       """
       ---
-      - !ruby/object:Reek::SmellWarning
-        location:
-          lines:
-          - 1
-          context: Turn
-          source: $stdin
-        smell:
-          class: IrresponsibleModule
-          subclass: IrresponsibleModule
-          module_name: Turn
-          message: has no descriptive comment
-        status:
-          is_active: true
-
+      - smell_category: IrresponsibleModule
+        smell_type: IrresponsibleModule
+        source: "$stdin"
+        context: Turn
+        lines:
+        - 1
+        message: has no descriptive comment
+        name: Turn
       """

data/features/samples.feature

@@ -10,13 +10,13 @@ Feature: Basic smell detection
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/inline.rb -- 43 warnings:
+    spec/samples/inline.rb -- 44 warnings:
       CompilationError has no descriptive comment (IrresponsibleModule)
       File has no descriptive comment (IrresponsibleModule)
       File#self.write_with_backup has approx 6 statements (TooManyStatements)
       Inline declares the class variable @@directory (ClassVariable)
       Inline declares the class variable @@rootdir (ClassVariable)
-      Inline#self.rootdir calls env.nil? twice (DuplicateMethodCall)
+      Inline#self.rootdir calls env.nil? 2 times (DuplicateMethodCall)
       Inline#self.rootdir has approx 8 statements (TooManyStatements)
       Inline#self.rootdir performs a nil-check. (NilCheck)
       Inline::C declares the class variable @@type_map (ClassVariable)
@@ -25,25 +25,26 @@ Feature: Basic smell detection
       Inline::C tests $DEBUG at least 7 times (RepeatedConditional)
       Inline::C tests $TESTING at least 4 times (RepeatedConditional)
       Inline::C tests @@type_map.has_key?(type) at least 3 times (RepeatedConditional)
-      Inline::C#build calls $? != 0 twice (DuplicateMethodCall)
+      Inline::C#build calls $? != 0 2 times (DuplicateMethodCall)
       Inline::C#build calls Inline.directory 5 times (DuplicateMethodCall)
       Inline::C#build calls io.puts 6 times (DuplicateMethodCall)
-      Inline::C#build calls io.puts("#endif") twice (DuplicateMethodCall)
-      Inline::C#build calls io.puts("#ifdef __cplusplus") twice (DuplicateMethodCall)
-      Inline::C#build calls warn("Output:\n#{result}") twice (DuplicateMethodCall)
+      Inline::C#build calls io.puts("#endif") 2 times (DuplicateMethodCall)
+      Inline::C#build calls io.puts("#ifdef __cplusplus") 2 times (DuplicateMethodCall)
+      Inline::C#build calls warn("Output:\n#{result}") 2 times (DuplicateMethodCall)
       Inline::C#build contains iterators nested 2 deep (NestedIterators)
       Inline::C#build has approx 63 statements (TooManyStatements)
       Inline::C#build has the variable name 'n' (UncommunicativeVariableName)
       Inline::C#build has the variable name 't' (UncommunicativeVariableName)
       Inline::C#c has the name 'c' (UncommunicativeMethodName)
-      Inline::C#crap_for_windoze calls Config::CONFIG["libdir"] twice (DuplicateMethodCall)
-      Inline::C#generate calls result.sub!(/\A\n/, "") twice (DuplicateMethodCall)
-      Inline::C#generate calls signature["args"] twice (DuplicateMethodCall)
-      Inline::C#generate calls signature["args"].map twice (DuplicateMethodCall)
+      Inline::C#crap_for_windoze calls Config::CONFIG["libdir"] 2 times (DuplicateMethodCall)
+      Inline::C#generate calls result.sub!(/\A\n/, "") 2 times (DuplicateMethodCall)
+      Inline::C#generate calls signature["args"] 2 times (DuplicateMethodCall)
+      Inline::C#generate calls signature["args"].map 2 times (DuplicateMethodCall)
       Inline::C#generate has approx 35 statements (TooManyStatements)
-      Inline::C#initialize calls stack.empty? twice (DuplicateMethodCall)
+      Inline::C#initialize calls stack.empty? 2 times (DuplicateMethodCall)
       Inline::C#module_name has approx 7 statements (TooManyStatements)
       Inline::C#module_name has the variable name 'm' (UncommunicativeVariableName)
+      Inline::C#module_name has the variable name 'md5' (UncommunicativeVariableName)
       Inline::C#module_name has the variable name 'x' (UncommunicativeVariableName)
       Inline::C#parse_signature has approx 16 statements (TooManyStatements)
       Inline::C#parse_signature has boolean parameter 'raw' (BooleanParameter)
@@ -51,8 +52,8 @@ Feature: Basic smell detection
       Inline::C#parse_signature is controlled by argument raw (ControlParameter)
       Inline::C#strip_comments doesn't depend on instance state (UtilityFunction)
       Inline::C#strip_comments refers to src more than self (FeatureEnvy)
-      Module#inline calls Inline.const_get(lang) twice (DuplicateMethodCall)
-      Module#inline calls options[:testing] twice (DuplicateMethodCall)
+      Module#inline calls Inline.const_get(lang) 2 times (DuplicateMethodCall)
+      Module#inline calls options[:testing] 2 times (DuplicateMethodCall)
       Module#inline has approx 12 statements (TooManyStatements)
     """
 
@@ -77,20 +78,20 @@ Feature: Basic smell detection
       OptionParser#complete has 4 parameters (LongParameterList)
       OptionParser#complete has approx 6 statements (TooManyStatements)
       OptionParser#complete has boolean parameter 'icase' (BooleanParameter)
-      OptionParser#getopts calls result[opt] = false twice (DuplicateMethodCall)
+      OptionParser#getopts calls result[opt] = false 2 times (DuplicateMethodCall)
       OptionParser#getopts has approx 18 statements (TooManyStatements)
       OptionParser#load has approx 6 statements (TooManyStatements)
       OptionParser#load has the variable name 's' (UncommunicativeVariableName)
       OptionParser#make_switch calls default_style.guess(arg = a) 4 times (DuplicateMethodCall)
-      OptionParser#make_switch calls long << (o = q.downcase) twice (DuplicateMethodCall)
-      OptionParser#make_switch calls notwice(NilClass, klass, "type") twice (DuplicateMethodCall)
-      OptionParser#make_switch calls notwice(if a ... end, klass, "type") twice (DuplicateMethodCall)
-      OptionParser#make_switch calls pattern.method(:convert) twice (DuplicateMethodCall)
-      OptionParser#make_switch calls pattern.method(:convert).to_proc twice (DuplicateMethodCall)
-      OptionParser#make_switch calls pattern.respond_to?(:convert) twice (DuplicateMethodCall)
+      OptionParser#make_switch calls long << (o = q.downcase) 2 times (DuplicateMethodCall)
+      OptionParser#make_switch calls notwice(NilClass, klass, "type") 2 times (DuplicateMethodCall)
+      OptionParser#make_switch calls notwice(if a ... end, klass, "type") 2 times (DuplicateMethodCall)
+      OptionParser#make_switch calls pattern.method(:convert) 2 times (DuplicateMethodCall)
+      OptionParser#make_switch calls pattern.method(:convert).to_proc 2 times (DuplicateMethodCall)
+      OptionParser#make_switch calls pattern.respond_to?(:convert) 2 times (DuplicateMethodCall)
       OptionParser#make_switch calls q.downcase 3 times (DuplicateMethodCall)
-      OptionParser#make_switch calls sdesc << "-#{q}" twice (DuplicateMethodCall)
-      OptionParser#make_switch calls search(:atype, FalseClass) twice (DuplicateMethodCall)
+      OptionParser#make_switch calls sdesc << "-#{q}" 2 times (DuplicateMethodCall)
+      OptionParser#make_switch calls search(:atype, FalseClass) 2 times (DuplicateMethodCall)
       OptionParser#make_switch calls search(:atype, o) 6 times (DuplicateMethodCall)
       OptionParser#make_switch contains iterators nested 3 deep (NestedIterators)
       OptionParser#make_switch has approx 72 statements (TooManyStatements)
@@ -102,20 +103,20 @@ Feature: Basic smell detection
       OptionParser#make_switch has the variable name 's' (UncommunicativeVariableName)
       OptionParser#make_switch has the variable name 'v' (UncommunicativeVariableName)
       OptionParser#make_switch performs a nil-check. (NilCheck)
-      OptionParser#order calls argv[0] twice (DuplicateMethodCall)
+      OptionParser#order calls argv[0] 2 times (DuplicateMethodCall)
       OptionParser#order refers to argv more than self (FeatureEnvy)
-      OptionParser#parse calls argv[0] twice (DuplicateMethodCall)
+      OptionParser#parse calls argv[0] 2 times (DuplicateMethodCall)
       OptionParser#parse refers to argv more than self (FeatureEnvy)
-      OptionParser#parse_in_order calls $!.set_option(arg, true) twice (DuplicateMethodCall)
-      OptionParser#parse_in_order calls cb.call(val) twice (DuplicateMethodCall)
-      OptionParser#parse_in_order calls raise($!.set_option(arg, true)) twice (DuplicateMethodCall)
-      OptionParser#parse_in_order calls raise(*exc) twice (DuplicateMethodCall)
-      OptionParser#parse_in_order calls setter.call(sw.switch_name, val) twice (DuplicateMethodCall)
-      OptionParser#parse_in_order calls sw.block twice (DuplicateMethodCall)
-      OptionParser#parse_in_order calls sw.switch_name twice (DuplicateMethodCall)
+      OptionParser#parse_in_order calls $!.set_option(arg, true) 2 times (DuplicateMethodCall)
+      OptionParser#parse_in_order calls cb.call(val) 2 times (DuplicateMethodCall)
+      OptionParser#parse_in_order calls raise($!.set_option(arg, true)) 2 times (DuplicateMethodCall)
+      OptionParser#parse_in_order calls raise(*exc) 2 times (DuplicateMethodCall)
+      OptionParser#parse_in_order calls setter.call(sw.switch_name, val) 2 times (DuplicateMethodCall)
+      OptionParser#parse_in_order calls sw.block 2 times (DuplicateMethodCall)
+      OptionParser#parse_in_order calls sw.switch_name 2 times (DuplicateMethodCall)
       OptionParser#parse_in_order contains iterators nested 3 deep (NestedIterators)
       OptionParser#parse_in_order has approx 35 statements (TooManyStatements)
-      OptionParser#permute calls argv[0] twice (DuplicateMethodCall)
+      OptionParser#permute calls argv[0] 2 times (DuplicateMethodCall)
       OptionParser#permute refers to argv more than self (FeatureEnvy)
       OptionParser#permute! has approx 6 statements (TooManyStatements)
       OptionParser#search has the variable name 'k' (UncommunicativeVariableName)
@@ -128,8 +129,8 @@ Feature: Basic smell detection
       OptionParser::Arguable#options has approx 6 statements (TooManyStatements)
       OptionParser::Arguable#options= is controlled by argument opt (ControlParameter)
       OptionParser::CompletingHash#match contains iterators nested 2 deep (NestedIterators)
-      OptionParser::Completion#complete calls candidates.size twice (DuplicateMethodCall)
-      OptionParser::Completion#complete calls k.id2name twice (DuplicateMethodCall)
+      OptionParser::Completion#complete calls candidates.size 2 times (DuplicateMethodCall)
+      OptionParser::Completion#complete calls k.id2name 2 times (DuplicateMethodCall)
       OptionParser::Completion#complete has approx 23 statements (TooManyStatements)
       OptionParser::Completion#complete has boolean parameter 'icase' (BooleanParameter)
       OptionParser::Completion#complete has the variable name 'k' (UncommunicativeVariableName)
@@ -149,19 +150,19 @@ Feature: Basic smell detection
       OptionParser::ParseError#set_option is controlled by argument eq (ControlParameter)
       OptionParser::Switch#add_banner has the variable name 's' (UncommunicativeVariableName)
       OptionParser::Switch#initialize has 7 parameters (LongParameterList)
-      OptionParser::Switch#parse_arg calls s.length twice (DuplicateMethodCall)
+      OptionParser::Switch#parse_arg calls s.length 2 times (DuplicateMethodCall)
       OptionParser::Switch#parse_arg has approx 11 statements (TooManyStatements)
       OptionParser::Switch#parse_arg has the variable name 'm' (UncommunicativeVariableName)
       OptionParser::Switch#parse_arg has the variable name 's' (UncommunicativeVariableName)
       OptionParser::Switch#self.guess has approx 6 statements (TooManyStatements)
       OptionParser::Switch#self.guess has the variable name 't' (UncommunicativeVariableName)
       OptionParser::Switch#self.incompatible_argument_styles has the parameter name 't' (UncommunicativeParameterName)
-      OptionParser::Switch#summarize calls indent + l twice (DuplicateMethodCall)
-      OptionParser::Switch#summarize calls left.collect do |s| ... end twice (DuplicateMethodCall)
-      OptionParser::Switch#summarize calls left.collect do |s| ... end.max twice (DuplicateMethodCall)
-      OptionParser::Switch#summarize calls left.collect do |s| ... end.max.to_i twice (DuplicateMethodCall)
-      OptionParser::Switch#summarize calls left.collect twice (DuplicateMethodCall)
-      OptionParser::Switch#summarize calls left.shift twice (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls indent + l 2 times (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.collect 2 times (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.collect do |s| ... end 2 times (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.collect do |s| ... end.max 2 times (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.collect do |s| ... end.max.to_i 2 times (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.shift 2 times (DuplicateMethodCall)
       OptionParser::Switch#summarize calls left[(-1)] 3 times (DuplicateMethodCall)
       OptionParser::Switch#summarize calls s.length 3 times (DuplicateMethodCall)
       OptionParser::Switch#summarize contains iterators nested 2 deep (NestedIterators)
@@ -195,10 +196,10 @@ Feature: Basic smell detection
       RedCloth#block_markdown_rule refers to text more than self (FeatureEnvy)
       RedCloth#block_markdown_setext refers to text more than self (FeatureEnvy)
       RedCloth#block_textile_lists calls depth.last 5 times (DuplicateMethodCall)
-      RedCloth#block_textile_lists calls depth.last.length twice (DuplicateMethodCall)
-      RedCloth#block_textile_lists calls depth[i] twice (DuplicateMethodCall)
-      RedCloth#block_textile_lists calls line_id - 1 twice (DuplicateMethodCall)
-      RedCloth#block_textile_lists calls lines[line_id - 1] twice (DuplicateMethodCall)
+      RedCloth#block_textile_lists calls depth.last.length 2 times (DuplicateMethodCall)
+      RedCloth#block_textile_lists calls depth[i] 2 times (DuplicateMethodCall)
+      RedCloth#block_textile_lists calls line_id - 1 2 times (DuplicateMethodCall)
+      RedCloth#block_textile_lists calls lines[line_id - 1] 2 times (DuplicateMethodCall)
       RedCloth#block_textile_lists calls tl.length 3 times (DuplicateMethodCall)
       RedCloth#block_textile_lists contains iterators nested 3 deep (NestedIterators)
       RedCloth#block_textile_lists has approx 21 statements (TooManyStatements)
@@ -213,7 +214,7 @@ Feature: Basic smell detection
       RedCloth#blocks has boolean parameter 'deep_code' (BooleanParameter)
       RedCloth#blocks is controlled by argument deep_code (ControlParameter)
       RedCloth#blocks refers to blk more than self (FeatureEnvy)
-      RedCloth#clean_html calls tags[tag] twice (DuplicateMethodCall)
+      RedCloth#clean_html calls tags[tag] 2 times (DuplicateMethodCall)
       RedCloth#clean_html contains iterators nested 3 deep (NestedIterators)
       RedCloth#clean_html doesn't depend on instance state (UtilityFunction)
       RedCloth#clean_html has approx 15 statements (TooManyStatements)
@@ -252,7 +253,7 @@ Feature: Basic smell detection
       RedCloth#lT refers to text more than self (FeatureEnvy)
       RedCloth#no_textile doesn't depend on instance state (UtilityFunction)
       RedCloth#no_textile refers to text more than self (FeatureEnvy)
-      RedCloth#pba calls $1.length twice (DuplicateMethodCall)
+      RedCloth#pba calls $1.length 2 times (DuplicateMethodCall)
       RedCloth#pba has approx 21 statements (TooManyStatements)
       RedCloth#pba is controlled by argument element (ControlParameter)
       RedCloth#pba refers to text more than self (FeatureEnvy)
@@ -260,13 +261,13 @@ Feature: Basic smell detection
       RedCloth#refs_textile has the variable name 'm' (UncommunicativeVariableName)
       RedCloth#retrieve has the variable name 'i' (UncommunicativeVariableName)
       RedCloth#retrieve has the variable name 'r' (UncommunicativeVariableName)
-      RedCloth#rip_offtags calls (codepre - used_offtags.length) > 0 twice (DuplicateMethodCall)
-      RedCloth#rip_offtags calls @pre_list.last << line twice (DuplicateMethodCall)
-      RedCloth#rip_offtags calls @pre_list.last twice (DuplicateMethodCall)
-      RedCloth#rip_offtags calls codepre - used_offtags.length twice (DuplicateMethodCall)
-      RedCloth#rip_offtags calls codepre.zero? twice (DuplicateMethodCall)
-      RedCloth#rip_offtags calls htmlesc(line, :NoQuotes) twice (DuplicateMethodCall)
-      RedCloth#rip_offtags calls used_offtags.length twice (DuplicateMethodCall)
+      RedCloth#rip_offtags calls (codepre - used_offtags.length) > 0 2 times (DuplicateMethodCall)
+      RedCloth#rip_offtags calls @pre_list.last 2 times (DuplicateMethodCall)
+      RedCloth#rip_offtags calls @pre_list.last << line 2 times (DuplicateMethodCall)
+      RedCloth#rip_offtags calls codepre - used_offtags.length 2 times (DuplicateMethodCall)
+      RedCloth#rip_offtags calls codepre.zero? 2 times (DuplicateMethodCall)
+      RedCloth#rip_offtags calls htmlesc(line, :NoQuotes) 2 times (DuplicateMethodCall)
+      RedCloth#rip_offtags calls used_offtags.length 2 times (DuplicateMethodCall)
       RedCloth#rip_offtags calls used_offtags["notextile"] 3 times (DuplicateMethodCall)
       RedCloth#rip_offtags has approx 18 statements (TooManyStatements)
       RedCloth#textile_bq has 4 parameters (LongParameterList)

data/features/support/env.rb

@@ -1,14 +1,21 @@
+require 'English'
 require 'tempfile'
 require 'fileutils'
 require 'open3'
 require 'reek/cli/application'
 
+begin
+  require 'pry'
+  require 'byebug'
+rescue LoadError # rubocop:disable Lint/HandleExceptions
+end
+
 class ReekWorld
   def run(cmd)
     stderr_file = Tempfile.new('reek-world')
     stderr_file.close
     @last_stdout = `#{cmd} 2> #{stderr_file.path}`
-    @last_exit_status = $?.exitstatus
+    @last_exit_status = $CHILD_STATUS.exitstatus
     @last_stderr = IO.read(stderr_file.path)
   end
 

data/lib/reek/cli/application.rb

@@ -1,4 +1,5 @@
 require 'reek/cli/options'
+require 'reek/configuration/app_configuration'
 
 module Reek
   module Cli
@@ -8,26 +9,34 @@ module Reek
     # command line.
     #
     class Application
+      attr_reader :options
+
       STATUS_SUCCESS = 0
       STATUS_ERROR   = 1
       STATUS_SMELLS  = 2
 
       def initialize(argv)
+        @status  = STATUS_SUCCESS
         @options = Options.new(argv)
-        @status = STATUS_SUCCESS
-      end
-
-      def execute
         begin
-          cmd = @options.parse
-          cmd.execute(self)
-        rescue OptionParser::InvalidOption, ConfigFileException => error
+          @command = @options.parse
+          initialize_configuration
+        rescue OptionParser::InvalidOption, Reek::Configuration::ConfigFileException => error
           $stderr.puts "Error: #{error}"
           @status = STATUS_ERROR
         end
+      end
+
+      def execute
+        return @status if error_occured?
+        @command.execute self
         @status
       end
 
+      def initialize_configuration
+        Configuration::AppConfiguration.initialize_with self
+      end
+
       def output(text)
         print text
       end
@@ -39,6 +48,12 @@ module Reek
       def report_smells
         @status = STATUS_SMELLS
       end
+
+      private
+
+      def error_occured?
+        @status == STATUS_ERROR
+      end
     end
   end
 end

data/lib/reek/cli/command.rb

@@ -4,8 +4,10 @@ module Reek
     # Base class for all commands
     #
     class Command
-      def initialize(parser)
-        @parser = parser
+      attr_reader :options
+
+      def initialize(options)
+        @options = options
       end
     end
   end

data/lib/reek/cli/help_command.rb

@@ -7,7 +7,7 @@ module Reek
     #
     class HelpCommand < Command
       def execute(view)
-        view.output(@parser.help_text)
+        view.output(@options.help_text)
         view.report_success
       end
     end

data/lib/reek/cli/options.rb

@@ -22,7 +22,7 @@ module Reek
         @strategy = Report::Strategy::Quiet
         @warning_formatter = Report::WarningFormatterWithLineNumbers
         @command_class = ReekCommand
-        @config_files = []
+        @config_file = nil
         @sort_by_issue_count = false
         @smells_to_detect = []
         set_options
@@ -72,7 +72,7 @@ EOB
 
         @parser.separator "\nConfiguration:"
         @parser.on('-c', '--config FILE', 'Read configuration options from FILE') do |file|
-          @config_files << file
+          @config_file = file
         end
         @parser.on('--smell SMELL', 'Detect smell SMELL (default is all enabled smells)') do |smell|
           @smells_to_detect << smell
@@ -117,7 +117,7 @@ EOB
         @command_class.new(self)
       end
 
-      attr_reader :config_files
+      attr_reader :config_file
       attr_reader :smells_to_detect
 
       def reporter