reek 1.2.13 → 1.3

data/CHANGELOG

@@ -1,3 +1,9 @@
+== 1.3
+
+* (mvz) Use new ruby_parser 3 and friends
+* (EmilRehnberg) Unused parameter smell added
+* (dkubb) Fix problem with IrresponsibleModule flagging the same module twice
+
 == 1.2.13 (2012-12-07)
 
 * (mvz) Update to rspec2.

data/config/defaults.reek

@@ -112,3 +112,6 @@ LongYieldList:
   exclude: []
 
   enabled: true
+UnusedParameters: 
+  exclude: *id001
+  enabled: true

data/features/ruby_api/api.feature

@@ -9,12 +9,16 @@ Feature: The Reek API maintains backwards compatibility
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/demo/demo.rb -- 6 warnings:
+      spec/samples/demo/demo.rb -- 10 warnings:
         Dirty has no descriptive comment (IrresponsibleModule)
         Dirty#awful has 4 parameters (LongParameterList)
         Dirty#awful has boolean parameter 'log' (BooleanParameter)
         Dirty#awful has the parameter name 'x' (UncommunicativeParameterName)
         Dirty#awful has the parameter name 'y' (UncommunicativeParameterName)
         Dirty#awful has the variable name 'w' (UncommunicativeVariableName)
+        Dirty#awful has unused parameter 'log' (UnusedParameters)
+        Dirty#awful has unused parameter 'offset' (UnusedParameters)
+        Dirty#awful has unused parameter 'x' (UnusedParameters)
+        Dirty#awful has unused parameter 'y' (UnusedParameters)
 
       """

data/features/samples.feature

@@ -8,169 +8,181 @@ Feature: Basic smell detection
   Scenario: Correct smells from inline.rb
     When I run reek spec/samples/inline.rb
     Then the exit status indicates smells
-    And it reports something like: spec/samples/inline.rb -- 41 warnings:
-    And it reports something like: File has no descriptive comment (IrresponsibleModule)
-    And it reports something like: Inline declares the class variable @@directory (ClassVariable)
-    And it reports something like: Inline declares the class variable @@rootdir (ClassVariable)
-    And it reports something like: Inline#self.rootdir calls env.nil? twice (DuplicateMethodCall)
-    And it reports something like: Inline#self.rootdir has approx 8 statements (TooManyStatements)
-    And it reports something like: Inline::C declares the class variable @@type_map (ClassVariable)
-    And it reports something like: Inline::C has at least 13 instance variables (TooManyInstanceVariables)
-    And it reports something like: Inline::C takes parameters [options, src] to 5 methods (DataClump)
-    And it reports something like: Inline::C tests $DEBUG at least 7 times (RepeatedConditional)
-    And it reports something like: Inline::C tests $TESTING at least 4 times (RepeatedConditional)
-    And it reports something like: Inline::C tests @@type_map.has_key?(type) at least 3 times (RepeatedConditional)
-    And it reports something like: Inline::C#build calls ($? == 0) twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#build calls Inline.directory 5 times (DuplicateMethodCall)
-    And it reports something like: Inline::C#build calls io.puts 6 times (DuplicateMethodCall)
-    And it reports something like: Inline::C#build calls io.puts("#endif") twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#build calls io.puts("#ifdef __cplusplus") twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#build calls module_name twice (DuplicateMethodCall)
-    And it reports something like (pending): Inline::C#build calls warn("Output:\n#{result}") twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#build contains iterators nested 2 deep (NestedIterators)
-    And it reports something like: Inline::C#build has approx 60 statements (TooManyStatements)
-    And it reports something like: Inline::C#build has the variable name 'n' (UncommunicativeVariableName)
-    And it reports something like: Inline::C#build has the variable name 't' (UncommunicativeVariableName)
-    And it reports something like: Inline::C#c has the name 'c' (UncommunicativeMethodName)
-    And it reports something like: Inline::C#crap_for_windoze calls Config::CONFIG["libdir"] twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#generate calls result.sub!(/\A\n/, "") twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#generate calls signature["args"] twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#generate calls signature["args"].map twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#generate has approx 32 statements (TooManyStatements)
-    And it reports something like: Inline::C#initialize calls stack.empty? twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#load calls so_name twice (DuplicateMethodCall)
-    And it reports something like: Inline::C#module_name has the variable name 'm' (UncommunicativeVariableName)
-    And it reports something like: Inline::C#module_name has the variable name 'x' (UncommunicativeVariableName)
-    And it reports something like: Inline::C#parse_signature has approx 15 statements (TooManyStatements)
-    And it reports something like: Inline::C#parse_signature has boolean parameter 'raw' (BooleanParameter)
-    And it reports something like: Inline::C#parse_signature has the variable name 'x' (UncommunicativeVariableName)
-    And it reports something like: Inline::C#parse_signature is controlled by argument raw (ControlParameter)
-    And it reports something like: Inline::C#strip_comments doesn't depend on instance state (UtilityFunction)
-    And it reports something like: Inline::C#strip_comments refers to src more than self (FeatureEnvy)
-    And it reports something like: Module#inline calls Inline.const_get(lang) twice (DuplicateMethodCall)
-    And it reports something like: Module#inline has approx 11 statements (TooManyStatements)
-    And it reports something like: Module#inline is controlled by argument options (ControlParameter)
+    And it reports:
+    """
+    spec/samples/inline.rb -- 41 warnings:
+      File has no descriptive comment (IrresponsibleModule)
+      Inline declares the class variable @@directory (ClassVariable)
+      Inline declares the class variable @@rootdir (ClassVariable)
+      Inline#self.rootdir calls env.nil? twice (DuplicateMethodCall)
+      Inline#self.rootdir has approx 8 statements (TooManyStatements)
+      Inline::C declares the class variable @@type_map (ClassVariable)
+      Inline::C has at least 13 instance variables (TooManyInstanceVariables)
+      Inline::C takes parameters [options, src] to 5 methods (DataClump)
+      Inline::C tests $DEBUG at least 7 times (RepeatedConditional)
+      Inline::C tests $TESTING at least 4 times (RepeatedConditional)
+      Inline::C tests @@type_map.has_key?(type) at least 3 times (RepeatedConditional)
+      Inline::C#build calls $?.!=(0) twice (DuplicateMethodCall)
+      Inline::C#build calls Inline.directory 5 times (DuplicateMethodCall)
+      Inline::C#build calls io.puts 6 times (DuplicateMethodCall)
+      Inline::C#build calls io.puts("#endif") twice (DuplicateMethodCall)
+      Inline::C#build calls io.puts("#ifdef __cplusplus") twice (DuplicateMethodCall)
+      Inline::C#build calls module_name twice (DuplicateMethodCall)
+      Inline::C#build calls warn("Output:\n#{result}") twice (DuplicateMethodCall)
+      Inline::C#build contains iterators nested 2 deep (NestedIterators)
+      Inline::C#build has approx 60 statements (TooManyStatements)
+      Inline::C#build has the variable name 'n' (UncommunicativeVariableName)
+      Inline::C#build has the variable name 't' (UncommunicativeVariableName)
+      Inline::C#c has the name 'c' (UncommunicativeMethodName)
+      Inline::C#crap_for_windoze calls Config::CONFIG["libdir"] twice (DuplicateMethodCall)
+      Inline::C#generate calls result.sub!(/\A\n/, "") twice (DuplicateMethodCall)
+      Inline::C#generate calls signature["args"] twice (DuplicateMethodCall)
+      Inline::C#generate calls signature["args"].map twice (DuplicateMethodCall)
+      Inline::C#generate has approx 32 statements (TooManyStatements)
+      Inline::C#initialize calls stack.empty? twice (DuplicateMethodCall)
+      Inline::C#load calls so_name twice (DuplicateMethodCall)
+      Inline::C#module_name has the variable name 'm' (UncommunicativeVariableName)
+      Inline::C#module_name has the variable name 'x' (UncommunicativeVariableName)
+      Inline::C#parse_signature has approx 15 statements (TooManyStatements)
+      Inline::C#parse_signature has boolean parameter 'raw' (BooleanParameter)
+      Inline::C#parse_signature has the variable name 'x' (UncommunicativeVariableName)
+      Inline::C#parse_signature is controlled by argument raw (ControlParameter)
+      Inline::C#strip_comments doesn't depend on instance state (UtilityFunction)
+      Inline::C#strip_comments refers to src more than self (FeatureEnvy)
+      Module#inline calls Inline.const_get(lang) twice (DuplicateMethodCall)
+      Module#inline has approx 11 statements (TooManyStatements)
+      Module#inline is controlled by argument options (ControlParameter)
+
+    """
 
   Scenario: Correct smells from optparse.rb
     When I run reek spec/samples/optparse.rb
     Then the exit status indicates smells
-    And it reports something like: spec/samples/optparse.rb -- 109 warnings:
-    And it reports something like: OptionParser has at least 42 methods (TooManyMethods)
-    And it reports something like: OptionParser has the variable name 'f' (UncommunicativeVariableName)
-    And it reports something like: OptionParser has the variable name 'k' (UncommunicativeVariableName)
-    And it reports something like: OptionParser has the variable name 'o' (UncommunicativeVariableName)
-    And it reports something like: OptionParser has the variable name 's' (UncommunicativeVariableName)
-    And it reports something like: OptionParser has the variable name 'v' (UncommunicativeVariableName)
-    And it reports something like: OptionParser tests ((argv.size == 1) and Array.===(argv[0])) at least 3 times (RepeatedConditional)
-    And it reports something like: OptionParser tests a at least 7 times (RepeatedConditional)
-    And it reports something like: OptionParser tests default_pattern at least 7 times (RepeatedConditional)
-    And it reports something like: OptionParser tests not_style at least 3 times (RepeatedConditional)
-    And it reports something like: OptionParser tests s at least 7 times (RepeatedConditional)
-    And it reports something like: OptionParser#complete contains iterators nested 2 deep (NestedIterators)
-    And it reports something like: OptionParser#complete has 4 parameters (LongParameterList)
-    And it reports something like: OptionParser#complete has boolean parameter 'icase' (BooleanParameter)
-    And it reports something like: OptionParser#getopts calls result[opt] = false twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#getopts has approx 17 statements (TooManyStatements)
-    And it reports something like: OptionParser#load has the variable name 's' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#make_switch calls (long << o = q.downcase) twice (DuplicateMethodCall)
-    And it reports something like (pending): OptionParser#make_switch calls (sdesc << "-#{q}") twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls default_style.guess(arg = a) 4 times (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls notwice(NilClass, klass, "type") twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls notwice(a ? (Object) : (TrueClass), klass, "type") twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls pattern.method(:convert) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls pattern.method(:convert).to_proc twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls pattern.respond_to?(:convert) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls q.downcase 3 times (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls search(:atype, FalseClass) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch calls search(:atype, o) 6 times (DuplicateMethodCall)
-    And it reports something like: OptionParser#make_switch contains iterators nested 2 deep (NestedIterators)
-    And it reports something like: OptionParser#make_switch contains iterators nested 3 deep (NestedIterators)
-    And it reports something like: OptionParser#make_switch has approx 68 statements (TooManyStatements)
-    And it reports something like: OptionParser#make_switch has the variable name 'a' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#make_switch has the variable name 'c' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#make_switch has the variable name 'n' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#make_switch has the variable name 'o' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#make_switch has the variable name 'q' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#make_switch has the variable name 's' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#make_switch has the variable name 'v' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#order calls argv[0] twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#order refers to argv more than self (FeatureEnvy)
-    And it reports something like: OptionParser#parse calls argv[0] twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#parse refers to argv more than self (FeatureEnvy)
-    And it reports something like: OptionParser#parse_in_order calls $!.set_option(arg, true) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#parse_in_order calls cb.call(val) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#parse_in_order calls raise($!.set_option(arg, true)) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#parse_in_order calls raise(*exc) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#parse_in_order calls setter.call(sw.switch_name, val) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#parse_in_order calls sw.block twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#parse_in_order calls sw.switch_name twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#parse_in_order contains iterators nested 2 deep (NestedIterators)
-    And it reports something like: OptionParser#parse_in_order contains iterators nested 3 deep (NestedIterators)
-    And it reports something like: OptionParser#parse_in_order has approx 28 statements (TooManyStatements)
-    And it reports something like: OptionParser#parse_in_order is controlled by argument setter (ControlParameter)
-    And it reports something like: OptionParser#permute calls argv[0] twice (DuplicateMethodCall)
-    And it reports something like: OptionParser#permute refers to argv more than self (FeatureEnvy)
-    And it reports something like: OptionParser#search has the variable name 'k' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#summarize has 4 parameters (LongParameterList)
-    And it reports something like: OptionParser#summarize has the variable name 'l' (UncommunicativeVariableName)
-    And it reports something like: OptionParser#ver has the variable name 'v' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::CompletingHash#match contains iterators nested 2 deep (NestedIterators)
-    And it reports something like: OptionParser::Completion#complete calls candidates.size twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Completion#complete calls k.id2name twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Completion#complete has approx 22 statements (TooManyStatements)
-    And it reports something like: OptionParser::Completion#complete has boolean parameter 'icase' (BooleanParameter)
-    And it reports something like: OptionParser::Completion#complete has the variable name 'k' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Completion#complete has the variable name 'v' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Completion#complete refers to candidates more than self (FeatureEnvy)
-    And it reports something like: OptionParser::List#accept has the parameter name 't' (UncommunicativeParameterName)
-    And it reports something like: OptionParser::List#accept is controlled by argument pat (ControlParameter)
-    And it reports something like: OptionParser::List#accept refers to pat more than self (FeatureEnvy)
-    And it reports something like: OptionParser::List#add_banner refers to opt more than self (FeatureEnvy)
-    And it reports something like: OptionParser::List#complete has 4 parameters (LongParameterList)
-    And it reports something like: OptionParser::List#complete has boolean parameter 'icase' (BooleanParameter)
-    And it reports something like: OptionParser::List#reject has the parameter name 't' (UncommunicativeParameterName)
-    And it reports something like: OptionParser::List#summarize refers to opt more than self (FeatureEnvy)
-    And it reports something like: OptionParser::List#update has 5 parameters (LongParameterList)
-    And it reports something like: OptionParser::List#update has approx 6 statements (TooManyStatements)
-    And it reports something like: OptionParser::List#update has the variable name 'o' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::List#update is controlled by argument lopts (ControlParameter)
-    And it reports something like: OptionParser::List#update is controlled by argument sopts (ControlParameter)
-    And it reports something like: OptionParser::ParseError#set_option is controlled by argument eq (ControlParameter)
-    And it reports something like: OptionParser::Switch#add_banner has the variable name 's' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Switch#conv_arg calls conv twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#initialize has 7 parameters (LongParameterList)
-    And it reports something like: OptionParser::Switch#parse_arg calls pattern twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#parse_arg calls s.length twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#parse_arg has approx 11 statements (TooManyStatements)
-    And it reports something like: OptionParser::Switch#parse_arg has the variable name 'm' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Switch#parse_arg has the variable name 's' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Switch#self.guess has the variable name 't' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Switch#self.incompatible_argument_styles has the parameter name 't' (UncommunicativeParameterName)
-    And it reports something like: OptionParser::Switch#summarize calls (indent + l) twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#summarize calls arg 4 times (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#summarize calls left.collect twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#summarize calls left.collect { |s| s.length }.max twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#summarize calls left.collect { |s| s.length }.max.to_i twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#summarize calls left.shift twice (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#summarize calls left[-1] 3 times (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#summarize calls s.length 3 times (DuplicateMethodCall)
-    And it reports something like: OptionParser::Switch#summarize contains iterators nested 2 deep (NestedIterators)
-    And it reports something like: OptionParser::Switch#summarize has 5 parameters (LongParameterList)
-    And it reports something like: OptionParser::Switch#summarize has approx 25 statements (TooManyStatements)
-    And it reports something like: OptionParser::Switch#summarize has the variable name 'l' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Switch#summarize has the variable name 'r' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Switch#summarize has the variable name 's' (UncommunicativeVariableName)
-    And it reports something like: OptionParser::Switch::NoArgument#parse is controlled by argument arg (ControlParameter)
-    And it reports something like: OptionParser::Switch::OptionalArgument#parse is controlled by argument arg (ControlParameter)
-    And it reports something like: OptionParser::Switch::PlacedArgument#parse has approx 6 statements (TooManyStatements)
-    And it reports something like: OptionParser::Switch::RequiredArgument#parse is controlled by argument arg (ControlParameter)
+    And it reports:
+    """
+    spec/samples/optparse.rb -- 113 warnings:
+      OptionParser has at least 42 methods (TooManyMethods)
+      OptionParser has the variable name 'f' (UncommunicativeVariableName)
+      OptionParser has the variable name 'k' (UncommunicativeVariableName)
+      OptionParser has the variable name 'o' (UncommunicativeVariableName)
+      OptionParser has the variable name 's' (UncommunicativeVariableName)
+      OptionParser has the variable name 'v' (UncommunicativeVariableName)
+      OptionParser tests (argv.size == 1) and Array.===(argv[0]) at least 3 times (RepeatedConditional)
+      OptionParser tests a at least 7 times (RepeatedConditional)
+      OptionParser tests default_pattern at least 7 times (RepeatedConditional)
+      OptionParser tests not_style at least 3 times (RepeatedConditional)
+      OptionParser tests s at least 7 times (RepeatedConditional)
+      OptionParser#complete contains iterators nested 2 deep (NestedIterators)
+      OptionParser#complete has 4 parameters (LongParameterList)
+      OptionParser#complete has boolean parameter 'icase' (BooleanParameter)
+      OptionParser#getopts calls result[opt] = false twice (DuplicateMethodCall)
+      OptionParser#getopts has approx 17 statements (TooManyStatements)
+      OptionParser#load has the variable name 's' (UncommunicativeVariableName)
+      OptionParser#make_switch calls (long << (o = q.downcase)) twice (DuplicateMethodCall)
+      OptionParser#make_switch calls (sdesc << "-#{q}") twice (DuplicateMethodCall)
+      OptionParser#make_switch calls default_style.guess((arg = a)) 4 times (DuplicateMethodCall)
+      OptionParser#make_switch calls notwice((a ? (Object) : (TrueClass)), klass, "type") twice (DuplicateMethodCall)
+      OptionParser#make_switch calls notwice(NilClass, klass, "type") twice (DuplicateMethodCall)
+      OptionParser#make_switch calls pattern.method(:convert) twice (DuplicateMethodCall)
+      OptionParser#make_switch calls pattern.method(:convert).to_proc twice (DuplicateMethodCall)
+      OptionParser#make_switch calls pattern.respond_to?(:convert) twice (DuplicateMethodCall)
+      OptionParser#make_switch calls q.downcase 3 times (DuplicateMethodCall)
+      OptionParser#make_switch calls search(:atype, FalseClass) twice (DuplicateMethodCall)
+      OptionParser#make_switch calls search(:atype, o) 6 times (DuplicateMethodCall)
+      OptionParser#make_switch contains iterators nested 2 deep (NestedIterators)
+      OptionParser#make_switch contains iterators nested 3 deep (NestedIterators)
+      OptionParser#make_switch has approx 68 statements (TooManyStatements)
+      OptionParser#make_switch has the variable name 'a' (UncommunicativeVariableName)
+      OptionParser#make_switch has the variable name 'c' (UncommunicativeVariableName)
+      OptionParser#make_switch has the variable name 'n' (UncommunicativeVariableName)
+      OptionParser#make_switch has the variable name 'o' (UncommunicativeVariableName)
+      OptionParser#make_switch has the variable name 'q' (UncommunicativeVariableName)
+      OptionParser#make_switch has the variable name 's' (UncommunicativeVariableName)
+      OptionParser#make_switch has the variable name 'v' (UncommunicativeVariableName)
+      OptionParser#order calls argv[0] twice (DuplicateMethodCall)
+      OptionParser#order refers to argv more than self (FeatureEnvy)
+      OptionParser#parse calls argv[0] twice (DuplicateMethodCall)
+      OptionParser#parse refers to argv more than self (FeatureEnvy)
+      OptionParser#parse_in_order calls $!.set_option(arg, true) twice (DuplicateMethodCall)
+      OptionParser#parse_in_order calls cb.call(val) twice (DuplicateMethodCall)
+      OptionParser#parse_in_order calls raise($!.set_option(arg, true)) twice (DuplicateMethodCall)
+      OptionParser#parse_in_order calls raise(*exc) twice (DuplicateMethodCall)
+      OptionParser#parse_in_order calls setter.call(sw.switch_name, val) twice (DuplicateMethodCall)
+      OptionParser#parse_in_order calls sw.block twice (DuplicateMethodCall)
+      OptionParser#parse_in_order calls sw.switch_name twice (DuplicateMethodCall)
+      OptionParser#parse_in_order contains iterators nested 2 deep (NestedIterators)
+      OptionParser#parse_in_order contains iterators nested 3 deep (NestedIterators)
+      OptionParser#parse_in_order has approx 28 statements (TooManyStatements)
+      OptionParser#parse_in_order is controlled by argument setter (ControlParameter)
+      OptionParser#permute calls argv[0] twice (DuplicateMethodCall)
+      OptionParser#permute refers to argv more than self (FeatureEnvy)
+      OptionParser#search has the variable name 'k' (UncommunicativeVariableName)
+      OptionParser#summarize has 4 parameters (LongParameterList)
+      OptionParser#summarize has the variable name 'l' (UncommunicativeVariableName)
+      OptionParser#ver has the variable name 'v' (UncommunicativeVariableName)
+      OptionParser::Arguable#initialize has unused parameter '*args' (UnusedParameters)
+      OptionParser::CompletingHash#match contains iterators nested 2 deep (NestedIterators)
+      OptionParser::Completion#complete calls candidates.size twice (DuplicateMethodCall)
+      OptionParser::Completion#complete calls k.id2name twice (DuplicateMethodCall)
+      OptionParser::Completion#complete has approx 22 statements (TooManyStatements)
+      OptionParser::Completion#complete has boolean parameter 'icase' (BooleanParameter)
+      OptionParser::Completion#complete has the variable name 'k' (UncommunicativeVariableName)
+      OptionParser::Completion#complete has the variable name 'v' (UncommunicativeVariableName)
+      OptionParser::Completion#complete refers to candidates more than self (FeatureEnvy)
+      OptionParser::Completion#convert has unused parameter 'opt' (UnusedParameters)
+      OptionParser::List#accept has the parameter name 't' (UncommunicativeParameterName)
+      OptionParser::List#accept is controlled by argument pat (ControlParameter)
+      OptionParser::List#accept refers to pat more than self (FeatureEnvy)
+      OptionParser::List#add_banner refers to opt more than self (FeatureEnvy)
+      OptionParser::List#complete has 4 parameters (LongParameterList)
+      OptionParser::List#complete has boolean parameter 'icase' (BooleanParameter)
+      OptionParser::List#reject has the parameter name 't' (UncommunicativeParameterName)
+      OptionParser::List#summarize refers to opt more than self (FeatureEnvy)
+      OptionParser::List#update has 5 parameters (LongParameterList)
+      OptionParser::List#update has approx 6 statements (TooManyStatements)
+      OptionParser::List#update has the variable name 'o' (UncommunicativeVariableName)
+      OptionParser::List#update is controlled by argument lopts (ControlParameter)
+      OptionParser::List#update is controlled by argument sopts (ControlParameter)
+      OptionParser::ParseError#set_option is controlled by argument eq (ControlParameter)
+      OptionParser::Switch#add_banner has the variable name 's' (UncommunicativeVariableName)
+      OptionParser::Switch#conv_arg calls conv twice (DuplicateMethodCall)
+      OptionParser::Switch#initialize has 7 parameters (LongParameterList)
+      OptionParser::Switch#parse_arg calls pattern twice (DuplicateMethodCall)
+      OptionParser::Switch#parse_arg calls s.length twice (DuplicateMethodCall)
+      OptionParser::Switch#parse_arg has approx 11 statements (TooManyStatements)
+      OptionParser::Switch#parse_arg has the variable name 'm' (UncommunicativeVariableName)
+      OptionParser::Switch#parse_arg has the variable name 's' (UncommunicativeVariableName)
+      OptionParser::Switch#self.guess has the variable name 't' (UncommunicativeVariableName)
+      OptionParser::Switch#self.incompatible_argument_styles has the parameter name 't' (UncommunicativeParameterName)
+      OptionParser::Switch#summarize calls (indent + l) twice (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls arg 4 times (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.collect twice (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.collect { |s| s.length }.max twice (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.collect { |s| s.length }.max.to_i twice (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left.shift twice (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls left[-1] 3 times (DuplicateMethodCall)
+      OptionParser::Switch#summarize calls s.length 3 times (DuplicateMethodCall)
+      OptionParser::Switch#summarize contains iterators nested 2 deep (NestedIterators)
+      OptionParser::Switch#summarize has 5 parameters (LongParameterList)
+      OptionParser::Switch#summarize has approx 25 statements (TooManyStatements)
+      OptionParser::Switch#summarize has the variable name 'l' (UncommunicativeVariableName)
+      OptionParser::Switch#summarize has the variable name 'r' (UncommunicativeVariableName)
+      OptionParser::Switch#summarize has the variable name 's' (UncommunicativeVariableName)
+      OptionParser::Switch::NoArgument#parse has unused parameter 'argv' (UnusedParameters)
+      OptionParser::Switch::NoArgument#parse is controlled by argument arg (ControlParameter)
+      OptionParser::Switch::OptionalArgument#parse has unused parameter 'argv' (UnusedParameters)
+      OptionParser::Switch::OptionalArgument#parse is controlled by argument arg (ControlParameter)
+      OptionParser::Switch::PlacedArgument#parse has approx 6 statements (TooManyStatements)
+      OptionParser::Switch::RequiredArgument#parse is controlled by argument arg (ControlParameter)
+
+    """
 
   Scenario: Correct smells from redcloth.rb
     When I run reek spec/samples/redcloth.rb
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/redcloth.rb -- 97 warnings:
+    spec/samples/redcloth.rb -- 102 warnings:
       RedCloth has at least 44 methods (TooManyMethods)
       RedCloth has the variable name 'a' (UncommunicativeVariableName)
       RedCloth has the variable name 'b' (UncommunicativeVariableName)
@@ -181,6 +193,7 @@ Feature: Basic smell detection
       RedCloth tests title at least 4 times (RepeatedConditional)
       RedCloth#block_markdown_atx refers to text more than self (FeatureEnvy)
       RedCloth#block_markdown_bq has approx 6 statements (TooManyStatements)
+      RedCloth#block_markdown_lists has unused parameter 'text' (UnusedParameters)
       RedCloth#block_markdown_rule refers to text more than self (FeatureEnvy)
       RedCloth#block_markdown_setext refers to text more than self (FeatureEnvy)
       RedCloth#block_textile_lists calls (line_id - 1) twice (DuplicateMethodCall)
@@ -259,11 +272,15 @@ Feature: Basic smell detection
       RedCloth#rip_offtags calls used_offtags["notextile"] 3 times (DuplicateMethodCall)
       RedCloth#rip_offtags has approx 18 statements (TooManyStatements)
       RedCloth#textile_bq has 4 parameters (LongParameterList)
+      RedCloth#textile_bq has unused parameter 'tag' (UnusedParameters)
       RedCloth#textile_bq is controlled by argument atts (ControlParameter)
       RedCloth#textile_bq is controlled by argument cite (ControlParameter)
       RedCloth#textile_fn_ has 5 parameters (LongParameterList)
+      RedCloth#textile_fn_ has unused parameter 'cite' (UnusedParameters)
+      RedCloth#textile_fn_ has unused parameter 'tag' (UnusedParameters)
       RedCloth#textile_fn_ is controlled by argument atts (ControlParameter)
       RedCloth#textile_p has 4 parameters (LongParameterList)
+      RedCloth#textile_p has unused parameter 'cite' (UnusedParameters)
       RedCloth#textile_p is controlled by argument atts (ControlParameter)
       RedCloth#textile_popup_help has the parameter name 'windowH' (UncommunicativeParameterName)
       RedCloth#textile_popup_help has the parameter name 'windowW' (UncommunicativeParameterName)

data/features/step_definitions/reek_steps.rb

@@ -40,10 +40,6 @@ Then /^it reports this yaml:$/ do |expected_yaml|
   actual_warnings.should == expected_warnings
 end
 
-Then /^it reports something like: (.*)$/ do |line|
-  @last_stdout.chomp.should match Regexp.new(Regexp.escape(line))
-end
-
 Then /^stderr reports:$/ do |report|
   @last_stderr.should == report
 end
@@ -57,11 +53,7 @@ Then /^it reports the error ['"](.*)['"]$/ do |string|
 end
 
 Then /^it reports a parsing error$/ do
-  if RUBY_VERSION < "1.9.3"
-    @last_stderr.chomp.should match /Racc::ParseError/
-  else
-    @last_stderr.chomp.should match /RipperRubyParser::SyntaxError/
-  end
+  @last_stderr.chomp.should match(/Racc::ParseError/)
 end
 
 Then /^it reports the current version$/ do

data/lib/reek/core/code_parser.rb

@@ -57,7 +57,7 @@ module Reek
       end
 
       def process_block(exp)
-        @element.count_statements(CodeParser.count_statements(exp))
+        @element.count_statements(CodeParser.count_statements(exp[1..-1]))
         process_default(exp)
       end
 
@@ -110,7 +110,7 @@ module Reek
       end
 
       def process_when(exp)
-        count_clause(exp[2])
+        @element.count_statements(CodeParser.count_statements(exp[2..-1].compact))
         process_default(exp)
       end
 
@@ -133,8 +133,7 @@ module Reek
         end
       end
 
-      def self.count_statements(exp)
-        stmts = exp[1..-1]
+      def self.count_statements(stmts)
         ignore = 0
         ignore += 1 if stmts[1] == s(:nil)
         stmts.length - ignore
@@ -145,6 +144,7 @@ module Reek
       def handle_context(klass, type, exp)
         scope = klass.new(@element, exp)
         push(scope) do
+          @element.count_statements(CodeParser.count_statements(exp.body))
           process_default(exp)
           check_smells(type)
         end