reek 1.2.13 → 1.3

data/spec/reek/smells/unused_parameters_spec.rb

@@ -0,0 +1,47 @@
+
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'unused_parameters')
+require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+
+include Reek
+include Reek::Smells
+
+describe UnusedParameters do
+
+  context 'for methods' do
+
+    it 'should report nothing for no parameters' do
+      'def simple; true end'.should_not smell_of(UnusedParameters)
+    end
+
+    it 'should report nothing for used parameter' do
+      'def simple(sum); sum end'.should_not smell_of(UnusedParameters)
+    end
+
+    it 'should report for 1 used and 2 unused parameter' do
+      src = 'def simple(num,sum,denum); sum end'
+      src.should smell_of(UnusedParameters,
+                          {UnusedParameters::PARAMETER_KEY => 'num'},
+                          {UnusedParameters::PARAMETER_KEY => 'denum'})
+    end
+
+    it 'should report for 3 used and 1 unused parameter' do
+      src = 'def simple(num,sum,denum,quotient); num + denum + sum end'
+      src.should smell_of(UnusedParameters,
+                          {UnusedParameters::PARAMETER_KEY => 'quotient'})
+    end
+
+    it 'should report nothing for used splatted parameter' do
+      'def simple(*sum); sum end'.should_not smell_of(UnusedParameters)
+    end
+
+    it 'should report nothing for unused anonymous parameter' do
+      'def simple(_); end'.should_not smell_of(UnusedParameters)
+    end
+
+    it 'should report nothing for unused anonymous splatted parameter' do
+      'def simple(*); end'.should_not smell_of(UnusedParameters)
+    end
+
+  end
+end

data/spec/reek/smells/utility_function_spec.rb

@@ -29,13 +29,13 @@ describe UtilityFunction do
       @detector.examine_context(ctx).should be_empty
     end
     it 'does not report literal' do
-      'def simple(arga) 3; end'.should_not reek
+      'def simple() 3; end'.should_not reek
     end
     it 'does not report instance variable reference' do
-      'def simple(arga) @yellow end'.should_not reek
+      'def simple() @yellow end'.should_not reek
     end
     it 'does not report vcall' do
-      'def simple(arga) y end'.should_not reek
+      'def simple() y end'.should_not reek
     end
     it 'does not report references to self' do
       'def into; self; end'.should_not reek

data/spec/reek/source/tree_dresser_spec.rb

@@ -44,8 +44,8 @@ describe SexpExtensions::DefnNode do
       @node = s(:defn, :hello, s(:args))
       @node.extend(SexpExtensions::DefnNode)
     end
-    it 'has no parameters' do
-      @node.parameters.should == s(:args)
+    it 'has no arg names' do
+      @node.arg_names.should == s()
     end
     it 'has no parameter names' do
       @node.parameter_names.should == s()
@@ -63,8 +63,8 @@ describe SexpExtensions::DefnNode do
       @node = s(:defn, :hello, s(:args, :param))
       @node.extend(SexpExtensions::DefnNode)
     end
-    it 'has 1 parameter' do
-      @node.parameters.should == s(:args, :param)
+    it 'has 1 arg name' do
+      @node.arg_names.should == s(:param)
     end
     it 'has 1 parameter name' do
       @node.parameter_names.should == s(:param)
@@ -82,10 +82,10 @@ describe SexpExtensions::DefnNode do
       @node = s(:defn, :hello, s(:args, :param, :"&blk"))
       @node.extend(SexpExtensions::DefnNode)
     end
-    it 'has 1 parameter' do
-      @node.parameters.should == s(:args, :param, :"&blk")
+    it 'has 1 arg name' do
+      @node.arg_names.should == s(:param)
     end
-    it 'has 1 parameter name' do
+    it 'has 2 parameter names' do
       @node.parameter_names.should == s(:param, :"&blk")
     end
     it 'includes outer scope in its full name' do
@@ -98,11 +98,11 @@ describe SexpExtensions::DefnNode do
 
   context 'with 1 defaulted parameter' do
     before :each do
-      @node = s(:defn, :hello, s(:args, :param, s(:block, s(:lasgn, :param, s(:array)))))
+      @node = s(:defn, :hello, s(:args, s(:lasgn, :param, s(:array))))
       @node.extend(SexpExtensions::DefnNode)
     end
-    it 'has 1 parameter' do
-      @node.parameters.should == s(:args, :param)
+    it 'has 1 arg name' do
+      @node.arg_names.should == s(:param)
     end
     it 'has 1 parameter name' do
       @node.parameter_names.should == s(:param)
@@ -114,6 +114,22 @@ describe SexpExtensions::DefnNode do
       @node.full_name('').should == 'hello'
     end
   end
+
+  context 'with a body with 2 statements' do
+    before :each do
+      @node = s(:defn, :hello, s(:args), s(:first), s(:second))
+      @node.extend(SexpExtensions::DefnNode)
+    end
+
+    it 'has 2 body statements' do
+      @node.body.should == s(s(:first), s(:second))
+    end
+
+    it 'has a body extended with SexpNode' do
+      b = @node.body
+      (class << b; self; end).ancestors.first.should == SexpNode
+    end
+  end
 end
 
 describe SexpExtensions::DefsNode do
@@ -122,8 +138,8 @@ describe SexpExtensions::DefsNode do
       @node = s(:defs, :obj, :hello, s(:args))
       @node.extend(SexpExtensions::DefsNode)
     end
-    it 'has no parameters' do
-      @node.parameters.should == s(:args)
+    it 'has no arg names' do
+      @node.arg_names.should == s()
     end
     it 'has no parameter names' do
       @node.parameter_names.should == s()
@@ -141,8 +157,8 @@ describe SexpExtensions::DefsNode do
       @node = s(:defs, :obj, :hello, s(:args, :param))
       @node.extend(SexpExtensions::DefsNode)
     end
-    it 'has 1 parameter' do
-      @node.parameters.should == s(:args, :param)
+    it 'has 1 arg name' do
+      @node.arg_names.should == s(:param)
     end
     it 'has 1 parameter name' do
       @node.parameter_names.should == s(:param)
@@ -160,10 +176,10 @@ describe SexpExtensions::DefsNode do
       @node = s(:defs, :obj, :hello, s(:args, :param, :"&blk"))
       @node.extend(SexpExtensions::DefsNode)
     end
-    it 'has 1 parameter' do
-      @node.parameters.should == s(:args, :param, :"&blk")
+    it 'has 1 arg name' do
+      @node.arg_names.should == s(:param)
     end
-    it 'has 1 parameter name' do
+    it 'has 2 parameter names' do
       @node.parameter_names.should == s(:param, :"&blk")
     end
     it 'includes outer scope in its full name' do
@@ -176,11 +192,11 @@ describe SexpExtensions::DefsNode do
 
   context 'with 1 defaulted parameter' do
     before :each do
-      @node = s(:defs, :obj, :hello, s(:args, :param, s(:block, s(:lasgn, :param, s(:array)))))
+      @node = s(:defs, :obj, :hello, s(:args, s(:lasgn, :param, s(:array))))
       @node.extend(SexpExtensions::DefsNode)
     end
-    it 'has 1 parameter' do
-      @node.parameters.should == s(:args, :param)
+    it 'has 1 arg name' do
+      @node.arg_names.should == s(:param)
     end
     it 'has 1 parameter name' do
       @node.parameter_names.should == s(:param)
@@ -192,17 +208,62 @@ describe SexpExtensions::DefsNode do
       @node.full_name('').should == 'obj.hello'
     end
   end
+
+  context 'with a body with 2 statements' do
+    before :each do
+      @node = s(:defs, s(:self), :hello, s(:args), s(:first), s(:second))
+      @node.extend(SexpExtensions::DefsNode)
+    end
+
+    it 'has 2 body statements' do
+      @node.body.should == s(s(:first), s(:second))
+    end
+
+    it 'has a body extended with SexpNode' do
+      b = @node.body
+      (class << b; self; end).ancestors.first.should == SexpNode
+    end
+  end
+end
+
+describe SexpExtensions::CallNode do
+  context 'with no parameters' do
+    before :each do
+      @node = s(:call, nil, :hello)
+      @node.extend(SexpExtensions::CallNode)
+    end
+    it 'has no parameter names' do
+      @node.parameter_names.should == nil
+    end
+  end
+
+  context 'with 1 literal parameter' do
+    before :each do
+      @node = s(:call, nil, :hello, s(:lit, :param))
+      @node.extend(SexpExtensions::CallNode)
+    end
+    it 'has 1 argument name' do
+      @node.arg_names.should == [:param]
+    end
+  end
+
+  context 'with 2 literal parameters' do
+    before :each do
+      @node = s(:call, nil, :hello, s(:lit, :x), s(:lit, :y))
+      @node.extend(SexpExtensions::CallNode)
+    end
+    it 'has 2 argument names' do
+      @node.arg_names.should == [:x, :y]
+    end
+  end
 end
 
 describe SexpExtensions::IterNode do
   context 'with no parameters' do
     before :each do
-      @node = s(:iter, s(), nil, s())
+      @node = s(:iter, s(), s(:args), s())
       @node.extend(SexpExtensions::IterNode)
     end
-    it 'has no parameters' do
-      @node.parameters.should == []
-    end
     it 'has no parameter names' do
       @node.parameter_names.should == []
     end
@@ -210,12 +271,9 @@ describe SexpExtensions::IterNode do
 
   context 'with 1 parameter' do
     before :each do
-      @node = s(:iter, s(), s(:lasgn, :param), s())
+      @node = s(:iter, s(), s(:args, :param), s())
       @node.extend(SexpExtensions::IterNode)
     end
-    it 'has 1 parameter' do
-      @node.parameters.should == s(:lasgn, :param)
-    end
     it 'has 1 parameter name' do
       @node.parameter_names.should == s(:param)
     end
@@ -223,13 +281,10 @@ describe SexpExtensions::IterNode do
 
   context 'with 2 parameters' do
     before :each do
-      @node = s(:iter, s(), s(:masgn, s(:array, s(:lasgn, :x), s(:lasgn, :y))), s())
+      @node = s(:iter, s(), s(:args, :x, :y), s())
       @node.extend(SexpExtensions::IterNode)
     end
-    it 'has 1 parameter' do
-      @node.parameters.should == s(:masgn, s(:array, s(:lasgn, :x), s(:lasgn, :y)))
-    end
-    it 'has 1 parameter name' do
+    it 'has 2 parameter names' do
       @node.parameter_names.should == [:x, :y]
     end
   end

metadata

@@ -1,13 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: reek
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 9
   prerelease: 
   segments: 
   - 1
-  - 2
-  - 13
-  version: 1.2.13
+  - 3
+  version: "1.3"
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -17,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-26 00:00:00 Z
+date: 2013-01-19 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   prerelease: false
@@ -27,27 +26,26 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 3
+        hash: 15
         segments: 
-        - 2
+        - 3
         - 0
-        version: "2.0"
+        - 4
+        version: 3.0.4
   requirement: *id001
   type: :runtime
 - !ruby/object:Gem::Dependency 
   prerelease: false
-  name: ripper_ruby_parser
+  name: sexp_processor
   version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version 
-        hash: 17
+        hash: 3
         segments: 
         - 0
-        - 0
-        - 7
-        version: 0.0.7
+        version: "0"
   requirement: *id002
   type: :runtime
 - !ruby/object:Gem::Dependency 
@@ -58,33 +56,18 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 21
+        hash: 15
         segments: 
-        - 1
         - 2
-        - 5
-        version: 1.2.5
-  requirement: *id003
-  type: :runtime
-- !ruby/object:Gem::Dependency 
-  prerelease: false
-  name: sexp_processor
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
         - 0
-        version: "3.0"
-  requirement: *id004
+        - 0
+        version: 2.0.0
+  requirement: *id003
   type: :runtime
 - !ruby/object:Gem::Dependency 
   prerelease: false
   name: bundler
-  version_requirements: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -94,12 +77,12 @@ dependencies:
         - 1
         - 1
         version: "1.1"
-  requirement: *id005
+  requirement: *id004
   type: :development
 - !ruby/object:Gem::Dependency 
   prerelease: false
   name: rake
-  version_requirements: &id006 !ruby/object:Gem::Requirement 
+  version_requirements: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -108,12 +91,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  requirement: *id006
+  requirement: *id005
   type: :development
 - !ruby/object:Gem::Dependency 
   prerelease: false
   name: cucumber
-  version_requirements: &id007 !ruby/object:Gem::Requirement 
+  version_requirements: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -122,12 +105,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  requirement: *id007
+  requirement: *id006
   type: :development
 - !ruby/object:Gem::Dependency 
   prerelease: false
   name: rspec
-  version_requirements: &id008 !ruby/object:Gem::Requirement 
+  version_requirements: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -137,6 +120,20 @@ dependencies:
         - 2
         - 12
         version: "2.12"
+  requirement: *id007
+  type: :development
+- !ruby/object:Gem::Dependency 
+  prerelease: false
+  name: yard
+  version_requirements: &id008 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   requirement: *id008
   type: :development
 description: |
@@ -190,6 +187,7 @@ files:
 - lib/reek/smells/duplication.rb
 - lib/reek/smells/boolean_parameter.rb
 - lib/reek/smells/uncommunicative_parameter_name.rb
+- lib/reek/smells/unused_parameters.rb
 - lib/reek/smells/long_method.rb
 - lib/reek/smells/control_couple.rb
 - lib/reek/smells/long_yield_list.rb
@@ -251,6 +249,7 @@ files:
 - spec/reek/smells/class_variable_spec.rb
 - spec/reek/smells/long_yield_list_spec.rb
 - spec/reek/smells/control_couple_spec.rb
+- spec/reek/smells/unused_parameters_spec.rb
 - spec/reek/smells/uncommunicative_parameter_name_spec.rb
 - spec/reek/smells/long_parameter_list_spec.rb
 - spec/reek/smells/attribute_spec.rb
@@ -365,3 +364,4 @@ specification_version: 3
 summary: Code smell detector for Ruby
 test_files: []
 
+has_rdoc: