reek 6.0.3 → 6.1.0

data/features/reports/yaml.feature

@@ -1,52 +0,0 @@
-Feature: Report smells using simple YAML layout
-  In order to parse Reek's output simply and consistently, simply
-  output a list of smells in Yaml.
-
-  Scenario: output is empty when there are no smells
-    Given a directory called 'clean' containing two clean files
-    When I run reek --format yaml clean
-    Then it succeeds
-    And it reports this yaml:
-    """
-    --- []
-    """
-
-  Scenario: Indicate smells and print them as yaml when using files
-    Given the smelly file 'smelly.rb'
-    When I run reek --format yaml smelly.rb
-    Then the exit status indicates smells
-    And it reports this yaml:
-      """
-      ---
-      - context: Smelly#x
-        lines:
-        - 4
-        message: has the name 'x'
-        smell_type: UncommunicativeMethodName
-        source: smelly.rb
-        name: x
-        documentation_link: https://github.com/troessner/reek/blob/v6.0.3/docs/Uncommunicative-Method-Name.md
-      - context: Smelly#x
-        lines:
-        - 5
-        message: has the variable name 'y'
-        smell_type: UncommunicativeVariableName
-        source: smelly.rb
-        name: y
-        documentation_link: https://github.com/troessner/reek/blob/v6.0.3/docs/Uncommunicative-Variable-Name.md
-      """
-
-  Scenario: Indicate smells and print them as yaml when using STDIN
-    When I pass "class Turn; end" to reek --format yaml
-    Then the exit status indicates smells
-    And it reports this yaml:
-      """
-      ---
-      - smell_type: IrresponsibleModule
-        source: "STDIN"
-        context: Turn
-        lines:
-        - 1
-        message: has no descriptive comment
-        documentation_link: https://github.com/troessner/reek/blob/v6.0.3/docs/Irresponsible-Module.md
-      """

data/features/rspec_matcher.feature

@@ -1,41 +0,0 @@
-Feature: Use reek_of matcher
-  As a developer
-  In order to check code quality as part of my spec suite
-  I want to assert that my code doesn't smell
-
-  Background:
-    Given the smelly file 'smelly.rb'
-    And a file "reek_spec.rb" with:
-    """
-    require 'reek'
-    require 'reek/spec'
-
-    describe 'smelly.rb' do
-      it 'is clean' do
-        expect(Pathname.new('smelly.rb')).not_to reek
-      end
-    end
-    """
-
-  Scenario: Failing on a smelly file
-    When I run `rspec reek_spec.rb`
-    Then stdout should contain:
-    """
-    Failure/Error: expect(Pathname.new('smelly.rb')).not_to reek
-    """
-
-  Scenario: Masking smells with a configuration file
-    Given a file named ".reek.yml" with:
-      """
-      ---
-      detectors:
-        UncommunicativeMethodName:
-          enabled: false
-        UncommunicativeVariableName:
-          enabled: false
-      """
-    When I run `rspec reek_spec.rb`
-    Then stdout should contain:
-    """
-    1 example, 0 failures
-    """

data/features/samples.feature

@@ -1,305 +0,0 @@
-Feature: Basic smell detection
-  In order to write better software
-  As a developer
-  I want to detect the smells in my Ruby code
-
-  Scenario: Correct smells from inline.rb
-    Given the smelly file 'inline.rb'
-    And the smelly file 'optparse.rb'
-    And the smelly file 'redcloth.rb'
-    When I run reek --no-line-numbers inline.rb optparse.rb redcloth.rb
-    Then the exit status indicates smells
-    And it reports:
-    """
-    inline.rb -- 51 warnings:
-      BooleanParameter: Inline::C#parse_signature has boolean parameter 'raw'
-      ClassVariable: Inline declares the class variable '@@directory'
-      ClassVariable: Inline declares the class variable '@@rootdir'
-      ClassVariable: Inline::C declares the class variable '@@type_map'
-      ControlParameter: Inline::C#parse_signature is controlled by argument 'raw'
-      DataClump: Inline::C takes parameters ['options', 'src'] to 5 methods
-      DuplicateMethodCall: Inline#self.rootdir calls 'env.nil?' 2 times
-      DuplicateMethodCall: Inline::C#build calls '$? != 0' 2 times
-      DuplicateMethodCall: Inline::C#build calls 'Inline.directory' 5 times
-      DuplicateMethodCall: Inline::C#build calls 'io.puts "#endif"' 2 times
-      DuplicateMethodCall: Inline::C#build calls 'io.puts "#ifdef __cplusplus"' 2 times
-      DuplicateMethodCall: Inline::C#build calls 'io.puts' 6 times
-      DuplicateMethodCall: Inline::C#build calls 'warn "Output:\n#{result}"' 2 times
-      DuplicateMethodCall: Inline::C#crap_for_windoze calls 'Config::CONFIG['libdir']' 2 times
-      DuplicateMethodCall: Inline::C#generate calls 'result.sub!(/\A\n/, '')' 2 times
-      DuplicateMethodCall: Inline::C#generate calls 'signature['args']' 2 times
-      DuplicateMethodCall: Inline::C#generate calls 'signature['args'].map' 2 times
-      DuplicateMethodCall: Inline::C#initialize calls 'stack.empty?' 2 times
-      DuplicateMethodCall: Module#inline calls 'Inline.const_get(lang)' 2 times
-      DuplicateMethodCall: Module#inline calls 'options[:testing]' 2 times
-      InstanceVariableAssumption: Inline::C assumes too much for instance variable '@module_name'
-      InstanceVariableAssumption: Inline::C assumes too much for instance variable '@so_name'
-      InstanceVariableAssumption: Inline::C assumes too much for instance variable '@types'
-      IrresponsibleModule: CompilationError has no descriptive comment
-      IrresponsibleModule: Dir has no descriptive comment
-      IrresponsibleModule: File has no descriptive comment
-      IrresponsibleModule: Module has no descriptive comment
-      NestedIterators: Inline::C#build contains iterators nested 2 deep
-      NilCheck: Inline#self.rootdir performs a nil-check
-      RepeatedConditional: Inline::C tests '$DEBUG' at least 7 times
-      RepeatedConditional: Inline::C tests '$TESTING' at least 4 times
-      RepeatedConditional: Inline::C tests '@@type_map.has_key? type' at least 3 times
-      TooManyConstants: Inline has 6 constants
-      TooManyInstanceVariables: Inline::C has at least 13 instance variables
-      TooManyMethods: Inline::C has at least 25 methods
-      TooManyStatements: File#self.write_with_backup has approx 6 statements
-      TooManyStatements: Inline#self.rootdir has approx 8 statements
-      TooManyStatements: Inline::C#build has approx 63 statements
-      TooManyStatements: Inline::C#generate has approx 35 statements
-      TooManyStatements: Inline::C#module_name has approx 7 statements
-      TooManyStatements: Inline::C#parse_signature has approx 16 statements
-      TooManyStatements: Module#inline has approx 12 statements
-      UncommunicativeMethodName: Inline::C#c has the name 'c'
-      UncommunicativeModuleName: Inline::C has the name 'C'
-      UncommunicativeVariableName: Inline::C#build has the variable name 'n'
-      UncommunicativeVariableName: Inline::C#build has the variable name 't'
-      UncommunicativeVariableName: Inline::C#module_name has the variable name 'm'
-      UncommunicativeVariableName: Inline::C#module_name has the variable name 'md5'
-      UncommunicativeVariableName: Inline::C#module_name has the variable name 'x'
-      UncommunicativeVariableName: Inline::C#parse_signature has the variable name 'x'
-      UtilityFunction: Inline::C#strip_comments doesn't depend on instance state (maybe move it to another class?)
-    optparse.rb -- 126 warnings:
-      Attribute: OptionParser#banner is a writable attribute
-      Attribute: OptionParser#default_argv is a writable attribute
-      Attribute: OptionParser#program_name is a writable attribute
-      Attribute: OptionParser#release is a writable attribute
-      Attribute: OptionParser#summary_indent is a writable attribute
-      Attribute: OptionParser#summary_width is a writable attribute
-      Attribute: OptionParser#version is a writable attribute
-      Attribute: OptionParser::ParseError#reason is a writable attribute
-      BooleanParameter: OptionParser#complete has boolean parameter 'icase'
-      BooleanParameter: OptionParser::Completion#complete has boolean parameter 'icase'
-      BooleanParameter: OptionParser::List#complete has boolean parameter 'icase'
-      ControlParameter: OptionParser#summarize is controlled by argument 'blk'
-      ControlParameter: OptionParser::Arguable#options= is controlled by argument 'opt'
-      ControlParameter: OptionParser::ParseError#set_option is controlled by argument 'eq'
-      DuplicateMethodCall: OptionParser#getopts calls 'result[opt] = false' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'default_style.guess(arg = a)' 4 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'long << (o = q.downcase)' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'notwice(NilClass, klass, 'type')' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'notwice(a ? Object : TrueClass, klass, 'type')' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'pattern.method(:convert)' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'pattern.method(:convert).to_proc' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'pattern.respond_to?(:convert)' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'q.downcase' 3 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'sdesc << "-#{q}"' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'search(:atype, FalseClass)' 2 times
-      DuplicateMethodCall: OptionParser#make_switch calls 'search(:atype, o)' 6 times
-      DuplicateMethodCall: OptionParser#order calls 'argv[0]' 2 times
-      DuplicateMethodCall: OptionParser#parse calls 'argv[0]' 2 times
-      DuplicateMethodCall: OptionParser#parse_in_order calls '$!.set_option(arg, true)' 2 times
-      DuplicateMethodCall: OptionParser#parse_in_order calls 'cb.call(val)' 2 times
-      DuplicateMethodCall: OptionParser#parse_in_order calls 'raise $!.set_option(arg, true)' 2 times
-      DuplicateMethodCall: OptionParser#parse_in_order calls 'raise(*exc)' 2 times
-      DuplicateMethodCall: OptionParser#parse_in_order calls 'setter.call(sw.switch_name, val)' 2 times
-      DuplicateMethodCall: OptionParser#parse_in_order calls 'sw.block' 2 times
-      DuplicateMethodCall: OptionParser#parse_in_order calls 'sw.switch_name' 2 times
-      DuplicateMethodCall: OptionParser#permute calls 'argv[0]' 2 times
-      DuplicateMethodCall: OptionParser::Completion#complete calls 'candidates.size' 2 times
-      DuplicateMethodCall: OptionParser::Completion#complete calls 'k.id2name' 2 times
-      DuplicateMethodCall: OptionParser::Switch#parse_arg calls 's.length' 2 times
-      DuplicateMethodCall: OptionParser::Switch#summarize calls 'indent + l' 2 times
-      DuplicateMethodCall: OptionParser::Switch#summarize calls 'left.collect {|s| s.length}' 2 times
-      DuplicateMethodCall: OptionParser::Switch#summarize calls 'left.collect {|s| s.length}.max' 2 times
-      DuplicateMethodCall: OptionParser::Switch#summarize calls 'left.collect {|s| s.length}.max.to_i' 2 times
-      DuplicateMethodCall: OptionParser::Switch#summarize calls 'left.collect' 2 times
-      DuplicateMethodCall: OptionParser::Switch#summarize calls 'left.shift' 2 times
-      DuplicateMethodCall: OptionParser::Switch#summarize calls 'left[-1]' 3 times
-      DuplicateMethodCall: OptionParser::Switch#summarize calls 's.length' 3 times
-      FeatureEnvy: OptionParser#order refers to 'argv' more than self (maybe move it to another class?)
-      FeatureEnvy: OptionParser#parse refers to 'argv' more than self (maybe move it to another class?)
-      FeatureEnvy: OptionParser#permute refers to 'argv' more than self (maybe move it to another class?)
-      FeatureEnvy: OptionParser::Completion#complete refers to 'candidates' more than self (maybe move it to another class?)
-      FeatureEnvy: OptionParser::List#accept refers to 'pat' more than self (maybe move it to another class?)
-      FeatureEnvy: OptionParser::List#add_banner refers to 'opt' more than self (maybe move it to another class?)
-      FeatureEnvy: OptionParser::List#summarize refers to 'opt' more than self (maybe move it to another class?)
-      InstanceVariableAssumption: OptionParser assumes too much for instance variable '@release'
-      InstanceVariableAssumption: OptionParser assumes too much for instance variable '@version'
-      LongParameterList: OptionParser#complete has 4 parameters
-      LongParameterList: OptionParser#summarize has 4 parameters
-      LongParameterList: OptionParser::List#complete has 4 parameters
-      LongParameterList: OptionParser::List#update has 5 parameters
-      LongParameterList: OptionParser::Switch#initialize has 7 parameters
-      LongParameterList: OptionParser::Switch#summarize has 5 parameters
-      ManualDispatch: OptionParser#make_switch manually dispatches method call
-      ManualDispatch: OptionParser::List#accept manually dispatches method call
-      ManualDispatch: OptionParser::List#add_banner manually dispatches method call
-      ManualDispatch: OptionParser::List#summarize manually dispatches method call
-      ModuleInitialize: OptionParser::Arguable has initialize method
-      NestedIterators: OptionParser#make_switch contains iterators nested 2 deep
-      NilCheck: OptionParser#make_switch performs a nil-check
-      NilCheck: OptionParser#self.inc performs a nil-check
-      RepeatedConditional: OptionParser tests 'a' at least 7 times
-      RepeatedConditional: OptionParser tests 'argv.size == 1 and Array === argv[0]' at least 3 times
-      RepeatedConditional: OptionParser tests 'default_pattern' at least 7 times
-      RepeatedConditional: OptionParser tests 'not_style' at least 3 times
-      RepeatedConditional: OptionParser tests 's' at least 7 times
-      SubclassedFromCoreClass: OptionParser::CompletingHash inherits from core class 'Hash'
-      SubclassedFromCoreClass: OptionParser::OptionMap inherits from core class 'Hash'
-      TooManyConstants: OptionParser has 16 constants
-      TooManyInstanceVariables: OptionParser has at least 6 instance variables
-      TooManyInstanceVariables: OptionParser::Switch has at least 7 instance variables
-      TooManyMethods: OptionParser has at least 42 methods
-      TooManyStatements: OptionParser#complete has approx 6 statements
-      TooManyStatements: OptionParser#getopts has approx 18 statements
-      TooManyStatements: OptionParser#load has approx 6 statements
-      TooManyStatements: OptionParser#make_switch has approx 72 statements
-      TooManyStatements: OptionParser#parse_in_order has approx 35 statements
-      TooManyStatements: OptionParser#permute! has approx 6 statements
-      TooManyStatements: OptionParser::Arguable#options has approx 6 statements
-      TooManyStatements: OptionParser::Completion#complete has approx 23 statements
-      TooManyStatements: OptionParser::List#update has approx 10 statements
-      TooManyStatements: OptionParser::Switch#parse_arg has approx 11 statements
-      TooManyStatements: OptionParser::Switch#self.guess has approx 6 statements
-      TooManyStatements: OptionParser::Switch#summarize has approx 28 statements
-      TooManyStatements: OptionParser::Switch::PlacedArgument#parse has approx 6 statements
-      UncommunicativeParameterName: OptionParser::List#accept has the parameter name 't'
-      UncommunicativeParameterName: OptionParser::List#reject has the parameter name 't'
-      UncommunicativeParameterName: OptionParser::Switch#self.incompatible_argument_styles has the parameter name 't'
-      UncommunicativeVariableName: OptionParser has the variable name 'f'
-      UncommunicativeVariableName: OptionParser has the variable name 'k'
-      UncommunicativeVariableName: OptionParser has the variable name 'o'
-      UncommunicativeVariableName: OptionParser has the variable name 's'
-      UncommunicativeVariableName: OptionParser has the variable name 'v'
-      UncommunicativeVariableName: OptionParser#load has the variable name 's'
-      UncommunicativeVariableName: OptionParser#make_switch has the variable name 'a'
-      UncommunicativeVariableName: OptionParser#make_switch has the variable name 'c'
-      UncommunicativeVariableName: OptionParser#make_switch has the variable name 'n'
-      UncommunicativeVariableName: OptionParser#make_switch has the variable name 'o'
-      UncommunicativeVariableName: OptionParser#make_switch has the variable name 'q'
-      UncommunicativeVariableName: OptionParser#make_switch has the variable name 's'
-      UncommunicativeVariableName: OptionParser#make_switch has the variable name 'v'
-      UncommunicativeVariableName: OptionParser#search has the variable name 'k'
-      UncommunicativeVariableName: OptionParser#summarize has the variable name 'l'
-      UncommunicativeVariableName: OptionParser#ver has the variable name 'v'
-      UncommunicativeVariableName: OptionParser::Completion#complete has the variable name 'k'
-      UncommunicativeVariableName: OptionParser::Completion#complete has the variable name 'v'
-      UncommunicativeVariableName: OptionParser::List#update has the variable name 'o'
-      UncommunicativeVariableName: OptionParser::Switch#add_banner has the variable name 's'
-      UncommunicativeVariableName: OptionParser::Switch#parse_arg has the variable name 'm'
-      UncommunicativeVariableName: OptionParser::Switch#parse_arg has the variable name 's'
-      UncommunicativeVariableName: OptionParser::Switch#self.guess has the variable name 't'
-      UncommunicativeVariableName: OptionParser::Switch#summarize has the variable name 'l'
-      UncommunicativeVariableName: OptionParser::Switch#summarize has the variable name 'r'
-      UncommunicativeVariableName: OptionParser::Switch#summarize has the variable name 's'
-      UnusedParameters: OptionParser::Completion#convert has unused parameter 'opt'
-      UnusedParameters: OptionParser::Switch::NoArgument#parse has unused parameter 'argv'
-      UnusedParameters: OptionParser::Switch::OptionalArgument#parse has unused parameter 'argv'
-    redcloth.rb -- 110 warnings:
-      Attribute: RedCloth#filter_html is a writable attribute
-      Attribute: RedCloth#filter_styles is a writable attribute
-      Attribute: RedCloth#hard_breaks is a writable attribute
-      Attribute: RedCloth#lite_mode is a writable attribute
-      Attribute: RedCloth#no_span_caps is a writable attribute
-      Attribute: RedCloth#rules is a writable attribute
-      BooleanParameter: RedCloth#blocks has boolean parameter 'deep_code'
-      ControlParameter: RedCloth#blocks is controlled by argument 'deep_code'
-      ControlParameter: RedCloth#htmlesc is controlled by argument 'mode'
-      ControlParameter: RedCloth#lT is controlled by argument 'text'
-      ControlParameter: RedCloth#pba is controlled by argument 'element'
-      DataClump: RedCloth takes parameters ['atts', 'cite', 'content', 'tag'] to 3 methods
-      DuplicateMethodCall: RedCloth#block_textile_lists calls 'depth.last' 5 times
-      DuplicateMethodCall: RedCloth#block_textile_lists calls 'depth.last.length' 2 times
-      DuplicateMethodCall: RedCloth#block_textile_lists calls 'depth[i]' 2 times
-      DuplicateMethodCall: RedCloth#block_textile_lists calls 'line_id - 1' 2 times
-      DuplicateMethodCall: RedCloth#block_textile_lists calls 'lines[line_id - 1]' 2 times
-      DuplicateMethodCall: RedCloth#block_textile_lists calls 'tl.length' 3 times
-      DuplicateMethodCall: RedCloth#clean_html calls 'tags[tag]' 2 times
-      DuplicateMethodCall: RedCloth#pba calls '$1.length' 2 times
-      DuplicateMethodCall: RedCloth#rip_offtags calls '@pre_list.last << line' 2 times
-      DuplicateMethodCall: RedCloth#rip_offtags calls '@pre_list.last' 2 times
-      DuplicateMethodCall: RedCloth#rip_offtags calls 'codepre - used_offtags.length > 0' 2 times
-      DuplicateMethodCall: RedCloth#rip_offtags calls 'codepre - used_offtags.length' 2 times
-      DuplicateMethodCall: RedCloth#rip_offtags calls 'codepre.zero?' 2 times
-      DuplicateMethodCall: RedCloth#rip_offtags calls 'htmlesc( line, :NoQuotes )' 2 times
-      DuplicateMethodCall: RedCloth#rip_offtags calls 'used_offtags.length' 2 times
-      DuplicateMethodCall: RedCloth#rip_offtags calls 'used_offtags['notextile']' 3 times
-      FeatureEnvy: RedCloth#block_markdown_atx refers to 'text' more than self (maybe move it to another class?)
-      FeatureEnvy: RedCloth#block_markdown_setext refers to 'text' more than self (maybe move it to another class?)
-      FeatureEnvy: RedCloth#block_textile_lists refers to 'depth' more than self (maybe move it to another class?)
-      FeatureEnvy: RedCloth#blocks refers to 'blk' more than self (maybe move it to another class?)
-      FeatureEnvy: RedCloth#clean_white_space refers to 'text' more than self (maybe move it to another class?)
-      FeatureEnvy: RedCloth#pba refers to 'text' more than self (maybe move it to another class?)
-      InstanceVariableAssumption: RedCloth assumes too much for instance variable '@lite_mode'
-      InstanceVariableAssumption: RedCloth assumes too much for instance variable '@pre_list'
-      InstanceVariableAssumption: RedCloth assumes too much for instance variable '@rules'
-      InstanceVariableAssumption: RedCloth assumes too much for instance variable '@shelf'
-      InstanceVariableAssumption: RedCloth assumes too much for instance variable '@urlrefs'
-      LongParameterList: RedCloth#textile_bq has 4 parameters
-      LongParameterList: RedCloth#textile_fn_ has 5 parameters
-      LongParameterList: RedCloth#textile_p has 4 parameters
-      ManualDispatch: RedCloth#block_textile_prefix manually dispatches method call
-      NestedIterators: RedCloth#block_textile_lists contains iterators nested 3 deep
-      NestedIterators: RedCloth#block_textile_table contains iterators nested 2 deep
-      NestedIterators: RedCloth#block_textile_table contains iterators nested 3 deep
-      NestedIterators: RedCloth#blocks contains iterators nested 2 deep
-      NestedIterators: RedCloth#clean_html contains iterators nested 2 deep
-      NestedIterators: RedCloth#inline contains iterators nested 2 deep
-      NestedIterators: RedCloth#inline_textile_span contains iterators nested 2 deep
-      RepeatedConditional: RedCloth tests 'atts' at least 6 times
-      RepeatedConditional: RedCloth tests 'codepre.zero?' at least 3 times
-      RepeatedConditional: RedCloth tests 'href' at least 3 times
-      RepeatedConditional: RedCloth tests 'title' at least 4 times
-      SubclassedFromCoreClass: RedCloth inherits from core class 'String'
-      TooManyConstants: RedCloth has 45 constants
-      TooManyMethods: RedCloth has at least 44 methods
-      TooManyStatements: RedCloth#block_markdown_bq has approx 6 statements
-      TooManyStatements: RedCloth#block_textile_lists has approx 21 statements
-      TooManyStatements: RedCloth#block_textile_table has approx 19 statements
-      TooManyStatements: RedCloth#blocks has approx 19 statements
-      TooManyStatements: RedCloth#clean_html has approx 15 statements
-      TooManyStatements: RedCloth#clean_white_space has approx 7 statements
-      TooManyStatements: RedCloth#glyphs_textile has approx 10 statements
-      TooManyStatements: RedCloth#inline_markdown_link has approx 6 statements
-      TooManyStatements: RedCloth#inline_markdown_reflink has approx 8 statements
-      TooManyStatements: RedCloth#inline_textile_image has approx 17 statements
-      TooManyStatements: RedCloth#inline_textile_link has approx 9 statements
-      TooManyStatements: RedCloth#inline_textile_span has approx 9 statements
-      TooManyStatements: RedCloth#pba has approx 21 statements
-      TooManyStatements: RedCloth#rip_offtags has approx 18 statements
-      TooManyStatements: RedCloth#to_html has approx 26 statements
-      UncommunicativeMethodName: RedCloth#lT has the name 'lT'
-      UncommunicativeParameterName: RedCloth#textile_popup_help has the parameter name 'windowH'
-      UncommunicativeParameterName: RedCloth#textile_popup_help has the parameter name 'windowW'
-      UncommunicativeVariableName: RedCloth has the variable name 'a'
-      UncommunicativeVariableName: RedCloth has the variable name 'b'
-      UncommunicativeVariableName: RedCloth#block_textile_lists has the variable name 'i'
-      UncommunicativeVariableName: RedCloth#block_textile_lists has the variable name 'v'
-      UncommunicativeVariableName: RedCloth#block_textile_table has the variable name 'x'
-      UncommunicativeVariableName: RedCloth#clean_html has the variable name 'q'
-      UncommunicativeVariableName: RedCloth#clean_html has the variable name 'q2'
-      UncommunicativeVariableName: RedCloth#initialize has the variable name 'r'
-      UncommunicativeVariableName: RedCloth#inline_markdown_link has the variable name 'm'
-      UncommunicativeVariableName: RedCloth#inline_markdown_reflink has the variable name 'm'
-      UncommunicativeVariableName: RedCloth#inline_textile_code has the variable name 'm'
-      UncommunicativeVariableName: RedCloth#inline_textile_image has the variable name 'href_a1'
-      UncommunicativeVariableName: RedCloth#inline_textile_image has the variable name 'href_a2'
-      UncommunicativeVariableName: RedCloth#inline_textile_image has the variable name 'm'
-      UncommunicativeVariableName: RedCloth#inline_textile_link has the variable name 'm'
-      UncommunicativeVariableName: RedCloth#inline_textile_span has the variable name 'm'
-      UncommunicativeVariableName: RedCloth#refs_markdown has the variable name 'm'
-      UncommunicativeVariableName: RedCloth#refs_textile has the variable name 'm'
-      UncommunicativeVariableName: RedCloth#retrieve has the variable name 'i'
-      UncommunicativeVariableName: RedCloth#retrieve has the variable name 'r'
-      UnusedParameters: RedCloth#block_markdown_lists has unused parameter 'text'
-      UnusedParameters: RedCloth#textile_bq has unused parameter 'tag'
-      UnusedParameters: RedCloth#textile_fn_ has unused parameter 'cite'
-      UnusedParameters: RedCloth#textile_fn_ has unused parameter 'tag'
-      UnusedParameters: RedCloth#textile_p has unused parameter 'cite'
-      UtilityFunction: RedCloth#block_markdown_rule doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#clean_html doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#flush_left doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#footnote_ref doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#h_align doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#htmlesc doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#incoming_entities doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#lT doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#no_textile doesn't depend on instance state (maybe move it to another class?)
-      UtilityFunction: RedCloth#v_align doesn't depend on instance state (maybe move it to another class?)
-    287 total warnings
-    """

data/features/step_definitions/.rubocop.yml

@@ -1,5 +0,0 @@
-inherit_from: ../../.rubocop.yml
-
-# Allow common When <regexp> syntax
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false

data/features/step_definitions/reek_steps.rb

@@ -1,102 +0,0 @@
-When /^I run reek (.*)$/ do |args|
-  reek(args)
-end
-
-When 'I run the code climate reek runner' do
-  run_command_and_stop 'code_climate_reek'
-end
-
-When /^I pass "([^"]*)" to reek *(.*)$/ do |stdin, args|
-  reek_with_pipe(stdin, args)
-end
-
-When /^I pass a stdin to reek *(.*) with:$/ do |args, stdin|
-  reek_with_pipe(stdin, args)
-end
-
-Then /^it reports nothing$/ do
-  expect(last_command_started).to have_output_on_stdout('')
-end
-
-Then /^there is no output on stdout$/ do
-  expect(last_command_started).to have_output_on_stdout('')
-end
-
-Then /^stdout includes "(.*)"$/ do |text|
-  expect(last_command_started).to have_output_on_stdout(/#{Regexp.escape(text)}/)
-end
-
-Then /^it succeeds$/ do
-  success = Reek::CLI::Status::DEFAULT_SUCCESS_EXIT_CODE
-  expect(last_command_started).to have_exit_status(success)
-end
-
-Then /^the exit status indicates an error$/ do
-  error = Reek::CLI::Status::DEFAULT_ERROR_EXIT_CODE
-  expect(last_command_started).to have_exit_status(error)
-end
-
-Then /^the exit status indicates smells$/ do
-  smells = Reek::CLI::Status::DEFAULT_FAILURE_EXIT_CODE
-  expect(last_command_started).to have_exit_status(smells)
-end
-
-Then(/^the exit status is (\d+)$/) do |status|
-  expect(last_command_started).to have_exit_status(status.to_i)
-end
-
-Then /^it reports:$/ do |report|
-  expect(last_command_started).to have_output_on_stdout(report.gsub('\n', "\n"))
-end
-
-Then /^it reports this yaml:$/ do |expected_yaml|
-  expected_warnings = YAML.safe_load(expected_yaml.chomp)
-  actual_warnings = YAML.safe_load(last_command_started.stdout)
-  expect(actual_warnings).to eq expected_warnings
-end
-
-Then /^it reports this JSON:$/ do |expected_json|
-  expected_warnings = JSON.parse(expected_json.chomp)
-  actual_warnings = JSON.parse(last_command_started.stdout)
-  expect(actual_warnings).to eq expected_warnings
-end
-
-Then /^stderr reports:$/ do |report|
-  expect(last_command_started).to have_output_on_stderr(report.chomp)
-end
-
-Then /^it reports no errors$/ do
-  expect(last_command_started).to have_output_on_stderr('')
-end
-
-Then /^it reports an error$/ do
-  expect(last_command_started.stderr).to_not be_empty
-end
-
-Then /^it reports the error ['"](.*)['"]$/ do |string|
-  expect(last_command_started).to have_output_on_stderr(/#{Regexp.escape(string)}/)
-end
-
-Then /^it reports a parsing error$/ do
-  expect(last_command_started).to have_output_on_stderr(/Parser::SyntaxError/)
-end
-
-Then /^it should indicate the line numbers of those smells$/ do
-  expect(last_command_started).to have_output(/\[.*\]:/)
-end
-
-Then /^it reports the current version$/ do
-  expect(last_command_started).to have_output("reek #{Reek::Version::STRING}")
-end
-
-Then /^it reports this Code Climate output:$/ do |expected_output|
-  expected_issues = expected_output.split('NULL_BYTE_CHARACTER').map do |issue|
-    JSON.parse(issue)
-  end
-
-  actual_issues = last_command_started.stdout.split("\0").map do |issue|
-    JSON.parse(issue)
-  end
-
-  expect(actual_issues).to eq(expected_issues)
-end

data/features/step_definitions/sample_file_steps.rb

@@ -1,63 +0,0 @@
-require_relative '../../samples/paths'
-
-Given(/^the smelly file '(.+)'$/) do |filename|
-  write_file(filename, SAMPLES_DIR.join('smelly_source').join(filename).read)
-end
-
-Given(/^the smelly file "(.+)" in the directory "(.+)"$/) do |filename, directory|
-  FileUtils.mkdir_p directory
-  write_file Pathname(directory).join(filename).to_s,
-             SAMPLES_DIR.join('smelly_source').join(filename).read
-end
-
-Given(/^the clean file "(.*)"$/) do |filename|
-  write_file(filename, CLEAN_FILE.read)
-end
-
-Given(/^a directory called 'clean' containing two clean files$/) do
-  contents = CLEAN_FILE.read
-
-  write_file('clean/clean_one.rb', contents)
-  write_file('clean/clean_two.rb', contents)
-end
-
-Given(/^a directory called 'mixed_files' containing some clean and smelly files$/) do
-  write_file('mixed_files/clean.rb', CLEAN_FILE.read)
-  write_file('mixed_files/dirty.rb', SMELLY_FILE.read)
-end
-
-Given(/^a directory called 'smelly' containing two smelly files$/) do
-  contents = SMELLY_FILE.read
-
-  write_file('smelly/dirty_one.rb', contents)
-  write_file('smelly/dirty_two.rb', contents)
-end
-
-Given(/^the smelly file '(.+)' in a subdirectory$/) do |filename|
-  contents = SAMPLES_DIR.join('smelly_source').join(filename).read
-
-  write_file("subdir/#{filename}", contents)
-end
-
-Given(/^a configuration file '(.+)'$/) do |filename|
-  write_file(filename, CONFIGURATION_DIR.join(filename).read)
-end
-
-Given(/^our default configuration file$/) do
-  default_configuration = File.read Reek::DEFAULT_SMELL_CONFIGURATION
-  write_file('defaults.reek.yml', default_configuration)
-end
-
-When(/^I run "reek (.*?)" in a subdirectory$/) do |args|
-  cd 'subdir'
-
-  reek(args)
-end
-
-Then(/^it does not report private or protected methods$/) do
-  # Pseudo step for feature clarity.
-end
-
-Given('with a configuration file that is further up in the directory tree') do
-  # Pseudo step for feature clarity. We have an empty .reek.yml in our root directory already.
-end

data/features/support/env.rb

@@ -1,33 +0,0 @@
-require_relative '../../lib/reek'
-require_relative '../../lib/reek/cli/application'
-require 'aruba/cucumber'
-
-begin
-  require 'pry-byebug'
-rescue LoadError # rubocop:disable Lint/SuppressedException
-end
-
-#
-# Provides runner methods used in the cucumber steps.
-#
-class ReekWorld
-  def reek(args)
-    run_command_and_stop("reek --no-color --no-documentation #{args}", fail_on_error: false)
-  end
-
-  def reek_with_pipe(stdin, args)
-    run_command "reek --no-color --no-documentation #{args}"
-    type(stdin)
-    close_input
-  end
-end
-
-World do
-  ReekWorld.new
-end
-
-Before do
-  Aruba.configure do |config|
-    config.exit_timeout = 30
-  end
-end