RubyGems - reek - Versions diffs - 6.0.2 → 6.1.4 - Mend - Supply Chain Defender

reek 6.0.2 → 6.1.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (247) hide show

checksums.yaml +4 -4
data/.github/dependabot.yml +13 -0
data/.github/workflows/ruby.yml +57 -0
data/.rubocop.yml +6 -4
data/.rubocop_todo.yml +6 -4
data/CHANGELOG.md +42 -0
data/CONTRIBUTING.md +4 -1
data/Dockerfile +1 -1
data/Gemfile +7 -7
data/README.md +2 -2
data/bin/code_climate_reek +2 -3
data/lib/reek/ast/ast_node_class_map.rb +1 -1
data/lib/reek/ast/node.rb +1 -1
data/lib/reek/ast/sexp_extensions/arguments.rb +20 -0
data/lib/reek/ast/sexp_extensions/case.rb +1 -1
data/lib/reek/ast/sexp_extensions/if.rb +1 -1
data/lib/reek/ast/sexp_extensions/send.rb +1 -1
data/lib/reek/cli/command/todo_list_command.rb +2 -2
data/lib/reek/cli/options.rb +6 -6
data/lib/reek/code_comment.rb +22 -17
data/lib/reek/configuration/configuration_file_finder.rb +2 -1
data/lib/reek/configuration/excluded_paths.rb +2 -1
data/lib/reek/context/code_context.rb +1 -1
data/lib/reek/context/module_context.rb +4 -0
data/lib/reek/context/refinement_context.rb +16 -0
data/lib/reek/context/send_context.rb +6 -0
data/lib/reek/context_builder.rb +17 -3
data/lib/reek/rake/task.rb +5 -5
data/lib/reek/report/code_climate/code_climate_configuration.yml +3 -3
data/lib/reek/report/code_climate/code_climate_formatter.rb +1 -3
data/lib/reek/smell_detectors/base_detector.rb +1 -1
data/lib/reek/smell_detectors/class_variable.rb +2 -2
data/lib/reek/smell_detectors/control_parameter_helpers/candidate.rb +6 -6
data/lib/reek/smell_detectors/duplicate_method_call.rb +5 -5
data/lib/reek/smell_detectors/unused_private_method.rb +1 -0
data/lib/reek/smell_warning.rb +1 -1
data/lib/reek/source/source_locator.rb +1 -3
data/lib/reek/spec/should_reek_of.rb +11 -9
data/lib/reek/spec.rb +1 -1
data/lib/reek/version.rb +2 -2
data/reek.gemspec +28 -25
metadata +13 -240
data/.travis.yml +0 -40
data/docs/API.md +0 -174
data/docs/Attribute.md +0 -39
data/docs/Basic-Smell-Options.md +0 -85
data/docs/Boolean-Parameter.md +0 -54
data/docs/Class-Variable.md +0 -40
data/docs/Code-Smells.md +0 -39
data/docs/Command-Line-Options.md +0 -119
data/docs/Control-Couple.md +0 -26
data/docs/Control-Parameter.md +0 -32
data/docs/Data-Clump.md +0 -46
data/docs/Duplicate-Method-Call.md +0 -264
data/docs/Feature-Envy.md +0 -93
data/docs/How-To-Write-New-Detectors.md +0 -132
data/docs/How-reek-works-internally.md +0 -114
data/docs/Instance-Variable-Assumption.md +0 -163
data/docs/Irresponsible-Module.md +0 -47
data/docs/Large-Class.md +0 -16
data/docs/Long-Parameter-List.md +0 -39
data/docs/Long-Yield-List.md +0 -37
data/docs/Manual-Dispatch.md +0 -30
data/docs/Missing-Safe-Method.md +0 -92
data/docs/Module-Initialize.md +0 -62
data/docs/Nested-Iterators.md +0 -59
data/docs/Nil-Check.md +0 -47
data/docs/RSpec-matchers.md +0 -129
data/docs/Rake-Task.md +0 -66
data/docs/Reek-4-to-Reek-5-migration.md +0 -188
data/docs/Reek-Driven-Development.md +0 -46
data/docs/Repeated-Conditional.md +0 -47
data/docs/Simulated-Polymorphism.md +0 -16
data/docs/Smell-Suppression.md +0 -96
data/docs/Style-Guide.md +0 -19
data/docs/Subclassed-From-Core-Class.md +0 -79
data/docs/Too-Many-Constants.md +0 -37
data/docs/Too-Many-Instance-Variables.md +0 -43
data/docs/Too-Many-Methods.md +0 -56
data/docs/Too-Many-Statements.md +0 -54
data/docs/Uncommunicative-Method-Name.md +0 -94
data/docs/Uncommunicative-Module-Name.md +0 -92
data/docs/Uncommunicative-Name.md +0 -18
data/docs/Uncommunicative-Parameter-Name.md +0 -90
data/docs/Uncommunicative-Variable-Name.md +0 -96
data/docs/Unused-Parameters.md +0 -28
data/docs/Unused-Private-Method.md +0 -101
data/docs/Utility-Function.md +0 -56
data/docs/Versioning-Policy.md +0 -7
data/docs/YAML-Reports.md +0 -93
data/docs/defaults.reek.yml +0 -129
data/docs/templates/default/docstring/html/public_api_marker.erb +0 -3
data/docs/templates/default/docstring/setup.rb +0 -37
data/docs/templates/default/fulldoc/html/css/common.css +0 -1
data/docs/yard_plugin.rb +0 -17
data/features/command_line_interface/basic_usage.feature +0 -15
data/features/command_line_interface/options.feature +0 -123
data/features/command_line_interface/show_progress.feature +0 -33
data/features/command_line_interface/smell_selection.feature +0 -15
data/features/command_line_interface/smells_count.feature +0 -38
data/features/command_line_interface/stdin.feature +0 -65
data/features/configuration_files/accept_setting.feature +0 -87
data/features/configuration_files/directory_specific_directives.feature +0 -274
data/features/configuration_files/exclude_directives.feature +0 -35
data/features/configuration_files/exclude_paths_directives.feature +0 -42
data/features/configuration_files/masking_smells.feature +0 -94
data/features/configuration_files/mix_accept_reject_setting.feature +0 -84
data/features/configuration_files/reject_setting.feature +0 -89
data/features/configuration_files/schema_validation.feature +0 -59
data/features/configuration_files/show_configuration_file.feature +0 -44
data/features/configuration_files/unused_private_method.feature +0 -68
data/features/configuration_loading.feature +0 -91
data/features/configuration_via_source_comments/erroneous_source_comments.feature +0 -68
data/features/configuration_via_source_comments/well_formed_source_comments.feature +0 -116
data/features/locales.feature +0 -32
data/features/programmatic_access.feature +0 -41
data/features/rake_task/rake_task.feature +0 -138
data/features/reports/codeclimate.feature +0 -59
data/features/reports/json.feature +0 -59
data/features/reports/reports.feature +0 -219
data/features/reports/yaml.feature +0 -52
data/features/rspec_matcher.feature +0 -41
data/features/samples.feature +0 -305
data/features/step_definitions/.rubocop.yml +0 -5
data/features/step_definitions/reek_steps.rb +0 -102
data/features/step_definitions/sample_file_steps.rb +0 -63
data/features/support/env.rb +0 -33
data/features/todo_list.feature +0 -108
data/samples/checkstyle.xml +0 -7
data/samples/clean_source/clean.rb +0 -6
data/samples/configuration/accepts_rejects_and_excludes_for_detectors.reek.yml +0 -29
data/samples/configuration/accepts_rejects_and_excludes_for_directory_directives.reek.yml +0 -30
data/samples/configuration/corrupt.reek +0 -1
data/samples/configuration/empty.reek +0 -0
data/samples/configuration/full_configuration.reek +0 -13
data/samples/configuration/full_mask.reek +0 -6
data/samples/configuration/home/home.reek.yml +0 -4
data/samples/configuration/partial_mask.reek +0 -4
data/samples/configuration/regular_configuration/.reek.yml +0 -4
data/samples/configuration/regular_configuration/empty_sub_directory/.gitignore +0 -0
data/samples/configuration/with_excluded_paths.reek +0 -5
data/samples/no_config_file/.keep +0 -0
data/samples/paths.rb +0 -5
data/samples/smelly_source/inline.rb +0 -704
data/samples/smelly_source/optparse.rb +0 -1788
data/samples/smelly_source/redcloth.rb +0 -1130
data/samples/smelly_source/ruby.rb +0 -368
data/samples/smelly_source/smelly.rb +0 -7
data/samples/source_with_exclude_paths/ignore_me/uncommunicative_method_name.rb +0 -5
data/samples/source_with_exclude_paths/nested/ignore_me_as_well/irresponsible_module.rb +0 -2
data/samples/source_with_exclude_paths/nested/uncommunicative_parameter_name.rb +0 -6
data/samples/source_with_exclude_paths/nested/uncommunicative_variable_name.rb +0 -6
data/samples/source_with_hidden_directories/.hidden/hidden.rb +0 -1
data/samples/source_with_hidden_directories/not_hidden.rb +0 -1
data/samples/source_with_non_ruby_files/gibberish +0 -1
data/samples/source_with_non_ruby_files/python_source.py +0 -1
data/samples/source_with_non_ruby_files/ruby.rb +0 -6
data/spec/performance/reek/smell_detectors/runtime_speed_spec.rb +0 -15
data/spec/quality/documentation_spec.rb +0 -41
data/spec/quality/reek_source_spec.rb +0 -11
data/spec/reek/ast/node_spec.rb +0 -211
data/spec/reek/ast/object_refs_spec.rb +0 -83
data/spec/reek/ast/reference_collector_spec.rb +0 -47
data/spec/reek/ast/sexp_extensions_spec.rb +0 -498
data/spec/reek/cli/application_spec.rb +0 -168
data/spec/reek/cli/command/report_command_spec.rb +0 -44
data/spec/reek/cli/command/todo_list_command_spec.rb +0 -86
data/spec/reek/cli/options_spec.rb +0 -51
data/spec/reek/cli/silencer_spec.rb +0 -28
data/spec/reek/code_comment_spec.rb +0 -184
data/spec/reek/configuration/app_configuration_spec.rb +0 -195
data/spec/reek/configuration/configuration_file_finder_spec.rb +0 -230
data/spec/reek/configuration/default_directive_spec.rb +0 -13
data/spec/reek/configuration/directory_directives_spec.rb +0 -122
data/spec/reek/configuration/excluded_paths_spec.rb +0 -16
data/spec/reek/configuration/rake_task_converter_spec.rb +0 -33
data/spec/reek/configuration/schema_validator_spec.rb +0 -165
data/spec/reek/context/code_context_spec.rb +0 -192
data/spec/reek/context/ghost_context_spec.rb +0 -60
data/spec/reek/context/method_context_spec.rb +0 -72
data/spec/reek/context/module_context_spec.rb +0 -55
data/spec/reek/context/root_context_spec.rb +0 -12
data/spec/reek/context/statement_counter_spec.rb +0 -24
data/spec/reek/context_builder_spec.rb +0 -457
data/spec/reek/detector_repository_spec.rb +0 -22
data/spec/reek/documentation_link_spec.rb +0 -20
data/spec/reek/errors/base_error_spec.rb +0 -13
data/spec/reek/examiner_spec.rb +0 -309
data/spec/reek/logging_error_handler_spec.rb +0 -24
data/spec/reek/rake/task_spec.rb +0 -56
data/spec/reek/report/code_climate/code_climate_configuration_spec.rb +0 -22
data/spec/reek/report/code_climate/code_climate_fingerprint_spec.rb +0 -126
data/spec/reek/report/code_climate/code_climate_formatter_spec.rb +0 -51
data/spec/reek/report/code_climate/code_climate_report_spec.rb +0 -56
data/spec/reek/report/html_report_spec.rb +0 -19
data/spec/reek/report/json_report_spec.rb +0 -58
data/spec/reek/report/location_formatter_spec.rb +0 -32
data/spec/reek/report/progress_formatter_spec.rb +0 -68
data/spec/reek/report/text_report_spec.rb +0 -89
data/spec/reek/report/xml_report_spec.rb +0 -24
data/spec/reek/report/yaml_report_spec.rb +0 -55
data/spec/reek/report_spec.rb +0 -28
data/spec/reek/smell_configuration_spec.rb +0 -56
data/spec/reek/smell_detectors/attribute_spec.rb +0 -197
data/spec/reek/smell_detectors/base_detector_spec.rb +0 -50
data/spec/reek/smell_detectors/boolean_parameter_spec.rb +0 -93
data/spec/reek/smell_detectors/class_variable_spec.rb +0 -106
data/spec/reek/smell_detectors/control_parameter_spec.rb +0 -300
data/spec/reek/smell_detectors/data_clump_spec.rb +0 -134
data/spec/reek/smell_detectors/duplicate_method_call_spec.rb +0 -211
data/spec/reek/smell_detectors/feature_envy_spec.rb +0 -295
data/spec/reek/smell_detectors/instance_variable_assumption_spec.rb +0 -96
data/spec/reek/smell_detectors/irresponsible_module_spec.rb +0 -226
data/spec/reek/smell_detectors/long_parameter_list_spec.rb +0 -61
data/spec/reek/smell_detectors/long_yield_list_spec.rb +0 -49
data/spec/reek/smell_detectors/manual_dispatch_spec.rb +0 -75
data/spec/reek/smell_detectors/missing_safe_method_spec.rb +0 -68
data/spec/reek/smell_detectors/module_initialize_spec.rb +0 -77
data/spec/reek/smell_detectors/nested_iterators_spec.rb +0 -333
data/spec/reek/smell_detectors/nil_check_spec.rb +0 -100
data/spec/reek/smell_detectors/repeated_conditional_spec.rb +0 -100
data/spec/reek/smell_detectors/subclassed_from_core_class_spec.rb +0 -77
data/spec/reek/smell_detectors/too_many_constants_spec.rb +0 -144
data/spec/reek/smell_detectors/too_many_instance_variables_spec.rb +0 -132
data/spec/reek/smell_detectors/too_many_methods_spec.rb +0 -54
data/spec/reek/smell_detectors/too_many_statements_spec.rb +0 -90
data/spec/reek/smell_detectors/uncommunicative_method_name_spec.rb +0 -78
data/spec/reek/smell_detectors/uncommunicative_module_name_spec.rb +0 -78
data/spec/reek/smell_detectors/uncommunicative_parameter_name_spec.rb +0 -147
data/spec/reek/smell_detectors/uncommunicative_variable_name_spec.rb +0 -201
data/spec/reek/smell_detectors/unused_parameters_spec.rb +0 -114
data/spec/reek/smell_detectors/unused_private_method_spec.rb +0 -205
data/spec/reek/smell_detectors/utility_function_spec.rb +0 -293
data/spec/reek/smell_warning_spec.rb +0 -137
data/spec/reek/source/source_code_spec.rb +0 -79
data/spec/reek/source/source_locator_spec.rb +0 -166
data/spec/reek/spec/should_reek_of_spec.rb +0 -153
data/spec/reek/spec/should_reek_only_of_spec.rb +0 -91
data/spec/reek/spec/should_reek_spec.rb +0 -52
data/spec/reek/spec/smell_matcher_spec.rb +0 -87
data/spec/reek/tree_dresser_spec.rb +0 -46
data/spec/spec_helper.rb +0 -110
data/tasks/configuration.rake +0 -18
data/tasks/console.rake +0 -5
data/tasks/reek.rake +0 -6
data/tasks/rubocop.rake +0 -11
data/tasks/test.rake +0 -32

data/samples/configuration/accepts_rejects_and_excludes_for_detectors.reek.yml DELETED Viewed

@@ -1,29 +0,0 @@
----
-detectors:
-  UnusedPrivateMethod:
-    exclude:
-      - "/exclude regexp/"
-  UncommunicativeMethodName:
-    reject:
-      - "reject name"
-    accept:
-      - "accept name"
-  UncommunicativeModuleName:
-    reject:
-      - "reject name 1"
-      - "reject name 2"
-    accept:
-      - "accept name 1"
-      - "accept name 2"
-  UncommunicativeParameterName:
-    reject:
-      - "reject name"
-      - "/reject regexp/"
-    accept:
-      - "accept name"
-      - "/accept regexp/"
-  UncommunicativeVariableName:
-    reject:
-      - "/^reject regexp$/"
-    accept:
-      - "/accept(.*)regexp/"

data/samples/configuration/accepts_rejects_and_excludes_for_directory_directives.reek.yml DELETED Viewed

@@ -1,30 +0,0 @@
----
-directories:
-  "app/controllers":
-    UnusedPrivateMethod:
-      exclude:
-        - "/exclude regexp/"
-    UncommunicativeMethodName:
-      reject:
-        - "reject name"
-      accept:
-        - "accept name"
-    UncommunicativeModuleName:
-      reject:
-        - "reject name 1"
-        - "reject name 2"
-      accept:
-        - "accept name 1"
-        - "accept name 2"
-    UncommunicativeParameterName:
-      reject:
-        - "reject name"
-        - "/reject regexp/"
-      accept:
-        - "accept name"
-        - "/accept regexp/"
-    UncommunicativeVariableName:
-      reject:
-        - "/^reject regexp$/"
-      accept:
-        - "/accept(.*)regexp/"

data/samples/configuration/corrupt.reek DELETED Viewed

	@@ -1 +0,0 @@
1	- Not a valid configuration file

data/samples/configuration/empty.reek DELETED Viewed

File without changes

data/samples/configuration/full_configuration.reek DELETED Viewed

@@ -1,13 +0,0 @@
----
-detectors:
-  IrresponsibleModule:
-    enabled: false
-directories:
-  "samples/three_clean_files/":
-    UtilityFunction:
-      enabled: false
-exclude_paths:
-  - "samples/two_smelly_files/"
-  - "samples/source_with_non_ruby_files/"

data/samples/configuration/full_mask.reek DELETED Viewed

@@ -1,6 +0,0 @@
----
-detectors:
-  UncommunicativeMethodName:
-    enabled: false
-  UncommunicativeVariableName:
-    enabled: false

data/samples/configuration/home/home.reek.yml DELETED Viewed

@@ -1,4 +0,0 @@
----
-UncommunicativeVariableName:
-  accept:
-  - md5

data/samples/configuration/partial_mask.reek DELETED Viewed

@@ -1,4 +0,0 @@
----
-detectors:
-  UncommunicativeMethodName:
-    enabled: false

data/samples/configuration/regular_configuration/.reek.yml DELETED Viewed

@@ -1,4 +0,0 @@
----
-UncommunicativeVariableName:
-  accept:
-  - md5

data/samples/configuration/regular_configuration/empty_sub_directory/.gitignore DELETED Viewed

File without changes

data/samples/configuration/with_excluded_paths.reek DELETED Viewed

@@ -1,5 +0,0 @@
----
-exclude_paths:
-  - samples/source_with_exclude_paths/ignore_me/
-  - samples/source_with_exclude_paths/nested/ignore_me_as_well
-  - samples/source_with_exclude_paths/nested/uncommunicative_parameter_name.rb

data/samples/no_config_file/.keep DELETED Viewed

File without changes

data/samples/paths.rb DELETED Viewed

@@ -1,5 +0,0 @@
-SAMPLES_DIR = Pathname.new(__dir__).relative_path_from(Pathname.pwd)
-CONFIGURATION_DIR = SAMPLES_DIR.join('configuration')
-CLEAN_FILE = SAMPLES_DIR.join('clean_source').join('clean.rb')
-SMELLY_FILE = SAMPLES_DIR.join('smelly_source').join('smelly.rb')