reek 5.3.0 → 5.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b224c4eef70b2a99e48c212ba52e13a36ac530c2b96e3fd2b3924a38e0cbda42
-  data.tar.gz: 3667c059f76f95f5eeb25b9f6e576d41e4643c8118f93f31f54a41df50d7605a
+  metadata.gz: db4147666bde8bb5b529a24811652b2962207c644f391bef9dd134091490ae44
+  data.tar.gz: 1bc45d794c8c4a678801a612e533c2f1fff5a490ccc3e0e60013b95ff6a387f2
 SHA512:
-  metadata.gz: dbd6ef9ccbde8364187729ef0d496246db6da79e6e04f07f149b971fb567c3fa00d56641dcbd3b2e424d31132ba11bbdaac864e7f5077b432f60db518f8eeb68
-  data.tar.gz: c2ea5ccb2646ee26320fcbf791aee04229633862f98af22f186f2e0ed8d4ddd5115255a148f9b56523b61e244a78af0d31eefdebbd97e1437e2beccd9fc19d7a
+  metadata.gz: e7dddc4d7211d87887bbb3d639d499a9eb4730f1915c88793fe591f67332a549dcb88fa678bc4acd50bc6e05c8183eede890b03b6e000c036825c58e10f14b2e
+  data.tar.gz: 49ebed1b359d43a42e843dc5e994c62c7d9ca7a9e3b0cb8640bd345664c8d8d094b7c42a14efea81280a3575c9f9f2b25b22ecceece76b09cfcc40589de7fc18

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 5.3.1 (2019-02-08)
+
+* (Al Snow) Upgrade parser dependency
+
 ## 5.3.0 (2018-12-28)
 
 * (mvz) Add support for Ruby 2.6.

data/Gemfile

@@ -5,18 +5,18 @@ gemspec
 ruby RUBY_VERSION
 
 group :development do
-  gem 'activesupport',   '>= 4.2'
-  gem 'aruba',           '~> 0.14.0'
-  gem 'cucumber',        '~> 3.0'
-  gem 'factory_bot',     '~> 4.0'
-  gem 'kramdown',        '~> 1.17'
-  gem 'rake',            '~> 12.0'
-  gem 'rspec',           '~> 3.0'
-  gem 'rspec-benchmark', '~> 0.4.0'
-  gem 'rubocop',         '~> 0.61.1'
-  gem 'rubocop-rspec',   '~> 1.30.1'
-  gem 'simplecov',       '~> 0.16.1'
-  gem 'yard',            '~> 0.9.5'
+  gem 'aruba',               '~> 0.14.8'
+  gem 'cucumber',            '~> 3.0'
+  gem 'factory_bot',         '~> 5.0'
+  gem 'kramdown',            '~> 2.1'
+  gem 'kramdown-parser-gfm', '~> 1.0'
+  gem 'rake',                '~> 12.0'
+  gem 'rspec',               '~> 3.0'
+  gem 'rspec-benchmark',     '~> 0.4.0'
+  gem 'rubocop',             '~> 0.63.0'
+  gem 'rubocop-rspec',       '~> 1.32.0'
+  gem 'simplecov',           '~> 0.16.1'
+  gem 'yard',                '~> 0.9.5'
 
   platforms :mri do
     gem 'redcarpet', '~> 3.4.0'

data/features/command_line_interface/options.feature

@@ -43,7 +43,7 @@ Feature: Reek can be controlled using command-line options
           -c, --config FILE                Read configuration options from FILE
               --smell SMELL                Only look for a specific smell.
                                            Call it like this: reek --smell MissingSafeMethod source.rb
-                                           Check out https://github.com/troessner/reek/blob/v5.3.0/docs/Code-Smells.md for a list of smells
+                                           Check out https://github.com/troessner/reek/blob/v5.3.1/docs/Code-Smells.md for a list of smells
               --stdin-filename FILE        When passing code in via pipe, assume this filename when checking file or directory rules in the config.
 
       Generate a todo list:
@@ -120,5 +120,5 @@ Feature: Reek can be controlled using command-line options
       UnusedPrivateMethod
       UtilityFunction
 
-      Check out https://github.com/troessner/reek/blob/v5.3.0/docs/Code-Smells.md for a details on each detector
+      Check out https://github.com/troessner/reek/blob/v5.3.1/docs/Code-Smells.md for a details on each detector
       """

data/features/reports/json.feature

@@ -24,7 +24,7 @@ Feature: Report smells using simple JSON layout
               "context": "Smelly#x",
               "lines": [ 4 ],
               "message": "has the name 'x'",
-              "documentation_link": "https://github.com/troessner/reek/blob/v5.3.0/docs/Uncommunicative-Method-Name.md",
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.3.1/docs/Uncommunicative-Method-Name.md",
               "name": "x"
           },
           {
@@ -33,7 +33,7 @@ Feature: Report smells using simple JSON layout
               "context": "Smelly#x",
               "lines": [ 5 ],
               "message": "has the variable name 'y'",
-              "documentation_link": "https://github.com/troessner/reek/blob/v5.3.0/docs/Uncommunicative-Variable-Name.md",
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.3.1/docs/Uncommunicative-Variable-Name.md",
               "name": "y"
           }
       ]
@@ -53,7 +53,7 @@ Feature: Report smells using simple JSON layout
                   1
               ],
               "message": "has no descriptive comment",
-              "documentation_link": "https://github.com/troessner/reek/blob/v5.3.0/docs/Irresponsible-Module.md"
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.3.1/docs/Irresponsible-Module.md"
           }
       ]
       """

data/features/reports/reports.feature

@@ -182,8 +182,8 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.3.0/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.3.0/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.3.1/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.3.1/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:
@@ -209,8 +209,8 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.3.0/docs/Uncommunicative-Method-Name.md]
-        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.3.0/docs/Uncommunicative-Variable-Name.md]
+        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.3.1/docs/Uncommunicative-Method-Name.md]
+        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.3.1/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:

data/features/reports/yaml.feature

@@ -25,7 +25,7 @@ Feature: Report smells using simple YAML layout
         smell_type: UncommunicativeMethodName
         source: smelly.rb
         name: x
-        documentation_link: https://github.com/troessner/reek/blob/v5.3.0/docs/Uncommunicative-Method-Name.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.3.1/docs/Uncommunicative-Method-Name.md
       - context: Smelly#x
         lines:
         - 5
@@ -33,7 +33,7 @@ Feature: Report smells using simple YAML layout
         smell_type: UncommunicativeVariableName
         source: smelly.rb
         name: y
-        documentation_link: https://github.com/troessner/reek/blob/v5.3.0/docs/Uncommunicative-Variable-Name.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.3.1/docs/Uncommunicative-Variable-Name.md
       """
 
   Scenario: Indicate smells and print them as yaml when using STDIN
@@ -48,5 +48,5 @@ Feature: Report smells using simple YAML layout
         lines:
         - 1
         message: has no descriptive comment
-        documentation_link: https://github.com/troessner/reek/blob/v5.3.0/docs/Irresponsible-Module.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.3.1/docs/Irresponsible-Module.md
       """

data/features/support/env.rb

@@ -13,11 +13,11 @@ end
 #
 class ReekWorld
   def reek(args)
-    run_simple("reek --no-color --no-documentation #{args}", false)
+    run_command_and_stop("reek --no-color --no-documentation #{args}", fail_on_error: false)
   end
 
   def reek_with_pipe(stdin, args)
-    run "reek --no-color --no-documentation #{args}"
+    run_command "reek --no-color --no-documentation #{args}"
     type(stdin)
     close_input
   end

data/lib/reek/ast/sexp_extensions.rb

@@ -3,14 +3,12 @@
 require_relative 'reference_collector'
 
 require_relative 'sexp_extensions/arguments'
-require_relative 'sexp_extensions/attribute_assignments'
 require_relative 'sexp_extensions/begin'
 require_relative 'sexp_extensions/block'
 require_relative 'sexp_extensions/case'
 require_relative 'sexp_extensions/constant'
 require_relative 'sexp_extensions/if'
 require_relative 'sexp_extensions/lambda'
-require_relative 'sexp_extensions/literal'
 require_relative 'sexp_extensions/logical_operators'
 require_relative 'sexp_extensions/methods'
 require_relative 'sexp_extensions/module'

data/lib/reek/ast/sexp_extensions/yield.rb

@@ -8,10 +8,6 @@ module Reek
         def args
           children
         end
-
-        def arg_names
-          args.map { |arg| arg[1] }
-        end
       end
     end
   end

data/lib/reek/spec.rb

@@ -6,10 +6,10 @@ require_relative 'spec/should_reek_only_of'
 
 module Reek
   #
-  # Provides matchers for Rspec, making it easy to check code quality.
+  # Provides matchers for RSpec, making it easy to check code quality.
   #
   # If you require this module somewhere within your spec (or in your spec_helper),
-  # Reek will arrange to update Spec::Runner's config so that it knows about the
+  # Reek will arrange to update RSpec::Runner's config so that it knows about the
   # matchers defined here.
   #
   # === Examples
@@ -120,12 +120,6 @@ module Reek
   end
 end
 
-if Object.const_defined?(:Spec)
-  Spec::Runner.configure do |config|
-    config.include(Reek::Spec)
-  end
-end
-
 if Object.const_defined?(:RSpec)
   RSpec.configure do |config|
     config.include(Reek::Spec)

data/lib/reek/version.rb

@@ -8,6 +8,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '5.3.0'
+    STRING = '5.3.1'
   end
 end

data/reek.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency 'codeclimate-engine-rb', '~> 0.4.0'
   s.add_runtime_dependency 'kwalify',               '~> 0.7.0'
-  s.add_runtime_dependency 'parser',                '< 2.6', '>= 2.5.0.0', '!= 2.5.1.1'
+  s.add_runtime_dependency 'parser',                '< 2.7', '>= 2.5.0.0', '!= 2.5.1.1'
   s.add_runtime_dependency 'psych',                 '~> 3.1.0'
   s.add_runtime_dependency 'rainbow',               '>= 2.0', '< 4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 5.3.0
+  version: 5.3.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-28 00:00:00.000000000 Z
+date: 2019-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb
@@ -45,28 +45,28 @@ dependencies:
   name: parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.7'
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.5.0.0
     - - "!="
       - !ruby/object:Gem::Version
         version: 2.5.1.1
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.7'
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.5.0.0
     - - "!="
       - !ruby/object:Gem::Version
         version: 2.5.1.1
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2.6'
 - !ruby/object:Gem::Dependency
   name: psych
   requirement: !ruby/object:Gem::Requirement
@@ -224,14 +224,12 @@ files:
 - lib/reek/ast/reference_collector.rb
 - lib/reek/ast/sexp_extensions.rb
 - lib/reek/ast/sexp_extensions/arguments.rb
-- lib/reek/ast/sexp_extensions/attribute_assignments.rb
 - lib/reek/ast/sexp_extensions/begin.rb
 - lib/reek/ast/sexp_extensions/block.rb
 - lib/reek/ast/sexp_extensions/case.rb
 - lib/reek/ast/sexp_extensions/constant.rb
 - lib/reek/ast/sexp_extensions/if.rb
 - lib/reek/ast/sexp_extensions/lambda.rb
-- lib/reek/ast/sexp_extensions/literal.rb
 - lib/reek/ast/sexp_extensions/logical_operators.rb
 - lib/reek/ast/sexp_extensions/methods.rb
 - lib/reek/ast/sexp_extensions/module.rb
@@ -501,7 +499,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubyforge_project: 
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Code smell detector for Ruby

data/lib/reek/ast/sexp_extensions/attribute_assignments.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-module Reek
-  module AST
-    module SexpExtensions
-      # Utility methods for :attrasgn nodes.
-      module AttrasgnNode
-        def args
-          children[2]
-        end
-      end
-    end
-  end
-end

data/lib/reek/ast/sexp_extensions/literal.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-module Reek
-  module AST
-    module SexpExtensions
-      # Utility methods for :lit nodes.
-      module LitNode
-        def value
-          children.first
-        end
-      end
-    end
-  end
-end