reek 4.8.2 → 5.0.0

data/samples/configuration/accepts_rejects_and_excludes_for_directory_directives.reek.yml

@@ -0,0 +1,30 @@
+---
+directories:
+  "app/controllers":
+    UnusedPrivateMethod:
+      exclude:
+        - "/exclude regexp/"
+    UncommunicativeMethodName:
+      reject:
+        - "reject name"
+      accept:
+        - "accept name"
+    UncommunicativeModuleName:
+      reject:
+        - "reject name 1"
+        - "reject name 2"
+      accept:
+        - "accept name 1"
+        - "accept name 2"
+    UncommunicativeParameterName:
+      reject:
+        - "reject name"
+        - "/reject regexp/"
+      accept:
+        - "accept name"
+        - "/accept regexp/"
+    UncommunicativeVariableName:
+      reject:
+        - "/^reject regexp$/"
+      accept:
+        - "/accept(.*)regexp/"

data/samples/configuration/full_configuration.reek

@@ -1,9 +1,13 @@
 ---
-IrresponsibleModule:
-  enabled: false
-"samples/three_clean_files/":
-  UtilityFunction:
+detectors:
+  IrresponsibleModule:
     enabled: false
+
+directories:
+  "samples/three_clean_files/":
+    UtilityFunction:
+      enabled: false
+
 exclude_paths:
   - "samples/two_smelly_files/"
   - "samples/source_with_non_ruby_files/"

data/samples/configuration/full_mask.reek

@@ -1,5 +1,6 @@
 ---
-UncommunicativeMethodName:
-  enabled: false
-UncommunicativeVariableName:
-  enabled: false
+detectors:
+  UncommunicativeMethodName:
+    enabled: false
+  UncommunicativeVariableName:
+    enabled: false

data/samples/configuration/partial_mask.reek

@@ -1,3 +1,4 @@
 ---
-UncommunicativeMethodName:
-  enabled: false
+detectors:
+  UncommunicativeMethodName:
+    enabled: false

data/samples/configuration/regular_configuration/.reek.yml

@@ -0,0 +1,4 @@
+---
+UncommunicativeVariableName:
+  accept:
+  - md5

data/samples/paths.rb

@@ -1,4 +1,5 @@
-SAMPLES_PATH = Pathname.new(__dir__).relative_path_from(Pathname.pwd)
-CONFIG_PATH = SAMPLES_PATH.join('configuration')
-CLEAN_FILE = SAMPLES_PATH.join('clean.rb')
-SMELLY_FILE = SAMPLES_PATH.join('smelly.rb')
+SAMPLES_DIR = Pathname.new(__dir__).relative_path_from(Pathname.pwd)
+CONFIGURATION_DIR = SAMPLES_DIR.join('configuration')
+CLEAN_FILE = SAMPLES_DIR.join('clean_source').join('clean.rb')
+SMELLY_FILE = SAMPLES_DIR.join('smelly_source').join('smelly.rb')
+

data/samples/source_with_hidden_directories/.hidden/hidden.rb

@@ -0,0 +1 @@
+

data/samples/source_with_hidden_directories/not_hidden.rb

@@ -0,0 +1 @@
+

data/spec/reek/ast/node_spec.rb

@@ -164,7 +164,7 @@ RSpec.describe Reek::AST::Node do
 
   describe '#line' do
     context 'with source from a file' do
-      let(:file) { SAMPLES_PATH.join('smelly.rb') }
+      let(:file) { SMELLY_FILE }
       let(:ast) { Reek::Source::SourceCode.from(file).syntax_tree }
 
       it 'returns the right line number' do
@@ -173,7 +173,7 @@ RSpec.describe Reek::AST::Node do
     end
 
     context 'with source from a string' do
-      let(:source) { File.read(SAMPLES_PATH.join('smelly.rb')) }
+      let(:source) { File.read(SMELLY_FILE) }
       let(:ast) { Reek::Source::SourceCode.from(source).syntax_tree }
 
       it 'returns the right line number' do
@@ -184,16 +184,16 @@ RSpec.describe Reek::AST::Node do
 
   describe '#source' do
     context 'with source from a file' do
-      let(:file) { SAMPLES_PATH.join('smelly.rb') }
+      let(:file) { SMELLY_FILE }
       let(:ast) { Reek::Source::SourceCode.from(file).syntax_tree }
 
       it 'returns the file name' do
-        expect(ast.source).to eq(SAMPLES_PATH.join('smelly.rb').to_s)
+        expect(ast.source).to eq(SMELLY_FILE.to_s)
       end
     end
 
     context 'with source from a string' do
-      let(:source) { File.read(SAMPLES_PATH.join('smelly.rb')) }
+      let(:source) { File.read SMELLY_FILE }
       let(:ast) { Reek::Source::SourceCode.from(source).syntax_tree }
 
       it 'returns "string"' do

data/spec/reek/cli/application_spec.rb

@@ -17,9 +17,9 @@ RSpec.describe Reek::CLI::Application do
 
   describe '#execute' do
     let(:path_excluded_in_configuration) do
-      SAMPLES_PATH.join('source_with_exclude_paths/ignore_me/uncommunicative_method_name.rb')
+      SAMPLES_DIR.join('source_with_exclude_paths/ignore_me/uncommunicative_method_name.rb')
     end
-    let(:configuration) { test_configuration_for(CONFIG_PATH.join('with_excluded_paths.reek')) }
+    let(:configuration) { test_configuration_for(CONFIGURATION_DIR.join('with_excluded_paths.reek')) }
     let(:command) { instance_double 'Reek::CLI::Command::ReportCommand' }
     let(:app) { described_class.new [] }
 
@@ -37,13 +37,27 @@ RSpec.describe Reek::CLI::Application do
         allow_any_instance_of(IO).to receive(:tty?).and_return(false)
       end
 
-      it 'uses source form pipe' do
+      it 'uses source from pipe' do
+        expected_sources = a_collection_containing_exactly(have_attributes(origin: 'STDIN'))
         app.execute
         expect(Reek::CLI::Command::ReportCommand).to have_received(:new).
-          with(sources: [$stdin],
+          with(sources: expected_sources,
                configuration: Reek::Configuration::AppConfiguration,
                options: Reek::CLI::Options)
       end
+
+      context 'when a stdin filename is provided' do
+        let(:app) { described_class.new ['--stdin-filename', 'foo.rb'] }
+
+        it 'assumes that filename' do
+          expected_sources = a_collection_containing_exactly(have_attributes(origin: 'foo.rb'))
+          app.execute
+          expect(Reek::CLI::Command::ReportCommand).to have_received(:new).
+            with(sources: expected_sources,
+                 configuration: Reek::Configuration::AppConfiguration,
+                 options: Reek::CLI::Options)
+        end
+      end
     end
 
     context 'when no source files given and no input was piped' do

data/spec/reek/cli/command/todo_list_command_spec.rb

@@ -1,6 +1,7 @@
 require_relative '../../../spec_helper'
 require_lib 'reek/cli/command/todo_list_command'
 require_lib 'reek/cli/options'
+require_lib 'reek/configuration/app_configuration'
 
 RSpec.describe Reek::CLI::Command::TodoListCommand do
   let(:nil_check) { build :smell_detector, smell_type: :NilCheck }
@@ -37,8 +38,9 @@ RSpec.describe Reek::CLI::Command::TodoListCommand do
       it 'writes a todo file with exclusions for each smell' do
         Reek::CLI::Silencer.silently { command.execute }
         expected_yaml = {
-          'UncommunicativeMethodName' => { 'exclude' => ['Smelly#x'] },
-          'UncommunicativeVariableName' => { 'exclude' => ['Smelly#x'] }
+          Reek::Configuration::AppConfiguration::DETECTORS_KEY =>
+          { 'UncommunicativeMethodName' => { 'exclude' => ['Smelly#x'] },
+            'UncommunicativeVariableName' => { 'exclude' => ['Smelly#x'] } }
         }.to_yaml
         expect(File).to have_received(:write).with(described_class::FILE_NAME, expected_yaml)
       end

data/spec/reek/cli/silencer_spec.rb

@@ -0,0 +1,28 @@
+require_relative '../../spec_helper'
+require_lib 'reek/cli/silencer'
+
+RSpec.describe Reek::CLI::Silencer do
+  describe '.silently' do
+    it 'blocks output from the block on $stdout' do
+      expect { described_class.silently { puts 'Hi!' } }.not_to output.to_stdout
+    end
+
+    it 'blocks output from the block on $stderr' do
+      expect { described_class.silently { warn 'Hi!' } }.not_to output.to_stderr
+    end
+
+    it 'restores output on $stdout after the block' do
+      expect do
+        described_class.silently { puts 'Hi!' }
+        puts 'there!'
+      end.to output("there!\n").to_stdout
+    end
+
+    it 'restores output on $stderr after the block' do
+      expect do
+        described_class.silently { warn 'Hi!' }
+        warn 'there!'
+      end.to output("there!\n").to_stderr
+    end
+  end
+end

data/spec/reek/code_comment_spec.rb

@@ -161,13 +161,6 @@ RSpec.describe Reek::CodeComment::CodeCommentValidator do
           build(:code_comment, comment: comment)
         end.not_to raise_error
       end
-
-      it 'does not raise on regexps' do
-        expect do
-          comment = '# :reek:UncommunicativeMethodName { exclude: !ruby/regexp /alfa/ }'
-          build(:code_comment, comment: comment)
-        end.not_to raise_error
-      end
     end
 
     context 'when unknown custom options are specified' do

data/spec/reek/configuration/app_configuration_spec.rb

@@ -8,8 +8,8 @@ require_lib 'reek/configuration/excluded_paths'
 RSpec.describe Reek::Configuration::AppConfiguration do
   describe 'factory methods' do
     let(:expected_excluded_paths) do
-      [SAMPLES_PATH.join('two_smelly_files'),
-       SAMPLES_PATH.join('source_with_non_ruby_files')]
+      [SAMPLES_DIR.join('two_smelly_files'),
+       SAMPLES_DIR.join('source_with_non_ruby_files')]
     end
 
     let(:expected_default_directive) do
@@ -17,32 +17,35 @@ RSpec.describe Reek::Configuration::AppConfiguration do
     end
 
     let(:expected_directory_directives) do
-      { SAMPLES_PATH.join('three_clean_files') =>
+      { SAMPLES_DIR.join('three_clean_files') =>
         { Reek::SmellDetectors::UtilityFunction => { 'enabled' => false } } }
     end
 
     let(:default_directive_value) do
-      { 'IrresponsibleModule' => { 'enabled' => false } }
+      { described_class::DETECTORS_KEY =>
+        { 'IrresponsibleModule' => { 'enabled' => false } } }
     end
 
     let(:directory_directives_value) do
-      { 'samples/three_clean_files' =>
-        { 'UtilityFunction' => { 'enabled' => false } } }
+      { described_class::DIRECTORIES_KEY =>
+        { 'samples/three_clean_files' =>
+          { 'UtilityFunction' => { 'enabled' => false } } } }
     end
 
     let(:exclude_paths_value) do
-      ['samples/two_smelly_files',
-       'samples/source_with_non_ruby_files']
+      { described_class::EXCLUDE_PATHS_KEY =>
+        ['samples/two_smelly_files',
+         'samples/source_with_non_ruby_files'] }
     end
 
     let(:combined_value) do
       directory_directives_value.
         merge(default_directive_value).
-        merge('exclude_paths' => exclude_paths_value)
+        merge(exclude_paths_value)
     end
 
     describe '#from_path' do
-      let(:full_configuration_path) { CONFIG_PATH.join('full_configuration.reek') }
+      let(:full_configuration_path) { CONFIGURATION_DIR.join('full_configuration.reek') }
 
       it 'properly loads configuration and processes it' do
         config = described_class.from_path full_configuration_path
@@ -77,34 +80,38 @@ RSpec.describe Reek::Configuration::AppConfiguration do
   describe '#directive_for' do
     context 'with multiple directory directives and no default directive present' do
       let(:source_via) { 'samples/three_clean_files/dummy.rb' }
-      let(:baz_config)  { { Reek::SmellDetectors::IrresponsibleModule => { enabled: false } } }
-      let(:bang_config) { { Reek::SmellDetectors::Attribute => { enabled: true } } }
+      let(:baz_config)  { { IrresponsibleModule: { enabled: false } } }
+      let(:bang_config) { { Attribute: { enabled: true } } }
+      let(:expected_result) { { Reek::SmellDetectors::Attribute => { enabled: true } } }
 
       let(:directory_directives) do
-        {
-          'samples/two_smelly_files' => baz_config,
-          'samples/three_clean_files' => bang_config
-        }
+        { described_class::DIRECTORIES_KEY =>
+          {
+            'samples/two_smelly_files' => baz_config,
+            'samples/three_clean_files' => bang_config
+          } }
       end
 
       it 'returns the corresponding directive' do
         configuration = described_class.from_hash directory_directives
-        expect(configuration.directive_for(source_via)).to eq(bang_config)
+        expect(configuration.directive_for(source_via)).to eq expected_result
       end
     end
 
     context 'with directory directive and default directive present' do
       let(:directory) { 'spec/samples/two_smelly_files/' }
-      let(:directory_config) { { Reek::SmellDetectors::TooManyStatements => { max_statements: 8 } } }
-      let(:directory_directives) { { directory => directory_config } }
-      let(:default_directive) do
+      let(:source_via) { "#{directory}/dummy.rb" }
+
+      let(:configuration_as_hash) do
         {
-          Reek::SmellDetectors::IrresponsibleModule => { enabled: false },
-          Reek::SmellDetectors::TooManyStatements => { max_statements: 15 }
+          described_class::DIRECTORIES_KEY =>
+            { directory => { TooManyStatements: { max_statements: 8 } } },
+          described_class::DETECTORS_KEY => {
+            IrresponsibleModule: { enabled: false },
+            TooManyStatements: { max_statements: 15 }
+          }
         }
       end
-      let(:source_via) { "#{directory}/dummy.rb" }
-      let(:configuration_as_hash) { directory_directives.merge(default_directive) }
 
       it 'returns the directory directive with the default directive reverse-merged' do
         configuration = described_class.from_hash configuration_as_hash
@@ -116,18 +123,24 @@ RSpec.describe Reek::Configuration::AppConfiguration do
       end
     end
 
-    context 'with no directory directive but a default directive present' do
+    context 'with a path not covered by a directory directive but a default directive present' do
       let(:source_via) { 'spec/samples/three_clean_files/dummy.rb' }
-      let(:default_directive) { { Reek::SmellDetectors::IrresponsibleModule => { enabled: false } } }
-      let(:attribute_config) { { Reek::SmellDetectors::Attribute => { enabled: false } } }
-      let(:directory_directives) do
-        { 'spec/samples/two_smelly_files' => attribute_config }
+
+      let(:configuration_as_hash) do
+        {
+          described_class::DETECTORS_KEY => {
+            IrresponsibleModule: { enabled: false }
+          },
+          described_class::DIRECTORIES_KEY =>
+            { 'spec/samples/two_smelly_files' => { Attribute: { enabled: false } } }
+        }
       end
-      let(:configuration_as_hash) { directory_directives.merge(default_directive) }
+
+      let(:expected_result) { { Reek::SmellDetectors::IrresponsibleModule => { enabled: false } } }
 
       it 'returns the default directive' do
         configuration = described_class.from_hash configuration_as_hash
-        expect(configuration.directive_for(source_via)).to eq(default_directive)
+        expect(configuration.directive_for(source_via)).to eq expected_result
       end
     end
   end

data/spec/reek/configuration/configuration_file_finder_spec.rb

@@ -2,9 +2,13 @@ require 'fileutils'
 require 'pathname'
 require 'tmpdir'
 require_relative '../../spec_helper'
+require_lib 'reek/configuration/app_configuration'
 
 RSpec.describe Reek::Configuration::ConfigurationFileFinder do
   describe '.find' do
+    let(:regular_configuration_dir) { CONFIGURATION_DIR.join('regular_configuration') }
+    let(:regular_configuration_file) { regular_configuration_dir.join('.reek.yml') }
+
     it 'returns any explicitely passed path' do
       path = Pathname.new 'foo/bar'
       found = described_class.find(path: path)
@@ -13,42 +17,44 @@ RSpec.describe Reek::Configuration::ConfigurationFileFinder do
 
     it 'prefers an explicitely passed path over a file in current dir' do
       path = Pathname.new 'foo/bar'
-      found = described_class.find(path: path, current: SAMPLES_PATH)
+      found = described_class.find(path: path, current: regular_configuration_dir)
       expect(found).to eq(path)
     end
 
     it 'returns the file in current dir if path is not set' do
-      found = described_class.find(current: SAMPLES_PATH)
-      expect(found).to eq(SAMPLES_PATH.join('exceptions.reek'))
+      found = described_class.find(current: regular_configuration_dir)
+      expect(found).to eq(regular_configuration_file)
     end
 
     it 'returns the file in a parent dir if none in current dir' do
-      Dir.mktmpdir(nil, SAMPLES_PATH) do |tempdir|
-        found = described_class.find(current: Pathname.new(tempdir))
-        expect(found).to eq(SAMPLES_PATH.join('exceptions.reek'))
-      end
+      empty_sub_directory = CONFIGURATION_DIR.join('regular_configuration').join('empty_sub_directory')
+      found = described_class.find(current: empty_sub_directory)
+      expect(found).to eq(regular_configuration_file)
     end
 
-    it 'returns the file even if it’s just ‘.reek’' do
-      single_configuration_file_dir = CONFIG_PATH.join('single_configuration_file')
-      found = described_class.find(current: single_configuration_file_dir)
-      expect(found).to eq(single_configuration_file_dir.join('.reek'))
+    it 'skips files ending in .reek.yml in current dir' do
+      Dir.mktmpdir(nil, regular_configuration_dir) do |tempdir|
+        current = Pathname.new(tempdir)
+        bad_config = current.join('ignoreme.reek.yml')
+        FileUtils.touch bad_config
+        found = described_class.find(current: Pathname.new(tempdir))
+        expect(found).to eq(regular_configuration_file)
+      end
     end
 
     it 'returns the file in home if traversing from the current dir fails' do
       skip_if_a_config_in_tempdir
 
-      Dir.mktmpdir(nil, SAMPLES_PATH) do |tempdir|
-        found = described_class.find(current: Pathname.new(tempdir))
-        expect(found).to eq(SAMPLES_PATH.join('exceptions.reek'))
+      Dir.mktmpdir do |tempdir|
+        found = described_class.find(current: Pathname.new(tempdir), home: regular_configuration_dir)
+        expect(found).to eq(regular_configuration_file)
       end
     end
 
     it 'prefers the file in :current over one in :home' do
-      found = described_class.find(current: SAMPLES_PATH, home: CONFIG_PATH)
-      file_in_current = SAMPLES_PATH.join('exceptions.reek')
-
-      expect(found).to eq(file_in_current)
+      home_dir = CONFIGURATION_DIR.join('home')
+      found = described_class.find(current: regular_configuration_dir, home: home_dir)
+      expect(found).to eq(regular_configuration_file)
     end
 
     it 'returns nil when there are no files to find' do
@@ -68,12 +74,10 @@ RSpec.describe Reek::Configuration::ConfigurationFileFinder do
       skip_if_a_config_in_tempdir
 
       Dir.mktmpdir do |tempdir|
-        dir = Pathname.new(tempdir)
-        subdir = dir.join('subdir')
-
-        FileUtils.mkdir(subdir)
+        current = Pathname.new(tempdir)
+        home = SAMPLES_DIR.join('no_config_file')
 
-        found = described_class.find(current: subdir, home: dir)
+        found = described_class.find(current: current, home: home)
 
         expect(found).to be_nil
       end
@@ -81,7 +85,7 @@ RSpec.describe Reek::Configuration::ConfigurationFileFinder do
 
     it 'works with paths that need escaping' do
       Dir.mktmpdir("ma\ngic d*r") do |tempdir|
-        config = Pathname.new("#{tempdir}/ma\ngic f*le.reek")
+        config = Pathname.new("#{tempdir}/.reek.yml")
         subdir = Pathname.new("#{tempdir}/ma\ngic subd*r")
         FileUtils.touch config
         FileUtils.mkdir subdir
@@ -89,42 +93,122 @@ RSpec.describe Reek::Configuration::ConfigurationFileFinder do
         expect(found).to eq(config)
       end
     end
-
-    context 'with more than one configuration file' do
-      let(:path) { CONFIG_PATH.join('more_than_one_configuration_file') }
-
-      it 'prints a message on STDERR' do
-        expected_message = "Error: Found multiple configuration files 'regular.reek', 'todo.reek'"
-        expect do
-          begin
-            described_class.find(current: path)
-          rescue SystemExit
-          end
-        end.to output(/#{expected_message}/).to_stderr
-      end
-
-      it 'exits' do
-        Reek::CLI::Silencer.silently do
-          expect do
-            described_class.find(current: path)
-          end.to raise_error(SystemExit)
-        end
-      end
-    end
   end
 
   describe '.load_from_file' do
     let(:sample_configuration_loaded) do
       {
-        'UncommunicativeVariableName' => { 'enabled' => false },
-        'UncommunicativeMethodName'   => { 'enabled' => false }
+        Reek::Configuration::AppConfiguration::DETECTORS_KEY => {
+          'UncommunicativeVariableName' => { 'enabled' => false },
+          'UncommunicativeMethodName'   => { 'enabled' => false }
+        }
       }
     end
 
     it 'loads the configuration from given file' do
-      configuration = described_class.load_from_file(CONFIG_PATH.join('full_mask.reek'))
+      configuration = described_class.load_from_file(CONFIGURATION_DIR.join('full_mask.reek'))
       expect(configuration).to eq(sample_configuration_loaded)
     end
+
+    context 'with exclude, accept and reject settings' do
+      context 'when configuring top level detectors' do
+        let(:configuration) do
+          described_class.
+            load_from_file(CONFIGURATION_DIR.join('accepts_rejects_and_excludes_for_detectors.reek.yml')).
+            fetch(Reek::Configuration::AppConfiguration::DETECTORS_KEY)
+        end
+
+        let(:expected) do
+          {
+            'UnusedPrivateMethod' => { 'exclude' => [/exclude regexp/] },
+            'UncommunicativeMethodName' => { 'reject' => ['reject name'],
+                                             'accept' => ['accept name'] },
+            'UncommunicativeModuleName' => { 'reject' => ['reject name 1', 'reject name 2'],
+                                             'accept' => ['accept name 1', 'accept name 2'] },
+            'UncommunicativeParameterName' => { 'reject' => ['reject name', /reject regexp/],
+                                                'accept' => ['accept name', /accept regexp/] },
+            'UncommunicativeVariableName' => { 'reject' => [/^reject regexp$/],
+                                               'accept' => [/accept(.*)regexp/] }
+          }
+        end
+
+        it 'converts marked strings to regexes' do
+          expect(configuration['UnusedPrivateMethod']).to eq(expected['UnusedPrivateMethod'])
+        end
+
+        it 'leaves regular single strings untouched' do
+          expect(configuration['UncommunicativeMethodName']).to eq(expected['UncommunicativeMethodName'])
+        end
+
+        it 'leaves regular multiple strings untouched' do
+          expect(configuration['UncommunicativeModuleName']).to eq(expected['UncommunicativeModuleName'])
+        end
+
+        it 'allows mixing of regular strings and marked strings' do
+          expect(configuration['UncommunicativeParameterName']).to eq(expected['UncommunicativeParameterName'])
+        end
+
+        it 'converts more complex marked strings correctly to regexes' do
+          expect(configuration['UncommunicativeVariableName']).to eq(expected['UncommunicativeVariableName'])
+        end
+      end
+
+      context 'when configuring directory directives' do
+        let(:directory_name) { 'app/controllers' }
+        let(:configuration) do
+          described_class.
+            load_from_file(CONFIGURATION_DIR.join('accepts_rejects_and_excludes_for_directory_directives.reek.yml')).
+            fetch(Reek::Configuration::AppConfiguration::DIRECTORIES_KEY)
+        end
+
+        let(:expected) do
+          {
+            directory_name => {
+              'UnusedPrivateMethod' => { 'exclude' => [/exclude regexp/] },
+              'UncommunicativeMethodName' => { 'reject' => ['reject name'],
+                                               'accept' => ['accept name'] },
+              'UncommunicativeModuleName' => { 'reject' => ['reject name 1', 'reject name 2'],
+                                               'accept' => ['accept name 1', 'accept name 2'] },
+              'UncommunicativeParameterName' => { 'reject' => ['reject name', /reject regexp/],
+                                                  'accept' => ['accept name', /accept regexp/] },
+              'UncommunicativeVariableName' => { 'reject' => [/^reject regexp$/],
+                                                 'accept' => [/accept(.*)regexp/] }
+            }
+          }
+        end
+
+        it 'converts marked strings to regexes' do
+          expect(configuration[directory_name]['UnusedPrivateMethod']).
+            to eq(expected[directory_name]['UnusedPrivateMethod'])
+        end
+
+        it 'leaves regular single strings untouched' do
+          expect(configuration[directory_name]['UncommunicativeMethodName']).
+            to eq(expected[directory_name]['UncommunicativeMethodName'])
+        end
+
+        it 'leaves regular multiple strings untouched' do
+          expect(configuration[directory_name]['UncommunicativeModuleName']).
+            to eq(expected[directory_name]['UncommunicativeModuleName'])
+        end
+
+        it 'allows mixing of regular strings and marked strings' do
+          expect(configuration[directory_name]['UncommunicativeParameterName']).
+            to eq(expected[directory_name]['UncommunicativeParameterName'])
+        end
+
+        it 'converts more complex marked strings correctly to regexes' do
+          expect(configuration[directory_name]['UncommunicativeVariableName']).
+            to eq(expected[directory_name]['UncommunicativeVariableName'])
+        end
+      end
+    end
+
+    it 'returns blank hash when no file is found' do
+      config = described_class.load_from_file(nil)
+
+      expect(config).to eq({})
+    end
   end
 
   private