reek 4.8.1 → 5.0.2

data/features/configuration_files/schema_validation.feature

@@ -0,0 +1,59 @@
+Feature: Validate schema
+  In order to ensure that I am using the right configuration
+  As a user
+  I want to be notified when I am using a configuration that violates our schema
+
+  Scenario: Our generated default configuration
+    Given our default configuration file
+    And the clean file 'clean.rb'
+    When I run reek -c defaults.reek clean.rb
+    Then it succeeds
+    And it reports nothing
+
+  Scenario: Detectors, directories and exclude paths all mixed
+    Given a file named "config.reek" with:
+    """
+    ---
+    detectors:
+      IrresponsibleModule:
+        enabled: false
+      NestedIterators:
+        exclude:
+          - "MyWorker#self.class_method"
+          - "AnotherWorker#instance_method"
+      DataClump:
+        max_copies: 3
+        min_clump_size: 3
+
+    directories:
+      "web_app/app/controllers":
+        NestedIterators:
+          enabled: false
+      "web_app/app/helpers":
+        UtilityFunction:
+          enabled: false
+
+    exclude_paths:
+      - lib/legacy
+      - lib/rake/legacy_tasks
+    """
+    And the clean file 'clean.rb'
+    When I run reek -c config.reek clean.rb
+    Then it succeeds
+    And it reports nothing
+
+  Scenario: Invalid detector name
+    Given a file named "config.reek" with:
+    """
+    ---
+    detectors:
+      DoesNotExist:
+        enabled: true
+    """
+    And the clean file 'clean.rb'
+    When I run reek -c config.reek clean.rb
+    Then the exit status indicates an error
+    And stderr reports:
+    """
+    Error: We found some problems with your configuration file: [/detectors/DoesNotExist] key 'DoesNotExist:' is undefined.
+    """

data/features/configuration_files/unused_private_method.feature

@@ -7,12 +7,13 @@ Feature: Unused Private Method detector
     Given a file named "config.reek" with:
       """
       ---
-      IrresponsibleModule:
-        enabled: false
-      UnusedPrivateMethod:
-        enabled: true
-        exclude:
-          - "Outer::Awesome#foobar"
+      detectors:
+        IrresponsibleModule:
+          enabled: false
+        UnusedPrivateMethod:
+          enabled: true
+          exclude:
+            - Outer::Awesome#foobar
       """
     And a file named "sample.rb" with:
       """
@@ -27,23 +28,24 @@ Feature: Unused Private Method detector
         end
       end
       """
-    When I run `reek -c config.reek sample.rb`
+    When I run reek -c config.reek sample.rb
     Then it reports:
     """
     sample.rb -- 1 warning:
-      [4]:UnusedPrivateMethod: Outer::Smelly has the unused private instance method 'foobar' [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      [4]:UnusedPrivateMethod: Outer::Smelly has the unused private instance method 'foobar'
     """
 
   Scenario: Use regexes for excluding contexts
     Given a file named "config.reek" with:
       """
       ---
-      IrresponsibleModule:
-        enabled: false
-      UnusedPrivateMethod:
-        enabled: true
-        exclude:
-          - !ruby/regexp /(.*)wesome#foo(.*)/
+      detectors:
+        IrresponsibleModule:
+          enabled: false
+        UnusedPrivateMethod:
+          enabled: true
+          exclude:
+            - wesome#foo
       """
     And a file named "sample.rb" with:
       """
@@ -58,9 +60,9 @@ Feature: Unused Private Method detector
         end
       end
       """
-    When I run `reek -c config.reek sample.rb`
+    When I run reek -c config.reek sample.rb
     Then it reports:
     """
     sample.rb -- 1 warning:
-      [4]:UnusedPrivateMethod: Outer::Smelly has the unused private instance method 'foobar' [https://github.com/troessner/reek/blob/master/docs/Unused-Private-Method.md]
+      [4]:UnusedPrivateMethod: Outer::Smelly has the unused private instance method 'foobar'
     """

data/features/configuration_loading.feature

@@ -3,7 +3,7 @@ Feature: Offer different ways how to load configuration
   Reek can be configured in two ways:
   - Using the cli "-c" switch to pass a configuration file on the command line.
   - Having a Reek configuration file that is automatically found. Reek will
-    look for a file ending in .reek in the following places, in order:
+    look for a file ending in .reek.yml in the following places, in order:
     - The current working directory
     - The working directory's ancestor directories, traversing all the way up
       to the root.
@@ -17,8 +17,8 @@ Feature: Offer different ways how to load configuration
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
   Scenario: Configuration via CLI
@@ -30,19 +30,62 @@ Feature: Offer different ways how to load configuration
 
   Scenario: Configuration file in working directory
     Given the smelly file 'smelly.rb'
-    And a configuration file 'full_mask.reek'
+    And a file named ".reek.yml" with:
+      """
+      ---
+      detectors:
+        UncommunicativeMethodName:
+          enabled: false
+        UncommunicativeVariableName:
+          enabled: false
+      """
     When I run reek smelly.rb
     Then it reports no errors
     And it succeeds
 
-  Scenario: Two opposing configuration files and we stop after the first one
-    Given the smelly file 'smelly.rb' in a subdirectory
-    And a configuration file 'partial_mask.reek' in a subdirectory
-    And a configuration file 'full_mask.reek'
-    When I run "reek smelly.rb" in a subdirectory
+  Scenario: Do not use the default config file when we explicitly specify one configuration file
+    Given the smelly file 'smelly.rb'
+    And a file named "config.reek" with:
+      """
+      ---
+      detectors:
+        UncommunicativeMethodName:
+          enabled: false
+      """
+    And a file named ".reek.yml" with:
+      """
+      ---
+      UncommunicativeVariableName:
+        enabled: false
+      """
+    When I run reek -c config.reek smelly.rb
+    Then the exit status indicates smells
+    And it reports:
+      """
+      smelly.rb -- 1 warning:
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
+      """
+
+  Scenario: Prefer the default config file over other configuration files
+    Given the smelly file 'smelly.rb'
+    And a file named "config.reek" with:
+      """
+      ---
+      detectors:
+        UncommunicativeMethodName:
+          enabled: false
+      """
+    And a file named ".reek.yml" with:
+      """
+      ---
+      detectors:
+        UncommunicativeVariableName:
+          enabled: false
+      """
+    When I run reek smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
       smelly.rb -- 1 warning:
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
       """

data/features/configuration_via_source_comments/erroneous_source_comments.feature

@@ -33,8 +33,8 @@ Feature: Erroneous source comments are handled properly
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       2 total warnings
       """
 

data/features/configuration_via_source_comments/well_formed_source_comments.feature

@@ -48,7 +48,7 @@ Feature: Well formed source comments are handled properly
     And it reports:
       """
       enable_detector_explicitly.rb -- 1 warning:
-        [3]:TooManyInstanceVariables: Alfa has at least 5 instance variables [https://github.com/troessner/reek/blob/master/docs/Too-Many-Instance-Variables.md]
+        [3]:TooManyInstanceVariables: Alfa has at least 5 instance variables
       """
 
   Scenario: Configure smell detector with the basic exclude option as string
@@ -112,5 +112,5 @@ Feature: Well formed source comments are handled properly
     And it reports:
       """
       configure_detector_specific_option.rb -- 1 warning:
-        [3]:TooManyInstanceVariables: Alfa has at least 3 instance variables [https://github.com/troessner/reek/blob/master/docs/Too-Many-Instance-Variables.md]
+        [3]:TooManyInstanceVariables: Alfa has at least 3 instance variables
       """

data/features/locales.feature

@@ -9,7 +9,7 @@ Feature: Handling different locales
     """
     puts 'こんにちは世界'
     """
-    When I run `reek -V konnichiwa.rb`
+    When I run reek -V konnichiwa.rb
     Then it succeeds
     And it reports no errors
     And it reports:
@@ -23,7 +23,7 @@ Feature: Handling different locales
     """
     puts 'こんにちは世界'
     """
-    When I run `reek -V konnichiwa.rb`
+    When I run reek -V konnichiwa.rb
     Then it succeeds
     And it reports no errors
     And it reports:

data/features/rake_task/rake_task.feature

@@ -10,7 +10,7 @@ Feature: Reek can be driven through its Task
 
       Reek::Rake::Task.new do |t|
         t.source_files = 'smelly.rb'
-        t.reek_opts = '--no-color'
+        t.reek_opts = '--no-color --no-documentation'
       end
       """
     When I run `rake reek`
@@ -18,8 +18,8 @@ Feature: Reek can be driven through its Task
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
   Scenario: source_files using a FileList instead of a String
@@ -30,7 +30,7 @@ Feature: Reek can be driven through its Task
 
       Reek::Rake::Task.new do |t|
         t.source_files = FileList['smelly.*']
-        t.reek_opts = '--no-color'
+        t.reek_opts = '--no-color --no-documentation'
       end
       """
     When I run `rake reek`
@@ -38,8 +38,8 @@ Feature: Reek can be driven through its Task
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
   Scenario: name changes the task name
@@ -50,7 +50,7 @@ Feature: Reek can be driven through its Task
 
       Reek::Rake::Task.new('silky') do |t|
         t.source_files = 'smelly.rb'
-        t.reek_opts = '--no-color'
+        t.reek_opts = '--no-color --no-documentation'
       end
       """
     When I run `rake silky`
@@ -58,8 +58,8 @@ Feature: Reek can be driven through its Task
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
   Scenario: verbose prints the reek command
@@ -86,7 +86,7 @@ Feature: Reek can be driven through its Task
       Reek::Rake::Task.new do |t|
         t.fail_on_error = false
         t.source_files = 'smelly.rb'
-        t.reek_opts = '--no-color'
+        t.reek_opts = '--no-color --no-documentation'
       end
       """
     When I run `rake reek`
@@ -95,8 +95,8 @@ Feature: Reek can be driven through its Task
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
   Scenario: can be configured with config_file
@@ -124,7 +124,7 @@ Feature: Reek can be driven through its Task
 
       Reek::Rake::Task.new do |t|
         t.source_files = 'clean.rb'
-        t.reek_opts = '--no-color'
+        t.reek_opts = '--no-color --no-documentation'
       end
       """
     When I set the environment variable "REEK_SRC" to "smelly.rb"
@@ -133,6 +133,6 @@ Feature: Reek can be driven through its Task
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """

data/features/reports/json.feature

@@ -24,7 +24,7 @@ Feature: Report smells using simple JSON layout
               "context": "Smelly#x",
               "lines": [ 4 ],
               "message": "has the name 'x'",
-              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md",
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.0.2/docs/Uncommunicative-Method-Name.md",
               "name": "x"
           },
           {
@@ -33,7 +33,7 @@ Feature: Report smells using simple JSON layout
               "context": "Smelly#x",
               "lines": [ 5 ],
               "message": "has the variable name 'y'",
-              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md",
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.0.2/docs/Uncommunicative-Variable-Name.md",
               "name": "y"
           }
       ]
@@ -53,7 +53,7 @@ Feature: Report smells using simple JSON layout
                   1
               ],
               "message": "has no descriptive comment",
-              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md"
+              "documentation_link": "https://github.com/troessner/reek/blob/v5.0.2/docs/Irresponsible-Module.md"
           }
       ]
       """

data/features/reports/reports.feature

@@ -10,11 +10,11 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly/dirty_one.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       smelly/dirty_two.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       4 total warnings
       """
 
@@ -30,11 +30,11 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly/dirty_one.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       smelly/dirty_two.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       4 total warnings
       """
 
@@ -51,11 +51,11 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly/dirty_two.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       smelly/dirty_one.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       4 total warnings
       """
 
@@ -110,8 +110,8 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        UncommunicativeMethodName: Smelly#x has the name 'x'
+        UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
     Examples:
@@ -127,8 +127,8 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
     Examples:
@@ -144,8 +144,8 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        smelly.rb:4: UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        smelly.rb:5: UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        smelly.rb:4: UncommunicativeMethodName: Smelly#x has the name 'x'
+        smelly.rb:5: UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
     Examples:
@@ -162,11 +162,11 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly/dirty_one.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       smelly/dirty_two.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       4 total warnings
       """
 
@@ -175,25 +175,25 @@ Feature: Correctly formatted reports
       | smelly/ |
       | smelly  |
 
-  Scenario Outline: -U or --wiki-links adds helpful links to smell warnings
+  Scenario Outline: -U or --documentation adds helpful links to smell warnings
     Given the smelly file 'smelly.rb'
     When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.0.2/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.0.2/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:
-      | option        |
-      | -U            |
-      | --wiki-links  |
+      | option           |
+      | -U               |
+      | --documentation  |
 
-  Scenario: --no-wiki-links drops links from smell warnings
+  Scenario: --no-documentation drops links from smell warnings
     Given the smelly file 'smelly.rb'
-    When I run reek --no-wiki-links smelly.rb
+    When I run reek --no-documentation smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
@@ -202,18 +202,18 @@ Feature: Correctly formatted reports
         [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
-  Scenario Outline: --wiki-links is independent of --line-numbers
+  Scenario Outline: --documentation is independent of --line-numbers
     Given the smelly file 'smelly.rb'
     When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
       smelly.rb -- 2 warnings:
-        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.0.2/docs/Uncommunicative-Method-Name.md]
+        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.0.2/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:
       | option                             |
       | --no-line-numbers -U               |
-      | --no-line-numbers --wiki-links  |
+      | --no-line-numbers --documentation  |

data/features/reports/yaml.feature

@@ -25,7 +25,7 @@ Feature: Report smells using simple YAML layout
         smell_type: UncommunicativeMethodName
         source: smelly.rb
         name: x
-        wiki_link: https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.0.2/docs/Uncommunicative-Method-Name.md
       - context: Smelly#x
         lines:
         - 5
@@ -33,7 +33,7 @@ Feature: Report smells using simple YAML layout
         smell_type: UncommunicativeVariableName
         source: smelly.rb
         name: y
-        wiki_link: https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.0.2/docs/Uncommunicative-Variable-Name.md
       """
 
   Scenario: Indicate smells and print them as yaml when using STDIN
@@ -48,5 +48,5 @@ Feature: Report smells using simple YAML layout
         lines:
         - 1
         message: has no descriptive comment
-        wiki_link: https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md
+        documentation_link: https://github.com/troessner/reek/blob/v5.0.2/docs/Irresponsible-Module.md
       """

data/features/rspec_matcher.feature

@@ -24,7 +24,15 @@ Feature: Use reek_of matcher
     """
 
   Scenario: Masking smells with a configuration file
-    Given a configuration file 'full_mask.reek'
+    Given a file named ".reek.yml" with:
+      """
+      ---
+      detectors:
+        UncommunicativeMethodName:
+          enabled: false
+        UncommunicativeVariableName:
+          enabled: false
+      """
     When I run `rspec reek_spec.rb`
     Then stdout should contain:
     """