reek 4.8.1 → 5.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +5 -5
- data/.rubocop.yml +17 -3
- data/.simplecov +1 -0
- data/.travis.yml +0 -5
- data/.yardopts +1 -1
- data/CHANGELOG.md +33 -0
- data/Gemfile +1 -1
- data/README.md +115 -100
- data/Rakefile +16 -3
- data/bin/reek +1 -3
- data/docs/API.md +2 -9
- data/docs/Basic-Smell-Options.md +51 -11
- data/docs/Code-Smells.md +1 -1
- data/docs/Command-Line-Options.md +14 -4
- data/docs/Duplicate-Method-Call.md +49 -1
- data/docs/Feature-Envy.md +44 -0
- data/docs/How-To-Write-New-Detectors.md +2 -3
- data/docs/Instance-Variable-Assumption.md +1 -1
- data/docs/{Prima-Donna-Method.md → Missing-Safe-Method.md} +11 -9
- data/docs/Rake-Task.md +1 -1
- data/docs/Reek-4-to-Reek-5-migration.md +193 -0
- data/docs/Reek-Driven-Development.md +1 -1
- data/docs/Uncommunicative-Method-Name.md +45 -6
- data/docs/Uncommunicative-Module-Name.md +49 -7
- data/docs/Uncommunicative-Parameter-Name.md +43 -5
- data/docs/Uncommunicative-Variable-Name.md +73 -2
- data/docs/Unused-Private-Method.md +1 -1
- data/docs/defaults.reek.yml +129 -0
- data/docs/yard_plugin.rb +1 -0
- data/features/command_line_interface/basic_usage.feature +2 -2
- data/features/command_line_interface/options.feature +46 -4
- data/features/command_line_interface/show_progress.feature +4 -4
- data/features/command_line_interface/smell_selection.feature +1 -1
- data/features/command_line_interface/smells_count.feature +6 -6
- data/features/command_line_interface/stdin.feature +30 -8
- data/features/configuration_files/accept_setting.feature +45 -28
- data/features/configuration_files/directory_specific_directives.feature +78 -73
- data/features/configuration_files/exclude_directives.feature +11 -10
- data/features/configuration_files/exclude_paths_directives.feature +4 -4
- data/features/configuration_files/masking_smells.feature +38 -9
- data/features/configuration_files/mix_accept_reject_setting.feature +31 -28
- data/features/configuration_files/reject_setting.feature +52 -41
- data/features/configuration_files/schema_validation.feature +59 -0
- data/features/configuration_files/unused_private_method.feature +18 -16
- data/features/configuration_loading.feature +53 -10
- data/features/configuration_via_source_comments/erroneous_source_comments.feature +2 -2
- data/features/configuration_via_source_comments/well_formed_source_comments.feature +2 -2
- data/features/locales.feature +2 -2
- data/features/rake_task/rake_task.feature +15 -15
- data/features/reports/json.feature +3 -3
- data/features/reports/reports.feature +34 -34
- data/features/reports/yaml.feature +3 -3
- data/features/rspec_matcher.feature +9 -1
- data/features/samples.feature +287 -287
- data/features/step_definitions/reek_steps.rb +4 -0
- data/features/step_definitions/sample_file_steps.rb +9 -4
- data/features/support/env.rb +2 -2
- data/features/todo_list.feature +26 -23
- data/lib/reek/ast/node.rb +3 -6
- data/lib/reek/ast/object_refs.rb +1 -1
- data/lib/reek/ast/sexp_extensions/if.rb +1 -1
- data/lib/reek/ast/sexp_extensions/methods.rb +1 -1
- data/lib/reek/cli/application.rb +4 -3
- data/lib/reek/cli/command/report_command.rb +1 -2
- data/lib/reek/cli/command/todo_list_command.rb +4 -2
- data/lib/reek/cli/options.rb +29 -14
- data/lib/reek/cli/silencer.rb +14 -3
- data/lib/reek/code_comment.rb +14 -16
- data/lib/reek/configuration/app_configuration.rb +32 -28
- data/lib/reek/configuration/configuration_converter.rb +110 -0
- data/lib/reek/configuration/configuration_file_finder.rb +15 -40
- data/lib/reek/configuration/configuration_validator.rb +12 -23
- data/lib/reek/configuration/default_directive.rb +17 -3
- data/lib/reek/configuration/directory_directives.rb +17 -11
- data/lib/reek/configuration/excluded_paths.rb +1 -1
- data/lib/reek/configuration/rake_task_converter.rb +29 -0
- data/lib/reek/configuration/schema.yml +210 -0
- data/lib/reek/configuration/schema_validator.rb +38 -0
- data/lib/reek/context/attribute_context.rb +1 -1
- data/lib/reek/context/code_context.rb +4 -4
- data/lib/reek/context/method_context.rb +2 -2
- data/lib/reek/context/module_context.rb +1 -1
- data/lib/reek/context_builder.rb +9 -9
- data/lib/reek/detector_repository.rb +6 -0
- data/lib/reek/documentation_link.rb +28 -0
- data/lib/reek/errors/bad_detector_configuration_key_in_comment_error.rb +4 -3
- data/lib/reek/errors/bad_detector_in_comment_error.rb +4 -3
- data/lib/reek/errors/config_file_error.rb +11 -0
- data/lib/reek/errors/encoding_error.rb +2 -2
- data/lib/reek/errors/garbage_detector_configuration_in_comment_error.rb +4 -3
- data/lib/reek/errors/incomprehensible_source_error.rb +2 -2
- data/lib/reek/errors/syntax_error.rb +41 -0
- data/lib/reek/examiner.rb +9 -19
- data/lib/reek/rake/task.rb +3 -3
- data/lib/reek/report/base_report.rb +8 -12
- data/lib/reek/report/code_climate/code_climate_configuration.yml +6 -10
- data/lib/reek/report/documentation_link_warning_formatter.rb +17 -0
- data/lib/reek/report/heading_formatter.rb +54 -0
- data/lib/reek/report/json_report.rb +1 -1
- data/lib/reek/report/location_formatter.rb +40 -0
- data/lib/reek/report/progress_formatter.rb +79 -0
- data/lib/reek/report/simple_warning_formatter.rb +34 -0
- data/lib/reek/report/text_report.rb +1 -2
- data/lib/reek/report/xml_report.rb +3 -3
- data/lib/reek/report/yaml_report.rb +1 -1
- data/lib/reek/report.rb +15 -10
- data/lib/reek/smell_configuration.rb +2 -2
- data/lib/reek/smell_detectors/attribute.rb +0 -1
- data/lib/reek/smell_detectors/base_detector.rb +8 -11
- data/lib/reek/smell_detectors/boolean_parameter.rb +0 -1
- data/lib/reek/smell_detectors/class_variable.rb +0 -1
- data/lib/reek/smell_detectors/control_parameter.rb +17 -32
- data/lib/reek/smell_detectors/data_clump.rb +3 -4
- data/lib/reek/smell_detectors/duplicate_method_call.rb +5 -6
- data/lib/reek/smell_detectors/feature_envy.rb +1 -1
- data/lib/reek/smell_detectors/instance_variable_assumption.rb +0 -1
- data/lib/reek/smell_detectors/irresponsible_module.rb +0 -1
- data/lib/reek/smell_detectors/long_parameter_list.rb +1 -2
- data/lib/reek/smell_detectors/long_yield_list.rb +2 -3
- data/lib/reek/smell_detectors/manual_dispatch.rb +2 -2
- data/lib/reek/smell_detectors/{prima_donna_method.rb → missing_safe_method.rb} +6 -7
- data/lib/reek/smell_detectors/module_initialize.rb +0 -1
- data/lib/reek/smell_detectors/nested_iterators.rb +4 -5
- data/lib/reek/smell_detectors/nil_check.rb +0 -1
- data/lib/reek/smell_detectors/repeated_conditional.rb +3 -4
- data/lib/reek/smell_detectors/subclassed_from_core_class.rb +0 -1
- data/lib/reek/smell_detectors/too_many_constants.rb +1 -2
- data/lib/reek/smell_detectors/too_many_instance_variables.rb +1 -2
- data/lib/reek/smell_detectors/too_many_methods.rb +1 -2
- data/lib/reek/smell_detectors/too_many_statements.rb +1 -2
- data/lib/reek/smell_detectors/uncommunicative_method_name.rb +2 -3
- data/lib/reek/smell_detectors/uncommunicative_module_name.rb +2 -3
- data/lib/reek/smell_detectors/uncommunicative_parameter_name.rb +2 -3
- data/lib/reek/smell_detectors/uncommunicative_variable_name.rb +4 -5
- data/lib/reek/smell_detectors/unused_parameters.rb +0 -1
- data/lib/reek/smell_detectors/unused_private_method.rb +0 -1
- data/lib/reek/smell_detectors/utility_function.rb +1 -2
- data/lib/reek/smell_detectors.rb +1 -2
- data/lib/reek/smell_warning.rb +15 -8
- data/lib/reek/source/source_code.rb +40 -55
- data/lib/reek/source/source_locator.rb +7 -7
- data/lib/reek/spec/should_reek.rb +2 -2
- data/lib/reek/spec/should_reek_of.rb +9 -16
- data/lib/reek/spec/should_reek_only_of.rb +4 -4
- data/lib/reek/spec.rb +6 -6
- data/lib/reek/tree_dresser.rb +5 -5
- data/lib/reek/version.rb +1 -1
- data/reek.gemspec +3 -3
- data/samples/checkstyle.xml +1 -1
- data/samples/configuration/accepts_rejects_and_excludes_for_detectors.reek.yml +29 -0
- data/samples/configuration/accepts_rejects_and_excludes_for_directory_directives.reek.yml +30 -0
- data/samples/configuration/full_configuration.reek +8 -4
- data/samples/configuration/full_mask.reek +5 -4
- data/samples/configuration/partial_mask.reek +3 -2
- data/samples/configuration/regular_configuration/.reek.yml +4 -0
- data/samples/paths.rb +5 -4
- data/samples/source_with_hidden_directories/.hidden/hidden.rb +1 -0
- data/samples/source_with_hidden_directories/not_hidden.rb +1 -0
- data/spec/reek/ast/node_spec.rb +5 -5
- data/spec/reek/cli/application_spec.rb +18 -4
- data/spec/reek/cli/command/todo_list_command_spec.rb +4 -2
- data/spec/reek/cli/silencer_spec.rb +28 -0
- data/spec/reek/code_comment_spec.rb +0 -7
- data/spec/reek/configuration/app_configuration_spec.rb +44 -31
- data/spec/reek/configuration/configuration_file_finder_spec.rb +133 -49
- data/spec/reek/configuration/default_directive_spec.rb +1 -1
- data/spec/reek/configuration/directory_directives_spec.rb +3 -4
- data/spec/reek/configuration/excluded_paths_spec.rb +5 -5
- data/spec/reek/configuration/rake_task_converter_spec.rb +33 -0
- data/spec/reek/configuration/schema_validator_spec.rb +165 -0
- data/spec/reek/context/code_context_spec.rb +1 -1
- data/spec/reek/documentation_link_spec.rb +20 -0
- data/spec/reek/examiner_spec.rb +28 -1
- data/spec/reek/report/json_report_spec.rb +13 -46
- data/spec/reek/report/{formatter/location_formatter_spec.rb → location_formatter_spec.rb} +5 -5
- data/spec/reek/report/{formatter/progress_formatter_spec.rb → progress_formatter_spec.rb} +4 -4
- data/spec/reek/report/text_report_spec.rb +4 -4
- data/spec/reek/report/xml_report_spec.rb +1 -1
- data/spec/reek/report/yaml_report_spec.rb +9 -38
- data/spec/reek/report_spec.rb +3 -3
- data/spec/reek/smell_detectors/feature_envy_spec.rb +47 -2
- data/spec/reek/smell_detectors/{prima_donna_method_spec.rb → missing_safe_method_spec.rb} +9 -9
- data/spec/reek/smell_detectors/too_many_constants_spec.rb +3 -3
- data/spec/reek/smell_detectors/too_many_instance_variables_spec.rb +1 -1
- data/spec/reek/smell_detectors/uncommunicative_method_name_spec.rb +6 -6
- data/spec/reek/smell_detectors/uncommunicative_module_name_spec.rb +6 -4
- data/spec/reek/smell_detectors/uncommunicative_parameter_name_spec.rb +6 -4
- data/spec/reek/smell_detectors/uncommunicative_variable_name_spec.rb +6 -6
- data/spec/reek/smell_detectors/unused_private_method_spec.rb +1 -1
- data/spec/reek/smell_warning_spec.rb +4 -0
- data/spec/reek/source/source_code_spec.rb +16 -22
- data/spec/reek/source/source_locator_spec.rb +11 -11
- data/spec/reek/spec/should_reek_of_spec.rb +0 -4
- data/spec/reek/spec/should_reek_only_of_spec.rb +2 -2
- data/spec/reek/spec/should_reek_spec.rb +1 -1
- data/spec/reek/tree_dresser_spec.rb +2 -6
- data/spec/spec_helper.rb +3 -5
- data/tasks/configuration.rake +8 -5
- metadata +58 -35
- data/defaults.reek +0 -131
- data/features/configuration_files/warn_about_multiple_configuration_files.feature +0 -44
- data/lib/reek/report/formatter/heading_formatter.rb +0 -52
- data/lib/reek/report/formatter/location_formatter.rb +0 -42
- data/lib/reek/report/formatter/progress_formatter.rb +0 -81
- data/lib/reek/report/formatter/simple_warning_formatter.rb +0 -35
- data/lib/reek/report/formatter/wiki_link_warning_formatter.rb +0 -36
- data/lib/reek/report/formatter.rb +0 -33
- data/lib/reek/smell_detectors/syntax.rb +0 -37
- data/samples/configuration/non_public_modifiers_mask.reek +0 -3
- data/samples/smelly_with_inline_mask.rb +0 -8
- data/samples/smelly_with_modifiers.rb +0 -12
- data/samples/source_with_hidden_directories/.hidden/uncommunicative_method_name.rb +0 -5
- data/samples/source_with_non_ruby_files/uncommunicative_parameter_name.rb +0 -6
- data/spec/reek/smell_detectors/syntax_spec.rb +0 -17
- /data/{samples/configuration/more_than_one_configuration_file/regular.reek → .reek.yml} +0 -0
- /data/samples/{clean.rb → clean_source/clean.rb} +0 -0
- /data/samples/{exceptions.reek → configuration/home/home.reek.yml} +0 -0
- /data/samples/configuration/{more_than_one_configuration_file/todo.reek → regular_configuration/empty_sub_directory/.gitignore} +0 -0
- /data/samples/{configuration/single_configuration_file/.reek → no_config_file/.keep} +0 -0
- /data/samples/{inline.rb → smelly_source/inline.rb} +0 -0
- /data/samples/{optparse.rb → smelly_source/optparse.rb} +0 -0
- /data/samples/{redcloth.rb → smelly_source/redcloth.rb} +0 -0
- /data/samples/{smelly.rb → smelly_source/smelly.rb} +0 -0
- /data/samples/{source_with_hidden_directories/uncommunicative_parameter_name.rb → source_with_non_ruby_files/ruby.rb} +0 -0
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
|
-
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
2
|
+
SHA1:
|
|
3
|
+
metadata.gz: dcc26f0cc3bb682d6af4ccd125c9968049fa7659
|
|
4
|
+
data.tar.gz: 3f07f95ea9d5dc2d9a3228d9720aa991ac1f5232
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: caeb105aa52968eb387304da206083cf07394d1f378c01a6aabf040e2aa264d0016491e69dba31910fa64982cdc8bf9902b036b63639279422c93ad934a91725
|
|
7
|
+
data.tar.gz: 8af65a286c9207f04770b530865755aeeca35b4162d3db66c987b0e6d5c02438faeeee3251bef91ef5e91e4b75235ec2ae23f805a07bfc64d448e7e5066610d6
|
data/.rubocop.yml
CHANGED
|
@@ -6,7 +6,7 @@ AllCops:
|
|
|
6
6
|
- 'samples/**/*'
|
|
7
7
|
- 'tmp/**/*'
|
|
8
8
|
- 'vendor/**/*'
|
|
9
|
-
TargetRubyVersion: 2.
|
|
9
|
+
TargetRubyVersion: 2.3
|
|
10
10
|
|
|
11
11
|
# Place . on the previous line
|
|
12
12
|
Layout/DotPosition:
|
|
@@ -60,9 +60,21 @@ Metrics/ClassLength:
|
|
|
60
60
|
- lib/reek/context_builder.rb
|
|
61
61
|
- lib/reek/cli/options.rb
|
|
62
62
|
|
|
63
|
+
Style/SafeNavigation:
|
|
64
|
+
Exclude:
|
|
65
|
+
- lib/reek/ast/node.rb
|
|
66
|
+
- lib/reek/ast/sexp_extensions/module.rb
|
|
67
|
+
|
|
63
68
|
# FIXME: Lower the method length by fixing the biggest offenders
|
|
64
69
|
Metrics/MethodLength:
|
|
65
70
|
Max: 15
|
|
71
|
+
Exclude:
|
|
72
|
+
- 'lib/reek/cli/options.rb'
|
|
73
|
+
|
|
74
|
+
Metrics/AbcSize:
|
|
75
|
+
Exclude:
|
|
76
|
+
- 'lib/reek/cli/options.rb'
|
|
77
|
+
- 'lib/reek/configuration/configuration_converter.rb'
|
|
66
78
|
|
|
67
79
|
# Be rather lenient with line length
|
|
68
80
|
Metrics/LineLength:
|
|
@@ -100,8 +112,8 @@ RSpec/MultipleDescribes:
|
|
|
100
112
|
Exclude:
|
|
101
113
|
- 'spec/reek/ast/sexp_extensions_spec.rb'
|
|
102
114
|
- 'spec/reek/code_comment_spec.rb'
|
|
103
|
-
- 'spec/reek/report/
|
|
104
|
-
- 'spec/reek/report/
|
|
115
|
+
- 'spec/reek/report/location_formatter_spec.rb'
|
|
116
|
+
- 'spec/reek/report/progress_formatter_spec.rb'
|
|
105
117
|
|
|
106
118
|
# FIXME: Update specs to avoid offenses
|
|
107
119
|
RSpec/MultipleExpectations:
|
|
@@ -119,6 +131,8 @@ RSpec/NestedGroups:
|
|
|
119
131
|
Exclude:
|
|
120
132
|
- 'spec/reek/report/code_climate/code_climate_fingerprint_spec.rb'
|
|
121
133
|
- 'spec/reek/cli/application_spec.rb'
|
|
134
|
+
- 'spec/reek/configuration/schema_validator_spec.rb'
|
|
135
|
+
- 'spec/reek/configuration/configuration_file_finder_spec.rb'
|
|
122
136
|
|
|
123
137
|
# rubocop-rspec expects a CodeClimate namespace to go with the code_climate directory.
|
|
124
138
|
RSpec/FilePath:
|
data/.simplecov
CHANGED
data/.travis.yml
CHANGED
data/.yardopts
CHANGED
data/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,38 @@
|
|
|
1
1
|
# Change log
|
|
2
2
|
|
|
3
|
+
## 5.0.0 (2018-06-18)
|
|
4
|
+
|
|
5
|
+
*Breaking changes:*
|
|
6
|
+
|
|
7
|
+
* (David Fisher) Change PrimaDonnaMethod to MissingSafeMethod
|
|
8
|
+
* (mvz) Always include documentation in JSON and YAML
|
|
9
|
+
* (mvz) Remove Syntax smell detector
|
|
10
|
+
* (mvz) Remove deprecated Examiner#description (in favor of Examiner#origin)
|
|
11
|
+
* (mvz) Allow only detector names in configuration hash
|
|
12
|
+
* (mvz) Do not accept a class as parameter for reek_of
|
|
13
|
+
* (mvz) Allow only .reek.yml instead of any file name ending in .reek
|
|
14
|
+
* (troessner) Validate our configuration by using a schema
|
|
15
|
+
* (troessner) Scope detectors in the configuration under `detectors`
|
|
16
|
+
* (troessner) Move directory directives under a special key
|
|
17
|
+
* (troessner) Use strings not regexes in our configuration file
|
|
18
|
+
* (troessner) Replace `wiki-links` flag with `documentation` flag
|
|
19
|
+
* (troessner) Add yml extension to Reeks configuration file
|
|
20
|
+
* (troessner) Drop legacy code comment separator
|
|
21
|
+
* (troessner) Drop Ruby 2.2 support
|
|
22
|
+
* (troessner) Drop Ruby 2.1 support
|
|
23
|
+
|
|
24
|
+
*Non breaking changes:*
|
|
25
|
+
|
|
26
|
+
* (Paul Sadauskas) Add support for --stdin-filename
|
|
27
|
+
* (mvz) Generate versioned documentation links
|
|
28
|
+
* (mvz) Bugfix: Only report FeatureEnvy for instance methods
|
|
29
|
+
* (troessner) List all smells
|
|
30
|
+
|
|
31
|
+
## 4.8.2 (2018-06-26)
|
|
32
|
+
|
|
33
|
+
* (mvz) Only report FeatureEnvy for instance methods
|
|
34
|
+
* (mvz) Generate versioned documentation links
|
|
35
|
+
|
|
3
36
|
## 4.8.1 (2018-04-12)
|
|
4
37
|
|
|
5
38
|
* (mvz) Loosen dependency on rainbow
|
data/Gemfile
CHANGED
data/README.md
CHANGED
|
@@ -39,13 +39,18 @@
|
|
|
39
39
|
* [](https://badge.fury.io/rb/reek)
|
|
40
40
|
* 
|
|
41
41
|
* 
|
|
42
|
-
* [](https://gemnasium.com/github.com/troessner/reek)
|
|
43
42
|
* [](https://inch-ci.org/github/troessner/reek)
|
|
44
43
|
* [](https://codeclimate.com/github/troessner/reek)
|
|
45
44
|
* [](https://codebeat.co/projects/github-com-troessner-reek)
|
|
46
45
|
* 
|
|
47
46
|
* 
|
|
48
47
|
|
|
48
|
+
## Reek 5 is out!
|
|
49
|
+
|
|
50
|
+
Reek 5 is out and with it a bunch of breaking changes. If you're a new user you can just
|
|
51
|
+
continue with the quickstart below. If you're a Reek 4 user and would like to upgrade to 5, don't
|
|
52
|
+
worry, this shouldn't take you more than 10 minutes. Check out our [Upgrade Guide](docs/Reek-4-to-Reek-5-migration.md).
|
|
53
|
+
|
|
49
54
|
## Quickstart
|
|
50
55
|
|
|
51
56
|
Reek is a tool that examines Ruby classes, modules and methods and reports any
|
|
@@ -84,21 +89,19 @@ end
|
|
|
84
89
|
Reek will report the following code smells in this file:
|
|
85
90
|
|
|
86
91
|
```
|
|
87
|
-
$ reek demo.rb
|
|
92
|
+
$ reek --no-documentation demo.rb
|
|
88
93
|
Inspecting 1 file(s):
|
|
89
94
|
S
|
|
90
95
|
|
|
91
96
|
demo.rb -- 2 warnings:
|
|
92
|
-
[4]:UncommunicativeMethodName: Smelly#x has the name 'x'
|
|
93
|
-
[5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
|
|
97
|
+
[4]:UncommunicativeMethodName: Smelly#x has the name 'x'
|
|
98
|
+
[5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
|
|
94
99
|
```
|
|
95
100
|
|
|
96
101
|
## Supported Ruby versions
|
|
97
102
|
|
|
98
103
|
Reek is officially supported for the following CRuby versions:
|
|
99
104
|
|
|
100
|
-
- 2.1
|
|
101
|
-
- 2.2
|
|
102
105
|
- 2.3
|
|
103
106
|
- 2.4
|
|
104
107
|
- 2.5
|
|
@@ -254,12 +257,13 @@ For a summary of those CLI options see [Command-Line Options](docs/Command-Line-
|
|
|
254
257
|
#### Configuration loading
|
|
255
258
|
|
|
256
259
|
Configuring Reek via a configuration file is by far the most powerful way.
|
|
260
|
+
Reek expects this filename to be `.reek.yml` but you can override this via the CLI `-c` switch (see below).
|
|
257
261
|
|
|
258
|
-
There are three ways of passing Reek
|
|
262
|
+
There are three ways of passing Reek the configuration file:
|
|
259
263
|
|
|
260
264
|
1. Using the CLI `-c` switch (see [_Command-line interface_](#command-line-interface) above)
|
|
261
|
-
2. Having
|
|
262
|
-
3. Having
|
|
265
|
+
2. Having the configuration file either in your current working directory or in a parent directory (more on that later)
|
|
266
|
+
3. Having the configuration file in your home directory
|
|
263
267
|
|
|
264
268
|
The order in which Reek tries to find such a configuration
|
|
265
269
|
file is exactly the above: first it checks if we have given
|
|
@@ -277,43 +281,46 @@ of how many `*.reek` files you might have on your filesystem.
|
|
|
277
281
|
|
|
278
282
|
We put a lot of effort into making Reek's configuration as self explanatory as possible so the
|
|
279
283
|
best way to understand it is by looking at a simple
|
|
280
|
-
example (e.g.
|
|
284
|
+
example (e.g. `.reek.yml` in your project directory):
|
|
281
285
|
|
|
282
286
|
```yaml
|
|
283
287
|
---
|
|
284
288
|
|
|
285
289
|
### Generic smell configuration
|
|
286
290
|
|
|
287
|
-
|
|
288
|
-
|
|
289
|
-
|
|
290
|
-
|
|
291
|
-
|
|
292
|
-
#
|
|
293
|
-
# because you
|
|
294
|
-
|
|
295
|
-
|
|
296
|
-
|
|
297
|
-
|
|
298
|
-
|
|
299
|
-
|
|
300
|
-
#
|
|
301
|
-
#
|
|
302
|
-
|
|
303
|
-
|
|
304
|
-
|
|
291
|
+
detectors:
|
|
292
|
+
# You can disable smells completely
|
|
293
|
+
IrresponsibleModule:
|
|
294
|
+
enabled: false
|
|
295
|
+
|
|
296
|
+
# You can use filters to silence Reek warnings.
|
|
297
|
+
# Either because you simply disagree with Reek (we are not the police) or
|
|
298
|
+
# because you want to fix this at a later point in time.
|
|
299
|
+
NestedIterators:
|
|
300
|
+
exclude:
|
|
301
|
+
- "MyWorker#self.class_method" # should be refactored
|
|
302
|
+
- "AnotherWorker#instance_method" # should be refactored as well
|
|
303
|
+
|
|
304
|
+
# A lot of smells allow fine tuning their configuration. You can look up all available options
|
|
305
|
+
# in the corresponding smell documentation in /docs. In most cases you probably can just go
|
|
306
|
+
# with the defaults as documented in defaults.reek.yml.
|
|
307
|
+
DataClump:
|
|
308
|
+
max_copies: 3
|
|
309
|
+
min_clump_size: 3
|
|
305
310
|
|
|
306
311
|
### Directory specific configuration
|
|
307
312
|
|
|
308
313
|
# You can configure smells on a per-directory base.
|
|
309
314
|
# E.g. the classic Rails case: controllers smell of NestedIterators (see /docs/Nested-Iterators.md) and
|
|
310
315
|
# helpers smell of UtilityFunction (see docs/Utility-Function.md)
|
|
311
|
-
|
|
312
|
-
|
|
313
|
-
|
|
314
|
-
|
|
315
|
-
|
|
316
|
-
|
|
316
|
+
# Note that we only allow configuration on a directory level, not a file level, so all paths have to point to directories.
|
|
317
|
+
directories:
|
|
318
|
+
"web_app/app/controllers":
|
|
319
|
+
NestedIterators:
|
|
320
|
+
enabled: false
|
|
321
|
+
"web_app/app/helpers":
|
|
322
|
+
UtilityFunction:
|
|
323
|
+
enabled: false
|
|
317
324
|
|
|
318
325
|
### Excluding directories
|
|
319
326
|
|
|
@@ -323,6 +330,14 @@ exclude_paths:
|
|
|
323
330
|
- lib/rake/legacy_tasks
|
|
324
331
|
```
|
|
325
332
|
|
|
333
|
+
As you see above, Reek's configuration consists of 3 different sections denoted by 3 different keys:
|
|
334
|
+
|
|
335
|
+
* detectors
|
|
336
|
+
* directories
|
|
337
|
+
* exclude_paths
|
|
338
|
+
|
|
339
|
+
Whatever you add to your configuration should be scoped under one of those keys.
|
|
340
|
+
|
|
326
341
|
If you have a directory directive for which a default directive exists, the more specific
|
|
327
342
|
one (which is the directory directive) will take precedence.
|
|
328
343
|
|
|
@@ -330,15 +345,12 @@ This configuration for instance:
|
|
|
330
345
|
|
|
331
346
|
```yaml
|
|
332
347
|
---
|
|
333
|
-
|
|
334
|
-
|
|
335
|
-
|
|
336
|
-
|
|
337
|
-
max_statements: 5
|
|
338
|
-
|
|
339
|
-
"app/controllers":
|
|
348
|
+
detectors:
|
|
349
|
+
IrresponsibleModule:
|
|
350
|
+
enabled: false
|
|
351
|
+
|
|
340
352
|
TooManyStatements:
|
|
341
|
-
max_statements:
|
|
353
|
+
max_statements: 5
|
|
342
354
|
```
|
|
343
355
|
|
|
344
356
|
translates to:
|
|
@@ -347,16 +359,53 @@ translates to:
|
|
|
347
359
|
* TooManyStatements#max_statements is 10 in "app/controllers"
|
|
348
360
|
* TooManyStatements#max_statements is 5 everywhere else
|
|
349
361
|
|
|
350
|
-
|
|
351
|
-
|
|
352
|
-
types offer a configuration that goes beyond that of the basic smell options, for instance
|
|
362
|
+
Every smell detector supports our [Basic Smell Options](docs/Basic-Smell-Options.md). As you can see above,
|
|
363
|
+
certain smell types offer a configuration that goes beyond that of the basic smell options, for instance
|
|
353
364
|
[Data Clump](docs/Data-Clump.md).
|
|
354
365
|
All options that go beyond the [Basic Smell Options](docs/Basic-Smell-Options.md)
|
|
355
366
|
are documented in the corresponding smell type /docs page (if you want to get a quick overview over all possible
|
|
356
|
-
configurations you can also check out [the `
|
|
367
|
+
configurations you can also check out [the `defaults.reek.yml` file in this repository](docs/defaults.reek.yml).
|
|
357
368
|
|
|
358
369
|
Note that you do not need a configuration file at all.
|
|
359
|
-
If you're fine with all the [defaults](defaults.reek) we set you can skip this completely.
|
|
370
|
+
If you're fine with all the [defaults.reek.yml](docs/defaults.reek.yml) we set you can skip this completely.
|
|
371
|
+
|
|
372
|
+
Don't worry about introducing a mistake in your configuration file that might go unnoticed - Reek uses a
|
|
373
|
+
schema to validate your configuration against on start up and will faily loudly in case you
|
|
374
|
+
misspelled an option or used the wrong data type for a value like this:
|
|
375
|
+
|
|
376
|
+
```
|
|
377
|
+
Error: We found some problems with your configuration file: [/detectors/DetectorWithTypo] key 'DetectorWithTypo:' is undefined.
|
|
378
|
+
```
|
|
379
|
+
|
|
380
|
+
Reek takes one configuration file and one configuration file only with `.reek.yml` being the default name.
|
|
381
|
+
|
|
382
|
+
In case you have to have one or more configuration files in the directory (e.g. you're
|
|
383
|
+
toying around with different, mutually exclusive settings) you need to tell Reek
|
|
384
|
+
explicitly which file to use via `reek -c config.reek`.
|
|
385
|
+
|
|
386
|
+
### Source code comments
|
|
387
|
+
|
|
388
|
+
In case you need to suppress a smell warning and you can't or don't want to
|
|
389
|
+
use configuration files for whatever reasons you can also use special
|
|
390
|
+
source code comments like this:
|
|
391
|
+
|
|
392
|
+
```Ruby
|
|
393
|
+
# This method smells of :reek:NestedIterators
|
|
394
|
+
def smelly_method foo
|
|
395
|
+
foo.each {|bar| bar.each {|baz| baz.qux}}
|
|
396
|
+
end
|
|
397
|
+
```
|
|
398
|
+
|
|
399
|
+
You can even pass in smell specific configuration settings:
|
|
400
|
+
|
|
401
|
+
```Ruby
|
|
402
|
+
# :reek:NestedIterators { max_allowed_nesting: 2 }
|
|
403
|
+
def smelly_method foo
|
|
404
|
+
foo.each {|bar| bar.each {|baz| baz.qux}}
|
|
405
|
+
end
|
|
406
|
+
```
|
|
407
|
+
|
|
408
|
+
This is an incredibly powerful feature and further explained under [Smell Suppresion](docs/Smell-Suppression.md).
|
|
360
409
|
|
|
361
410
|
### Generating a 'todo' list
|
|
362
411
|
|
|
@@ -404,42 +453,6 @@ reek -c other_configuration.reek --todo lib/
|
|
|
404
453
|
`other_configuration.reek` will simply be ignored (as outlined before, Reek
|
|
405
454
|
is supposed to have one configuration file and one file only).
|
|
406
455
|
|
|
407
|
-
### Beware of multiple configuration files
|
|
408
|
-
|
|
409
|
-
Reek takes one configuration file and one configuration file only.
|
|
410
|
-
|
|
411
|
-
If you have more than one configuration file in the same directory Reek
|
|
412
|
-
will not know what configuration file to use. If this happens Reek will
|
|
413
|
-
print a warning on STDERR and exit with the failure exit status 1.
|
|
414
|
-
|
|
415
|
-
In case you have to have one or more configuration files in the directory (e.g. you're
|
|
416
|
-
toying around with different, mutually exclusive settings) you need to tell Reek
|
|
417
|
-
explicitly which file to use via `reek -c config.reek`.
|
|
418
|
-
|
|
419
|
-
### Source code comments
|
|
420
|
-
|
|
421
|
-
In case you need to suppress a smell warning and you can't or don't want to
|
|
422
|
-
use configuration files for whatever reasons you can also use special
|
|
423
|
-
source code comments like this:
|
|
424
|
-
|
|
425
|
-
```Ruby
|
|
426
|
-
# This method smells of :reek:NestedIterators
|
|
427
|
-
def smelly_method foo
|
|
428
|
-
foo.each {|bar| bar.each {|baz| baz.qux}}
|
|
429
|
-
end
|
|
430
|
-
```
|
|
431
|
-
|
|
432
|
-
You can even pass in smell specific configuration settings:
|
|
433
|
-
|
|
434
|
-
```Ruby
|
|
435
|
-
# :reek:NestedIterators { max_allowed_nesting: 2 }
|
|
436
|
-
def smelly_method foo
|
|
437
|
-
foo.each {|bar| bar.each {|baz| baz.qux}}
|
|
438
|
-
end
|
|
439
|
-
```
|
|
440
|
-
|
|
441
|
-
This is an incredible powerful feature and further explained under [Smell Suppresion](docs/Smell-Suppression.md).
|
|
442
|
-
|
|
443
456
|
## Usage
|
|
444
457
|
|
|
445
458
|
Besides the obvious
|
|
@@ -559,23 +572,24 @@ Making Reek "Rails"-friendly is fairly simple since we support directory specifi
|
|
|
559
572
|
Just add this to your configuration file:
|
|
560
573
|
|
|
561
574
|
```Yaml
|
|
562
|
-
|
|
563
|
-
|
|
564
|
-
|
|
565
|
-
|
|
566
|
-
|
|
567
|
-
|
|
568
|
-
|
|
569
|
-
|
|
570
|
-
|
|
571
|
-
|
|
572
|
-
|
|
573
|
-
|
|
574
|
-
|
|
575
|
-
|
|
576
|
-
|
|
577
|
-
|
|
578
|
-
|
|
575
|
+
directories:
|
|
576
|
+
"app/controllers":
|
|
577
|
+
IrresponsibleModule:
|
|
578
|
+
enabled: false
|
|
579
|
+
NestedIterators:
|
|
580
|
+
max_allowed_nesting: 2
|
|
581
|
+
UnusedPrivateMethod:
|
|
582
|
+
enabled: false
|
|
583
|
+
InstanceVariableAssumption:
|
|
584
|
+
enabled: false
|
|
585
|
+
"app/helpers":
|
|
586
|
+
IrresponsibleModule:
|
|
587
|
+
enabled: false
|
|
588
|
+
UtilityFunction:
|
|
589
|
+
enabled: false
|
|
590
|
+
"app/mailers":
|
|
591
|
+
InstanceVariableAssumption:
|
|
592
|
+
enabled: false
|
|
579
593
|
```
|
|
580
594
|
|
|
581
595
|
Be careful though, Reek does not merge your configuration entries, so if you already have a directory directive for "app/controllers" or "app/helpers" you need to update those directives instead of copying the above YAML sample into your configuration file.
|
|
@@ -588,6 +602,7 @@ Be careful though, Reek does not merge your configuration entries, so if you alr
|
|
|
588
602
|
* [TextMate Bundle](https://github.com/peeyush1234/reek.tmbundle)
|
|
589
603
|
* [Atom plugin](https://atom.io/packages/linter-reek)
|
|
590
604
|
* [SublimeLinter plugin](https://packagecontrol.io/packages/SublimeLinter-contrib-reek)
|
|
605
|
+
* [VS Code plugin](https://github.com/rubyide/vscode-ruby)
|
|
591
606
|
* [Emacs plugin](https://github.com/hanmoi-choi/reek-emacs)
|
|
592
607
|
|
|
593
608
|
### Projects that use or support us
|
data/Rakefile
CHANGED
|
@@ -3,6 +3,19 @@ require 'rake/clean'
|
|
|
3
3
|
|
|
4
4
|
Dir['tasks/**/*.rake'].each { |t| load t }
|
|
5
5
|
|
|
6
|
-
task
|
|
7
|
-
|
|
8
|
-
|
|
6
|
+
task :ci do
|
|
7
|
+
[
|
|
8
|
+
'test:spec',
|
|
9
|
+
'configuration:update_default_configuration',
|
|
10
|
+
'test:features',
|
|
11
|
+
:rubocop,
|
|
12
|
+
'test:quality',
|
|
13
|
+
:ataru
|
|
14
|
+
].each do |name|
|
|
15
|
+
puts "\n=== Running #{name}...\n"
|
|
16
|
+
Rake::Task[name].invoke
|
|
17
|
+
puts "\n=== Running #{name} -> Done\n"
|
|
18
|
+
end
|
|
19
|
+
end
|
|
20
|
+
|
|
21
|
+
task default: :ci
|
data/bin/reek
CHANGED
data/docs/API.md
CHANGED
|
@@ -89,7 +89,7 @@ XMLReport
|
|
|
89
89
|
|
|
90
90
|
## Configuration
|
|
91
91
|
|
|
92
|
-
Given you have the following configuration file called
|
|
92
|
+
Given you have the following configuration file called `.reek.yml` in your root directory:
|
|
93
93
|
|
|
94
94
|
```Yaml
|
|
95
95
|
---
|
|
@@ -106,7 +106,7 @@ You can now use either
|
|
|
106
106
|
Reek::Configuration::AppConfiguration.from_path Pathname.new('config.reek')
|
|
107
107
|
```
|
|
108
108
|
|
|
109
|
-
but you can also pass a hash with the contents of the
|
|
109
|
+
but you can also pass a hash with the contents of the `.reek.yml` YAML file
|
|
110
110
|
to `Reek::Configuration::AppConfiguration.from_hash`.
|
|
111
111
|
|
|
112
112
|
Given the example above you would load that as follows:
|
|
@@ -140,13 +140,6 @@ string -- 2 warnings:
|
|
|
140
140
|
Dirty#call_me has the parameter name 'b' (UncommunicativeParameterName)
|
|
141
141
|
```
|
|
142
142
|
|
|
143
|
-
Instead of the smell detector names you can also use the full detector class in
|
|
144
|
-
your configuration hash, for example:
|
|
145
|
-
|
|
146
|
-
```ruby
|
|
147
|
-
config_hash = { Reek::SmellDetectors::IrresponsibleModule => { 'enabled' => false } }
|
|
148
|
-
```
|
|
149
|
-
|
|
150
143
|
Of course, directory specific configuration and excluded paths are supported as
|
|
151
144
|
well:
|
|
152
145
|
|
data/docs/Basic-Smell-Options.md
CHANGED
|
@@ -7,14 +7,14 @@ Every smell detector in Reek offers at least the following configuration options
|
|
|
7
7
|
| Option | Value | Effect |
|
|
8
8
|
| ---------------|-------------|---------|
|
|
9
9
|
| `enabled` | Boolean | Determines whether the smell detector is active. Defaults to `true` |
|
|
10
|
-
| `exclude` | an array of strings
|
|
10
|
+
| `exclude` | an array of strings that will be converted into regular expressions | Ignores any context whose full description matches any element of this array. |
|
|
11
11
|
|
|
12
|
-
The file `defaults.reek` (shipped with the Reek gem) lists any default
|
|
12
|
+
The file `docs/defaults.reek.yml` (shipped with the Reek gem) lists any default
|
|
13
13
|
exclusions for each smell.
|
|
14
14
|
|
|
15
15
|
## Examples
|
|
16
16
|
|
|
17
|
-
|
|
17
|
+
**An easy one:**
|
|
18
18
|
|
|
19
19
|
To stop Reek reporting smells in any method called `write` you might create a configuration file containing this:
|
|
20
20
|
|
|
@@ -24,15 +24,9 @@ DuplicateMethodCall:
|
|
|
24
24
|
- write
|
|
25
25
|
```
|
|
26
26
|
|
|
27
|
-
|
|
27
|
+
Internally Reek will convert this to the Regexp /write/.
|
|
28
28
|
|
|
29
|
-
|
|
30
|
-
DuplicateMethodCall:
|
|
31
|
-
exclude:
|
|
32
|
-
- !ruby/regexp /write/
|
|
33
|
-
```
|
|
34
|
-
|
|
35
|
-
<u>A more sophisticated one:</u>
|
|
29
|
+
**A more sophisticated one:**
|
|
36
30
|
|
|
37
31
|
```yaml
|
|
38
32
|
FeatureEnvy:
|
|
@@ -43,3 +37,49 @@ FeatureEnvy:
|
|
|
43
37
|
```
|
|
44
38
|
|
|
45
39
|
This would not report FeatureEnvy for the instance method `MyModel#do_things`, the whole module `MyHelper` and the `respond` instance method of `ApplicationController`
|
|
40
|
+
|
|
41
|
+
## Advanced configuration
|
|
42
|
+
|
|
43
|
+
Sometimes just strings are not enough for configuration. E.g. consider this code sample:
|
|
44
|
+
|
|
45
|
+
```Ruby
|
|
46
|
+
class Klass
|
|
47
|
+
def foo1; end
|
|
48
|
+
def foo1bar; end
|
|
49
|
+
end
|
|
50
|
+
```
|
|
51
|
+
Both "Klass#foo1" and "Klass#foo1bar" will smell of UncommunicativeMethodName. Now let's assume
|
|
52
|
+
you are ok with "Klass#foo1" but not "Klass#foo1bar".
|
|
53
|
+
Just having this configuration
|
|
54
|
+
|
|
55
|
+
```yaml
|
|
56
|
+
UncommunicativeMethodName:
|
|
57
|
+
exclude:
|
|
58
|
+
- "Klass#foo1"
|
|
59
|
+
```
|
|
60
|
+
|
|
61
|
+
wouldn't work because now "Klass#foo1bar" wouldn't smell as well.
|
|
62
|
+
|
|
63
|
+
For this reason Reek has a special syntax that allows you to use regexes by using a forward slash at the beginning and the end of the string.
|
|
64
|
+
Everything within the forward slashes will be loaded as a regex.
|
|
65
|
+
|
|
66
|
+
A possible configuration that hat excludes "Klass#foo1" from this scan but not "Klass#foo1bar" could look like this:
|
|
67
|
+
|
|
68
|
+
```yaml
|
|
69
|
+
UncommunicativeMethodName:
|
|
70
|
+
exclude:
|
|
71
|
+
- "/Klass#foo1$/"
|
|
72
|
+
```
|
|
73
|
+
|
|
74
|
+
## Reek 4
|
|
75
|
+
|
|
76
|
+
In Reek 4 you could also pass regexes to `exclude`, meaning this was perfectly valid as well:
|
|
77
|
+
|
|
78
|
+
```yaml
|
|
79
|
+
DuplicateMethodCall:
|
|
80
|
+
exclude:
|
|
81
|
+
- !ruby/regexp /write/
|
|
82
|
+
```
|
|
83
|
+
|
|
84
|
+
Support for this has been scrapped with Reek 5 to make the Reek configuration more yaml standard compliant.
|
|
85
|
+
You can still pass in regexes, you just have to wrap them into a string. Please see "Advanced configuration" above.
|
data/docs/Code-Smells.md
CHANGED
|
@@ -23,7 +23,7 @@ Reek currently includes checks for the following smells:
|
|
|
23
23
|
* [Utility Function](Utility-Function.md)
|
|
24
24
|
* [Module Initialize](Module-Initialize.md)
|
|
25
25
|
* [Nested Iterators](Nested-Iterators.md)
|
|
26
|
-
* [
|
|
26
|
+
* [Missing Safe Method](Missing-Safe-Method.md), formerly known as Prima Donna Method
|
|
27
27
|
* [Simulated Polymorphism](Simulated-Polymorphism.md), including
|
|
28
28
|
* [Manual Dispatch](Manual-Dispatch.md)
|
|
29
29
|
* [Nil Check](Nil-Check.md)
|
|
@@ -12,6 +12,16 @@ reek -h
|
|
|
12
12
|
|
|
13
13
|
for details.
|
|
14
14
|
|
|
15
|
+
## Telling Reek to use a specific configuration file
|
|
16
|
+
|
|
17
|
+
In case your configuration file is not in the standard location (that would be your project directory or
|
|
18
|
+
whatever directory you're running Reek from) you can specify a configuration file with the `-c` option
|
|
19
|
+
like this:
|
|
20
|
+
|
|
21
|
+
```Bash
|
|
22
|
+
reek -c /somewhere/on/your/filesystem/reek_config.yml lib/
|
|
23
|
+
```
|
|
24
|
+
|
|
15
25
|
## Telling Reek Which Code to Check
|
|
16
26
|
|
|
17
27
|
Probably the most standard use case would be to check all Ruby files in the lib directory:
|
|
@@ -91,10 +101,10 @@ mess.rb -- 2 warnings:
|
|
|
91
101
|
[2]:x has the name 'x' (UncommunicativeMethodName)
|
|
92
102
|
```
|
|
93
103
|
|
|
94
|
-
### Enable the
|
|
104
|
+
### Enable the verbose mode
|
|
95
105
|
|
|
96
|
-
_reek_ has a
|
|
97
|
-
This mode can be enabled via the "-U" or "--
|
|
106
|
+
_reek_ has a verbose mode which you might find helpful as a beginner. "verbose" just means that behind each warning a helpful link will be displayed which leads directly to the corresponding _reek_ documentation page.
|
|
107
|
+
This mode can be enabled via the "-U" or "--documentation" flag.
|
|
98
108
|
|
|
99
109
|
So for instance, if your test file would smell of _ClassVariable_, this is what the _reek_ output would look like:
|
|
100
110
|
|
|
@@ -103,7 +113,7 @@ reek -U test.rb
|
|
|
103
113
|
```
|
|
104
114
|
```
|
|
105
115
|
test.rb -- 1 warning:
|
|
106
|
-
[2]:Dummy declares the class variable @@class_variable (ClassVariable) [https://github.com/troessner/reek/
|
|
116
|
+
[2]:Dummy declares the class variable @@class_variable (ClassVariable) [https://github.com/troessner/reek/blob/master/docs/Class-Variable.md]
|
|
107
117
|
```
|
|
108
118
|
|
|
109
119
|
Note the link at the end.
|