reek 4.7.3 → 5.0.0

data/spec/reek/smell_detectors/duplicate_method_call_spec.rb

@@ -150,7 +150,7 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
     end
   end
 
-  context 'non-repeated method calls' do
+  context 'with non-repeated method calls' do
     it 'does not report similar calls' do
       src = 'def alfa(bravo) bravo.charlie == self.charlie end'
       expect(src).not_to reek_of(:DuplicateMethodCall)
@@ -162,7 +162,7 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
     end
   end
 
-  context 'allowing up to 3 calls' do
+  context 'when allowing up to 3 calls' do
     let(:config) do
       { Reek::SmellDetectors::DuplicateMethodCall::MAX_ALLOWED_CALLS_KEY => 3 }
     end
@@ -189,7 +189,7 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
     end
   end
 
-  context 'allowing calls to some methods' do
+  context 'when allowing calls to some methods' do
     it 'does not report calls to some methods' do
       config = { Reek::SmellDetectors::DuplicateMethodCall::ALLOW_CALLS_KEY => ['@bravo.charlie'] }
       src = 'def alfa; @bravo.charlie + @bravo.charlie; end'

data/spec/reek/smell_detectors/feature_envy_spec.rb

@@ -130,7 +130,7 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
         delta += bravo.foxtrot
         delta *= 1.15
       end
-      EOS
+    EOS
 
     expect(src).
       to reek_of(:FeatureEnvy, name: 'delta').
@@ -145,7 +145,7 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
         delta += bravo.echo
         delta += bravo.foxtrot
       end
-      EOS
+    EOS
 
     expect(src).
       to reek_of(:FeatureEnvy, name: 'delta').
@@ -247,4 +247,49 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
 
     expect(src).not_to reek_of(:FeatureEnvy)
   end
+
+  it 'does not report on class methods defined by opening the metaclass' do
+    src = <<-EOS
+      class Alfa
+        class << self
+          def bravo(charlie)
+            delta = new(charlie)
+            delta.echo
+            delta.echo
+          end
+        end
+      end
+    EOS
+
+    expect(src).not_to reek_of(:FeatureEnvy)
+  end
+
+  it 'does not report on class methods defined with an explicit receiver' do
+    src = <<-EOS
+      class Alfa
+        def self.bravo(charlie)
+          delta = new(charlie)
+          delta.echo
+          delta.echo
+        end
+      end
+    EOS
+
+    expect(src).not_to reek_of(:FeatureEnvy)
+  end
+
+  it 'does not report module functions' do
+    src = <<-EOF
+      module Alfa
+        module_function
+        def bravo(charlie)
+          echo = delta(charlie)
+          echo.foxtrot
+          echo.foxtrot
+        end
+      end
+    EOF
+
+    expect(src).not_to reek_of(:FeatureEnvy)
+  end
 end

data/spec/reek/smell_detectors/{prima_donna_method_spec.rb → missing_safe_method_spec.rb}

@@ -1,7 +1,7 @@
 require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/prima_donna_method'
+require_lib 'reek/smell_detectors/missing_safe_method'
 
-RSpec.describe Reek::SmellDetectors::PrimaDonnaMethod do
+RSpec.describe Reek::SmellDetectors::MissingSafeMethod do
   it 'reports the right values' do
     src = <<-EOS
       class Alfa
@@ -10,10 +10,10 @@ RSpec.describe Reek::SmellDetectors::PrimaDonnaMethod do
       end
     EOS
 
-    expect(src).to reek_of(:PrimaDonnaMethod,
+    expect(src).to reek_of(:MissingSafeMethod,
                            lines:   [2],
                            context: 'Alfa',
-                           message: "has prima donna method 'bravo!'",
+                           message: "has missing safe method 'bravo!'",
                            source:  'string',
                            name:    'bravo!')
   end
@@ -30,8 +30,8 @@ RSpec.describe Reek::SmellDetectors::PrimaDonnaMethod do
     EOS
 
     expect(src).
-      to reek_of(:PrimaDonnaMethod, lines: [2], name: 'bravo!').
-      and reek_of(:PrimaDonnaMethod, lines: [5], name: 'charlie!')
+      to reek_of(:MissingSafeMethod, lines: [2], name: 'bravo!').
+      and reek_of(:MissingSafeMethod, lines: [5], name: 'charlie!')
   end
 
   it 'reports nothing when method and bang counterpart exist' do
@@ -45,18 +45,18 @@ RSpec.describe Reek::SmellDetectors::PrimaDonnaMethod do
       end
     EOS
 
-    expect(src).not_to reek_of(:PrimaDonnaMethod)
+    expect(src).not_to reek_of(:MissingSafeMethod)
   end
 
   it 'does not report methods we excluded via comment' do
     source = <<-EOF
-      # :reek:PrimaDonnaMethod: { exclude: [ bravo! ] }
+      # :reek:MissingSafeMethod: { exclude: [ bravo! ] }
       class Alfa
         def bravo!
         end
       end
     EOF
 
-    expect(source).not_to reek_of(:PrimaDonnaMethod)
+    expect(source).not_to reek_of(:MissingSafeMethod)
   end
 end

data/spec/reek/smell_detectors/module_initialize_spec.rb

@@ -50,6 +50,20 @@ RSpec.describe Reek::SmellDetectors::ModuleInitialize do
     expect(src).not_to reek_of(:ModuleInitialize)
   end
 
+  it 'reports nothing for a method named initialize in a nested dynamic class' do
+    src = <<-EOF
+      module Alfa
+        def self.bravo
+          Class.new do
+            def initialize; end
+          end
+        end
+      end
+    EOF
+
+    expect(src).not_to reek_of(:ModuleInitialize)
+  end
+
   it 'can be disabled via comment' do
     src = <<-EOS
       # :reek:ModuleInitialize

data/spec/reek/smell_detectors/nested_iterators_spec.rb

@@ -223,7 +223,7 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
     expect(src).not_to reek_of(:NestedIterators)
   end
 
-  context 'setting the allowed nesting depth to 3' do
+  context 'when setting the allowed nesting depth to 3' do
     let(:config) do
       { Reek::SmellDetectors::NestedIterators::MAX_ALLOWED_NESTING_KEY => 3 }
     end

data/spec/reek/smell_detectors/too_many_constants_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe Reek::SmellDetectors::TooManyConstants do
 
   it 'does not report when increasing default' do
     src = <<-EOS
-      # :reek:TooManyConstants: { max_constants: 3 }
+      # :reek:TooManyConstants { max_constants: 3 }
       class Alfa
         Bravo = Charlie = Delta = 1
       end
@@ -44,7 +44,7 @@ RSpec.describe Reek::SmellDetectors::TooManyConstants do
 
   it 'does not report when disabled' do
     src = <<-EOS
-      # :reek:TooManyConstants: { enabled: false }
+      # :reek:TooManyConstants { enabled: false }
       class Alfa
         Bravo = Charlie = Delta = 1
       end
@@ -96,7 +96,7 @@ RSpec.describe Reek::SmellDetectors::TooManyConstants do
   it 'does not report outer module when inner module suppressed' do
     src = <<-EOS
       module Alfa
-        # ignore :reek:TooManyConstants:
+        # ignore :reek:TooManyConstants
         module Bravo
           Charlie = Delta = Echo = 1
         end

data/spec/reek/smell_detectors/too_many_instance_variables_spec.rb

@@ -37,7 +37,7 @@ RSpec.describe Reek::SmellDetectors::TooManyInstanceVariables do
 
   it 'has a configurable maximum' do
     src = <<-EOS
-      # :reek:TooManyInstanceVariables: { max_instance_variables: 3 }
+      # :reek:TooManyInstanceVariables { max_instance_variables: 3 }
       class Alfa
         def bravo
           @charlie = @delta = @echo = 1

data/spec/reek/smell_detectors/uncommunicative_method_name_spec.rb

@@ -41,18 +41,18 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeMethodName do
   describe '`accept` patterns' do
     let(:source) { 'def x; end' }
 
-    it 'make smelly names pass via regex / strings given by list / literal' do
-      [[/x/], /x/, ['x'], 'x'].each do |pattern|
-        expect(source).not_to reek_of(:UncommunicativeMethodName).with_config('accept' => pattern)
-      end
+    it 'make smelly names pass' do
+      pattern = /x/
+      expect(source).not_to reek_of(:UncommunicativeMethodName).with_config('accept' => pattern)
     end
   end
 
   describe '`reject` patterns' do
     let(:source) { 'def alfa; end' }
 
-    it 'reject smelly names via regex / strings given by list / literal' do
-      [[/alfa/], /alfa/, ['alfa'], 'alfa'].each do |pattern|
+    it 'reject smelly names' do
+      patterns = [/alf/, /lfa/]
+      patterns.each do |pattern|
         expect(source).to reek_of(:UncommunicativeMethodName).with_config('reject' => pattern)
       end
     end

data/spec/reek/smell_detectors/uncommunicative_module_name_spec.rb

@@ -39,8 +39,9 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeModuleName do
   describe '`accept` patterns' do
     let(:source) { 'class Alfa1; end' }
 
-    it 'makes smelly names pass via regex / strings given by list / literal' do
-      [[/lfa/], /lfa/, ['lfa'], 'lfa'].each do |pattern|
+    it 'make smelly names pass ' do
+      patterns = [/lfa1/, /Alfa1/]
+      patterns.each do |pattern|
         expect(source).not_to reek_of(:UncommunicativeModuleName).with_config('accept' => pattern)
       end
     end
@@ -49,8 +50,9 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeModuleName do
   describe '`reject` patterns' do
     let(:source) { 'class Alfa; end' }
 
-    it 'rejects smelly names via regex / strings given by list / literal' do
-      [[/Alfa/], /Alfa/, ['Alfa'], 'Alfa'].each do |pattern|
+    it 'reject smelly names' do
+      patterns = [/lfa/, /Alf/]
+      patterns.each do |pattern|
         expect(source).to reek_of(:UncommunicativeModuleName).with_config('reject' => pattern)
       end
     end

data/spec/reek/smell_detectors/uncommunicative_parameter_name_spec.rb

@@ -107,8 +107,9 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeParameterName do
   describe '`accept` patterns' do
     let(:source) { 'def alfa(bar2); charlie(bar2); end' }
 
-    it 'make smelly names pass via regex / strings given by list / literal' do
-      [[/bar2/], /bar2/, ['bar2'], 'bar2'].each do |pattern|
+    it 'make smelly names pass' do
+      patterns = [/bar2/, /ar2/]
+      patterns.each do |pattern|
         expect(source).not_to reek_of(:UncommunicativeParameterName).with_config('accept' => pattern)
       end
     end
@@ -117,8 +118,9 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeParameterName do
   describe '`reject` patterns' do
     let(:source) { 'def alfa(bravo); charlie(bravo); end' }
 
-    it 'reject smelly names via regex / strings given by list / literal' do
-      [[/bravo/], /bravo/, ['bravo'], 'bravo'].each do |pattern|
+    it 'reject smelly names' do
+      patterns = [/brav/, /ravo/]
+      patterns.each do |pattern|
         expect(source).to reek_of(:UncommunicativeParameterName).with_config('reject' => pattern)
       end
     end

data/spec/reek/smell_detectors/uncommunicative_variable_name_spec.rb

@@ -29,7 +29,7 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
       and reek_of(:UncommunicativeVariableName, lines: [3], name: 'y')
   end
 
-  context 'instance variables' do
+  context 'when examining instance variables' do
     it 'does not report use of one-letter names' do
       src = 'class Alfa; def bravo; @x; end; end'
       expect(src).not_to reek_of(:UncommunicativeVariableName)
@@ -41,7 +41,7 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
     end
   end
 
-  context 'local variables' do
+  context 'when examining local variables' do
     it 'does not report single underscore as a variable name' do
       src = 'def alfa; _ = bravo(); end'
       expect(src).not_to reek_of(:UncommunicativeVariableName)
@@ -78,7 +78,7 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
     end
   end
 
-  context 'block parameters' do
+  context 'when examining block parameters' do
     it 'reports all relevant block parameters' do
       src = <<-EOS
         def alfa
@@ -159,9 +159,9 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
   describe '`accept` patterns' do
     let(:src) { 'def alfa; bravo2 = 42; end' }
 
-    # FIXME: Move the loop out of the it?
-    it 'make smelly names pass via regex / strings given by list / literal' do
-      [[/bravo2/], /bravo2/, ['bravo2'], 'bravo2'].each do |pattern|
+    it 'make smelly names pass' do
+      patterns = [/ravo2/, /bravo2/]
+      patterns.each do |pattern|
         expect(src).to reek_of(:UncommunicativeVariableName).
           and not_reek_of(:UncommunicativeVariableName).with_config('accept' => pattern)
       end
@@ -171,9 +171,9 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
   describe '`reject` patterns' do
     let(:src) { 'def alfa; foobar = 42; end' }
 
-    # FIXME: Move the loop out of the it?
-    it 'reject smelly names via regex / strings given by list / literal' do
-      [[/foobar/], /foobar/, ['foobar'], 'foobar'].each do |pattern|
+    it 'reject smelly names' do
+      patterns = [/fooba/, /oobar/]
+      patterns.each do |pattern|
         expect(src).to not_reek_of(:UncommunicativeVariableName).
           and reek_of(:UncommunicativeVariableName).with_config('reject' => pattern)
       end

data/spec/reek/smell_detectors/unused_parameters_spec.rb

@@ -61,7 +61,7 @@ RSpec.describe Reek::SmellDetectors::UnusedParameters do
     expect(src).not_to reek_of(:UnusedParameters)
   end
 
-  context 'using super' do
+  context 'when using super' do
     it 'reports nothing with implicit arguments' do
       src = 'def alfa(*bravo); super; end'
       expect(src).not_to reek_of(:UnusedParameters)
@@ -83,7 +83,7 @@ RSpec.describe Reek::SmellDetectors::UnusedParameters do
     end
   end
 
-  context 'anonymous parameters' do
+  context 'with anonymous parameters' do
     it 'reports nothing for unused anonymous parameter' do
       src = 'def alfa(_); end'
       expect(src).not_to reek_of(:UnusedParameters)
@@ -95,7 +95,7 @@ RSpec.describe Reek::SmellDetectors::UnusedParameters do
     end
   end
 
-  context 'splatted parameters' do
+  context 'with splatted parameters' do
     it 'reports nothing for used splatted parameter' do
       src = 'def alfa(*bravo); bravo; end'
       expect(src).not_to reek_of(:UnusedParameters)

data/spec/reek/smell_detectors/unused_private_method_spec.rb

@@ -38,7 +38,7 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
       and reek_of(:UnusedPrivateMethod, lines: [7], name: 'charlie')
   end
 
-  context 'unused private methods' do
+  context 'when a class has unused private methods' do
     it 'reports instance methods' do
       source = <<-EOF
         class Alfa
@@ -116,10 +116,10 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
   end
 
-  describe 'configuring the detector via source code comment' do
+  context 'when the detector is configured via a source code comment' do
     it 'does not report methods we excluded' do
       source = <<-EOF
-        # :reek:UnusedPrivateMethod: { exclude: [ bravo ] }
+        # :reek:UnusedPrivateMethod { exclude: [ bravo ] }
         class Alfa
           private
           def bravo; end
@@ -133,8 +133,8 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
   end
 
-  context 'used private methods' do
-    it 'are not reported' do
+  context 'when a class has only used private methods' do
+    it 'reports nothing' do
       source = <<-EOF
         class Alfa
           def bravo
@@ -150,8 +150,8 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
   end
 
-  context 'unused protected methods' do
-    it 'are not reported' do
+  context 'when a class has unused protected methods' do
+    it 'reports nothing' do
       source = <<-EOF
         class Alfa
           protected
@@ -163,8 +163,8 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
   end
 
-  context 'unused public methods' do
-    it 'are not reported' do
+  context 'when a class has unused public methods' do
+    it 'reports nothing' do
       source = <<-EOF
         class Alfa
           def bravo; end
@@ -175,7 +175,7 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
   end
 
-  describe 'prevent methods from being reported' do
+  describe 'preventing methods from being reported' do
     let(:source) do
       <<-EOF
         class Alfa

data/spec/reek/smell_detectors/utility_function_spec.rb

@@ -98,7 +98,7 @@ RSpec.describe Reek::SmellDetectors::UtilityFunction do
     expect(src).to reek_of(:UtilityFunction, context: 'simple')
   end
 
-  context 'Singleton methods' do
+  context 'when examining singleton methods' do
     ['class', 'module'].each do |scope|
       it "does not report for #{scope} with `class << self` notation" do
         src = "#{scope} Alfa; class << self; def bravo(charlie) charlie.to_s; end; end; end"
@@ -111,7 +111,7 @@ RSpec.describe Reek::SmellDetectors::UtilityFunction do
       end
     end
 
-    context 'by using `module_function`' do
+    context 'when defined by using `module_function`' do
       it 'does not report UtilityFunction also when using multiple arguments' do
         src = <<-EOS
           class Alfa
@@ -194,7 +194,7 @@ RSpec.describe Reek::SmellDetectors::UtilityFunction do
       { Reek::SmellDetectors::UtilityFunction::PUBLIC_METHODS_ONLY_KEY => true }
     end
 
-    context 'public methods' do
+    context 'when examining public methods' do
       it 'still reports UtilityFunction' do
         src = <<-EOS
           class Alfa
@@ -208,7 +208,7 @@ RSpec.describe Reek::SmellDetectors::UtilityFunction do
       end
     end
 
-    context 'private methods' do
+    context 'when examining private methods' do
       it 'does not report UtilityFunction' do
         src = <<-EOS
           class Alfa
@@ -235,7 +235,7 @@ RSpec.describe Reek::SmellDetectors::UtilityFunction do
       end
     end
 
-    context 'protected methods' do
+    context 'when examining protected methods' do
       it 'does not report UtilityFunction' do
         src = <<-EOS
           class Alfa

data/spec/reek/smell_warning_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Reek::SmellWarning do
   let(:utility_function_detector) { build(:smell_detector, smell_type: 'UtilityFunction') }
   let(:uncommunicative_name_detector) { build(:smell_detector, smell_type: 'UncommunicativeVariableName') }
 
-  context 'sort order' do
+  describe 'sort order' do
     shared_examples_for 'first sorts ahead of second' do
       it 'hash differently' do
         expect(first.hash).not_to eq(second.hash)
@@ -26,21 +26,21 @@ RSpec.describe Reek::SmellWarning do
       end
     end
 
-    context 'smells differing only by detector' do
+    context 'when smells differ only by detector' do
       let(:first) { build(:smell_warning, smell_detector: duplication_detector) }
       let(:second) { build(:smell_warning, smell_detector: feature_envy_detector) }
 
       it_behaves_like 'first sorts ahead of second'
     end
 
-    context 'smells differing only by lines' do
+    context 'when smells differ only by lines' do
       let(:first) { build(:smell_warning, smell_detector: feature_envy_detector, lines: [2]) }
       let(:second) { build(:smell_warning, smell_detector: feature_envy_detector, lines: [3]) }
 
       it_behaves_like 'first sorts ahead of second'
     end
 
-    context 'smells differing only by context' do
+    context 'when smells differ only by context' do
       let(:first) { build(:smell_warning, smell_detector: duplication_detector, context: 'first') }
       let(:second) do
         build(:smell_warning, smell_detector: duplication_detector, context: 'second')
@@ -49,7 +49,7 @@ RSpec.describe Reek::SmellWarning do
       it_behaves_like 'first sorts ahead of second'
     end
 
-    context 'smells differing only by message' do
+    context 'when smells differ only by message' do
       let(:first) do
         build(:smell_warning, smell_detector: duplication_detector,
                               context: 'ctx', message: 'first message')
@@ -62,7 +62,7 @@ RSpec.describe Reek::SmellWarning do
       it_behaves_like 'first sorts ahead of second'
     end
 
-    context 'smell name takes precedence over message' do
+    context 'when smells differ by name and message' do
       let(:first) do
         build(:smell_warning, smell_detector: feature_envy_detector, message: 'second message')
       end
@@ -73,7 +73,7 @@ RSpec.describe Reek::SmellWarning do
       it_behaves_like 'first sorts ahead of second'
     end
 
-    context 'smells differing everywhere' do
+    context 'when smells differ everywhere' do
       let(:first) do
         build(:smell_warning, smell_detector: duplication_detector,
                               context: 'Dirty#a',
@@ -97,7 +97,7 @@ RSpec.describe Reek::SmellWarning do
     end
   end
 
-  context '#yaml_hash' do
+  describe '#yaml_hash' do
     let(:context_name) { 'Module::Class#method/block' }
     let(:lines) { [24, 513] }
     let(:message) { 'test message' }
@@ -135,6 +135,10 @@ RSpec.describe Reek::SmellWarning do
       expect(yaml['source']).to eq source
     end
 
+    it 'includes the documentation link' do
+      expect(yaml['documentation_link']).to eq Reek::DocumentationLink.build('FeatureEnvy')
+    end
+
     it 'includes the parameters' do
       parameters.each do |key, value|
         expect(yaml[key]).to eq value

data/spec/reek/source/source_code_spec.rb

@@ -6,86 +6,60 @@ RSpec.describe Reek::Source::SourceCode do
   describe '#syntax_tree' do
     it 'associates comments with the AST' do
       source = "# this is\n# a comment\ndef foo; end"
-      source_code = described_class.new(code: source, origin: '(string)')
+      source_code = described_class.new(source: source, origin: '(string)')
       result = source_code.syntax_tree
       expect(result.leading_comment).to eq "# this is\n# a comment"
     end
 
     it 'cleanly processes empty source' do
-      source_code = described_class.new(code: '', origin: '(string)')
+      source_code = described_class.new(source: '', origin: '(string)')
       result = source_code.syntax_tree
-      expect(result).to be_nil
+      expect(result.type).to eq :empty
     end
 
     it 'cleanly processes empty source with comments' do
       source = "# this is\n# a comment\n"
-      source_code = described_class.new(code: source, origin: '(string)')
+      source_code = described_class.new(source: source, origin: '(string)')
       result = source_code.syntax_tree
-      expect(result).to be_nil
+      expect(result.type).to eq :empty
     end
 
     it 'does not crash with sequences incompatible with UTF-8' do
       source = '"\xFF"'
-      source_code = described_class.new(code: source, origin: '(string)')
+      source_code = described_class.new(source: source, origin: '(string)')
       result = source_code.syntax_tree
       expect(result.children.first).to eq "\xFF"
     end
 
     it 'returns a :lambda node for lambda expressions' do
       source = '->() { }'
-      source_code = described_class.new(code: source, origin: '(string)')
+      source_code = described_class.new(source: source, origin: '(string)')
       result = source_code.syntax_tree
       expect(result.children.first.type).to eq :lambda
     end
-  end
-
-  context 'with a source that triggers an encoding error' do
-    let(:source_name) { 'Bad source' }
-    let(:code) do
-      <<-SRC.strip_heredoc
-      # encoding: US-ASCII
-      puts 'こんにちは世界'
-      SRC
-    end
-    let(:src) { described_class.new(code: code, origin: source_name) }
 
-    it 'raises an encoding error' do
-      expect { src.syntax_tree }.to raise_error Reek::Errors::EncodingError
-    end
-
-    it 'explains the origin of the error' do
-      message = "Source '#{source_name}' cannot be processed by Reek due to an encoding error in the source file."
-      expect { src.syntax_tree }.to raise_error.with_message(/#{message}/)
-    end
-  end
-
-  context 'when the parser fails' do
-    let(:source_name) { 'Test source' }
-    let(:src) { described_class.new(code: code, origin: source_name, **parser) }
-
-    context 'with a Parser::SyntaxError' do
+    context 'when the parser fails with a Parser::SyntaxError' do
+      let(:src) { described_class.new(source: code) }
       let(:code) { '== Invalid Syntax ==' }
-      let(:parser) { {} }
 
-      it 'adds a diagnostic' do
-        expect(src.diagnostics.size).to eq 2
+      it 'raises the error' do
+        expect { src.syntax_tree }.to raise_error Parser::SyntaxError
       end
     end
 
-    context 'with a generic error' do
+    context 'when the parser fails with a generic error' do
       let(:code) { '' }
+      let(:parser) { instance_double('Parser::Ruby25') }
+      let(:src) { described_class.new(source: code, parser: parser) }
       let(:error_class) { RuntimeError }
       let(:error_message) { 'An error' }
-      let(:parser) do
-        parser = instance_double('Parser::Ruby24')
+
+      before do
         allow(parser).to receive(:parse_with_comments).and_raise(error_class, error_message)
-        {
-          parser: parser
-        }
       end
 
       it 'raises the error' do
-        expect { src.valid_syntax? }.to raise_error error_class, error_message
+        expect { src.syntax_tree }.to raise_error error_class, error_message
       end
     end
   end