reek 4.7.2 → 4.7.3

data/spec/reek/spec/should_reek_spec.rb

@@ -8,11 +8,11 @@ RSpec.describe Reek::Spec::ShouldReek do
     let(:smelly_code) { 'def x() y = 4; end' }
 
     it 'matches a smelly String' do
-      expect(matcher.matches?(smelly_code)).to be_truthy
+      expect(matcher).to be_matches(smelly_code)
     end
 
     it 'doesnt match a fragrant String' do
-      expect(matcher.matches?(clean_code)).to be_falsey
+      expect(matcher).not_to be_matches(clean_code)
     end
 
     it 'reports the smells when should_not fails' do
@@ -26,11 +26,11 @@ RSpec.describe Reek::Spec::ShouldReek do
       let(:matcher) { described_class.new }
 
       it 'matches a smelly File' do
-        expect(matcher.matches?(SMELLY_FILE)).to be_truthy
+        expect(matcher).to be_matches(SMELLY_FILE)
       end
 
       it 'doesnt match a fragrant File' do
-        expect(matcher.matches?(CLEAN_FILE)).to be_falsey
+        expect(matcher).not_to be_matches(CLEAN_FILE)
       end
 
       it 'reports the smells when should_not fails' do
@@ -45,7 +45,7 @@ RSpec.describe Reek::Spec::ShouldReek do
       let(:matcher) { described_class.new(configuration: configuration) }
 
       it 'masks smells using the relevant configuration' do
-        expect(matcher.matches?(SMELLY_FILE)).to be_falsey
+        expect(matcher).not_to be_matches(SMELLY_FILE)
       end
     end
   end

data/spec/reek/spec/smell_matcher_spec.rb

@@ -12,33 +12,33 @@ RSpec.describe Reek::Spec::SmellMatcher do
 
   context '#matches?' do
     it 'matches on class symbol' do
-      expect(matcher.matches?(:UncommunicativeVariableName)).to be_truthy
+      expect(matcher).to be_matches(:UncommunicativeVariableName)
     end
 
     it 'matches on class symbol and params' do
-      expect(matcher.matches?(:UncommunicativeVariableName,
-                              test: 'something')).to be_truthy
+      expect(matcher).to be_matches(:UncommunicativeVariableName,
+                                    test: 'something')
     end
 
     it 'matches on class symbol, params and attributes' do
-      expect(matcher.matches?(:UncommunicativeVariableName,
-                              test: 'something',
-                              message: "has the variable name '@s'")).to be_truthy
+      expect(matcher).to be_matches(:UncommunicativeVariableName,
+                                    test: 'something',
+                                    message: "has the variable name '@s'")
     end
 
     it 'does not match on different class symbol' do
-      expect(matcher.matches?(:FeatureEnvy)).to be_falsy
+      expect(matcher).not_to be_matches(:FeatureEnvy)
     end
 
     it 'does not match on different params' do
-      expect(matcher.matches?(:UncommunicativeVariableName,
-                              test: 'something else')).to be_falsy
+      expect(matcher).not_to be_matches(:UncommunicativeVariableName,
+                                        test: 'something else')
     end
 
     it 'does not match on different attributes' do
-      expect(matcher.matches?(:UncommunicativeVariableName,
-                              test: 'something',
-                              message: 'nothing')).to be_falsy
+      expect(matcher).not_to be_matches(:UncommunicativeVariableName,
+                                        test: 'something',
+                                        message: 'nothing')
     end
 
     it 'raises error on uncomparable attribute' do
@@ -52,31 +52,31 @@ RSpec.describe Reek::Spec::SmellMatcher do
 
   context '#matches_smell_type?' do
     it 'matches on class symbol' do
-      expect(matcher.matches_smell_type?(:UncommunicativeVariableName)).to be_truthy
+      expect(matcher).to be_matches_smell_type(:UncommunicativeVariableName)
     end
 
     it 'does not match on different class symbol' do
-      expect(matcher.matches_smell_type?(:FeatureEnvy)).to be_falsy
+      expect(matcher).not_to be_matches_smell_type(:FeatureEnvy)
     end
   end
 
   context '#matches_attributes?' do
     it 'matches on params' do
-      expect(matcher.matches_attributes?(test: 'something')).to be_truthy
+      expect(matcher).to be_matches_attributes(test: 'something')
     end
 
     it 'matches on class symbol, params and attributes' do
-      expect(matcher.matches_attributes?(test: 'something',
-                                         message: "has the variable name '@s'")).to be_truthy
+      expect(matcher).to be_matches_attributes(test: 'something',
+                                               message: "has the variable name '@s'")
     end
 
     it 'does not match on different params' do
-      expect(matcher.matches_attributes?(test: 'something else')).to be_falsy
+      expect(matcher).not_to be_matches_attributes(test: 'something else')
     end
 
     it 'does not match on different attributes' do
-      expect(matcher.matches_attributes?(test: 'something',
-                                         message: 'nothing')).to be_falsy
+      expect(matcher).not_to be_matches_attributes(test: 'something',
+                                                   message: 'nothing')
     end
 
     it 'raises error on uncomparable attribute' do

data/spec/spec_helper.rb

@@ -90,7 +90,7 @@ RSpec.configure do |config|
   # mutation tester. Set the DEBUG environment variable to something truthy
   # like '1' to disable this and allow using pry without specs failing.
   unless ENV['DEBUG']
-    config.around(:each) do |example|
+    config.around do |example|
       Timeout.timeout(5, &example)
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.7.2
+  version: 4.7.3
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-24 00:00:00.000000000 Z
+date: 2017-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb
@@ -160,12 +160,14 @@ files:
 - features/configuration_loading.feature
 - features/configuration_via_source_comments/erroneous_source_comments.feature
 - features/configuration_via_source_comments/well_formed_source_comments.feature
+- features/locales.feature
 - features/programmatic_access.feature
 - features/rake_task/rake_task.feature
 - features/reports/codeclimate.feature
 - features/reports/json.feature
 - features/reports/reports.feature
 - features/reports/yaml.feature
+- features/rspec_matcher.feature
 - features/samples.feature
 - features/step_definitions/.rubocop.yml
 - features/step_definitions/reek_steps.rb
@@ -230,6 +232,7 @@ files:
 - lib/reek/errors/bad_detector_configuration_key_in_comment_error.rb
 - lib/reek/errors/bad_detector_in_comment_error.rb
 - lib/reek/errors/base_error.rb
+- lib/reek/errors/encoding_error.rb
 - lib/reek/errors/garbage_detector_configuration_in_comment_error.rb
 - lib/reek/errors/incomprehensible_source_error.rb
 - lib/reek/examiner.rb
@@ -443,7 +446,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Code smell detector for Ruby