reek 4.6.0 → 5.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.codeclimate.yml +17 -12
- data/.rubocop.yml +79 -26
- data/.simplecov +1 -0
- data/.travis.yml +3 -9
- data/.yardopts +1 -1
- data/CHANGELOG.md +76 -0
- data/CONTRIBUTING.md +1 -1
- data/Gemfile +5 -5
- data/README.md +138 -107
- data/Rakefile +16 -3
- data/bin/code_climate_reek +1 -0
- data/bin/reek +2 -3
- data/docs/API.md +2 -9
- data/docs/Basic-Smell-Options.md +51 -11
- data/docs/Code-Smells.md +1 -1
- data/docs/Command-Line-Options.md +14 -4
- data/docs/Duplicate-Method-Call.md +49 -1
- data/docs/Feature-Envy.md +44 -0
- data/docs/How-To-Write-New-Detectors.md +7 -7
- data/docs/Instance-Variable-Assumption.md +1 -1
- data/docs/{Prima-Donna-Method.md → Missing-Safe-Method.md} +11 -9
- data/docs/Rake-Task.md +1 -1
- data/docs/Reek-4-to-Reek-5-migration.md +193 -0
- data/docs/Reek-Driven-Development.md +1 -1
- data/docs/Uncommunicative-Method-Name.md +45 -6
- data/docs/Uncommunicative-Module-Name.md +49 -7
- data/docs/Uncommunicative-Parameter-Name.md +43 -5
- data/docs/Uncommunicative-Variable-Name.md +73 -2
- data/docs/Unused-Private-Method.md +3 -3
- data/docs/defaults.reek.yml +129 -0
- data/docs/yard_plugin.rb +1 -0
- data/features/command_line_interface/basic_usage.feature +2 -2
- data/features/command_line_interface/options.feature +46 -4
- data/features/command_line_interface/show_progress.feature +4 -4
- data/features/command_line_interface/smell_selection.feature +1 -1
- data/features/command_line_interface/smells_count.feature +6 -6
- data/features/command_line_interface/stdin.feature +31 -5
- data/features/configuration_files/accept_setting.feature +45 -28
- data/features/configuration_files/directory_specific_directives.feature +80 -75
- data/features/configuration_files/exclude_directives.feature +11 -10
- data/features/configuration_files/exclude_paths_directives.feature +4 -4
- data/features/configuration_files/masking_smells.feature +38 -9
- data/features/configuration_files/mix_accept_reject_setting.feature +31 -28
- data/features/configuration_files/reject_setting.feature +52 -41
- data/features/configuration_files/schema_validation.feature +59 -0
- data/features/configuration_files/unused_private_method.feature +18 -16
- data/features/configuration_loading.feature +53 -10
- data/features/configuration_via_source_comments/erroneous_source_comments.feature +3 -3
- data/features/configuration_via_source_comments/well_formed_source_comments.feature +2 -2
- data/features/locales.feature +32 -0
- data/features/rake_task/rake_task.feature +58 -18
- data/features/reports/codeclimate.feature +59 -0
- data/features/reports/json.feature +3 -3
- data/features/reports/reports.feature +34 -34
- data/features/reports/yaml.feature +3 -3
- data/features/rspec_matcher.feature +40 -0
- data/features/samples.feature +287 -287
- data/features/step_definitions/reek_steps.rb +14 -2
- data/features/step_definitions/sample_file_steps.rb +9 -4
- data/features/support/env.rb +2 -11
- data/features/todo_list.feature +26 -23
- data/lib/reek/ast/ast_node_class_map.rb +1 -0
- data/lib/reek/ast/builder.rb +16 -0
- data/lib/reek/ast/node.rb +50 -58
- data/lib/reek/ast/object_refs.rb +2 -1
- data/lib/reek/ast/reference_collector.rb +3 -4
- data/lib/reek/ast/sexp_extensions/arguments.rb +1 -0
- data/lib/reek/ast/sexp_extensions/attribute_assignments.rb +1 -0
- data/lib/reek/ast/sexp_extensions/begin.rb +17 -0
- data/lib/reek/ast/sexp_extensions/block.rb +1 -0
- data/lib/reek/ast/sexp_extensions/case.rb +2 -1
- data/lib/reek/ast/sexp_extensions/constant.rb +1 -0
- data/lib/reek/ast/sexp_extensions/if.rb +9 -1
- data/lib/reek/ast/sexp_extensions/lambda.rb +1 -0
- data/lib/reek/ast/sexp_extensions/literal.rb +1 -0
- data/lib/reek/ast/sexp_extensions/logical_operators.rb +2 -1
- data/lib/reek/ast/sexp_extensions/methods.rb +5 -6
- data/lib/reek/ast/sexp_extensions/module.rb +55 -8
- data/lib/reek/ast/sexp_extensions/nested_assignables.rb +1 -0
- data/lib/reek/ast/sexp_extensions/self.rb +1 -0
- data/lib/reek/ast/sexp_extensions/send.rb +1 -4
- data/lib/reek/ast/sexp_extensions/super.rb +1 -0
- data/lib/reek/ast/sexp_extensions/symbols.rb +1 -0
- data/lib/reek/ast/sexp_extensions/variables.rb +1 -0
- data/lib/reek/ast/sexp_extensions/when.rb +1 -0
- data/lib/reek/ast/sexp_extensions/yield.rb +1 -0
- data/lib/reek/ast/sexp_extensions.rb +2 -0
- data/lib/reek/cli/application.rb +5 -3
- data/lib/reek/cli/command/base_command.rb +1 -0
- data/lib/reek/cli/command/report_command.rb +2 -2
- data/lib/reek/cli/command/todo_list_command.rb +9 -8
- data/lib/reek/cli/options.rb +32 -16
- data/lib/reek/cli/silencer.rb +15 -3
- data/lib/reek/cli/status.rb +1 -0
- data/lib/reek/code_comment.rb +14 -16
- data/lib/reek/configuration/app_configuration.rb +34 -28
- data/lib/reek/configuration/configuration_converter.rb +110 -0
- data/lib/reek/configuration/configuration_file_finder.rb +17 -41
- data/lib/reek/configuration/configuration_validator.rb +13 -23
- data/lib/reek/configuration/default_directive.rb +18 -3
- data/lib/reek/configuration/directory_directives.rb +18 -11
- data/lib/reek/configuration/excluded_paths.rb +2 -1
- data/lib/reek/configuration/rake_task_converter.rb +29 -0
- data/lib/reek/configuration/schema.yml +210 -0
- data/lib/reek/configuration/schema_validator.rb +38 -0
- data/lib/reek/context/attribute_context.rb +4 -3
- data/lib/reek/context/class_context.rb +1 -0
- data/lib/reek/context/code_context.rb +49 -44
- data/lib/reek/context/ghost_context.rb +1 -2
- data/lib/reek/context/method_context.rb +26 -18
- data/lib/reek/context/module_context.rb +11 -11
- data/lib/reek/context/root_context.rb +1 -4
- data/lib/reek/context/send_context.rb +3 -2
- data/lib/reek/context/singleton_attribute_context.rb +1 -0
- data/lib/reek/context/singleton_method_context.rb +1 -0
- data/lib/reek/context/statement_counter.rb +1 -0
- data/lib/reek/context/visibility_tracker.rb +1 -0
- data/lib/reek/context_builder.rb +44 -44
- data/lib/reek/detector_repository.rb +12 -11
- data/lib/reek/documentation_link.rb +28 -0
- data/lib/reek/errors/bad_detector_configuration_key_in_comment_error.rb +15 -13
- data/lib/reek/errors/bad_detector_in_comment_error.rb +13 -11
- data/lib/reek/errors/base_error.rb +3 -0
- data/lib/reek/errors/config_file_error.rb +11 -0
- data/lib/reek/errors/encoding_error.rb +43 -0
- data/lib/reek/errors/garbage_detector_configuration_in_comment_error.rb +14 -12
- data/lib/reek/errors/incomprehensible_source_error.rb +23 -24
- data/lib/reek/errors/syntax_error.rb +41 -0
- data/lib/reek/examiner.rb +24 -22
- data/lib/reek/logging_error_handler.rb +8 -5
- data/lib/reek/rake/task.rb +8 -5
- data/lib/reek/report/base_report.rb +9 -12
- data/lib/reek/report/code_climate/code_climate_configuration.rb +2 -1
- data/lib/reek/report/code_climate/code_climate_configuration.yml +6 -6
- data/lib/reek/report/code_climate/code_climate_fingerprint.rb +1 -0
- data/lib/reek/report/code_climate/code_climate_formatter.rb +1 -0
- data/lib/reek/report/code_climate/code_climate_report.rb +1 -0
- data/lib/reek/report/code_climate.rb +1 -0
- data/lib/reek/report/documentation_link_warning_formatter.rb +17 -0
- data/lib/reek/report/heading_formatter.rb +54 -0
- data/lib/reek/report/html_report.rb +1 -0
- data/lib/reek/report/json_report.rb +2 -1
- data/lib/reek/report/location_formatter.rb +40 -0
- data/lib/reek/report/progress_formatter.rb +79 -0
- data/lib/reek/report/simple_warning_formatter.rb +34 -0
- data/lib/reek/report/text_report.rb +2 -2
- data/lib/reek/report/xml_report.rb +4 -3
- data/lib/reek/report/yaml_report.rb +2 -1
- data/lib/reek/report.rb +16 -10
- data/lib/reek/smell_configuration.rb +3 -2
- data/lib/reek/smell_detectors/attribute.rb +6 -11
- data/lib/reek/smell_detectors/base_detector.rb +31 -26
- data/lib/reek/smell_detectors/boolean_parameter.rb +4 -5
- data/lib/reek/smell_detectors/class_variable.rb +6 -14
- data/lib/reek/smell_detectors/control_parameter.rb +19 -33
- data/lib/reek/smell_detectors/data_clump.rb +16 -9
- data/lib/reek/smell_detectors/duplicate_method_call.rb +24 -17
- data/lib/reek/smell_detectors/feature_envy.rb +10 -7
- data/lib/reek/smell_detectors/instance_variable_assumption.rb +15 -23
- data/lib/reek/smell_detectors/irresponsible_module.rb +6 -12
- data/lib/reek/smell_detectors/long_parameter_list.rb +11 -7
- data/lib/reek/smell_detectors/long_yield_list.rb +11 -7
- data/lib/reek/smell_detectors/manual_dispatch.rb +5 -5
- data/lib/reek/smell_detectors/{prima_donna_method.rb → missing_safe_method.rb} +21 -20
- data/lib/reek/smell_detectors/module_initialize.rb +4 -5
- data/lib/reek/smell_detectors/nested_iterators.rb +17 -24
- data/lib/reek/smell_detectors/nil_check.rb +9 -15
- data/lib/reek/smell_detectors/repeated_conditional.rb +14 -11
- data/lib/reek/smell_detectors/subclassed_from_core_class.rb +8 -8
- data/lib/reek/smell_detectors/too_many_constants.rb +11 -9
- data/lib/reek/smell_detectors/too_many_instance_variables.rb +11 -6
- data/lib/reek/smell_detectors/too_many_methods.rb +12 -7
- data/lib/reek/smell_detectors/too_many_statements.rb +11 -6
- data/lib/reek/smell_detectors/uncommunicative_method_name.rb +11 -11
- data/lib/reek/smell_detectors/uncommunicative_module_name.rb +15 -18
- data/lib/reek/smell_detectors/uncommunicative_parameter_name.rb +18 -22
- data/lib/reek/smell_detectors/uncommunicative_variable_name.rb +27 -27
- data/lib/reek/smell_detectors/unused_parameters.rb +5 -6
- data/lib/reek/smell_detectors/unused_private_method.rb +14 -20
- data/lib/reek/smell_detectors/utility_function.rb +13 -16
- data/lib/reek/smell_detectors.rb +2 -1
- data/lib/reek/smell_warning.rb +16 -8
- data/lib/reek/source/source_code.rb +65 -46
- data/lib/reek/source/source_locator.rb +9 -8
- data/lib/reek/spec/should_reek.rb +3 -2
- data/lib/reek/spec/should_reek_of.rb +13 -26
- data/lib/reek/spec/should_reek_only_of.rb +5 -4
- data/lib/reek/spec/smell_matcher.rb +2 -1
- data/lib/reek/spec.rb +7 -6
- data/lib/reek/tree_dresser.rb +9 -8
- data/lib/reek/version.rb +2 -1
- data/lib/reek.rb +1 -0
- data/reek.gemspec +5 -6
- data/samples/checkstyle.xml +1 -1
- data/samples/configuration/accepts_rejects_and_excludes_for_detectors.reek.yml +29 -0
- data/samples/configuration/accepts_rejects_and_excludes_for_directory_directives.reek.yml +30 -0
- data/samples/configuration/full_configuration.reek +8 -4
- data/samples/configuration/full_mask.reek +5 -4
- data/samples/configuration/partial_mask.reek +3 -2
- data/samples/configuration/regular_configuration/.reek.yml +4 -0
- data/samples/paths.rb +5 -4
- data/samples/source_with_hidden_directories/.hidden/hidden.rb +1 -0
- data/samples/source_with_hidden_directories/not_hidden.rb +1 -0
- data/spec/factories/factories.rb +2 -13
- data/spec/reek/ast/node_spec.rb +103 -10
- data/spec/reek/ast/reference_collector_spec.rb +1 -1
- data/spec/reek/ast/sexp_extensions_spec.rb +15 -34
- data/spec/reek/cli/application_spec.rb +52 -42
- data/spec/reek/cli/command/todo_list_command_spec.rb +6 -4
- data/spec/reek/cli/silencer_spec.rb +28 -0
- data/spec/reek/code_comment_spec.rb +31 -38
- data/spec/reek/configuration/app_configuration_spec.rb +46 -33
- data/spec/reek/configuration/configuration_file_finder_spec.rb +133 -51
- data/spec/reek/configuration/default_directive_spec.rb +1 -1
- data/spec/reek/configuration/directory_directives_spec.rb +6 -7
- data/spec/reek/configuration/excluded_paths_spec.rb +6 -6
- data/spec/reek/configuration/rake_task_converter_spec.rb +33 -0
- data/spec/reek/configuration/schema_validator_spec.rb +165 -0
- data/spec/reek/context/code_context_spec.rb +70 -106
- data/spec/reek/context/ghost_context_spec.rb +9 -9
- data/spec/reek/context/method_context_spec.rb +2 -2
- data/spec/reek/context/module_context_spec.rb +3 -3
- data/spec/reek/context/root_context_spec.rb +1 -1
- data/spec/reek/context/statement_counter_spec.rb +1 -0
- data/spec/reek/context_builder_spec.rb +20 -0
- data/spec/reek/documentation_link_spec.rb +20 -0
- data/spec/reek/errors/base_error_spec.rb +13 -0
- data/spec/reek/examiner_spec.rb +137 -29
- data/spec/reek/rake/task_spec.rb +25 -2
- data/spec/reek/report/code_climate/code_climate_fingerprint_spec.rb +82 -78
- data/spec/reek/report/code_climate/code_climate_formatter_spec.rb +6 -6
- data/spec/reek/report/code_climate/code_climate_report_spec.rb +22 -22
- data/spec/reek/report/json_report_spec.rb +13 -46
- data/spec/reek/report/{formatter/location_formatter_spec.rb → location_formatter_spec.rb} +5 -5
- data/spec/reek/report/{formatter/progress_formatter_spec.rb → progress_formatter_spec.rb} +4 -4
- data/spec/reek/report/text_report_spec.rb +4 -4
- data/spec/reek/report/xml_report_spec.rb +3 -3
- data/spec/reek/report/yaml_report_spec.rb +17 -46
- data/spec/reek/report_spec.rb +3 -3
- data/spec/reek/smell_detectors/base_detector_spec.rb +4 -5
- data/spec/reek/smell_detectors/boolean_parameter_spec.rb +2 -2
- data/spec/reek/smell_detectors/class_variable_spec.rb +26 -32
- data/spec/reek/smell_detectors/control_parameter_spec.rb +34 -4
- data/spec/reek/smell_detectors/duplicate_method_call_spec.rb +3 -3
- data/spec/reek/smell_detectors/feature_envy_spec.rb +47 -2
- data/spec/reek/smell_detectors/irresponsible_module_spec.rb +59 -21
- data/spec/reek/smell_detectors/{prima_donna_method_spec.rb → missing_safe_method_spec.rb} +10 -10
- data/spec/reek/smell_detectors/module_initialize_spec.rb +14 -0
- data/spec/reek/smell_detectors/nested_iterators_spec.rb +1 -1
- data/spec/reek/smell_detectors/too_many_constants_spec.rb +3 -3
- data/spec/reek/smell_detectors/too_many_instance_variables_spec.rb +1 -1
- data/spec/reek/smell_detectors/uncommunicative_method_name_spec.rb +6 -6
- data/spec/reek/smell_detectors/uncommunicative_module_name_spec.rb +6 -4
- data/spec/reek/smell_detectors/uncommunicative_parameter_name_spec.rb +36 -15
- data/spec/reek/smell_detectors/uncommunicative_variable_name_spec.rb +9 -9
- data/spec/reek/smell_detectors/unused_parameters_spec.rb +3 -3
- data/spec/reek/smell_detectors/unused_private_method_spec.rb +21 -10
- data/spec/reek/smell_detectors/utility_function_spec.rb +57 -5
- data/spec/reek/smell_warning_spec.rb +12 -8
- data/spec/reek/source/source_code_spec.rb +27 -38
- data/spec/reek/source/source_locator_spec.rb +42 -12
- data/spec/reek/spec/should_reek_of_spec.rb +25 -30
- data/spec/reek/spec/should_reek_only_of_spec.rb +2 -2
- data/spec/reek/spec/should_reek_spec.rb +8 -8
- data/spec/reek/spec/smell_matcher_spec.rb +23 -23
- data/spec/reek/tree_dresser_spec.rb +12 -17
- data/spec/spec_helper.rb +7 -17
- data/tasks/configuration.rake +8 -5
- metadata +77 -40
- data/defaults.reek +0 -128
- data/features/configuration_files/warn_about_multiple_configuration_files.feature +0 -44
- data/lib/reek/errors/parse_error.rb +0 -19
- data/lib/reek/report/formatter/heading_formatter.rb +0 -51
- data/lib/reek/report/formatter/location_formatter.rb +0 -41
- data/lib/reek/report/formatter/progress_formatter.rb +0 -80
- data/lib/reek/report/formatter/simple_warning_formatter.rb +0 -35
- data/lib/reek/report/formatter/wiki_link_warning_formatter.rb +0 -35
- data/lib/reek/report/formatter.rb +0 -32
- data/samples/configuration/non_public_modifiers_mask.reek +0 -3
- data/samples/smelly_with_inline_mask.rb +0 -8
- data/samples/smelly_with_modifiers.rb +0 -12
- data/samples/source_with_hidden_directories/.hidden/uncommunicative_method_name.rb +0 -5
- data/samples/source_with_non_ruby_files/uncommunicative_parameter_name.rb +0 -6
- /data/{samples/configuration/more_than_one_configuration_file/regular.reek → .reek.yml} +0 -0
- /data/samples/{clean.rb → clean_source/clean.rb} +0 -0
- /data/samples/{exceptions.reek → configuration/home/home.reek.yml} +0 -0
- /data/samples/configuration/{more_than_one_configuration_file/todo.reek → regular_configuration/empty_sub_directory/.gitignore} +0 -0
- /data/samples/{configuration/single_configuration_file/.reek → no_config_file/.keep} +0 -0
- /data/samples/{inline.rb → smelly_source/inline.rb} +0 -0
- /data/samples/{optparse.rb → smelly_source/optparse.rb} +0 -0
- /data/samples/{redcloth.rb → smelly_source/redcloth.rb} +0 -0
- /data/samples/{smelly.rb → smelly_source/smelly.rb} +0 -0
- /data/samples/{source_with_hidden_directories/uncommunicative_parameter_name.rb → source_with_non_ruby_files/ruby.rb} +0 -0
data/README.md
CHANGED
|
@@ -7,7 +7,7 @@
|
|
|
7
7
|
- [Overview](#overview)
|
|
8
8
|
- [Quickstart](#quickstart)
|
|
9
9
|
- [Example](#example)
|
|
10
|
-
- [Supported
|
|
10
|
+
- [Supported Ruby versions](#supported-ruby-versions)
|
|
11
11
|
- [Fixing Smell Warnings](#fixing-smell-warnings)
|
|
12
12
|
- [Sources](#sources)
|
|
13
13
|
- [Code smells](#code-smells)
|
|
@@ -39,13 +39,18 @@
|
|
|
39
39
|
* [](https://badge.fury.io/rb/reek)
|
|
40
40
|
* 
|
|
41
41
|
* 
|
|
42
|
-
* [](https://gemnasium.com/github.com/troessner/reek)
|
|
43
42
|
* [](https://inch-ci.org/github/troessner/reek)
|
|
44
43
|
* [](https://codeclimate.com/github/troessner/reek)
|
|
45
44
|
* [](https://codebeat.co/projects/github-com-troessner-reek)
|
|
46
45
|
* 
|
|
47
46
|
* 
|
|
48
47
|
|
|
48
|
+
## Reek 5 is out!
|
|
49
|
+
|
|
50
|
+
Reek 5 is out and with it a bunch of breaking changes. If you're a new user you can just
|
|
51
|
+
continue with the quickstart below. If you're a Reek 4 user and would like to upgrade to 5, don't
|
|
52
|
+
worry, this shouldn't take you more than 10 minutes. Check out our [Upgrade Guide](docs/Reek-4-to-Reek-5-migration.md).
|
|
53
|
+
|
|
49
54
|
## Quickstart
|
|
50
55
|
|
|
51
56
|
Reek is a tool that examines Ruby classes, modules and methods and reports any
|
|
@@ -53,7 +58,7 @@ Reek is a tool that examines Ruby classes, modules and methods and reports any
|
|
|
53
58
|
|
|
54
59
|
For an excellent introduction to
|
|
55
60
|
[Code Smells](docs/Code-Smells.md) and Reek check out [this blog post](https://blog.codeship.com/how-to-find-ruby-code-smells-with-reek/)
|
|
56
|
-
or [that one](https://troessner.svbtle.com/the-latest-and-greatest-additions-to-reek). There is also [this talk](https://www.youtube.com/watch?v=
|
|
61
|
+
or [that one](https://troessner.svbtle.com/the-latest-and-greatest-additions-to-reek). There is also [this talk](https://www.youtube.com/watch?v=pazYe7WRWRU) from [RubyConfBY](http://rubyconference.by/) (there is also a [slide deck](http://talks.chastell.net/rubyconf-by-lt-2016/) if you prefer that).
|
|
57
62
|
|
|
58
63
|
Install it via rubygems:
|
|
59
64
|
|
|
@@ -84,24 +89,24 @@ end
|
|
|
84
89
|
Reek will report the following code smells in this file:
|
|
85
90
|
|
|
86
91
|
```
|
|
87
|
-
$ reek demo.rb
|
|
92
|
+
$ reek --no-documentation demo.rb
|
|
88
93
|
Inspecting 1 file(s):
|
|
89
94
|
S
|
|
90
95
|
|
|
91
96
|
demo.rb -- 2 warnings:
|
|
92
|
-
[4]:UncommunicativeMethodName: Smelly#x has the name 'x'
|
|
93
|
-
[5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
|
|
97
|
+
[4]:UncommunicativeMethodName: Smelly#x has the name 'x'
|
|
98
|
+
[5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
|
|
94
99
|
```
|
|
95
100
|
|
|
96
|
-
## Supported
|
|
101
|
+
## Supported Ruby versions
|
|
97
102
|
|
|
98
|
-
Reek is officially
|
|
103
|
+
Reek is officially supported for the following CRuby versions:
|
|
99
104
|
|
|
100
|
-
- 2.1
|
|
101
|
-
- 2.2
|
|
102
105
|
- 2.3
|
|
106
|
+
- 2.4
|
|
107
|
+
- 2.5
|
|
103
108
|
|
|
104
|
-
Other
|
|
109
|
+
Other Ruby implementations (like Rubinius or JRuby) are not officially supported but should work as well.
|
|
105
110
|
|
|
106
111
|
## Fixing Smell Warnings
|
|
107
112
|
|
|
@@ -252,12 +257,13 @@ For a summary of those CLI options see [Command-Line Options](docs/Command-Line-
|
|
|
252
257
|
#### Configuration loading
|
|
253
258
|
|
|
254
259
|
Configuring Reek via a configuration file is by far the most powerful way.
|
|
260
|
+
Reek expects this filename to be `.reek.yml` but you can override this via the CLI `-c` switch (see below).
|
|
255
261
|
|
|
256
|
-
There are three ways of passing Reek
|
|
262
|
+
There are three ways of passing Reek the configuration file:
|
|
257
263
|
|
|
258
264
|
1. Using the CLI `-c` switch (see [_Command-line interface_](#command-line-interface) above)
|
|
259
|
-
2. Having
|
|
260
|
-
3. Having
|
|
265
|
+
2. Having the configuration file either in your current working directory or in a parent directory (more on that later)
|
|
266
|
+
3. Having the configuration file in your home directory
|
|
261
267
|
|
|
262
268
|
The order in which Reek tries to find such a configuration
|
|
263
269
|
file is exactly the above: first it checks if we have given
|
|
@@ -275,43 +281,46 @@ of how many `*.reek` files you might have on your filesystem.
|
|
|
275
281
|
|
|
276
282
|
We put a lot of effort into making Reek's configuration as self explanatory as possible so the
|
|
277
283
|
best way to understand it is by looking at a simple
|
|
278
|
-
example (e.g.
|
|
284
|
+
example (e.g. `.reek.yml` in your project directory):
|
|
279
285
|
|
|
280
286
|
```yaml
|
|
281
287
|
---
|
|
282
288
|
|
|
283
289
|
### Generic smell configuration
|
|
284
290
|
|
|
285
|
-
|
|
286
|
-
|
|
287
|
-
|
|
288
|
-
|
|
289
|
-
|
|
290
|
-
#
|
|
291
|
-
# because you
|
|
292
|
-
|
|
293
|
-
|
|
294
|
-
|
|
295
|
-
|
|
296
|
-
|
|
297
|
-
|
|
298
|
-
#
|
|
299
|
-
#
|
|
300
|
-
|
|
301
|
-
|
|
302
|
-
|
|
291
|
+
detectors:
|
|
292
|
+
# You can disable smells completely
|
|
293
|
+
IrresponsibleModule:
|
|
294
|
+
enabled: false
|
|
295
|
+
|
|
296
|
+
# You can use filters to silence Reek warnings.
|
|
297
|
+
# Either because you simply disagree with Reek (we are not the police) or
|
|
298
|
+
# because you want to fix this at a later point in time.
|
|
299
|
+
NestedIterators:
|
|
300
|
+
exclude:
|
|
301
|
+
- "MyWorker#self.class_method" # should be refactored
|
|
302
|
+
- "AnotherWorker#instance_method" # should be refactored as well
|
|
303
|
+
|
|
304
|
+
# A lot of smells allow fine tuning their configuration. You can look up all available options
|
|
305
|
+
# in the corresponding smell documentation in /docs. In most cases you probably can just go
|
|
306
|
+
# with the defaults as documented in defaults.reek.yml.
|
|
307
|
+
DataClump:
|
|
308
|
+
max_copies: 3
|
|
309
|
+
min_clump_size: 3
|
|
303
310
|
|
|
304
311
|
### Directory specific configuration
|
|
305
312
|
|
|
306
313
|
# You can configure smells on a per-directory base.
|
|
307
314
|
# E.g. the classic Rails case: controllers smell of NestedIterators (see /docs/Nested-Iterators.md) and
|
|
308
315
|
# helpers smell of UtilityFunction (see docs/Utility-Function.md)
|
|
309
|
-
|
|
310
|
-
|
|
311
|
-
|
|
312
|
-
|
|
313
|
-
|
|
314
|
-
|
|
316
|
+
# Note that we only allow configuration on a directory level, not a file level, so all paths have to point to directories.
|
|
317
|
+
directories:
|
|
318
|
+
"web_app/app/controllers":
|
|
319
|
+
NestedIterators:
|
|
320
|
+
enabled: false
|
|
321
|
+
"web_app/app/helpers":
|
|
322
|
+
UtilityFunction:
|
|
323
|
+
enabled: false
|
|
315
324
|
|
|
316
325
|
### Excluding directories
|
|
317
326
|
|
|
@@ -321,6 +330,14 @@ exclude_paths:
|
|
|
321
330
|
- lib/rake/legacy_tasks
|
|
322
331
|
```
|
|
323
332
|
|
|
333
|
+
As you see above, Reek's configuration consists of 3 different sections denoted by 3 different keys:
|
|
334
|
+
|
|
335
|
+
* detectors
|
|
336
|
+
* directories
|
|
337
|
+
* exclude_paths
|
|
338
|
+
|
|
339
|
+
Whatever you add to your configuration should be scoped under one of those keys.
|
|
340
|
+
|
|
324
341
|
If you have a directory directive for which a default directive exists, the more specific
|
|
325
342
|
one (which is the directory directive) will take precedence.
|
|
326
343
|
|
|
@@ -328,15 +345,12 @@ This configuration for instance:
|
|
|
328
345
|
|
|
329
346
|
```yaml
|
|
330
347
|
---
|
|
331
|
-
|
|
332
|
-
|
|
333
|
-
|
|
334
|
-
|
|
335
|
-
max_statements: 5
|
|
336
|
-
|
|
337
|
-
"app/controllers":
|
|
348
|
+
detectors:
|
|
349
|
+
IrresponsibleModule:
|
|
350
|
+
enabled: false
|
|
351
|
+
|
|
338
352
|
TooManyStatements:
|
|
339
|
-
max_statements:
|
|
353
|
+
max_statements: 5
|
|
340
354
|
```
|
|
341
355
|
|
|
342
356
|
translates to:
|
|
@@ -345,16 +359,53 @@ translates to:
|
|
|
345
359
|
* TooManyStatements#max_statements is 10 in "app/controllers"
|
|
346
360
|
* TooManyStatements#max_statements is 5 everywhere else
|
|
347
361
|
|
|
348
|
-
|
|
349
|
-
|
|
350
|
-
types offer a configuration that goes beyond that of the basic smell options, for instance
|
|
362
|
+
Every smell detector supports our [Basic Smell Options](docs/Basic-Smell-Options.md). As you can see above,
|
|
363
|
+
certain smell types offer a configuration that goes beyond that of the basic smell options, for instance
|
|
351
364
|
[Data Clump](docs/Data-Clump.md).
|
|
352
365
|
All options that go beyond the [Basic Smell Options](docs/Basic-Smell-Options.md)
|
|
353
366
|
are documented in the corresponding smell type /docs page (if you want to get a quick overview over all possible
|
|
354
|
-
configurations you can also check out [the `
|
|
367
|
+
configurations you can also check out [the `defaults.reek.yml` file in this repository](docs/defaults.reek.yml).
|
|
355
368
|
|
|
356
369
|
Note that you do not need a configuration file at all.
|
|
357
|
-
If you're fine with all the [defaults](defaults.reek) we set you can skip this completely.
|
|
370
|
+
If you're fine with all the [defaults.reek.yml](docs/defaults.reek.yml) we set you can skip this completely.
|
|
371
|
+
|
|
372
|
+
Don't worry about introducing a mistake in your configuration file that might go unnoticed - Reek uses a
|
|
373
|
+
schema to validate your configuration against on start up and will faily loudly in case you
|
|
374
|
+
misspelled an option or used the wrong data type for a value like this:
|
|
375
|
+
|
|
376
|
+
```
|
|
377
|
+
Error: We found some problems with your configuration file: [/detectors/DetectorWithTypo] key 'DetectorWithTypo:' is undefined.
|
|
378
|
+
```
|
|
379
|
+
|
|
380
|
+
Reek takes one configuration file and one configuration file only with `.reek.yml` being the default name.
|
|
381
|
+
|
|
382
|
+
In case you have to have one or more configuration files in the directory (e.g. you're
|
|
383
|
+
toying around with different, mutually exclusive settings) you need to tell Reek
|
|
384
|
+
explicitly which file to use via `reek -c config.reek`.
|
|
385
|
+
|
|
386
|
+
### Source code comments
|
|
387
|
+
|
|
388
|
+
In case you need to suppress a smell warning and you can't or don't want to
|
|
389
|
+
use configuration files for whatever reasons you can also use special
|
|
390
|
+
source code comments like this:
|
|
391
|
+
|
|
392
|
+
```Ruby
|
|
393
|
+
# This method smells of :reek:NestedIterators
|
|
394
|
+
def smelly_method foo
|
|
395
|
+
foo.each {|bar| bar.each {|baz| baz.qux}}
|
|
396
|
+
end
|
|
397
|
+
```
|
|
398
|
+
|
|
399
|
+
You can even pass in smell specific configuration settings:
|
|
400
|
+
|
|
401
|
+
```Ruby
|
|
402
|
+
# :reek:NestedIterators { max_allowed_nesting: 2 }
|
|
403
|
+
def smelly_method foo
|
|
404
|
+
foo.each {|bar| bar.each {|baz| baz.qux}}
|
|
405
|
+
end
|
|
406
|
+
```
|
|
407
|
+
|
|
408
|
+
This is an incredibly powerful feature and further explained under [Smell Suppresion](docs/Smell-Suppression.md).
|
|
358
409
|
|
|
359
410
|
### Generating a 'todo' list
|
|
360
411
|
|
|
@@ -402,42 +453,6 @@ reek -c other_configuration.reek --todo lib/
|
|
|
402
453
|
`other_configuration.reek` will simply be ignored (as outlined before, Reek
|
|
403
454
|
is supposed to have one configuration file and one file only).
|
|
404
455
|
|
|
405
|
-
### Beware of multiple configuration files
|
|
406
|
-
|
|
407
|
-
Reek takes one configuration file and one configuration file only.
|
|
408
|
-
|
|
409
|
-
If you have more than one configuration file in the same directory Reek
|
|
410
|
-
will not know what configuration file to use. If this happens Reek will
|
|
411
|
-
print a warning on STDERR and exit with the failure exit status 1.
|
|
412
|
-
|
|
413
|
-
In case you have to have one or more configuration files in the directory (e.g. you're
|
|
414
|
-
toying around with different, mutually exclusive settings) you need to tell Reek
|
|
415
|
-
explicitly which file to use via `reek -c config.reek`.
|
|
416
|
-
|
|
417
|
-
### Source code comments
|
|
418
|
-
|
|
419
|
-
In case you need to suppress a smell warning and you can't or don't want to
|
|
420
|
-
use configuration files for whatever reasons you can also use special
|
|
421
|
-
source code comments like this:
|
|
422
|
-
|
|
423
|
-
```Ruby
|
|
424
|
-
# This method smells of :reek:NestedIterators
|
|
425
|
-
def smelly_method foo
|
|
426
|
-
foo.each {|bar| bar.each {|baz| baz.qux}}
|
|
427
|
-
end
|
|
428
|
-
```
|
|
429
|
-
|
|
430
|
-
You can even pass in smell specific configuration settings:
|
|
431
|
-
|
|
432
|
-
```Ruby
|
|
433
|
-
# :reek:NestedIterators { max_allowed_nesting: 2 }
|
|
434
|
-
def smelly_method foo
|
|
435
|
-
foo.each {|bar| bar.each {|baz| baz.qux}}
|
|
436
|
-
end
|
|
437
|
-
```
|
|
438
|
-
|
|
439
|
-
This is an incredible powerful feature and further explained under [Smell Suppresion](docs/Smell-Suppression.md).
|
|
440
|
-
|
|
441
456
|
## Usage
|
|
442
457
|
|
|
443
458
|
Besides the obvious
|
|
@@ -475,7 +490,7 @@ Or just run the whole test suite:
|
|
|
475
490
|
bundle exec rake
|
|
476
491
|
```
|
|
477
492
|
|
|
478
|
-
This will run the RSpec
|
|
493
|
+
This will run the tests (RSpec and Cucumber), RuboCop and Reek itself.
|
|
479
494
|
|
|
480
495
|
You can also run:
|
|
481
496
|
|
|
@@ -484,7 +499,7 @@ bundle exec rake ci
|
|
|
484
499
|
```
|
|
485
500
|
|
|
486
501
|
This will run everything the default task runs and also
|
|
487
|
-
|
|
502
|
+
[Ataru](https://github.com/CodePadawans/ataru). This is the task that we run on
|
|
488
503
|
Travis as well and that determines if your pull request is green or red.
|
|
489
504
|
|
|
490
505
|
Another useful Rake task is the `console` task. This will throw you right into an environment where you can play around with Reeks modules and classes:
|
|
@@ -527,6 +542,20 @@ If you don't feel like getting your hands dirty with code there are still other
|
|
|
527
542
|
* Open up an [issue](https://github.com/troessner/reek/issues) and report bugs
|
|
528
543
|
* Suggest other improvements like additional smells for instance
|
|
529
544
|
|
|
545
|
+
### Running Code Climate locally
|
|
546
|
+
|
|
547
|
+
If you run into Code Climate issues (e.g., go over code duplication
|
|
548
|
+
threshold) you might want to be able to run Code Climate against
|
|
549
|
+
the Reek codebase locally. To do this, you need to do the following:
|
|
550
|
+
|
|
551
|
+
* [install Docker CE](https://docs.docker.com/engine/installation/)
|
|
552
|
+
* [install Code Climate CLI](https://github.com/codeclimate/codeclimate#installation)
|
|
553
|
+
* `gem install codeclimate`
|
|
554
|
+
* `codeclimate engines:install`
|
|
555
|
+
|
|
556
|
+
Now you can run various Code Climate engines,
|
|
557
|
+
e.g., `codeclimate analyze -e duplication`
|
|
558
|
+
|
|
530
559
|
## Output formats
|
|
531
560
|
|
|
532
561
|
Reek supports 5 output formats:
|
|
@@ -543,23 +572,24 @@ Making Reek "Rails"-friendly is fairly simple since we support directory specifi
|
|
|
543
572
|
Just add this to your configuration file:
|
|
544
573
|
|
|
545
574
|
```Yaml
|
|
546
|
-
|
|
547
|
-
|
|
548
|
-
|
|
549
|
-
|
|
550
|
-
|
|
551
|
-
|
|
552
|
-
|
|
553
|
-
|
|
554
|
-
|
|
555
|
-
|
|
556
|
-
|
|
557
|
-
|
|
558
|
-
|
|
559
|
-
|
|
560
|
-
|
|
561
|
-
|
|
562
|
-
|
|
575
|
+
directories:
|
|
576
|
+
"app/controllers":
|
|
577
|
+
IrresponsibleModule:
|
|
578
|
+
enabled: false
|
|
579
|
+
NestedIterators:
|
|
580
|
+
max_allowed_nesting: 2
|
|
581
|
+
UnusedPrivateMethod:
|
|
582
|
+
enabled: false
|
|
583
|
+
InstanceVariableAssumption:
|
|
584
|
+
enabled: false
|
|
585
|
+
"app/helpers":
|
|
586
|
+
IrresponsibleModule:
|
|
587
|
+
enabled: false
|
|
588
|
+
UtilityFunction:
|
|
589
|
+
enabled: false
|
|
590
|
+
"app/mailers":
|
|
591
|
+
InstanceVariableAssumption:
|
|
592
|
+
enabled: false
|
|
563
593
|
```
|
|
564
594
|
|
|
565
595
|
Be careful though, Reek does not merge your configuration entries, so if you already have a directory directive for "app/controllers" or "app/helpers" you need to update those directives instead of copying the above YAML sample into your configuration file.
|
|
@@ -572,6 +602,7 @@ Be careful though, Reek does not merge your configuration entries, so if you alr
|
|
|
572
602
|
* [TextMate Bundle](https://github.com/peeyush1234/reek.tmbundle)
|
|
573
603
|
* [Atom plugin](https://atom.io/packages/linter-reek)
|
|
574
604
|
* [SublimeLinter plugin](https://packagecontrol.io/packages/SublimeLinter-contrib-reek)
|
|
605
|
+
* [VS Code plugin](https://github.com/rubyide/vscode-ruby)
|
|
575
606
|
* [Emacs plugin](https://github.com/hanmoi-choi/reek-emacs)
|
|
576
607
|
|
|
577
608
|
### Projects that use or support us
|
data/Rakefile
CHANGED
|
@@ -3,6 +3,19 @@ require 'rake/clean'
|
|
|
3
3
|
|
|
4
4
|
Dir['tasks/**/*.rake'].each { |t| load t }
|
|
5
5
|
|
|
6
|
-
task
|
|
7
|
-
|
|
8
|
-
|
|
6
|
+
task :ci do
|
|
7
|
+
[
|
|
8
|
+
'test:spec',
|
|
9
|
+
'configuration:update_default_configuration',
|
|
10
|
+
'test:features',
|
|
11
|
+
:rubocop,
|
|
12
|
+
'test:quality',
|
|
13
|
+
:ataru
|
|
14
|
+
].each do |name|
|
|
15
|
+
puts "\n=== Running #{name}...\n"
|
|
16
|
+
Rake::Task[name].invoke
|
|
17
|
+
puts "\n=== Running #{name} -> Done\n"
|
|
18
|
+
end
|
|
19
|
+
end
|
|
20
|
+
|
|
21
|
+
task default: :ci
|
data/bin/code_climate_reek
CHANGED
data/bin/reek
CHANGED
|
@@ -1,10 +1,9 @@
|
|
|
1
1
|
#!/usr/bin/env ruby
|
|
2
2
|
# frozen_string_literal: true
|
|
3
|
+
|
|
3
4
|
#
|
|
4
5
|
# Reek examines Ruby source code for smells.
|
|
5
|
-
# Visit https://
|
|
6
|
-
#
|
|
7
|
-
# Author: Kevin Rutherford
|
|
6
|
+
# Visit https://github.com/troessner/reek for docs etc.
|
|
8
7
|
#
|
|
9
8
|
|
|
10
9
|
require_relative '../lib/reek'
|
data/docs/API.md
CHANGED
|
@@ -89,7 +89,7 @@ XMLReport
|
|
|
89
89
|
|
|
90
90
|
## Configuration
|
|
91
91
|
|
|
92
|
-
Given you have the following configuration file called
|
|
92
|
+
Given you have the following configuration file called `.reek.yml` in your root directory:
|
|
93
93
|
|
|
94
94
|
```Yaml
|
|
95
95
|
---
|
|
@@ -106,7 +106,7 @@ You can now use either
|
|
|
106
106
|
Reek::Configuration::AppConfiguration.from_path Pathname.new('config.reek')
|
|
107
107
|
```
|
|
108
108
|
|
|
109
|
-
but you can also pass a hash with the contents of the
|
|
109
|
+
but you can also pass a hash with the contents of the `.reek.yml` YAML file
|
|
110
110
|
to `Reek::Configuration::AppConfiguration.from_hash`.
|
|
111
111
|
|
|
112
112
|
Given the example above you would load that as follows:
|
|
@@ -140,13 +140,6 @@ string -- 2 warnings:
|
|
|
140
140
|
Dirty#call_me has the parameter name 'b' (UncommunicativeParameterName)
|
|
141
141
|
```
|
|
142
142
|
|
|
143
|
-
Instead of the smell detector names you can also use the full detector class in
|
|
144
|
-
your configuration hash, for example:
|
|
145
|
-
|
|
146
|
-
```ruby
|
|
147
|
-
config_hash = { Reek::SmellDetectors::IrresponsibleModule => { 'enabled' => false } }
|
|
148
|
-
```
|
|
149
|
-
|
|
150
143
|
Of course, directory specific configuration and excluded paths are supported as
|
|
151
144
|
well:
|
|
152
145
|
|
data/docs/Basic-Smell-Options.md
CHANGED
|
@@ -7,14 +7,14 @@ Every smell detector in Reek offers at least the following configuration options
|
|
|
7
7
|
| Option | Value | Effect |
|
|
8
8
|
| ---------------|-------------|---------|
|
|
9
9
|
| `enabled` | Boolean | Determines whether the smell detector is active. Defaults to `true` |
|
|
10
|
-
| `exclude` | an array of strings
|
|
10
|
+
| `exclude` | an array of strings that will be converted into regular expressions | Ignores any context whose full description matches any element of this array. |
|
|
11
11
|
|
|
12
|
-
The file `defaults.reek` (shipped with the Reek gem) lists any default
|
|
12
|
+
The file `docs/defaults.reek.yml` (shipped with the Reek gem) lists any default
|
|
13
13
|
exclusions for each smell.
|
|
14
14
|
|
|
15
15
|
## Examples
|
|
16
16
|
|
|
17
|
-
|
|
17
|
+
**An easy one:**
|
|
18
18
|
|
|
19
19
|
To stop Reek reporting smells in any method called `write` you might create a configuration file containing this:
|
|
20
20
|
|
|
@@ -24,15 +24,9 @@ DuplicateMethodCall:
|
|
|
24
24
|
- write
|
|
25
25
|
```
|
|
26
26
|
|
|
27
|
-
|
|
27
|
+
Internally Reek will convert this to the Regexp /write/.
|
|
28
28
|
|
|
29
|
-
|
|
30
|
-
DuplicateMethodCall:
|
|
31
|
-
exclude:
|
|
32
|
-
- !ruby/regexp /write/
|
|
33
|
-
```
|
|
34
|
-
|
|
35
|
-
<u>A more sophisticated one:</u>
|
|
29
|
+
**A more sophisticated one:**
|
|
36
30
|
|
|
37
31
|
```yaml
|
|
38
32
|
FeatureEnvy:
|
|
@@ -43,3 +37,49 @@ FeatureEnvy:
|
|
|
43
37
|
```
|
|
44
38
|
|
|
45
39
|
This would not report FeatureEnvy for the instance method `MyModel#do_things`, the whole module `MyHelper` and the `respond` instance method of `ApplicationController`
|
|
40
|
+
|
|
41
|
+
## Advanced configuration
|
|
42
|
+
|
|
43
|
+
Sometimes just strings are not enough for configuration. E.g. consider this code sample:
|
|
44
|
+
|
|
45
|
+
```Ruby
|
|
46
|
+
class Klass
|
|
47
|
+
def foo1; end
|
|
48
|
+
def foo1bar; end
|
|
49
|
+
end
|
|
50
|
+
```
|
|
51
|
+
Both "Klass#foo1" and "Klass#foo1bar" will smell of UncommunicativeMethodName. Now let's assume
|
|
52
|
+
you are ok with "Klass#foo1" but not "Klass#foo1bar".
|
|
53
|
+
Just having this configuration
|
|
54
|
+
|
|
55
|
+
```yaml
|
|
56
|
+
UncommunicativeMethodName:
|
|
57
|
+
exclude:
|
|
58
|
+
- "Klass#foo1"
|
|
59
|
+
```
|
|
60
|
+
|
|
61
|
+
wouldn't work because now "Klass#foo1bar" wouldn't smell as well.
|
|
62
|
+
|
|
63
|
+
For this reason Reek has a special syntax that allows you to use regexes by using a forward slash at the beginning and the end of the string.
|
|
64
|
+
Everything within the forward slashes will be loaded as a regex.
|
|
65
|
+
|
|
66
|
+
A possible configuration that hat excludes "Klass#foo1" from this scan but not "Klass#foo1bar" could look like this:
|
|
67
|
+
|
|
68
|
+
```yaml
|
|
69
|
+
UncommunicativeMethodName:
|
|
70
|
+
exclude:
|
|
71
|
+
- "/Klass#foo1$/"
|
|
72
|
+
```
|
|
73
|
+
|
|
74
|
+
## Reek 4
|
|
75
|
+
|
|
76
|
+
In Reek 4 you could also pass regexes to `exclude`, meaning this was perfectly valid as well:
|
|
77
|
+
|
|
78
|
+
```yaml
|
|
79
|
+
DuplicateMethodCall:
|
|
80
|
+
exclude:
|
|
81
|
+
- !ruby/regexp /write/
|
|
82
|
+
```
|
|
83
|
+
|
|
84
|
+
Support for this has been scrapped with Reek 5 to make the Reek configuration more yaml standard compliant.
|
|
85
|
+
You can still pass in regexes, you just have to wrap them into a string. Please see "Advanced configuration" above.
|
data/docs/Code-Smells.md
CHANGED
|
@@ -23,7 +23,7 @@ Reek currently includes checks for the following smells:
|
|
|
23
23
|
* [Utility Function](Utility-Function.md)
|
|
24
24
|
* [Module Initialize](Module-Initialize.md)
|
|
25
25
|
* [Nested Iterators](Nested-Iterators.md)
|
|
26
|
-
* [
|
|
26
|
+
* [Missing Safe Method](Missing-Safe-Method.md), formerly known as Prima Donna Method
|
|
27
27
|
* [Simulated Polymorphism](Simulated-Polymorphism.md), including
|
|
28
28
|
* [Manual Dispatch](Manual-Dispatch.md)
|
|
29
29
|
* [Nil Check](Nil-Check.md)
|
|
@@ -12,6 +12,16 @@ reek -h
|
|
|
12
12
|
|
|
13
13
|
for details.
|
|
14
14
|
|
|
15
|
+
## Telling Reek to use a specific configuration file
|
|
16
|
+
|
|
17
|
+
In case your configuration file is not in the standard location (that would be your project directory or
|
|
18
|
+
whatever directory you're running Reek from) you can specify a configuration file with the `-c` option
|
|
19
|
+
like this:
|
|
20
|
+
|
|
21
|
+
```Bash
|
|
22
|
+
reek -c /somewhere/on/your/filesystem/reek_config.yml lib/
|
|
23
|
+
```
|
|
24
|
+
|
|
15
25
|
## Telling Reek Which Code to Check
|
|
16
26
|
|
|
17
27
|
Probably the most standard use case would be to check all Ruby files in the lib directory:
|
|
@@ -91,10 +101,10 @@ mess.rb -- 2 warnings:
|
|
|
91
101
|
[2]:x has the name 'x' (UncommunicativeMethodName)
|
|
92
102
|
```
|
|
93
103
|
|
|
94
|
-
### Enable the
|
|
104
|
+
### Enable the verbose mode
|
|
95
105
|
|
|
96
|
-
_reek_ has a
|
|
97
|
-
This mode can be enabled via the "-U" or "--
|
|
106
|
+
_reek_ has a verbose mode which you might find helpful as a beginner. "verbose" just means that behind each warning a helpful link will be displayed which leads directly to the corresponding _reek_ documentation page.
|
|
107
|
+
This mode can be enabled via the "-U" or "--documentation" flag.
|
|
98
108
|
|
|
99
109
|
So for instance, if your test file would smell of _ClassVariable_, this is what the _reek_ output would look like:
|
|
100
110
|
|
|
@@ -103,7 +113,7 @@ reek -U test.rb
|
|
|
103
113
|
```
|
|
104
114
|
```
|
|
105
115
|
test.rb -- 1 warning:
|
|
106
|
-
[2]:Dummy declares the class variable @@class_variable (ClassVariable) [https://github.com/troessner/reek/
|
|
116
|
+
[2]:Dummy declares the class variable @@class_variable (ClassVariable) [https://github.com/troessner/reek/blob/master/docs/Class-Variable.md]
|
|
107
117
|
```
|
|
108
118
|
|
|
109
119
|
Note the link at the end.
|
|
@@ -42,7 +42,55 @@ The approach you take will depend on balancing other factors in your code.
|
|
|
42
42
|
|
|
43
43
|
## Current support in Reek
|
|
44
44
|
|
|
45
|
-
Reek's Duplicate Method Call detector checks for repeated identical method calls within
|
|
45
|
+
Reek's Duplicate Method Call detector checks for repeated identical method calls within
|
|
46
|
+
any one method definition. This is intended to complement the checks performed by tools
|
|
47
|
+
such as [Flay](http://ruby.sadi.st/Flay.html) and [Simian](http://www.redhillconsulting.com.au/products/simian/).
|
|
48
|
+
|
|
49
|
+
## Edge cases
|
|
50
|
+
|
|
51
|
+
Be aware that there are some edge cases like this code:
|
|
52
|
+
|
|
53
|
+
```Ruby
|
|
54
|
+
class Foo
|
|
55
|
+
def bar(switch)
|
|
56
|
+
case switch
|
|
57
|
+
when :a
|
|
58
|
+
->(arg) { arg.call_me(:maybe); do_something }
|
|
59
|
+
when :b
|
|
60
|
+
->(arg) { arg.call_me(:maybe); do_something_else }
|
|
61
|
+
when :c
|
|
62
|
+
->(arg) { arg.call_me(:maybe); do_something_different }
|
|
63
|
+
end
|
|
64
|
+
end
|
|
65
|
+
end
|
|
66
|
+
```
|
|
67
|
+
|
|
68
|
+
Reek cannot reliably detect that each call's receiver is a different arg and will report:
|
|
69
|
+
|
|
70
|
+
```
|
|
71
|
+
[5, 7, 9]:DuplicateMethodCall: Foo#bar calls 'arg.call_me(:maybe)' 3 times
|
|
72
|
+
```
|
|
73
|
+
|
|
74
|
+
If you're running into this problem you can disable this smell detector for this method either via
|
|
75
|
+
configuration:
|
|
76
|
+
|
|
77
|
+
```Yaml
|
|
78
|
+
---
|
|
79
|
+
DuplicateMethodCall:
|
|
80
|
+
exclude:
|
|
81
|
+
- 'Foo#bar'
|
|
82
|
+
```
|
|
83
|
+
|
|
84
|
+
or via source code comment:
|
|
85
|
+
|
|
86
|
+
```Ruby
|
|
87
|
+
class Foo
|
|
88
|
+
# :reek:DuplicateMethodCall
|
|
89
|
+
def bar(switch)
|
|
90
|
+
# ....
|
|
91
|
+
end
|
|
92
|
+
end
|
|
93
|
+
```
|
|
46
94
|
|
|
47
95
|
## Configuration
|
|
48
96
|
|