reek 4.6.0 → 4.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5c827e3718e3a4f1524fdaf0d6c28df6e86b671b
-  data.tar.gz: 9755661abe970fb1499ee2b9de2f6d701b8c8ee2
+  metadata.gz: a703ee92e2eee612e747e83dd8f7262cc889a347
+  data.tar.gz: 2cd0f17e74826fabc001c770a96f7cc24545ced3
 SHA512:
-  metadata.gz: 77122032bb96bbd32994195c9745acc214ecfbfff7963348aff01239402deefb74032883eed3762df8eda34c6054447a5ca076dfe707a9a1460a5c14bc85ddf7
-  data.tar.gz: e86a819d479502f6f091c6d6f8b7d1b6c1aae20779131a3e6e62445eb048db3f1f0e1226b59a0b11ca82e9f3c4471578ce4c71c19d0a1fdff96b51f8f5e7d752
+  metadata.gz: 3bc0fe4ede8578d81c431bda322171cc240daaa3502da110fe98ecd6cd927fd7d336b83a813df6dff2acfd7d685fc70248e490f51cce4ede9ade528b80ff0e34
+  data.tar.gz: 8387daed0291caee16f71bd78c9dd3477d1cad1220e7998618039d937b5c017f5ca5fc95182268e7793d4ea975ac88a50a4d8fbd1b494fd02ad32a4c8f908095

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 4.6.1 (2017-04-05)
+
+* (IanWhitney) Properly handle absolute paths.
+
 ## 4.6.0 (2017-04-04)
 
 * (IanWhitney) Implement `--force-exclusion` flag

data/lib/reek/configuration/app_configuration.rb

@@ -62,7 +62,7 @@ module Reek
       end
 
       def path_excluded?(path)
-        excluded_paths.include?(path)
+        excluded_paths.map(&:expand_path).include?(path.expand_path)
       end
 
       def load_values(configuration_hash)

data/lib/reek/version.rb

@@ -7,6 +7,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '4.6.0'.freeze
+    STRING = '4.6.1'.freeze
   end
 end

data/spec/reek/source/source_locator_spec.rb

@@ -37,6 +37,36 @@ RSpec.describe Reek::Source::SourceLocator do
 
       let(:options) { instance_double('Reek::CLI::Options', force_exclusion?: false) }
 
+      context 'when the path is absolute' do
+        let(:path) do
+          SAMPLES_PATH.join('source_with_exclude_paths',
+                            'ignore_me',
+                            'uncommunicative_method_name.rb').expand_path
+        end
+
+        context 'and options.force_exclusion? is true' do
+          before do
+            allow(options).to receive(:force_exclusion?).and_return(true)
+          end
+
+          it 'excludes this file' do
+            sources = described_class.new([path], configuration: configuration, options: options).sources
+            expect(sources).not_to include(path)
+          end
+        end
+
+        context 'and options.force_exclusion? is false' do
+          before do
+            allow(options).to receive(:force_exclusion?).and_return(false)
+          end
+
+          it 'includes this file' do
+            sources = described_class.new([path], configuration: configuration, options: options).sources
+            expect(sources).to include(path)
+          end
+        end
+      end
+
       context 'when the path is a file name in an excluded directory' do
         let(:path) { SAMPLES_PATH.join('source_with_exclude_paths', 'ignore_me', 'uncommunicative_method_name.rb') }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.6.0
+  version: 4.6.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-04 00:00:00.000000000 Z
+date: 2017-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb