reek 4.4.0 → 4.4.1

data/spec/reek/spec/should_reek_of_spec.rb

@@ -112,9 +112,9 @@ RSpec.describe Reek::Spec::ShouldReekOf do
           Expected string to reek of DuplicateMethodCall (which it did) with smell details {:name=>"foo", :count=>15}, which it didn't.
           The number of smell details I had to compare with the given one was 2 and here they are:
           1.)
-          {"context"=>"double_thing", "lines"=>[1, 1], "message"=>"calls @other.thing 2 times", "source"=>"string", "name"=>"@other.thing", "count"=>2}
+          {"context"=>"double_thing", "lines"=>[1, 1], "message"=>"calls '@other.thing' 2 times", "source"=>"string", "name"=>"@other.thing", "count"=>2}
           2.)
-          {"context"=>"double_thing", "lines"=>[1, 1], "message"=>"calls @other.thing.foo 2 times", "source"=>"string", "name"=>"@other.thing.foo", "count"=>2}
+          {"context"=>"double_thing", "lines"=>[1, 1], "message"=>"calls '@other.thing.foo' 2 times", "source"=>"string", "name"=>"@other.thing.foo", "count"=>2}
         EOS
 
         expect(matcher.failure_message).to eq(expected)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.4.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-24 00:00:00.000000000 Z
+date: 2016-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb
@@ -103,7 +103,9 @@ files:
 - docs/Data-Clump.md
 - docs/Duplicate-Method-Call.md
 - docs/Feature-Envy.md
+- docs/How-To-Write-New-Detectors.md
 - docs/How-reek-works-internally.md
+- docs/Instance-Variable-Assumption.md
 - docs/Irresponsible-Module.md
 - docs/Large-Class.md
 - docs/Long-Parameter-List.md
@@ -119,6 +121,7 @@ files:
 - docs/Repeated-Conditional.md
 - docs/Simulated-Polymorphism.md
 - docs/Smell-Suppression.md
+- docs/Style-Guide.md
 - docs/Subclassed-From-Core-Class.md
 - docs/Too-Many-Constants.md
 - docs/Too-Many-Instance-Variables.md
@@ -134,7 +137,6 @@ files:
 - docs/Utility-Function.md
 - docs/Versioning-Policy.md
 - docs/YAML-Reports.md
-- docs/style-guide.md
 - docs/templates/default/docstring/html/public_api_marker.erb
 - docs/templates/default/docstring/setup.rb
 - docs/templates/default/fulldoc/html/css/common.css
@@ -197,7 +199,6 @@ files:
 - lib/reek/cli/command/todo_list_command.rb
 - lib/reek/cli/options.rb
 - lib/reek/cli/silencer.rb
-- lib/reek/cli/warning_collector.rb
 - lib/reek/code_comment.rb
 - lib/reek/configuration/app_configuration.rb
 - lib/reek/configuration/configuration_file_finder.rb
@@ -314,7 +315,6 @@ files:
 - spec/reek/cli/command/report_command_spec.rb
 - spec/reek/cli/command/todo_list_command_spec.rb
 - spec/reek/cli/options_spec.rb
-- spec/reek/cli/warning_collector_spec.rb
 - spec/reek/code_comment_spec.rb
 - spec/reek/configuration/app_configuration_spec.rb
 - spec/reek/configuration/configuration_file_finder_spec.rb
@@ -357,7 +357,6 @@ files:
 - spec/reek/smells/prima_donna_method_spec.rb
 - spec/reek/smells/repeated_conditional_spec.rb
 - spec/reek/smells/smell_configuration_spec.rb
-- spec/reek/smells/smell_detector_shared.rb
 - spec/reek/smells/smell_detector_spec.rb
 - spec/reek/smells/smell_repository_spec.rb
 - spec/reek/smells/smell_warning_spec.rb
@@ -412,7 +411,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Code smell detector for Ruby

data/lib/reek/cli/warning_collector.rb

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-require 'set'
-
-module Reek
-  module CLI
-    #
-    # Collects and sorts smells warnings.
-    #
-    class WarningCollector
-      def initialize
-        @warnings_set = Set.new
-      end
-
-      def found_smell(warning)
-        warnings_set.add(warning)
-      end
-
-      def warnings
-        warnings_set.sort
-      end
-
-      private
-
-      attr_reader :warnings_set
-    end
-  end
-end

data/spec/reek/cli/warning_collector_spec.rb

@@ -1,25 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/cli/warning_collector'
-require_lib 'reek/smells/smell_warning'
-
-RSpec.describe Reek::CLI::WarningCollector do
-  let(:collector) { described_class.new }
-
-  context 'when empty' do
-    it 'reports no warnings' do
-      expect(collector.warnings).to eq([])
-    end
-  end
-
-  context 'with one warning' do
-    it 'reports that warning' do
-      warning = Reek::Smells::SmellWarning.new(Reek::Smells::FeatureEnvy.new,
-                                               source:  'string',
-                                               context: 'foo',
-                                               lines:   [1, 2, 3],
-                                               message: 'hello')
-      collector.found_smell(warning)
-      expect(collector.warnings).to eq([warning])
-    end
-  end
-end

data/spec/reek/smells/smell_detector_shared.rb

@@ -1,29 +0,0 @@
-require_relative '../../spec_helper'
-
-RSpec.shared_examples_for 'SmellDetector' do
-  context 'exception matching follows the context' do
-    let(:ctx) { double('context') }
-
-    before { allow(ctx).to receive(:config_for).and_return({}) }
-
-    it 'when false' do
-      expect(ctx).to receive(:matches?).at_least(:once).and_return(false)
-      expect(detector.exception?(ctx)).to eq(false)
-    end
-
-    it 'when true' do
-      expect(ctx).to receive(:matches?).at_least(:once).and_return(true)
-      expect(detector.exception?(ctx)).to eq(true)
-    end
-  end
-end
-
-RSpec.shared_examples_for 'common fields set correctly' do
-  it 'reports the source' do
-    expect(warning.source).to eq('string')
-  end
-
-  it 'reports the smell type' do
-    expect(warning.smell_type).to eq(detector.smell_type)
-  end
-end