reek 4.3.0 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e3c2e9cc70f29c322ad9284d8412aafc7d1dba9
-  data.tar.gz: b2bbee88bc846020a28cb27214d0ea09a1fbb1c7
+  metadata.gz: 9e0d256e7194e6839716a3817b6fe951985f4fc8
+  data.tar.gz: ec2e207fe63cd0c8cd5b48071e660bd83ccb1cc6
 SHA512:
-  metadata.gz: cc8a77b31dcbc0be82506493b24654f299cd21c5f8ecf2484d962a73363072c372d09d8d9e58223197c6fb9934a0de0f42481bf131146297d3f653194219110c
-  data.tar.gz: 5fca779e7aa91f5a7e6b943fd3923f4cada5a50364e3952ed30def4a16dd112b3267bcca1fde743e627008cc534c9c82ba223dd4a4f8502bfb346a7b2da5154f
+  metadata.gz: 6a2f747bdbded9c2610d934c23b07a72b001a93a9a9ed99d20b9e2bdea7c6ed5e7e667c8e05713b1e77e148294fb8e4cd34d606e197829744491db395a0c964b
+  data.tar.gz: 16d71aee67557e3f4d78cba1d45c8452032ccf76148c57b0c50650d0bff4f8fbcb4ecc9020df33a88746a80cce65235231e5b9a4f610e187a47a43baba27b1bf

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change log
 
+## 4.4.0 (2016-08-24)
+
+* (waldyr) Add ignored nodes parameter to local_nodes
+* (waldyr) Add Instance Variable Assumption smell detector
+* (waldyr) Remove memoized instance variables from accounting of TooManyInstanceVariables smell
+
 ## 4.3.0 (2016-08-23)
 
 * (backus) Add ManualDispatch smell.

data/CONTRIBUTING.md

@@ -105,6 +105,9 @@ git rebase -i master
 # squash squash squash
 git push -f origin
 ```
+## Failing Cucumber Scenarios
+
+If there is a failing scenario and you can not figure out why it is failing, just run the failing scenario: `bundle exec cucumber features/failing_scenario.feature:line`. By doing so Aruba will leave its set up in the `tmp/aruba` directory. You can then `cd` into this directory and run Reek the same way the cucumber scenario actually ran it. This way you can debug scenario failures that can be very opaque sometimes.
 
 ## Versioning policy
 

data/README.md

@@ -510,6 +510,8 @@ Just add this to your configuration file:
     max_allowed_nesting: 2
   UnusedPrivateMethod:
     enabled: false
+  InstanceVariableAssumption:
+    enabled: false
 "app/helpers":
   IrresponsibleModule:
     enabled: false

data/defaults.reek

@@ -24,6 +24,9 @@ DuplicateMethodCall:
 FeatureEnvy:
   enabled: true
   exclude: []
+InstanceVariableAssumption:
+  enabled: true
+  exclude: []
 IrresponsibleModule:
   enabled: true
   exclude: []

data/features/configuration_files/directory_specific_directives.feature

@@ -49,10 +49,12 @@ Feature: Directory directives
     When I run `reek -c web_app/config.reek web_app/`
     Then it reports:
     """
+    web_app/app/controllers/users_controller.rb -- 1 warning:
+      [1]:InstanceVariableAssumption: UsersController assumes too much for instance variable @user [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
     web_app/app/models/user.rb -- 2 warnings:
       [1]:IrresponsibleModule: User has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
       [2]:UnusedParameters: User#logged_in_with_role has unused parameter 'r' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-    2 total warnings
+    3 total warnings
     """
 
   Scenario: Ignore trailing slashes
@@ -118,12 +120,13 @@ Feature: Directory directives
     When I run `reek -c web_app/config.reek web_app/`
     Then it reports:
     """
-    web_app/app/controllers/users_controller.rb -- 2 warnings:
+    web_app/app/controllers/users_controller.rb -- 3 warnings:
+      [1]:InstanceVariableAssumption: UsersController assumes too much for instance variable @user [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
       [1]:IrresponsibleModule: UsersController has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
       [4]:NestedIterators: UsersController#show contains iterators nested 2 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
     web_app/app/models/user.rb -- 1 warning:
       [2]:UnusedParameters: User#logged_in_with_role has unused parameter 'r' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-    3 total warnings
+    4 total warnings
     """
 
   Scenario: Use the default directive if there is no directory directive
@@ -163,11 +166,13 @@ Feature: Directory directives
     When I run `reek -c config.reek other/ web_app/`
     Then it reports:
     """
-    other/projects_controller.rb -- 1 warning:
+    other/projects_controller.rb -- 2 warnings:
+      [1]:InstanceVariableAssumption: ProjectController assumes too much for instance variable @project [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
       [4]:NestedIterators: ProjectController#show contains iterators nested 2 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
-    web_app/app/controllers/users_controller.rb -- 1 warning:
+    web_app/app/controllers/users_controller.rb -- 2 warnings:
+      [1]:InstanceVariableAssumption: UsersController assumes too much for instance variable @user [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
       [1]:IrresponsibleModule: UsersController has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-    2 total warnings
+    4 total warnings
     """
 
   Scenario: Abort on non-existent smell type in directory directive

data/features/samples.feature

@@ -11,7 +11,7 @@ Feature: Basic smell detection
     Then the exit status indicates smells
     And it reports:
     """
-    inline.rb -- 48 warnings:
+    inline.rb -- 51 warnings:
       BooleanParameter: Inline::C#parse_signature has boolean parameter 'raw' [https://github.com/troessner/reek/blob/master/docs/Boolean-Parameter.md]
       ClassVariable: Inline declares the class variable @@directory [https://github.com/troessner/reek/blob/master/docs/Class-Variable.md]
       ClassVariable: Inline declares the class variable @@rootdir [https://github.com/troessner/reek/blob/master/docs/Class-Variable.md]
@@ -32,6 +32,9 @@ Feature: Basic smell detection
       DuplicateMethodCall: Inline::C#initialize calls stack.empty? 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
       DuplicateMethodCall: Module#inline calls Inline.const_get(lang) 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
       DuplicateMethodCall: Module#inline calls options[:testing] 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
+      InstanceVariableAssumption: Inline::C assumes too much for instance variable @module_name [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
+      InstanceVariableAssumption: Inline::C assumes too much for instance variable @so_name [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
+      InstanceVariableAssumption: Inline::C assumes too much for instance variable @types [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
       IrresponsibleModule: CompilationError has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
       IrresponsibleModule: Dir has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
       IrresponsibleModule: File has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
@@ -60,7 +63,7 @@ Feature: Basic smell detection
       UncommunicativeVariableName: Inline::C#module_name has the variable name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       UncommunicativeVariableName: Inline::C#parse_signature has the variable name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       UtilityFunction: Inline::C#strip_comments doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
-    optparse.rb -- 124 warnings:
+    optparse.rb -- 126 warnings:
       Attribute: OptionParser#banner is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: OptionParser#default_argv is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: OptionParser#program_name is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
@@ -115,6 +118,8 @@ Feature: Basic smell detection
       FeatureEnvy: OptionParser::List#accept refers to pat more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
       FeatureEnvy: OptionParser::List#add_banner refers to opt more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
       FeatureEnvy: OptionParser::List#summarize refers to opt more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
+      InstanceVariableAssumption: OptionParser assumes too much for instance variable @release [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
+      InstanceVariableAssumption: OptionParser assumes too much for instance variable @version [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
       LongParameterList: OptionParser#complete has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
       LongParameterList: OptionParser#summarize has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
       LongParameterList: OptionParser::List#complete has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
@@ -185,7 +190,7 @@ Feature: Basic smell detection
       UnusedParameters: OptionParser::Completion#convert has unused parameter 'opt' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: OptionParser::Switch::NoArgument#parse has unused parameter 'argv' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: OptionParser::Switch::OptionalArgument#parse has unused parameter 'argv' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-    redcloth.rb -- 105 warnings:
+    redcloth.rb -- 110 warnings:
       Attribute: RedCloth#filter_html is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: RedCloth#filter_styles is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: RedCloth#hard_breaks is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
@@ -220,6 +225,11 @@ Feature: Basic smell detection
       FeatureEnvy: RedCloth#blocks refers to blk more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
       FeatureEnvy: RedCloth#clean_white_space refers to text more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
       FeatureEnvy: RedCloth#pba refers to text more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
+      InstanceVariableAssumption: RedCloth assumes too much for instance variable @lite_mode [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
+      InstanceVariableAssumption: RedCloth assumes too much for instance variable @pre_list [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
+      InstanceVariableAssumption: RedCloth assumes too much for instance variable @rules [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
+      InstanceVariableAssumption: RedCloth assumes too much for instance variable @shelf [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
+      InstanceVariableAssumption: RedCloth assumes too much for instance variable @urlrefs [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]
       LongParameterList: RedCloth#textile_bq has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
       LongParameterList: RedCloth#textile_fn_ has 5 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
       LongParameterList: RedCloth#textile_p has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
@@ -291,5 +301,5 @@ Feature: Basic smell detection
       UtilityFunction: RedCloth#lT doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#no_textile doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#v_align doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
-    277 total warnings
+    287 total warnings
     """

data/lib/reek/context/code_context.rb

@@ -68,8 +68,9 @@ module Reek
       # @param type [Symbol] the type of the nodes we are looking for, e.g. :defs.
       # @yield block that is executed for every node.
       #
-      def local_nodes(type, &blk)
-        each_node(type, [:casgn, :class, :module], &blk)
+      def local_nodes(type, ignored = [], &blk)
+        ignored += [:casgn, :class, :module]
+        each_node(type, ignored, &blk)
       end
 
       # Iterate over `self` and child contexts.

data/lib/reek/smells.rb

@@ -7,6 +7,7 @@ require_relative 'smells/data_clump'
 require_relative 'smells/duplicate_method_call'
 require_relative 'smells/feature_envy'
 require_relative 'smells/irresponsible_module'
+require_relative 'smells/instance_variable_assumption'
 require_relative 'smells/long_parameter_list'
 require_relative 'smells/long_yield_list'
 require_relative 'smells/manual_dispatch'

data/lib/reek/smells/instance_variable_assumption.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+require_relative 'smell_detector'
+require_relative 'smell_warning'
+
+module Reek
+  module Smells
+    #
+    # The +InstanceVariableAssumption+ class is responsible for
+    # detecting directly access of instance variables in a class
+    # that does not define them in its initialize method.
+    #
+    class InstanceVariableAssumption < SmellDetector
+      def self.contexts
+        [:class]
+      end
+
+      # Checks +klass+ for instance
+      # variables assumptions.
+      #
+      # @return [Array<SmellWarning>]
+      #
+      def sniff(ctx)
+        method_expressions = ctx.node_instance_methods
+
+        assumptions = (variables_from_context(method_expressions) -
+          variables_from_initialize(method_expressions)).uniq
+
+        assumptions.map do |assumption|
+          build_smell_warning(ctx, assumption)
+        end
+      end
+
+      private
+
+      def build_smell_warning(ctx, assumption)
+        message = "assumes too much for instance variable #{assumption}"
+
+        smell_warning(
+          context: ctx,
+          lines: [ctx.exp.line],
+          message: message,
+          parameters: { assumption: assumption })
+      end
+
+      # :reek:UtilityFunction
+      def variables_from_initialize(instance_methods)
+        initialize_exp = instance_methods.detect do |method|
+          method.name == :initialize
+        end
+
+        return [] unless initialize_exp
+
+        initialize_exp.each_node(:ivasgn).map(&:name)
+      end
+
+      def variables_from_context(instance_methods)
+        instance_methods.map do |method|
+          method.find_nodes(assumption_nodes, ignored_nodes).map(&:name)
+        end.flatten
+      end
+
+      def assumption_nodes
+        [:ivar]
+      end
+
+      def ignored_nodes
+        [:or_asgn]
+      end
+    end
+  end
+end

data/lib/reek/smells/too_many_instance_variables.rb

@@ -35,7 +35,8 @@ module Reek
       #
       def sniff(ctx)
         max_allowed_ivars = value(MAX_ALLOWED_IVARS_KEY, ctx)
-        count = ctx.local_nodes(:ivasgn).map { |ivasgn| ivasgn.children.first }.uniq.length
+        variables = ctx.local_nodes(:ivasgn, [:or_asgn]).map(&:name)
+        count = variables.uniq.size
         return [] if count <= max_allowed_ivars
         [smell_warning(
           context: ctx,

data/lib/reek/version.rb

@@ -7,6 +7,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '4.3.0'.freeze
+    STRING = '4.4.0'.freeze
   end
 end

data/spec/reek/smells/instance_variable_assumption_spec.rb

@@ -0,0 +1,195 @@
+require_relative '../../spec_helper'
+
+require_lib 'reek/smells/instance_variable_assumption'
+
+RSpec.describe Reek::Smells::InstanceVariableAssumption do
+  describe 'warning' do
+    context 'smell line' do
+      it 'should report the lines' do
+        src = <<-EOS
+          class Dummy
+            def test
+              @a
+            end
+          end
+        EOS
+
+        expect(src).to reek_of(:InstanceVariableAssumption, lines: [1])
+      end
+    end
+
+    context 'smell parameters' do
+      it 'should report the lines' do
+        src = <<-EOS
+          class Dummy
+            def test
+              @a
+            end
+          end
+        EOS
+
+        expect(src).to reek_of(:InstanceVariableAssumption, assumption: :@a)
+      end
+    end
+
+    context 'smell context' do
+      it 'should report the context' do
+        src = <<-EOS
+          class Dummy
+            def test
+              @a
+            end
+          end
+        EOS
+
+        expect(src).to reek_of(:InstanceVariableAssumption, context: 'Dummy')
+      end
+    end
+
+    context 'smell message' do
+      it 'should report the ivars in the message' do
+        message_a = 'assumes too much for instance variable @a'
+        message_b = 'assumes too much for instance variable @b'
+
+        src = <<-EOS
+          class Dummy
+            def test
+              [@a, @b]
+            end
+          end
+        EOS
+
+        expect(src).to reek_of(:InstanceVariableAssumption, message: message_a)
+        expect(src).to reek_of(:InstanceVariableAssumption, message: message_b)
+      end
+
+      it 'should report each ivar once' do
+        message_a = 'assumes too much for instance variable @a'
+        message_b = 'assumes too much for instance variable @b'
+        message_c = 'assumes too much for instance variable @c'
+
+        src = <<-EOS
+          class Dummy
+            def test
+              [@a, @a, @b, @c]
+            end
+
+            def retest
+              @c
+            end
+          end
+        EOS
+
+        expect(src).to reek_of(:InstanceVariableAssumption, message: message_a)
+        expect(src).to reek_of(:InstanceVariableAssumption, message: message_b)
+        expect(src).to reek_of(:InstanceVariableAssumption, message: message_c)
+      end
+    end
+  end
+
+  it 'should not report an empty class' do
+    src = <<-EOS
+      class Dummy
+      end
+    EOS
+
+    expect(src).not_to reek_of(:InstanceVariableAssumption)
+  end
+
+  it 'should not report when lazy initializing' do
+    src = <<-EOS
+      class Dummy
+        def test
+          @a ||= 1
+        end
+      end
+    EOS
+
+    expect(src).not_to reek_of(:InstanceVariableAssumption)
+  end
+
+  it 'should report when making instance variable assumption' do
+    src = <<-EOS
+      class Dummy
+        def test
+          @a
+        end
+      end
+    EOS
+
+    expect(src).to reek_of(:InstanceVariableAssumption)
+  end
+
+  it 'reports variable even if others are initialized' do
+    src = <<-EOS
+      class Dummy
+        def initialize
+          @a = 1
+        end
+
+        def test
+          [@a, @b]
+        end
+      end
+    EOS
+
+    expect(src).to reek_of(:InstanceVariableAssumption)
+  end
+
+  context 'inner classes' do
+    it 'should report outter class' do
+      src = <<-EOS
+        class Dummy
+          def test
+            @a
+          end
+
+          class Dummiest
+          end
+        end
+      EOS
+
+      expect(src).to reek_of(:InstanceVariableAssumption, context: 'Dummy')
+    end
+
+    it 'should report even if outer class initialize the variable' do
+      src = <<-EOS
+        class Dummy
+          def initialize
+            @a = 1
+          end
+
+          class Dummiest
+            def test
+              @a
+            end
+          end
+        end
+      EOS
+
+      expect(src).to reek_of(:InstanceVariableAssumption, context: 'Dummy::Dummiest')
+    end
+
+    it 'should report inner classes' do
+      src = <<-EOS
+        class Dummy
+          def initialize
+            @a = 1
+          end
+
+          class Dummiest
+            def initialize
+              @b = 1
+            end
+
+            def test
+              @c
+            end
+          end
+        end
+      EOS
+
+      expect(src).to reek_of(:InstanceVariableAssumption, context: 'Dummy::Dummiest')
+    end
+  end
+end

data/spec/reek/smells/too_many_instance_variables_spec.rb

@@ -1,24 +1,24 @@
 require_relative '../../spec_helper'
 require_lib 'reek/smells/too_many_instance_variables'
-require_relative 'smell_detector_shared'
 
 RSpec.describe Reek::Smells::TooManyInstanceVariables do
-  let(:detector) { build(:smell_detector, smell_type: :TooManyInstanceVariables) }
-
-  it_should_behave_like 'SmellDetector'
-
-  def default_max_ivars
-    Reek::Smells::TooManyInstanceVariables::DEFAULT_MAX_IVARS
-  end
-
-  def too_many_ivars
-    default_max_ivars + 1
-  end
+  context 'reporting smell' do
+    it 'reports the smell parameters' do
+      src = <<-EOS
+        class Empty
+          def ivars
+            @a = @b = @c = @d = 1
+            @e = 1
+          end
+        end
+      EOS
 
-  def ivar_sequence(count: default_max_ivars, alphabet: ('a'..'z').to_a)
-    alphabet.first(count).map do |name|
-      "@#{name}=#{rand}"
-    end.join(',')
+      expect(src).to reek_of(described_class,
+                             lines: [1],
+                             count: 5,
+                             message: 'has at least 5 instance variables',
+                             context: 'Empty')
+    end
   end
 
   context 'counting instance variables' do
@@ -26,73 +26,130 @@ RSpec.describe Reek::Smells::TooManyInstanceVariables do
       src = <<-EOS
         class Empty
           def ivars
-           #{ivar_sequence}
+            @a = @b = @c = @d = 1
           end
         end
       EOS
-      expect(src).not_to reek_of(:TooManyInstanceVariables)
+      expect(src).not_to reek_of(described_class)
+    end
+
+    it 'has a configurable maximum' do
+      src = <<-EOS
+        # :reek:TooManyInstanceVariables: { max_instance_variables: 5 }
+        class Empty
+          def ivars
+            @a = @b = @c = @d = 1
+            @e = 1
+          end
+        end
+      EOS
+      expect(src).not_to reek_of(described_class)
     end
 
     it 'counts each ivar only once' do
       src = <<-EOS
         class Empty
           def ivars
-           #{ivar_sequence}
-           #{ivar_sequence}
+            @a = @b = @c = @d = 1
+            @a = @b = @c = @d = 1
           end
         end
       EOS
-      expect(src).not_to reek_of(:TooManyInstanceVariables)
+      expect(src).not_to reek_of(described_class)
     end
 
-    it 'should report excessive ivars' do
+    it 'should not report memoized ivars' do
       src = <<-EOS
         class Empty
           def ivars
-            #{ivar_sequence(count: too_many_ivars)}
+            @a = @b = @c = @d = 1
+            @e ||= 1
           end
         end
       EOS
-      expect(src).to reek_of(:TooManyInstanceVariables)
+      expect(src).not_to reek_of(described_class)
     end
 
-    it 'should not report for ivars in 2 extensions' do
+    it 'should not count ivars on inner classes altogether' do
       src = <<-EOS
-        class Full
-          def ivars_a
-            #{ivar_sequence}
+        class Empty
+          class InnerA
+            def ivars
+              @a = @b = @c = @d = 1
+            end
+          end
+
+          class InnerB
+            def ivars
+              @e = 1
+            end
           end
         end
+      EOS
+      expect(src).not_to reek_of(described_class)
+    end
 
-        class Full
-          def ivars_b
-            #{ivar_sequence}
+    it 'should not count ivars on modules altogether' do
+      src = <<-EOS
+        class Empty
+          class InnerA
+            def ivars
+              @a = @b = @c = @d = 1
+            end
+          end
+
+          module InnerB
+            def ivars
+              @e = 1
+            end
           end
         end
       EOS
-      expect(src).not_to reek_of(:TooManyInstanceVariables)
+      expect(src).not_to reek_of(described_class)
     end
-  end
 
-  context 'when a smell is reported' do
-    let(:warning) do
+    it 'reports excessive ivars' do
       src = <<-EOS
-        # Comment
         class Empty
           def ivars
-            #{ivar_sequence(count: too_many_ivars)}
+            @a = @b = @c = @d = 1
+            @e = 1
+          end
+        end
+      EOS
+      expect(src).to reek_of(described_class)
+    end
+
+    it 'reports excessive ivars even in different methods' do
+      src = <<-EOS
+        class Empty
+          def ivars_a
+            @a = @b = @c = @d = 1
+          end
+
+          def ivars_b
+            @e = 1
           end
         end
       EOS
-      ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      detector.sniff(ctx).first
+      expect(src).to reek_of(described_class)
     end
 
-    it_should_behave_like 'common fields set correctly'
+    it 'should not report for ivars in 2 extensions' do
+      src = <<-EOS
+        class Full
+          def ivars_a
+            @a = @b = @c = @d = 1
+          end
+        end
 
-    it 'reports the correct values' do
-      expect(warning.parameters[:count]).to eq(too_many_ivars)
-      expect(warning.lines).to eq([2])
+        class Full
+          def ivars_b
+            @a = @b = @c = @d = 1
+          end
+        end
+      EOS
+      expect(src).not_to reek_of(described_class)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.4.0
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-23 00:00:00.000000000 Z
+date: 2016-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb
@@ -236,6 +236,7 @@ files:
 - lib/reek/smells/data_clump.rb
 - lib/reek/smells/duplicate_method_call.rb
 - lib/reek/smells/feature_envy.rb
+- lib/reek/smells/instance_variable_assumption.rb
 - lib/reek/smells/irresponsible_module.rb
 - lib/reek/smells/long_parameter_list.rb
 - lib/reek/smells/long_yield_list.rb
@@ -345,6 +346,7 @@ files:
 - spec/reek/smells/data_clump_spec.rb
 - spec/reek/smells/duplicate_method_call_spec.rb
 - spec/reek/smells/feature_envy_spec.rb
+- spec/reek/smells/instance_variable_assumption_spec.rb
 - spec/reek/smells/irresponsible_module_spec.rb
 - spec/reek/smells/long_parameter_list_spec.rb
 - spec/reek/smells/long_yield_list_spec.rb
@@ -410,7 +412,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Code smell detector for Ruby