reek 4.1.0 → 4.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb4b9a8e91de50f96e7fc83d96e72f92af778dfc
-  data.tar.gz: f33a99fd21ffa8d82eb48d4e1cde69a0a01e0468
+  metadata.gz: cd5651b2cc5c8b32a2eb8d1297c190b67ebf3f6b
+  data.tar.gz: 948781b5c00280ff13499c1a31cf634f495e5736
 SHA512:
-  metadata.gz: 82da2cb804ea9c2fe37665072c0666350c7a22ba0e857f3629589ca7f91e87a55ee84ae198cd01e06d51e7e00d16b1aabde1b5d7f3cd59523435118e6692d954
-  data.tar.gz: 5177823be762c3c3354144a57abee5c1fea661d2ed9f947e63233a16de0aeae3dd8ac443bd3beb17cb7f3d22ac1d0d12f106a8e8eab568a934b878d8bf550cdd
+  metadata.gz: 16653eda1cae7ac27cf6f439f45b8d2f77e8c954bd9e989cd70fdfa0c5c553cebb3caa97bb6a8696312a5029120455a7e7c45e20a46b42b3823d77c25abc3a2d
+  data.tar.gz: ecc7e1105e00ae9e6f284889ad5fc58e19eee73d79fde9f6c6ae9194ed6ad2b29c06006e3eee8e74356a4f629b04cfb001ab6e8ea9c7ad1dc4e263051a1edb83

data/.rubocop.yml

@@ -52,6 +52,10 @@ Style/FrozenStringLiteralComment:
 Style/MultilineBlockChain:
   Enabled: false
 
+# Always put the closing brace on the last line
+Style/MultilineMethodCallBraceLayout:
+  EnforcedStyle: same_line
+
 # Indent one level for follow-up lines
 Style/MultilineMethodCallIndentation:
   EnforcedStyle: indented

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 4.1.1 (2016-07-05)
+
+* (waldyr) Checking lambda should not raise error
+
 ## 4.1.0 (2016-06-23)
 
 * (waldyr) Add SubclassedFromCoreClass detector

data/Gemfile

@@ -10,9 +10,10 @@ group :development do
   gem 'mutant-rspec',  '~> 0.8.8'
   gem 'rake',          '~> 11.1'
   gem 'rspec',         '~> 3.0'
-  gem 'rubocop',       '~> 0.39.0'
+  gem 'rubocop',       '~> 0.41.1'
   gem 'simplecov',     '~> 0.11.1'
   gem 'yard',          '~> 0.8.7'
+  gem 'activesupport', '~> 4.2.7.rc1'
 
   platforms :mri do
     gem 'redcarpet', '~> 3.3.1'

data/defaults.reek

@@ -115,3 +115,4 @@ UnusedPrivateMethod:
 UtilityFunction:
   enabled: true
   exclude: []
+  public_methods_only: false

data/lib/reek/ast/sexp_extensions/lambda.rb

@@ -7,6 +7,10 @@ module Reek
         def name
           'lambda'
         end
+
+        def module_creation_call?
+          false
+        end
       end
     end
   end

data/lib/reek/cli/options.rb

@@ -109,8 +109,7 @@ module Reek
         parser.on(
           '-f', '--format FORMAT', [:html, :text, :yaml, :json, :xml, :code_climate],
           'Report smells in the given format:',
-          '  html', '  text (default)', '  yaml', '  json', '  xml', '  code_climate'
-        ) do |opt|
+          '  html', '  text (default)', '  yaml', '  json', '  xml', '  code_climate') do |opt|
           self.report_format = opt
         end
       end

data/lib/reek/configuration/app_configuration.rb

@@ -72,10 +72,9 @@ module Reek
 
       def load_values(configuration_hash)
         configuration_hash.each do |key, value|
-          case
-          when key == EXCLUDE_PATHS_KEY
+          if key == EXCLUDE_PATHS_KEY
             excluded_paths.add value
-          when smell_type?(key)
+          elsif smell_type?(key)
             default_directive.add key, value
           else
             directory_directives.add key, value

data/lib/reek/report.rb

@@ -25,7 +25,8 @@ module Reek
 
     HEADING_FORMATTERS = {
       verbose: HeadingFormatter::Verbose,
-      quiet: HeadingFormatter::Quiet }.freeze
+      quiet: HeadingFormatter::Quiet
+    }.freeze
 
     WARNING_FORMATTER_CLASSES = {
       wiki_links: WikiLinkWarningFormatter,

data/lib/reek/report/code_climate/code_climate_formatter.rb

@@ -15,8 +15,7 @@ module Reek
                             categories: categories,
                             location: location,
                             remediation_points: remediation_points,
-                            content: content
-                           ).render
+                            content: content).render
       end
 
       private
@@ -39,8 +38,7 @@ module Reek
         warning_lines = warning.lines
         CCEngine::Location::LineRange.new(
           path: warning.source,
-          line_range: warning_lines.first..warning_lines.last
-        )
+          line_range: warning_lines.first..warning_lines.last)
       end
 
       def remediation_points

data/lib/reek/smells/data_clump.rb

@@ -42,8 +42,7 @@ module Reek
       def self.default_config
         super.merge(
           MAX_COPIES_KEY => DEFAULT_MAX_COPIES,
-          MIN_CLUMP_SIZE_KEY => DEFAULT_MIN_CLUMP_SIZE
-        )
+          MIN_CLUMP_SIZE_KEY => DEFAULT_MIN_CLUMP_SIZE)
       end
 
       #

data/lib/reek/smells/duplicate_method_call.rb

@@ -33,8 +33,7 @@ module Reek
       def self.default_config
         super.merge(
           MAX_ALLOWED_CALLS_KEY => DEFAULT_MAX_CALLS,
-          ALLOW_CALLS_KEY => DEFAULT_ALLOW_CALLS
-        )
+          ALLOW_CALLS_KEY => DEFAULT_ALLOW_CALLS)
       end
 
       #

data/lib/reek/smells/long_parameter_list.rb

@@ -25,8 +25,7 @@ module Reek
           MAX_ALLOWED_PARAMS_KEY => DEFAULT_MAX_ALLOWED_PARAMS,
           SmellConfiguration::OVERRIDES_KEY => {
             'initialize' => { MAX_ALLOWED_PARAMS_KEY => 5 }
-          }
-        )
+          })
       end
 
       #

data/lib/reek/smells/nested_iterators.rb

@@ -31,8 +31,7 @@ module Reek
       def self.default_config
         super.merge(
           MAX_ALLOWED_NESTING_KEY => DEFAULT_MAX_ALLOWED_NESTING,
-          IGNORE_ITERATORS_KEY => DEFAULT_IGNORE_ITERATORS
-        )
+          IGNORE_ITERATORS_KEY => DEFAULT_IGNORE_ITERATORS)
       end
 
       # Generates a smell warning for each independent deepest nesting depth

data/lib/reek/smells/too_many_instance_variables.rb

@@ -25,8 +25,7 @@ module Reek
       def self.default_config
         super.merge(
           MAX_ALLOWED_IVARS_KEY => DEFAULT_MAX_IVARS,
-          EXCLUDE_KEY => []
-        )
+          EXCLUDE_KEY => [])
       end
 
       #

data/lib/reek/smells/too_many_methods.rb

@@ -27,8 +27,7 @@ module Reek
       def self.default_config
         super.merge(
           MAX_ALLOWED_METHODS_KEY => DEFAULT_MAX_METHODS,
-          EXCLUDE_KEY => []
-        )
+          EXCLUDE_KEY => [])
       end
 
       #

data/lib/reek/smells/too_many_statements.rb

@@ -19,8 +19,7 @@ module Reek
       def self.default_config
         super.merge(
           MAX_ALLOWED_STATEMENTS_KEY => DEFAULT_MAX_STATEMENTS,
-          EXCLUDE_KEY => ['initialize']
-        )
+          EXCLUDE_KEY => ['initialize'])
       end
 
       #

data/lib/reek/smells/uncommunicative_method_name.rb

@@ -28,8 +28,7 @@ module Reek
       def self.default_config
         super.merge(
           REJECT_KEY => DEFAULT_REJECT_PATTERNS,
-          ACCEPT_KEY => DEFAULT_ACCEPT_PATTERNS
-        )
+          ACCEPT_KEY => DEFAULT_ACCEPT_PATTERNS)
       end
 
       #

data/lib/reek/smells/uncommunicative_module_name.rb

@@ -33,8 +33,7 @@ module Reek
       def self.default_config
         super().merge(
           REJECT_KEY => DEFAULT_REJECT_PATTERNS,
-          ACCEPT_KEY => DEFAULT_ACCEPT_PATTERNS
-        )
+          ACCEPT_KEY => DEFAULT_ACCEPT_PATTERNS)
       end
 
       def self.contexts

data/lib/reek/smells/uncommunicative_parameter_name.rb

@@ -30,8 +30,7 @@ module Reek
       def self.default_config
         super.merge(
           REJECT_KEY => DEFAULT_REJECT_PATTERNS,
-          ACCEPT_KEY => DEFAULT_ACCEPT_PATTERNS
-        )
+          ACCEPT_KEY => DEFAULT_ACCEPT_PATTERNS)
       end
 
       #

data/lib/reek/smells/uncommunicative_variable_name.rb

@@ -35,8 +35,7 @@ module Reek
       def self.default_config
         super.merge(
           REJECT_KEY => DEFAULT_REJECT_SET,
-          ACCEPT_KEY => DEFAULT_ACCEPT_SET
-        )
+          ACCEPT_KEY => DEFAULT_ACCEPT_SET)
       end
 
       def self.contexts

data/lib/reek/version.rb

@@ -7,6 +7,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '4.1.0'.freeze
+    STRING = '4.1.1'.freeze
   end
 end

data/spec/reek/ast/sexp_extensions_spec.rb

@@ -466,6 +466,14 @@ RSpec.describe Reek::AST::SexpExtensions::CasgnNode do
         expect(exp.defines_module?).to be_truthy
       end
     end
+
+    context 'when assign a lambda to a constant' do
+      it 'does not define a module' do
+        exp = Reek::Source::SourceCode.from('C = ->{}').syntax_tree
+
+        expect(exp.defines_module?).to be_falsey
+      end
+    end
   end
 
   context '#superclass' do

data/spec/reek/report/code_climate_formatter_spec.rb

@@ -11,34 +11,35 @@ RSpec.describe Reek::Report::CodeClimateFormatter, '#render' do
                       source:         'a/ruby/source/file.rb')
   end
   let(:rendered) { Reek::Report::CodeClimateFormatter.new(warning).render }
+  let(:json) { JSON.parse rendered.chop }
 
   it "sets the type as 'issue'" do
-    expect(rendered).to match(/\"type\":\"issue\"/)
+    expect(json['type']).to eq 'issue'
   end
 
   it 'sets the category' do
-    expect(rendered).to match(/\"categories\":\[\"Complexity\"\]/)
+    expect(json['categories']).to eq ['Complexity']
   end
 
   it 'constructs a description based on the context and message' do
-    expect(rendered).to match(/\"description\":\"context foo message bar\"/)
+    expect(json['description']).to eq 'context foo message bar'
   end
 
   it 'sets a check name based on the smell detector' do
-    expect(rendered).to match(/\"check_name\":\"UtilityFunction\"/)
+    expect(json['check_name']).to eq 'UtilityFunction'
   end
 
   it 'sets the location' do
-    expect(rendered).to match(%r{\"location\":{\"path\":\"a/ruby/source/file.rb\",\"lines\":{\"begin\":1,\"end\":2}}})
+    expect(json['location']).to eq('path' => 'a/ruby/source/file.rb',
+                                   'lines' => { 'begin' => 1, 'end' => 2 })
   end
 
   it 'sets a content based on the smell detector' do
-    expect(rendered).to match(
-      /\"body\":\"A _Utility Function_ is any instance method that has no dependency on the state of the instance.\\n\"/
-    )
+    expect(json['content']['body']).
+      to eq "A _Utility Function_ is any instance method that has no dependency on the state of the instance.\n"
   end
 
   it 'sets remediation points based on the smell detector' do
-    expect(rendered).to match(/\"remediation_points\":250000/)
+    expect(json['remediation_points']).to eq 250_000
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.1.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb