reek 4.0.5 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ed3e33db32a0d7b3de163a1ac8d9f042d0123e00
-  data.tar.gz: 6316cc39b5ed860bbca0b4f47aca9f3547709eca
+  metadata.gz: fb4b9a8e91de50f96e7fc83d96e72f92af778dfc
+  data.tar.gz: f33a99fd21ffa8d82eb48d4e1cde69a0a01e0468
 SHA512:
-  metadata.gz: 5f81127feca9c714604fdb3e80cdb1a83e071359e953f902de08295b14ebf6942f345613b1f6b9b90e259364aa194a1704038c8a8e1f03c4beabab51b7e0319e
-  data.tar.gz: bbbbe01a9d539dd9b50a1c883fdbbe519d2258abedaaa16e59cb481a7576048be7743163f8bad3cabc867a9b4fb8353e07220e29b6cbae7f82f6cdf403fe3722
+  metadata.gz: 82da2cb804ea9c2fe37665072c0666350c7a22ba0e857f3629589ca7f91e87a55ee84ae198cd01e06d51e7e00d16b1aabde1b5d7f3cd59523435118e6692d954
+  data.tar.gz: 5177823be762c3c3354144a57abee5c1fea661d2ed9f947e63233a16de0aeae3dd8ac443bd3beb17cb7f3d22ac1d0d12f106a8e8eab568a934b878d8bf550cdd

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 4.1.0 (2016-06-23)
+
+* (waldyr) Add SubclassedFromCoreClass detector
+
 ## 4.0.5 (2016-06-16)
 
 * (mvz) Handle new lambda syntax in NestedIterators

data/README.md

@@ -440,11 +440,34 @@ Or just run the whole test suite:
 bundle exec rake
 ```
 
+This will run the tests (RSpec and Cucumber), RuboCop and Reek itself.
+
+You can also run:
+
+```
+bundle exec rake ci
+```
+
+This will run everything the default task runs and also [Ataru](https://github.com/CodePadawans/ataru) and [Mutant](https://github.com/mbj/mutant). This is the task that we run on Travis as well and that determines if your pull request is green or red.
+
+Another useful Rake task is the `console` task. This will throw you right into an environment where you can play around with Reeks modules and classes:
+
+```
+bundle exec rake console
+
+[3] pry(main)> require_relative 'lib/reek/examiner'
+=> true
+[4] pry(main)> Reek::Examiner
+=> Reek::Examiner
+```
+
+Have a look at our [Developer API](docs/API.md) for more inspiration.
+
 From then on you should check out:
+
 * [How Reek works internally](docs/How-reek-works-internally.md)
 * [the contributing guide](CONTRIBUTING.md)
 
-
 If you don't feel like getting your hands dirty with code there are still other ways you can help us:
 
 * Open up an [issue](https://github.com/troessner/reek/issues) and report bugs

data/defaults.reek

@@ -57,6 +57,9 @@ RepeatedConditional:
   enabled: true
   exclude: []
   max_ifs: 2
+SubclassedFromCoreClass:
+  enabled: true
+  exclude: []
 TooManyInstanceVariables:
   enabled: true
   exclude: []

data/docs/Subclassed-From-Core-Class.md

@@ -0,0 +1,79 @@
+# Subclassed From Core Class
+
+## Introduction
+
+Candidate classes for the _Subclassed From Core Class_ smell are classes which inherit from Core Classes like Hash, String and Array.
+
+Inheriting from Core Classes means that you are going to have a bad time debugging (the explanation below is taken from [here](http://words.steveklabnik.com/beware-subclassing-ruby-core-classes)):
+
+> What do you think this code should do?
+
+```Ruby
+List = Class.new(Array)
+
+l = List.new
+l << 1
+l << 2
+puts l.reverse.class # => Array
+```
+
+> If you said “it prints Array” you’d be right.
+> Let’s talk about a more pernicious issue: Strings.
+
+```Ruby
+class MyString < String
+  def to_s
+    "lol"
+  end
+end
+
+s = MyString.new
+s.concat "Hey"
+
+puts s      # => Hey
+puts s.to_s # => lol
+puts "#{s}" # => Hey
+```
+
+> That’s right! With Strings, Ruby doesn’t call #to_s: it puts the value in directly.
+> Generally speaking, subclassing isn’t the right idea here.
+
+## Example
+
+Given
+
+```Ruby
+class Ary < Array
+end
+
+class Str < String
+end
+```
+
+Reek would report the _Subclassed From Core Class_ smell for both classes. Instead of subclassing them you want a data structure that uses one of these core classes internally, but isn’t exactly like one. For instance:
+
+```Ruby
+require 'forwardable'
+
+class List
+  extend Forwardable
+  def_delegators :@list, :<<, :length # and anything else
+
+  def initialize(list = [])
+    @list = list
+  end
+
+  def reverse
+    List.new(@list.reverse)
+  end
+end
+
+l = List.new 
+l << 1
+l << 2
+puts l.reverse.class  # => List
+```
+
+## Configuration
+
+_Subclassed From Core Class_ offers the [Basic Smell Options](Basic-Smell-Options.md).

data/features/samples.feature

@@ -59,7 +59,7 @@ Feature: Basic smell detection
       UncommunicativeVariableName: Inline::C#module_name has the variable name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       UncommunicativeVariableName: Inline::C#parse_signature has the variable name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       UtilityFunction: Inline::C#strip_comments doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
-    optparse.rb -- 117 warnings:
+    optparse.rb -- 119 warnings:
       Attribute: OptionParser#banner is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: OptionParser#default_argv is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: OptionParser#program_name is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
@@ -129,6 +129,8 @@ Feature: Basic smell detection
       RepeatedConditional: OptionParser tests default_pattern at least 7 times [https://github.com/troessner/reek/blob/master/docs/Repeated-Conditional.md]
       RepeatedConditional: OptionParser tests not_style at least 3 times [https://github.com/troessner/reek/blob/master/docs/Repeated-Conditional.md]
       RepeatedConditional: OptionParser tests s at least 7 times [https://github.com/troessner/reek/blob/master/docs/Repeated-Conditional.md]
+      SubclassedFromCoreClass: OptionParser::CompletingHash inherits from a core class (Hash) [https://github.com/troessner/reek/blob/master/docs/Subclassed-From-Core-Class.md]
+      SubclassedFromCoreClass: OptionParser::OptionMap inherits from a core class (Hash) [https://github.com/troessner/reek/blob/master/docs/Subclassed-From-Core-Class.md]
       TooManyInstanceVariables: OptionParser has at least 6 instance variables [https://github.com/troessner/reek/blob/master/docs/Too-Many-Instance-Variables.md]
       TooManyInstanceVariables: OptionParser::Switch has at least 7 instance variables [https://github.com/troessner/reek/blob/master/docs/Too-Many-Instance-Variables.md]
       TooManyMethods: OptionParser has at least 42 methods [https://github.com/troessner/reek/blob/master/docs/Too-Many-Methods.md]
@@ -177,7 +179,7 @@ Feature: Basic smell detection
       UnusedParameters: OptionParser::Completion#convert has unused parameter 'opt' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: OptionParser::Switch::NoArgument#parse has unused parameter 'argv' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: OptionParser::Switch::OptionalArgument#parse has unused parameter 'argv' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-    redcloth.rb -- 102 warnings:
+    redcloth.rb -- 103 warnings:
       Attribute: RedCloth#filter_html is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: RedCloth#filter_styles is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: RedCloth#hard_breaks is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
@@ -226,6 +228,7 @@ Feature: Basic smell detection
       RepeatedConditional: RedCloth tests codepre.zero? at least 3 times [https://github.com/troessner/reek/blob/master/docs/Repeated-Conditional.md]
       RepeatedConditional: RedCloth tests href at least 3 times [https://github.com/troessner/reek/blob/master/docs/Repeated-Conditional.md]
       RepeatedConditional: RedCloth tests title at least 4 times [https://github.com/troessner/reek/blob/master/docs/Repeated-Conditional.md]
+      SubclassedFromCoreClass: RedCloth inherits from a core class (String) [https://github.com/troessner/reek/blob/master/docs/Subclassed-From-Core-Class.md]
       TooManyMethods: RedCloth has at least 44 methods [https://github.com/troessner/reek/blob/master/docs/Too-Many-Methods.md]
       TooManyStatements: RedCloth#block_markdown_bq has approx 6 statements [https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md]
       TooManyStatements: RedCloth#block_textile_lists has approx 21 statements [https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md]
@@ -280,5 +283,5 @@ Feature: Basic smell detection
       UtilityFunction: RedCloth#lT doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#no_textile doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#v_align doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
-    266 total warnings
+    269 total warnings
     """

data/features/smells/subclassed_from_core_class.feature

@@ -0,0 +1,14 @@
+Feature: Smell - SubclassedFromCoreClass
+  Scenario: Reports smell
+    Given a file named "my_hash.rb" with:
+      """
+      # The MyHash class
+      class MyHash < Hash
+      end
+      """
+    When I run `reek my_hash.rb`
+    Then it reports:
+    """
+    my_hash.rb -- 1 warning:
+      [2]:SubclassedFromCoreClass: MyHash inherits from a core class (Hash) [https://github.com/troessner/reek/blob/master/docs/Subclassed-From-Core-Class.md]
+    """

data/lib/reek/ast/sexp_extensions/constant.rb

@@ -5,7 +5,6 @@ module Reek
       # Utility methods for :const nodes.
       module ConstNode
         def name
-          namespace = children.first
           if namespace
             "#{namespace.format_to_ruby}::#{simple_name}"
           else
@@ -16,6 +15,10 @@ module Reek
         def simple_name
           children.last
         end
+
+        def namespace
+          children.first
+        end
       end
     end
   end

data/lib/reek/ast/sexp_extensions/module.rb

@@ -45,6 +45,7 @@ module Reek
       # Utility methods for :class nodes.
       module ClassNode
         include ModuleNodeBase
+
         def superclass() children[1] end
       end
 
@@ -53,16 +54,71 @@ module Reek
         include ModuleNodeBase
 
         def defines_module?
-          return false unless value
-          call = case value.type
-                 when :block
-                   value.call
-                 when :send
-                   value
-                 end
+          call = constant_definition
           call && call.module_creation_call?
         end
 
+        # This is the right hand side of a constant
+        # assignment.
+        #
+        # This can be simple:
+        #
+        # Foo = 23
+        #
+        # s(:casgn, nil, :Foo,
+        #   s(:int, 23))
+        #
+        # In this cases we do not care and return nil.
+        #
+        # Or complicated:
+        #
+        # Iterator = Struct.new :exp do ... end
+        #
+        # s(:casgn, nil, :Iterator,
+        #   s(:block,
+        #     s(:send,
+        #       s(:const, nil, :Struct), :new,
+        #       s(:sym, :exp)
+        #     ),
+        #     s(:args),
+        #     ...
+        #   )
+        # )
+        #
+        # In this cases we return the Struct.new part
+        #
+        def constant_definition
+          return nil unless value
+
+          case value.type
+          when :block
+            value.call
+          when :send
+            value
+          end
+        end
+
+        # Sometimes we assign classes like:
+        #
+        # Foo = Class.new(Bar)
+        #
+        # This is mapped into the following expression:
+        #
+        # s(:casgn, nil :Foo,
+        #   s(:send,
+        #     s(:const, nil, :Class), :new,
+        #     s(:const, nil, :Bar)
+        #   )
+        # )
+        #
+        # And we are only looking for s(:const, nil, :Bar)
+        #
+        def superclass
+          return nil unless constant_definition
+
+          constant_definition.args.first
+        end
+
         def name
           children[1].to_s
         end

data/lib/reek/report/code_climate/code_climate_configuration.yml

@@ -662,3 +662,14 @@ UtilityFunction:
   remediation_points: 250_000
   content: |
     A _Utility Function_ is any instance method that has no dependency on the state of the instance.
+SubclassedFromCoreClass:
+  remediation_points: 250_000
+  content: |
+    Subclassing core classes in Ruby can lead to unexpected side effects.
+
+    Knowing that Ruby has a core library, which is written in C,
+    and a standard library, which is written in Ruby,
+    if you do not know exactly how these core classes operate at the C level,
+    you are gonna have a bad time.
+
+    Source: http://words.steveklabnik.com/beware-subclassing-ruby-core-classes

data/lib/reek/smells.rb

@@ -14,6 +14,7 @@ require_relative 'smells/nested_iterators'
 require_relative 'smells/nil_check'
 require_relative 'smells/prima_donna_method'
 require_relative 'smells/repeated_conditional'
+require_relative 'smells/subclassed_from_core_class'
 require_relative 'smells/too_many_instance_variables'
 require_relative 'smells/too_many_methods'
 require_relative 'smells/too_many_statements'

data/lib/reek/smells/subclassed_from_core_class.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+require_relative 'smell_detector'
+require_relative 'smell_warning'
+
+module Reek
+  module Smells
+    #
+    # Subclassing core classes in Ruby can lead to unexpected side effects.
+    # Knowing that Ruby has a core library, which is written in C, and a standard
+    # library, which is written in Ruby, if you do not know exactly how these core
+    # classes operate at the C level, you are gonna have a bad time.
+    #
+    # Source: http://words.steveklabnik.com/beware-subclassing-ruby-core-classes
+    #
+    class SubclassedFromCoreClass < SmellDetector
+      CORE_CLASSES = ['Array', 'Hash', 'String'].freeze
+
+      def self.contexts
+        [:class, :casgn]
+      end
+
+      # Checks +ctx+ for either expressions:
+      #
+      # Foo = Class.new(Bar)
+      #
+      # class Foo < Bar; end;
+      #
+      # @return [Array<SmellWarning>]
+      def inspect(ctx)
+        superclass = ctx.exp.superclass
+
+        return [] unless superclass
+
+        inspect_superclass(ctx, superclass.name)
+      end
+
+      private
+
+      def inspect_superclass(ctx, superclass_name)
+        return [] unless CORE_CLASSES.include?(superclass_name)
+
+        [build_smell_warning(ctx, superclass_name)]
+      end
+
+      def build_smell_warning(ctx, ancestor_name)
+        smell_attributes = {
+          context: ctx,
+          lines: [ctx.exp.line],
+          message: "inherits from a core class (#{ancestor_name})",
+          parameters: { ancestor: ancestor_name }
+        }
+
+        smell_warning(smell_attributes)
+      end
+    end
+  end
+end

data/lib/reek/version.rb

@@ -7,6 +7,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '4.0.5'.freeze
+    STRING = '4.1.0'.freeze
   end
 end

data/spec/reek/ast/sexp_extensions_spec.rb

@@ -240,6 +240,44 @@ RSpec.describe Reek::AST::SexpExtensions::LvarNode do
   end
 end
 
+RSpec.describe Reek::AST::SexpExtensions::ConstNode do
+  describe '#name' do
+    it 'returns the fully qualified name' do
+      node = sexp(:const, sexp(:const, sexp(:cbase), :Parser), :AST)
+
+      expect(node.name).to eq "#{sexp(:const, sexp(:cbase), :Parser)}::AST"
+    end
+
+    it 'returns only the name in case of no namespace' do
+      node = sexp(:const, nil, :AST)
+
+      expect(node.name).to eq 'AST'
+    end
+  end
+
+  describe '#simple_name' do
+    it 'returns the name' do
+      node = sexp(:const, sexp(:const, nil, :Rake), :TaskLib)
+
+      expect(node.simple_name).to eq :TaskLib
+    end
+  end
+
+  describe '#namespace' do
+    it 'returns the namespace' do
+      node = sexp(:const, :Parser, :AST)
+
+      expect(node.namespace).to eq :Parser
+    end
+
+    it 'returns nil in case of no namespace' do
+      node = sexp(:const, nil, :AST)
+
+      expect(node.namespace).to be_nil
+    end
+  end
+end
+
 RSpec.describe Reek::AST::SexpExtensions::SendNode do
   context 'with no parameters' do
     let(:node) { sexp(:send, nil, :hello) }
@@ -403,20 +441,78 @@ RSpec.describe Reek::AST::SexpExtensions::ModuleNode do
 end
 
 RSpec.describe Reek::AST::SexpExtensions::CasgnNode do
-  context 'with single assignment' do
-    subject do
-      sexp(:casgn, nil, :Foo)
+  context '#defines_module' do
+    context 'with single assignment' do
+      subject do
+        sexp(:casgn, nil, :Foo)
+      end
+
+      it 'does not define a module' do
+        expect(subject.defines_module?).to be_falsey
+      end
     end
 
-    it 'does not define a module' do
-      expect(subject.defines_module?).to be_falsey
+    context 'with implicit receiver to new' do
+      it 'does not define a module' do
+        exp = sexp(:casgn, nil, :Foo, sexp(:send, nil, :new))
+        expect(exp.defines_module?).to be_falsey
+      end
+    end
+
+    context 'with implicit receiver to new' do
+      it 'does not define a module' do
+        exp = Reek::Source::SourceCode.from('Foo = Class.new(Bar)').syntax_tree
+
+        expect(exp.defines_module?).to be_truthy
+      end
     end
   end
 
-  context 'with implicit receiver to new' do
-    it 'does not define a module' do
-      exp = sexp(:casgn, nil, :Foo, sexp(:send, nil, :new))
-      expect(exp.defines_module?).to be_falsey
+  context '#superclass' do
+    it 'returns the superclass from the class definition' do
+      exp = Reek::Source::SourceCode.from('Foo = Class.new(Bar)').syntax_tree
+
+      expect(exp.superclass).to eq sexp(:const, nil, :Bar)
+    end
+
+    it 'returns nil in case of no class definition' do
+      exp = Reek::Source::SourceCode.from('Foo = 23').syntax_tree
+
+      expect(exp.superclass).to be_nil
+    end
+
+    it 'returns nil in case of no superclass' do
+      exp = Reek::Source::SourceCode.from('Foo = Class.new').syntax_tree
+
+      expect(exp.superclass).to be_nil
+    end
+  end
+
+  context '#constant_definition' do
+    context 'simple constant assignment' do
+      it 'is not important' do
+        exp = sexp(:casgn, nil, :Foo, sexp(:int, 23))
+
+        expect(exp.constant_definition).to be_nil
+      end
+    end
+
+    context 'complicated constant assignments' do
+      it 'calls the block and returns what is being sent' do
+        exp = Reek::Source::SourceCode.from('Iterator = Struct.new(:exp) { def p; end; }').syntax_tree
+
+        struct_exp = sexp(:send, sexp(:const, nil, :Struct), :new, sexp(:sym, :exp))
+
+        expect(exp.constant_definition).to eq struct_exp
+      end
+
+      it 'returns the expression responsible for class creation' do
+        exp = Reek::Source::SourceCode.from('Foo = Class.new(Bar)').syntax_tree
+
+        class_exp = sexp(:send, sexp(:const, nil, :Class), :new, sexp(:const, nil, :Bar))
+
+        expect(exp.constant_definition).to eq class_exp
+      end
     end
   end
 end

data/spec/reek/smells/subclassed_from_core_class_spec.rb

@@ -0,0 +1,135 @@
+require_relative '../../spec_helper'
+require_lib 'reek/smells/subclassed_from_core_class'
+require_relative 'smell_detector_shared'
+
+RSpec.describe Reek::Smells::SubclassedFromCoreClass do
+  let(:detector) { described_class.new }
+
+  it_should_behave_like 'SmellDetector'
+
+  context 'report' do
+    context 'smell line' do
+      context 'single class' do
+        it 'should report the core class in the message' do
+          src = <<-EOS
+            class Dummy < Hash
+            end
+          EOS
+
+          expect(src).to reek_of(:SubclassedFromCoreClass, lines: [1])
+        end
+      end
+
+      context 'class inside a module' do
+        it 'should report the core class in the message' do
+          src = <<-EOS
+            module Namespace
+              class Dummy < Hash
+              end
+            end
+          EOS
+
+          expect(src).to reek_of(:SubclassedFromCoreClass, lines: [2])
+        end
+      end
+    end
+
+    context 'smell message' do
+      context 'Array' do
+        it 'should report the core class in the message' do
+          src = <<-EOS
+            class Dummy < Array
+            end
+          EOS
+
+          expect(src).to reek_of(:SubclassedFromCoreClass, message: 'inherits from a core class (Array)')
+        end
+      end
+
+      context 'Hash' do
+        it 'should report the core class in the message' do
+          src = <<-EOS
+            class Dummy < Hash
+            end
+          EOS
+
+          expect(src).to reek_of(:SubclassedFromCoreClass, message: 'inherits from a core class (Hash)')
+        end
+      end
+    end
+  end
+
+  it 'does not inherit from a core class' do
+    src = <<-EOS
+      class Dummy
+      end
+    EOS
+
+    expect(src).to_not reek_of(:SubclassedFromCoreClass)
+  end
+
+  it 'should report if we inherit from a core class' do
+    src = <<-EOS
+      class Dummy < Array
+      end
+    EOS
+
+    expect(src).to reek_of(:SubclassedFromCoreClass, ancestor: 'Array', message: 'inherits from a core class (Array)')
+  end
+
+  it 'should not report on coincidental core class names in other namespaces' do
+    src = <<-EOS
+      class Dummy < My::Array
+      end
+    EOS
+    expect(src).to_not reek_of(:SubclassedFromCoreClass)
+  end
+
+  it 'should report if we inherit from a core class from within a namespaced class' do
+    src = <<-EOS
+      module Namespace
+        class Dummy < Array
+        end
+      end
+    EOS
+    expect(src).to reek_of(:SubclassedFromCoreClass, ancestor: 'Array')
+  end
+
+  it 'should report if we inherit from a core class using Class#new' do
+    src = 'Dummy = Class.new(Array)'
+    expect(src).to reek_of(:SubclassedFromCoreClass, ancestor: 'Array')
+  end
+
+  it 'should report if inner class inherit from a core class' do
+    src = <<-EOS
+      module Namespace
+        class Dummy
+          Dummiest = Class.new(Array)
+        end
+      end
+    EOS
+    expect(src).to reek_of(:SubclassedFromCoreClass, ancestor: 'Array')
+  end
+
+  it 'should not report on coincidental core class names in other namespaces' do
+    src = <<-EOS
+      module Namespace
+        class Dummy
+          Dummiest = Class.new(My::Array)
+        end
+      end
+    EOS
+    expect(src).to_not reek_of(:SubclassedFromCoreClass, ancestor: 'Array')
+  end
+
+  it 'should not report if inner class inherits from allowed classes' do
+    src = <<-EOS
+      module Namespace
+        class Dummy
+          Dummiest = Class.new(StandardError)
+        end
+      end
+    EOS
+    expect(src).to_not reek_of(:SubclassedFromCoreClass, ancestor: 'StandardError')
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.0.5
+  version: 4.1.0
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-16 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb
@@ -118,6 +118,7 @@ files:
 - docs/Repeated-Conditional.md
 - docs/Simulated-Polymorphism.md
 - docs/Smell-Suppression.md
+- docs/Subclassed-From-Core-Class.md
 - docs/Too-Many-Instance-Variables.md
 - docs/Too-Many-Methods.md
 - docs/Too-Many-Statements.md
@@ -156,6 +157,7 @@ files:
 - features/reports/reports.feature
 - features/reports/yaml.feature
 - features/samples.feature
+- features/smells/subclassed_from_core_class.feature
 - features/step_definitions/.rubocop.yml
 - features/step_definitions/reek_steps.rb
 - features/step_definitions/sample_file_steps.rb
@@ -243,6 +245,7 @@ files:
 - lib/reek/smells/smell_detector.rb
 - lib/reek/smells/smell_repository.rb
 - lib/reek/smells/smell_warning.rb
+- lib/reek/smells/subclassed_from_core_class.rb
 - lib/reek/smells/too_many_instance_variables.rb
 - lib/reek/smells/too_many_methods.rb
 - lib/reek/smells/too_many_statements.rb
@@ -322,6 +325,7 @@ files:
 - spec/reek/smells/smell_detector_spec.rb
 - spec/reek/smells/smell_repository_spec.rb
 - spec/reek/smells/smell_warning_spec.rb
+- spec/reek/smells/subclassed_from_core_class_spec.rb
 - spec/reek/smells/too_many_instance_variables_spec.rb
 - spec/reek/smells/too_many_methods_spec.rb
 - spec/reek/smells/too_many_statements_spec.rb