reek 4.0.1 → 4.0.2

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.0.2
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-10 00:00:00.000000000 Z
+date: 2016-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb
@@ -190,8 +190,6 @@ files:
 - lib/reek/cli/command/base_command.rb
 - lib/reek/cli/command/report_command.rb
 - lib/reek/cli/command/todo_list_command.rb
-- lib/reek/cli/input.rb
-- lib/reek/cli/option_interpreter.rb
 - lib/reek/cli/options.rb
 - lib/reek/cli/silencer.rb
 - lib/reek/cli/warning_collector.rb
@@ -280,8 +278,6 @@ files:
 - spec/reek/cli/application_spec.rb
 - spec/reek/cli/command/report_command_spec.rb
 - spec/reek/cli/command/todo_list_command_spec.rb
-- spec/reek/cli/input_spec.rb
-- spec/reek/cli/option_interpreter_spec.rb
 - spec/reek/cli/options_spec.rb
 - spec/reek/cli/warning_collector_spec.rb
 - spec/reek/code_comment_spec.rb

data/lib/reek/cli/input.rb

@@ -1,49 +0,0 @@
-# frozen_string_literal: true
-require_relative '../source/source_locator'
-
-module Reek
-  module CLI
-    #
-    # CLI Input utility
-    #
-    module Input
-      def sources
-        if no_source_files_given?
-          if input_was_piped?
-            source_from_pipe
-          else
-            working_directory_as_source
-          end
-        else
-          sources_from_argv
-        end
-      end
-
-      private
-
-      # :reek:UtilityFunction
-      def input_was_piped?
-        !$stdin.tty?
-      end
-
-      def no_source_files_given?
-        # At this point we have deleted all options from argv. The only remaining entries
-        # are paths to the source files. If argv is empty, this means that no files were given.
-        argv.empty?
-      end
-
-      # :reek:UtilityFunction
-      def working_directory_as_source
-        Source::SourceLocator.new(['.'], configuration: configuration).sources
-      end
-
-      def sources_from_argv
-        Source::SourceLocator.new(argv).sources
-      end
-
-      def source_from_pipe
-        [$stdin]
-      end
-    end
-  end
-end

data/lib/reek/cli/option_interpreter.rb

@@ -1,58 +0,0 @@
-# frozen_string_literal: true
-require 'forwardable'
-require_relative 'input'
-require_relative '../report'
-
-module Reek
-  module CLI
-    #
-    # Interprets the options set from the command line
-    #
-    class OptionInterpreter
-      extend Forwardable
-      def_delegators :options, :smells_to_detect, :success_exit_code, :failure_exit_code
-
-      def initialize(options)
-        @options = options
-        @argv = options.argv
-      end
-
-      def reporter
-        @reporter ||=
-          report_class.new(
-            warning_formatter: warning_formatter,
-            report_formatter: Report::Formatter,
-            sort_by_issue_count: sort_by_issue_count,
-            heading_formatter: heading_formatter)
-      end
-
-      def report_class
-        Report.report_class(options.report_format)
-      end
-
-      def warning_formatter
-        warning_formatter_class.new(location_formatter: location_formatter)
-      end
-
-      def warning_formatter_class
-        Report.warning_formatter_class(options.show_links ? :wiki_links : :simple)
-      end
-
-      def location_formatter
-        Report.location_formatter(options.location_format)
-      end
-
-      def heading_formatter
-        Report.heading_formatter(options.show_empty ? :verbose : :quiet)
-      end
-
-      def sort_by_issue_count
-        options.sorting == :smelliness
-      end
-
-      private
-
-      attr_reader :argv, :options
-    end
-  end
-end

data/spec/reek/cli/input_spec.rb

@@ -1,71 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/cli/input'
-
-RSpec.describe Reek::CLI::Input do
-  # dummy class which includes module under test
-  class DummyClass
-    include Reek::CLI::Input
-
-    def argv; end
-
-    def configuration; end
-  end
-
-  let(:path_excluded_in_configuration) do
-    SAMPLES_PATH.join('source_with_exclude_paths/ignore_me/uncommunicative_method_name.rb')
-  end
-
-  let(:configuration) { test_configuration_for(SAMPLES_PATH.join('configuration/with_excluded_paths.reek')) }
-
-  subject { DummyClass.new }
-
-  before do
-    allow(subject).to receive(:configuration).and_return(configuration)
-  end
-
-  describe '#sources' do
-    context 'when no source files given' do
-      before do
-        allow(subject).to receive(:argv).and_return([])
-      end
-
-      context 'and input was piped' do
-        before do
-          allow_any_instance_of(IO).to receive(:tty?).and_return(false)
-          expect(subject).to receive(:source_from_pipe).and_call_original
-        end
-
-        it 'should use source form pipe' do
-          expect(subject.sources).to_not be_empty
-        end
-      end
-
-      context 'and input was not piped' do
-        before do
-          allow_any_instance_of(IO).to receive(:tty?).and_return(true)
-          expect(subject).to receive(:working_directory_as_source).
-            and_call_original
-        end
-
-        it 'should use working directory as source' do
-          expect(subject.sources).to_not be_empty
-        end
-
-        it 'should use configuration for excluded paths' do
-          expect(subject.sources).to_not include(path_excluded_in_configuration)
-        end
-      end
-    end
-
-    context 'when source files given' do
-      before do
-        allow(subject).to receive(:argv).and_return(['.'])
-        expect(subject).to receive(:sources_from_argv).and_call_original
-      end
-
-      it 'should use sources from argv' do
-        expect(subject.sources).to_not be_empty
-      end
-    end
-  end
-end

data/spec/reek/cli/option_interpreter_spec.rb

@@ -1,20 +0,0 @@
-require_relative '../../spec_helper'
-
-require_lib 'reek/cli/options'
-require_lib 'reek/cli/option_interpreter'
-require_lib 'reek/report/report'
-
-RSpec.describe Reek::CLI::OptionInterpreter do
-  describe '#reporter' do
-    context 'with a valid set of options' do
-      let(:options) do
-        Reek::CLI::Options.new.parse
-      end
-      subject { described_class.new(options) }
-
-      it 'returns an object of the correct subclass of Report::Base' do
-        expect(subject.reporter).to be_instance_of Reek::Report::TextReport
-      end
-    end
-  end
-end