reek 3.8.3 → 3.9.0

data/spec/reek/smells/duplicate_method_call_spec.rb

@@ -47,7 +47,7 @@ RSpec.describe Reek::Smells::DuplicateMethodCall do
 
     it 'reports call parameters' do
       src = 'def double_thing() @other.thing(2,3) + @other.thing(2,3) end'
-      expect(src).to reek_of(:DuplicateMethodCall, name: '@other.thing(2, 3)')
+      expect(src).to reek_of(:DuplicateMethodCall, name: '@other.thing(2,3)')
     end
 
     it 'should report nested calls' do

data/spec/reek/tree_dresser_spec.rb

@@ -34,7 +34,6 @@ RSpec.describe Reek::TreeDresser do
 
     it 'dresses `def` nodes properly' do
       expect(def_node).to be_a Reek::AST::SexpExtensions::DefNode
-      expect(def_node).to be_a Reek::AST::SexpExtensions::SingletonMethod
       expect(def_node).to be_a Reek::AST::SexpExtensions::MethodNodeBase
     end
 

data/spec/samples/checkstyle.xml

@@ -3,8 +3,8 @@
   <file name='spec/samples/two_smelly_files/dirty_one.rb'>
     <error column='0' line='4' message='calls @s.title 2 times' severity='warning' source='DuplicateMethodCall'/>
     <error column='0' line='6' message='calls @s.title 2 times' severity='warning' source='DuplicateMethodCall'/>
-    <error column='0' line='4' message='calls puts(@s.title) 2 times' severity='warning' source='DuplicateMethodCall'/>
-    <error column='0' line='6' message='calls puts(@s.title) 2 times' severity='warning' source='DuplicateMethodCall'/>
+    <error column='0' line='4' message='calls puts @s.title 2 times' severity='warning' source='DuplicateMethodCall'/>
+    <error column='0' line='6' message='calls puts @s.title 2 times' severity='warning' source='DuplicateMethodCall'/>
     <error column='0' line='5' message='contains iterators nested 2 deep' severity='warning' source='NestedIterators'/>
     <error column='0' line='3' message='has the name &apos;a&apos;' severity='warning' source='UncommunicativeMethodName'/>
     <error column='0' line='5' message='has the variable name &apos;@s&apos;' severity='warning' source='UncommunicativeVariableName'/>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 3.8.3
+  version: 3.9.0
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-15 00:00:00.000000000 Z
+date: 2016-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-engine-rb
@@ -33,20 +33,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.2.2.5
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.2.2.5
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: private_attr
   requirement: !ruby/object:Gem::Requirement
@@ -75,146 +69,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: unparser
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.2.2
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.2.2
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
-- !ruby/object:Gem::Dependency
-  name: aruba
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.10.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.10.0
-- !ruby/object:Gem::Dependency
-  name: ataru
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.2.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.2.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-- !ruby/object:Gem::Dependency
-  name: cucumber
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: factory_girl
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.34.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.34.0
 description: |2
       Reek is a tool that examines Ruby classes, modules and methods and reports
       any code smells it finds.
@@ -320,13 +174,13 @@ files:
 - lib/reek/ast/sexp_extensions/methods.rb
 - lib/reek/ast/sexp_extensions/module.rb
 - lib/reek/ast/sexp_extensions/nested_assignables.rb
+- lib/reek/ast/sexp_extensions/self.rb
 - lib/reek/ast/sexp_extensions/send.rb
 - lib/reek/ast/sexp_extensions/super.rb
 - lib/reek/ast/sexp_extensions/symbols.rb
 - lib/reek/ast/sexp_extensions/variables.rb
 - lib/reek/ast/sexp_extensions/when.rb
 - lib/reek/ast/sexp_extensions/yield.rb
-- lib/reek/ast/sexp_formatter.rb
 - lib/reek/cli/application.rb
 - lib/reek/cli/command.rb
 - lib/reek/cli/input.rb
@@ -345,10 +199,12 @@ files:
 - lib/reek/context/attribute_context.rb
 - lib/reek/context/class_context.rb
 - lib/reek/context/code_context.rb
+- lib/reek/context/ghost_context.rb
 - lib/reek/context/method_context.rb
 - lib/reek/context/module_context.rb
 - lib/reek/context/root_context.rb
 - lib/reek/context/send_context.rb
+- lib/reek/context/singleton_attribute_context.rb
 - lib/reek/context/singleton_method_context.rb
 - lib/reek/context/statement_counter.rb
 - lib/reek/context/visibility_tracker.rb
@@ -414,7 +270,6 @@ files:
 - spec/reek/ast/object_refs_spec.rb
 - spec/reek/ast/reference_collector_spec.rb
 - spec/reek/ast/sexp_extensions_spec.rb
-- spec/reek/ast/sexp_formatter_spec.rb
 - spec/reek/cli/input_spec.rb
 - spec/reek/cli/option_interpreter_spec.rb
 - spec/reek/cli/options_spec.rb
@@ -426,6 +281,7 @@ files:
 - spec/reek/configuration/directory_directives_spec.rb
 - spec/reek/configuration/excluded_paths_spec.rb
 - spec/reek/context/code_context_spec.rb
+- spec/reek/context/ghost_context_spec.rb
 - spec/reek/context/method_context_spec.rb
 - spec/reek/context/module_context_spec.rb
 - spec/reek/context/root_context_spec.rb

data/lib/reek/ast/sexp_formatter.rb

@@ -1,31 +0,0 @@
-require_relative '../cli/silencer'
-
-Reek::CLI::Silencer.silently do
-  require 'unparser'
-end
-
-module Reek
-  module AST
-    #
-    # Formats snippets of syntax tree back into Ruby source code.
-    #
-    class SexpFormatter
-      # Formats the given sexp.
-      #
-      # @param [AST::Node, #to_s] sexp - The expression to format
-      #
-      # @return [String] a formatted string representation.
-      #
-      # :reek:DuplicateMethodCall { max_calls: 2 } is ok for lines.first
-      def self.format(sexp)
-        return sexp.to_s unless sexp.is_a? ::Parser::AST::Node
-        lines = Unparser.unparse(sexp).split "\n"
-        case lines.length
-        when 1 then lines.first
-        when 2 then lines.join('; ')
-        else [lines.first, lines.last].join(' ... ')
-        end
-      end
-    end
-  end
-end

data/spec/reek/ast/sexp_formatter_spec.rb

@@ -1,35 +0,0 @@
-require_relative '../../spec_helper'
-require_lib 'reek/ast/sexp_formatter'
-
-RSpec.describe Reek::AST::SexpFormatter do
-  describe '::format' do
-    it 'formats a simple s-expression' do
-      result = described_class.format sexp(:lvar, :foo)
-      expect(result).to eq('foo')
-    end
-
-    it 'formats a more complex s-expression' do
-      ast = sexp(:send, nil, :foo, sexp(:lvar, :bar))
-      result = described_class.format(ast)
-      expect(result).to eq('foo(bar)')
-    end
-
-    it 'reduces very large ASTs to a single line' do
-      ast = sexp(:if,
-                 sexp(:send, nil, :foo),
-                 sexp(:send, nil, :bar),
-                 sexp(:begin,
-                      sexp(:send, nil, :baz),
-                      sexp(:send, nil, :qux)))
-      result = described_class.format ast
-
-      expect(result).to eq 'if foo ... end'
-    end
-
-    it "doesn't reduce two-line ASTs" do
-      ast = sexp(:def, 'my_method', sexp(:args))
-      result = described_class.format ast
-      expect(result).to eq 'def my_method; end'
-    end
-  end
-end