reek 3.8.0 → 3.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f9790efcdbc4208c4183611dd613d3c9e5075583
-  data.tar.gz: 4584bf1720a0ae7b9db6088e2c7e44550ed98fd3
+  metadata.gz: fa22fd6869d0e417b1a06439dfe1708b19681806
+  data.tar.gz: 64206ff481be4eec7b81f104414b8adfe20368c9
 SHA512:
-  metadata.gz: 1822f9ebf7c84992bcd366da12b336f5e48f5082d35e44c2c9ac639501237609a0be36b45907f639e5594ea2ba5afaf8dc7940cae8125609ba5e32ba6bc46e5d
-  data.tar.gz: 9dfe34d1d98f9816fb96504ca843f51e2daedc0912f4732fa5b7a07f36e1fde3a83796341ac157cb1866cbd91f26e9f0dd5dab4d40ac7c5c55d96d1a3c3acdcf
+  metadata.gz: 5d1059a61327c5541cb78cc9d03eb14e09c07ecd282c4231ab84f18afc98aa627b581238e960d23d061b22dd6e18a1cc3b0a0e99c3d9928dc7adecdbd6466eec
+  data.tar.gz: 849705c263f676c58fc845ccfdad492ee807fc28e1f7e20fa6a5fbd6b146aa69325f909bfdf6bf07a063c9a3172e494cbb0390e49c328e765293d32135ccde0e

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 3.8.1 (2015-12-28)
+
+* (troessner) Don't raise on missing directory for directive.
+
 ## 3.8.0 (2015-12-27)
 
 * (troessner) Report unused private instance methods.

data/features/configuration_files/directory_specific_directives.feature

@@ -170,22 +170,6 @@ Feature: Directory directives
     2 total warnings
     """
 
-  Scenario: Abort on non-existent directory
-    Given a file named "config.reek" with:
-      """
-      ---
-      "does/not/exist":
-        NestedIterators:
-          enabled: false
-      """
-    When I run `reek -c config.reek lib/`
-    Then the exit status indicates an error
-    And stderr reports:
-    """
-    Configuration error: Directory `does/not/exist` does not exist
-
-    """
-
   Scenario: Abort on non-existent smell type in directory directive
     Given a file named "config.reek" with:
       """

data/lib/reek/configuration/configuration_validator.rb

@@ -30,22 +30,13 @@ module Reek
         end
       end
 
-      def error_message_for_missing_directory(pathname)
-        "Configuration error: Directory `#{pathname}` does not exist"
-      end
-
       def error_message_for_file_given(pathname)
         "Configuration error: `#{pathname}` is supposed to be a directory but is a file"
       end
 
-      def validate_directory(pathname)
-        abort(error_message_for_missing_directory(pathname)) unless pathname.exist?
-        abort(error_message_for_file_given(pathname)) if pathname.file?
-      end
-
       def with_valid_directory(path)
         directory = Pathname.new path.to_s.chomp('/')
-        validate_directory directory
+        abort(error_message_for_file_given(directory)) if directory.file?
         yield directory if block_given?
       end
     end

data/lib/reek/version.rb

@@ -6,6 +6,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '3.8.0'
+    STRING = '3.8.1'
   end
 end

data/spec/reek/configuration/directory_directives_spec.rb

@@ -30,17 +30,6 @@ RSpec.describe Reek::Configuration::DirectoryDirectives do
     subject do
       {}.extend(described_class)
     end
-    let(:empty_config) { Hash.new }
-
-    context 'one of given paths does not exist' do
-      let(:bogus_path) { Pathname('does/not/exist') }
-
-      it 'raises an error' do
-        Reek::CLI::Silencer.silently do
-          expect { subject.add(bogus_path, {}) }.to raise_error(SystemExit)
-        end
-      end
-    end
 
     context 'one of given paths is a file' do
       let(:file_as_path) { SAMPLES_PATH.join('inline.rb') }

data/spec/reek/configuration/excluded_paths_spec.rb

@@ -5,17 +5,6 @@ RSpec.describe Reek::Configuration::ExcludedPaths do
   describe '#add' do
     subject { [].extend(described_class) }
 
-    context 'one of the given paths does not exist' do
-      let(:bogus_path) { Pathname('does/not/exist') }
-      let(:paths) { [SAMPLES_PATH, bogus_path] }
-
-      it 'raises an error' do
-        Reek::CLI::Silencer.silently do
-          expect { subject.add(paths) }.to raise_error(SystemExit)
-        end
-      end
-    end
-
     context 'one of given paths is a file' do
       let(:file_as_path) { SAMPLES_PATH.join('inline.rb') }
       let(:paths) { [SAMPLES_PATH, file_as_path] }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 3.8.0
+  version: 3.8.1
 platform: ruby
 authors:
 - Kevin Rutherford