reek 3.6.1 → 3.7.0

data/spec/reek/smells/smell_warning_spec.rb

@@ -52,12 +52,12 @@ RSpec.describe Reek::Smells::SmellWarning do
       it_should_behave_like 'first sorts ahead of second'
     end
 
-    context 'message takes precedence over smell name' do
+    context 'smell name takes precedence over message' do
       let(:first) do
-        build(:smell_warning, smell_detector: utility_function_detector, message: 'first message')
+        build(:smell_warning, smell_detector: feature_envy_detector, message: 'second message')
       end
       let(:second) do
-        build(:smell_warning, smell_detector: feature_envy_detector, message: 'second message')
+        build(:smell_warning, smell_detector: utility_function_detector, message: 'first message')
       end
 
       it_should_behave_like 'first sorts ahead of second'
@@ -65,14 +65,6 @@ RSpec.describe Reek::Smells::SmellWarning do
 
     context 'smells differing everywhere' do
       let(:first) do
-        uncommunicative_name_detector = build(:smell_detector,
-                                              smell_type: 'UncommunicativeVariableName')
-        build(:smell_warning, smell_detector: uncommunicative_name_detector,
-                              context: 'Dirty',
-                              message: "has the variable name '@s'")
-      end
-
-      let(:second) do
         duplication_detector = build(:smell_detector,
                                      smell_type: 'DuplicateMethodCall')
         build(:smell_warning, smell_detector: duplication_detector,
@@ -80,6 +72,14 @@ RSpec.describe Reek::Smells::SmellWarning do
                               message: 'calls @s.title twice')
       end
 
+      let(:second) do
+        uncommunicative_name_detector = build(:smell_detector,
+                                              smell_type: 'UncommunicativeVariableName')
+        build(:smell_warning, smell_detector: uncommunicative_name_detector,
+                              context: 'Dirty',
+                              message: "has the variable name '@s'")
+      end
+
       it_should_behave_like 'first sorts ahead of second'
     end
   end

data/spec/samples/checkstyle.xml

@@ -1,13 +1,13 @@
 <?xml version='1.0'?>
 <checkstyle>
   <file name='spec/samples/two_smelly_files/dirty_one.rb'>
-    <error column='0' line='5' message='has the variable name &apos;@s&apos;' severity='warning' source='UncommunicativeVariableName'/>
     <error column='0' line='4' message='calls @s.title 2 times' severity='warning' source='DuplicateMethodCall'/>
     <error column='0' line='6' message='calls @s.title 2 times' severity='warning' source='DuplicateMethodCall'/>
     <error column='0' line='4' message='calls puts(@s.title) 2 times' severity='warning' source='DuplicateMethodCall'/>
     <error column='0' line='6' message='calls puts(@s.title) 2 times' severity='warning' source='DuplicateMethodCall'/>
     <error column='0' line='5' message='contains iterators nested 2 deep' severity='warning' source='NestedIterators'/>
     <error column='0' line='3' message='has the name &apos;a&apos;' severity='warning' source='UncommunicativeMethodName'/>
+    <error column='0' line='5' message='has the variable name &apos;@s&apos;' severity='warning' source='UncommunicativeVariableName'/>
     <error column='0' line='5' message='has the variable name &apos;x&apos;' severity='warning' source='UncommunicativeVariableName'/>
   </file>
 </checkstyle>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 3.6.1
+  version: 3.7.0
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,8 +11,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-13 00:00:00.000000000 Z
+date: 2015-11-18 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: codeclimate-engine-rb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.0
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
@@ -336,6 +350,7 @@ files:
 - lib/reek/examiner.rb
 - lib/reek/rake/task.rb
 - lib/reek/report.rb
+- lib/reek/report/code_climate_formatter.rb
 - lib/reek/report/formatter.rb
 - lib/reek/report/heading_formatter.rb
 - lib/reek/report/html_report.html.erb
@@ -409,6 +424,8 @@ files:
 - spec/reek/context/root_context_spec.rb
 - spec/reek/context/singleton_method_context_spec.rb
 - spec/reek/examiner_spec.rb
+- spec/reek/report/code_climate_formatter_spec.rb
+- spec/reek/report/code_climate_report_spec.rb
 - spec/reek/report/html_report_spec.rb
 - spec/reek/report/json_report_spec.rb
 - spec/reek/report/location_formatter_spec.rb
@@ -513,7 +530,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.0
 signing_key: 
 specification_version: 4
 summary: Code smell detector for Ruby