reek 3.6.0 → 3.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4dcff37dc4ddba77bf578314779a49fab1fcd0e7
-  data.tar.gz: d3a82f168438222a7a5bbab73a491b877cbd8144
+  metadata.gz: 6656a7be5a8741a3d09652e3d4fffa05f06d8e8e
+  data.tar.gz: fe908f1791d3ca5ff1dddee324569dbc52293f6c
 SHA512:
-  metadata.gz: ccc8992f22bda5b7be9d68ee269fb454db74f179dd2ebe05c42d78b4b0c779af0202e511f43c337507187e411c03be58ab740a8383b79844c04f64d11c4e7ffc
-  data.tar.gz: b11c75c4d4ebf103cb97355b3688049ba275165783fba752b5c9cefe5c94cbeaa6f2a38dd0b1c5f6ab2faf0368c4e7548da42b56685acbf1f7f71a7cf9b8cf1d
+  metadata.gz: b90ac67fe60415c01a8b9330acdabbfa61ba82627e2a22f5e899b8bb2e7683d055b05ddfbf0643a3dffa551a1e39823d76df08a5496b70ddbb15a9928475236f
+  data.tar.gz: 8adff3362ad6e24ac4a2f91b8e8325fb4432f890a66a10fc3ced5fd997ab9029642283eec0f2550d3c84c8777ae53d00eefa83be3cc95dae1e15e1d10ca8434a

data/CHANGELOG.md

@@ -2,7 +2,12 @@
 
 ## Unreleased
 
-## 3.6 (2015-10-30)
+## 3.6.1 (2015-11-13)
+
+* (mvz) Make UtilityFunction not report methods that call `super` with
+  arguments.
+
+## 3.6.0 (2015-10-30)
 
 * (mvz) Make Attribute respect suppressing comments
 * (chastell) Adjust parser dependency to allow versions 2.2.3+ (and even 2.3+)

data/README.md

@@ -14,7 +14,12 @@
 
 Reek is a tool that examines Ruby classes, modules and methods and reports any
 [Code Smells](docs/Code-Smells.md) it finds.
-Install it like this:
+
+For an excellent introduction to
+[Code Smells](docs/Code-Smells.md) and `Reek` check out [this blog post](https://blog.codeship.com/how-to-find-ruby-code-smells-with-reek/)
+or [this talk](https://www.youtube.com/watch?v=ZzqOuHI5MkA).
+
+Install it via rubygems:
 
 ```Bash
 gem install reek

data/docs/API.md

@@ -50,6 +50,33 @@ string -- 5 warnings:
 
 Note that `Reek::Examiner.new` can take `source` as `String`, `Pathname`, `File` or `IO`.
 
+## API stability
+
+Everything that is mentioned in this document can be considered stable in the
+sense that it will only change across major versions.
+
+`Reek 3` was the first major version with a stable API. As soon as `Reek 4`
+is released we will mark the differences between `3` and `4`.
+
+There is one thing in this API documentation you can't and shouldn't rely on:
+The `SmellWarning` messages itself.
+
+Something like this
+
+```
+Dirty#m has the parameter name 'a' (UncommunicativeParameterName)
+```
+
+might change even across minor versions.
+
+You should not need to be specific about those messages anyways.
+In case you'd like to be specific about `SmellWarnings` please have a look at
+[accessing the smell warnings directly](#accessing-the-smell-warnings-directly).
+
+Additionally you can use one of our structured [outputs formats](#choosing-your-output-format)
+like JSON or YAML if you need a more fine-grained access to our
+`SmellWarnings`.
+
 ## Choosing your output format
 
 Besides normal text output, Reek can generate output in YAML,

data/lib/reek/ast/node.rb

@@ -43,7 +43,7 @@ module Reek
       #
       # target_type - the type to look for, e.g. :send, :block
       # ignoring - types to ignore, e.g. [:casgn, :class, :module]
-      # blk - block to execute for every hit
+      # blk - block to execute for every hit. Gets passed in the matching element itself.
       #
       # Examples:
       #   context.each_node(:send, [:mlhs]) do |call_node| .... end

data/lib/reek/ast/reference_collector.rb

@@ -22,7 +22,7 @@ module Reek
       private_attr_reader :ast
 
       def explicit_self_calls
-        [:self, :zsuper, :ivar, :ivasgn].flat_map do |node_type|
+        [:self, :super, :zsuper, :ivar, :ivasgn].flat_map do |node_type|
           ast.each_node(node_type, STOP_NODES)
         end
       end

data/lib/reek/context/code_context.rb

@@ -105,6 +105,7 @@ module Reek
         each_node(type, [:casgn, :class, :module], &blk)
       end
 
+      # See Reek::AST::Node for details.
       def each_node(type, ignoring, &blk)
         exp.each_node(type, ignoring, &blk)
       end

data/lib/reek/smells/attribute.rb

@@ -29,7 +29,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         attributes_in(ctx).map do |attribute, line|
           smell_warning(
             context: ctx,

data/lib/reek/smells/boolean_parameter.rb

@@ -23,7 +23,7 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       # :reek:FeatureEnvy
-      def examine_context(ctx)
+      def inspect(ctx)
         ctx.default_assignments.select do |_param, value|
           [:true, :false].include?(value.type)
         end.map do |parameter, _value|

data/lib/reek/smells/class_variable.rb

@@ -23,7 +23,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         class_variables_in(ctx.exp).map do |variable, lines|
           smell_warning(
             context: ctx,

data/lib/reek/smells/control_parameter.rb

@@ -53,7 +53,7 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       # :reek:FeatureEnvy
-      def examine_context(ctx)
+      def inspect(ctx)
         ControlParameterCollector.new(ctx).control_parameters.map do |control_parameter|
           name = control_parameter.name.to_s
           smell_warning(

data/lib/reek/smells/data_clump.rb

@@ -51,7 +51,7 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       # :reek:FeatureEnvy
-      def examine_context(ctx)
+      def inspect(ctx)
         max_copies = value(MAX_COPIES_KEY, ctx, DEFAULT_MAX_COPIES)
         min_clump_size = value(MIN_CLUMP_SIZE_KEY, ctx, DEFAULT_MIN_CLUMP_SIZE)
         MethodGroup.new(ctx, min_clump_size, max_copies).clumps.map do |clump, methods|

data/lib/reek/smells/duplicate_method_call.rb

@@ -47,7 +47,7 @@ module Reek
       #
       # :reek:FeatureEnvy
       # :reek:DuplicateMethodCall: { max_calls: 2 }
-      def examine_context(ctx)
+      def inspect(ctx)
         max_allowed_calls = value(MAX_ALLOWED_CALLS_KEY, ctx, DEFAULT_MAX_CALLS)
         allow_calls = value(ALLOW_CALLS_KEY, ctx, DEFAULT_ALLOW_CALLS)
 

data/lib/reek/smells/feature_envy.rb

@@ -45,7 +45,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         return [] unless ctx.references_self?
         envious_receivers(ctx).map do |name, refs|
           smell_warning(

data/lib/reek/smells/irresponsible_module.rb

@@ -18,7 +18,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         return [] if descriptive?(ctx) || ctx.namespace_module?
         expression = ctx.exp
         [smell_warning(

data/lib/reek/smells/long_parameter_list.rb

@@ -33,7 +33,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         max_allowed_params = value(MAX_ALLOWED_PARAMS_KEY, ctx, DEFAULT_MAX_ALLOWED_PARAMS)
         exp = ctx.exp
         count = exp.arg_names.length

data/lib/reek/smells/long_yield_list.rb

@@ -29,7 +29,7 @@ module Reek
       #
       # :reek:FeatureEnvy
       # :reek:DuplicateMethodCall: { max_calls: 2 }
-      def examine_context(ctx)
+      def inspect(ctx)
         max_allowed_params = value(MAX_ALLOWED_PARAMS_KEY,
                                    ctx,
                                    DEFAULT_MAX_ALLOWED_PARAMS)

data/lib/reek/smells/module_initialize.rb

@@ -20,7 +20,7 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       # :reek:FeatureEnvy
-      def examine_context(ctx)
+      def inspect(ctx)
         ctx.local_nodes(:def) do |node| # FIXME: also search for :defs?
           if node.name.to_s == 'initialize'
             return [

data/lib/reek/smells/nested_iterators.rb

@@ -44,7 +44,7 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       # :reek:TooManyStatements: { max_statements: 6 }
-      def examine_context(ctx)
+      def inspect(ctx)
         configure_ignore_iterators(ctx)
         deepest_iterator = find_deepest_iterator ctx
         return [] unless deepest_iterator

data/lib/reek/smells/nil_check.rb

@@ -12,7 +12,7 @@ module Reek
         'SimulatedPolymorphism'
       end
 
-      def examine_context(ctx)
+      def inspect(ctx)
         call_node_finder = NodeFinder.new(ctx, :send, NilCallNodeDetector)
         case_node_finder = NodeFinder.new(ctx, :when, NilWhenNodeDetector)
         smelly_nodes = call_node_finder.smelly_nodes + case_node_finder.smelly_nodes

data/lib/reek/smells/prima_donna_method.rb

@@ -28,7 +28,7 @@ module Reek
         [:class]
       end
 
-      def examine_context(ctx)
+      def inspect(ctx)
         ctx.node_instance_methods.map do |method_sexp|
           check_for_smells(method_sexp, ctx)
         end.compact

data/lib/reek/smells/repeated_conditional.rb

@@ -51,7 +51,7 @@ module Reek
       #
       # :reek:TooManyStatements: { max_statements: 6 }
       # :reek:DuplicateMethodCall: { max_calls: 2 }
-      def examine_context(ctx)
+      def inspect(ctx)
         max_identical_ifs = value(MAX_IDENTICAL_IFS_KEY, ctx, DEFAULT_MAX_IFS)
         conditional_counts(ctx).select do |_key, lines|
           lines.length > max_identical_ifs

data/lib/reek/smells/smell_detector.rb

@@ -15,6 +15,8 @@ module Reek
     # :reek:TooManyMethods: { max_methods: 19 }
     # :reek:TooManyInstanceVariables: { max_instance_variables: 5 }
     class SmellDetector
+      attr_reader :config
+      private_attr_accessor :smells_found
       # The name of the config field that lists the names of code contexts
       # that should not be checked. Add this field to the config for each
       # smell that should ignore this code element.
@@ -24,32 +26,9 @@ module Reek
       # in any configuration file.
       DEFAULT_EXCLUDE_SET = []
 
-      class << self
-        def contexts
-          [:def, :defs]
-        end
-
-        # :reek:UtilityFunction
-        def default_config
-          {
-            SmellConfiguration::ENABLED_KEY => true,
-            EXCLUDE_KEY => DEFAULT_EXCLUDE_SET.dup
-          }
-        end
-
-        def inherited(subclass)
-          subclasses << subclass
-        end
-
-        def descendants
-          subclasses
-        end
-
-        private
-
-        def subclasses
-          @subclasses ||= []
-        end
+      def initialize(config = {})
+        @config       = SmellConfiguration.new self.class.default_config.merge(config)
+        @smells_found = []
       end
 
       def smell_category
@@ -60,52 +39,25 @@ module Reek
         self.class.smell_type
       end
 
-      class << self
-        def smell_category
-          @smell_category ||= default_smell_category
-        end
-
-        def smell_type
-          @smell_type ||= default_smell_category
-        end
-
-        def default_smell_category
-          name.split(/::/)[-1]
-        end
-      end
-
-      def initialize(config = {})
-        config = self.class.default_config.merge(config)
-        @config = SmellConfiguration.new(config)
-        @smells_found = []
+      def contexts
+        self.class.contexts
       end
 
-      def register(hooks)
-        return unless config.enabled?
-        self.class.contexts.each { |ctx| hooks[ctx] << self }
-      end
-
-      def examine(context)
-        return unless enabled_for? context
+      def run_for(context)
+        return unless enabled_for?(context)
         return if exception?(context)
 
-        sm = examine_context(context)
-        self.smells_found += sm
+        self.smells_found = smells_found + inspect(context)
       end
 
-      def report_on(report)
-        smells_found.each { |smell| smell.report_on(report) }
+      def report_on(collector)
+        smells_found.each { |smell| smell.report_on(collector) }
       end
 
       def exception?(context)
         context.matches?(value(EXCLUDE_KEY, context, DEFAULT_EXCLUDE_SET))
       end
 
-      protected
-
-      # NOTE: Needs to be protected so += works for Ruby < 2.2
-      attr_accessor :smells_found
-
       private
 
       def enabled_for?(context)
@@ -133,7 +85,39 @@ module Reek
                          parameters: options.fetch(:parameters, {}))
       end
 
-      private_attr_reader :config
+      class << self
+        def smell_category
+          @smell_category ||= default_smell_category
+        end
+
+        def smell_type
+          @smell_type ||= default_smell_category
+        end
+
+        def default_smell_category
+          name.split(/::/)[-1]
+        end
+
+        def contexts
+          [:def, :defs]
+        end
+
+        # :reek:UtilityFunction
+        def default_config
+          {
+            SmellConfiguration::ENABLED_KEY => true,
+            EXCLUDE_KEY => DEFAULT_EXCLUDE_SET.dup
+          }
+        end
+
+        def inherited(subclass)
+          descendants << subclass
+        end
+
+        def descendants
+          @descendants ||= []
+        end
+      end
     end
   end
 end

data/lib/reek/smells/smell_repository.rb

@@ -8,6 +8,8 @@ module Reek
     # Contains all the existing smells and exposes operations on them.
     #
     class SmellRepository
+      private_attr_reader :configuration, :smell_types, :detectors
+
       def self.smell_types
         Reek::Smells::SmellDetector.descendants.sort_by(&:name)
       end
@@ -23,38 +25,34 @@ module Reek
                      configuration: {})
         @configuration = configuration
         @smell_types   = smell_types
+        @detectors     = smell_types.map { |klass| klass.new configuration_for(klass) }
       end
 
-      def report_on(listener)
-        detectors.each_value { |detector| detector.report_on(listener) }
+      def report_on(collector)
+        detectors.each { |detector| detector.report_on(collector) }
       end
 
       def examine(context)
-        smell_listeners[context.type].each do |detector|
-          detector.examine(context)
+        smell_detectors_for(context.type).each do |detector|
+          detector.run_for(context)
         end
       end
 
-      def detectors
-        @initialized_detectors ||= smell_types.map do |klass|
-          { klass => klass.new(source_configuration_for(klass)) }
-        end.reduce({}, :merge)
-      end
-
       private
 
-      private_attr_reader :configuration, :smell_types
-
-      def source_configuration_for(klass)
-        configuration[klass] || {}
+      def configuration_for(klass)
+        configuration.fetch klass, {}
       end
 
-      # TODO: Make a method smell_detectors_for(scope)
-      def smell_listeners
-        @smell_listeners ||= Hash.new { |hash, key| hash[key] = [] }.tap do |listeners|
-          detectors.each_value { |detector| detector.register(listeners) }
+      def smell_detectors_for(type)
+        enabled_detectors.select do |detector|
+          detector.contexts.include? type
         end
       end
+
+      def enabled_detectors
+        detectors.select { |detector| detector.config.enabled? }
+      end
     end
   end
 end

data/lib/reek/smells/too_many_instance_variables.rb

@@ -37,7 +37,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         max_allowed_ivars = value(MAX_ALLOWED_IVARS_KEY, ctx, DEFAULT_MAX_IVARS)
         count = ctx.local_nodes(:ivasgn).map { |ivasgn| ivasgn.children.first }.uniq.length
         return [] if count <= max_allowed_ivars

data/lib/reek/smells/too_many_methods.rb

@@ -23,7 +23,7 @@ module Reek
         'LargeClass'
       end
 
-      def self.contexts # :nodoc:
+      def self.contexts
         [:class]
       end
 
@@ -39,7 +39,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         max_allowed_methods = value(MAX_ALLOWED_METHODS_KEY, ctx, DEFAULT_MAX_METHODS)
         # TODO: Only checks instance methods!
         actual = ctx.node_instance_methods.length

data/lib/reek/smells/too_many_statements.rb

@@ -31,7 +31,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         max_allowed_statements = value(MAX_ALLOWED_STATEMENTS_KEY,
                                        ctx,
                                        DEFAULT_MAX_STATEMENTS)

data/lib/reek/smells/uncommunicative_method_name.rb

@@ -39,7 +39,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(context)
+      def inspect(context)
         name = context.name.to_s
         return [] if acceptable_name?(name: name, context: context)
 

data/lib/reek/smells/uncommunicative_module_name.rb

@@ -49,7 +49,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(context)
+      def inspect(context)
         fully_qualified_name = context.full_name
         exp                  = context.exp
         module_name          = exp.simple_name

data/lib/reek/smells/uncommunicative_parameter_name.rb

@@ -40,7 +40,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(context)
+      def inspect(context)
         expression = context.exp
         expression.parameter_names.select do |name|
           sanitized_name = sanitize name

data/lib/reek/smells/uncommunicative_variable_name.rb

@@ -51,7 +51,7 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
-      def examine_context(ctx)
+      def inspect(ctx)
         self.reject_names = value(REJECT_KEY, ctx, DEFAULT_REJECT_SET)
         self.accept_names = value(ACCEPT_KEY, ctx, DEFAULT_ACCEPT_SET)
         variable_names(ctx.exp).select do |name, _lines|

data/lib/reek/smells/unused_parameters.rb

@@ -18,7 +18,7 @@ module Reek
       # @return [Array<SmellWarning>]
       #
       # :reek:FeatureEnvy
-      def examine_context(ctx)
+      def inspect(ctx)
         return [] if ctx.uses_super_with_implicit_arguments?
         ctx.unused_params.map do |param|
           name = param.name.to_s

data/lib/reek/smells/utility_function.rb

@@ -57,7 +57,7 @@ module Reek
       #
       # :reek:FeatureEnvy
       # :reek:TooManyStatements: { max_statements: 6 }
-      def examine_context(ctx)
+      def inspect(ctx)
         return [] if ctx.singleton_method?
         return [] if ctx.num_statements == 0
         return [] if ctx.references_self?

data/lib/reek/tree_walker.rb

@@ -25,7 +25,7 @@ module Reek
     end
 
     def walk
-      result.each do |element|
+      context_tree.each do |element|
         smell_repository.examine(element)
       end
     end
@@ -35,8 +35,26 @@ module Reek
     private_attr_accessor :element
     private_attr_reader :exp, :smell_repository
 
-    def result
-      @result ||= process(exp)
+    # Processes the given AST, memoizes it and returns a tree of nested
+    # contexts.
+    #
+    # For example this ruby code:
+    #   class Car; def drive; end; end
+    # would get compiled into this AST:
+    #   (class
+    #     (const nil :Car) nil
+    #     (def :drive
+    #       (args) nil))
+    # Processing this AST would result in a context tree where each node
+    # contains the outer context, the AST and the child contexts. The top
+    # node is always Reek::Context::RootContext. Using the example above,
+    # the tree would look like this:
+    #
+    # RootContext -> children: 1 ModuleContext -> children: 1 MethodContext
+    #
+    # @return [Reek::Context::RootContext] tree of nested contexts
+    def context_tree
+      @context_tree ||= process(exp)
     end
 
     def process(exp)

data/lib/reek/version.rb

@@ -6,6 +6,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '3.6.0'
+    STRING = '3.6.1'
   end
 end

data/reek.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'unparser',     '~> 0.2.2'
 
   s.add_development_dependency 'activesupport', '~> 4.2'
-  s.add_development_dependency 'aruba',         '~> 0.9.0'
+  s.add_development_dependency 'aruba',         '~> 0.10.0'
   s.add_development_dependency 'ataru',         '~> 0.2.0'
   s.add_development_dependency 'bundler',       '~> 1.1'
   s.add_development_dependency 'cucumber',      '~> 2.0'

data/spec/reek/ast/reference_collector_spec.rb

@@ -16,6 +16,10 @@ RSpec.describe Reek::AST::ReferenceCollector do
       expect(refs_to_self('def simple() super; end')).to eq(1)
     end
 
+    it 'counts a call to super with arguments' do
+      expect(refs_to_self('def simple() super(); end')).to eq(1)
+    end
+
     it 'counts a local call' do
       expect(refs_to_self('def simple() to_s; end')).to eq(1)
     end

data/spec/reek/smells/boolean_parameter_spec.rb

@@ -74,7 +74,7 @@ RSpec.describe Reek::Smells::BooleanParameter do
       let(:warning) do
         src = 'def cc(arga = true) end'
         ctx = Reek::Context::MethodContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-        detector.examine_context(ctx).first
+        detector.inspect(ctx).first
       end
 
       it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/class_variable_spec.rb

@@ -12,19 +12,19 @@ RSpec.describe Reek::Smells::ClassVariable do
   context 'with no class variables' do
     it 'records nothing in the class' do
       exp = sexp(:class, :Fred)
-      expect(detector.examine_context(Reek::Context::CodeContext.new(nil, exp))).to be_empty
+      expect(detector.inspect(Reek::Context::CodeContext.new(nil, exp))).to be_empty
     end
 
     it 'records nothing in the module' do
       exp = sexp(:module, :Fred)
-      expect(detector.examine_context(Reek::Context::CodeContext.new(nil, exp))).to be_empty
+      expect(detector.inspect(Reek::Context::CodeContext.new(nil, exp))).to be_empty
     end
   end
 
   context 'with one class variable' do
     shared_examples_for 'one variable found' do
       let(:ast) { Reek::Source::SourceCode.from(src).syntax_tree }
-      let(:smells) { detector.examine_context(Reek::Context::CodeContext.new(nil, ast)) }
+      let(:smells) { detector.inspect(Reek::Context::CodeContext.new(nil, ast)) }
 
       it 'records only that class variable' do
         expect(smells.length).to eq(1)
@@ -85,7 +85,7 @@ RSpec.describe Reek::Smells::ClassVariable do
         end
       EOS
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/control_parameter_spec.rb

@@ -270,7 +270,7 @@ RSpec.describe Reek::Smells::ControlParameter do
         end
       EOS
       ctx = Reek::Context::MethodContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      smells = detector.examine(ctx)
+      smells = detector.run_for(ctx)
       expect(smells.length).to eq(1)
       smells.first
     end

data/spec/reek/smells/data_clump_spec.rb

@@ -26,7 +26,7 @@ RSpec.shared_examples_for 'a data clump detector' do
         end
       EOS
       ctx = Reek::Context::ModuleContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      build(:smell_detector, smell_type: :DataClump).examine_context(ctx)
+      build(:smell_detector, smell_type: :DataClump).inspect(ctx)
     end
 
     it 'records only the one smell' do

data/spec/reek/smells/duplicate_method_call_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe Reek::Smells::DuplicateMethodCall do
         end
       EOS
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      smells = detector.examine_context(ctx)
+      smells = detector.inspect(ctx)
       expect(smells.length).to eq(1)
       smells.first
     end

data/spec/reek/smells/long_parameter_list_spec.rb

@@ -87,7 +87,7 @@ RSpec.describe Reek::Smells::LongParameterList do
         end
       EOS
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/long_yield_list_spec.rb

@@ -36,7 +36,7 @@ RSpec.describe Reek::Smells::LongYieldList do
           end
       EOS
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/nested_iterators_spec.rb

@@ -109,7 +109,7 @@ RSpec.describe Reek::Smells::NestedIterators do
     expect(src).to reek_of(:NestedIterators)
   end
 
-  describe 'examine_context / warnings' do
+  describe 'inspect / warnings' do
     let(:detector) { build(:smell_detector, smell_type: :NestedIterators) }
 
     it 'reports correctly' do
@@ -120,7 +120,7 @@ RSpec.describe Reek::Smells::NestedIterators do
           end
         end
       EOS
-      warnings = detector.examine_context(build(:method_context, source: source))
+      warnings = detector.inspect(build(:method_context, source: source))
       warning = warnings.first
 
       expect(warning.smell_category).to eq(Reek::Smells::NestedIterators.smell_category)
@@ -137,7 +137,7 @@ RSpec.describe Reek::Smells::NestedIterators do
         end
       EOS
 
-      warnings = detector.examine_context(build(:method_context, source: source))
+      warnings = detector.inspect(build(:method_context, source: source))
       expect(warnings.size).to eq(1)
       warning = warnings.first
       expect(warning.parameters[:name]).to eq('bad')
@@ -150,7 +150,7 @@ RSpec.describe Reek::Smells::NestedIterators do
           @jim.each {|ting| ting.each {|piece| piece.each {|atom| atom.foo } } }
         end
       EOS
-      warnings = detector.examine_context(build(:method_context, source: source))
+      warnings = detector.inspect(build(:method_context, source: source))
       expect(warnings.size).to eq(1)
       warning = warnings.first
 
@@ -273,7 +273,7 @@ RSpec.describe Reek::Smells::NestedIterators do
         end
       EOS
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/nil_check_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe Reek::Smells::NilCheck do
       EOS
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
       detector = build(:smell_detector, smell_type: :NilCheck)
-      smells = detector.examine_context(ctx)
+      smells = detector.inspect(ctx)
       expect(smells[0].lines).to eq [2]
     end
 

data/spec/reek/smells/prima_donna_method_spec.rb

@@ -20,7 +20,7 @@ RSpec.describe Reek::Smells::PrimaDonnaMethod do
     end
 
     it 'should be reported' do
-      smells = detector.examine_context(ctx)
+      smells = detector.inspect(ctx)
       warning = smells[0]
 
       expect(warning.smell_category).to eq('PrimaDonnaMethod')

data/spec/reek/smells/smell_detector_shared.rb

@@ -22,9 +22,11 @@ RSpec.shared_examples_for 'common fields set correctly' do
   it 'reports the source' do
     expect(warning.source).to eq('string')
   end
+
   it 'reports the smell class' do
     expect(warning.smell_category).to eq(detector.smell_category)
   end
+
   it 'reports the smell sub class' do
     expect(warning.smell_type).to eq(detector.smell_type)
   end

data/spec/reek/smells/too_many_instance_variables_spec.rb

@@ -85,7 +85,7 @@ RSpec.describe Reek::Smells::TooManyInstanceVariables do
         end
       EOS
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/too_many_methods_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe Reek::Smells::TooManyMethods do
       EOS
       syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
       ctx = Reek::Context::ModuleContext.new(nil, syntax_tree)
-      expect(detector.examine_context(ctx)).to be_empty
+      expect(detector.inspect(ctx)).to be_empty
     end
 
     it 'should report if we exceed max_methods' do
@@ -31,7 +31,7 @@ RSpec.describe Reek::Smells::TooManyMethods do
       EOS
       syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
       ctx = Reek::Context::ModuleContext.new(nil, syntax_tree)
-      smells = detector.examine_context(ctx)
+      smells = detector.inspect(ctx)
       expect(smells.length).to eq(1)
       expect(smells[0].smell_type).to eq(described_class.smell_type)
       expect(smells[0].parameters[:count]).to eq(3)
@@ -54,7 +54,7 @@ RSpec.describe Reek::Smells::TooManyMethods do
       EOS
       syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
       ctx = Reek::Context::ModuleContext.new(nil, syntax_tree)
-      expect(detector.examine_context(ctx)).to be_empty
+      expect(detector.inspect(ctx)).to be_empty
     end
   end
 
@@ -69,7 +69,7 @@ RSpec.describe Reek::Smells::TooManyMethods do
 
     syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
     ctx = Reek::Context::ModuleContext.new(nil, syntax_tree)
-    warning = detector.examine_context(ctx)[0]
+    warning = detector.inspect(ctx)[0]
     expect(warning.source).to eq(source_name)
     expect(warning.smell_category).to eq(described_class.smell_category)
     expect(warning.smell_type).to eq(described_class.smell_type)

data/spec/reek/smells/too_many_statements_spec.rb

@@ -51,7 +51,7 @@ RSpec.describe Reek::Smells::TooManyStatements do
       ctx = double('method_context').as_null_object
       expect(ctx).to receive(:num_statements).and_return(num_statements)
       expect(ctx).to receive(:config_for).with(described_class).and_return({})
-      detector.examine_context(ctx)
+      detector.inspect(ctx)
     end
 
     it 'reports only 1 smell' do

data/spec/reek/smells/uncommunicative_method_name_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe Reek::Smells::UncommunicativeMethodName do
       let(:warning) do
         src = "def #{method_name}; end"
         ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-        detector.examine_context(ctx).first
+        detector.inspect(ctx).first
       end
 
       it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/uncommunicative_module_name_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe Reek::Smells::UncommunicativeModuleName do
     it 'reports a bad scoped name' do
       src = "#{type} Foo::X; end"
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      smells = detector.examine_context(ctx)
+      smells = detector.inspect(ctx)
       expect(smells.length).to eq(1)
       expect(smells[0].smell_category).to eq(Reek::Smells::UncommunicativeModuleName.smell_category)
       expect(smells[0].smell_type).to eq(Reek::Smells::UncommunicativeModuleName.smell_type)
@@ -66,7 +66,7 @@ RSpec.describe Reek::Smells::UncommunicativeModuleName do
     let(:warning) do
       src = 'module Printer2; end'
       ctx = Reek::Context::CodeContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/uncommunicative_parameter_name_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe Reek::Smells::UncommunicativeParameterName do
 
   it_should_behave_like 'SmellDetector'
 
-  { 'obj.' => 'with a receiveer',
+  { 'obj.' => 'with a receiver',
     '' => 'without a receiver' }.each do |host, description|
     context "in a method definition #{description}" do
       it 'does not recognise *' do
@@ -77,7 +77,7 @@ RSpec.describe Reek::Smells::UncommunicativeParameterName do
     let(:warning) do
       src = 'def bad(good, bad2, good_again); basics(good, bad2, good_again); end'
       ctx = Reek::Context::MethodContext.new(nil, Reek::Source::SourceCode.from(src).syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/uncommunicative_variable_name_spec.rb

@@ -51,7 +51,7 @@ RSpec.describe Reek::Smells::UncommunicativeVariableName do
       src = 'def simple(fred) x = jim(45); x = y end'
       syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
       ctx = Reek::Context::CodeContext.new(nil, syntax_tree)
-      smells = detector.examine_context(ctx)
+      smells = detector.inspect(ctx)
       expect(smells.length).to eq(1)
       expect(smells[0].smell_type).to eq(described_class.smell_type)
       expect(smells[0].parameters[:name]).to eq('x')
@@ -164,7 +164,7 @@ RSpec.describe Reek::Smells::UncommunicativeVariableName do
       EOS
       syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
       ctx = Reek::Context::CodeContext.new(nil, syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'
@@ -180,7 +180,7 @@ RSpec.describe Reek::Smells::UncommunicativeVariableName do
       src = 'def self.bad() x2 = 4; end'
       syntax_tree = Reek::Source::SourceCode.from(src).syntax_tree
       ctx = Reek::Context::CodeContext.new(nil, syntax_tree)
-      detector.examine_context(ctx).first
+      detector.inspect(ctx).first
     end
 
     it_should_behave_like 'common fields set correctly'

data/spec/reek/smells/utility_function_spec.rb

@@ -197,6 +197,10 @@ RSpec.describe Reek::Smells::UtilityFunction do
       expect('def child(arg) super; arg.to_s; end').not_to reek_of(:UtilityFunction)
     end
 
+    it 'does not report a method that calls super with arguments' do
+      expect('def child(arg) super(arg * 2); arg.to_s; end').not_to reek_of(:UtilityFunction)
+    end
+
     it 'should recognise a deep call' do
       src = <<-EOS
         class Red

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 3.6.0
+  version: 3.6.1
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-30 00:00:00.000000000 Z
+date: 2015-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -95,14 +95,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: ataru
   requirement: !ruby/object:Gem::Requirement