reek 3.1 → 3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c490c79513c93451a148336881db8ffec7665e7e
-  data.tar.gz: 88059b5d7db2a76be01ca26339e3753f1ef4fa68
+  metadata.gz: 51661975b3fe585a7de62a86ef3bdd470999cf9d
+  data.tar.gz: d47b8fc50a340c0effa99b2d19f2bf6b460d8531
 SHA512:
-  metadata.gz: a93e6367ce746f4c1fba78e8ca91e035b9f3f9624316f329c1f5640415649816dfcc5608427ec113ac4c66aceb7f3eaed800af0c11a8931ebfc828e0a1931413
-  data.tar.gz: 24b764ba2d1a15fefe32702567f55cdf49270aaf00c78b6cab50420ebad3b96651d450c210934b8e76e50da2048b14e0b496c4a861ebeb98f4a6d6fedfdac21c
+  metadata.gz: 1ad047b74e7063afa1ecf570d94e9522bc3b4da8e671abd72c06a7e318b9dc47c5faac7570b67afbca9ffc1c8b766e973594b241c04c62b16914a26d80d57830
+  data.tar.gz: 6801060d336d6ba4d605797cf32ad6f5df7be22fd44b41964c22b21c73d6a387e902dc63a6c119ec55f5bbf166179c93b471342fd91a33254179ad83567dc812

data/.travis.yml

@@ -18,14 +18,13 @@ matrix:
     - rvm: jruby-head
       env: JRUBY_OPTS='--server -Xcompile.invokedynamic=false'
   allow_failures:
+    - rvm: jruby
     - rvm: jruby-head
-      env: JRUBY_OPTS='--server -Xcompile.invokedynamic=false'
     - rvm: ruby-head
   fast_finish: true
 notifications:
   recipients:
     - timo.roessner@googlemail.com
     - matijs@matijs.net
-    - emil.rehnberg@gmail.com
     - chastell@chastell.net
   irc: "irc.freenode.org#reek"

data/{CHANGELOG → CHANGELOG.md}

@@ -1,70 +1,84 @@
-== 3.1
+# Change log
+
+## Unreleased
+
+## 3.2.0 (2015-08-17)
+
+* (mvz) Detect attribute writers created with `attr` in Attribute smell
+* (beanieboi) Report `attr_writer` and `attr_accessor` in Attribute smell
+* (troessner) Update TooManyInstanceVariables default from 9 to 4
+
+## 3.1.0 (2015-07-21)
 
 * (troessner) Make smells configurable on a directory base
 * (mvz) Handle modules defined by constant assignment
 * (mvz) Handle modifier style use of module_function for UtilityFunction
 
-== 3.0.4
+## 3.0.4 (2015-07-10)
 
 * (troessner) Fix wiki-link cli option.
+* (troessner) Recognize singleton methods defined via module function.
+* (chastell) Report all envious lines for FeatureEnvy
+* (mvz) Report IrresponsibleModule for modules in addition to classes
+* (mvz) Do not report IrresponsibleModule for namespace modules
 
-== 3.0.3
+## 3.0.3 (2015-07-04)
 
 * (troessner) Fix finding sources when using just the current directory.
 
-== 3.0.2
+## 3.0.2 (2015-07-03)
 
-* (troessner) Only use ruby source files.
+* (troessner) Only use Ruby source files.
 
-== 3.0.1
+## 3.0.1 (2015-07-03)
 
 * (troessner) Fix reek descending into hidden directories
 
-== 3.0.0
+## 3.0.0 (2015-06-30)
 
 * (troessner) Make directories excludable via configuration.
 * (mvz) Define and document public API
 * (troessner) Recognize methods defined with class << self syntax as singleton methods.
-* (troessner)  Use ruby22 instead of ruby21 for parsing.
+* (troessner)  Use Ruby22 instead of Ruby21 for parsing.
 * (nTraum) Drop support for Ruby 1.9
 
-== 2.2.1
+## 2.2.1 (2015-05-11)
 
 * (mvz) Support methods using array decomposition arguments
 
-== 2.2.0
+## 2.2.0 (2015-05-09)
 
 * (sauliusgrigaitis) Add support for XML reports
 * (beanieboi) Don’t track private methods in the Attributes smell
 * (Sebastian Boehm) Do not enable colorization if stdout is not a TTY
 
-== 2.1.0
+## 2.1.0 (2015-04-17)
 
 * (mvz) Ensure require 'reek' is enough to use reek's classes
 * (mvz) Pick config file that comes first alphabetically
 * (mvz) Separate FeatureEnvy and UtilityFunction
 
-== 2.0.4
+## 2.0.4 (2015-04-07)
 
 * (chastell)  Recognise .reek as a valid configuration file
 
-== 2.0.3
+## 2.0.3 (2015-04-06)
 
 * (mvz) Make NestedIterators handle super with arguments
 * (mvz) Handle shadow block arguments
 * (CoralineAda) Allow all formatters to support -U (wiki links)
 * (tuexss) Make defaults transparent in help message
 
-== 2.0.2
+## 2.0.2 (2015-03-15)
 
 * (troessner) Fix version command
 
-== 2.0.1
+## 2.0.1 (2015-03-03)
 
 * (leonelgalan) Add support for json reports
 * (chastell) Escape Regexp-like Strings on CodeContext matches (Bug https://github.com/troessner/reek/pull/397)
 
-== 2.0.0
+## 2.0.0 (2015-02-09)
 
 * (troessner) Revise, improve & refactor our Rspec matcher and remove smell_of
 * (guilhermesimoes) Fix generating HTML report
@@ -73,144 +87,157 @@
 * (marcofognog) Make NestedIterator not break if iterator is called on super
 * (troessner) Revamp & refactor our rake task
 
-== 1.6.3
+## 1.6.3 (2015-01-15)
 
-* (mvz) Support ruby 2.2
+* (mvz) Support Ruby 2.2
 
-== 1.6.2
+## 1.6.2 (2015-01-13)
 
 * (mvz) Fix rake task bug when no config file was given explicitly.
 * (troessner) Run on working directory when no source is given.
 
-== 1.6.1
+## 1.6.1 (2014-12-20)
 
 * (mvz) Fix regression in rake task: Provide alias for backward compatibility
 
-== 1.6.0
+## 1.6.0 (2014-12-27)
 
 * (troessner) Revise configuration handling:
   Now there are 3 ways of passing reek a configuration file:
   - Using the cli "-c" switch
   - Having a file ending with .reek either in your current working directory or in a parent directory (more on that later)
   - Having a file ending with .reek in your HOME directory
-  The order in which reek tries to find such a configuration file is exactly like above: First reek checks if we have given it a configuration file explicitly via CLI. Then it checks the current working directory for a file and if it can't find one, it traverses up the directories until it hits the root directory. And lastly, it checks your HOME directory.
-  As soon as reek detects a configuration file it stops searching immediately, meaning that from reek's point of view there exists one configuration file and one configuration only regardless of how many ".reek" files you might have on your filesystem.
+
+  The order in which reek tries to find such a configuration file is exactly
+  like above: First reek checks if we have given it a configuration file
+  explicitly via CLI. Then it checks the current working directory for a file and
+  if it can't find one, it traverses up the directories until it hits the root
+  directory. And lastly, it checks your HOME directory. As soon as reek detects a
+  configuration file it stops searching immediately, meaning that from reek's
+  point of view there exists one configuration file and one configuration only
+  regardless of how many ".reek" files you might have on your filesystem.
 * (chastell) Add keyword arguments support after switching to 'parser'
 * (mvz) Handle nil-block in iterators
 
-== 1.5.0
+## 1.5.1 (2014-12-05)
+
+* (mvz) Fix support for empty block in NestedIterators
+* (mvz) Update minimum required Ruby version to 1.9.3
+* (chastell) Fix support for required keyword arguments
+
+## 1.5.0 (2014-12-01)
 
-* (mvz) Parse with the parse gem
+* (mvz) Parse with the parser gem
 * (mvz) Add ModuleInitialize smell
 
-== 1.4.0
+## 1.4.0 (2014-11-09)
 
 * (Gilles Leblanc) Corrects UnusedParameter with keyword arguments with splat
 * (mvz) Consider block parameter for DuplicateMethodCall
 * (mvz) Add support for detecting specific smells
 * (troessner) Add ultra verbose warning formatter.
 
-== 1.3.8
+## 1.3.8 (2014-07-07)
 
 * Internal improvements
 
-== 1.3.7
+## 1.3.7 (2014-03-25)
 
 * (gilles-leblanc) Add color to reek's output
 * (mvz) Ignore unused parameters if method calls super in nested context
 * (mvz) Only mark parameters uncommunicative if used
 
-== 1.3.6
+## 1.3.6 (2013-12-29)
 
 * (troessner) Add `Prima Donna Method` smell
 
-== 1.3.5
+## 1.3.5 (2013-12-23)
 
 * (troessner) Allow sorting by issue count
 * (mvz) Improve cli options
 
-== 1.3.4
+## 1.3.4 (2013-10-14)
 
 * (apiology) Add --single-line option for reporting
 * (gilles-leblanc) Allow config files to override default config values
 * (gilles-leblanc) Added line numbers by default when you run the reek command
 * (mvz) Support Ruby 2.0 syntax
 
-== 1.3.3
+## 1.3.3 (2013-08-27)
 
 * (bf4) Loosen ruby_parser version dependency
 * (gilles-leblanc) Added total warning count
 
-== 1.3.2
+## 1.3.2 (2013-08-09)
 
 * (mvz) Allow duplicate calls to variable-like methods
 * (mvz) Improve NestedIterators smell detector
 * (mvz) Make combination of -n and -q options work
 
-== 1.3.1
+## 1.3.1 (2013-02-02)
 
 * (EmilRehnberg) Added smell for nil checks
 * (geoffharcourt) Updated dependencies to use ruby2ruby 2.0.2 and ruby_parser 3.1.1
 * (EmilRehnberg) Added command-line option for printing line numbers with the smell lines
 
-== 1.3
+## 1.3 (2013-01-19)
 
 * (mvz) Use new ruby_parser 3 and friends
 * (EmilRehnberg) Unused parameter smell added
 * (dkubb) Fix problem with IrresponsibleModule flagging the same module twice
 
-== 1.2.13 (2012-12-07)
+## 1.2.13 (2012-12-07)
 
 * (mvz) Update to rspec2.
-* (petrjanda) Fix undefined method `chr' on an instance of String on Rubinius
+* (petrjanda) Fix undefined method `chr` on an instance of String on Rubinius
 
-== 1.2.12 (2012-06-09)
+## 1.2.12 (2012-06-09)
 
 * (mvz) Use ripper_ruby_parser on Ruby 1.9.3 and up (thus making reek able
         to parse the new 1.9 hash syntax).
 
-== 1.2.11 (2012-06-08)
+## 1.2.11 (2012-06-08)
 
 * (mvz) Make Bundler a development dependency.
 
-== 1.2.10 (2012-06-05)
+## 1.2.10 (2012-06-05)
 
 * (troessner) Use bundler rake tasks.
 
-== 1.2.9 (2012-06-05)
+## 1.2.9 (2012-06-05)
 
 * (marktabler) Allow single underscore as a variable assignment without triggering UncommunicativeVariableName.
 
-== 1.2.8 (2010-04-26)
+## 1.2.8 (2010-04-26)
 
-=== Major Changes
+### Major Changes
 * Smell detectors can be configured or disabled in code comments
-** Comment with :reek:smell_name disables the named smell for a class, module or method
-** Comment with :reek:smell_name:{...} for more detailed configuration
+  * Comment with `:reek:smell_name` disables the named smell for a class, module or method
+  * Comment with `:reek:smell_name:{...}` for more detailed configuration
 * Additional config file(s) can be specified:
-** on the command-line using -c
-** via Reek::Rake::Task in the rakefile
+  * on the command-line using -c
+  * via Reek::Rake::Task in the rakefile
 
-=== Minor Changes
+### Minor Changes
 * Duplication can be configured to ignore specific calls
 * IrresponsibleModule now reports scoped module names correctly (#66)
 * NestedIterators is now more configurable:
-** Option to specify permitted nesting depth (#14)
-** Option to ignore certain iterator methods
+  * Option to specify permitted nesting depth (#14)
+  * Option to ignore certain iterator methods
 
-== 1.2.7.3 (2010-03-29)
+## 1.2.7.3 (2010-03-29)
 
-=== Minor Changes
+### Minor Changes
 * UtilityFunction no longer reported when local method called in param initializer (#60)
 * Spaces removed from smell class names in report output
 * Masked smells are no longer reported
-** the -a command-line option has been removed
-** some methods on Examiner are now deprecated
+  * the -a command-line option has been removed
+  * some methods on Examiner are now deprecated
 * DataClump no longer needs infinite memory for large classes (#57 again)
 
-== 1.2.7.2 (2010-03-05)
+## 1.2.7.2 (2010-03-05)
 
-=== Minor Changes
+### Minor Changes
 * Number of masked smells is no longer shown in report headers
 * Masked smells are no longer listed in --yaml reports
 * DataClump no longer needs infinite memory for large classes (#57)
@@ -218,20 +245,20 @@
 * UncommunicativeMethodName now accepts operator names (+, -, ...)
 * Uncommunicative Name now warns about uppercase letters in method & var names
 
-== 1.2.7.1 (2010-02-03)
+## 1.2.7.1 (2010-02-03)
 
-=== Minor Changes
+### Minor Changes
 * Fixed crash on a case statement with no condition (#58)
 
-== 1.2.7 (2010-02-01)
+## 1.2.7 (2010-02-01)
 
-=== Major Changes
+### Major Changes
 * New option --yaml reports smells in YAML format
 * Now require 'reek/rake/task' to use the rake task
 * Now require 'reek/spec' to use the Rspec matchers
 * Developer API completely revised and documented
 
-=== Minor Changes
+### Minor Changes
 * New smell: Irresponsible Module (has no meaningful comment)
 * ControlCouple no longer checks arguments yielded to blocks
 * FeatureEnvy and UtilityFunction are now subclasses of a new smell: LowCohesion
@@ -243,27 +270,27 @@
 
 See http://wiki.github.com/kevinrutherford/reek for further details.
 
-== 1.2.6 (2009-11-28)
+## 1.2.6 (2009-11-28)
 
-=== Minor Changes
+### Minor Changes
 * Corrected display of module methods to use # (#56)
 
-== 1.2.5 (2009-11-19)
+## 1.2.5 (2009-11-19)
 
-=== Minor Changes
+### Minor Changes
 * Ignores ruby_parser errors and pretends the offending file was empty
 
-== 1.2.4 (2009-11-17)
+## 1.2.4 (2009-11-17)
 
-=== Major Changes
+### Major Changes
 * The -f, -c and -s options for formatting smell warnings have been removed
 
-=== Minor Changes
+### Minor Changes
 * ControlCouple now warns about parameters defaulted to true/false
 
-== 1.2.3 (2009-11-2)
+## 1.2.3 (2009-11-2)
 
-=== Minor Changes
+### Minor Changes
 * New smell: Attribute (disabled by default)
 * Expanded DataClump to check modules (#9)
 * Fixed LargeClass to ignore inner classes and modules
@@ -271,109 +298,109 @@ See http://wiki.github.com/kevinrutherford/reek for further details.
 * Removed support for MyClass.should_not reek due to ParseTree EOL
 * Removed internal requiring of 'rubygems'
 
-== 1.2.1 (2009-10-02)
+## 1.2.1 (2009-10-02)
 
-=== Minor Changes
+### Minor Changes
 * New smell: Class Variable
 
 See http://wiki.github.com/kevinrutherford/reek for details
 
-== 1.2 2009-09-20
+## 1.2 2009-09-20
 
-=== Major Changes
-* Reek passes all its tests under ruby 1.8.6, 1.8.7 and 1.9.1 (fixed #16)
+### Major Changes
+* Reek passes all its tests under Ruby 1.8.6, 1.8.7 and 1.9.1 (fixed #16)
 * New smell -- Data Clump:
-** Looks within a class for 3 or more methods taking the same 2 or more parameters
+  * Looks within a class for 3 or more methods taking the same 2 or more parameters
 * New smell -- Simulated Polymorphism:
-** Currently only performs basic check for multiple tests of same value
+  * Currently only performs basic check for multiple tests of same value
 * Reek's output reports are now formatted differently:
-** Reek is no longer silent about smell-free source code
-** Output now reports on all files examined, even if they have no smells
-** Smell warnings are indented in the report; file summary headers are not
-** Reports for multiple sources are run together; no more blank lines
-** Reports in spec matcher failures are quiet (fixed #38)
-* The smells masked by *.reek config files can now be seen:
-** The header for each source file now counts masked smells
-** The --show-all (-a) option shows masked warnings in the report
+  * Reek is no longer silent about smell-free source code
+  * Output now reports on all files examined, even if they have no smells
+  * Smell warnings are indented in the report; file summary headers are not
+  * Reports for multiple sources are run together; no more blank lines
+  * Reports in spec matcher failures are quiet (fixed #38)
+* The smells masked by `*.reek` config files can now be seen:
+  * The header for each source file now counts masked smells
+  * The --show-all (-a) option shows masked warnings in the report
 * The spec matchers are now accessed by requiring 'reek/adapters/spec'
 
-=== Minor Changes
+### Minor Changes
 * Reek's RDoc is now hosted at http://rdoc.info/projects/kevinrutherford/reek
-* If a dir is passed on the command-line all **/*.rb files below it are examined (fixed #41)
+* If a dir is passed on the command-line all `**/*.rb` files below it are examined (fixed #41)
 * Duplication warnings now report the number of identical calls
 * FeatureEnvy no longer ignores :self when passed as a method parameter
 * LargeClass is disabled when checking in-memory classes (fixed #28)
 * LongParameterList accepts upto 5 parameters for #initialize methods
 * Several changes to the LongMethod counting algorithm:
-** LongMethod now counts statements deeper into each method (fixed #25)
-** LongMethod no longer counts control structures, only their contained stmts
-** See http://wiki.github.com/kevinrutherford/reek/long-method for details
+  * LongMethod now counts statements deeper into each method (fixed #25)
+  * LongMethod no longer counts control structures, only their contained stmts
+  * See http://wiki.github.com/kevinrutherford/reek/long-method for details
 * UncommunicativeName warns about any name ending in a number (fixed #18)
 * UtilityFunction has been relaxed somewhat:
-** no longer reports methods that call 'super' (fixed #39)
-** no longer reports simple helper methods
-** can be configured based on number of calls out
+  * no longer reports methods that call 'super' (fixed #39)
+  * no longer reports simple helper methods
+  * can be configured based on number of calls out
 * Now reports an error for corrupt config files
 * Empty config files are ignored
 * Smells can be configured with scope-specific overrides for any config item
 
 
-== 1.1.3 2009-05-19
+## 1.1.3 2009-05-19
 
-=== Minor Changes
+### Minor Changes
 * No longer depends directly on the sexp_processor gem
 
-=== Fixes
+### Fixes
 * LargeClass now relies only on the given source code (fixed #26)
 
-== 1.1.2 2009-05-18
+## 1.1.2 2009-05-18
 
-=== Major Enhancements
+### Major Enhancements
 * Switched from ParseTree to ruby_parser for source code parsing
 * 'MyClass.should_not reek' now only possible if ParseTree gem installed
 
-== 1.1.1 2009-05-08
+## 1.1.1 2009-05-08
 
-=== Minor enhancements
+### Minor enhancements
 * LargeClass now also warns about any class with > 9 instance variables (fixed #6)
 * Now depends on ruby2ruby, to display code better
 * Duplication notices more repeated method calls
 * Smells within blocks are now reported better
 
-== 1.1.0 2009-04-10
+## 1.1.0 2009-04-10
 
-=== Minor enhancements
+### Minor enhancements
 * Now possible to write 'MyClass.should_not reek' (fixed #33)
 
-=== Fixes
+### Fixes
 * Now counts attr assignments ([]= etc) in feature envy calculations
-* Doesn't attempt to find *.reek files when reading code from stdin
+* Doesn't attempt to find `*.reek` files when reading code from stdin
 
-== 1.0.1 2009-04-06
+## 1.0.1 2009-04-06
 
-=== Fixes
+### Fixes
 * Dir[...].to_source now creates a Report that can be browsed (fixed #36)
 
-== 1.0.0 2009-04-05
+## 1.0.0 2009-04-05
 
-=== Major enhancements
-* Use *.reek files in source tree to configure Reek's behaviour
+### Major enhancements
+* Use `*.reek` files in source tree to configure Reek's behaviour
 * Added -f option to configure report format
 * --sort_order replaced by -f, -c and -s
 * Matchers provided for rspec; eg. foo.should_not reek
 
-=== Minor enhancements
+### Minor enhancements
 * Smells in singleton methods are now analysed
 * Uncommunicative parameter names in blocks now reported
 * Modules and blocks now reflected in scope of smell reports
 
-=== Fixes
+### Fixes
 * Corrected false reports of long arg lists to yield
 * A method can now be a UtilityFunction only when it includes a call
 
-== 0.3.1 2008-11-17
+## 0.3.1 2008-11-17
 
-=== Minor enhancements
+### Minor enhancements
 * Uncommunicative Name now checks instance variables more thoroughly
 * Uncommunicative Name now warns about names of the form 'x2'
 * Added check for duplicated calls within a method
@@ -381,20 +408,20 @@ See http://wiki.github.com/kevinrutherford/reek for details
 * Added rdoc comments explaining what each smell is about
 * Chained iterators are no longer mis-reported as nested
 
-== 0.3.0 2008-11-02
+## 0.3.0 2008-11-02
 
-=== Minor enhancements
+### Minor enhancements
 * New smell: first naive checks for Control Couple
 * reek now only checks sources passed on the command line
 * Code snippets can be supplied on the commandline
 * Added headings and warnings count when smells in multiple files
 * Added Reek::RakeTask to run reek from rakefiles
 
-=== Fixes
+### Fixes
 * Fixed: Returns exit status 2 when smells are reported
 * Fixed: no longer claims an empty method is a Utility Function
 
-== 0.2.3 2008-09-22
+## 0.2.3 2008-09-22
 
 * Minor enhancements:
   * Only reports Feature Envy when the method isn't a Utility Function
@@ -405,24 +432,24 @@ See http://wiki.github.com/kevinrutherford/reek for details
   * Fixed: displaying the receiver of many more kinds of Feature Envy
   * Fixed: Large Class calculation for Object
 
-== 0.2.2 2008-09-15
+## 0.2.2 2008-09-15
 
 * Tweaks:
   * Fixed --version!
 
-== 0.2.1 2008-09-14
+## 0.2.1 2008-09-14
 
 * Tweaks:
   * Now works from the source code, instead of requiring each named file
   * Added integration tests that run reek on a couple of gems
 
-== 0.2.0 2008-09-10
+## 0.2.0 2008-09-10
 
 * Minor enhancements:
   * Added --help, --version options
   * Added --sort option to sort the report by smell or by code location
 
-== 0.1.1 2008-09-09
+## 0.1.1 2008-09-09
 
 * Some tweaks:
   * Fixed report printing for Feature Envy when the receiver is a block
@@ -430,7 +457,7 @@ See http://wiki.github.com/kevinrutherford/reek for details
   * Fixed: Long Method now reports the total length of the method
   * Fixed: each smell reported only once
 
-== 0.1.0 2008-09-09
+## 0.1.0 2008-09-09
 
 * 1 minor enhancement:
   * Added a check for nested iterators within a method
@@ -439,7 +466,7 @@ See http://wiki.github.com/kevinrutherford/reek for details
   * Split some of the specs into more meaningful chunks
   * Updated the rakefile so that rcov is no longer the default
 
-== 0.0.1 2008-09-08
+## 0.0.1 2008-09-08
 
 * 1 major enhancement:
   * Initial release