reek 3.0.4 → 3.1

data/spec/samples/configuration/full_configuration.reek

@@ -0,0 +1,9 @@
+---
+IrresponsibleModule:
+  enabled: false
+"spec/samples/three_clean_files/":
+  UtilityFunction:
+    enabled: false
+exclude_paths:
+  - "spec/samples/two_smelly_files/"
+  - "spec/samples/source_with_non_ruby_files/"

data/spec/spec_helper.rb

@@ -1,6 +1,8 @@
+require 'pathname'
 require_relative '../lib/reek/spec'
 require_relative '../lib/reek/ast/ast_node_class_map'
 require_relative '../lib/reek/configuration/app_configuration'
+require 'ostruct'
 
 Reek::CLI::Silencer.silently do
   require 'factory_girl'
@@ -16,22 +18,20 @@ end
 
 FactoryGirl.find_definitions
 
-SAMPLES_DIR = 'spec/samples'
+SAMPLES_PATH = Pathname.new("#{__dir__}/samples").relative_path_from(Pathname.pwd)
 
 # Simple helpers for our specs.
 module Helpers
-  def with_test_config(config)
-    if config.is_a? String
-      Reek::Configuration::AppConfiguration.load_from_file(config)
+  def test_configuration_for(config)
+    if config.is_a? Pathname
+      configuration = Reek::Configuration::AppConfiguration.new OpenStruct.new(config_file: config)
     elsif config.is_a? Hash
-      Reek::Configuration::AppConfiguration.class_eval do
-        @configuration = config
-      end
+      configuration = Reek::Configuration::AppConfiguration.new
+      configuration.instance_variable_set :@default_directive, config
     else
-      raise "Unknown config given in `with_test_config`: #{config.inspect}"
+      raise "Unknown config given in `test_configuration_for`: #{config.inspect}"
     end
-    yield if block_given?
-    Reek::Configuration::AppConfiguration.reset
+    configuration
   end
 
   # :reek:UncommunicativeMethodName

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 3.0.4
+  version: '3.1'
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-10 00:00:00.000000000 Z
+date: 2015-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -251,8 +251,8 @@ files:
 - features/command_line_interface/smell_selection.feature
 - features/command_line_interface/smells_count.feature
 - features/command_line_interface/stdin.feature
+- features/configuration_files/directory_specific_directives.feature
 - features/configuration_files/masking_smells.feature
-- features/configuration_files/overrides_defaults.feature
 - features/configuration_loading.feature
 - features/programmatic_access.feature
 - features/rake_task/rake_task.feature
@@ -406,6 +406,7 @@ files:
 - spec/samples/clean_due_to_masking/dirty_one.rb
 - spec/samples/clean_due_to_masking/dirty_two.rb
 - spec/samples/clean_due_to_masking/masked.reek
+- spec/samples/configuration/full_configuration.reek
 - spec/samples/configuration/simple_configuration.reek
 - spec/samples/configuration/with_excluded_paths.reek
 - spec/samples/exceptions.reek

data/features/configuration_files/overrides_defaults.feature

@@ -1,15 +0,0 @@
-Feature: Overriding current rules by specifying new configuration values
-  In order to customize Reek to suit my needs
-  As a developer
-  I want to be able to override the default configuration values
-
-  Scenario: List of configuration values is overridden by a lower configuration file
-    Given a file with smelly variable names called 'camel_case.rb'
-    And a configuration file allowing camel case variables
-    When I run reek camel_case.rb
-    Then the exit status indicates smells
-    And it reports:
-      """
-      camel_case.rb -- 1 warning:
-        [9]:CamelCase#initialize has the variable name 'x1' (UncommunicativeVariableName)
-      """