reek 2.2.1 → 3.0.0

data/lib/reek/core/tree_dresser.rb

@@ -1,24 +0,0 @@
-require_relative 'ast_node_class_map'
-
-module Reek
-  module Core
-    #
-    # Adorns an abstract syntax tree with mix-in modules to make accessing
-    # the tree more understandable and less implementation-dependent.
-    #
-    class TreeDresser
-      def initialize(klass_map = ASTNodeClassMap.new)
-        @klass_map = klass_map
-      end
-
-      def dress(sexp, comment_map)
-        return sexp unless sexp.is_a? AST::Node
-        type = sexp.type
-        children = sexp.children.map { |child| dress(child, comment_map) }
-        comments = comment_map[sexp]
-        @klass_map.klass_for(type).new(type, children,
-                                       location: sexp.loc, comments: comments)
-      end
-    end
-  end
-end

data/lib/reek/core/tree_walker.rb

@@ -1,180 +0,0 @@
-require_relative 'method_context'
-require_relative 'module_context'
-require_relative 'stop_context'
-require_relative 'singleton_method_context'
-
-module Reek
-  module Core
-    #
-    # Traverses a Sexp abstract syntax tree and fires events whenever
-    # it encounters specific node types.
-    #
-    # SMELL: This class is responsible for counting statements and for feeding
-    # each context to the smell repository.
-    class TreeWalker
-      def initialize(smell_repository = Core::SmellRepository.new)
-        @smell_repository = smell_repository
-        @element = StopContext.new
-      end
-
-      def process(exp)
-        context_processor = "process_#{exp.type}"
-        if context_processor_exists?(context_processor)
-          send(context_processor, exp)
-        else
-          process_default exp
-        end
-        @element
-      end
-
-      def process_default(exp)
-        exp.children.each do |child|
-          process(child) if child.is_a? AST::Node
-        end
-      end
-
-      def process_module(exp)
-        inside_new_context(ModuleContext, exp) do
-          process_default(exp)
-        end
-      end
-
-      alias_method :process_class, :process_module
-
-      def process_def(exp)
-        inside_new_context(MethodContext, exp) do
-          count_clause(exp.body)
-          process_default(exp)
-        end
-      end
-
-      def process_defs(exp)
-        inside_new_context(SingletonMethodContext, exp) do
-          count_clause(exp.body)
-          process_default(exp)
-        end
-      end
-
-      def process_args(_) end
-
-      #
-      # Recording of calls to methods and self
-      #
-
-      def process_send(exp)
-        @element.record_call_to(exp)
-        process_default(exp)
-      end
-
-      alias_method :process_attrasgn, :process_send
-      alias_method :process_op_asgn, :process_send
-
-      def process_ivar(exp)
-        @element.record_use_of_self
-        process_default(exp)
-      end
-
-      alias_method :process_ivasgn, :process_ivar
-
-      def process_self(_)
-        @element.record_use_of_self
-      end
-
-      alias_method :process_zsuper, :process_self
-
-      #
-      # Statement counting
-      #
-
-      def process_block(exp)
-        count_clause(exp.block)
-        process_default(exp)
-      end
-
-      def process_begin(exp)
-        count_statement_list(exp.children)
-        @element.count_statements(-1)
-        process_default(exp)
-      end
-
-      alias_method :process_kwbegin, :process_begin
-
-      def process_if(exp)
-        count_clause(exp[2])
-        count_clause(exp[3])
-        @element.count_statements(-1)
-        process_default(exp)
-      end
-
-      def process_while(exp)
-        count_clause(exp[2])
-        @element.count_statements(-1)
-        process_default(exp)
-      end
-
-      alias_method :process_until, :process_while
-
-      def process_for(exp)
-        count_clause(exp[3])
-        @element.count_statements(-1)
-        process_default(exp)
-      end
-
-      def process_rescue(exp)
-        count_clause(exp[1])
-        @element.count_statements(-1)
-        process_default(exp)
-      end
-
-      def process_resbody(exp)
-        count_statement_list(exp[2..-1].compact)
-        process_default(exp)
-      end
-
-      def process_case(exp)
-        count_clause(exp.else_body)
-        @element.count_statements(-1)
-        process_default(exp)
-      end
-
-      def process_when(exp)
-        count_clause(exp.body)
-        process_default(exp)
-      end
-
-      private
-
-      def context_processor_exists?(name)
-        respond_to?(name)
-      end
-
-      def count_clause(sexp)
-        @element.count_statements(1) if sexp
-      end
-
-      def count_statement_list(statement_list)
-        @element.count_statements statement_list.length
-      end
-
-      def inside_new_context(klass, exp)
-        scope = klass.new(@element, exp)
-        push(scope) do
-          yield
-          check_smells(exp.type)
-        end
-        scope
-      end
-
-      def check_smells(type)
-        @smell_repository.examine(@element, type)
-      end
-
-      def push(scope)
-        orig = @element
-        @element = scope
-        yield
-        @element = orig
-      end
-    end
-  end
-end

data/lib/reek/source/source_repository.rb

@@ -1,43 +0,0 @@
-require_relative 'source_code'
-require_relative 'source_locator'
-
-module Reek
-  module Source
-    #
-    # A collection of source code. If the collection is initialized with an array
-    # it is assumed to be a list of file paths. Otherwise it is assumed to be a
-    # single unit of Ruby source code.
-    #
-    class SourceRepository
-      attr_reader :description
-
-      def initialize(description, sources)
-        @description = description
-        @sources     = sources
-      end
-
-      # TODO: This method is a least partially broken.
-      # Regardless of how you call reek, be it:
-      #   reek lib/
-      #   reek lib/file_one.rb lib/file_two.rb
-      #   echo "def m; end" | reek
-      # we *always* end up in the "when Source::SourceCode" branch.
-      # So it seems like 80% of this method is never used.
-      def self.parse(source)
-        case source
-        when Array
-          new 'dir', Source::SourceLocator.new(source).sources
-        when Source::SourceCode
-          new source.description, [source]
-        else
-          src = Source::SourceCode.from source
-          new src.description, [src]
-        end
-      end
-
-      def each(&block)
-        @sources.each(&block)
-      end
-    end
-  end
-end

data/spec/reek/cli/json_report_spec.rb

@@ -1,20 +0,0 @@
-require_relative '../../spec_helper'
-require_relative '../../../lib/reek/core/examiner'
-require_relative '../../../lib/reek/cli/report/report'
-require_relative '../../../lib/reek/cli/report/formatter'
-
-RSpec.describe Reek::CLI::Report::JSONReport do
-  let(:instance) { Reek::CLI::Report::JSONReport.new }
-
-  context 'empty source' do
-    let(:examiner) { Reek::Core::Examiner.new('') }
-
-    before do
-      instance.add_examiner examiner
-    end
-
-    it 'prints empty json' do
-      expect { instance.show }.to output(/^\[\]$/).to_stdout
-    end
-  end
-end

data/spec/reek/cli/yaml_report_spec.rb

@@ -1,20 +0,0 @@
-require_relative '../../spec_helper'
-require_relative '../../../lib/reek/core/examiner'
-require_relative '../../../lib/reek/cli/report/report'
-require_relative '../../../lib/reek/cli/report/formatter'
-
-RSpec.describe Reek::CLI::Report::YAMLReport do
-  let(:instance) { Reek::CLI::Report::YAMLReport.new }
-
-  context 'empty source' do
-    let(:examiner) { Reek::Core::Examiner.new('') }
-
-    before do
-      instance.add_examiner examiner
-    end
-
-    it 'prints empty yaml' do
-      expect { instance.show }.to output(/^--- \[\]\n.*$/).to_stdout
-    end
-  end
-end

data/spec/reek/core/object_source_spec.rb

@@ -1,18 +0,0 @@
-require_relative '../../spec_helper'
-
-RSpec.describe Dir do
-  it 'reports correct smells via the Dir matcher' do
-    files = Dir['spec/samples/two_smelly_files/*.rb']
-    expect(files).to reek
-    expect(files).to reek_of(:UncommunicativeVariableName)
-    expect(files).not_to reek_of(:LargeClass)
-  end
-
-  it 'copes with daft file specs' do
-    expect(Dir['spec/samples/two_smelly_files/*/.rb']).not_to reek
-  end
-
-  it 'copes with empty array' do
-    expect([]).not_to reek
-  end
-end

data/spec/reek/core/stop_context_spec.rb

@@ -1,14 +0,0 @@
-require_relative '../../spec_helper'
-require_relative '../../../lib/reek/core/stop_context'
-
-RSpec.describe Reek::Core::StopContext do
-  before :each do
-    @stop = Reek::Core::StopContext.new
-  end
-
-  context 'full_name' do
-    it 'reports full context' do
-      expect(@stop.full_name).to eq('')
-    end
-  end
-end

data/spec/reek/core/tree_dresser_spec.rb

@@ -1,16 +0,0 @@
-require_relative '../../spec_helper'
-require_relative '../../../lib/reek/core/tree_dresser'
-
-RSpec.describe Reek::Core::TreeDresser do
-  let(:ifnode) { Parser::AST::Node.new(:if) }
-  let(:sendnode) { Parser::AST::Node.new(:send) }
-  let(:dresser) { described_class.new }
-
-  it 'dresses :if sexp with IfNode' do
-    expect(dresser.dress(ifnode, {})).to be_a Reek::Sexp::SexpExtensions::IfNode
-  end
-
-  it 'dresses :send sexp with SendNode' do
-    expect(dresser.dress(sendnode, {})).to be_a Reek::Sexp::SexpExtensions::SendNode
-  end
-end