reek 2.0.4 → 2.1.0

data/spec/reek/source/tree_dresser_spec.rb

@@ -1,12 +1,10 @@
-require 'spec_helper'
-require 'reek/source/tree_dresser'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/source/tree_dresser'
 
-include Reek::Source
-
-describe TreeDresser do
+describe Reek::Source::TreeDresser do
   let(:ifnode) { Parser::AST::Node.new(:if) }
   let(:sendnode) { Parser::AST::Node.new(:send) }
-  let(:dresser) { TreeDresser.new }
+  let(:dresser) { Reek::Source::TreeDresser.new }
 
   it 'dresses :if sexp with IfNode' do
     expect(dresser.dress(ifnode, {})).to be_a Reek::Source::SexpExtensions::IfNode

data/spec/reek/spec/should_reek_of_spec.rb

@@ -1,10 +1,7 @@
-require 'spec_helper'
-require 'reek/spec'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/spec'
 
-include Reek
-include Reek::Spec
-
-describe ShouldReekOf do
+describe Reek::Spec::ShouldReekOf do
   context 'rdoc demo example' do
     before :each do
       @ruby = 'def double_thing() @other.thing.foo + @other.thing.foo end'
@@ -27,7 +24,8 @@ describe ShouldReekOf do
     before :each do
       @clean_code = 'def good() true; end'
       @smelly_code = 'def x() y = 4; end'
-      @matcher = ShouldReekOf.new(:UncommunicativeVariableName,  name: 'y')
+      @matcher = Reek::Spec::ShouldReekOf.new(:UncommunicativeVariableName,
+                                              name: 'y')
     end
 
     it 'matches a smelly String' do
@@ -47,7 +45,8 @@ describe ShouldReekOf do
   context 'passing in smell_details with unknown parameter name' do
     before :each do
       @smelly_code = 'def x() y = 4; end'
-      @matcher = ShouldReekOf.new(:UncommunicativeVariableName,  foo: 'y')
+      @matcher = Reek::Spec::ShouldReekOf.new(:UncommunicativeVariableName,
+                                              foo: 'y')
     end
 
     it 'raises ArgumentError' do
@@ -59,7 +58,8 @@ describe ShouldReekOf do
     before :each do
       @clean_dir = Dir['spec/samples/three_clean_files/*.rb']
       @smelly_dir = Dir['spec/samples/two_smelly_files/*.rb']
-      @matcher = ShouldReekOf.new(:UncommunicativeVariableName, name: '@s')
+      @matcher = Reek::Spec::ShouldReekOf.new(:UncommunicativeVariableName,
+                                              name: '@s')
     end
 
     it 'matches a smelly String' do
@@ -75,7 +75,8 @@ describe ShouldReekOf do
     before :each do
       @clean_file = File.new(Dir['spec/samples/three_clean_files/*.rb'][0])
       @smelly_file = File.new(Dir['spec/samples/two_smelly_files/*.rb'][0])
-      @matcher = ShouldReekOf.new(:UncommunicativeVariableName, name: '@s')
+      @matcher = Reek::Spec::ShouldReekOf.new(:UncommunicativeVariableName,
+                                              name: '@s')
     end
 
     it 'matches a smelly String' do

data/spec/reek/spec/should_reek_only_of_spec.rb

@@ -1,14 +1,11 @@
-require 'spec_helper'
-require 'reek/spec'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/spec'
 
-include Reek
-include Reek::Spec
-
-describe ShouldReekOnlyOf do
+describe Reek::Spec::ShouldReekOnlyOf do
   before :each do
     @expected_smell_type = :NestedIterators
     @expected_context_name = 'SmellyClass#big_method'
-    @matcher = ShouldReekOnlyOf.new(@expected_smell_type)
+    @matcher = Reek::Spec::ShouldReekOnlyOf.new(@expected_smell_type)
     @examiner = double('examiner').as_null_object
     expect(@examiner).to receive(:smells) { smells }
     @match = @matcher.matches_examiner?(@examiner)

data/spec/reek/spec/should_reek_spec.rb

@@ -1,11 +1,8 @@
-require 'spec_helper'
-require 'reek/spec'
+require_relative '../../spec_helper'
+require_relative '../../../lib/reek/spec'
 
-include Reek
-include Reek::Spec
-
-describe ShouldReek do
-  let(:matcher) { ShouldReek.new }
+describe Reek::Spec::ShouldReek do
+  let(:matcher) { Reek::Spec::ShouldReek.new }
 
   describe 'checking code in a string' do
     let(:clean_code) { 'def good() true; end' }

data/spec/samples/{overrides/masked/lower.reek → masked_by_dotfile/.reek}

@@ -1,7 +1,9 @@
 ---
 DuplicateMethodCall:
-  enabled: true
+  enabled: false
 UncommunicativeVariableName:
   enabled: false
 UncommunicativeMethodName:
   enabled: false
+UncommunicativeParameterName:
+  enabled: false

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
-require 'reek/spec'
-require 'reek/source/ast_node_class_map'
-require 'reek/configuration/app_configuration'
+require_relative '../lib/reek/spec'
+require_relative '../lib/reek/source/ast_node_class_map'
+require_relative '../lib/reek/configuration/app_configuration'
 
 require 'factory_girl'
 
@@ -31,7 +31,7 @@ module Helpers
 
   # :reek:UncommunicativeMethodName
   def s(type, *children)
-    @klass_map ||= Reek::Source::AstNodeClassMap.new
+    @klass_map ||= Reek::Source::ASTNodeClassMap.new
     @klass_map.klass_for(type).new(type, children)
   end
 

data/tasks/develop.rake

@@ -1,5 +1,5 @@
 require 'rake/clean'
-require 'reek/core/smell_repository'
+require_relative '../lib/reek/core/smell_repository'
 
 CONFIG_FILE = 'config/defaults.reek'
 

data/tasks/reek.rake

@@ -1,4 +1,4 @@
-require 'reek/rake/task'
+require_relative '../lib/reek/rake/task'
 
 Reek::Rake::Task.new do |t|
   t.fail_on_error = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 2.0.4
+  version: 2.1.0
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-07 00:00:00.000000000 Z
+date: 2015-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -26,6 +26,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
+- !ruby/object:Gem::Dependency
+  name: rainbow
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: require_all
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: unparser
   requirement: !ruby/object:Gem::Requirement
@@ -41,33 +69,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.2.2
 - !ruby/object:Gem::Dependency
-  name: rainbow
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :runtime
+        version: '4.2'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
-  name: require_all
+  name: aruba
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :runtime
+        version: 0.6.2
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 0.6.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -83,101 +111,89 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: cucumber
+  name: factory_girl
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.3.18
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.3.18
+        version: '4.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.8.7
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.8.7
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 0.30.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 0.30.0
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.29.0
+        version: 0.8.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.29.0
+        version: 0.8.7
 description: |2
       Reek is a tool that examines Ruby classes, modules and methods and reports
       any code smells it finds.
@@ -190,13 +206,20 @@ extra_rdoc_files:
 - CHANGELOG
 - License.txt
 files:
+- ".gitignore"
+- ".rubocop.yml"
+- ".ruby-gemset"
+- ".travis.yml"
 - ".yardopts"
 - CHANGELOG
+- CONTRIBUTING.md
+- Gemfile
 - License.txt
 - README.md
 - Rakefile
 - assets/html_output.html.erb
 - bin/reek
+- config/cucumber.yml
 - config/defaults.reek
 - features/command_line_interface/options.feature
 - features/command_line_interface/smell_selection.feature
@@ -205,15 +228,17 @@ files:
 - features/configuration_files/masking_smells.feature
 - features/configuration_files/overrides_defaults.feature
 - features/configuration_loading.feature
+- features/programmatic_access.feature
 - features/rake_task/rake_task.feature
 - features/reports/json.feature
 - features/reports/reports.feature
 - features/reports/yaml.feature
 - features/ruby_api/api.feature
 - features/samples.feature
+- features/step_definitions/.rubocop.yml
 - features/step_definitions/reek_steps.rb
+- features/step_definitions/sample_file_steps.rb
 - features/support/env.rb
-- features/support/hooks.rb
 - lib/reek.rb
 - lib/reek/cli/application.rb
 - lib/reek/cli/command.rb
@@ -266,17 +291,14 @@ files:
 - lib/reek/smells/uncommunicative_variable_name.rb
 - lib/reek/smells/unused_parameters.rb
 - lib/reek/smells/utility_function.rb
-- lib/reek/source.rb
 - lib/reek/source/ast_node.rb
 - lib/reek/source/ast_node_class_map.rb
 - lib/reek/source/code_comment.rb
-- lib/reek/source/core_extras.rb
 - lib/reek/source/reference_collector.rb
 - lib/reek/source/sexp_extensions.rb
 - lib/reek/source/sexp_formatter.rb
 - lib/reek/source/sexp_node.rb
 - lib/reek/source/source_code.rb
-- lib/reek/source/source_file.rb
 - lib/reek/source/source_locator.rb
 - lib/reek/source/source_repository.rb
 - lib/reek/source/tree_dresser.rb
@@ -355,55 +377,19 @@ files:
 - spec/samples/clean_due_to_masking/dirty_one.rb
 - spec/samples/clean_due_to_masking/dirty_two.rb
 - spec/samples/clean_due_to_masking/masked.reek
-- spec/samples/config/allow_duplication.reek
-- spec/samples/config/deeper_nested_iterators.reek
-- spec/samples/configuration_loading/minimal_dirty.rb
-- spec/samples/configuration_loading/reek-test-run-disable_smells.reek
-- spec/samples/configuration_loading/reek-test-run-enable_smells.reek
-- spec/samples/corrupt_config_file/corrupt.reek
-- spec/samples/corrupt_config_file/dirty.rb
-- spec/samples/demo/demo.rb
-- spec/samples/empty_config_file/dirty.rb
-- spec/samples/empty_config_file/empty.reek
 - spec/samples/exceptions.reek
 - spec/samples/inline.rb
-- spec/samples/inline_config/dirty.rb
-- spec/samples/inline_config/masked.reek
-- spec/samples/mask_some/dirty.rb
-- spec/samples/mask_some/some.reek
-- spec/samples/masked/dirty.rb
-- spec/samples/masked/masked.reek
+- spec/samples/masked_by_dotfile/.reek
 - spec/samples/masked_by_dotfile/dirty.rb
-- spec/samples/minimal_smelly_and_masked/config.reek
-- spec/samples/minimal_smelly_and_masked/minimal_dirty.rb
-- spec/samples/mixed_results/clean_one.rb
-- spec/samples/mixed_results/clean_three.rb
-- spec/samples/mixed_results/clean_two.rb
-- spec/samples/mixed_results/dirty_one.rb
-- spec/samples/mixed_results/dirty_two.rb
 - spec/samples/no_config_file/dirty.rb
-- spec/samples/not_quite_masked/dirty.rb
-- spec/samples/not_quite_masked/masked.reek
-- spec/samples/not_quite_masked/smelly.rb
-- spec/samples/one_smelly_file/dirty.rb
 - spec/samples/optparse.rb
-- spec/samples/overrides/masked/dirty.rb
-- spec/samples/overrides/masked/lower.reek
-- spec/samples/overrides/upper.reek
-- spec/samples/overrides_defaults/camel_case.rb
-- spec/samples/overrides_defaults/config.reek
 - spec/samples/redcloth.rb
 - spec/samples/ruby20_syntax.rb
 - spec/samples/ruby21_syntax.rb
 - spec/samples/simple_configuration.reek
-- spec/samples/standard_smelly/dirty.rb
-- spec/samples/standard_smelly/minimal_dirty.rb
 - spec/samples/three_clean_files/clean_one.rb
 - spec/samples/three_clean_files/clean_three.rb
 - spec/samples/three_clean_files/clean_two.rb
-- spec/samples/three_smelly_files/dirty_one.rb
-- spec/samples/three_smelly_files/dirty_three.rb
-- spec/samples/three_smelly_files/dirty_two.rb
 - spec/samples/two_smelly_files/dirty_one.rb
 - spec/samples/two_smelly_files/dirty_two.rb
 - spec/spec_helper.rb
@@ -411,7 +397,7 @@ files:
 - tasks/reek.rake
 - tasks/rubocop.rake
 - tasks/test.rake
-homepage: https://wiki.github.com/troessner/reek
+homepage: https://github.com/troessner/reek/wiki
 licenses:
 - MIT
 metadata: {}
@@ -434,8 +420,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: reek
-rubygems_version: 2.4.4
+rubyforge_project: 
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Code smell detector for Ruby