reek 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4119a0e66c059ea4a0d565bfab3ecfaeef3c722
-  data.tar.gz: 60149f1e3dda3e9f1b9f1e03f2287817ab9715ce
+  metadata.gz: 1877ecb6f7f04aa89c30beda81afb570a22b0edf
+  data.tar.gz: 9bb692ec4755c9402ce8bfa596e7333be0755573
 SHA512:
-  metadata.gz: de5e40087670fc35f74a341f9e50c477aa1deaeb914abe7466afe4ce53efaf9fb38633b814424cc50cc20aa08e1563f1e65169d159bc29b6e720f012d11b628b
-  data.tar.gz: ed3e2bddfbc5e369f1079da7e1a7684dc6ab28d1ad6d64625541587ec47c0173b7596de15ac4b26737401a6cb0d9ec82a8c0696cd88603e57772530254ead51f
+  metadata.gz: 16cd877bea8569bb5e55e30f825d076d62fa7a0a5f026fbf50f86150672f93517a881d71cd048670a3d2f029cacd88c27ceab2f21fe6aa65de2a0ce7995cb27f
+  data.tar.gz: cfd0ba532e2870abc0794fa173274b811a6a19de8ecf5adfd3f741c55cfec7aa70dc1263f4d183f584fc4c4f682ec9eed5b4d323bc996f5c1e2c5e654e7a5e14

data/CHANGELOG

@@ -1,3 +1,7 @@
+== 2.0.2
+
+* (troessner) Fix version command
+
 == 2.0.1
 
 * (leonelgalan) Add support for json reports

data/lib/reek/cli/options.rb

@@ -2,6 +2,7 @@ require 'optparse'
 require 'ostruct'
 require 'rainbow'
 require 'reek/cli/option_interpreter'
+require 'reek/version'
 
 module Reek
   module Cli

data/lib/reek/core/smell_repository.rb

@@ -13,12 +13,13 @@ module Reek
         Reek::Smells::SmellDetector.descendants
       end
 
-      def initialize(source_description, smell_types = self.class.smell_types)
+      def initialize(source_description = nil, smell_types = self.class.smell_types)
         @typed_detectors = nil
         @detectors = {}
         smell_types.each do |klass|
           @detectors[klass] = klass.new(source_description)
         end
+        Configuration::AppConfiguration.configure_smell_repository self
       end
 
       def configure(klass, config)

data/lib/reek/core/tree_walker.rb

@@ -11,9 +11,8 @@ module Reek
     #
     # SMELL: This class is responsible for counting statements and for feeding
     # each context to the smell repository.
-    # SMELL: This class has a name that doesn't match its responsibility.
     class TreeWalker
-      def initialize(smell_repository)
+      def initialize(smell_repository = Core::SmellRepository.new)
         @smell_repository = smell_repository
         @element = StopContext.new
       end

data/lib/reek/examiner.rb

@@ -1,10 +1,11 @@
-require 'reek/core/sniffer'
-require 'reek/core/warning_collector'
 require 'reek/source/source_repository'
+require 'reek/core/warning_collector'
+require 'reek/core/smell_repository'
+require 'reek/core/tree_walker'
 
 module Reek
   #
-  # Finds the active code smells in Ruby source code.
+  # Applies all available smell detectors to a source.
   #
   class Examiner
     #
@@ -23,20 +24,12 @@ module Reek
     #   each of which is opened and parsed for source code.
     #
     def initialize(source, smell_types_to_filter_by = [])
-      sources = Source::SourceRepository.parse(source)
-      @description = sources.description
-      @collector = Core::WarningCollector.new
-
-      smell_types = Core::SmellRepository.smell_types
-
-      if smell_types_to_filter_by.any?
-        smell_types.select! { |klass| smell_types_to_filter_by.include? klass.smell_type }
-      end
+      @sources      = Source::SourceRepository.parse(source)
+      @description  = @sources.description
+      @collector    = Core::WarningCollector.new
+      @smell_types  = eligible_smell_types(smell_types_to_filter_by)
 
-      sources.each do |src|
-        repository = Core::SmellRepository.new(src.desc, smell_types)
-        Core::Sniffer.new(src, repository).report_on(@collector)
-      end
+      run
     end
 
     #
@@ -61,5 +54,26 @@ module Reek
     def smelly?
       !smells.empty?
     end
+
+    private
+
+    def run
+      @sources.each do |source|
+        smell_repository = Core::SmellRepository.new(source.desc, @smell_types)
+        syntax_tree = source.syntax_tree
+        Core::TreeWalker.new(smell_repository).process(syntax_tree) if syntax_tree
+        smell_repository.report_on(@collector)
+      end
+    end
+
+    def eligible_smell_types(smell_types_to_filter_by = [])
+      if smell_types_to_filter_by.any?
+        Core::SmellRepository.smell_types.select do |klass|
+          smell_types_to_filter_by.include? klass.smell_type
+        end
+      else
+        Core::SmellRepository.smell_types
+      end
+    end
   end
 end

data/lib/reek/version.rb

@@ -3,6 +3,6 @@ module Reek
   # This module holds the Reek version informations
   #
   module Version
-    STRING = '2.0.1'
+    STRING = '2.0.2'
   end
 end

data/spec/factories/factories.rb

@@ -1,3 +1,5 @@
+require 'reek/smells'
+
 FactoryGirl.define do
   factory :smell_detector, class: Reek::Smells::SmellDetector do
     skip_create

data/spec/reek/smells/duplicate_method_call_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 require 'reek/smells/duplicate_method_call'
 require 'reek/core/code_context'
 require 'reek/core/tree_walker'
-require 'reek/core/sniffer'
 require 'reek/smells/smell_detector_shared'
 
 describe Reek::Smells::DuplicateMethodCall do

data/spec/reek/smells/feature_envy_spec.rb

@@ -230,8 +230,7 @@ describe Reek::Smells::FeatureEnvy do
         end
       EOS
       source = src.to_reek_source
-      sniffer = Reek::Core::Sniffer.new(source)
-      @mctx = Reek::Core::TreeWalker.new(sniffer).process_def(source.syntax_tree)
+      @mctx = Reek::Core::TreeWalker.new.process_def(source.syntax_tree)
       @smells = @detector.examine_context(@mctx)
     end
 

data/spec/reek/smells/smell_detector_shared.rb

@@ -9,6 +9,7 @@ shared_examples_for 'SmellDetector' do
       @ctx = double('context')
       allow(@ctx).to receive(:config_for).and_return({})
     end
+
     it 'when false' do
       expect(@ctx).to receive(:matches?).at_least(:once).and_return(false)
       expect(@detector.exception?(@ctx)).to eq(false)

data/spec/reek/smells/too_many_statements_spec.rb

@@ -2,16 +2,12 @@ require 'spec_helper'
 require 'reek/smells/too_many_statements'
 require 'reek/smells/smell_detector_shared'
 
-def process_method(src)
-  source = src.to_reek_source
-  sniffer = Reek::Core::Sniffer.new(source)
-  Reek::Core::TreeWalker.new(sniffer).process_def(source.syntax_tree)
+def process_method(source)
+  Reek::Core::TreeWalker.new.process_def(source.to_reek_source.syntax_tree)
 end
 
-def process_singleton_method(src)
-  source = src.to_reek_source
-  sniffer = Reek::Core::Sniffer.new(source)
-  Reek::Core::TreeWalker.new(sniffer).process_defs(source.syntax_tree)
+def process_singleton_method(source)
+  Reek::Core::TreeWalker.new.process_defs(source.to_reek_source.syntax_tree)
 end
 
 describe Reek::Smells::TooManyStatements do

data/spec/reek/smells/utility_function_spec.rb

@@ -119,8 +119,7 @@ describe Reek::Smells::UtilityFunction do
         end
       EOS
       source = src.to_reek_source
-      sniffer = Reek::Core::Sniffer.new(source)
-      mctx = Reek::Core::TreeWalker.new(sniffer).process_def(source.syntax_tree)
+      mctx = Reek::Core::TreeWalker.new.process_def(source.syntax_tree)
       @warning = @detector.examine_context(mctx)[0]   # SMELL: too cumbersome!
     end
 

data/tasks/develop.rake

@@ -1,10 +1,10 @@
 require 'rake/clean'
+require 'reek/core/smell_repository'
 
 CONFIG_FILE = 'config/defaults.reek'
 
 file CONFIG_FILE do
   config = {}
-  require 'reek/core/sniffer'
   Reek::Core::SmellRepository.smell_types.each do |klass|
     config[klass.name.split(/::/)[-1]] = klass.default_config
   end

data/tasks/reek.rake

@@ -3,5 +3,4 @@ require 'reek/rake/task'
 Reek::Rake::Task.new do |t|
   t.fail_on_error = true
   t.verbose = false
-  t.reek_opts = '--quiet'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Kevin Rutherford
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-03 00:00:00.000000000 Z
+date: 2015-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -234,7 +234,6 @@ files:
 - lib/reek/core/singleton_method_context.rb
 - lib/reek/core/smell_configuration.rb
 - lib/reek/core/smell_repository.rb
-- lib/reek/core/sniffer.rb
 - lib/reek/core/stop_context.rb
 - lib/reek/core/tree_walker.rb
 - lib/reek/core/warning_collector.rb
@@ -436,7 +435,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: reek
-rubygems_version: 2.4.4
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Code smell detector for Ruby

data/lib/reek/core/sniffer.rb

@@ -1,35 +0,0 @@
-require 'reek/core/tree_walker'
-require 'reek/core/smell_repository'
-require 'reek/configuration/app_configuration'
-
-module Reek
-  module Core
-    #
-    # Configures all available smell detectors and applies them to a source.
-    #
-    class Sniffer
-      def initialize(source, # Either Source::SourceFile or Source::SourceCode
-                     smell_repository = Core::SmellRepository.new(source.desc))
-        @smell_repository = smell_repository
-        @source = source
-
-        Configuration::AppConfiguration.configure_smell_repository(@smell_repository)
-      end
-
-      def report_on(listener)
-        TreeWalker.new(@smell_repository).process(syntax_tree) if syntax_tree
-        @smell_repository.report_on(listener)
-      end
-
-      def examine(scope, node_type)
-        @smell_repository.examine scope, node_type
-      end
-
-      private
-
-      def syntax_tree
-        @syntax_tree ||= @source.syntax_tree
-      end
-    end
-  end
-end