reek 2.0.0 → 2.0.1

data/spec/reek/smells/irresponsible_module_spec.rb

@@ -1,12 +1,13 @@
 require 'spec_helper'
+require 'reek/core/code_context'
 require 'reek/smells/irresponsible_module'
 require 'reek/smells/smell_detector_shared'
-include Reek::Smells
 
-describe IrresponsibleModule do
+describe Reek::Smells::IrresponsibleModule do
   before(:each) do
     @bad_module_name = 'WrongUn'
-    @detector = IrresponsibleModule.new('yoof')
+    @source_name = 'dummy_source'
+    @detector = build(:smell_detector, smell_type: :IrresponsibleModule, source: @source_name)
   end
 
   it_should_behave_like 'SmellDetector'
@@ -26,17 +27,17 @@ describe IrresponsibleModule do
       # test class
       class Responsible; end
     EOS
-    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
     expect(@detector.examine_context(ctx)).to be_empty
   end
 
   it 'reports a class without a comment' do
     src = "class #{@bad_module_name}; end"
-    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
     smells = @detector.examine_context(ctx)
     expect(smells.length).to eq(1)
-    expect(smells[0].smell_category).to eq(IrresponsibleModule.smell_category)
-    expect(smells[0].smell_type).to eq(IrresponsibleModule.smell_type)
+    expect(smells[0].smell_category).to eq(Reek::Smells::IrresponsibleModule.smell_category)
+    expect(smells[0].smell_type).to eq(Reek::Smells::IrresponsibleModule.smell_type)
     expect(smells[0].lines).to eq([1])
     expect(smells[0].parameters[:name]).to eq(@bad_module_name)
   end
@@ -48,7 +49,7 @@ describe IrresponsibleModule do
       #
       class #{@bad_module_name}; end
     EOS
-    expect(src).to reek_of IrresponsibleModule
+    expect(src).to reek_of :IrresponsibleModule
   end
 
   it 'reports a class with a preceding comment with intermittent material' do
@@ -64,11 +65,11 @@ describe IrresponsibleModule do
 
   it 'reports a fq module name correctly' do
     src = 'class Foo::Bar; end'
-    ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+    ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
     smells = @detector.examine_context(ctx)
     expect(smells.length).to eq(1)
-    expect(smells[0].smell_category).to eq(IrresponsibleModule.smell_category)
-    expect(smells[0].smell_type).to eq(IrresponsibleModule.smell_type)
+    expect(smells[0].smell_category).to eq(described_class.smell_category)
+    expect(smells[0].smell_type).to eq(described_class.smell_type)
     expect(smells[0].parameters[:name]).to eq('Foo::Bar')
     expect(smells[0].context).to match(/#{smells[0].parameters['name']}/)
   end

data/spec/reek/smells/long_parameter_list_spec.rb

@@ -1,45 +1,49 @@
 require 'spec_helper'
+require 'reek/core/code_context'
 require 'reek/smells/long_parameter_list'
 require 'reek/smells/smell_detector_shared'
 
-include Reek
-include Reek::Smells
-
-describe LongParameterList do
+describe Reek::Smells::LongParameterList do
   context 'for methods with few parameters' do
     it 'should report nothing for no parameters' do
-      expect('def simple; f(3);true; end').not_to reek_of(LongParameterList)
+      expect('def simple; f(3);true; end').not_to reek_of(:LongParameterList)
     end
+
     it 'should report nothing for 1 parameter' do
-      expect('def simple(yep) f(3);true end').not_to reek_of(LongParameterList)
+      expect('def simple(yep) f(3);true end').not_to reek_of(:LongParameterList)
     end
+
     it 'should report nothing for 2 parameters' do
-      expect('def simple(yep,zero) f(3);true end').not_to reek_of(LongParameterList)
+      expect('def simple(yep,zero) f(3);true end').not_to reek_of(:LongParameterList)
     end
+
     it 'should not count an optional block' do
       src = 'def simple(alpha, yep, zero, &opt) f(3); true end'
-      expect(src).not_to reek_of(LongParameterList)
+      expect(src).not_to reek_of(:LongParameterList)
     end
+
     it 'should not report inner block with too many parameters' do
       src = '
         def simple(yep,zero)
           m[3]; rand(34); f.each { |arga, argb, argc, argd| true}
         end
       '
-      expect(src).not_to reek_of(LongParameterList)
+      expect(src).not_to reek_of(:LongParameterList)
     end
 
     describe 'and default values' do
       it 'should report nothing for 1 parameter' do
-        expect('def simple(zero=nil) f(3);false end').not_to reek_of(LongParameterList)
+        expect('def simple(zero=nil) f(3);false end').not_to reek_of(:LongParameterList)
       end
+
       it 'should report nothing for 2 parameters with 1 default' do
         source = 'def simple(yep, zero=nil) f(3); false end'
-        expect(source).not_to reek_of(LongParameterList)
+        expect(source).not_to reek_of(:LongParameterList)
       end
+
       it 'should report nothing for 2 defaulted parameters' do
         source = 'def simple(yep=4, zero=nil) f(3); false end'
-        expect(source).not_to reek_of(LongParameterList)
+        expect(source).not_to reek_of(:LongParameterList)
       end
     end
   end
@@ -47,43 +51,45 @@ describe LongParameterList do
   describe 'for methods with too many parameters' do
     it 'should report 4 parameters' do
       src = 'def simple(arga, argb, argc, argd) f(3);true end'
-      expect(src).to reek_of(LongParameterList, count: 4)
+      expect(src).to reek_of(:LongParameterList, count: 4)
     end
+
     it 'should report 8 parameters' do
       src = 'def simple(arga, argb, argc, argd,arge, argf, argg, argh) f(3);true end'
-      expect(src).to reek_of(LongParameterList, count: 8)
+      expect(src).to reek_of(:LongParameterList, count: 8)
     end
 
     describe 'and default values' do
       it 'should report 3 with 1 defaulted' do
         src = 'def simple(polly, queue, yep, zero=nil) f(3);false end'
-        expect(src).to reek_of(LongParameterList, count: 4)
+        expect(src).to reek_of(:LongParameterList, count: 4)
       end
+
       it 'should report with 3 defaulted' do
         src = 'def simple(aarg, polly=2, yep=:truth, zero=nil) f(3);false end'
-        expect(src).to reek_of(LongParameterList, count: 4)
+        expect(src).to reek_of(:LongParameterList, count: 4)
       end
     end
   end
 end
 
-describe LongParameterList do
+describe Reek::Smells::LongParameterList do
   before(:each) do
-    @source_name = 'smokin'
-    @detector = LongParameterList.new(@source_name)
+    @source_name = 'dummy_source'
+    @detector = build(:smell_detector, smell_type: :LongParameterList, source: @source_name)
   end
 
   it_should_behave_like 'SmellDetector'
 
   context 'when a smell is reported' do
     before :each do
-      src = <<EOS
-def badguy(arga, argb, argc, argd)
-  f(3)
-  true
-end
-EOS
-      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      src = <<-EOS
+        def badguy(arga, argb, argc, argd)
+          f(3)
+          true
+        end
+      EOS
+      ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
       @smells = @detector.examine_context(ctx)
       @warning = @smells[0]
     end
@@ -93,6 +99,7 @@ EOS
     it 'reports the number of parameters' do
       expect(@warning.parameters[:count]).to eq(4)
     end
+
     it 'reports the line number of the method' do
       expect(@warning.lines).to eq([1])
     end

data/spec/reek/smells/long_yield_list_spec.rb

@@ -1,16 +1,12 @@
 require 'spec_helper'
+require 'reek/core/code_context'
 require 'reek/smells/long_yield_list'
 require 'reek/smells/smell_detector_shared'
 
-include Reek
-include Reek::Smells
-
-describe LongYieldList do
+describe Reek::Smells::LongYieldList do
   before(:each) do
-    @source_name = 'oo la la'
-    @detector = LongYieldList.new(@source_name)
-    # SMELL: can't use the default config, because that contains an override,
-    # which causes the mocked matches?() method to be called twice!!
+    @source_name = 'dummy_source'
+    @detector = build(:smell_detector, smell_type: :LongYieldList, source: @source_name)
   end
 
   it_should_behave_like 'SmellDetector'
@@ -18,31 +14,31 @@ describe LongYieldList do
   context 'yield' do
     it 'should not report yield with no parameters' do
       src = 'def simple(arga, argb, &blk) f(3);yield; end'
-      expect(src).not_to reek_of(LongYieldList)
+      expect(src).not_to reek_of(:LongYieldList)
     end
     it 'should not report yield with few parameters' do
       src = 'def simple(arga, argb, &blk) f(3);yield a,b; end'
-      expect(src).not_to reek_of(LongYieldList)
+      expect(src).not_to reek_of(:LongYieldList)
     end
     it 'should report yield with many parameters' do
       src = 'def simple(arga, argb, &blk) f(3);yield arga,argb,arga,argb; end'
-      expect(src).to reek_of(LongYieldList, count: 4)
+      expect(src).to reek_of(:LongYieldList, count: 4)
     end
     it 'should not report yield of a long expression' do
       src = 'def simple(arga, argb, &blk) f(3);yield(if @dec then argb else 5+3 end); end'
-      expect(src).not_to reek_of(LongYieldList)
+      expect(src).not_to reek_of(:LongYieldList)
     end
   end
 
   context 'when a smells is reported' do
     before :each do
-      src = <<EOS
-def simple(arga, argb, &blk)
-  f(3)
-  yield(arga,argb,arga,argb)
-  end
-EOS
-      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      src = <<-EOS
+        def simple(arga, argb, &blk)
+          f(3)
+          yield(arga,argb,arga,argb)
+          end
+      EOS
+      ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
       @smells = @detector.examine_context(ctx)
       @warning = @smells[0]
     end

data/spec/reek/smells/module_initialize_spec.rb

@@ -2,9 +2,7 @@ require 'spec_helper'
 require 'reek/smells/module_initialize'
 require 'reek/smells/smell_detector_shared'
 
-include Reek::Smells
-
-describe ModuleInitialize do
+describe Reek::Smells::ModuleInitialize do
   context 'module' do
     context 'with method named initialize' do
       it 'smells' do
@@ -13,7 +11,7 @@ describe ModuleInitialize do
             def initialize; end
           end
         EOF
-        expect(src).to reek_of(ModuleInitialize)
+        expect(src).to reek_of(:ModuleInitialize)
       end
     end
 
@@ -26,7 +24,7 @@ describe ModuleInitialize do
             end
           end
         EOF
-        expect(src).not_to reek_of(ModuleInitialize)
+        expect(src).not_to reek_of(:ModuleInitialize)
       end
     end
 
@@ -39,7 +37,7 @@ describe ModuleInitialize do
             end
           end
         EOF
-        expect(src).not_to reek_of(ModuleInitialize)
+        expect(src).not_to reek_of(:ModuleInitialize)
       end
     end
   end

data/spec/reek/smells/nested_iterators_spec.rb

@@ -2,26 +2,24 @@ require 'spec_helper'
 require 'reek/smells/nested_iterators'
 require 'reek/smells/smell_detector_shared'
 
-include Reek::Smells
-
-describe NestedIterators do
+describe Reek::Smells::NestedIterators do
   context 'with no iterators' do
     it 'reports no smells' do
       src = 'def fred() nothing = true; end'
-      expect(src).not_to reek_of(NestedIterators)
+      expect(src).not_to reek_of(:NestedIterators)
     end
   end
 
   context 'with one iterator' do
     it 'reports no smells' do
       src = 'def fred() nothing.each {|item| item}; end'
-      expect(src).not_to reek_of(NestedIterators)
+      expect(src).not_to reek_of(:NestedIterators)
     end
   end
 
   it 'should report nested iterators in a method' do
     src = 'def bad(fred) @fred.each {|item| item.each {|ting| ting.ting} } end'
-    expect(src).to reek_of(NestedIterators)
+    expect(src).to reek_of(:NestedIterators)
   end
 
   it 'should not report method with successive iterators' do
@@ -31,7 +29,7 @@ describe NestedIterators do
         @jim.each {|ting| ting.each }
       end
     EOS
-    expect(src).not_to reek_of(NestedIterators)
+    expect(src).not_to reek_of(:NestedIterators)
   end
 
   it 'should not report method with chained iterators' do
@@ -40,7 +38,7 @@ describe NestedIterators do
         @sig.keys.sort_by { |xray| xray.to_s }.each { |min| md5 << min.to_s }
       end
     EOS
-    expect(src).not_to reek_of(NestedIterators)
+    expect(src).not_to reek_of(:NestedIterators)
   end
 
   it 'detects an iterator with an empty block' do
@@ -49,7 +47,7 @@ describe NestedIterators do
         bar { baz { } }
       end
     EOS
-    expect(src).to reek_of(NestedIterators)
+    expect(src).to reek_of(:NestedIterators)
   end
 
   it 'should report nested iterators only once per method' do
@@ -59,7 +57,7 @@ describe NestedIterators do
         @jim.each {|ting| ting.each {|piece| @hal.send} }
       end
     EOS
-    expect(src).to reek_of(NestedIterators)
+    expect(src).to reek_of(:NestedIterators)
   end
 
   it 'reports nested iterators only once per method even if levels are different' do
@@ -69,7 +67,7 @@ describe NestedIterators do
         @jim.each {|ting| ting.each {|piece| piece.each {|atom| atom.foo } } }
       end
     EOS
-    expect(src).to reek_of(NestedIterators)
+    expect(src).to reek_of(:NestedIterators)
   end
 
   it 'reports nesting inside iterator arguments' do
@@ -84,7 +82,7 @@ describe NestedIterators do
         ) { |qux| qux.quuz }
       end
     EOS
-    expect(src).to reek_of(NestedIterators, count: 2)
+    expect(src).to reek_of(:NestedIterators, count: 2)
   end
 
   it 'reports the deepest level of nesting only' do
@@ -97,12 +95,13 @@ describe NestedIterators do
         }
       end
     EOS
-    expect(src).to reek_of(NestedIterators, count: 3)
+    expect(src).to reek_of(:NestedIterators, count: 3)
   end
 
   context 'when the allowed nesting depth is 3' do
     before :each do
-      @config = { NestedIterators: { NestedIterators::MAX_ALLOWED_NESTING_KEY => 3 } }
+      @config = { NestedIterators:
+                  { Reek::Smells::NestedIterators::MAX_ALLOWED_NESTING_KEY => 3 } }
     end
 
     it 'should not report nested iterators 2 levels deep' do
@@ -113,7 +112,7 @@ describe NestedIterators do
       EOS
 
       with_test_config(@config) do
-        expect(src).not_to reek_of(NestedIterators)
+        expect(src).not_to reek_of(:NestedIterators)
       end
     end
 
@@ -125,7 +124,7 @@ describe NestedIterators do
       EOS
 
       with_test_config(@config) do
-        expect(src).not_to reek_of(NestedIterators)
+        expect(src).not_to reek_of(:NestedIterators)
       end
     end
 
@@ -137,27 +136,28 @@ describe NestedIterators do
       EOS
 
       with_test_config(@config) do
-        expect(src).to reek_of(NestedIterators)
+        expect(src).to reek_of(:NestedIterators)
       end
     end
   end
 
   context 'when ignoring iterators' do
     before :each do
-      @config = { NestedIterators: { NestedIterators::IGNORE_ITERATORS_KEY => ['ignore_me'] } }
+      @config = { NestedIterators:
+                  { Reek::Smells::NestedIterators::IGNORE_ITERATORS_KEY => ['ignore_me'] } }
     end
 
     it 'should not report nesting the ignored iterator inside another' do
       src = 'def bad(fred) @fred.each {|item| item.ignore_me {|ting| ting.ting} } end'
       with_test_config(@config) do
-        expect(src).not_to reek_of(NestedIterators)
+        expect(src).not_to reek_of(:NestedIterators)
       end
     end
 
     it 'should not report nesting inside the ignored iterator' do
       src = 'def bad(fred) @fred.ignore_me {|item| item.each {|ting| ting.ting} } end'
       with_test_config(@config) do
-        expect(src).not_to reek_of(NestedIterators)
+        expect(src).not_to reek_of(:NestedIterators)
       end
     end
 
@@ -168,7 +168,7 @@ describe NestedIterators do
         end
       '
       with_test_config(@config) do
-        expect(src).to reek_of(NestedIterators, count: 2)
+        expect(src).to reek_of(:NestedIterators, count: 2)
       end
     end
 
@@ -179,7 +179,7 @@ describe NestedIterators do
         end
       '
       with_test_config(@config) do
-        expect(src).to reek_of(NestedIterators, count: 2)
+        expect(src).to reek_of(:NestedIterators, count: 2)
       end
     end
 
@@ -190,16 +190,16 @@ describe NestedIterators do
         end
       '
       with_test_config(@config) do
-        expect(src).to reek_of(NestedIterators, count: 2)
+        expect(src).to reek_of(:NestedIterators, count: 2)
       end
     end
   end
 end
 
-describe NestedIterators do
+describe Reek::Smells::NestedIterators do
   before(:each) do
-    @source_name = 'cuckoo'
-    @detector = NestedIterators.new(@source_name)
+    @source_name = 'dummy_source'
+    @detector = build(:smell_detector, smell_type: :NestedIterators, source: @source_name)
   end
 
   it_should_behave_like 'SmellDetector'
@@ -213,7 +213,7 @@ describe NestedIterators do
           end
         end
       EOS
-      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
       @warning = @detector.examine_context(ctx)[0]
     end
 
@@ -235,7 +235,7 @@ describe NestedIterators do
         end
       EOS
 
-      ctx = CodeContext.new(nil, src.to_reek_source.syntax_tree)
+      ctx = Reek::Core::CodeContext.new(nil, src.to_reek_source.syntax_tree)
       @warning = @detector.examine_context(ctx)[0]
     end