reek 1.3.6 → 1.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd6196b99429388642049ac970d159ca81066a08
-  data.tar.gz: 45ec008b56f8a42ca8edeaa9951ecc8b03fd5d7c
+  metadata.gz: a655ae03def5604c059ac663e271eecc1a18d461
+  data.tar.gz: 6f6c21e7d712a339e649ad91eabefea90c5a6d13
 SHA512:
-  metadata.gz: a09c19c44892cd6d2b8cc82b0fa82c8563fbed0c8734b8f12dfbb5906c223b664ab15e95cdeea8d2270004e06a182968d161bd644a044b157236e69141b8be80
-  data.tar.gz: a6ff074ebe7abd1a2029ffd6a3f04571ee75beb5709cef297a221bc37b3427fa84c5d53de767ccecf2f248e70a0cdf75fb8e363eb776ddec0b0aa9f1d2018c93
+  metadata.gz: 637e3a7af79aee3dd3d7e107d9de35ab2bac39b90f015b58ae8b21cd852a12613a7085d5217eb701ef0b78baa2f517566d21906006eba841dcc77e722ff6d171
+  data.tar.gz: 1f6f1923e86614fcb73d77e6a36e3c4f977db3bba059b785904042f27fa8fe7fecc5f568128597c432ee5ca42ea7b9c3ce5039b256f13bd87f46228136438d3d

data/CHANGELOG

@@ -1,3 +1,9 @@
+== 1.3.7
+
+* (gilles-leblanc) Add color to reek's output
+* (mvz) Ignore unused parameters if method calls super in nested context
+* (mvz) Only mark parameters uncommunicative if used
+
 == 1.3.6
 
 * (troessner) Add `Prima Donna Method` smell

data/README.md

@@ -1,9 +1,16 @@
 # Reek -- code smell detection for Ruby
 
-##Overview
+
+### Overview
+
 
 [![Build Status](https://secure.travis-ci.org/troessner/reek.png?branch=master)](http://travis-ci.org/troessner/reek?branch=master)
 [![Gem Version](https://badge.fury.io/rb/reek.png)](http://badge.fury.io/rb/reek)
+[![Dependency Status](https://gemnasium.com/troessner/reek.png)](https://gemnasium.com/troessner/reek)
+[![Inline docs](http://inch-pages.github.io/github/troessner/reek.png)](http://inch-pages.github.io/github/troessner/reek)
+
+
+### Synopsis
 
 
 Reek is a tool that examines Ruby classes, modules and methods and
@@ -131,6 +138,8 @@ There's a vim plugin for `reek`: [https://github.com/rainerborene/vim-reek](http
 
 TextMate Bundle for `reek`: [https://github.com/peeyush1234/reek.tmbundle](https://github.com/peeyush1234/reek.tmbundle)
 
+Colorful output for `reek`: [Preek](https://github.com/joenas/preek) (also with [Guard::Preek](https://github.com/joenas/guard-preek))
+
 ### Dependencies
 
 Reek makes use of the following other gems:
@@ -138,6 +147,7 @@ Reek makes use of the following other gems:
 * ruby_parser
 * sexp_processor
 * ruby2ruby
+* rainbow
 
 ### Learn More
 

data/config/defaults.reek

@@ -89,6 +89,7 @@ UncommunicativeParameterName:
   - !ruby/regexp /^.$/
   - !ruby/regexp /[0-9]$/
   - !ruby/regexp /[A-Z]/
+  - !ruby/regexp /^_/
   accept: []
 UncommunicativeVariableName:
   enabled: true

data/features/command_line_interface/options.feature

@@ -38,6 +38,7 @@ Feature: Reek can be controlled using command-line options
           -c, --config FILE                Read configuration options from FILE
 
       Report formatting:
+          -o, --[no-]color                 Use colors for the output (this is the default)
           -q, --quiet                      Suppress headings for smell-free source files (this is the default)
           -V, --no-quiet, --verbose        Show headings for smell-free source files
           -n, --no-line-numbers            Suppress line numbers from the output

data/features/rake_task/rake_task.feature

@@ -8,6 +8,7 @@ Feature: Reek can be driven through its Task
       """
       Reek::Rake::Task.new do |t|
         t.source_files = 'spec/samples/masked/dirty.rb'
+        t.reek_opts = '--no-color'
       end
       """
     Then the exit status indicates an error
@@ -24,6 +25,7 @@ Feature: Reek can be driven through its Task
       """
       Reek::Rake::Task.new('silky') do |t|
         t.source_files = 'spec/samples/masked/dirty.rb'
+        t.reek_opts = '--no-color'
       end
       """
     Then the exit status indicates an error
@@ -52,6 +54,7 @@ Feature: Reek can be driven through its Task
       Reek::Rake::Task.new do |t|
         t.fail_on_error = false
         t.source_files = 'spec/samples/no_config_file/dirty.rb'
+        t.reek_opts = '--no-color'
       end
       """
     Then it reports no errors

data/features/ruby_api/api.feature

@@ -9,12 +9,10 @@ Feature: The Reek API maintains backwards compatibility
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/demo/demo.rb -- 10 warnings:
+      spec/samples/demo/demo.rb -- 8 warnings:
         [1]:Dirty has no descriptive comment (IrresponsibleModule)
         [3]:Dirty#awful has 4 parameters (LongParameterList)
         [3]:Dirty#awful has boolean parameter 'log' (BooleanParameter)
-        [3]:Dirty#awful has the parameter name 'x' (UncommunicativeParameterName)
-        [3]:Dirty#awful has the parameter name 'y' (UncommunicativeParameterName)
         [5]:Dirty#awful has the variable name 'w' (UncommunicativeVariableName)
         [3]:Dirty#awful has unused parameter 'log' (UnusedParameters)
         [3]:Dirty#awful has unused parameter 'offset' (UnusedParameters)

data/features/samples.feature

@@ -10,8 +10,9 @@ Feature: Basic smell detection
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/inline.rb -- 39 warnings:
+    spec/samples/inline.rb -- 41 warnings:
       File has no descriptive comment (IrresponsibleModule)
+      File#self.write_with_backup has approx 6 statements (TooManyStatements)
       Inline declares the class variable @@directory (ClassVariable)
       Inline declares the class variable @@rootdir (ClassVariable)
       Inline#self.rootdir calls env.nil? twice (DuplicateMethodCall)
@@ -30,7 +31,7 @@ Feature: Basic smell detection
       Inline::C#build calls io.puts("#ifdef __cplusplus") twice (DuplicateMethodCall)
       Inline::C#build calls warn("Output:\n#{result}") twice (DuplicateMethodCall)
       Inline::C#build contains iterators nested 2 deep (NestedIterators)
-      Inline::C#build has approx 60 statements (TooManyStatements)
+      Inline::C#build has approx 63 statements (TooManyStatements)
       Inline::C#build has the variable name 'n' (UncommunicativeVariableName)
       Inline::C#build has the variable name 't' (UncommunicativeVariableName)
       Inline::C#c has the name 'c' (UncommunicativeMethodName)
@@ -38,18 +39,19 @@ Feature: Basic smell detection
       Inline::C#generate calls result.sub!(/\A\n/, "") twice (DuplicateMethodCall)
       Inline::C#generate calls signature["args"] twice (DuplicateMethodCall)
       Inline::C#generate calls signature["args"].map twice (DuplicateMethodCall)
-      Inline::C#generate has approx 32 statements (TooManyStatements)
+      Inline::C#generate has approx 35 statements (TooManyStatements)
       Inline::C#initialize calls stack.empty? twice (DuplicateMethodCall)
+      Inline::C#module_name has approx 7 statements (TooManyStatements)
       Inline::C#module_name has the variable name 'm' (UncommunicativeVariableName)
       Inline::C#module_name has the variable name 'x' (UncommunicativeVariableName)
-      Inline::C#parse_signature has approx 15 statements (TooManyStatements)
+      Inline::C#parse_signature has approx 16 statements (TooManyStatements)
       Inline::C#parse_signature has boolean parameter 'raw' (BooleanParameter)
       Inline::C#parse_signature has the variable name 'x' (UncommunicativeVariableName)
       Inline::C#parse_signature is controlled by argument raw (ControlParameter)
       Inline::C#strip_comments doesn't depend on instance state (UtilityFunction)
       Inline::C#strip_comments refers to src more than self (FeatureEnvy)
       Module#inline calls Inline.const_get(lang) twice (DuplicateMethodCall)
-      Module#inline has approx 11 statements (TooManyStatements)
+      Module#inline has approx 12 statements (TooManyStatements)
     """
 
   Scenario: Correct smells from optparse.rb
@@ -57,7 +59,7 @@ Feature: Basic smell detection
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/optparse.rb -- 103 warnings:
+    spec/samples/optparse.rb -- 108 warnings:
       OptionParser has at least 42 methods (TooManyMethods)
       OptionParser has the variable name 'f' (UncommunicativeVariableName)
       OptionParser has the variable name 'k' (UncommunicativeVariableName)
@@ -71,9 +73,11 @@ Feature: Basic smell detection
       OptionParser tests s at least 7 times (RepeatedConditional)
       OptionParser#complete contains iterators nested 2 deep (NestedIterators)
       OptionParser#complete has 4 parameters (LongParameterList)
+      OptionParser#complete has approx 6 statements (TooManyStatements)
       OptionParser#complete has boolean parameter 'icase' (BooleanParameter)
       OptionParser#getopts calls result[opt] = false twice (DuplicateMethodCall)
-      OptionParser#getopts has approx 17 statements (TooManyStatements)
+      OptionParser#getopts has approx 18 statements (TooManyStatements)
+      OptionParser#load has approx 6 statements (TooManyStatements)
       OptionParser#load has the variable name 's' (UncommunicativeVariableName)
       OptionParser#make_switch calls (long << (o = q.downcase)) twice (DuplicateMethodCall)
       OptionParser#make_switch calls (sdesc << "-#{q}") twice (DuplicateMethodCall)
@@ -87,7 +91,7 @@ Feature: Basic smell detection
       OptionParser#make_switch calls search(:atype, FalseClass) twice (DuplicateMethodCall)
       OptionParser#make_switch calls search(:atype, o) 6 times (DuplicateMethodCall)
       OptionParser#make_switch contains iterators nested 3 deep (NestedIterators)
-      OptionParser#make_switch has approx 68 statements (TooManyStatements)
+      OptionParser#make_switch has approx 72 statements (TooManyStatements)
       OptionParser#make_switch has the variable name 'a' (UncommunicativeVariableName)
       OptionParser#make_switch has the variable name 'c' (UncommunicativeVariableName)
       OptionParser#make_switch has the variable name 'n' (UncommunicativeVariableName)
@@ -108,19 +112,21 @@ Feature: Basic smell detection
       OptionParser#parse_in_order calls sw.block twice (DuplicateMethodCall)
       OptionParser#parse_in_order calls sw.switch_name twice (DuplicateMethodCall)
       OptionParser#parse_in_order contains iterators nested 3 deep (NestedIterators)
-      OptionParser#parse_in_order has approx 28 statements (TooManyStatements)
+      OptionParser#parse_in_order has approx 35 statements (TooManyStatements)
       OptionParser#permute calls argv[0] twice (DuplicateMethodCall)
       OptionParser#permute refers to argv more than self (FeatureEnvy)
+      OptionParser#permute! has approx 6 statements (TooManyStatements)
       OptionParser#search has the variable name 'k' (UncommunicativeVariableName)
       OptionParser#self.inc performs a nil-check. (NilCheck)
       OptionParser#summarize has 4 parameters (LongParameterList)
       OptionParser#summarize has the variable name 'l' (UncommunicativeVariableName)
       OptionParser#ver has the variable name 'v' (UncommunicativeVariableName)
+      OptionParser::Arguable#options has approx 6 statements (TooManyStatements)
       OptionParser::Arguable#options= is controlled by argument opt (ControlParameter)
       OptionParser::CompletingHash#match contains iterators nested 2 deep (NestedIterators)
       OptionParser::Completion#complete calls candidates.size twice (DuplicateMethodCall)
       OptionParser::Completion#complete calls k.id2name twice (DuplicateMethodCall)
-      OptionParser::Completion#complete has approx 22 statements (TooManyStatements)
+      OptionParser::Completion#complete has approx 23 statements (TooManyStatements)
       OptionParser::Completion#complete has boolean parameter 'icase' (BooleanParameter)
       OptionParser::Completion#complete has the variable name 'k' (UncommunicativeVariableName)
       OptionParser::Completion#complete has the variable name 'v' (UncommunicativeVariableName)
@@ -134,7 +140,7 @@ Feature: Basic smell detection
       OptionParser::List#reject has the parameter name 't' (UncommunicativeParameterName)
       OptionParser::List#summarize refers to opt more than self (FeatureEnvy)
       OptionParser::List#update has 5 parameters (LongParameterList)
-      OptionParser::List#update has approx 6 statements (TooManyStatements)
+      OptionParser::List#update has approx 10 statements (TooManyStatements)
       OptionParser::List#update has the variable name 'o' (UncommunicativeVariableName)
       OptionParser::ParseError#set_option is controlled by argument eq (ControlParameter)
       OptionParser::Switch#add_banner has the variable name 's' (UncommunicativeVariableName)
@@ -143,6 +149,7 @@ Feature: Basic smell detection
       OptionParser::Switch#parse_arg has approx 11 statements (TooManyStatements)
       OptionParser::Switch#parse_arg has the variable name 'm' (UncommunicativeVariableName)
       OptionParser::Switch#parse_arg has the variable name 's' (UncommunicativeVariableName)
+      OptionParser::Switch#self.guess has approx 6 statements (TooManyStatements)
       OptionParser::Switch#self.guess has the variable name 't' (UncommunicativeVariableName)
       OptionParser::Switch#self.incompatible_argument_styles has the parameter name 't' (UncommunicativeParameterName)
       OptionParser::Switch#summarize calls (indent + l) twice (DuplicateMethodCall)
@@ -154,7 +161,7 @@ Feature: Basic smell detection
       OptionParser::Switch#summarize calls s.length 3 times (DuplicateMethodCall)
       OptionParser::Switch#summarize contains iterators nested 2 deep (NestedIterators)
       OptionParser::Switch#summarize has 5 parameters (LongParameterList)
-      OptionParser::Switch#summarize has approx 25 statements (TooManyStatements)
+      OptionParser::Switch#summarize has approx 28 statements (TooManyStatements)
       OptionParser::Switch#summarize has the variable name 'l' (UncommunicativeVariableName)
       OptionParser::Switch#summarize has the variable name 'r' (UncommunicativeVariableName)
       OptionParser::Switch#summarize has the variable name 's' (UncommunicativeVariableName)
@@ -189,21 +196,21 @@ Feature: Basic smell detection
       RedCloth#block_textile_lists calls lines[(line_id - 1)] twice (DuplicateMethodCall)
       RedCloth#block_textile_lists calls tl.length 3 times (DuplicateMethodCall)
       RedCloth#block_textile_lists contains iterators nested 3 deep (NestedIterators)
-      RedCloth#block_textile_lists has approx 20 statements (TooManyStatements)
+      RedCloth#block_textile_lists has approx 21 statements (TooManyStatements)
       RedCloth#block_textile_lists has the variable name 'i' (UncommunicativeVariableName)
       RedCloth#block_textile_lists has the variable name 'v' (UncommunicativeVariableName)
       RedCloth#block_textile_lists refers to depth more than self (FeatureEnvy)
       RedCloth#block_textile_table contains iterators nested 3 deep (NestedIterators)
-      RedCloth#block_textile_table has approx 18 statements (TooManyStatements)
+      RedCloth#block_textile_table has approx 19 statements (TooManyStatements)
       RedCloth#block_textile_table has the variable name 'x' (UncommunicativeVariableName)
       RedCloth#blocks contains iterators nested 2 deep (NestedIterators)
-      RedCloth#blocks has approx 18 statements (TooManyStatements)
+      RedCloth#blocks has approx 19 statements (TooManyStatements)
       RedCloth#blocks has boolean parameter 'deep_code' (BooleanParameter)
       RedCloth#blocks is controlled by argument deep_code (ControlParameter)
       RedCloth#clean_html calls tags[tag] twice (DuplicateMethodCall)
       RedCloth#clean_html contains iterators nested 3 deep (NestedIterators)
       RedCloth#clean_html doesn't depend on instance state (UtilityFunction)
-      RedCloth#clean_html has approx 14 statements (TooManyStatements)
+      RedCloth#clean_html has approx 15 statements (TooManyStatements)
       RedCloth#clean_html has the variable name 'q' (UncommunicativeVariableName)
       RedCloth#clean_html has the variable name 'q2' (UncommunicativeVariableName)
       RedCloth#clean_html refers to raw more than self (FeatureEnvy)
@@ -233,7 +240,7 @@ Feature: Basic smell detection
       RedCloth#inline_textile_link has approx 9 statements (TooManyStatements)
       RedCloth#inline_textile_link has the variable name 'm' (UncommunicativeVariableName)
       RedCloth#inline_textile_span contains iterators nested 2 deep (NestedIterators)
-      RedCloth#inline_textile_span has approx 8 statements (TooManyStatements)
+      RedCloth#inline_textile_span has approx 9 statements (TooManyStatements)
       RedCloth#inline_textile_span has the variable name 'm' (UncommunicativeVariableName)
       RedCloth#lT has the name 'lT' (UncommunicativeMethodName)
       RedCloth#lT is controlled by argument text (ControlParameter)
@@ -266,15 +273,15 @@ Feature: Basic smell detection
       RedCloth#textile_p has unused parameter 'cite' (UnusedParameters)
       RedCloth#textile_popup_help has the parameter name 'windowH' (UncommunicativeParameterName)
       RedCloth#textile_popup_help has the parameter name 'windowW' (UncommunicativeParameterName)
-      RedCloth#to_html has approx 24 statements (TooManyStatements)
+      RedCloth#to_html has approx 26 statements (TooManyStatements)
     """
 
+  @ruby20
   Scenario: Correct smells from a source file with Ruby 2.0 specific syntax
     When I run reek spec/samples/ruby20_syntax.rb
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/ruby20_syntax.rb -- 2 warnings:
+    spec/samples/ruby20_syntax.rb -- 1 warning:
       [1]:SomeClass has no descriptive comment (IrresponsibleModule)
-      [2]:SomeClass#method_with_keyword_arguments has unused parameter 'foo' (UnusedParameters)
     """

data/features/support/env.rb

@@ -15,11 +15,11 @@ class ReekWorld
   end
 
   def reek(args)
-    run("ruby -Ilib -rubygems bin/reek #{args}")
+    run("ruby -Ilib -rubygems bin/reek --no-color #{args}")
   end
 
   def reek_with_pipe(stdin, args)
-    run("echo \"#{stdin}\" | ruby -Ilib -rubygems bin/reek #{args}")
+    run("echo \"#{stdin}\" | ruby -Ilib -rubygems bin/reek --no-color #{args}")
   end
 
   def rake(name, task_def)

data/lib/reek/cli/application.rb

@@ -41,10 +41,6 @@ module Reek
       def report_smells
         @status = STATUS_SMELLS
       end
-
-      def update_status(reporter)
-        reporter.has_smells? ? report_smells : report_success
-      end
     end
   end
 end

data/lib/reek/cli/command_line.rb

@@ -1,9 +1,9 @@
 require 'optparse'
+require 'rainbow'
 require 'reek/cli/report'
 require 'reek/cli/reek_command'
 require 'reek/cli/help_command'
 require 'reek/cli/version_command'
-require 'reek/cli/yaml_command'
 require 'reek/source'
 
 module Reek
@@ -17,9 +17,11 @@ module Reek
       def initialize(argv)
         @argv = argv
         @parser = OptionParser.new
+        @colored = true
         @report_class = QuietReport
         @warning_formatter = WarningFormatterWithLineNumbers
         @command_class = ReekCommand
+        @format = Report::DefaultFormat
         @config_files = []
         @sort_by_issue_count = false
         set_options
@@ -73,6 +75,9 @@ EOB
         end
 
         @parser.separator "\nReport formatting:"
+        @parser.on("-o", "--[no-]color", "Use colors for the output (this is the default)") do |opt|
+          @colored = opt
+        end
         @parser.on("-q", "--quiet", "Suppress headings for smell-free source files (this is the default)") do |opt|
           @report_class = QuietReport
         end
@@ -92,10 +97,7 @@ EOB
           @sort_by_issue_count = true
         end
         @parser.on("-y", "--yaml", "Report smells in YAML format") do
-          @command_class = YamlCommand
-          # SMELL: the args passed to the command should be tested, because it may
-          # turn out that they are passed too soon, ie. before the files have been
-          # separated out from the options
+          @format = :yaml
         end
       end
 
@@ -106,13 +108,9 @@ EOB
         elsif @command_class == VersionCommand
           VersionCommand.new(@parser.program_name)
         else
-          sources = get_sources
-          if @command_class == YamlCommand
-            YamlCommand.create(sources, @config_files)
-          else
-            reporter = @report_class.new(@warning_formatter, ReportFormatter, @sort_by_issue_count)
-            ReekCommand.create(sources, reporter, @config_files)
-          end
+          Rainbow.enabled = @colored
+          reporter = @report_class.new(@warning_formatter, ReportFormatter, @sort_by_issue_count, @format)
+          ReekCommand.create(get_sources, reporter, @config_files)
         end
       end
 

data/lib/reek/cli/reek_command.rb

@@ -22,7 +22,7 @@ module Reek
         @sources.each do |source|
           @reporter.add_examiner(Examiner.new(source, @config_files))
         end
-        app.update_status(@reporter)
+        @reporter.has_smells? ? app.report_smells : app.report_success
         @reporter.show
       end
     end

data/lib/reek/cli/report.rb

@@ -1,3 +1,5 @@
+require 'rainbow'
+
 module Reek
   module Cli
     module ReportFormatter
@@ -9,8 +11,8 @@ module Reek
 
       def self.header(examiner)
         count = examiner.smells_count
-        result = "#{examiner.description} -- #{count} warning"
-        result += 's' unless count == 1
+        result = Rainbow("#{examiner.description} -- ").cyan + Rainbow("#{count} warning").yellow
+        result += Rainbow('s').yellow unless count == 1
         result
       end
     end
@@ -33,13 +35,19 @@ module Reek
       end
     end
 
+    #
+    # A report that contains the smells and smell counts following source code analysis.
+    #
     class Report
-      def initialize(warning_formatter = SimpleWarningFormatter, report_formatter = ReportFormatter, sort_by_issue_count = false)
+      DefaultFormat = :text
+
+      def initialize(warning_formatter = SimpleWarningFormatter, report_formatter = ReportFormatter, sort_by_issue_count = false, format = DefaultFormat)
         @warning_formatter   = warning_formatter
         @report_formatter    = report_formatter
         @examiners           = []
         @total_smell_count   = 0
         @sort_by_issue_count = sort_by_issue_count
+        @format              = format
       end
 
       def add_examiner(examiner)
@@ -49,9 +57,18 @@ module Reek
       end
 
       def show
-        sort_examiners
-        display_summary
-        display_total_smell_count
+        case @format
+        when DefaultFormat
+          sort_examiners
+          display_summary
+          display_total_smell_count
+        when :yaml
+          if all_smells.size > 0
+            print(all_smells.to_yaml)
+          else
+            print ''
+          end
+        end
       end
 
       def has_smells?
@@ -60,8 +77,13 @@ module Reek
 
     private
 
+      def all_smells
+        @all_smells ||= @examiners.each_with_object([]) { |examiner, smells| smells << examiner.smells }
+                                  .flatten
+      end
+
       def sort_examiners
-        @examiners.sort! {|a, b| b.smells_count <=> a.smells_count } if @sort_by_issue_count
+        @examiners.sort! {|first, second| second.smells_count <=> first.smells_count } if @sort_by_issue_count
       end
 
       def display_summary
@@ -76,7 +98,7 @@ module Reek
       end
 
       def total_smell_count_message
-        "#{@total_smell_count} total warning#{'s' unless @total_smell_count == 1 }\n"
+        Rainbow("#{@total_smell_count} total warning#{'s' unless @total_smell_count == 1 }\n").red
       end
 
       def summarize_single_examiner(examiner)
@@ -89,6 +111,9 @@ module Reek
       end
     end
 
+    #
+    # A report that lists smell-free source files.
+    #
     class VerboseReport < Report
       def gather_results
         @examiners.each_with_object([]) do |examiner, result|
@@ -97,6 +122,9 @@ module Reek
       end
     end
 
+    #
+    # A report that does not list smell-free source files.
+    #
     class QuietReport < Report
       def gather_results
         @examiners.each_with_object([]) do |examiner, result|