reek 1.3.4 → 1.3.5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG +5 -0
- data/README.md +27 -2
- data/features/command_line_interface/options.feature +5 -2
- data/features/command_line_interface/smells_count.feature +43 -45
- data/features/command_line_interface/stdin.feature +9 -15
- data/features/configuration_files/masking_smells.feature +9 -17
- data/features/rake_task/rake_task.feature +4 -4
- data/features/reports/reports.feature +80 -21
- data/features/samples.feature +8 -18
- data/features/step_definitions/reek_steps.rb +4 -0
- data/lib/reek/cli/application.rb +3 -6
- data/lib/reek/cli/command_line.rb +16 -6
- data/lib/reek/cli/reek_command.rb +4 -12
- data/lib/reek/cli/report.rb +61 -19
- data/lib/reek/config_file_exception.rb +5 -0
- data/lib/reek/smells/control_parameter.rb +45 -14
- data/lib/reek/smells/data_clump.rb +15 -39
- data/lib/reek/smells/duplicate_method_call.rb +76 -26
- data/lib/reek/source/config_file.rb +30 -19
- data/lib/reek/source/sexp_extensions.rb +139 -0
- data/lib/reek/source/sexp_node.rb +64 -0
- data/lib/reek/source/source_code.rb +1 -1
- data/lib/reek/source/tree_dresser.rb +30 -175
- data/lib/reek/spec/should_reek.rb +2 -5
- data/lib/reek/version.rb +1 -1
- data/reek.gemspec +1 -1
- data/spec/matchers/smell_of_matcher.rb +12 -15
- data/spec/reek/cli/report_spec.rb +10 -6
- data/spec/reek/core/code_parser_spec.rb +0 -6
- data/spec/reek/smells/control_parameter_spec.rb +195 -8
- data/spec/reek/smells/data_clump_spec.rb +28 -3
- data/spec/reek/smells/uncommunicative_method_name_spec.rb +7 -7
- data/spec/reek/source/sexp_extensions_spec.rb +290 -0
- data/spec/reek/source/sexp_node_spec.rb +28 -0
- data/spec/reek/source/source_code_spec.rb +59 -19
- data/spec/reek/source/tree_dresser_spec.rb +7 -314
- data/spec/reek/spec/should_reek_spec.rb +51 -64
- data/spec/samples/all_but_one_masked/dirty.rb +2 -2
- data/spec/samples/corrupt_config_file/dirty.rb +1 -0
- data/spec/samples/masked/dirty.rb +1 -1
- data/spec/samples/masked_by_dotfile/dirty.rb +2 -2
- data/spec/samples/no_config_file/dirty.rb +8 -0
- data/spec/samples/not_quite_masked/dirty.rb +0 -3
- data/spec/samples/three_smelly_files/dirty_one.rb +3 -0
- data/spec/samples/three_smelly_files/dirty_three.rb +5 -0
- data/spec/samples/three_smelly_files/dirty_two.rb +4 -0
- data/spec/spec_helper.rb +5 -0
- metadata +145 -137
- data/spec/reek/cli/reek_command_spec.rb +0 -46
| @@ -4,83 +4,70 @@ require 'reek/spec' | |
| 4 4 | 
             
            include Reek
         | 
| 5 5 | 
             
            include Reek::Spec
         | 
| 6 6 |  | 
| 7 | 
            -
            describe ShouldReek | 
| 8 | 
            -
               | 
| 9 | 
            -
                @clean_code = 'def good() true; end'
         | 
| 10 | 
            -
                @smelly_code = 'def x() y = 4; end'
         | 
| 11 | 
            -
                @matcher = ShouldReek.new
         | 
| 12 | 
            -
              end
         | 
| 7 | 
            +
            describe ShouldReek do
         | 
| 8 | 
            +
              let(:matcher) { ShouldReek.new }
         | 
| 13 9 |  | 
| 14 | 
            -
               | 
| 15 | 
            -
                 | 
| 16 | 
            -
             | 
| 10 | 
            +
              describe 'checking code in a string' do
         | 
| 11 | 
            +
                let(:clean_code) { 'def good() true; end' }
         | 
| 12 | 
            +
                let(:smelly_code) { 'def x() y = 4; end' }
         | 
| 17 13 |  | 
| 18 | 
            -
             | 
| 19 | 
            -
             | 
| 20 | 
            -
             | 
| 14 | 
            +
                it 'matches a smelly String' do
         | 
| 15 | 
            +
                  matcher.matches?(smelly_code).should be_true
         | 
| 16 | 
            +
                end
         | 
| 21 17 |  | 
| 22 | 
            -
             | 
| 23 | 
            -
             | 
| 24 | 
            -
                 | 
| 25 | 
            -
              end
         | 
| 26 | 
            -
            end
         | 
| 18 | 
            +
                it 'doesnt match a fragrant String' do
         | 
| 19 | 
            +
                  matcher.matches?(clean_code).should be_false
         | 
| 20 | 
            +
                end
         | 
| 27 21 |  | 
| 28 | 
            -
             | 
| 29 | 
            -
             | 
| 30 | 
            -
             | 
| 31 | 
            -
                 | 
| 32 | 
            -
                @matcher = ShouldReek.new
         | 
| 22 | 
            +
                it 'reports the smells when should_not fails' do
         | 
| 23 | 
            +
                  matcher.matches?(smelly_code)
         | 
| 24 | 
            +
                  matcher.failure_message_for_should_not.should match('UncommunicativeVariableName')
         | 
| 25 | 
            +
                end
         | 
| 33 26 | 
             
              end
         | 
| 34 27 |  | 
| 35 | 
            -
               | 
| 36 | 
            -
                 | 
| 37 | 
            -
             | 
| 28 | 
            +
              describe 'checking code in a Dir' do
         | 
| 29 | 
            +
                let(:clean_dir) { Dir['spec/samples/three_clean_files/*.rb'] }
         | 
| 30 | 
            +
                let(:smelly_dir) { Dir['spec/samples/two_smelly_files/*.rb'] }
         | 
| 31 | 
            +
                let(:masked_dir) { Dir['spec/samples/clean_due_to_masking/*.rb'] }
         | 
| 38 32 |  | 
| 39 | 
            -
             | 
| 40 | 
            -
             | 
| 41 | 
            -
             | 
| 33 | 
            +
                it 'matches a smelly Dir' do
         | 
| 34 | 
            +
                  matcher.matches?(smelly_dir).should be_true
         | 
| 35 | 
            +
                end
         | 
| 42 36 |  | 
| 43 | 
            -
             | 
| 44 | 
            -
             | 
| 45 | 
            -
                 | 
| 46 | 
            -
              end
         | 
| 47 | 
            -
            end
         | 
| 37 | 
            +
                it 'doesnt match a fragrant Dir' do
         | 
| 38 | 
            +
                  matcher.matches?(clean_dir).should be_false
         | 
| 39 | 
            +
                end
         | 
| 48 40 |  | 
| 49 | 
            -
             | 
| 50 | 
            -
             | 
| 51 | 
            -
                 | 
| 52 | 
            -
                @smelly_file = File.new(Dir['spec/samples/two_smelly_files/*.rb'][0])
         | 
| 53 | 
            -
                @matcher = ShouldReek.new
         | 
| 54 | 
            -
              end
         | 
| 41 | 
            +
                it 'masks smells using the relevant configuration' do
         | 
| 42 | 
            +
                  matcher.matches?(masked_dir).should be_false
         | 
| 43 | 
            +
                end
         | 
| 55 44 |  | 
| 56 | 
            -
             | 
| 57 | 
            -
             | 
| 45 | 
            +
                it 'reports the smells when should_not fails' do
         | 
| 46 | 
            +
                  matcher.matches?(smelly_dir)
         | 
| 47 | 
            +
                  matcher.failure_message_for_should_not.should match('UncommunicativeVariableName')
         | 
| 48 | 
            +
                end
         | 
| 58 49 | 
             
              end
         | 
| 59 50 |  | 
| 60 | 
            -
               | 
| 61 | 
            -
                 | 
| 62 | 
            -
             | 
| 51 | 
            +
              describe 'checking code in a File' do
         | 
| 52 | 
            +
                let(:clean_file) { File.new('spec/samples/three_clean_files/clean_one.rb') }
         | 
| 53 | 
            +
                let(:smelly_file) { File.new('spec/samples/two_smelly_files/dirty_one.rb') }
         | 
| 54 | 
            +
                let(:masked_file) { File.new('spec/samples/clean_due_to_masking/dirty_one.rb') }
         | 
| 63 55 |  | 
| 64 | 
            -
             | 
| 65 | 
            -
             | 
| 66 | 
            -
                 | 
| 67 | 
            -
              end
         | 
| 68 | 
            -
            end
         | 
| 56 | 
            +
                it 'matches a smelly File' do
         | 
| 57 | 
            +
                  matcher.matches?(smelly_file).should be_true
         | 
| 58 | 
            +
                end
         | 
| 69 59 |  | 
| 70 | 
            -
             | 
| 71 | 
            -
             | 
| 72 | 
            -
                 | 
| 73 | 
            -
             | 
| 74 | 
            -
             | 
| 75 | 
            -
             | 
| 76 | 
            -
                 | 
| 77 | 
            -
             | 
| 78 | 
            -
             | 
| 79 | 
            -
             | 
| 80 | 
            -
             | 
| 81 | 
            -
             | 
| 82 | 
            -
              it 'ignores smells according to config' do
         | 
| 83 | 
            -
                matcher = ShouldReek.new(Dir['spec/samples/*.reek'])
         | 
| 84 | 
            -
                matcher.matches?('def hash() md5 = Digest::MD5.new; end').should be_false
         | 
| 60 | 
            +
                it 'doesnt match a fragrant File' do
         | 
| 61 | 
            +
                  matcher.matches?(clean_file).should be_false
         | 
| 62 | 
            +
                end
         | 
| 63 | 
            +
             | 
| 64 | 
            +
                it 'masks smells using the relevant configuration' do
         | 
| 65 | 
            +
                  matcher.matches?(masked_file).should be_false
         | 
| 66 | 
            +
                end
         | 
| 67 | 
            +
             | 
| 68 | 
            +
                it 'reports the smells when should_not fails' do
         | 
| 69 | 
            +
                  matcher.matches?(smelly_file)
         | 
| 70 | 
            +
                  matcher.failure_message_for_should_not.should match('UncommunicativeVariableName')
         | 
| 71 | 
            +
                end
         | 
| 85 72 | 
             
              end
         | 
| 86 73 | 
             
            end
         | 
    
        data/spec/spec_helper.rb
    CHANGED
    
    
    
        metadata
    CHANGED
    
    | @@ -1,7 +1,7 @@ | |
| 1 1 | 
             
            --- !ruby/object:Gem::Specification
         | 
| 2 2 | 
             
            name: reek
         | 
| 3 3 | 
             
            version: !ruby/object:Gem::Version
         | 
| 4 | 
            -
              version: 1.3. | 
| 4 | 
            +
              version: 1.3.5
         | 
| 5 5 | 
             
            platform: ruby
         | 
| 6 6 | 
             
            authors:
         | 
| 7 7 | 
             
            - Kevin Rutherford
         | 
| @@ -10,7 +10,7 @@ authors: | |
| 10 10 | 
             
            autorequire: 
         | 
| 11 11 | 
             
            bindir: bin
         | 
| 12 12 | 
             
            cert_chain: []
         | 
| 13 | 
            -
            date: 2013- | 
| 13 | 
            +
            date: 2013-12-23 00:00:00.000000000 Z
         | 
| 14 14 | 
             
            dependencies:
         | 
| 15 15 | 
             
            - !ruby/object:Gem::Dependency
         | 
| 16 16 | 
             
              name: ruby_parser
         | 
| @@ -46,14 +46,14 @@ dependencies: | |
| 46 46 | 
             
                requirements:
         | 
| 47 47 | 
             
                - - ~>
         | 
| 48 48 | 
             
                  - !ruby/object:Gem::Version
         | 
| 49 | 
            -
                    version: 2.0. | 
| 49 | 
            +
                    version: 2.0.7
         | 
| 50 50 | 
             
              type: :runtime
         | 
| 51 51 | 
             
              prerelease: false
         | 
| 52 52 | 
             
              version_requirements: !ruby/object:Gem::Requirement
         | 
| 53 53 | 
             
                requirements:
         | 
| 54 54 | 
             
                - - ~>
         | 
| 55 55 | 
             
                  - !ruby/object:Gem::Version
         | 
| 56 | 
            -
                    version: 2.0. | 
| 56 | 
            +
                    version: 2.0.7
         | 
| 57 57 | 
             
            - !ruby/object:Gem::Dependency
         | 
| 58 58 | 
             
              name: bundler
         | 
| 59 59 | 
             
              requirement: !ruby/object:Gem::Requirement
         | 
| @@ -157,184 +157,192 @@ files: | |
| 157 157 | 
             
            - Rakefile
         | 
| 158 158 | 
             
            - bin/reek
         | 
| 159 159 | 
             
            - config/defaults.reek
         | 
| 160 | 
            -
            - features/ | 
| 161 | 
            -
            - features/configuration_files/masking_smells.feature
         | 
| 162 | 
            -
            - features/configuration_files/overrides_defaults.feature
         | 
| 163 | 
            -
            - features/samples.feature
         | 
| 164 | 
            -
            - features/reports/yaml.feature
         | 
| 165 | 
            -
            - features/reports/reports.feature
         | 
| 166 | 
            -
            - features/command_line_interface/options.feature
         | 
| 160 | 
            +
            - features/ruby_api/api.feature
         | 
| 167 161 | 
             
            - features/command_line_interface/smells_count.feature
         | 
| 168 162 | 
             
            - features/command_line_interface/stdin.feature
         | 
| 163 | 
            +
            - features/command_line_interface/options.feature
         | 
| 169 164 | 
             
            - features/step_definitions/reek_steps.rb
         | 
| 165 | 
            +
            - features/support/env.rb
         | 
| 166 | 
            +
            - features/samples.feature
         | 
| 167 | 
            +
            - features/reports/reports.feature
         | 
| 168 | 
            +
            - features/reports/yaml.feature
         | 
| 169 | 
            +
            - features/configuration_files/masking_smells.feature
         | 
| 170 | 
            +
            - features/configuration_files/overrides_defaults.feature
         | 
| 170 171 | 
             
            - features/rake_task/rake_task.feature
         | 
| 171 | 
            -
            -  | 
| 172 | 
            +
            - lib/reek.rb
         | 
| 173 | 
            +
            - lib/reek/spec.rb
         | 
| 172 174 | 
             
            - lib/reek/spec/should_reek_of.rb
         | 
| 173 175 | 
             
            - lib/reek/spec/should_reek_only_of.rb
         | 
| 174 176 | 
             
            - lib/reek/spec/should_reek.rb
         | 
| 175 | 
            -
            - lib/reek/source/source_code.rb
         | 
| 176 | 
            -
            - lib/reek/source/code_comment.rb
         | 
| 177 | 
            -
            - lib/reek/source/source_file.rb
         | 
| 178 | 
            -
            - lib/reek/source/config_file.rb
         | 
| 179 | 
            -
            - lib/reek/source/tree_dresser.rb
         | 
| 180 | 
            -
            - lib/reek/source/source_locator.rb
         | 
| 181 | 
            -
            - lib/reek/source/reference_collector.rb
         | 
| 182 | 
            -
            - lib/reek/source/sexp_formatter.rb
         | 
| 183 | 
            -
            - lib/reek/source/core_extras.rb
         | 
| 184 | 
            -
            - lib/reek/source/source_repository.rb
         | 
| 185 | 
            -
            - lib/reek/core/object_refs.rb
         | 
| 186 | 
            -
            - lib/reek/core/module_context.rb
         | 
| 187 | 
            -
            - lib/reek/core/smell_repository.rb
         | 
| 188 | 
            -
            - lib/reek/core/warning_collector.rb
         | 
| 189 | 
            -
            - lib/reek/core/method_context.rb
         | 
| 190 | 
            -
            - lib/reek/core/code_parser.rb
         | 
| 191 | 
            -
            - lib/reek/core/hash_extensions.rb
         | 
| 192 | 
            -
            - lib/reek/core/stop_context.rb
         | 
| 193 | 
            -
            - lib/reek/core/singleton_method_context.rb
         | 
| 194 | 
            -
            - lib/reek/core/code_context.rb
         | 
| 195 | 
            -
            - lib/reek/core/sniffer.rb
         | 
| 196 | 
            -
            - lib/reek/core/smell_configuration.rb
         | 
| 197 | 
            -
            - lib/reek/spec.rb
         | 
| 198 | 
            -
            - lib/reek/source.rb
         | 
| 199 | 
            -
            - lib/reek/examiner.rb
         | 
| 200 | 
            -
            - lib/reek/rake/task.rb
         | 
| 201 | 
            -
            - lib/reek/smells.rb
         | 
| 202 | 
            -
            - lib/reek/version.rb
         | 
| 203 177 | 
             
            - lib/reek/cli/version_command.rb
         | 
| 204 178 | 
             
            - lib/reek/cli/application.rb
         | 
| 205 | 
            -
            - lib/reek/cli/report.rb
         | 
| 206 | 
            -
            - lib/reek/cli/reek_command.rb
         | 
| 207 | 
            -
            - lib/reek/cli/yaml_command.rb
         | 
| 208 179 | 
             
            - lib/reek/cli/command_line.rb
         | 
| 180 | 
            +
            - lib/reek/cli/yaml_command.rb
         | 
| 209 181 | 
             
            - lib/reek/cli/help_command.rb
         | 
| 210 | 
            -
            - lib/reek/ | 
| 182 | 
            +
            - lib/reek/cli/report.rb
         | 
| 183 | 
            +
            - lib/reek/cli/reek_command.rb
         | 
| 184 | 
            +
            - lib/reek/examiner.rb
         | 
| 185 | 
            +
            - lib/reek/rake/task.rb
         | 
| 186 | 
            +
            - lib/reek/smell_warning.rb
         | 
| 187 | 
            +
            - lib/reek/version.rb
         | 
| 188 | 
            +
            - lib/reek/smells/boolean_parameter.rb
         | 
| 189 | 
            +
            - lib/reek/smells/uncommunicative_parameter_name.rb
         | 
| 190 | 
            +
            - lib/reek/smells/unused_parameters.rb
         | 
| 211 191 | 
             
            - lib/reek/smells/long_yield_list.rb
         | 
| 212 | 
            -
            - lib/reek/smells/ | 
| 192 | 
            +
            - lib/reek/smells/attribute.rb
         | 
| 213 193 | 
             
            - lib/reek/smells/uncommunicative_method_name.rb
         | 
| 214 | 
            -
            - lib/reek/smells/ | 
| 194 | 
            +
            - lib/reek/smells/repeated_conditional.rb
         | 
| 195 | 
            +
            - lib/reek/smells/nil_check.rb
         | 
| 215 196 | 
             
            - lib/reek/smells/class_variable.rb
         | 
| 216 | 
            -
            - lib/reek/smells/ | 
| 197 | 
            +
            - lib/reek/smells/long_parameter_list.rb
         | 
| 198 | 
            +
            - lib/reek/smells/feature_envy.rb
         | 
| 199 | 
            +
            - lib/reek/smells/irresponsible_module.rb
         | 
| 217 200 | 
             
            - lib/reek/smells/utility_function.rb
         | 
| 218 | 
            -
            - lib/reek/smells/ | 
| 201 | 
            +
            - lib/reek/smells/data_clump.rb
         | 
| 219 202 | 
             
            - lib/reek/smells/too_many_methods.rb
         | 
| 220 | 
            -
            - lib/reek/smells/ | 
| 221 | 
            -
            - lib/reek/smells/nil_check.rb
         | 
| 222 | 
            -
            - lib/reek/smells/attribute.rb
         | 
| 203 | 
            +
            - lib/reek/smells/uncommunicative_variable_name.rb
         | 
| 223 204 | 
             
            - lib/reek/smells/uncommunicative_module_name.rb
         | 
| 224 | 
            -
            - lib/reek/smells/ | 
| 225 | 
            -
            - lib/reek/smells/ | 
| 205 | 
            +
            - lib/reek/smells/nested_iterators.rb
         | 
| 206 | 
            +
            - lib/reek/smells/control_parameter.rb
         | 
| 207 | 
            +
            - lib/reek/smells/too_many_instance_variables.rb
         | 
| 226 208 | 
             
            - lib/reek/smells/smell_detector.rb
         | 
| 227 | 
            -
            - lib/reek/smells/feature_envy.rb
         | 
| 228 | 
            -
            - lib/reek/smells/too_many_statements.rb
         | 
| 229 | 
            -
            - lib/reek/smells/uncommunicative_variable_name.rb
         | 
| 230 | 
            -
            - lib/reek/smells/unused_parameters.rb
         | 
| 231 209 | 
             
            - lib/reek/smells/duplicate_method_call.rb
         | 
| 232 | 
            -
            - lib/reek/smells/ | 
| 233 | 
            -
            - lib/reek/ | 
| 234 | 
            -
            - lib/reek.rb
         | 
| 235 | 
            -
            -  | 
| 236 | 
            -
            -  | 
| 210 | 
            +
            - lib/reek/smells/too_many_statements.rb
         | 
| 211 | 
            +
            - lib/reek/config_file_exception.rb
         | 
| 212 | 
            +
            - lib/reek/smells.rb
         | 
| 213 | 
            +
            - lib/reek/source/config_file.rb
         | 
| 214 | 
            +
            - lib/reek/source/source_code.rb
         | 
| 215 | 
            +
            - lib/reek/source/sexp_node.rb
         | 
| 216 | 
            +
            - lib/reek/source/sexp_formatter.rb
         | 
| 217 | 
            +
            - lib/reek/source/source_repository.rb
         | 
| 218 | 
            +
            - lib/reek/source/sexp_extensions.rb
         | 
| 219 | 
            +
            - lib/reek/source/reference_collector.rb
         | 
| 220 | 
            +
            - lib/reek/source/core_extras.rb
         | 
| 221 | 
            +
            - lib/reek/source/source_file.rb
         | 
| 222 | 
            +
            - lib/reek/source/code_comment.rb
         | 
| 223 | 
            +
            - lib/reek/source/source_locator.rb
         | 
| 224 | 
            +
            - lib/reek/source/tree_dresser.rb
         | 
| 225 | 
            +
            - lib/reek/source.rb
         | 
| 226 | 
            +
            - lib/reek/core/smell_configuration.rb
         | 
| 227 | 
            +
            - lib/reek/core/method_context.rb
         | 
| 228 | 
            +
            - lib/reek/core/code_parser.rb
         | 
| 229 | 
            +
            - lib/reek/core/module_context.rb
         | 
| 230 | 
            +
            - lib/reek/core/stop_context.rb
         | 
| 231 | 
            +
            - lib/reek/core/code_context.rb
         | 
| 232 | 
            +
            - lib/reek/core/sniffer.rb
         | 
| 233 | 
            +
            - lib/reek/core/hash_extensions.rb
         | 
| 234 | 
            +
            - lib/reek/core/smell_repository.rb
         | 
| 235 | 
            +
            - lib/reek/core/object_refs.rb
         | 
| 236 | 
            +
            - lib/reek/core/singleton_method_context.rb
         | 
| 237 | 
            +
            - lib/reek/core/warning_collector.rb
         | 
| 238 | 
            +
            - spec/matchers/smell_of_matcher.rb
         | 
| 239 | 
            +
            - spec/spec_helper.rb
         | 
| 237 240 | 
             
            - spec/reek/spec/should_reek_of_spec.rb
         | 
| 238 | 
            -
            - spec/reek/spec/should_reek_only_of_spec.rb
         | 
| 239 241 | 
             
            - spec/reek/spec/should_reek_spec.rb
         | 
| 240 | 
            -
            - spec/reek/ | 
| 241 | 
            -
            - spec/reek/source/reference_collector_spec.rb
         | 
| 242 | 
            -
            - spec/reek/source/code_comment_spec.rb
         | 
| 243 | 
            -
            - spec/reek/source/source_code_spec.rb
         | 
| 244 | 
            -
            - spec/reek/source/sexp_formatter_spec.rb
         | 
| 245 | 
            -
            - spec/reek/source/tree_dresser_spec.rb
         | 
| 246 | 
            -
            - spec/reek/core/module_context_spec.rb
         | 
| 247 | 
            -
            - spec/reek/core/singleton_method_context_spec.rb
         | 
| 248 | 
            -
            - spec/reek/core/code_parser_spec.rb
         | 
| 249 | 
            -
            - spec/reek/core/code_context_spec.rb
         | 
| 250 | 
            -
            - spec/reek/core/warning_collector_spec.rb
         | 
| 251 | 
            -
            - spec/reek/core/object_refs_spec.rb
         | 
| 252 | 
            -
            - spec/reek/core/smell_configuration_spec.rb
         | 
| 253 | 
            -
            - spec/reek/core/stop_context_spec.rb
         | 
| 254 | 
            -
            - spec/reek/core/config_spec.rb
         | 
| 255 | 
            -
            - spec/reek/core/method_context_spec.rb
         | 
| 256 | 
            -
            - spec/reek/smell_warning_spec.rb
         | 
| 242 | 
            +
            - spec/reek/spec/should_reek_only_of_spec.rb
         | 
| 257 243 | 
             
            - spec/reek/examiner_spec.rb
         | 
| 258 | 
            -
            - spec/reek/cli/yaml_command_spec.rb
         | 
| 259 | 
            -
            - spec/reek/cli/reek_command_spec.rb
         | 
| 260 244 | 
             
            - spec/reek/cli/help_command_spec.rb
         | 
| 245 | 
            +
            - spec/reek/cli/yaml_command_spec.rb
         | 
| 261 246 | 
             
            - spec/reek/cli/report_spec.rb
         | 
| 262 247 | 
             
            - spec/reek/cli/version_command_spec.rb
         | 
| 263 | 
            -
            - spec/reek/smells/ | 
| 264 | 
            -
            - spec/reek/smells/ | 
| 265 | 
            -
            - spec/reek/smells/too_many_methods_spec.rb
         | 
| 266 | 
            -
            - spec/reek/smells/too_many_statements_spec.rb
         | 
| 248 | 
            +
            - spec/reek/smells/boolean_parameter_spec.rb
         | 
| 249 | 
            +
            - spec/reek/smells/uncommunicative_method_name_spec.rb
         | 
| 267 250 | 
             
            - spec/reek/smells/uncommunicative_module_name_spec.rb
         | 
| 268 | 
            -
            - spec/reek/smells/ | 
| 269 | 
            -
            - spec/reek/smells/long_parameter_list_spec.rb
         | 
| 270 | 
            -
            - spec/reek/smells/control_parameter_spec.rb
         | 
| 271 | 
            -
            - spec/reek/smells/behaves_like_variable_detector.rb
         | 
| 251 | 
            +
            - spec/reek/smells/too_many_statements_spec.rb
         | 
| 272 252 | 
             
            - spec/reek/smells/class_variable_spec.rb
         | 
| 253 | 
            +
            - spec/reek/smells/long_yield_list_spec.rb
         | 
| 254 | 
            +
            - spec/reek/smells/control_parameter_spec.rb
         | 
| 255 | 
            +
            - spec/reek/smells/unused_parameters_spec.rb
         | 
| 256 | 
            +
            - spec/reek/smells/uncommunicative_parameter_name_spec.rb
         | 
| 257 | 
            +
            - spec/reek/smells/long_parameter_list_spec.rb
         | 
| 273 258 | 
             
            - spec/reek/smells/attribute_spec.rb
         | 
| 274 | 
            -
            - spec/reek/smells/uncommunicative_variable_name_spec.rb
         | 
| 275 259 | 
             
            - spec/reek/smells/data_clump_spec.rb
         | 
| 276 | 
            -
            - spec/reek/smells/uncommunicative_parameter_name_spec.rb
         | 
| 277 260 | 
             
            - spec/reek/smells/feature_envy_spec.rb
         | 
| 278 261 | 
             
            - spec/reek/smells/smell_detector_shared.rb
         | 
| 279 | 
            -
            - spec/reek/smells/ | 
| 280 | 
            -
            - spec/reek/smells/repeated_conditional_spec.rb
         | 
| 281 | 
            -
            - spec/reek/smells/uncommunicative_method_name_spec.rb
         | 
| 262 | 
            +
            - spec/reek/smells/utility_function_spec.rb
         | 
| 282 263 | 
             
            - spec/reek/smells/nested_iterators_spec.rb
         | 
| 283 | 
            -
            - spec/reek/smells/long_yield_list_spec.rb
         | 
| 284 264 | 
             
            - spec/reek/smells/duplicate_method_call_spec.rb
         | 
| 285 | 
            -
            - spec/reek/smells/boolean_parameter_spec.rb
         | 
| 286 265 | 
             
            - spec/reek/smells/too_many_instance_variables_spec.rb
         | 
| 287 | 
            -
            - spec/ | 
| 288 | 
            -
            - spec/ | 
| 289 | 
            -
            - spec/ | 
| 266 | 
            +
            - spec/reek/smells/too_many_methods_spec.rb
         | 
| 267 | 
            +
            - spec/reek/smells/behaves_like_variable_detector.rb
         | 
| 268 | 
            +
            - spec/reek/smells/repeated_conditional_spec.rb
         | 
| 269 | 
            +
            - spec/reek/smells/nil_check_spec.rb
         | 
| 270 | 
            +
            - spec/reek/smells/irresponsible_module_spec.rb
         | 
| 271 | 
            +
            - spec/reek/smells/uncommunicative_variable_name_spec.rb
         | 
| 272 | 
            +
            - spec/reek/smell_warning_spec.rb
         | 
| 273 | 
            +
            - spec/reek/source/sexp_node_spec.rb
         | 
| 274 | 
            +
            - spec/reek/source/reference_collector_spec.rb
         | 
| 275 | 
            +
            - spec/reek/source/tree_dresser_spec.rb
         | 
| 276 | 
            +
            - spec/reek/source/sexp_formatter_spec.rb
         | 
| 277 | 
            +
            - spec/reek/source/code_comment_spec.rb
         | 
| 278 | 
            +
            - spec/reek/source/sexp_extensions_spec.rb
         | 
| 279 | 
            +
            - spec/reek/source/object_source_spec.rb
         | 
| 280 | 
            +
            - spec/reek/source/source_code_spec.rb
         | 
| 281 | 
            +
            - spec/reek/core/object_refs_spec.rb
         | 
| 282 | 
            +
            - spec/reek/core/warning_collector_spec.rb
         | 
| 283 | 
            +
            - spec/reek/core/stop_context_spec.rb
         | 
| 284 | 
            +
            - spec/reek/core/config_spec.rb
         | 
| 285 | 
            +
            - spec/reek/core/code_parser_spec.rb
         | 
| 286 | 
            +
            - spec/reek/core/smell_configuration_spec.rb
         | 
| 287 | 
            +
            - spec/reek/core/module_context_spec.rb
         | 
| 288 | 
            +
            - spec/reek/core/method_context_spec.rb
         | 
| 289 | 
            +
            - spec/reek/core/code_context_spec.rb
         | 
| 290 | 
            +
            - spec/reek/core/singleton_method_context_spec.rb
         | 
| 291 | 
            +
            - spec/gem/updates_spec.rb
         | 
| 292 | 
            +
            - spec/gem/yard_spec.rb
         | 
| 293 | 
            +
            - spec/samples/three_clean_files/clean_one.rb
         | 
| 290 294 | 
             
            - spec/samples/three_clean_files/clean_two.rb
         | 
| 291 295 | 
             
            - spec/samples/three_clean_files/clean_three.rb
         | 
| 292 | 
            -
            - spec/samples/ | 
| 293 | 
            -
            - spec/samples/ | 
| 294 | 
            -
            - spec/samples/ | 
| 295 | 
            -
            - spec/samples/ | 
| 296 | 
            -
            - spec/samples/ | 
| 297 | 
            -
            - spec/samples/ | 
| 298 | 
            -
            - spec/samples/clean_due_to_masking/clean_one.rb
         | 
| 299 | 
            -
            - spec/samples/not_quite_masked/dirty.rb
         | 
| 300 | 
            -
            - spec/samples/not_quite_masked/masked.reek
         | 
| 301 | 
            -
            - spec/samples/not_quite_masked/smelly.rb
         | 
| 302 | 
            -
            - spec/samples/optparse.rb
         | 
| 303 | 
            -
            - spec/samples/all_but_one_masked/dirty.rb
         | 
| 304 | 
            -
            - spec/samples/all_but_one_masked/masked.reek
         | 
| 305 | 
            -
            - spec/samples/all_but_one_masked/clean_one.rb
         | 
| 306 | 
            -
            - spec/samples/demo/demo.rb
         | 
| 307 | 
            -
            - spec/samples/exceptions.reek
         | 
| 308 | 
            -
            - spec/samples/masked_by_dotfile/dirty.rb
         | 
| 309 | 
            -
            - spec/samples/inline.rb
         | 
| 310 | 
            -
            - spec/samples/redcloth.rb
         | 
| 296 | 
            +
            - spec/samples/three_smelly_files/dirty_three.rb
         | 
| 297 | 
            +
            - spec/samples/three_smelly_files/dirty_two.rb
         | 
| 298 | 
            +
            - spec/samples/three_smelly_files/dirty_one.rb
         | 
| 299 | 
            +
            - spec/samples/config/allow_duplication.reek
         | 
| 300 | 
            +
            - spec/samples/config/deeper_nested_iterators.reek
         | 
| 301 | 
            +
            - spec/samples/overrides/upper.reek
         | 
| 311 302 | 
             
            - spec/samples/overrides/masked/dirty.rb
         | 
| 312 303 | 
             
            - spec/samples/overrides/masked/lower.reek
         | 
| 313 | 
            -
            - spec/samples/ | 
| 314 | 
            -
            - spec/samples/ | 
| 315 | 
            -
            - spec/samples/ | 
| 316 | 
            -
            - spec/samples/masked | 
| 317 | 
            -
            - spec/samples/ | 
| 318 | 
            -
            - spec/samples/config/deeper_nested_iterators.reek
         | 
| 319 | 
            -
            - spec/samples/config/allow_duplication.reek
         | 
| 320 | 
            -
            - spec/samples/ruby20_syntax.rb
         | 
| 321 | 
            -
            - spec/samples/overrides_defaults/camel_case.rb
         | 
| 322 | 
            -
            - spec/samples/overrides_defaults/config.reek
         | 
| 323 | 
            -
            - spec/samples/corrupt_config_file/dirty.rb
         | 
| 304 | 
            +
            - spec/samples/masked_by_dotfile/dirty.rb
         | 
| 305 | 
            +
            - spec/samples/demo/demo.rb
         | 
| 306 | 
            +
            - spec/samples/redcloth.rb
         | 
| 307 | 
            +
            - spec/samples/inline_config/masked.reek
         | 
| 308 | 
            +
            - spec/samples/inline_config/dirty.rb
         | 
| 324 309 | 
             
            - spec/samples/corrupt_config_file/corrupt.reek
         | 
| 310 | 
            +
            - spec/samples/corrupt_config_file/dirty.rb
         | 
| 325 311 | 
             
            - spec/samples/empty_config_file/dirty.rb
         | 
| 326 312 | 
             
            - spec/samples/empty_config_file/empty.reek
         | 
| 313 | 
            +
            - spec/samples/masked/masked.reek
         | 
| 314 | 
            +
            - spec/samples/masked/dirty.rb
         | 
| 315 | 
            +
            - spec/samples/all_but_one_masked/masked.reek
         | 
| 316 | 
            +
            - spec/samples/all_but_one_masked/clean_one.rb
         | 
| 317 | 
            +
            - spec/samples/all_but_one_masked/dirty.rb
         | 
| 318 | 
            +
            - spec/samples/ruby20_syntax.rb
         | 
| 319 | 
            +
            - spec/samples/inline.rb
         | 
| 320 | 
            +
            - spec/samples/mask_some/dirty.rb
         | 
| 321 | 
            +
            - spec/samples/mask_some/some.reek
         | 
| 322 | 
            +
            - spec/samples/overrides_defaults/config.reek
         | 
| 323 | 
            +
            - spec/samples/overrides_defaults/camel_case.rb
         | 
| 324 | 
            +
            - spec/samples/not_quite_masked/masked.reek
         | 
| 325 | 
            +
            - spec/samples/not_quite_masked/dirty.rb
         | 
| 326 | 
            +
            - spec/samples/not_quite_masked/smelly.rb
         | 
| 327 | 
            +
            - spec/samples/exceptions.reek
         | 
| 328 | 
            +
            - spec/samples/mixed_results/dirty_two.rb
         | 
| 327 329 | 
             
            - spec/samples/mixed_results/dirty_one.rb
         | 
| 330 | 
            +
            - spec/samples/mixed_results/clean_one.rb
         | 
| 328 331 | 
             
            - spec/samples/mixed_results/clean_two.rb
         | 
| 329 | 
            -
            - spec/samples/mixed_results/dirty_two.rb
         | 
| 330 332 | 
             
            - spec/samples/mixed_results/clean_three.rb
         | 
| 331 | 
            -
            - spec/samples/ | 
| 332 | 
            -
            - spec/samples/ | 
| 333 | 
            -
            - spec/samples/ | 
| 334 | 
            -
            - spec/ | 
| 333 | 
            +
            - spec/samples/clean_due_to_masking/dirty_two.rb
         | 
| 334 | 
            +
            - spec/samples/clean_due_to_masking/masked.reek
         | 
| 335 | 
            +
            - spec/samples/clean_due_to_masking/dirty_one.rb
         | 
| 336 | 
            +
            - spec/samples/clean_due_to_masking/clean_one.rb
         | 
| 337 | 
            +
            - spec/samples/clean_due_to_masking/clean_two.rb
         | 
| 338 | 
            +
            - spec/samples/clean_due_to_masking/clean_three.rb
         | 
| 339 | 
            +
            - spec/samples/no_config_file/dirty.rb
         | 
| 340 | 
            +
            - spec/samples/optparse.rb
         | 
| 341 | 
            +
            - spec/samples/two_smelly_files/dirty_two.rb
         | 
| 342 | 
            +
            - spec/samples/two_smelly_files/dirty_one.rb
         | 
| 335 343 | 
             
            - tasks/test.rake
         | 
| 336 | 
            -
            - tasks/develop.rake
         | 
| 337 344 | 
             
            - tasks/reek.rake
         | 
| 345 | 
            +
            - tasks/develop.rake
         | 
| 338 346 | 
             
            - reek.gemspec
         | 
| 339 347 | 
             
            homepage: http://wiki.github.com/troessner/reek
         | 
| 340 348 | 
             
            licenses: []
         | 
| @@ -357,7 +365,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement | |
| 357 365 | 
             
                  version: '0'
         | 
| 358 366 | 
             
            requirements: []
         | 
| 359 367 | 
             
            rubyforge_project: reek
         | 
| 360 | 
            -
            rubygems_version: 2. | 
| 368 | 
            +
            rubygems_version: 2.1.11
         | 
| 361 369 | 
             
            signing_key: 
         | 
| 362 370 | 
             
            specification_version: 4
         | 
| 363 371 | 
             
            summary: Code smell detector for Ruby
         |