reek 1.2.8 → 1.2.9

data/lib/reek/smells/smell_detector.rb

@@ -71,9 +71,6 @@ module Reek
         end
       end
 
-      def examine_context(context)
-      end
-
       def exception?(context)
         context.matches?(value(EXCLUDE_KEY, context, DEFAULT_EXCLUDE_SET))
       end

data/lib/reek/smells/uncommunicative_module_name.rb

@@ -56,15 +56,18 @@ module Reek
       #
       # @return [Array<SmellWarning>]
       #
+      # :reek:Duplication { allow_calls: [ to_s ] }
       def examine_context(ctx)
         @reject_names = value(REJECT_KEY, ctx, DEFAULT_REJECT_SET)
         @accept_names = value(ACCEPT_KEY, ctx, DEFAULT_ACCEPT_SET)
-        name = ctx.exp.simple_name
-        return [] if @accept_names.include?(ctx.full_name)
+        exp = ctx.exp
+        full_name = ctx.full_name
+        name = exp.simple_name
+        return [] if @accept_names.include?(full_name)
         var = name.to_s.gsub(/^[@\*\&]*/, '')
         return [] if @accept_names.include?(var)
         return [] unless @reject_names.detect {|patt| patt === var}
-        smell = SmellWarning.new(SMELL_CLASS, ctx.full_name, [ctx.exp.line],
+        smell = SmellWarning.new(SMELL_CLASS, full_name, [exp.line],
           "has the name '#{name}'",
           @source, SMELL_SUBCLASS, {MODULE_NAME_KEY => name.to_s})
         [smell]

data/lib/reek/smells/uncommunicative_variable_name.rb

@@ -34,7 +34,7 @@ module Reek
       # uncommunicative.
       ACCEPT_KEY = 'accept'
 
-      DEFAULT_ACCEPT_SET = []
+      DEFAULT_ACCEPT_SET = ['_']
 
       def self.default_config
         super.adopt(

data/lib/reek/source/config_file.rb

@@ -50,9 +50,15 @@ module Reek
       def load
         unless @@bad_config_files.include?(@file_path)
           begin
-            return YAML.load_file(@file_path) || {}
+            result = YAML.load_file(@file_path) || {}
+            if Hash === result
+              return result
+            else
+              @@bad_config_files << @file_path                            # poop
+              problem('Not a hash')
+            end
           rescue Exception => err
-            @@bad_config_files << @file_path
+            @@bad_config_files << @file_path                              # poop
             problem(err.to_s)
           end
         end

data/lib/reek/source/sexp_formatter.rb

@@ -9,7 +9,7 @@ module Reek
     class SexpFormatter
       def self.format(sexp)
         return sexp.to_s unless Array === sexp
-        sexp = YAML::load(YAML::dump(sexp))
+        sexp = Sexp.from_array(YAML::load(YAML::dump(sexp)))
         Ruby2Ruby.new.process(sexp)
       end
     end

data/lib/reek/source/source_repository.rb

@@ -0,0 +1,31 @@
+require File.join(File.dirname(File.dirname(File.expand_path(__FILE__))), 'source')
+
+module Reek
+  module Source
+    class SourceRepository
+      def self.parse source
+        case source
+        when Array
+          new 'dir', Source::SourceLocator.new(source).all_sources
+        when Source::SourceCode
+          new source.desc, [source]
+        else
+          src = source.to_reek_source
+          new src.desc, [src]
+        end
+      end
+
+      include Enumerable
+      attr_reader :description
+
+      def initialize description, sources
+        @description = description
+        @sources = sources
+      end
+
+      def each &block
+        @sources.each &block
+      end
+    end
+  end
+end

data/lib/reek/source/tree_dresser.rb

@@ -53,7 +53,7 @@ module Reek
         Ruby2Ruby.new.process(deep_copy)
       end
       def deep_copy
-        YAML::load(YAML::dump(self))
+        Sexp.from_array(YAML::load(YAML::dump(self)))
       end
     end
 

data/lib/reek/spec/should_reek.rb

@@ -8,8 +8,11 @@ module Reek
     # An rspec matcher that matches when the +actual+ has code smells.
     #
     class ShouldReek        # :nodoc:
+      def initialize(config_files = [])
+        @config_files = config_files
+      end
       def matches?(actual)
-        @examiner = Examiner.new(actual)
+        @examiner = Examiner.new(actual, @config_files)
         @examiner.smelly?
       end
       def failure_message_for_should
@@ -25,7 +28,7 @@ module Reek
     # Returns +true+ if and only if the target source code contains smells.
     #
     def reek
-      ShouldReek.new
+      ShouldReek.new(Dir['config/*.reek'])
     end
   end
 end

data/lib/reek/version.rb

@@ -0,0 +1,3 @@
+module Reek
+  VERSION = '1.2.9'
+end

data/lib/xp.reek

@@ -0,0 +1,63 @@
+--- 
+LargeClass: 
+  max_methods: 25
+  exclude: []
+  enabled: true
+  max_instance_variables: 9
+LongParameterList: 
+  max_params: 3
+  exclude: []
+  enabled: true
+  overrides: 
+    initialize: 
+      max_params: 5
+FeatureEnvy: 
+  exclude: 
+  - initialize
+  enabled: false
+ClassVariable: 
+  exclude: &id001 []
+  enabled: true
+UncommunicativeVariableName:
+  accept: 
+  - Inline::C
+  exclude: []
+  enabled: true
+  reject: 
+  - !ruby/regexp /^.$/
+  - !ruby/regexp /[0-9]$/
+NestedIterators: 
+  exclude: *id001
+  enabled: false
+LongMethod: 
+  max_statements: 5
+  exclude: 
+  - initialize
+  enabled: false
+Duplication: 
+  exclude: []
+  enabled: true
+  max_calls: 1
+UtilityFunction: 
+  max_helper_calls: 1
+  exclude: []
+  enabled: false
+Attribute: 
+  exclude: []
+  enabled: true
+SimulatedPolymorphism: 
+  exclude: []
+  enabled: true
+  max_ifs: 2
+DataClump: 
+  exclude: []
+  enabled: true
+  max_copies: 2
+  min_clump_size: 2
+LongYieldList: 
+  max_params: 2
+  exclude: []
+  enabled: true
+  overrides: 
+    initialize: 
+      max_params: 5

data/reek.gemspec

@@ -1,48 +1,36 @@
 # -*- encoding: utf-8 -*-
+require File.join(File.dirname(__FILE__), 'lib/reek/version.rb')
 
 Gem::Specification.new do |s|
   s.name = %q{reek}
-  s.version = "1.2.8"
+  s.version = Reek::VERSION
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Kevin Rutherford"]
+  s.authors = ['Kevin Rutherford', 'Timo Roessner', 'Matijs van Zuijlen']
   s.date = %q{2010-04-26}
   s.default_executable = %q{reek}
   s.description = %q{Reek is a tool that examines Ruby classes, modules and methods
 and reports any code smells it finds.
 }
-  s.email = ["kevin@rutherford-software.com"]
+  s.email = ["timo.roessner@googlemail.com"]
   s.executables = ["reek"]
   s.extra_rdoc_files = ["History.txt", "License.txt"]
-  s.files = [".yardopts", "History.txt", "License.txt", "README.md", "Rakefile", "bin/reek", "config/defaults.reek", "features/api.feature", "features/masking_smells.feature", "features/options.feature", "features/rake_task.feature", "features/reports.feature", "features/samples.feature", "features/stdin.feature", "features/step_definitions/reek_steps.rb", "features/support/env.rb", "features/yaml.feature", "lib/reek.rb", "lib/reek/cli/application.rb", "lib/reek/cli/command_line.rb", "lib/reek/cli/help_command.rb", "lib/reek/cli/reek_command.rb", "lib/reek/cli/report.rb", "lib/reek/cli/version_command.rb", "lib/reek/cli/yaml_command.rb", "lib/reek/core/code_context.rb", "lib/reek/core/code_parser.rb", "lib/reek/core/method_context.rb", "lib/reek/core/module_context.rb", "lib/reek/core/object_refs.rb", "lib/reek/core/singleton_method_context.rb", "lib/reek/core/smell_configuration.rb", "lib/reek/core/sniffer.rb", "lib/reek/core/stop_context.rb", "lib/reek/core/warning_collector.rb", "lib/reek/examiner.rb", "lib/reek/rake/task.rb", "lib/reek/smell_warning.rb", "lib/reek/smells.rb", "lib/reek/smells/attribute.rb", "lib/reek/smells/boolean_parameter.rb", "lib/reek/smells/class_variable.rb", "lib/reek/smells/control_couple.rb", "lib/reek/smells/data_clump.rb", "lib/reek/smells/duplication.rb", "lib/reek/smells/feature_envy.rb", "lib/reek/smells/irresponsible_module.rb", "lib/reek/smells/large_class.rb", "lib/reek/smells/long_method.rb", "lib/reek/smells/long_parameter_list.rb", "lib/reek/smells/long_yield_list.rb", "lib/reek/smells/nested_iterators.rb", "lib/reek/smells/simulated_polymorphism.rb", "lib/reek/smells/smell_detector.rb", "lib/reek/smells/uncommunicative_method_name.rb", "lib/reek/smells/uncommunicative_module_name.rb", "lib/reek/smells/uncommunicative_parameter_name.rb", "lib/reek/smells/uncommunicative_variable_name.rb", "lib/reek/smells/utility_function.rb", "lib/reek/source.rb", "lib/reek/source/code_comment.rb", "lib/reek/source/config_file.rb", "lib/reek/source/core_extras.rb", "lib/reek/source/reference_collector.rb", "lib/reek/source/sexp_formatter.rb", "lib/reek/source/source_code.rb", "lib/reek/source/source_file.rb", "lib/reek/source/source_locator.rb", "lib/reek/source/tree_dresser.rb", "lib/reek/spec.rb", "lib/reek/spec/should_reek.rb", "lib/reek/spec/should_reek_of.rb", "lib/reek/spec/should_reek_only_of.rb", "reek.gemspec", "spec/matchers/smell_of_matcher.rb", "spec/reek/cli/help_command_spec.rb", "spec/reek/cli/reek_command_spec.rb", "spec/reek/cli/report_spec.rb", "spec/reek/cli/version_command_spec.rb", "spec/reek/cli/yaml_command_spec.rb", "spec/reek/core/code_context_spec.rb", "spec/reek/core/code_parser_spec.rb", "spec/reek/core/config_spec.rb", "spec/reek/core/method_context_spec.rb", "spec/reek/core/module_context_spec.rb", "spec/reek/core/object_refs_spec.rb", "spec/reek/core/singleton_method_context_spec.rb", "spec/reek/core/smell_configuration_spec.rb", "spec/reek/core/stop_context_spec.rb", "spec/reek/core/warning_collector_spec.rb", "spec/reek/examiner_spec.rb", "spec/reek/smell_warning_spec.rb", "spec/reek/smells/attribute_spec.rb", "spec/reek/smells/behaves_like_variable_detector.rb", "spec/reek/smells/boolean_parameter_spec.rb", "spec/reek/smells/class_variable_spec.rb", "spec/reek/smells/control_couple_spec.rb", "spec/reek/smells/data_clump_spec.rb", "spec/reek/smells/duplication_spec.rb", "spec/reek/smells/feature_envy_spec.rb", "spec/reek/smells/irresponsible_module_spec.rb", "spec/reek/smells/large_class_spec.rb", "spec/reek/smells/long_method_spec.rb", "spec/reek/smells/long_parameter_list_spec.rb", "spec/reek/smells/long_yield_list_spec.rb", "spec/reek/smells/nested_iterators_spec.rb", "spec/reek/smells/simulated_polymorphism_spec.rb", "spec/reek/smells/smell_detector_shared.rb", "spec/reek/smells/uncommunicative_method_name_spec.rb", "spec/reek/smells/uncommunicative_module_name_spec.rb", "spec/reek/smells/uncommunicative_parameter_name_spec.rb", "spec/reek/smells/uncommunicative_variable_name_spec.rb", "spec/reek/smells/utility_function_spec.rb", "spec/reek/source/code_comment_spec.rb", "spec/reek/source/object_source_spec.rb", "spec/reek/source/reference_collector_spec.rb", "spec/reek/source/source_code_spec.rb", "spec/reek/source/tree_dresser_spec.rb", "spec/reek/spec/should_reek_of_spec.rb", "spec/reek/spec/should_reek_only_of_spec.rb", "spec/reek/spec/should_reek_spec.rb", "spec/samples/all_but_one_masked/clean_one.rb", "spec/samples/all_but_one_masked/dirty.rb", "spec/samples/all_but_one_masked/masked.reek", "spec/samples/clean_due_to_masking/clean_one.rb", "spec/samples/clean_due_to_masking/clean_three.rb", "spec/samples/clean_due_to_masking/clean_two.rb", "spec/samples/clean_due_to_masking/dirty_one.rb", "spec/samples/clean_due_to_masking/dirty_two.rb", "spec/samples/clean_due_to_masking/masked.reek", "spec/samples/config/allow_duplication.reek", "spec/samples/config/deeper_nested_iterators.reek", "spec/samples/corrupt_config_file/corrupt.reek", "spec/samples/corrupt_config_file/dirty.rb", "spec/samples/demo/demo.rb", "spec/samples/empty_config_file/dirty.rb", "spec/samples/empty_config_file/empty.reek", "spec/samples/exceptions.reek", "spec/samples/inline_config/dirty.rb", "spec/samples/inline_config/masked.reek", "spec/samples/inline.rb", "spec/samples/mask_some/dirty.rb", "spec/samples/mask_some/some.reek", "spec/samples/masked/dirty.rb", "spec/samples/masked/masked.reek", "spec/samples/mixed_results/clean_one.rb", "spec/samples/mixed_results/clean_three.rb", "spec/samples/mixed_results/clean_two.rb", "spec/samples/mixed_results/dirty_one.rb", "spec/samples/mixed_results/dirty_two.rb", "spec/samples/not_quite_masked/dirty.rb", "spec/samples/not_quite_masked/masked.reek", "spec/samples/optparse.rb", "spec/samples/overrides/masked/dirty.rb", "spec/samples/overrides/masked/lower.reek", "spec/samples/overrides/upper.reek", "spec/samples/redcloth.rb", "spec/samples/three_clean_files/clean_one.rb", "spec/samples/three_clean_files/clean_three.rb", "spec/samples/three_clean_files/clean_two.rb", "spec/samples/two_smelly_files/dirty_one.rb", "spec/samples/two_smelly_files/dirty_two.rb", "spec/spec.opts", "spec/spec_helper.rb", "tasks/reek.rake", "tasks/test.rake"]
-  s.homepage = %q{http://wiki.github.com/kevinrutherford/reek}
-  s.post_install_message = %q{
-Thank you for downloading Reek. For info:
-  - see the reek wiki http://wiki.github.com/kevinrutherford/reek
-  - follow @rubyreek on twitter
-}
+  s.files = Dir[".yardopts", "History.txt", "License.txt", "README.md",
+                "Rakefile", "bin/reek", "config/defaults.reek",
+                "{features,lib,spec,tasks}/**/*",
+                "reek.gemspec" ] & `git ls-files -z`.split("\0")
+  s.homepage = %q{http://wiki.github.com/troessner/reek}
+  s.post_install_message = %q{Thank you for downloading Reek. For info see the reek wiki http://wiki.github.com/troessner/reek}
   s.rdoc_options = ["--main", "README.md"]
   s.require_paths = ["lib"]
   s.rubyforge_project = %q{reek}
   s.rubygems_version = %q{1.3.6}
   s.summary = %q{Code smell detector for Ruby}
 
-  if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 3
+  s.add_runtime_dependency(%q<ruby_parser>, ["~> 2.0"])
+  s.add_runtime_dependency(%q<ruby2ruby>, ["~> 1.2.5"])
+  s.add_runtime_dependency(%q<sexp_processor>, ["~> 3.0"])
 
-    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<ruby_parser>, ["~> 2.0"])
-      s.add_runtime_dependency(%q<ruby2ruby>, ["~> 1.2"])
-      s.add_runtime_dependency(%q<sexp_processor>, ["~> 3.0"])
-    else
-      s.add_dependency(%q<ruby_parser>, ["~> 2.0"])
-      s.add_dependency(%q<ruby2ruby>, ["~> 1.2"])
-      s.add_dependency(%q<sexp_processor>, ["~> 3.0"])
-    end
-  else
-    s.add_dependency(%q<ruby_parser>, ["~> 2.0"])
-    s.add_dependency(%q<ruby2ruby>, ["~> 1.2"])
-    s.add_dependency(%q<sexp_processor>, ["~> 3.0"])
-  end
+  s.add_development_dependency(%q<rake>)
+  s.add_development_dependency(%q<cucumber>)
+  s.add_development_dependency(%q<rspec>, ["= 1.3.2"])
 end

data/spec/gem/manifest_spec.rb

@@ -0,0 +1,22 @@
+require File.join(File.dirname(File.dirname(File.expand_path(__FILE__))), 'spec_helper')
+require 'find'
+
+describe 'gem manifest' do
+  before :each do
+    @current_files = []
+    Find.find '.' do |path|
+      next unless File.file? path
+      next if path =~ /\.git|\.idea|build|doc|gem\/|tmp|nbproject|quality|xp.reek|Manifest.txt|develop.rake|deployment.rake/
+      @current_files << path[2..-1]
+    end
+    @current_files.sort!
+    @manifest = IO.readlines('Manifest.txt').map {|path| path.chomp}.sort
+  end
+
+  it 'lists every current file' do
+    (@current_files - @manifest).should == []
+  end
+  it 'lists no extra files' do
+    (@manifest - @current_files).should == []
+  end
+end

data/spec/gem/updates_spec.rb

@@ -0,0 +1,26 @@
+require File.join(File.dirname(File.dirname(File.expand_path(__FILE__))), 'spec_helper')
+require 'find'
+
+release_timestamp_file = 'build/.last-release'
+if test(?f, release_timestamp_file)
+  describe 'updates' do
+    before :each do
+      @release_time = File.stat(release_timestamp_file).mtime
+    end
+
+    context 'version file' do
+      it 'has been updated since the last release' do
+        version_time = File.stat('lib/reek.rb').mtime
+        (version_time > @release_time).should be_true
+      end
+    end
+
+    context 'history file' do
+      it 'has been updated since the last release' do
+        history_time = File.stat('History.txt').mtime
+        (history_time > @release_time).should be_true
+      end
+    end
+  end
+end
+

data/spec/gem/yard_spec.rb

@@ -0,0 +1,15 @@
+require File.join(File.dirname(File.dirname(File.expand_path(__FILE__))), 'spec_helper')
+require 'tempfile'
+
+describe 'yardoc' do
+  before :each do
+    stderr_file = Tempfile.new('yardoc')
+    stderr_file.close
+    @stdout = `yardoc 2> #{stderr_file.path}`
+    @stderr = IO.read(stderr_file.path)
+  end
+  it 'raises no warnings' do
+    @stderr.should == ''
+  end
+end
+

data/spec/matchers/smell_of_matcher.rb

@@ -35,7 +35,6 @@ module SmellOfMatcher
         expected_smell.each do |(key,value)|
           if actual_smells[index].smell[key] != value
             @reason = "#{key} != #{value}"
-            return false
           end
         end
       end

data/spec/reek/cli/reek_command_spec.rb

@@ -18,7 +18,7 @@ describe ReekCommand do
     end
 
     it 'displays the correct text on the view' do
-      @view.should_receive(:output).with(/UncommunicativeName/)
+      @view.should_receive(:output).with(/UncommunicativeMethodName/)
       @cmd.execute(@view)
     end
 

data/spec/reek/core/method_context_spec.rb

@@ -32,7 +32,7 @@ describe MethodContext do
 
   it 'should count calls to self' do
     mctx = MethodContext.new(StopContext.new, ast(:defn, :equals))
-    mctx.refs.record_ref([:lvar, :other])
+    mctx.refs.record_reference_to([:lvar, :other])
     mctx.record_call_to(ast(:call, s(:self), :thing))
     mctx.envious_receivers.should be_empty
   end
@@ -85,4 +85,4 @@ describe MethodParameters, 'default assignments' do
       @defaults.length.should == 2
     end
   end
-end
+end

data/spec/reek/core/object_refs_spec.rb

@@ -3,128 +3,125 @@ require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expan
 
 include Reek::Core
 
-describe ObjectRefs, 'when empty' do
+describe ObjectRefs do
   before(:each) do
     @refs = ObjectRefs.new
   end
 
-  it 'should report no refs to self' do
-    @refs.refs_to_self.should == 0
+  context 'when empty' do
+    it 'should report no refs to self' do
+      @refs.references_to(:self).should == 0
+    end
+  end
+
+  context "with references to a, b, and a" do
+    context 'with no refs to self' do
+      before(:each) do
+        @refs.record_reference_to('a')
+        @refs.record_reference_to('b')
+        @refs.record_reference_to('a')
+      end
+
+      it 'should report no refs to self' do
+        @refs.references_to(:self).should == 0
+      end
+
+      it 'should report :a as the max' do
+        @refs.max_keys.should == {'a' => 2}
+      end
+
+      it 'should not report self as the max' do
+        @refs.self_is_max?.should == false
+      end
+      
+      context "with one reference to self" do
+        before(:each) do
+          @refs.record_reference_to(:self)
+        end
+
+        it 'should report 1 ref to self' do
+          @refs.references_to(:self).should == 1
+        end
+
+        it 'should not report self among the max' do
+          @refs.max_keys.should include('a')
+          @refs.max_keys.should_not include(:self)
+        end
+
+        it 'should not report self as the max' do
+          @refs.self_is_max?.should == false
+        end
+      end
+    end
+  end
+
+  context 'with many refs to self' do
+    before(:each) do
+      @refs.record_reference_to(:self)
+      @refs.record_reference_to(:self)
+      @refs.record_reference_to('a')
+      @refs.record_reference_to(:self)
+      @refs.record_reference_to('b')
+      @refs.record_reference_to('a')
+      @refs.record_reference_to(:self)
+    end
+
+    it 'should report all refs to self' do
+      @refs.references_to(:self).should == 4
+    end
+
+    it 'should report self among the max' do
+      @refs.max_keys.should == { :self => 4}
+    end
+
+    it 'should report self as the max' do
+      @refs.self_is_max?.should == true
+    end
+  end
+
+  context 'when self is not the only max' do
+    before(:each) do
+      @refs.record_reference_to('a')
+      @refs.record_reference_to(:self)
+      @refs.record_reference_to(:self)
+      @refs.record_reference_to('b')
+      @refs.record_reference_to('a')
+    end
+
+    it 'should report all refs to self' do
+      @refs.references_to(:self).should == 2
+    end
+
+    it 'should report self among the max' do
+      @refs.max_keys.should include('a')
+      @refs.max_keys.should include(:self)
+    end
+
+    it 'should report self as the max' do
+      @refs.self_is_max?.should == true
+    end
+  end
+
+  context 'when self is not among the max' do
+    before(:each) do
+      @refs.record_reference_to('a')
+      @refs.record_reference_to('b')
+      @refs.record_reference_to('a')
+      @refs.record_reference_to('b')
+    end
+
+    it 'should report all refs to self' do
+      @refs.references_to(:self).should == 0
+    end
+
+    it 'should not report self among the max' do
+      @refs.max_keys.should include('a')
+      @refs.max_keys.should include('b')
+    end
+
+    it 'should not report self as the max' do
+      @refs.self_is_max?.should == false
+    end
   end
 end
 
-describe ObjectRefs, 'with no refs to self' do
-  before(:each) do
-    @refs = ObjectRefs.new
-    @refs.record_ref('a')
-    @refs.record_ref('b')
-    @refs.record_ref('a')
-  end
-
-  it 'should report no refs to self' do
-    @refs.refs_to_self.should == 0
-  end
-
-  it 'should report :a as the max' do
-    @refs.max_keys.should == {'a' => 2}
-  end
-
-  it 'should not report self as the max' do
-    @refs.self_is_max?.should == false
-  end
-end
-
-describe ObjectRefs, 'with one ref to self' do
-  before(:each) do
-    @refs = ObjectRefs.new
-    @refs.record_ref('a')
-    @refs.record_ref('b')
-    @refs.record_ref('a')
-    @refs.record_reference_to_self
-  end
-
-  it 'should report 1 ref to self' do
-    @refs.refs_to_self.should == 1
-  end
-
-  it 'should not report self among the max' do
-    @refs.max_keys.should be_include('a')
-    @refs.max_keys.should_not include(Sexp.from_array([:lit, :self]))
-  end
-
-  it 'should not report self as the max' do
-    @refs.self_is_max?.should == false
-  end
-end
-
-describe ObjectRefs, 'with many refs to self' do
-  before(:each) do
-    @refs = ObjectRefs.new
-    @refs.record_reference_to_self
-    @refs.record_reference_to_self
-    @refs.record_ref('a')
-    @refs.record_reference_to_self
-    @refs.record_ref('b')
-    @refs.record_ref('a')
-    @refs.record_reference_to_self
-  end
-
-  it 'should report all refs to self' do
-    @refs.refs_to_self.should == 4
-  end
-
-  it 'should report self among the max' do
-    @refs.max_keys.should == {Sexp.from_array([:lit, :self]) => 4}
-  end
-
-  it 'should report self as the max' do
-    @refs.self_is_max?.should == true
-  end
-end
-
-describe ObjectRefs, 'when self is not the only max' do
-  before(:each) do
-    @refs = ObjectRefs.new
-    @refs.record_ref('a')
-    @refs.record_reference_to_self
-    @refs.record_reference_to_self
-    @refs.record_ref('b')
-    @refs.record_ref('a')
-  end
-
-  it 'should report all refs to self' do
-    @refs.refs_to_self.should == 2
-  end
-
-  it 'should report self among the max' do
-    @refs.max_keys.should be_include('a')
-    @refs.max_keys.should be_include(Sexp.from_array([:lit, :self]))
-  end
-
-  it 'should report self as the max' do
-    @refs.self_is_max?.should == true
-  end
-end
-
-describe ObjectRefs, 'when self is not among the max' do
-  before(:each) do
-    @refs = ObjectRefs.new
-    @refs.record_ref('a')
-    @refs.record_ref('b')
-    @refs.record_ref('a')
-    @refs.record_ref('b')
-  end
-
-  it 'should report all refs to self' do
-    @refs.refs_to_self.should == 0
-  end
-
-  it 'should not report self among the max' do
-    @refs.max_keys.should be_include('a')
-    @refs.max_keys.should be_include('b')
-  end
-
-  it 'should not report self as the max' do
-    @refs.self_is_max?.should == false
-  end
-end