reek 1.2.6 → 1.2.7

data/features/samples.feature

@@ -10,7 +10,8 @@ Feature: Basic smell detection
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/inline.rb -- 39 warnings (+1 masked):
+    spec/samples/inline.rb -- 41 warnings (+1 masked):
+      File has no descriptive comment (Irresponsible Module)
       Inline declares the class variable @@directory (Class Variable)
       Inline declares the class variable @@rootdir (Class Variable)
       Inline#self.rootdir calls env.nil? twice (Duplication)
@@ -28,10 +29,10 @@ Feature: Basic smell detection
       Inline::C#build calls io.puts("#ifdef __cplusplus") twice (Duplication)
       Inline::C#build calls module_name twice (Duplication)
       Inline::C#build calls warn("Output:\n#{result}") twice (Duplication)
+      Inline::C#build contains iterators nested 2 deep (Nested Iterators)
       Inline::C#build has approx 60 statements (Long Method)
+      Inline::C#build has the variable name 'n' (Uncommunicative Name)
       Inline::C#build has the variable name 't' (Uncommunicative Name)
-      Inline::C#build/block/block has the variable name 'n' (Uncommunicative Name)
-      Inline::C#build/block/block is nested (Nested Iterators)
       Inline::C#c has the name 'c' (Uncommunicative Name)
       Inline::C#crap_for_windoze calls Config::CONFIG["libdir"] twice (Duplication)
       Inline::C#generate calls result.sub!(/\A\n/, "") twice (Duplication)
@@ -40,13 +41,14 @@ Feature: Basic smell detection
       Inline::C#generate has approx 32 statements (Long Method)
       Inline::C#initialize calls stack.empty? twice (Duplication)
       Inline::C#load calls so_name twice (Duplication)
-      Inline::C#module_name/block has the variable name 'm' (Uncommunicative Name)
-      Inline::C#module_name/block has the variable name 'x' (Uncommunicative Name)
+      Inline::C#module_name has the variable name 'm' (Uncommunicative Name)
+      Inline::C#module_name has the variable name 'x' (Uncommunicative Name)
       Inline::C#parse_signature has approx 15 statements (Long Method)
+      Inline::C#parse_signature has boolean parameter 'raw' (Control Couple)
+      Inline::C#parse_signature has the variable name 'x' (Uncommunicative Name)
       Inline::C#parse_signature is controlled by argument raw (Control Couple)
-      Inline::C#parse_signature/block has the variable name 'x' (Uncommunicative Name)
-      Inline::C#strip_comments doesn't depend on instance state (Utility Function)
-      Inline::C#strip_comments refers to src more than self (Feature Envy)
+      Inline::C#strip_comments doesn't depend on instance state (Low Cohesion)
+      Inline::C#strip_comments refers to src more than self (Low Cohesion)
       Module#inline calls Inline.const_get(lang) twice (Duplication)
       Module#inline has approx 11 statements (Long Method)
       Module#inline is controlled by argument options (Control Couple)
@@ -58,20 +60,24 @@ Feature: Basic smell detection
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/optparse.rb -- 124 warnings:
+    spec/samples/optparse.rb -- 109 warnings:
       OptionParser has at least 42 methods (Large Class)
+      OptionParser has the variable name 'f' (Uncommunicative Name)
+      OptionParser has the variable name 'k' (Uncommunicative Name)
+      OptionParser has the variable name 'o' (Uncommunicative Name)
+      OptionParser has the variable name 's' (Uncommunicative Name)
+      OptionParser has the variable name 'v' (Uncommunicative Name)
       OptionParser tests ((argv.size == 1) and Array.===(argv[0])) at least 3 times (Simulated Polymorphism)
       OptionParser tests a at least 7 times (Simulated Polymorphism)
       OptionParser tests default_pattern at least 7 times (Simulated Polymorphism)
       OptionParser tests not_style at least 3 times (Simulated Polymorphism)
       OptionParser tests s at least 7 times (Simulated Polymorphism)
+      OptionParser#complete contains iterators nested 2 deep (Nested Iterators)
       OptionParser#complete has 4 parameters (Long Parameter List)
-      OptionParser#complete is controlled by argument icase (Control Couple)
-      OptionParser#complete/block/block is nested (Nested Iterators)
+      OptionParser#complete has boolean parameter 'icase' (Control Couple)
       OptionParser#getopts calls result[opt] = false twice (Duplication)
       OptionParser#getopts has approx 17 statements (Long Method)
-      OptionParser#getopts/block is controlled by argument val (Control Couple)
-      OptionParser#load/block has the variable name 's' (Uncommunicative Name)
+      OptionParser#load has the variable name 's' (Uncommunicative Name)
       OptionParser#make_switch calls (long << o = q.downcase) twice (Duplication)
       OptionParser#make_switch calls (sdesc << "-#{q}") twice (Duplication)
       OptionParser#make_switch calls default_style.guess(arg = a) 4 times (Duplication)
@@ -83,24 +89,20 @@ Feature: Basic smell detection
       OptionParser#make_switch calls q.downcase 3 times (Duplication)
       OptionParser#make_switch calls search(:atype, FalseClass) twice (Duplication)
       OptionParser#make_switch calls search(:atype, o) 6 times (Duplication)
+      OptionParser#make_switch contains iterators nested 2 deep (Nested Iterators)
+      OptionParser#make_switch contains iterators nested 3 deep (Nested Iterators)
       OptionParser#make_switch has approx 68 statements (Long Method)
       OptionParser#make_switch has the variable name 'a' (Uncommunicative Name)
+      OptionParser#make_switch has the variable name 'c' (Uncommunicative Name)
       OptionParser#make_switch has the variable name 'n' (Uncommunicative Name)
       OptionParser#make_switch has the variable name 'o' (Uncommunicative Name)
       OptionParser#make_switch has the variable name 'q' (Uncommunicative Name)
       OptionParser#make_switch has the variable name 's' (Uncommunicative Name)
-      OptionParser#make_switch/block has the variable name 'a' (Uncommunicative Name)
-      OptionParser#make_switch/block has the variable name 'o' (Uncommunicative Name)
-      OptionParser#make_switch/block has the variable name 'q' (Uncommunicative Name)
-      OptionParser#make_switch/block/block has the variable name 'c' (Uncommunicative Name)
-      OptionParser#make_switch/block/block has the variable name 'o' (Uncommunicative Name)
-      OptionParser#make_switch/block/block has the variable name 'v' (Uncommunicative Name)
-      OptionParser#make_switch/block/block is nested (Nested Iterators)
-      OptionParser#make_switch/block/block/block is nested (Nested Iterators)
+      OptionParser#make_switch has the variable name 'v' (Uncommunicative Name)
       OptionParser#order calls argv[0] twice (Duplication)
-      OptionParser#order refers to argv more than self (Feature Envy)
+      OptionParser#order refers to argv more than self (Low Cohesion)
       OptionParser#parse calls argv[0] twice (Duplication)
-      OptionParser#parse refers to argv more than self (Feature Envy)
+      OptionParser#parse refers to argv more than self (Low Cohesion)
       OptionParser#parse_in_order calls $!.set_option(arg, true) twice (Duplication)
       OptionParser#parse_in_order calls cb.call(val) twice (Duplication)
       OptionParser#parse_in_order calls raise($!.set_option(arg, true)) twice (Duplication)
@@ -108,50 +110,37 @@ Feature: Basic smell detection
       OptionParser#parse_in_order calls setter.call(sw.switch_name, val) twice (Duplication)
       OptionParser#parse_in_order calls sw.block twice (Duplication)
       OptionParser#parse_in_order calls sw.switch_name twice (Duplication)
+      OptionParser#parse_in_order contains iterators nested 2 deep (Nested Iterators)
+      OptionParser#parse_in_order contains iterators nested 3 deep (Nested Iterators)
       OptionParser#parse_in_order has approx 28 statements (Long Method)
-      OptionParser#parse_in_order/block is controlled by argument setter (Control Couple)
-      OptionParser#parse_in_order/block/block is nested (Nested Iterators)
-      OptionParser#parse_in_order/block/block/block is nested (Nested Iterators)
+      OptionParser#parse_in_order is controlled by argument setter (Control Couple)
       OptionParser#permute calls argv[0] twice (Duplication)
-      OptionParser#permute refers to argv more than self (Feature Envy)
-      OptionParser#search/block has the variable name 'k' (Uncommunicative Name)
+      OptionParser#permute refers to argv more than self (Low Cohesion)
+      OptionParser#search has the variable name 'k' (Uncommunicative Name)
       OptionParser#summarize has 4 parameters (Long Parameter List)
-      OptionParser#summarize/block has the variable name 'l' (Uncommunicative Name)
+      OptionParser#summarize has the variable name 'l' (Uncommunicative Name)
       OptionParser#ver has the variable name 'v' (Uncommunicative Name)
-      OptionParser/block has the variable name 'f' (Uncommunicative Name)
-      OptionParser/block has the variable name 'k' (Uncommunicative Name)
-      OptionParser/block has the variable name 'o' (Uncommunicative Name)
-      OptionParser/block has the variable name 's' (Uncommunicative Name)
-      OptionParser/block is controlled by argument o (Control Couple)
-      OptionParser/block is controlled by argument s (Control Couple)
-      OptionParser/block/block has the variable name 's' (Uncommunicative Name)
-      OptionParser/block/block has the variable name 'v' (Uncommunicative Name)
-      OptionParser/block/block is controlled by argument pkg (Control Couple)
-      OptionParser/block/block is nested (Nested Iterators)
-      OptionParser::CompletingHash#match/block/block is nested (Nested Iterators)
+      OptionParser::CompletingHash#match contains iterators nested 2 deep (Nested Iterators)
       OptionParser::Completion#complete calls candidates.size twice (Duplication)
       OptionParser::Completion#complete calls k.id2name twice (Duplication)
       OptionParser::Completion#complete has approx 22 statements (Long Method)
+      OptionParser::Completion#complete has boolean parameter 'icase' (Control Couple)
       OptionParser::Completion#complete has the variable name 'k' (Uncommunicative Name)
       OptionParser::Completion#complete has the variable name 'v' (Uncommunicative Name)
-      OptionParser::Completion#complete is controlled by argument icase (Control Couple)
-      OptionParser::Completion#complete refers to candidates more than self (Feature Envy)
-      OptionParser::Completion#complete/block has the variable name 'k' (Uncommunicative Name)
-      OptionParser::Completion#complete/block has the variable name 'v' (Uncommunicative Name)
-      OptionParser::List#accept has the variable name 't' (Uncommunicative Name)
+      OptionParser::Completion#complete refers to candidates more than self (Low Cohesion)
+      OptionParser::List#accept has the parameter name 't' (Uncommunicative Name)
       OptionParser::List#accept is controlled by argument pat (Control Couple)
-      OptionParser::List#accept refers to pat more than self (Feature Envy)
-      OptionParser::List#add_banner refers to opt more than self (Feature Envy)
+      OptionParser::List#accept refers to pat more than self (Low Cohesion)
+      OptionParser::List#add_banner refers to opt more than self (Low Cohesion)
       OptionParser::List#complete has 4 parameters (Long Parameter List)
-      OptionParser::List#complete is controlled by argument icase (Control Couple)
-      OptionParser::List#reject has the variable name 't' (Uncommunicative Name)
-      OptionParser::List#summarize refers to opt more than self (Feature Envy)
+      OptionParser::List#complete has boolean parameter 'icase' (Control Couple)
+      OptionParser::List#reject has the parameter name 't' (Uncommunicative Name)
+      OptionParser::List#summarize refers to opt more than self (Low Cohesion)
       OptionParser::List#update has 5 parameters (Long Parameter List)
       OptionParser::List#update has approx 6 statements (Long Method)
       OptionParser::List#update has the variable name 'o' (Uncommunicative Name)
       OptionParser::List#update is controlled by argument lopts (Control Couple)
       OptionParser::List#update is controlled by argument sopts (Control Couple)
-      OptionParser::List#update/block has the variable name 'o' (Uncommunicative Name)
       OptionParser::ParseError#set_option is controlled by argument eq (Control Couple)
       OptionParser::Switch#add_banner has the variable name 's' (Uncommunicative Name)
       OptionParser::Switch#conv_arg calls conv twice (Duplication)
@@ -162,7 +151,7 @@ Feature: Basic smell detection
       OptionParser::Switch#parse_arg has the variable name 'm' (Uncommunicative Name)
       OptionParser::Switch#parse_arg has the variable name 's' (Uncommunicative Name)
       OptionParser::Switch#self.guess has the variable name 't' (Uncommunicative Name)
-      OptionParser::Switch#self.incompatible_argument_styles has the variable name 't' (Uncommunicative Name)
+      OptionParser::Switch#self.incompatible_argument_styles has the parameter name 't' (Uncommunicative Name)
       OptionParser::Switch#summarize calls (indent + l) twice (Duplication)
       OptionParser::Switch#summarize calls arg 4 times (Duplication)
       OptionParser::Switch#summarize calls left.collect twice (Duplication)
@@ -171,18 +160,16 @@ Feature: Basic smell detection
       OptionParser::Switch#summarize calls left.shift twice (Duplication)
       OptionParser::Switch#summarize calls left[-1] 3 times (Duplication)
       OptionParser::Switch#summarize calls s.length 3 times (Duplication)
+      OptionParser::Switch#summarize contains iterators nested 2 deep (Nested Iterators)
       OptionParser::Switch#summarize has 5 parameters (Long Parameter List)
       OptionParser::Switch#summarize has approx 25 statements (Long Method)
       OptionParser::Switch#summarize has the variable name 'l' (Uncommunicative Name)
       OptionParser::Switch#summarize has the variable name 'r' (Uncommunicative Name)
       OptionParser::Switch#summarize has the variable name 's' (Uncommunicative Name)
-      OptionParser::Switch#summarize/block has the variable name 's' (Uncommunicative Name)
-      OptionParser::Switch#summarize/block/block is nested (Nested Iterators)
       OptionParser::Switch::NoArgument#parse is controlled by argument arg (Control Couple)
       OptionParser::Switch::OptionalArgument#parse is controlled by argument arg (Control Couple)
       OptionParser::Switch::PlacedArgument#parse has approx 6 statements (Long Method)
       OptionParser::Switch::RequiredArgument#parse is controlled by argument arg (Control Couple)
-      block has the variable name 'q' (Uncommunicative Name)
 
     """
 
@@ -191,84 +178,84 @@ Feature: Basic smell detection
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/redcloth.rb -- 96 warnings:
+    spec/samples/redcloth.rb -- 94 warnings:
       RedCloth has at least 44 methods (Large Class)
+      RedCloth has the variable name 'a' (Uncommunicative Name)
+      RedCloth has the variable name 'b' (Uncommunicative Name)
       RedCloth takes parameters [atts, cite, content, tag] to 3 methods (Data Clump)
       RedCloth tests atts at least 6 times (Simulated Polymorphism)
       RedCloth tests codepre.zero? at least 3 times (Simulated Polymorphism)
       RedCloth tests href at least 3 times (Simulated Polymorphism)
       RedCloth tests title at least 4 times (Simulated Polymorphism)
-      RedCloth#block_markdown_atx refers to text more than self (Feature Envy)
+      RedCloth#block_markdown_atx refers to text more than self (Low Cohesion)
       RedCloth#block_markdown_bq has approx 6 statements (Long Method)
-      RedCloth#block_markdown_rule refers to text more than self (Feature Envy)
-      RedCloth#block_markdown_setext refers to text more than self (Feature Envy)
+      RedCloth#block_markdown_rule refers to text more than self (Low Cohesion)
+      RedCloth#block_markdown_setext refers to text more than self (Low Cohesion)
       RedCloth#block_textile_lists calls (line_id - 1) twice (Duplication)
       RedCloth#block_textile_lists calls depth.last 5 times (Duplication)
       RedCloth#block_textile_lists calls depth.last.length twice (Duplication)
       RedCloth#block_textile_lists calls depth[i] twice (Duplication)
       RedCloth#block_textile_lists calls lines[(line_id - 1)] twice (Duplication)
       RedCloth#block_textile_lists calls tl.length 3 times (Duplication)
+      RedCloth#block_textile_lists contains iterators nested 3 deep (Nested Iterators)
       RedCloth#block_textile_lists has approx 20 statements (Long Method)
-      RedCloth#block_textile_lists refers to depth more than self (Feature Envy)
-      RedCloth#block_textile_lists/block/block is nested (Nested Iterators)
-      RedCloth#block_textile_lists/block/block/block has the variable name 'i' (Uncommunicative Name)
-      RedCloth#block_textile_lists/block/block/block has the variable name 'v' (Uncommunicative Name)
-      RedCloth#block_textile_lists/block/block/block is nested (Nested Iterators)
+      RedCloth#block_textile_lists has the variable name 'i' (Uncommunicative Name)
+      RedCloth#block_textile_lists has the variable name 'v' (Uncommunicative Name)
+      RedCloth#block_textile_lists refers to depth more than self (Low Cohesion)
+      RedCloth#block_textile_table contains iterators nested 2 deep (Nested Iterators)
+      RedCloth#block_textile_table contains iterators nested 3 deep (Nested Iterators)
       RedCloth#block_textile_table has approx 18 statements (Long Method)
-      RedCloth#block_textile_table/block/block has the variable name 'x' (Uncommunicative Name)
-      RedCloth#block_textile_table/block/block is nested (Nested Iterators)
-      RedCloth#block_textile_table/block/block/block is nested (Nested Iterators)
+      RedCloth#block_textile_table has the variable name 'x' (Uncommunicative Name)
+      RedCloth#blocks contains iterators nested 2 deep (Nested Iterators)
       RedCloth#blocks has approx 18 statements (Long Method)
+      RedCloth#blocks has boolean parameter 'deep_code' (Control Couple)
       RedCloth#blocks is controlled by argument deep_code (Control Couple)
-      RedCloth#blocks/block is controlled by argument deep_code (Control Couple)
-      RedCloth#blocks/block/block is nested (Nested Iterators)
       RedCloth#check_refs is controlled by argument text (Control Couple)
       RedCloth#clean_html calls tags[tag] twice (Duplication)
-      RedCloth#clean_html doesn't depend on instance state (Utility Function)
+      RedCloth#clean_html contains iterators nested 3 deep (Nested Iterators)
+      RedCloth#clean_html doesn't depend on instance state (Low Cohesion)
       RedCloth#clean_html has approx 14 statements (Long Method)
-      RedCloth#clean_html refers to raw more than self (Feature Envy)
-      RedCloth#clean_html refers to tags more than self (Feature Envy)
-      RedCloth#clean_html/block/block is nested (Nested Iterators)
-      RedCloth#clean_html/block/block/block has the variable name 'q' (Uncommunicative Name)
-      RedCloth#clean_html/block/block/block has the variable name 'q2' (Uncommunicative Name)
-      RedCloth#clean_html/block/block/block is nested (Nested Iterators)
+      RedCloth#clean_html has the variable name 'q' (Uncommunicative Name)
+      RedCloth#clean_html has the variable name 'q2' (Uncommunicative Name)
+      RedCloth#clean_html refers to raw more than self (Low Cohesion)
+      RedCloth#clean_html refers to tags more than self (Low Cohesion)
       RedCloth#clean_white_space has approx 7 statements (Long Method)
-      RedCloth#clean_white_space refers to text more than self (Feature Envy)
-      RedCloth#flush_left doesn't depend on instance state (Utility Function)
-      RedCloth#flush_left refers to indt more than self (Feature Envy)
-      RedCloth#flush_left refers to text more than self (Feature Envy)
-      RedCloth#footnote_ref refers to text more than self (Feature Envy)
+      RedCloth#clean_white_space refers to text more than self (Low Cohesion)
+      RedCloth#flush_left doesn't depend on instance state (Low Cohesion)
+      RedCloth#flush_left refers to indt more than self (Low Cohesion)
+      RedCloth#flush_left refers to text more than self (Low Cohesion)
+      RedCloth#footnote_ref refers to text more than self (Low Cohesion)
       RedCloth#glyphs_textile has approx 10 statements (Long Method)
-      RedCloth#htmlesc doesn't depend on instance state (Utility Function)
-      RedCloth#htmlesc refers to str more than self (Feature Envy)
-      RedCloth#incoming_entities refers to text more than self (Feature Envy)
-      RedCloth#initialize/block has the variable name 'r' (Uncommunicative Name)
-      RedCloth#inline/block/block is nested (Nested Iterators)
+      RedCloth#htmlesc doesn't depend on instance state (Low Cohesion)
+      RedCloth#htmlesc refers to str more than self (Low Cohesion)
+      RedCloth#incoming_entities refers to text more than self (Low Cohesion)
+      RedCloth#initialize has the variable name 'r' (Uncommunicative Name)
+      RedCloth#inline contains iterators nested 2 deep (Nested Iterators)
       RedCloth#inline_markdown_link has approx 6 statements (Long Method)
-      RedCloth#inline_markdown_link/block has the variable name 'm' (Uncommunicative Name)
+      RedCloth#inline_markdown_link has the variable name 'm' (Uncommunicative Name)
       RedCloth#inline_markdown_reflink has approx 8 statements (Long Method)
-      RedCloth#inline_markdown_reflink/block has the variable name 'm' (Uncommunicative Name)
-      RedCloth#inline_textile_code/block has the variable name 'm' (Uncommunicative Name)
+      RedCloth#inline_markdown_reflink has the variable name 'm' (Uncommunicative Name)
+      RedCloth#inline_textile_code has the variable name 'm' (Uncommunicative Name)
       RedCloth#inline_textile_image has approx 17 statements (Long Method)
-      RedCloth#inline_textile_image/block has the variable name 'href_a1' (Uncommunicative Name)
-      RedCloth#inline_textile_image/block has the variable name 'href_a2' (Uncommunicative Name)
-      RedCloth#inline_textile_image/block has the variable name 'm' (Uncommunicative Name)
+      RedCloth#inline_textile_image has the variable name 'href_a1' (Uncommunicative Name)
+      RedCloth#inline_textile_image has the variable name 'href_a2' (Uncommunicative Name)
+      RedCloth#inline_textile_image has the variable name 'm' (Uncommunicative Name)
       RedCloth#inline_textile_link has approx 9 statements (Long Method)
-      RedCloth#inline_textile_link/block has the variable name 'm' (Uncommunicative Name)
+      RedCloth#inline_textile_link has the variable name 'm' (Uncommunicative Name)
+      RedCloth#inline_textile_span contains iterators nested 2 deep (Nested Iterators)
       RedCloth#inline_textile_span has approx 8 statements (Long Method)
-      RedCloth#inline_textile_span/block/block has the variable name 'm' (Uncommunicative Name)
-      RedCloth#inline_textile_span/block/block is nested (Nested Iterators)
-      RedCloth#no_textile doesn't depend on instance state (Utility Function)
-      RedCloth#no_textile refers to text more than self (Feature Envy)
+      RedCloth#inline_textile_span has the variable name 'm' (Uncommunicative Name)
+      RedCloth#no_textile doesn't depend on instance state (Low Cohesion)
+      RedCloth#no_textile refers to text more than self (Low Cohesion)
       RedCloth#pba calls $1.length twice (Duplication)
       RedCloth#pba has approx 21 statements (Long Method)
       RedCloth#pba is controlled by argument text_in (Control Couple)
-      RedCloth#pba refers to style more than self (Feature Envy)
-      RedCloth#pba refers to text more than self (Feature Envy)
-      RedCloth#refs_markdown/block has the variable name 'm' (Uncommunicative Name)
-      RedCloth#refs_textile/block has the variable name 'm' (Uncommunicative Name)
-      RedCloth#retrieve/block has the variable name 'i' (Uncommunicative Name)
-      RedCloth#retrieve/block has the variable name 'r' (Uncommunicative Name)
+      RedCloth#pba refers to style more than self (Low Cohesion)
+      RedCloth#pba refers to text more than self (Low Cohesion)
+      RedCloth#refs_markdown has the variable name 'm' (Uncommunicative Name)
+      RedCloth#refs_textile has the variable name 'm' (Uncommunicative Name)
+      RedCloth#retrieve has the variable name 'i' (Uncommunicative Name)
+      RedCloth#retrieve has the variable name 'r' (Uncommunicative Name)
       RedCloth#rip_offtags calls ((codepre - used_offtags.length) > 0) twice (Duplication)
       RedCloth#rip_offtags calls (@pre_list.last << line) twice (Duplication)
       RedCloth#rip_offtags calls (codepre - used_offtags.length) twice (Duplication)
@@ -286,7 +273,5 @@ Feature: Basic smell detection
       RedCloth#textile_p has 4 parameters (Long Parameter List)
       RedCloth#textile_p is controlled by argument atts (Control Couple)
       RedCloth#to_html has approx 24 statements (Long Method)
-      RedCloth/block has the variable name 'a' (Uncommunicative Name)
-      RedCloth/block has the variable name 'b' (Uncommunicative Name)
 
     """

data/features/stdin.feature

@@ -25,18 +25,15 @@ Feature: Reek reads from $stdin when no files are given
   Scenario: outputs nothing on empty stdin in quiet mode
     When I pass "" to reek --quiet
     Then it succeeds
-    And it reports:
-      """
-
-
-      """
+    And stdout equals ""
 
   Scenario: return non-zero status when there are smells
     When I pass "class Turn; def y() @x = 3; end end" to reek
     Then the exit status indicates smells
     And it reports:
       """
-      $stdin -- 2 warnings:
+      $stdin -- 3 warnings:
+        Turn has no descriptive comment (Irresponsible Module)
         Turn has the variable name '@x' (Uncommunicative Name)
         Turn#y has the name 'y' (Uncommunicative Name)
 

data/features/step_definitions/reek_steps.rb

@@ -14,16 +14,20 @@ Then /^stdout equals "([^\"]*)"$/ do |report|
   @last_stdout.should == report
 end
 
+Then /^stdout includes \/([^\"]*)\/$/ do |report|
+  @last_stdout.should match(report)
+end
+
 Then /^it succeeds$/ do
-  @last_exit_status.should == Reek::Application::STATUS_SUCCESS
+  @last_exit_status.should == Reek::Cli::Application::STATUS_SUCCESS
 end
 
 Then /^the exit status indicates an error$/ do
-  @last_exit_status.should == Reek::Application::STATUS_ERROR
+  @last_exit_status.should == Reek::Cli::Application::STATUS_ERROR
 end
 
 Then /^the exit status indicates smells$/ do
-  @last_exit_status.should == Reek::Application::STATUS_SMELLS
+  @last_exit_status.should == Reek::Cli::Application::STATUS_SMELLS
 end
 
 Then /^it reports:$/ do |report|
@@ -39,5 +43,5 @@ Then /^it reports the error ['"](.*)['"]$/ do |string|
 end
 
 Then /^it reports the current version$/ do
-  @last_stdout.chomp.should == "reek #{Reek::VERSION}"
+  @last_stdout.should == "reek #{Reek::VERSION}\n"
 end

data/features/support/env.rb

@@ -4,8 +4,7 @@ require 'rubygems'
 require 'tempfile'
 require 'spec/expectations'
 require 'fileutils'
-require 'reek'
-require 'reek/adapters/application'
+require 'reek/cli/application'
 
 class ReekWorld
   def run(cmd)
@@ -27,7 +26,7 @@ class ReekWorld
   def rake(name, task_def)
     header = <<EOS
 $:.unshift('lib')
-require 'reek/adapters/rake_task'
+require 'reek/rake/task'
 
 EOS
     rakefile = Tempfile.new('rake_task', '.')

data/features/yaml.feature

@@ -0,0 +1,124 @@
+@yaml
+Feature: Report smells using simple YAML layout
+  In order to parse reek's output simply and consistently, simply
+  output a list of smells in Yaml.
+
+  Scenario: output is empty when there are no smells
+    When I run reek --yaml spec/samples/three_clean_files
+    Then it succeeds
+    And stdout equals ""
+
+  @masking
+  Scenario: masked smells always appear
+    When I run reek --yaml spec/samples/masked/dirty.rb
+    Then the exit status indicates smells
+    And it reports:
+      """
+      --- 
+      - !ruby/object:Reek::SmellWarning 
+        location: 
+          lines: 
+          - 5
+          context: Dirty
+          source: spec/samples/masked/dirty.rb
+        smell: 
+          class: UncommunicativeName
+          subclass: UncommunicativeVariableName
+          variable_name: "@s"
+          message: has the variable name '@s'
+        status: 
+          is_active: false
+      - !ruby/object:Reek::SmellWarning 
+        location: 
+          lines: 
+          - 4
+          - 6
+          context: Dirty#a
+          source: spec/samples/masked/dirty.rb
+        smell: 
+          class: Duplication
+          occurrences: 2
+          subclass: DuplicateMethodCall
+          call: "@s.title"
+          message: calls @s.title twice
+        status: 
+          is_active: true
+      - !ruby/object:Reek::SmellWarning 
+        location: 
+          lines: 
+          - 5
+          - 7
+          context: Dirty#a
+          source: spec/samples/masked/dirty.rb
+        smell: 
+          class: Duplication
+          occurrences: 2
+          subclass: DuplicateMethodCall
+          call: puts(@s.title)
+          message: calls puts(@s.title) twice
+        status: 
+          is_active: true
+      - !ruby/object:Reek::SmellWarning 
+        location: 
+          lines: 
+          - 5
+          context: Dirty#a
+          source: spec/samples/masked/dirty.rb
+        smell: 
+          class: NestedIterators
+          depth: 2
+          subclass: ""
+          message: contains iterators nested 2 deep
+        status: 
+          is_active: true
+      - !ruby/object:Reek::SmellWarning 
+        location: 
+          lines: 
+          - 3
+          context: Dirty#a
+          source: spec/samples/masked/dirty.rb
+        smell: 
+          method_name: a
+          class: UncommunicativeName
+          subclass: UncommunicativeMethodName
+          message: has the name 'a'
+        status: 
+          is_active: false
+      - !ruby/object:Reek::SmellWarning 
+        location: 
+          lines: 
+          - 5
+          context: Dirty#a
+          source: spec/samples/masked/dirty.rb
+        smell: 
+          class: UncommunicativeName
+          subclass: UncommunicativeVariableName
+          variable_name: x
+          message: has the variable name 'x'
+        status: 
+          is_active: false
+
+      """
+
+  @stdin
+  Scenario: return non-zero status when there are smells
+    When I pass "# test class\nclass Turn; def fred(arg = true) end end" to reek --yaml
+    Then the exit status indicates smells
+    And it reports:
+      """
+      --- 
+      - !ruby/object:Reek::SmellWarning 
+        location: 
+          lines: 
+          - 2
+          context: Turn#fred
+          source: $stdin
+        smell: 
+          parameter: arg
+          class: ControlCouple
+          subclass: BooleanParameter
+          message: has boolean parameter 'arg'
+        status: 
+          is_active: true
+
+      """