reek 1.2.3 → 1.2.4

data/spec/reek/method_context_spec.rb

@@ -7,7 +7,7 @@ include Reek
 
 describe MethodContext, 'matching' do
   before :each do
-    @element = MethodContext.new(StopContext.new, s(0, :mod), s(:module, :mod, nil))
+    @element = MethodContext.new(StopContext.new, s(0, :mod))
   end
 
   it 'should recognise itself in a collection of names' do
@@ -64,3 +64,45 @@ describe MethodContext do
     mc.envious_receivers.should be_empty
   end
 end
+
+describe MethodParameters, 'default assignments' do
+  def assignments_from(src)
+    exp = src.to_reek_source.syntax_tree
+    ctx = MethodContext.new(StopContext.new, exp)
+    return ctx.parameters.default_assignments
+  end
+
+  context 'with no defaults' do
+    it 'returns an empty hash' do
+      src = 'def meth(arga, argb, &blk) end'
+      assignments_from(src).should be_empty
+    end
+  end
+
+  context 'with 1 default' do
+    before :each do
+      src = "def meth(arga, argb=456, &blk) end"
+      @defaults = assignments_from(src)
+    end
+    it 'returns the param-value pair' do
+      @defaults[:argb].should == s(:lit, 456)
+    end
+    it 'returns the nothing else' do
+      @defaults.length.should == 1
+    end
+  end
+
+  context 'with 2 defaults' do
+    before :each do
+      src = "def meth(arga=123, argb=456, &blk) end"
+      @defaults = assignments_from(src)
+    end
+    it 'returns both param-value pairs' do
+      @defaults[:arga].should == s(:lit, 123)
+      @defaults[:argb].should == s(:lit, 456)
+    end
+    it 'returns nothing else' do
+      @defaults.length.should == 2
+    end
+  end
+end

data/spec/reek/reek_command_spec.rb

@@ -0,0 +1,45 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+require 'reek/reek_command'
+
+include Reek
+
+describe ReekCommand do
+  before :each do
+    @view = mock('view', :null_object => true)
+  end
+
+  context 'with smells' do
+    before :each do
+      src = 'def x(); end'
+      @cmd = ReekCommand.new(src, QuietReport, false)
+    end
+
+    it 'displays the correct text on the view' do
+      @view.should_receive(:output).with(/Uncommunicative Name/)
+      @cmd.execute(@view)
+    end
+
+    it 'tells the view it succeeded' do
+      @view.should_receive(:report_smells)
+      @cmd.execute(@view)
+    end
+  end
+
+  context 'with no smells' do
+    before :each do
+      src = 'def clean(); end'
+      @cmd = ReekCommand.new(src, QuietReport, false)
+    end
+
+    it 'displays nothing on the view' do
+      @view.should_receive(:output).with('')
+      @cmd.execute(@view)
+    end
+
+    it 'tells the view it succeeded' do
+      @view.should_receive(:report_success)
+      @cmd.execute(@view)
+    end
+  end
+end

data/spec/reek/smell_warning_spec.rb

@@ -22,6 +22,10 @@ describe SmellWarning, 'equality' do
       it 'should compare equal when using <=>' do
         (@first <=> @second).should == 0
       end
+      it 'matches using eql?' do
+        @first.should eql(@second)
+        @second.should eql(@first)
+      end
     end
 
     shared_examples_for 'first sorts ahead of second' do
@@ -34,12 +38,16 @@ describe SmellWarning, 'equality' do
       it 'sort correctly' do
         (@first <=> @second).should be < 0
       end
+      it 'does not match using eql?' do
+        @first.should_not eql(@second)
+        @second.should_not eql(@first)
+      end
     end
 
     context 'smells differing only by detector' do
       before :each do
-        @first = SmellWarning.new(Smells::Duplication.new, "self", "self", true)
-        @second = SmellWarning.new(Smells::FeatureEnvy.new, "self", "self", false)
+        @first = SmellWarning.new(Smells::Duplication.new, "self", "self", false)
+        @second = SmellWarning.new(Smells::FeatureEnvy.new, "self", "self", true)
       end
 
       it_should_behave_like 'first sorts ahead of second'
@@ -88,11 +96,11 @@ describe SmellWarning, 'equality' do
       def initialize
         @masked = @non_masked = 0
       end
-      def <<(sw)
+      def found_smell(sw)
         @non_masked += 1
       end
 
-      def record_masked_smell(sw)
+      def found_masked_smell(sw)
         @masked += 1
       end
     end

data/spec/reek/smells/attribute_spec.rb

@@ -3,24 +3,96 @@ require File.dirname(__FILE__) + '/../../spec_helper.rb'
 require 'reek/smells/attribute'
 require 'reek/class_context'
 
-require 'spec/reek/smells/behaves_like_variable_detector'
-
 include Reek
 include Reek::Smells
 
 describe Attribute do
   before :each do
     @detector = Attribute.new
-    @record_variable = :record_attribute
   end
+  context 'with no attributes' do
+    it 'records nothing in the class' do
+      ctx = ClassContext.from_s('class Fred; end')
+      @detector.attributes_in(ctx).should be_empty
+    end
+    it 'records nothing in the module' do
+      ctx = ModuleContext.from_s('module Fred; end')
+      @detector.attributes_in(ctx).should be_empty
+    end
+  end
+
+  context 'with one attribute' do
+    shared_examples_for 'one attribute found' do
+      it 'records the attribute' do
+        @detector.attributes_in(@ctx).should include(:property)
+      end
+      it 'records only that attribute' do
+        @detector.attributes_in(@ctx).length.should == 1
+      end
+    end
+
+    context 'declared in a class' do
+      before :each do
+        @ctx = ClassContext.from_s('class Fred; attr :property; end')
+      end
+
+      it_should_behave_like 'one attribute found'
+    end
+
+    context 'reader in a class' do
+      before :each do
+        @ctx = ClassContext.from_s('class Fred; attr_reader :property; end')
+      end
+
+      it_should_behave_like 'one attribute found'
+    end
+
+    context 'writer in a class' do
+      before :each do
+        @ctx = ClassContext.from_s('class Fred; attr_writer :property; end')
+      end
+
+      it_should_behave_like 'one attribute found'
+    end
+
+    context 'accessor in a class' do
+      before :each do
+        @ctx = ClassContext.from_s('class Fred; attr_accessor :property; end')
+      end
+
+      it_should_behave_like 'one attribute found'
+    end
+
+    context 'declared in a module' do
+      before :each do
+        @ctx = ModuleContext.from_s('module Fred; attr :property; end')
+      end
+
+      it_should_behave_like 'one attribute found'
+    end
+
+    context 'reader in a module' do
+      before :each do
+        @ctx = ModuleContext.from_s('module Fred; attr_reader :property; end')
+      end
+
+      it_should_behave_like 'one attribute found'
+    end
+
+    context 'writer in a module' do
+      before :each do
+        @ctx = ModuleContext.from_s('module Fred; attr_writer :property; end')
+      end
+
+      it_should_behave_like 'one attribute found'
+    end
 
-  [ClassContext, ModuleContext].each do |klass|
-    context "in a #{klass}" do
+    context 'accessor in a module' do
       before :each do
-        @ctx = klass.create(StopContext.new, s(:null, :Fred))
+        @ctx = ModuleContext.from_s('module Fred; attr_accessor :property; end')
       end
 
-      it_should_behave_like 'a variable detector'
+      it_should_behave_like 'one attribute found'
     end
   end
 end

data/spec/reek/smells/control_couple_spec.rb

@@ -5,19 +5,48 @@ require 'reek/smells/control_couple'
 include Reek::Smells
 
 describe ControlCouple do
-  it 'should report a ternary check on a parameter' do
-    'def simple(arga) arga ? @ivar : 3 end'.should reek_only_of(:ControlCouple, /arga/)
+  context 'conditional on a parameter' do
+    it 'should report a ternary check on a parameter' do
+      'def simple(arga) arga ? @ivar : 3 end'.should reek_only_of(:ControlCouple, /arga/)
+    end
+    it 'should not report a ternary check on an ivar' do
+      'def simple(arga) @ivar ? arga : 3 end'.should_not reek
+    end
+    it 'should not report a ternary check on a lvar' do
+      'def simple(arga) lvar = 27; lvar ? arga : @ivar end'.should_not reek
+    end
+    it 'should spot a couple inside a block' do
+      'def blocks(arg) @text.map { |blk| arg ? blk : "#{blk}" } end'.should reek_of(:ControlCouple, /arg/)
+    end
   end
 
-  it 'should not report a ternary check on an ivar' do
-    'def simple(arga) @ivar ? arga : 3 end'.should_not reek
-  end
-
-  it 'should not report a ternary check on a lvar' do
-    'def simple(arga) lvar = 27; lvar ? arga : @ivar end'.should_not reek
-  end
+  context 'parameter defaulted with boolean' do
+    context 'in a method' do
+      it 'reports a parameter defaulted to true' do
+        'def cc(arga = true) end'.should reek_of(:ControlCouple, /arga/)
+      end
+      it 'reports a parameter defaulted to false' do
+        'def cc(arga = false) end'.should reek_of(:ControlCouple, /arga/)
+      end
+      it 'reports two parameters defaulted to booleans' do
+        src = 'def cc(nowt, arga = true, argb = false, &blk) end'
+        src.should reek_of(:ControlCouple, /arga/)
+        src.should reek_of(:ControlCouple, /argb/)
+      end
+    end
 
-  it 'should spot a couple inside a block' do
-    'def blocks(arg) @text.map { |blk| arg ? blk : "#{blk}" } end'.should reek_of(:ControlCouple, /arg/)
+    context 'in a singleton method' do
+      it 'reports a parameter defaulted to true' do
+        'def self.cc(arga = true) end'.should reek_of(:ControlCouple, /arga/)
+      end
+      it 'reports a parameter defaulted to false' do
+        'def fred.cc(arga = false) end'.should reek_of(:ControlCouple, /arga/)
+      end
+      it 'reports two parameters defaulted to booleans' do
+        src = 'def Module.cc(nowt, arga = true, argb = false, &blk) end'
+        src.should reek_of(:ControlCouple, /arga/)
+        src.should reek_of(:ControlCouple, /argb/)
+      end
+    end
   end
 end

data/spec/reek/smells/long_parameter_list_spec.rb

@@ -50,7 +50,7 @@ describe LongParameterList do
         'def simple(polly, queue, yep, zero=nil) f(3);false end'.should reek_only_of(:LongParameterList, /4 parameters/)
       end
       it 'should report with 3 defaulted' do
-        'def simple(aarg, polly=2, yep=true, zero=nil) f(3);false end'.should reek_only_of(:LongParameterList, /4 parameters/)
+        'def simple(aarg, polly=2, yep=:truth, zero=nil) f(3);false end'.should reek_only_of(:LongParameterList, /4 parameters/)
       end
     end
   end

data/spec/reek/smells/smell_detector_spec.rb

@@ -19,23 +19,6 @@ describe SmellDetector, 'configuration' do
   end
 end
 
-describe SmellDetector, 'when copied' do
-  before :each do
-    @detector = LongMethod.new
-    @copy = @detector.copy
-  end
-
-  it 'should have the same state' do
-    @copy.max_statements.should == @detector.max_statements
-  end
-
-  it 'should change independently of its parent' do
-    default_max = @detector.max_statements
-    @copy.configure_with(LongMethod::MAX_ALLOWED_STATEMENTS_KEY => 25)
-    @detector.max_statements.should == default_max
-  end
-end
-
 describe SmellDetector, 'configuration' do
 #  it 'stays enabled when not disabled' do
 #    @detector = LargeClass.new

data/spec/reek/tree_dresser_spec.rb

@@ -0,0 +1,20 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+require 'reek/tree_dresser'
+
+include Reek
+
+describe TreeDresser do
+  before(:each) do
+    @dresser = TreeDresser.new
+  end
+
+  it 'maps :if to IfNode' do
+    @dresser.extensions_for(:if).should == 'IfNode'
+  end
+
+  it 'maps :call to CallNode' do
+    @dresser.extensions_for(:call).should == 'CallNode'
+  end
+end
+

data/spec/reek/version_command_spec.rb

@@ -0,0 +1,29 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+require 'reek/version_command'
+
+include Reek
+
+describe VersionCommand do
+  before :each do
+    @text = 'Piece of interesting text'
+    @cmd = VersionCommand.new(@text)
+    @view = mock('view', :null_object => true)
+    @view.should_not_receive(:report_smells)
+  end
+
+  it 'displays the text on the view' do
+    @view.should_receive(:output).with(/#{@text}/)
+    @cmd.execute(@view)
+  end
+
+  it 'displays the Reek version on the view' do
+    @view.should_receive(:output).with(/#{Reek::VERSION}/)
+    @cmd.execute(@view)
+  end
+
+  it 'tells the view it succeeded' do
+    @view.should_receive(:report_success)
+    @cmd.execute(@view)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: reek
 version: !ruby/object:Gem::Version 
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-02 00:00:00 +00:00
+date: 2009-11-17 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -84,11 +84,14 @@ files:
 - lib/reek/code_parser.rb
 - lib/reek/configuration.rb
 - lib/reek/detector_stack.rb
+- lib/reek/help_command.rb
 - lib/reek/if_context.rb
+- lib/reek/masking_collection.rb
 - lib/reek/method_context.rb
 - lib/reek/module_context.rb
 - lib/reek/name.rb
 - lib/reek/object_refs.rb
+- lib/reek/reek_command.rb
 - lib/reek/sexp_formatter.rb
 - lib/reek/singleton_method_context.rb
 - lib/reek/smell_warning.rb
@@ -110,6 +113,7 @@ files:
 - lib/reek/sniffer.rb
 - lib/reek/stop_context.rb
 - lib/reek/tree_dresser.rb
+- lib/reek/version_command.rb
 - lib/reek/yield_call_context.rb
 - reek.gemspec
 - spec/reek/adapters/report_spec.rb
@@ -122,12 +126,15 @@ files:
 - spec/reek/code_parser_spec.rb
 - spec/reek/config_spec.rb
 - spec/reek/configuration_spec.rb
+- spec/reek/help_command_spec.rb
 - spec/reek/if_context_spec.rb
+- spec/reek/masking_collection_spec.rb
 - spec/reek/method_context_spec.rb
 - spec/reek/module_context_spec.rb
 - spec/reek/name_spec.rb
 - spec/reek/object_refs_spec.rb
 - spec/reek/object_source_spec.rb
+- spec/reek/reek_command_spec.rb
 - spec/reek/singleton_method_context_spec.rb
 - spec/reek/smell_warning_spec.rb
 - spec/reek/smells/attribute_spec.rb
@@ -147,6 +154,8 @@ files:
 - spec/reek/smells/utility_function_spec.rb
 - spec/reek/sniffer_spec.rb
 - spec/reek/stop_context_spec.rb
+- spec/reek/tree_dresser_spec.rb
+- spec/reek/version_command_spec.rb
 - spec/samples/all_but_one_masked/clean_one.rb
 - spec/samples/all_but_one_masked/dirty.rb
 - spec/samples/all_but_one_masked/masked.reek