reek 1.2.2 → 1.2.3

Sign up to get free protection for your applications and to get access to all the features.
Files changed (59) hide show
  1. data/History.txt +4 -0
  2. data/Rakefile +0 -1
  3. data/config/defaults.reek +4 -6
  4. data/features/masking_smells.feature +9 -9
  5. data/features/options.feature +2 -2
  6. data/features/profile.feature +34 -0
  7. data/features/rake_task.feature +74 -0
  8. data/features/reports.feature +1 -1
  9. data/features/samples.feature +4 -4
  10. data/features/stdin.feature +1 -1
  11. data/features/step_definitions/reek_steps.rb +11 -7
  12. data/features/support/env.rb +26 -18
  13. data/lib/reek.rb +1 -1
  14. data/lib/reek/adapters/application.rb +9 -2
  15. data/lib/reek/adapters/command_line.rb +2 -2
  16. data/lib/reek/adapters/source.rb +4 -1
  17. data/lib/reek/adapters/spec.rb +1 -3
  18. data/lib/reek/block_context.rb +14 -8
  19. data/lib/reek/class_context.rb +6 -66
  20. data/lib/reek/code_context.rb +10 -0
  21. data/lib/reek/code_parser.rb +25 -53
  22. data/lib/reek/configuration.rb +12 -6
  23. data/lib/reek/if_context.rb +2 -3
  24. data/lib/reek/method_context.rb +3 -12
  25. data/lib/reek/module_context.rb +30 -22
  26. data/lib/reek/name.rb +2 -0
  27. data/lib/reek/object_refs.rb +0 -3
  28. data/lib/reek/sexp_formatter.rb +0 -2
  29. data/lib/reek/smells/class_variable.rb +17 -4
  30. data/lib/reek/smells/control_couple.rb +3 -10
  31. data/lib/reek/smells/data_clump.rb +10 -10
  32. data/lib/reek/smells/feature_envy.rb +1 -8
  33. data/lib/reek/smells/large_class.rb +3 -3
  34. data/lib/reek/smells/simulated_polymorphism.rb +17 -3
  35. data/lib/reek/smells/smell_detector.rb +11 -2
  36. data/lib/reek/smells/utility_function.rb +1 -1
  37. data/lib/reek/sniffer.rb +0 -8
  38. data/lib/reek/stop_context.rb +1 -1
  39. data/lib/reek/tree_dresser.rb +74 -0
  40. data/reek.gemspec +3 -3
  41. data/spec/reek/block_context_spec.rb +6 -6
  42. data/spec/reek/class_context_spec.rb +2 -23
  43. data/spec/reek/code_context_spec.rb +149 -67
  44. data/spec/reek/code_parser_spec.rb +0 -102
  45. data/spec/reek/method_context_spec.rb +4 -4
  46. data/spec/reek/singleton_method_context_spec.rb +1 -1
  47. data/spec/reek/smells/attribute_spec.rb +1 -1
  48. data/spec/reek/smells/class_variable_spec.rb +96 -7
  49. data/spec/reek/smells/control_couple_spec.rb +1 -1
  50. data/spec/reek/smells/data_clump_spec.rb +31 -13
  51. data/spec/reek/smells/feature_envy_spec.rb +1 -1
  52. data/spec/reek/smells/large_class_spec.rb +32 -18
  53. data/spec/reek/smells/simulated_polymorphism_spec.rb +66 -18
  54. data/spec/reek/sniffer_spec.rb +1 -0
  55. data/spec/samples/not_quite_masked/dirty.rb +2 -0
  56. data/spec/spec_helper.rb +1 -1
  57. data/tasks/reek.rake +1 -1
  58. metadata +5 -3
  59. data/lib/reek/exceptions.reek +0 -20
@@ -7,4 +7,5 @@ describe Sniffer do
7
7
  dirty_file = Dir['spec/samples/two_smelly_files/*.rb'][0]
8
8
  File.new(dirty_file).sniff.should be_smelly
9
9
  end
10
+
10
11
  end
@@ -1,4 +1,6 @@
1
1
  class Dirty
2
+ attr_reader :property
3
+
2
4
  def a
3
5
  puts @s.title
4
6
  @s.map {|x| x.each {|key| key += 3}}
data/spec/spec_helper.rb CHANGED
@@ -1,9 +1,9 @@
1
1
  $:.unshift File.dirname(__FILE__) + '/../lib'
2
2
 
3
+ require 'rubygems'
3
4
  begin
4
5
  require 'spec/expectations'
5
6
  rescue LoadError
6
- require 'rubygems'
7
7
  gem 'rspec'
8
8
  require 'spec/expectations'
9
9
  end
data/tasks/reek.rake CHANGED
@@ -4,7 +4,7 @@ begin
4
4
  Reek::RakeTask.new do |t|
5
5
  t.fail_on_error = true
6
6
  t.verbose = false
7
- t.reek_opts = '--quiet --show-all'
7
+ t.reek_opts = '--quiet'
8
8
  end
9
9
  rescue Gem::LoadError
10
10
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: reek
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.2.2
4
+ version: 1.2.3
5
5
  platform: ruby
6
6
  authors:
7
7
  - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
11
 
12
- date: 2009-10-06 00:00:00 +01:00
12
+ date: 2009-11-02 00:00:00 +00:00
13
13
  default_executable:
14
14
  dependencies:
15
15
  - !ruby/object:Gem::Dependency
@@ -62,6 +62,8 @@ files:
62
62
  - config/defaults.reek
63
63
  - features/masking_smells.feature
64
64
  - features/options.feature
65
+ - features/profile.feature
66
+ - features/rake_task.feature
65
67
  - features/reports.feature
66
68
  - features/samples.feature
67
69
  - features/stdin.feature
@@ -82,7 +84,6 @@ files:
82
84
  - lib/reek/code_parser.rb
83
85
  - lib/reek/configuration.rb
84
86
  - lib/reek/detector_stack.rb
85
- - lib/reek/exceptions.reek
86
87
  - lib/reek/if_context.rb
87
88
  - lib/reek/method_context.rb
88
89
  - lib/reek/module_context.rb
@@ -108,6 +109,7 @@ files:
108
109
  - lib/reek/smells/utility_function.rb
109
110
  - lib/reek/sniffer.rb
110
111
  - lib/reek/stop_context.rb
112
+ - lib/reek/tree_dresser.rb
111
113
  - lib/reek/yield_call_context.rb
112
114
  - reek.gemspec
113
115
  - spec/reek/adapters/report_spec.rb
@@ -1,20 +0,0 @@
1
- ---
2
- Duplication:
3
- exclude:
4
- - Reek::Options#set_options
5
- FeatureEnvy:
6
- exclude:
7
- - examine_context
8
- LargeClass:
9
- exclude:
10
- - CodeParser
11
- LongMethod:
12
- exclude:
13
- - Reek::SexpFormatter#self.format
14
- - Reek::Options#set_options
15
- UncommunicativeName:
16
- accept:
17
- - process_op_asgn1
18
- UtilityFunction:
19
- exclude:
20
- - Reek::Spec