reek 1.2.12 → 1.2.13
Sign up to get free protection for your applications and to get access to all the features.
- data/CHANGELOG +5 -0
- data/README.md +37 -5
- data/lib/reek/core/smell_repository.rb +19 -19
- data/lib/reek/rake/task.rb +1 -1
- data/lib/reek/source/source_locator.rb +2 -2
- data/lib/reek/version.rb +1 -1
- data/reek.gemspec +1 -1
- data/spec/matchers/smell_of_matcher.rb +1 -1
- data/spec/reek/cli/help_command_spec.rb +1 -1
- data/spec/reek/cli/reek_command_spec.rb +1 -1
- data/spec/reek/cli/version_command_spec.rb +1 -1
- data/spec/reek/cli/yaml_command_spec.rb +1 -1
- data/spec/reek/core/method_context_spec.rb +1 -1
- data/spec/reek/smells/long_method_spec.rb +1 -1
- data/spec/reek/spec/should_reek_only_of_spec.rb +1 -1
- data/spec/spec_helper.rb +10 -9
- data/tasks/test.rake +13 -13
- metadata +148 -149
data/CHANGELOG
CHANGED
data/README.md
CHANGED
@@ -59,13 +59,45 @@ Simulated Polymorphism, Uncommunicative Name and more.
|
|
59
59
|
See the [Reek wiki](http://wiki.github.com/troessner/reek/code-smells)
|
60
60
|
for up to date details of exactly what Reek will check in your code.
|
61
61
|
|
62
|
-
###
|
62
|
+
### Integration
|
63
|
+
|
64
|
+
Basically there are two ways to use reek in your project except for the obvious static code analysis:
|
65
|
+
|
66
|
+
(1) Use Reek's [Rake Task](https://github.com/troessner/reek/wiki/Rake-Task) to easily add Reek to your Rakefile
|
67
|
+
|
68
|
+
(2) Add Reek's custom matcher to your Rspec examples like this:
|
69
|
+
|
70
|
+
```Ruby
|
71
|
+
require 'rubygems'
|
72
|
+
require 'spec'
|
73
|
+
require 'reek'
|
74
|
+
require 'reek/spec'
|
75
|
+
require 'reek/spec'
|
76
|
+
|
77
|
+
include Reek::Spec
|
78
|
+
|
79
|
+
my_precious_code = 'class C; def m; end; end'
|
80
|
+
my_precious_code.should_not reek # Well, it does.
|
81
|
+
```
|
63
82
|
|
64
|
-
|
83
|
+
## Contributing
|
65
84
|
|
66
|
-
*
|
67
|
-
*
|
68
|
-
*
|
85
|
+
* Fork the repo
|
86
|
+
* Create a feature branch
|
87
|
+
* Make sure the tests pass (see below)
|
88
|
+
* Submit a pull request
|
89
|
+
|
90
|
+
### Running the tests
|
91
|
+
|
92
|
+
Either just `rake` to run all or, if you want to be specific:
|
93
|
+
|
94
|
+
```bash
|
95
|
+
spec spec/your/file # Runs all tests
|
96
|
+
spec spec/your/file -l 23 # Runs test in line 23
|
97
|
+
spec spec/your/file -u # Runs all tests stopping at the breakpoints you have set before with `debugger`
|
98
|
+
```
|
99
|
+
|
100
|
+
### Tool Integration
|
69
101
|
|
70
102
|
### Dependencies
|
71
103
|
|
@@ -7,25 +7,25 @@ module Reek
|
|
7
7
|
def self.smell_classes
|
8
8
|
# SMELL: Duplication -- these should be loaded by listing the files
|
9
9
|
[
|
10
|
-
|
11
|
-
|
12
|
-
|
13
|
-
|
14
|
-
|
15
|
-
|
16
|
-
|
17
|
-
|
18
|
-
|
19
|
-
|
20
|
-
|
21
|
-
|
22
|
-
|
23
|
-
|
24
|
-
|
25
|
-
|
26
|
-
|
27
|
-
|
28
|
-
|
10
|
+
Smells::Attribute,
|
11
|
+
Smells::BooleanParameter,
|
12
|
+
Smells::ClassVariable,
|
13
|
+
Smells::ControlCouple,
|
14
|
+
Smells::DataClump,
|
15
|
+
Smells::Duplication,
|
16
|
+
Smells::FeatureEnvy,
|
17
|
+
Smells::IrresponsibleModule,
|
18
|
+
Smells::LargeClass,
|
19
|
+
Smells::LongMethod,
|
20
|
+
Smells::LongParameterList,
|
21
|
+
Smells::LongYieldList,
|
22
|
+
Smells::NestedIterators,
|
23
|
+
Smells::SimulatedPolymorphism,
|
24
|
+
Smells::UncommunicativeMethodName,
|
25
|
+
Smells::UncommunicativeModuleName,
|
26
|
+
Smells::UncommunicativeParameterName,
|
27
|
+
Smells::UncommunicativeVariableName,
|
28
|
+
Smells::UtilityFunction
|
29
29
|
]
|
30
30
|
end
|
31
31
|
|
data/lib/reek/rake/task.rb
CHANGED
@@ -19,7 +19,7 @@ module Reek
|
|
19
19
|
|
20
20
|
def all_ruby_source_files(paths)
|
21
21
|
paths.map do |path|
|
22
|
-
if test
|
22
|
+
if test ?d, path
|
23
23
|
all_ruby_source_files(Dir["#{path}/**/*.rb"])
|
24
24
|
else
|
25
25
|
path
|
@@ -29,7 +29,7 @@ module Reek
|
|
29
29
|
|
30
30
|
def valid_paths
|
31
31
|
all_ruby_source_files(@paths).select do |path|
|
32
|
-
if test
|
32
|
+
if test ?f, path
|
33
33
|
true
|
34
34
|
else
|
35
35
|
$stderr.puts "Error: No such file - #{path}"
|
data/lib/reek/version.rb
CHANGED
data/reek.gemspec
CHANGED
@@ -34,5 +34,5 @@ and reports any code smells it finds.
|
|
34
34
|
s.add_development_dependency(%q<bundler>, ["~> 1.1"])
|
35
35
|
s.add_development_dependency(%q<rake>)
|
36
36
|
s.add_development_dependency(%q<cucumber>)
|
37
|
-
s.add_development_dependency(%q<rspec>, ["
|
37
|
+
s.add_development_dependency(%q<rspec>, ["~> 2.12"])
|
38
38
|
end
|
@@ -6,7 +6,7 @@ include Reek::Core
|
|
6
6
|
|
7
7
|
describe MethodContext, 'matching' do
|
8
8
|
before :each do
|
9
|
-
exp = mock('exp'
|
9
|
+
exp = mock('exp').as_null_object
|
10
10
|
exp.should_receive(:full_name).at_least(:once).and_return('mod')
|
11
11
|
@element = MethodContext.new(StopContext.new, exp)
|
12
12
|
end
|
@@ -208,7 +208,7 @@ describe LongMethod do
|
|
208
208
|
context 'when the method has 30 statements' do
|
209
209
|
before :each do
|
210
210
|
@num_statements = 30
|
211
|
-
ctx = mock('method_context'
|
211
|
+
ctx = mock('method_context').as_null_object
|
212
212
|
ctx.should_receive(:num_statements).and_return(@num_statements)
|
213
213
|
ctx.should_receive(:config).and_return({})
|
214
214
|
@smells = @detector.examine_context(ctx)
|
@@ -9,7 +9,7 @@ describe ShouldReekOnlyOf do
|
|
9
9
|
@expected_smell_class = :NestedIterators
|
10
10
|
@expected_context_name = 'SmellyClass#big_method'
|
11
11
|
@matcher = ShouldReekOnlyOf.new(@expected_smell_class, [/#{@expected_context_name}/])
|
12
|
-
@examiner = mock('examiner'
|
12
|
+
@examiner = mock('examiner').as_null_object
|
13
13
|
@examiner.should_receive(:smells).and_return {smells}
|
14
14
|
@match = @matcher.matches_examiner?(@examiner)
|
15
15
|
end
|
data/spec/spec_helper.rb
CHANGED
@@ -1,14 +1,8 @@
|
|
1
|
-
|
2
1
|
require 'rubygems'
|
3
|
-
|
4
|
-
|
5
|
-
rescue LoadError
|
6
|
-
gem 'rspec'
|
7
|
-
require 'spec/expectations'
|
8
|
-
end
|
9
|
-
|
10
|
-
require 'spec/autorun'
|
2
|
+
require 'bundler'
|
3
|
+
Bundler.require :development, :default # Explicitly necessary here.
|
11
4
|
|
5
|
+
# TODO Clean me up big time please?
|
12
6
|
require File.join((File.dirname(File.dirname(File.expand_path(__FILE__)))), 'lib', 'reek', 'spec')
|
13
7
|
require File.join((File.dirname(File.dirname(File.expand_path(__FILE__)))), 'lib', 'reek', 'source', 'tree_dresser')
|
14
8
|
|
@@ -21,3 +15,10 @@ def ast(*args)
|
|
21
15
|
result.line = 1
|
22
16
|
result
|
23
17
|
end
|
18
|
+
|
19
|
+
# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
|
20
|
+
RSpec.configure do |config|
|
21
|
+
config.treat_symbols_as_metadata_keys_with_true_values = true
|
22
|
+
config.filter_run :focus
|
23
|
+
config.run_all_when_everything_filtered = true
|
24
|
+
end
|
data/tasks/test.rake
CHANGED
@@ -1,38 +1,38 @@
|
|
1
1
|
require 'rubygems'
|
2
2
|
require 'cucumber'
|
3
3
|
require 'cucumber/rake/task'
|
4
|
-
require '
|
5
|
-
require '
|
4
|
+
require 'rspec'
|
5
|
+
require 'rspec/core/rake_task'
|
6
6
|
|
7
7
|
namespace 'test' do
|
8
8
|
UNIT_TESTS = FileList['spec/reek/**/*_spec.rb']
|
9
9
|
|
10
|
-
|
11
|
-
t.
|
12
|
-
t.
|
10
|
+
RSpec::Core::RakeTask.new('spec') do |t|
|
11
|
+
t.pattern = UNIT_TESTS
|
12
|
+
t.rspec_opts = ['--color']
|
13
13
|
t.ruby_opts = ['-Ilib']
|
14
14
|
t.rcov = false
|
15
15
|
end
|
16
16
|
|
17
17
|
desc 'Tests various release attributes of the gem'
|
18
|
-
|
19
|
-
t.
|
18
|
+
RSpec::Core::RakeTask.new('gem') do |t|
|
19
|
+
t.pattern = FileList['spec/gem/**/*_spec.rb']
|
20
20
|
t.rcov = false
|
21
21
|
end
|
22
22
|
|
23
23
|
desc 'Tests code quality'
|
24
|
-
|
25
|
-
t.
|
26
|
-
t.
|
24
|
+
RSpec::Core::RakeTask.new('quality') do |t|
|
25
|
+
t.pattern = FileList['quality/**/*_spec.rb']
|
26
|
+
t.rspec_opts = ['--color']
|
27
27
|
t.ruby_opts = ['-Ilib']
|
28
28
|
t.rcov = false
|
29
29
|
end
|
30
30
|
|
31
31
|
desc 'Runs all unit tests under RCov'
|
32
|
-
|
33
|
-
t.
|
32
|
+
RSpec::Core::RakeTask.new('rcov') do |t|
|
33
|
+
t.pattern = UNIT_TESTS
|
34
34
|
t.rcov = true
|
35
|
-
t.
|
35
|
+
t.rcov_opts = '-o build/coverage'
|
36
36
|
end
|
37
37
|
|
38
38
|
Cucumber::Rake::Task.new(:features) do |t|
|
metadata
CHANGED
@@ -1,13 +1,13 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: reek
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
hash:
|
4
|
+
hash: 5
|
5
5
|
prerelease:
|
6
6
|
segments:
|
7
7
|
- 1
|
8
8
|
- 2
|
9
|
-
-
|
10
|
-
version: 1.2.
|
9
|
+
- 13
|
10
|
+
version: 1.2.13
|
11
11
|
platform: ruby
|
12
12
|
authors:
|
13
13
|
- Kevin Rutherford
|
@@ -20,9 +20,9 @@ cert_chain: []
|
|
20
20
|
date: 2010-04-26 00:00:00 Z
|
21
21
|
dependencies:
|
22
22
|
- !ruby/object:Gem::Dependency
|
23
|
-
name: ruby_parser
|
24
23
|
prerelease: false
|
25
|
-
|
24
|
+
name: ruby_parser
|
25
|
+
version_requirements: &id001 !ruby/object:Gem::Requirement
|
26
26
|
none: false
|
27
27
|
requirements:
|
28
28
|
- - ~>
|
@@ -32,12 +32,12 @@ dependencies:
|
|
32
32
|
- 2
|
33
33
|
- 0
|
34
34
|
version: "2.0"
|
35
|
+
requirement: *id001
|
35
36
|
type: :runtime
|
36
|
-
version_requirements: *id001
|
37
37
|
- !ruby/object:Gem::Dependency
|
38
|
-
name: ripper_ruby_parser
|
39
38
|
prerelease: false
|
40
|
-
|
39
|
+
name: ripper_ruby_parser
|
40
|
+
version_requirements: &id002 !ruby/object:Gem::Requirement
|
41
41
|
none: false
|
42
42
|
requirements:
|
43
43
|
- - ~>
|
@@ -48,12 +48,12 @@ dependencies:
|
|
48
48
|
- 0
|
49
49
|
- 7
|
50
50
|
version: 0.0.7
|
51
|
+
requirement: *id002
|
51
52
|
type: :runtime
|
52
|
-
version_requirements: *id002
|
53
53
|
- !ruby/object:Gem::Dependency
|
54
|
-
name: ruby2ruby
|
55
54
|
prerelease: false
|
56
|
-
|
55
|
+
name: ruby2ruby
|
56
|
+
version_requirements: &id003 !ruby/object:Gem::Requirement
|
57
57
|
none: false
|
58
58
|
requirements:
|
59
59
|
- - ~>
|
@@ -64,12 +64,12 @@ dependencies:
|
|
64
64
|
- 2
|
65
65
|
- 5
|
66
66
|
version: 1.2.5
|
67
|
+
requirement: *id003
|
67
68
|
type: :runtime
|
68
|
-
version_requirements: *id003
|
69
69
|
- !ruby/object:Gem::Dependency
|
70
|
-
name: sexp_processor
|
71
70
|
prerelease: false
|
72
|
-
|
71
|
+
name: sexp_processor
|
72
|
+
version_requirements: &id004 !ruby/object:Gem::Requirement
|
73
73
|
none: false
|
74
74
|
requirements:
|
75
75
|
- - ~>
|
@@ -79,12 +79,12 @@ dependencies:
|
|
79
79
|
- 3
|
80
80
|
- 0
|
81
81
|
version: "3.0"
|
82
|
+
requirement: *id004
|
82
83
|
type: :runtime
|
83
|
-
version_requirements: *id004
|
84
84
|
- !ruby/object:Gem::Dependency
|
85
|
-
name: bundler
|
86
85
|
prerelease: false
|
87
|
-
|
86
|
+
name: bundler
|
87
|
+
version_requirements: &id005 !ruby/object:Gem::Requirement
|
88
88
|
none: false
|
89
89
|
requirements:
|
90
90
|
- - ~>
|
@@ -94,12 +94,12 @@ dependencies:
|
|
94
94
|
- 1
|
95
95
|
- 1
|
96
96
|
version: "1.1"
|
97
|
+
requirement: *id005
|
97
98
|
type: :development
|
98
|
-
version_requirements: *id005
|
99
99
|
- !ruby/object:Gem::Dependency
|
100
|
-
name: rake
|
101
100
|
prerelease: false
|
102
|
-
|
101
|
+
name: rake
|
102
|
+
version_requirements: &id006 !ruby/object:Gem::Requirement
|
103
103
|
none: false
|
104
104
|
requirements:
|
105
105
|
- - ">="
|
@@ -108,12 +108,12 @@ dependencies:
|
|
108
108
|
segments:
|
109
109
|
- 0
|
110
110
|
version: "0"
|
111
|
+
requirement: *id006
|
111
112
|
type: :development
|
112
|
-
version_requirements: *id006
|
113
113
|
- !ruby/object:Gem::Dependency
|
114
|
-
name: cucumber
|
115
114
|
prerelease: false
|
116
|
-
|
115
|
+
name: cucumber
|
116
|
+
version_requirements: &id007 !ruby/object:Gem::Requirement
|
117
117
|
none: false
|
118
118
|
requirements:
|
119
119
|
- - ">="
|
@@ -122,24 +122,23 @@ dependencies:
|
|
122
122
|
segments:
|
123
123
|
- 0
|
124
124
|
version: "0"
|
125
|
+
requirement: *id007
|
125
126
|
type: :development
|
126
|
-
version_requirements: *id007
|
127
127
|
- !ruby/object:Gem::Dependency
|
128
|
-
name: rspec
|
129
128
|
prerelease: false
|
130
|
-
|
129
|
+
name: rspec
|
130
|
+
version_requirements: &id008 !ruby/object:Gem::Requirement
|
131
131
|
none: false
|
132
132
|
requirements:
|
133
|
-
- -
|
133
|
+
- - ~>
|
134
134
|
- !ruby/object:Gem::Version
|
135
|
-
hash:
|
135
|
+
hash: 27
|
136
136
|
segments:
|
137
|
-
- 1
|
138
|
-
- 3
|
139
137
|
- 2
|
140
|
-
|
138
|
+
- 12
|
139
|
+
version: "2.12"
|
140
|
+
requirement: *id008
|
141
141
|
type: :development
|
142
|
-
version_requirements: *id008
|
143
142
|
description: |
|
144
143
|
Reek is a tool that examines Ruby classes, modules and methods
|
145
144
|
and reports any code smells it finds.
|
@@ -161,174 +160,174 @@ files:
|
|
161
160
|
- Rakefile
|
162
161
|
- bin/reek
|
163
162
|
- config/defaults.reek
|
164
|
-
- features/
|
163
|
+
- features/ruby_api/api.feature
|
165
164
|
- features/command_line_interface/stdin.feature
|
166
165
|
- features/command_line_interface/options.feature
|
167
|
-
- features/ruby_api/api.feature
|
168
|
-
- features/rake_task/rake_task.feature
|
169
166
|
- features/step_definitions/reek_steps.rb
|
170
|
-
- features/samples.feature
|
171
167
|
- features/support/env.rb
|
172
|
-
- features/
|
168
|
+
- features/samples.feature
|
173
169
|
- features/reports/reports.feature
|
170
|
+
- features/reports/yaml.feature
|
171
|
+
- features/configuration_files/masking_smells.feature
|
172
|
+
- features/rake_task/rake_task.feature
|
174
173
|
- lib/xp.reek
|
174
|
+
- lib/reek.rb
|
175
175
|
- lib/reek/spec.rb
|
176
|
-
- lib/reek/source.rb
|
177
|
-
- lib/reek/spec/should_reek.rb
|
178
176
|
- lib/reek/spec/should_reek_of.rb
|
179
177
|
- lib/reek/spec/should_reek_only_of.rb
|
180
|
-
- lib/reek/
|
181
|
-
- lib/reek/
|
182
|
-
- lib/reek/
|
183
|
-
- lib/reek/
|
184
|
-
- lib/reek/
|
178
|
+
- lib/reek/spec/should_reek.rb
|
179
|
+
- lib/reek/cli/version_command.rb
|
180
|
+
- lib/reek/cli/application.rb
|
181
|
+
- lib/reek/cli/command_line.rb
|
182
|
+
- lib/reek/cli/yaml_command.rb
|
183
|
+
- lib/reek/cli/help_command.rb
|
184
|
+
- lib/reek/cli/report.rb
|
185
|
+
- lib/reek/cli/reek_command.rb
|
186
|
+
- lib/reek/examiner.rb
|
187
|
+
- lib/reek/rake/task.rb
|
188
|
+
- lib/reek/smell_warning.rb
|
189
|
+
- lib/reek/version.rb
|
190
|
+
- lib/reek/smells/duplication.rb
|
185
191
|
- lib/reek/smells/boolean_parameter.rb
|
192
|
+
- lib/reek/smells/uncommunicative_parameter_name.rb
|
186
193
|
- lib/reek/smells/long_method.rb
|
187
|
-
- lib/reek/smells/duplication.rb
|
188
|
-
- lib/reek/smells/smell_detector.rb
|
189
194
|
- lib/reek/smells/control_couple.rb
|
190
|
-
- lib/reek/smells/uncommunicative_module_name.rb
|
191
|
-
- lib/reek/smells/nested_iterators.rb
|
192
|
-
- lib/reek/smells/long_parameter_list.rb
|
193
195
|
- lib/reek/smells/long_yield_list.rb
|
194
|
-
- lib/reek/smells/utility_function.rb
|
195
|
-
- lib/reek/smells/uncommunicative_parameter_name.rb
|
196
|
-
- lib/reek/smells/simulated_polymorphism.rb
|
197
|
-
- lib/reek/smells/data_clump.rb
|
198
196
|
- lib/reek/smells/attribute.rb
|
197
|
+
- lib/reek/smells/simulated_polymorphism.rb
|
198
|
+
- lib/reek/smells/uncommunicative_method_name.rb
|
199
199
|
- lib/reek/smells/class_variable.rb
|
200
|
-
- lib/reek/
|
201
|
-
- lib/reek/
|
202
|
-
- lib/reek/
|
203
|
-
- lib/reek/
|
204
|
-
- lib/reek/
|
205
|
-
- lib/reek/
|
206
|
-
- lib/reek/
|
207
|
-
- lib/reek/
|
208
|
-
- lib/reek/
|
209
|
-
- lib/reek/
|
210
|
-
- lib/reek/
|
211
|
-
- lib/reek/
|
212
|
-
- lib/reek/
|
213
|
-
- lib/reek/core/stop_context.rb
|
214
|
-
- lib/reek/rake/task.rb
|
215
|
-
- lib/reek/cli/report.rb
|
216
|
-
- lib/reek/cli/command_line.rb
|
217
|
-
- lib/reek/cli/version_command.rb
|
218
|
-
- lib/reek/cli/reek_command.rb
|
219
|
-
- lib/reek/cli/yaml_command.rb
|
220
|
-
- lib/reek/cli/application.rb
|
221
|
-
- lib/reek/cli/help_command.rb
|
200
|
+
- lib/reek/smells/long_parameter_list.rb
|
201
|
+
- lib/reek/smells/feature_envy.rb
|
202
|
+
- lib/reek/smells/irresponsible_module.rb
|
203
|
+
- lib/reek/smells/utility_function.rb
|
204
|
+
- lib/reek/smells/data_clump.rb
|
205
|
+
- lib/reek/smells/uncommunicative_variable_name.rb
|
206
|
+
- lib/reek/smells/uncommunicative_module_name.rb
|
207
|
+
- lib/reek/smells/nested_iterators.rb
|
208
|
+
- lib/reek/smells/smell_detector.rb
|
209
|
+
- lib/reek/smells/large_class.rb
|
210
|
+
- lib/reek/smells.rb
|
211
|
+
- lib/reek/source/config_file.rb
|
212
|
+
- lib/reek/source/source_code.rb
|
222
213
|
- lib/reek/source/sexp_formatter.rb
|
223
214
|
- lib/reek/source/source_repository.rb
|
224
215
|
- lib/reek/source/reference_collector.rb
|
216
|
+
- lib/reek/source/core_extras.rb
|
225
217
|
- lib/reek/source/source_file.rb
|
226
|
-
- lib/reek/source/source_locator.rb
|
227
218
|
- lib/reek/source/code_comment.rb
|
228
|
-
- lib/reek/source/
|
229
|
-
- lib/reek/source/source_code.rb
|
219
|
+
- lib/reek/source/source_locator.rb
|
230
220
|
- lib/reek/source/tree_dresser.rb
|
231
|
-
- lib/reek/source
|
232
|
-
- lib/reek/
|
233
|
-
- lib/reek/
|
234
|
-
- lib/reek.rb
|
235
|
-
-
|
221
|
+
- lib/reek/source.rb
|
222
|
+
- lib/reek/core/smell_configuration.rb
|
223
|
+
- lib/reek/core/method_context.rb
|
224
|
+
- lib/reek/core/code_parser.rb
|
225
|
+
- lib/reek/core/module_context.rb
|
226
|
+
- lib/reek/core/stop_context.rb
|
227
|
+
- lib/reek/core/code_context.rb
|
228
|
+
- lib/reek/core/sniffer.rb
|
229
|
+
- lib/reek/core/hash_extensions.rb
|
230
|
+
- lib/reek/core/smell_repository.rb
|
231
|
+
- lib/reek/core/object_refs.rb
|
232
|
+
- lib/reek/core/singleton_method_context.rb
|
233
|
+
- lib/reek/core/warning_collector.rb
|
234
|
+
- spec/matchers/smell_of_matcher.rb
|
235
|
+
- spec/spec_helper.rb
|
236
|
+
- spec/spec.opts
|
236
237
|
- spec/reek/spec/should_reek_of_spec.rb
|
238
|
+
- spec/reek/spec/should_reek_spec.rb
|
237
239
|
- spec/reek/spec/should_reek_only_of_spec.rb
|
238
240
|
- spec/reek/examiner_spec.rb
|
241
|
+
- spec/reek/cli/help_command_spec.rb
|
242
|
+
- spec/reek/cli/reek_command_spec.rb
|
243
|
+
- spec/reek/cli/yaml_command_spec.rb
|
244
|
+
- spec/reek/cli/report_spec.rb
|
245
|
+
- spec/reek/cli/version_command_spec.rb
|
246
|
+
- spec/reek/smells/boolean_parameter_spec.rb
|
247
|
+
- spec/reek/smells/long_method_spec.rb
|
248
|
+
- spec/reek/smells/uncommunicative_method_name_spec.rb
|
239
249
|
- spec/reek/smells/duplication_spec.rb
|
240
250
|
- spec/reek/smells/uncommunicative_module_name_spec.rb
|
241
|
-
- spec/reek/smells/
|
242
|
-
- spec/reek/smells/nested_iterators_spec.rb
|
251
|
+
- spec/reek/smells/class_variable_spec.rb
|
243
252
|
- spec/reek/smells/long_yield_list_spec.rb
|
244
|
-
- spec/reek/smells/
|
245
|
-
- spec/reek/smells/
|
253
|
+
- spec/reek/smells/control_couple_spec.rb
|
254
|
+
- spec/reek/smells/uncommunicative_parameter_name_spec.rb
|
246
255
|
- spec/reek/smells/long_parameter_list_spec.rb
|
247
|
-
- spec/reek/smells/uncommunicative_variable_name_spec.rb
|
248
|
-
- spec/reek/smells/boolean_parameter_spec.rb
|
249
|
-
- spec/reek/smells/behaves_like_variable_detector.rb
|
250
|
-
- spec/reek/smells/class_variable_spec.rb
|
251
|
-
- spec/reek/smells/feature_envy_spec.rb
|
252
|
-
- spec/reek/smells/simulated_polymorphism_spec.rb
|
253
|
-
- spec/reek/smells/long_method_spec.rb
|
254
256
|
- spec/reek/smells/attribute_spec.rb
|
255
|
-
- spec/reek/smells/
|
256
|
-
- spec/reek/smells/
|
257
|
+
- spec/reek/smells/simulated_polymorphism_spec.rb
|
258
|
+
- spec/reek/smells/data_clump_spec.rb
|
259
|
+
- spec/reek/smells/feature_envy_spec.rb
|
260
|
+
- spec/reek/smells/smell_detector_shared.rb
|
257
261
|
- spec/reek/smells/utility_function_spec.rb
|
258
|
-
- spec/reek/smells/
|
262
|
+
- spec/reek/smells/nested_iterators_spec.rb
|
263
|
+
- spec/reek/smells/behaves_like_variable_detector.rb
|
259
264
|
- spec/reek/smells/large_class_spec.rb
|
260
|
-
- spec/reek/
|
261
|
-
- spec/reek/
|
262
|
-
- spec/reek/
|
265
|
+
- spec/reek/smells/irresponsible_module_spec.rb
|
266
|
+
- spec/reek/smells/uncommunicative_variable_name_spec.rb
|
267
|
+
- spec/reek/smell_warning_spec.rb
|
268
|
+
- spec/reek/source/reference_collector_spec.rb
|
269
|
+
- spec/reek/source/tree_dresser_spec.rb
|
270
|
+
- spec/reek/source/sexp_formatter_spec.rb
|
271
|
+
- spec/reek/source/code_comment_spec.rb
|
272
|
+
- spec/reek/source/object_source_spec.rb
|
273
|
+
- spec/reek/source/source_code_spec.rb
|
263
274
|
- spec/reek/core/object_refs_spec.rb
|
264
|
-
- spec/reek/core/method_context_spec.rb
|
265
|
-
- spec/reek/core/singleton_method_context_spec.rb
|
266
275
|
- spec/reek/core/warning_collector_spec.rb
|
267
|
-
- spec/reek/core/code_parser_spec.rb
|
268
276
|
- spec/reek/core/stop_context_spec.rb
|
269
277
|
- spec/reek/core/config_spec.rb
|
270
|
-
- spec/reek/
|
271
|
-
- spec/reek/
|
272
|
-
- spec/reek/
|
273
|
-
- spec/reek/
|
274
|
-
- spec/reek/
|
275
|
-
- spec/reek/
|
276
|
-
- spec/
|
277
|
-
- spec/
|
278
|
-
- spec/
|
279
|
-
- spec/reek/source/source_code_spec.rb
|
280
|
-
- spec/reek/source/object_source_spec.rb
|
281
|
-
- spec/reek/smell_warning_spec.rb
|
282
|
-
- spec/spec.opts
|
283
|
-
- spec/samples/demo/demo.rb
|
278
|
+
- spec/reek/core/code_parser_spec.rb
|
279
|
+
- spec/reek/core/smell_configuration_spec.rb
|
280
|
+
- spec/reek/core/module_context_spec.rb
|
281
|
+
- spec/reek/core/method_context_spec.rb
|
282
|
+
- spec/reek/core/code_context_spec.rb
|
283
|
+
- spec/reek/core/singleton_method_context_spec.rb
|
284
|
+
- spec/gem/updates_spec.rb
|
285
|
+
- spec/gem/yard_spec.rb
|
286
|
+
- spec/gem/manifest_spec.rb
|
284
287
|
- spec/samples/three_clean_files/clean_one.rb
|
285
|
-
- spec/samples/three_clean_files/clean_three.rb
|
286
288
|
- spec/samples/three_clean_files/clean_two.rb
|
289
|
+
- spec/samples/three_clean_files/clean_three.rb
|
290
|
+
- spec/samples/config/allow_duplication.reek
|
291
|
+
- spec/samples/config/deeper_nested_iterators.reek
|
287
292
|
- spec/samples/overrides/upper.reek
|
288
293
|
- spec/samples/overrides/masked/dirty.rb
|
289
294
|
- spec/samples/overrides/masked/lower.reek
|
295
|
+
- spec/samples/demo/demo.rb
|
296
|
+
- spec/samples/redcloth.rb
|
297
|
+
- spec/samples/inline_config/masked.reek
|
298
|
+
- spec/samples/inline_config/dirty.rb
|
299
|
+
- spec/samples/corrupt_config_file/corrupt.reek
|
300
|
+
- spec/samples/corrupt_config_file/dirty.rb
|
290
301
|
- spec/samples/empty_config_file/dirty.rb
|
291
302
|
- spec/samples/empty_config_file/empty.reek
|
303
|
+
- spec/samples/masked/masked.reek
|
304
|
+
- spec/samples/masked/dirty.rb
|
305
|
+
- spec/samples/all_but_one_masked/masked.reek
|
292
306
|
- spec/samples/all_but_one_masked/clean_one.rb
|
293
307
|
- spec/samples/all_but_one_masked/dirty.rb
|
294
|
-
- spec/samples/
|
295
|
-
- spec/samples/corrupt_config_file/dirty.rb
|
296
|
-
- spec/samples/corrupt_config_file/corrupt.reek
|
297
|
-
- spec/samples/optparse.rb
|
298
|
-
- spec/samples/exceptions.reek
|
299
|
-
- spec/samples/not_quite_masked/dirty.rb
|
300
|
-
- spec/samples/not_quite_masked/masked.reek
|
308
|
+
- spec/samples/inline.rb
|
301
309
|
- spec/samples/mask_some/dirty.rb
|
302
310
|
- spec/samples/mask_some/some.reek
|
303
|
-
- spec/samples/
|
304
|
-
- spec/samples/
|
305
|
-
- spec/samples/
|
306
|
-
- spec/samples/
|
307
|
-
- spec/samples/
|
308
|
-
- spec/samples/clean_due_to_masking/dirty_one.rb
|
309
|
-
- spec/samples/clean_due_to_masking/dirty_two.rb
|
310
|
-
- spec/samples/redcloth.rb
|
311
|
+
- spec/samples/not_quite_masked/masked.reek
|
312
|
+
- spec/samples/not_quite_masked/dirty.rb
|
313
|
+
- spec/samples/exceptions.reek
|
314
|
+
- spec/samples/mixed_results/dirty_two.rb
|
315
|
+
- spec/samples/mixed_results/dirty_one.rb
|
311
316
|
- spec/samples/mixed_results/clean_one.rb
|
312
|
-
- spec/samples/mixed_results/clean_three.rb
|
313
317
|
- spec/samples/mixed_results/clean_two.rb
|
314
|
-
- spec/samples/mixed_results/
|
315
|
-
- spec/samples/
|
316
|
-
- spec/samples/
|
317
|
-
- spec/samples/
|
318
|
-
- spec/samples/
|
318
|
+
- spec/samples/mixed_results/clean_three.rb
|
319
|
+
- spec/samples/clean_due_to_masking/dirty_two.rb
|
320
|
+
- spec/samples/clean_due_to_masking/masked.reek
|
321
|
+
- spec/samples/clean_due_to_masking/dirty_one.rb
|
322
|
+
- spec/samples/clean_due_to_masking/clean_one.rb
|
323
|
+
- spec/samples/clean_due_to_masking/clean_two.rb
|
324
|
+
- spec/samples/clean_due_to_masking/clean_three.rb
|
325
|
+
- spec/samples/optparse.rb
|
319
326
|
- spec/samples/two_smelly_files/dirty_two.rb
|
320
|
-
- spec/samples/
|
321
|
-
- spec/samples/masked/masked.reek
|
322
|
-
- spec/samples/inline_config/dirty.rb
|
323
|
-
- spec/samples/inline_config/masked.reek
|
324
|
-
- spec/gem/yard_spec.rb
|
325
|
-
- spec/gem/manifest_spec.rb
|
326
|
-
- spec/gem/updates_spec.rb
|
327
|
-
- spec/spec_helper.rb
|
328
|
-
- spec/matchers/smell_of_matcher.rb
|
327
|
+
- spec/samples/two_smelly_files/dirty_one.rb
|
329
328
|
- tasks/test.rake
|
330
|
-
- tasks/develop.rake
|
331
329
|
- tasks/reek.rake
|
330
|
+
- tasks/develop.rake
|
332
331
|
- reek.gemspec
|
333
332
|
homepage: http://wiki.github.com/troessner/reek
|
334
333
|
licenses: []
|