reek 1.2.1 → 1.2.3

data/tasks/test.rake

@@ -6,7 +6,6 @@ require 'spec/rake/spectask'
 
 namespace 'test' do
   UNIT_TESTS = FileList['spec/reek/**/*_spec.rb']
-  QUALITY_TESTS = FileList['spec/quality/**/*_spec.rb']
 
   Spec::Rake::SpecTask.new('spec') do |t|
     t.spec_files = UNIT_TESTS
@@ -16,7 +15,7 @@ namespace 'test' do
   end
 
   Spec::Rake::SpecTask.new('quality') do |t|
-    t.spec_files = QUALITY_TESTS
+    t.spec_files = FileList['quality/**/*_spec.rb']
     t.spec_opts = ['--color']
     t.ruby_opts = ['-Ilib']
     t.rcov = false
@@ -24,7 +23,7 @@ namespace 'test' do
 
   desc 'Runs all unit tests under RCov'
   Spec::Rake::SpecTask.new('rcov') do |t|
-    t.spec_files = UNIT_TESTS + QUALITY_TESTS
+    t.spec_files = UNIT_TESTS
     t.rcov = true
     t.rcov_dir = 'build/coverage'
   end
@@ -39,7 +38,7 @@ namespace 'test' do
   end
 
   desc 'Runs all unit tests, acceptance tests and quality checks'
-  task 'all' => ['test:spec', 'test:features', 'test:quality', 'test:multiruby']
+  task 'all' => ['test:spec', 'test:features', 'test:multiruby']
 end
 
 task 'clobber_rcov' => 'test:clobber_rcov'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: reek
 version: !ruby/object:Gem::Version 
-  version: 1.2.1
+  version: 1.2.3
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-10-03 00:00:00 +01:00
+date: 2009-11-02 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -62,6 +62,8 @@ files:
 - config/defaults.reek
 - features/masking_smells.feature
 - features/options.feature
+- features/profile.feature
+- features/rake_task.feature
 - features/reports.feature
 - features/samples.feature
 - features/stdin.feature
@@ -72,7 +74,6 @@ files:
 - lib/reek/adapters/command_line.rb
 - lib/reek/adapters/config_file.rb
 - lib/reek/adapters/core_extras.rb
-- lib/reek/adapters/object_source.rb
 - lib/reek/adapters/rake_task.rb
 - lib/reek/adapters/report.rb
 - lib/reek/adapters/source.rb
@@ -83,7 +84,6 @@ files:
 - lib/reek/code_parser.rb
 - lib/reek/configuration.rb
 - lib/reek/detector_stack.rb
-- lib/reek/exceptions.reek
 - lib/reek/if_context.rb
 - lib/reek/method_context.rb
 - lib/reek/module_context.rb
@@ -92,6 +92,7 @@ files:
 - lib/reek/sexp_formatter.rb
 - lib/reek/singleton_method_context.rb
 - lib/reek/smell_warning.rb
+- lib/reek/smells/attribute.rb
 - lib/reek/smells/class_variable.rb
 - lib/reek/smells/control_couple.rb
 - lib/reek/smells/data_clump.rb
@@ -108,9 +109,9 @@ files:
 - lib/reek/smells/utility_function.rb
 - lib/reek/sniffer.rb
 - lib/reek/stop_context.rb
+- lib/reek/tree_dresser.rb
 - lib/reek/yield_call_context.rb
 - reek.gemspec
-- spec/quality/reek_source_spec.rb
 - spec/reek/adapters/report_spec.rb
 - spec/reek/adapters/should_reek_of_spec.rb
 - spec/reek/adapters/should_reek_only_of_spec.rb
@@ -129,6 +130,8 @@ files:
 - spec/reek/object_source_spec.rb
 - spec/reek/singleton_method_context_spec.rb
 - spec/reek/smell_warning_spec.rb
+- spec/reek/smells/attribute_spec.rb
+- spec/reek/smells/behaves_like_variable_detector.rb
 - spec/reek/smells/class_variable_spec.rb
 - spec/reek/smells/control_couple_spec.rb
 - spec/reek/smells/data_clump_spec.rb

data/lib/reek/adapters/object_source.rb

@@ -1,52 +0,0 @@
-require 'reek/adapters/source'
-require 'reek/configuration'
-require 'reek/smells/large_class'
-
-include Reek::Smells
-
-module Reek
-  class ObjectSource < Source   # :nodoc:
-
-    def self.unify(sexp)   # :nodoc:
-      unifier = Unifier.new
-      unifier.processors.each do |proc|
-        proc.unsupported.delete :cfunc # HACK
-      end
-      return unifier.process(sexp[0])
-    end
-
-    def configure(sniffer)
-      super
-      disabled_config = {Reek::SmellConfiguration::ENABLED_KEY => false}
-      sniffer.configure(LargeClass, disabled_config)
-    end
-
-    def self.can_parse_objects?
-      return true if Object.const_defined?(:ParseTree)
-      begin
-        require 'parse_tree'
-        true
-      rescue LoadError
-        false
-      end
-    end
-
-    def syntax_tree
-      if ObjectSource.can_parse_objects?
-        ObjectSource.unify(ParseTree.new.parse_tree(@source))
-      else
-        throw ArgumentError.new('You must install the ParseTree gem to use this feature')
-      end
-    end
-  end
-end
-
-class Object
-  #
-  # Constructs a Sniffer which examines this object for code smells.
-  # (This feature is only enabled if you have the ParseTree gem installed.)
-  #
-  def to_reek_source
-    ObjectSource.new(self, self.to_s)
-  end
-end

data/lib/reek/exceptions.reek

@@ -1,20 +0,0 @@
----
-Duplication:
-  exclude:
-  - Reek::Options#set_options
-FeatureEnvy:
-  exclude:
-  - examine_context
-LargeClass:
-  exclude:
-  - CodeParser
-LongMethod:
-  exclude:
-  - Reek::SexpFormatter#self.format
-  - Reek::Options#set_options
-UncommunicativeName:
-  accept:
-  - process_op_asgn1
-UtilityFunction:
-  exclude:
-  - Reek::Spec

data/spec/quality/reek_source_spec.rb

@@ -1,15 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
-
-describe 'Reek source code' do
-  it 'has no smells' do
-    Dir['lib/**/*.rb'].should_not reek
-  end
-
-  nucleus = Dir['lib/reek/**.rb'] - Dir['lib/reek/adapters/**/*.rb']
-  nucleus.each do |src|
-    it "#{src} contains no references from the nucleus out to the adapters" do
-      IO.readlines(src).grep(/adapters/).should == []
-    end
-  end
-
-end