reek 1.1.3 → 1.2.0

data/spec/samples/clean_due_to_masking/dirty_two.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/clean_due_to_masking/masked.reek

@@ -0,0 +1,7 @@
+---
+Duplication:
+  enabled: false
+NestedIterators:
+  enabled: false
+UncommunicativeName:
+  enabled: false

data/spec/samples/corrupt_config_file/corrupt.reek

@@ -0,0 +1 @@
+This is not a config file

data/spec/samples/corrupt_config_file/dirty.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/empty_config_file/dirty.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/exceptions.reek

@@ -0,0 +1,4 @@
+---
+UncommunicativeName:
+  accept:
+  - md5

data/spec/samples/masked/dirty.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/masked/masked.reek

@@ -0,0 +1,3 @@
+---
+UncommunicativeName:
+  enabled: false

data/spec/samples/mixed_results/clean_one.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/mixed_results/clean_three.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/mixed_results/clean_two.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/mixed_results/dirty_one.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/mixed_results/dirty_two.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/not_quite_masked/dirty.rb

@@ -0,0 +1,8 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end
+

data/spec/samples/not_quite_masked/masked.reek

@@ -0,0 +1,5 @@
+---
+UncommunicativeName:
+  accept:
+    - x
+

data/spec/samples/overrides/masked/dirty.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/overrides/masked/lower.reek

@@ -0,0 +1,5 @@
+---
+Duplication:
+  enabled: true
+UncommunicativeName:
+  enabled: false

data/spec/samples/overrides/upper.reek

@@ -0,0 +1,5 @@
+---
+Duplication:
+  enabled: false
+NestedIterators:
+  enabled: false

data/spec/samples/three_clean_files/clean_one.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/three_clean_files/clean_three.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/three_clean_files/clean_two.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/two_smelly_files/dirty_one.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/two_smelly_files/dirty_two.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/spec.opts

@@ -1 +1 @@
---colour
+--color

data/spec/spec_helper.rb

@@ -1,13 +1,13 @@
 $:.unshift File.dirname(__FILE__) + '/../lib'
 
 begin
-  require 'spec'
+  require 'spec/expectations'
 rescue LoadError
   require 'rubygems'
   gem 'rspec'
-  require 'spec'
+  require 'spec/expectations'
 end
 
-require 'reek/spec'
+require 'reek/adapters/spec'
 
-SAMPLES_DIR = 'spec/slow/samples' unless Object.const_defined?('SAMPLES_DIR')
+SAMPLES_DIR = 'spec/samples' unless Object.const_defined?('SAMPLES_DIR')

data/tasks/reek.rake

@@ -1,7 +1,10 @@
-require 'reek/rake_task'
+begin
+  require 'reek/adapters/rake_task'
 
-Reek::RakeTask.new do |t|
-  t.fail_on_error = true
-  t.verbose = false
-#  t.reek_opts = '-f "Smell: %s: %c %w"'
+  Reek::RakeTask.new do |t|
+    t.fail_on_error = true
+    t.verbose = false
+    t.reek_opts = '--quiet --show-all'
+  end
+rescue Gem::LoadError
 end

data/tasks/test.rake

@@ -0,0 +1,51 @@
+require 'rubygems'
+require 'cucumber'
+require 'cucumber/rake/task'
+require 'spec'
+require 'spec/rake/spectask'
+
+namespace 'test' do
+  UNIT_TESTS = FileList['spec/reek/**/*_spec.rb']
+  QUALITY_TESTS = FileList['spec/quality/**/*_spec.rb']
+
+  Spec::Rake::SpecTask.new('spec') do |t|
+    t.spec_files = UNIT_TESTS
+    t.spec_opts = ['--color']
+    t.ruby_opts = ['-Ilib']
+    t.rcov = false
+  end
+
+  Spec::Rake::SpecTask.new('quality') do |t|
+    t.spec_files = QUALITY_TESTS
+    t.spec_opts = ['--color']
+    t.ruby_opts = ['-Ilib']
+    t.rcov = false
+  end
+
+  desc 'Runs all unit tests under RCov'
+  Spec::Rake::SpecTask.new('rcov') do |t|
+    t.spec_files = UNIT_TESTS + QUALITY_TESTS
+    t.rcov = true
+    t.rcov_dir = 'build/coverage'
+  end
+
+  desc 'Checks all supported versions of Ruby'
+  task :multiruby do
+    sh "multiruby -S rake spec"
+  end
+
+  Cucumber::Rake::Task.new(:features) do |t|
+    t.cucumber_opts = "features --format progress --color"
+  end
+
+  desc 'Runs all unit tests, acceptance tests and quality checks'
+  task 'all' => ['test:spec', 'test:features', 'test:quality', 'test:multiruby']
+end
+
+task 'clobber_rcov' => 'test:clobber_rcov'
+
+desc 'synonym for test:spec'
+task 'spec' => 'test:spec'
+
+desc 'synonym for test:all'
+task 'test' => 'test:all'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: reek
 version: !ruby/object:Gem::Version 
-  version: 1.1.3
+  version: 1.2.0
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-19 00:00:00 +01:00
+date: 2009-09-20 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -51,32 +51,49 @@ extensions: []
 
 extra_rdoc_files: 
 - History.txt
-- README.txt
+- License.txt
+- README.rdoc
 files: 
 - History.txt
-- README.txt
+- License.txt
+- README.rdoc
 - Rakefile
 - bin/reek
 - config/defaults.reek
+- features/masking_smells.feature
+- features/options.feature
+- features/reports.feature
+- features/samples.feature
+- features/stdin.feature
+- features/step_definitions/reek_steps.rb
+- features/support/env.rb
 - lib/reek.rb
+- lib/reek/adapters/application.rb
+- lib/reek/adapters/config_file.rb
+- lib/reek/adapters/core_extras.rb
+- lib/reek/adapters/object_source.rb
+- lib/reek/adapters/rake_task.rb
+- lib/reek/adapters/report.rb
+- lib/reek/adapters/source.rb
+- lib/reek/adapters/spec.rb
 - lib/reek/block_context.rb
 - lib/reek/class_context.rb
 - lib/reek/code_context.rb
 - lib/reek/code_parser.rb
+- lib/reek/command_line.rb
+- lib/reek/configuration.rb
+- lib/reek/detector_stack.rb
 - lib/reek/exceptions.reek
 - lib/reek/if_context.rb
 - lib/reek/method_context.rb
 - lib/reek/module_context.rb
 - lib/reek/name.rb
 - lib/reek/object_refs.rb
-- lib/reek/object_source.rb
-- lib/reek/options.rb
-- lib/reek/rake_task.rb
-- lib/reek/report.rb
 - lib/reek/sexp_formatter.rb
 - lib/reek/singleton_method_context.rb
 - lib/reek/smell_warning.rb
 - lib/reek/smells/control_couple.rb
+- lib/reek/smells/data_clump.rb
 - lib/reek/smells/duplication.rb
 - lib/reek/smells/feature_envy.rb
 - lib/reek/smells/large_class.rb
@@ -84,51 +101,84 @@ files:
 - lib/reek/smells/long_parameter_list.rb
 - lib/reek/smells/long_yield_list.rb
 - lib/reek/smells/nested_iterators.rb
+- lib/reek/smells/simulated_polymorphism.rb
 - lib/reek/smells/smell_detector.rb
-- lib/reek/smells/smells.rb
 - lib/reek/smells/uncommunicative_name.rb
 - lib/reek/smells/utility_function.rb
-- lib/reek/source.rb
-- lib/reek/spec.rb
+- lib/reek/sniffer.rb
 - lib/reek/stop_context.rb
 - lib/reek/yield_call_context.rb
 - reek.gemspec
+- spec/quality/reek_source_spec.rb
+- spec/reek/adapters/report_spec.rb
+- spec/reek/adapters/should_reek_of_spec.rb
+- spec/reek/adapters/should_reek_only_of_spec.rb
+- spec/reek/adapters/should_reek_spec.rb
 - spec/reek/block_context_spec.rb
 - spec/reek/class_context_spec.rb
 - spec/reek/code_context_spec.rb
 - spec/reek/code_parser_spec.rb
 - spec/reek/config_spec.rb
+- spec/reek/configuration_spec.rb
 - spec/reek/if_context_spec.rb
 - spec/reek/method_context_spec.rb
 - spec/reek/module_context_spec.rb
 - spec/reek/name_spec.rb
 - spec/reek/object_refs_spec.rb
-- spec/reek/options_spec.rb
-- spec/reek/report_spec.rb
+- spec/reek/object_source_spec.rb
 - spec/reek/singleton_method_context_spec.rb
+- spec/reek/smell_warning_spec.rb
 - spec/reek/smells/control_couple_spec.rb
+- spec/reek/smells/data_clump_spec.rb
 - spec/reek/smells/duplication_spec.rb
 - spec/reek/smells/feature_envy_spec.rb
 - spec/reek/smells/large_class_spec.rb
 - spec/reek/smells/long_method_spec.rb
 - spec/reek/smells/long_parameter_list_spec.rb
 - spec/reek/smells/nested_iterators_spec.rb
-- spec/reek/smells/smell_spec.rb
+- spec/reek/smells/simulated_polymorphism_spec.rb
+- spec/reek/smells/smell_detector_spec.rb
 - spec/reek/smells/uncommunicative_name_spec.rb
 - spec/reek/smells/utility_function_spec.rb
-- spec/slow/inline_spec.rb
-- spec/slow/optparse_spec.rb
-- spec/slow/redcloth_spec.rb
-- spec/slow/reek_source_spec.rb
-- spec/slow/samples/inline.rb
-- spec/slow/samples/optparse.rb
-- spec/slow/samples/redcloth.rb
-- spec/slow/script_spec.rb
-- spec/slow/source_list_spec.rb
+- spec/reek/sniffer_spec.rb
+- spec/samples/all_but_one_masked/clean_one.rb
+- spec/samples/all_but_one_masked/dirty.rb
+- spec/samples/all_but_one_masked/masked.reek
+- spec/samples/clean_due_to_masking/clean_one.rb
+- spec/samples/clean_due_to_masking/clean_three.rb
+- spec/samples/clean_due_to_masking/clean_two.rb
+- spec/samples/clean_due_to_masking/dirty_one.rb
+- spec/samples/clean_due_to_masking/dirty_two.rb
+- spec/samples/clean_due_to_masking/masked.reek
+- spec/samples/corrupt_config_file/corrupt.reek
+- spec/samples/corrupt_config_file/dirty.rb
+- spec/samples/empty_config_file/dirty.rb
+- spec/samples/empty_config_file/empty.reek
+- spec/samples/exceptions.reek
+- spec/samples/inline.rb
+- spec/samples/masked/dirty.rb
+- spec/samples/masked/masked.reek
+- spec/samples/mixed_results/clean_one.rb
+- spec/samples/mixed_results/clean_three.rb
+- spec/samples/mixed_results/clean_two.rb
+- spec/samples/mixed_results/dirty_one.rb
+- spec/samples/mixed_results/dirty_two.rb
+- spec/samples/not_quite_masked/dirty.rb
+- spec/samples/not_quite_masked/masked.reek
+- spec/samples/optparse.rb
+- spec/samples/overrides/masked/dirty.rb
+- spec/samples/overrides/masked/lower.reek
+- spec/samples/overrides/upper.reek
+- spec/samples/redcloth.rb
+- spec/samples/three_clean_files/clean_one.rb
+- spec/samples/three_clean_files/clean_three.rb
+- spec/samples/three_clean_files/clean_two.rb
+- spec/samples/two_smelly_files/dirty_one.rb
+- spec/samples/two_smelly_files/dirty_two.rb
 - spec/spec.opts
 - spec/spec_helper.rb
 - tasks/reek.rake
-- tasks/rspec.rake
+- tasks/test.rake
 has_rdoc: true
 homepage: http://wiki.github.com/kevinrutherford/reek
 licenses: []
@@ -157,7 +207,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: reek
-rubygems_version: 1.3.3
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Code smell detector for Ruby