reek 1.0.0 → 1.1.3

data/spec/reek/smells/large_class_spec.rb

@@ -8,18 +8,19 @@ include Reek::Smells
 
 describe LargeClass do
 
-  class BigOne
-    26.times do |i|
-      define_method "method#{i}".to_sym do
-        @melting
+  it 'should report large class' do
+    class BigOne
+      26.times do |i|
+        define_method "method#{i}".to_sym do
+          @melting
+        end
       end
     end
+    BigOne.should reek_only_of(:LargeClass, /BigOne/)
   end
+end
 
-  before(:each) do
-    @rpt = Report.new
-    @cchk = CodeParser.new(@rpt, SmellConfig.new.smell_listeners)
-  end
+describe LargeClass do
 
   it 'should not report short class' do
     class ShortClass
@@ -30,57 +31,57 @@ describe LargeClass do
       def method5() @var5; end
       def method6() @var6; end
     end
-    @cchk.check_object(ShortClass)
-    @rpt.should be_empty
+    ShortClass.should_not reek
   end
+end
 
-  it 'should report large class' do
-    @cchk.check_object(BigOne)
-    @rpt.length.should == 1
-  end
+describe LargeClass, 'when exceptions are listed' do
 
-  it 'should report class name' do
-    @cchk.check_object(BigOne)
-    @rpt[0].report.should match(/BigOne/)
+  before(:each) do
+    @rpt = Report.new
+    @ctx = ClassContext.create(StopContext.new, [0, :Humungous])
+    30.times { |num| @ctx.record_method("method#{num}") }
+    @config = LargeClass.default_config
   end
 
-  describe 'when exceptions are listed' do
-    before :each do
-      @ctx = ClassContext.create(StopContext.new, [0, :Humungous])
-      30.times { |num| @ctx.record_method("method#{num}") }
-      @config = LargeClass.default_config
-    end
+  it 'should ignore first excepted name' do
+    @config[LargeClass::EXCLUDE_KEY] = ['Humungous']
+    lc = LargeClass.new(@config)
+    lc.examine(@ctx, @rpt).should == false
+    @rpt.length.should == 0
+  end
 
-    it 'should ignore first excepted name' do
-      @config[LargeClass::EXCLUDE_KEY] = ['Humungous']
-      lc = LargeClass.new(@config)
-      lc.examine(@ctx, @rpt).should == false
-      @rpt.length.should == 0
-    end
+  it 'should ignore second excepted name' do
+    @config[LargeClass::EXCLUDE_KEY] = ['Oversized', 'Humungous']
+    lc = LargeClass.new(@config)
+    lc.examine(@ctx, @rpt).should == false
+    @rpt.length.should == 0
+  end
 
-    it 'should ignore second excepted name' do
-      @config[LargeClass::EXCLUDE_KEY] = ['Oversized', 'Humungous']
-      lc = LargeClass.new(@config)
-      lc.examine(@ctx, @rpt).should == false
-      @rpt.length.should == 0
-    end
+  it 'should report non-excepted name' do
+    @config[LargeClass::EXCLUDE_KEY] = ['SmellMe']
+    lc = LargeClass.new(@config)
+    lc.examine(@ctx, @rpt).should == true
+    @rpt.length.should == 1
+  end
+end
 
-    it 'should report non-excepted name' do
-      @config[LargeClass::EXCLUDE_KEY] = ['SmellMe']
-      lc = LargeClass.new(@config)
-      lc.examine(@ctx, @rpt).should == true
-      @rpt.length.should == 1
+describe LargeClass, 'counting instance variables' do
+  it 'warns about class with 10 ivars' do
+    class ManyIvars
+      def method
+        @vara = @varb = @varc = @vard = @vare
+        @varf = @varg = @varh = @vari = @varj
+      end
     end
+    ManyIvars.should reek_of(:LargeClass, /10/)
   end
-end
 
-describe LargeClass do
-  it 'should not report empty class in another module' do
-    'class Treetop::Runtime::SyntaxNode; end'.should_not reek
+  it 'ignores class with only a couple of ivars' do
+    LargeClass.should_not reek_of(:LargeClass)
   end
 
-  it 'should deal with :: scoped names' do
-    element = ClassContext.create(StopContext.new, [:colon2, [:colon2, [:const, :Treetop], :Runtime], :SyntaxNode])
-    element.num_methods.should == 0
+  it 'ignores fq class with only a couple of ivars' do
+    Reek::Smells::LargeClass.should_not reek_of(:LargeClass)
   end
 end

data/spec/reek/smells/long_method_spec.rb

@@ -5,7 +5,7 @@ require 'reek/report'
 
 include Reek
 
-describe CodeParser, "(Long Method)" do
+describe LongMethod do
   it 'should not report short methods' do
     'def short(arga) alf = f(1);@bet = 2;@cut = 3;@dit = 4; @emp = 5;end'.should_not reek
   end

data/spec/reek/smells/long_parameter_list_spec.rb

@@ -7,7 +7,7 @@ require 'reek/report'
 include Reek
 include Reek::Smells
 
-describe CodeParser, "(Long Parameter List)" do
+describe LongParameterList do
   
   describe 'for methods with few parameters' do
     it 'should report nothing for no parameters' do
@@ -25,7 +25,7 @@ describe CodeParser, "(Long Parameter List)" do
     it 'should not report inner block with too many parameters' do
       'def simple(yep,zero); m[3]; rand(34); f.each { |arga, argb, argc, argd| true}; end'.should_not reek
     end
-    
+
     describe 'and default values' do
       it 'should report nothing for 1 parameter' do
         'def simple(zero=nil) f(3);false end'.should_not reek
@@ -57,20 +57,13 @@ describe CodeParser, "(Long Parameter List)" do
     end
     
     describe 'in a class' do
-      before(:each) do
-        @rpt = Report.new
-        @cchk = CodeParser.new(@rpt, SmellConfig.new.smell_listeners)
-      end
-
       class InnerTest
         def xyzero(arga,argb) f(3);true end
         def abc(argx,yep,zero,argm) f(3);false end
       end
 
       it 'should only report long param list' do
-        @cchk.check_object(InnerTest)
-        @rpt.length.should == 1
-        @rpt[0].report.should match(/Long Parameter List/)
+        InnerTest.should reek_only_of(:LongParameterList, /abc/)
       end
     end
   end
@@ -83,7 +76,7 @@ describe CodeParser, "(Long Parameter List)" do
       'def simple(arga, argb, &blk) f(3);yield a,b; end'.should_not reek
     end
     it 'should report yield with many parameters' do
-      'def simple(arga, argb, &blk) f(3);yield a,b,a,b; end'.should reek_only_of(:LongYieldList, /simple/, /yields/, /4/)
+      'def simple(arga, argb, &blk) f(3);yield arga,argb,arga,argb; end'.should reek_only_of(:LongYieldList, /simple/, /yields/, /4/)
     end
     it 'should not report yield of a long expression' do
       'def simple(arga, argb, &blk) f(3);yield(if @dec then argb else 5+3 end); end'.should_not reek

data/spec/reek/smells/uncommunicative_name_spec.rb

@@ -46,6 +46,11 @@ describe UncommunicativeName, "local variable name" do
   it 'should report variable name only once' do
     'def simple(fred) x = jim(45); x = y end'.should reek_only_of(:UncommunicativeName, /x/)
   end
+
+  it 'should report a bad name inside a block' do
+    src = 'def clean(text) text.each { q2 = 3 } end'
+    src.should reek_of(:UncommunicativeName, /q2/)
+  end
 end
 
 describe UncommunicativeName, "parameter name" do
@@ -64,7 +69,7 @@ describe UncommunicativeName, "block parameter name" do
   it "should report parameter's name" do
     'def help() @stuff.each {|x|} end'.should reek_only_of(:UncommunicativeName, /x/, /block/, /variable name/)
   end
-  
+
   it "should report method name via if context" do
     src = <<EOS
 def bad

data/spec/reek/smells/utility_function_spec.rb

@@ -7,17 +7,11 @@ include Reek::Smells
 
 describe UtilityFunction do
 
-  before(:each) do
-    @rpt = Report.new
-    @cchk = CodeParser.new(@rpt, SmellConfig.new.smell_listeners)
-  end
-
   it 'should not report attrset' do
     class Fred
       attr_writer :xyz
     end
-    @cchk.check_object(Fred)
-    @rpt.should be_empty
+    Fred.should_not reek
   end
 
   it 'should count usages of self'do
@@ -43,8 +37,7 @@ describe UtilityFunction do
     class Son < Father
       def thing(ff); ff; end
     end
-    @cchk.check_object(Son)
-    @rpt.should be_empty
+    Son.should_not reek
   end
 
   it 'should not report class method' do
@@ -93,4 +86,8 @@ describe UtilityFunction, 'should only report a method containing a call' do
   it 'should not report references to self' do
     'def into; self; end'.should_not reek
   end
+
+  it 'should recognise an ivar reference within a block' do
+    'def clean(text) text.each { @fred = 3} end'.should_not reek
+  end
 end

data/spec/{samples → slow}/inline_spec.rb

@@ -2,23 +2,26 @@ require File.dirname(__FILE__) + '/../spec_helper.rb'
 
 describe 'sample gem source code' do
   it "reports the correct smells in inline.rb" do
-    ruby = File.new('spec/samples/inline.rb').to_source
+    ruby = File.new("#{SAMPLES_DIR}/inline.rb").to_source
     ruby.should reek_of(:ControlCouple, /Inline::C#parse_signature/, /raw/)
     ruby.should reek_of(:ControlCouple, /Module#inline/, /options/)
-    ruby.should reek_of(:Duplication, /Inline::C#build/, /\$\?\.==\(0\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /\(\$\?\ == 0\)/)
     ruby.should reek_of(:Duplication, /Inline::C#build/, /Inline.directory/)
     ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts/)
-    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts\(#endif\)/)
-    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts\(#ifdef __cplusplus\)/)
-    ruby.should reek_of(:Duplication, /Inline::C#crap_for_windoze/, /Config::CONFIG\[libdir\]/)
-    ruby.should reek_of(:Duplication, /Inline::C#generate/, /result.sub!\(\(\?-mix:\\A\\n\), \)/)
-    ruby.should reek_of(:Duplication, /Inline::C#generate/, /signature\[args\]/)
-    ruby.should reek_of(:Duplication, /Inline::C#generate/, /signature\[args\].map/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts\("#endif"\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts\("#ifdef __cplusplus"\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /module_name/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /warn\("Output:\\n\#\{result\}"\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#crap_for_windoze/, /Config::CONFIG\["libdir"\]/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /result.sub!\(\/\\A\\n\/, ""\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /signature\["args"\]/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /signature\["args"\].map/)
     ruby.should reek_of(:Duplication, /Inline::C#initialize/, /stack.empty?/)
+    ruby.should reek_of(:Duplication, /Inline::C#load/, /so_name/)
     ruby.should reek_of(:Duplication, /Inline::self.rootdir/, /env.nil?/)
     ruby.should reek_of(:Duplication, /Module#inline/, /Inline.const_get\(lang\)/)
     ruby.should reek_of(:FeatureEnvy, /Inline::C#strip_comments/, /src/)
-    ruby.should reek_of(:LargeClass, /Inline::C/)
+    ruby.should reek_of(:LargeClass, /Inline::C/, /instance variables/)
     ruby.should reek_of(:LongMethod, /File#self.write_with_backup/)
     ruby.should reek_of(:LongMethod, /Inline::C#build/)
     ruby.should reek_of(:LongMethod, /Inline::C#generate/)
@@ -35,6 +38,6 @@ describe 'sample gem source code' do
     ruby.should reek_of(:UncommunicativeName, /Inline::C#module_name/, /'x'/)
     ruby.should reek_of(:UncommunicativeName, /Inline::C#parse_signature/, /'x'/)
     ruby.should reek_of(:UtilityFunction, /Inline::C#strip_comments/)
-    ruby.report.should have_at_most(32).smells
+    ruby.report.should have_at_most(35).smells
   end
 end

data/spec/{samples → slow}/optparse_spec.rb

@@ -2,7 +2,7 @@ require File.dirname(__FILE__) + '/../spec_helper.rb'
 
 describe 'sample gem source code' do
   it "reports the correct smells in optparse.rb" do
-    ruby = File.new('spec/samples/optparse.rb').to_source
+    ruby = File.new("#{SAMPLES_DIR}/optparse.rb").to_source
     ruby.should reek_of(:ControlCouple, /OptionParser#List#accept/, /pat/)
     ruby.should reek_of(:ControlCouple, /OptionParser#List#update/, /lopts/)
     ruby.should reek_of(:ControlCouple, /OptionParser#List#update/, /sopts/)
@@ -10,24 +10,33 @@ describe 'sample gem source code' do
     ruby.should reek_of(:ControlCouple, /OptionParser#Switch#NoArgument#parse/, /arg/)
     ruby.should reek_of(:ControlCouple, /OptionParser#Switch#OptionalArgument#parse/, /arg/)
     ruby.should reek_of(:ControlCouple, /OptionParser#Switch#RequiredArgument#parse/, /arg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#block/, /o/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#block/, /s/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#block\/block/, /pkg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#getopts\/block/, /val/)
     ruby.should reek_of(:ControlCouple, /OptionParser#parse_in_order/, /setter/)
     ruby.should reek_of(:Duplication, /OptionParser#Completion::complete/, /candidates.size/)
     ruby.should reek_of(:Duplication, /OptionParser#Completion::complete/, /k.id2name/)
     ruby.should reek_of(:Duplication, /OptionParser#Switch#parse_arg/, /s.length/)
-    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /block.max/)
-    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /block.max.to_i/)
-    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /indent.+\(l\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.collect \{ \|s\| s\.length \}\.max/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.collect \{ \|s\| s\.length \}\.max\.to_i/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /\(indent \+ l\)/)
     ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.collect/)
     ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.shift/)
     ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left\[-1\]/)
     ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /s.length/)
-    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /default_style.guess\(arg=a\)/)
-    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /long.<<\(o=q.downcase\)/)
-    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.method\(convert\)/)
-    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.method\(convert\).to_proc/)
-    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.respond_to\?\(convert\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#getopts/, /result\[opt\] = false/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /default_style.guess\(arg = a\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /\(long << o = q.downcase\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /notwice\(a \? \(Object\) : \(TrueClass\), klass, "type"\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /notwice\(NilClass, klass, "type"\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.method\(:convert\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.method\(:convert\).to_proc/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.respond_to\?\(:convert\)/)
     ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /q.downcase/)
-    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /sdesc.<<\("-\#\{q\}"\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /search\(:atype, o\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /search\(:atype, FalseClass\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /\(sdesc << "-\#\{q\}"\)/)
     ruby.should reek_of(:Duplication, /OptionParser#order/, /argv\[0\]/)
     ruby.should reek_of(:Duplication, /OptionParser#parse/, /argv\[0\]/)
     ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /\$\!.set_option\(arg, true\)/)
@@ -45,7 +54,6 @@ describe 'sample gem source code' do
     ruby.should reek_of(:LargeClass, /OptionParser/)
     ruby.should reek_of(:LongMethod, /OptionParser#Completion::complete/)
     ruby.should reek_of(:LongMethod, /OptionParser#List#update/)
-    ruby.should reek_of(:LongMethod, /OptionParser#Switch#PlacedArgument#parse/)
     ruby.should reek_of(:LongMethod, /OptionParser#Switch#parse_arg/)
     ruby.should reek_of(:LongMethod, /OptionParser#Switch#summarize/)
     ruby.should reek_of(:LongMethod, /OptionParser#getopts/)
@@ -95,6 +103,6 @@ describe 'sample gem source code' do
     ruby.should reek_of(:UncommunicativeName, /OptionParser#summarize/, /'l'/)
     ruby.should reek_of(:UncommunicativeName, /OptionParser#ver/, /'v'/)
     ruby.should reek_of(:UncommunicativeName, /block/, /'q'/)
-    ruby.report.should have_at_most(92).smells
+    ruby.report.should have_at_most(116).smells
   end
 end

data/spec/{samples → slow}/redcloth_spec.rb

@@ -2,7 +2,7 @@ require File.dirname(__FILE__) + '/../spec_helper.rb'
 
 describe 'sample gem source code' do
   it "reports the correct smells in redcloth.rb" do
-    ruby = File.new('spec/samples/redcloth.rb').to_source
+    ruby = File.new("#{SAMPLES_DIR}/redcloth.rb").to_source
     ruby.should reek_of(:ControlCouple, /RedCloth#blocks\/block/, /deep_code/)
     ruby.should reek_of(:ControlCouple, /RedCloth#check_refs/, /text/)
     ruby.should reek_of(:ControlCouple, /RedCloth#pba/, /text_in/)
@@ -13,23 +13,31 @@ describe 'sample gem source code' do
     ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth.last/)
     ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth.last.length/)
     ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth\[i\]/)
-    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /line_id.-\(1\)/)
-    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /lines\[line_id.-\(1\)\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /\(line_id - 1\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /lines\[\(line_id - 1\)\]/)
     ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /tl.length/)
     ruby.should reek_of(:Duplication, /RedCloth#clean_html/, /tags\[tag\]/)
     ruby.should reek_of(:Duplication, /RedCloth#pba/, /\$1.length/)
     ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /@pre_list.last/)
-    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /@pre_list.last.<<\(line\)/)
-    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.-\(used_offtags.length\)/)
-    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.-\(used_offtags.length\).>\(0\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /\(@pre_list.last << line\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /\(codepre - used_offtags.length\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /\(\(codepre - used_offtags.length\) > 0\)/)
     ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.zero?/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /htmlesc\(line, :NoQuotes\)/)
     ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags.length/)
-    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags\[notextile\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags\["notextile"\]/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#block_markdown_atx/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#block_markdown_rule/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#block_markdown_setext/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#block_textile_lists/, /depth/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_html/, /raw/)
     ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_html/, /tags/)
     ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_white_space/, /text/)
     ruby.should reek_of(:FeatureEnvy, /RedCloth#flush_left/, /indt/)
     ruby.should reek_of(:FeatureEnvy, /RedCloth#flush_left/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#footnote_ref/, /text/)
     ruby.should reek_of(:FeatureEnvy, /RedCloth#htmlesc/, /str/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#incoming_entities/, /text/)
     ruby.should reek_of(:FeatureEnvy, /RedCloth#no_textile/, /text/)
     ruby.should reek_of(:FeatureEnvy, /RedCloth#pba/, /style/)
     ruby.should reek_of(:FeatureEnvy, /RedCloth#pba/, /text/)
@@ -88,6 +96,6 @@ describe 'sample gem source code' do
     ruby.should reek_of(:UtilityFunction, /RedCloth#incoming_entities/)
     ruby.should reek_of(:UtilityFunction, /RedCloth#no_textile/)
     ruby.should reek_of(:UtilityFunction, /RedCloth#v_align/)
-    ruby.report.should have_at_most(85).smells
+    ruby.report.should have_at_most(93).smells
   end
 end

data/spec/slow/source_list_spec.rb

@@ -0,0 +1,40 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+require 'reek/source'
+
+include Reek
+
+describe SourceList, 'from_pathlist' do
+
+  describe 'with no smells in any source' do
+    before :each do
+      @src = Dir['lib/reek/*.rb'].to_source
+    end
+
+    it 'reports no smells' do
+      @src.report.length.should == 0
+    end
+
+    it 'is empty' do
+      @src.report.should be_empty
+    end
+  end
+
+  describe 'with smells in one source' do
+    before :each do
+      @src = Source.from_pathlist(["#{SAMPLES_DIR}/inline.rb", 'lib/reek.rb'])
+    end
+
+    it 'reports some smells in the samples' do
+      @src.report.should have_at_least(30).smells
+    end
+
+    it 'is smelly' do
+      @src.should be_smelly
+    end
+
+    it 'reports an UncommunicativeName' do
+      @src.report.any? {|warning| warning.report =~ /Uncommunicative Name/}.should be_true
+    end
+  end
+end