reek 0.2.2 → 0.2.3

data/spec/samples/inline.reek

@@ -0,0 +1,17 @@
+[Long Method] C#build has approx 61 statements
+[Nested Iterators] C#build has nested iterators
+[Feature Envy] C#build uses io more than self
+[Uncommunicative Name] C#build uses the local variable name 't'
+[Uncommunicative Name] C#c uses the method name 'c'
+[Feature Envy] C#crap_for_windoze uses Config::CONFIG more than self
+[Long Method] C#generate has approx 33 statements
+[Feature Envy] C#initialize uses stack more than self
+[Long Method] C#load_cache has approx 7 statements
+[Long Method] C#module_name has approx 6 statements
+[Nested Iterators] C#module_name has nested iterators
+[Feature Envy] C#module_name uses md5 more than self
+[Long Method] C#parse_signature has approx 15 statements
+[Utility Function] C#strip_comments doesn't depend on instance state
+[Large Class] Dir has 31 methods
+[Large Class] Module has 34 methods
+[Long Method] Module#inline has approx 12 statements

data/spec/samples/optparse.reek

@@ -2,10 +2,7 @@
 [Long Method] AmbiguousArgument#options has approx 6 statements
 [Long Parameter List] CompletingHash#complete has 4 parameters
 [Nested Iterators] CompletingHash#complete has nested iterators
-[Feature Envy] CompletingHash#environment uses :env more than self
 [Long Method] CompletingHash#getopts has approx 17 statements
-[Long Method] CompletingHash#initialize has approx 8 statements
-[Feature Envy] CompletingHash#load uses :File and :filename more than self
 [Long Method] CompletingHash#make_switch has approx 69 statements
 [Nested Iterators] CompletingHash#make_switch has nested iterators
 [Uncommunicative Name] CompletingHash#make_switch uses the local variable name 'a'
@@ -14,42 +11,39 @@
 [Uncommunicative Name] CompletingHash#make_switch uses the local variable name 'q'
 [Uncommunicative Name] CompletingHash#make_switch uses the local variable name 's'
 [Nested Iterators] CompletingHash#match has nested iterators
-[Feature Envy] CompletingHash#order uses :argv more than self
-[Feature Envy] CompletingHash#parse uses :argv more than self
+[Feature Envy] CompletingHash#order uses argv more than self
+[Feature Envy] CompletingHash#parse uses argv more than self
 [Long Method] CompletingHash#parse_in_order has approx 31 statements
 [Nested Iterators] CompletingHash#parse_in_order has nested iterators
-[Feature Envy] CompletingHash#permute uses :argv more than self
-[Feature Envy] CompletingHash#permute! uses :arg more than self
+[Feature Envy] CompletingHash#permute uses argv more than self
 [Long Parameter List] CompletingHash#summarize has 4 parameters
 [Uncommunicative Name] CompletingHash#ver uses the local variable name 'v'
-[Feature Envy] CompletingHash#visit uses :el more than self
-[Feature Envy] List#accept uses :pat more than self
+[Feature Envy] List#accept uses pat more than self
 [Uncommunicative Name] List#accept uses the parameter name 't'
-[Feature Envy] List#add_banner uses :opt more than self
+[Feature Envy] List#add_banner uses opt more than self
 [Long Parameter List] List#complete has 4 parameters
+[Feature Envy] List#initialize uses OptionMap more than self
 [Uncommunicative Name] List#reject uses the parameter name 't'
-[Feature Envy] List#summarize uses :opt more than self
+[Feature Envy] List#summarize uses opt more than self
 [Long Parameter List] List#update has 5 parameters
 [Long Method] List#update has approx 6 statements
-[Feature Envy] List#update uses :o more than self
 [Uncommunicative Name] List#update uses the local variable name 'o'
 [Long Method] OptionParser#complete has approx 23 statements
-[Feature Envy] OptionParser#complete uses :candidates and :k more than self
+[Feature Envy] OptionParser#complete uses candidates more than self
 [Uncommunicative Name] OptionParser#complete uses the local variable name 'k'
 [Uncommunicative Name] OptionParser#complete uses the local variable name 'v'
 [Utility Function] OptionParser#convert doesn't depend on instance state
 [Long Method] PlacedArgument#parse has approx 6 statements
-[Feature Envy] PlacedArgument#parse uses :val more than self
 [Uncommunicative Name] Switch#add_banner uses the local variable name 's'
 [Long Parameter List] Switch#initialize has 7 parameters
 [Long Method] Switch#parse_arg has approx 12 statements
-[Feature Envy] Switch#parse_arg uses :m and :s more than self
+[Feature Envy] Switch#parse_arg uses arg more than self
 [Uncommunicative Name] Switch#parse_arg uses the local variable name 'm'
 [Uncommunicative Name] Switch#parse_arg uses the local variable name 's'
 [Long Parameter List] Switch#summarize has 5 parameters
 [Long Method] Switch#summarize has approx 27 statements
 [Nested Iterators] Switch#summarize has nested iterators
-[Feature Envy] Switch#summarize uses :s more than self
+[Feature Envy] Switch#summarize uses left more than self
 [Uncommunicative Name] Switch#summarize uses the local variable name 'l'
 [Uncommunicative Name] Switch#summarize uses the local variable name 'r'
 [Uncommunicative Name] Switch#summarize uses the local variable name 's'

data/spec/samples/redcloth.reek

@@ -1,38 +1,26 @@
-[Feature Envy] RedCloth#block_markdown_atx uses :blk and :cont and :text more than self
 [Long Method] RedCloth#block_markdown_bq has approx 6 statements
 [Utility Function] RedCloth#block_markdown_lists doesn't depend on instance state
 [Utility Function] RedCloth#block_markdown_rule doesn't depend on instance state
-[Feature Envy] RedCloth#block_markdown_rule uses :text more than self
-[Feature Envy] RedCloth#block_markdown_setext uses :blk and :cont and :text more than self
 [Long Method] RedCloth#block_textile_lists has approx 21 statements
 [Nested Iterators] RedCloth#block_textile_lists has nested iterators
-[Feature Envy] RedCloth#block_textile_lists uses :depth more than self
+[Feature Envy] RedCloth#block_textile_lists uses depth more than self
 [Long Method] RedCloth#block_textile_table has approx 19 statements
 [Nested Iterators] RedCloth#block_textile_table has nested iterators
 [Long Method] RedCloth#blocks has approx 17 statements
 [Nested Iterators] RedCloth#blocks has nested iterators
-[Feature Envy] RedCloth#blocks uses :blk more than self
 [Utility Function] RedCloth#clean_html doesn't depend on instance state
 [Long Method] RedCloth#clean_html has approx 14 statements
 [Nested Iterators] RedCloth#clean_html has nested iterators
-[Feature Envy] RedCloth#clean_html uses :raw and :tags more than self
 [Long Method] RedCloth#clean_white_space has approx 7 statements
-[Feature Envy] RedCloth#clean_white_space uses :text more than self
+[Feature Envy] RedCloth#clean_white_space uses text more than self
 [Utility Function] RedCloth#flush_left doesn't depend on instance state
-[Feature Envy] RedCloth#flush_left uses :indt more than self
 [Utility Function] RedCloth#footnote_ref doesn't depend on instance state
-[Feature Envy] RedCloth#footnote_ref uses :text more than self
 [Long Method] RedCloth#glyphs_textile has approx 9 statements
-[Feature Envy] RedCloth#glyphs_textile uses :codepre more than self
 [Utility Function] RedCloth#h_align doesn't depend on instance state
-[Feature Envy] RedCloth#h_align uses :H_ALGN_VALS more than self
 [Utility Function] RedCloth#htmlesc doesn't depend on instance state
-[Feature Envy] RedCloth#htmlesc uses :str more than self
 [Utility Function] RedCloth#incoming_entities doesn't depend on instance state
-[Feature Envy] RedCloth#incoming_entities uses :text more than self
 [Nested Iterators] RedCloth#inline has nested iterators
 [Long Method] RedCloth#inline_markdown_link has approx 6 statements
-[Feature Envy] RedCloth#inline_markdown_link uses :text more than self
 [Long Method] RedCloth#inline_markdown_reflink has approx 7 statements
 [Long Method] RedCloth#inline_textile_image has approx 16 statements
 [Long Method] RedCloth#inline_textile_link has approx 9 statements
@@ -40,15 +28,14 @@
 [Nested Iterators] RedCloth#inline_textile_span has nested iterators
 [Utility Function] RedCloth#lT doesn't depend on instance state
 [Utility Function] RedCloth#no_textile doesn't depend on instance state
-[Feature Envy] RedCloth#no_textile uses :text more than self
 [Long Method] RedCloth#pba has approx 22 statements
-[Feature Envy] RedCloth#pba uses :style and :text more than self
+[Feature Envy] RedCloth#pba uses style and text more than self
 [Long Method] RedCloth#rip_offtags has approx 22 statements
-[Feature Envy] RedCloth#rip_offtags uses :codepre more than self
+[Feature Envy] RedCloth#rip_offtags uses codepre more than self
+[Feature Envy] RedCloth#shelve uses @shelf more than self
+[Feature Envy] RedCloth#smooth_offtags uses @pre_list more than self
 [Long Parameter List] RedCloth#textile_bq has 4 parameters
 [Long Parameter List] RedCloth#textile_fn_ has 5 parameters
-[Feature Envy] RedCloth#textile_fn_ uses :atts more than self
 [Long Parameter List] RedCloth#textile_p has 4 parameters
 [Long Method] RedCloth#to_html has approx 24 statements
 [Utility Function] RedCloth#v_align doesn't depend on instance state
-[Feature Envy] RedCloth#v_align uses :V_ALGN_VALS more than self

data/tasks/samples.rake

@@ -1,5 +1,7 @@
 namespace :samples do
+
   files = Dir['spec/integration/*.rb'] + ['setup.rb']
+
   files.each do |f|
     fn = File.basename(f)
     desc "run reek on sample #{fn}"

data/website/index.html

@@ -5,7 +5,7 @@
   <link rel="stylesheet" href="stylesheets/screen.css" type="text/css" media="screen" />
   <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
   <title>
-      Code smell detector
+      reek
   </title>
   <script src="javascripts/rounded_corners_lite.inc.js" type="text/javascript"></script>
 <style>
@@ -30,73 +30,36 @@
 <body>
 <div id="main">
 
-    <h1>Code smell detector</h1>
+    <h1>reek</h1>
     <div id="version" class="clickable" onclick='document.location = "http://rubyforge.org/projects/reek"; return false'>
       <p>Get Version</p>
-      <a href="http://rubyforge.org/projects/reek" class="numbers">0.2.0</a>
+      <a href="http://rubyforge.org/projects/reek" class="numbers">0.2.2</a>
     </div>
-    <h1>&#x2192; &#8216;reek&#8217;</h1>
-
-
-	<h2>What</h2>
-
-
-	<p>Reek is a tool that examines Ruby classes, modules and methods and reports any code smells it finds.</p>
-
-
-	<h2>Installing</h2>
-
-
-	<p><pre class='syntax'><span class="ident">sudo</span> <span class="ident">gem</span> <span class="ident">install</span> <span class="ident">reek</span></pre></p>
-
-
-	<h2>The basics</h2>
-
-
-	<p><pre class='syntax'>
-  <span class="global">$ </span><span class="ident">cd</span> <span class="ident">my_project</span><span class="punct">/</span><span class="ident">lib</span>
-  <span class="global">$ </span><span class="ident">reek</span>
-</pre></p>
-
-
-	<p>(See reek&#8212;help for more.)</p>
-
-
-	<h2>Code Smells</h2>
-
-
-	<p>reek currently includes very naive checks for the following code smells:</p>
-
-
-	<ul>
+    <p>Reek is a tool that examines Ruby classes, modules and methods and reports any code smells it finds.</p>
+<h2>Installing</h2>
+<code>$ gem install reek</code>
+<h2>The basics</h2>
+<code>$ reek [options] [source_files]</code>
+<p>(See <code>reek --help</code> for details.)</p>
+<h2>Code Smells</h2>
+<p>reek currently includes very naive checks for the following code smells:</p>
+<ul>
 	<li>Long Method</li>
-		<li>Large Class</li>
-		<li>Feature Envy</li>
-		<li>Uncommunicative Name</li>
-		<li>Long Parameter List</li>
-		<li>Utility Function</li>
-		<li>Nested Iterators</li>
-	</ul>
-
-
-	<h2>How to access the source code</h2>
-
-
-	<p>The source is hosted on both <a href="http://github.com/kevinrutherford/reek/tree/master">github</a> and <a href="http://rubyforge.org/projects/reek/">rubyforge</a></p>
-
-
-	<h2>License</h2>
-
-
-	<p>This code is free to use under the terms of the <span class="caps">MIT</span> license.</p>
-
-
-	<h2>Contact</h2>
-
-
-	<p>Comments are welcome. Send an email to <a href="mailto:kevin@rutherford-software.com">Kevin Rutherford</a></p>
+	<li>Large Class</li>
+	<li>Feature Envy</li>
+	<li>Uncommunicative Name</li>
+	<li>Long Parameter List</li>
+	<li>Utility Function</li>
+	<li>Nested Iterators</li>
+</ul>
+<h2>How to access the source code</h2>
+<p>The source is hosted on both <a href="http://github.com/kevinrutherford/reek/tree/master">github</a> and <a href="http://rubyforge.org/projects/reek/">rubyforge</a></p>
+<h2>License</h2>
+<p>This code is free to use under the terms of the <span class="caps">MIT</span> license.</p>
+<h2>Contact</h2>
+<p>Comments are welcome. Send an email to <a href="mailto:kevin@rutherford-software.com">Kevin Rutherford</a></p>
     <p class="coda">
-      <a href="http://www.kevinrutherford.co.uk">Kevin Rutherford</a>, 12th September 2008<br>
+      <a href="http://www.kevinrutherford.co.uk">Kevin Rutherford</a>, 15th September 2008<br>
       Theme extended from <a href="http://rb2js.rubyforge.org/">Paul Battley</a>
     </p>
 </div>

data/website/index.txt

@@ -1,24 +1,16 @@
-h1. Code smell detector
-
-h1. → 'reek'
-
-
-h2. What
+h1. reek
 
 Reek is a tool that examines Ruby classes, modules and methods and reports any code smells it finds.
 
 h2. Installing
 
-<pre syntax="ruby">sudo gem install reek</pre>
+    @$ gem install reek@
 
 h2. The basics
 
-<pre syntax="ruby">
-  $ cd my_project/lib
-  $ reek
-</pre>
+    @$ reek [options] [source_files]@
 
-(See reek --help for more.)
+(See @reek --help@ for details.)
 
 h2. Code Smells
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: reek
 version: !ruby/object:Gem::Version 
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-09-15 00:00:00 +01:00
+date: 2008-09-22 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -53,6 +53,7 @@ files:
 - lib/reek/class_checker.rb
 - lib/reek/file_checker.rb
 - lib/reek/method_checker.rb
+- lib/reek/object_refs.rb
 - lib/reek/options.rb
 - lib/reek/printer.rb
 - lib/reek/report.rb
@@ -67,11 +68,16 @@ files:
 - spec/reek/long_parameter_list_spec.rb
 - spec/reek/method_checker_spec.rb
 - spec/reek/nested_iterators_spec.rb
+- spec/reek/object_refs_spec.rb
 - spec/reek/options_spec.rb
+- spec/reek/printer_spec.rb
 - spec/reek/report_spec.rb
 - spec/reek/smell_spec.rb
 - spec/reek/uncommunicative_name_spec.rb
 - spec/reek/utility_function_spec.rb
+- spec/reek_source_spec.rb
+- spec/samples/inline.rb
+- spec/samples/inline.reek
 - spec/samples/optparse.rb
 - spec/samples/optparse.reek
 - spec/samples/optparse/date.rb