reek 0.2.0 → 0.2.1

data/spec/samples/redcloth.reek

@@ -0,0 +1,54 @@
+[Feature Envy] RedCloth#block_markdown_atx uses :blk and :cont and :text more than self
+[Long Method] RedCloth#block_markdown_bq has approx 6 statements
+[Utility Function] RedCloth#block_markdown_lists doesn't depend on instance state
+[Utility Function] RedCloth#block_markdown_rule doesn't depend on instance state
+[Feature Envy] RedCloth#block_markdown_rule uses :text more than self
+[Feature Envy] RedCloth#block_markdown_setext uses :blk and :cont and :text more than self
+[Long Method] RedCloth#block_textile_lists has approx 21 statements
+[Nested Iterators] RedCloth#block_textile_lists has nested iterators
+[Feature Envy] RedCloth#block_textile_lists uses :depth more than self
+[Long Method] RedCloth#block_textile_table has approx 19 statements
+[Nested Iterators] RedCloth#block_textile_table has nested iterators
+[Long Method] RedCloth#blocks has approx 17 statements
+[Nested Iterators] RedCloth#blocks has nested iterators
+[Feature Envy] RedCloth#blocks uses :blk more than self
+[Utility Function] RedCloth#clean_html doesn't depend on instance state
+[Long Method] RedCloth#clean_html has approx 14 statements
+[Nested Iterators] RedCloth#clean_html has nested iterators
+[Feature Envy] RedCloth#clean_html uses :raw and :tags more than self
+[Long Method] RedCloth#clean_white_space has approx 7 statements
+[Feature Envy] RedCloth#clean_white_space uses :text more than self
+[Utility Function] RedCloth#flush_left doesn't depend on instance state
+[Feature Envy] RedCloth#flush_left uses :indt more than self
+[Utility Function] RedCloth#footnote_ref doesn't depend on instance state
+[Feature Envy] RedCloth#footnote_ref uses :text more than self
+[Long Method] RedCloth#glyphs_textile has approx 9 statements
+[Feature Envy] RedCloth#glyphs_textile uses :codepre more than self
+[Utility Function] RedCloth#h_align doesn't depend on instance state
+[Feature Envy] RedCloth#h_align uses :H_ALGN_VALS more than self
+[Utility Function] RedCloth#htmlesc doesn't depend on instance state
+[Feature Envy] RedCloth#htmlesc uses :str more than self
+[Utility Function] RedCloth#incoming_entities doesn't depend on instance state
+[Feature Envy] RedCloth#incoming_entities uses :text more than self
+[Nested Iterators] RedCloth#inline has nested iterators
+[Long Method] RedCloth#inline_markdown_link has approx 6 statements
+[Feature Envy] RedCloth#inline_markdown_link uses :text more than self
+[Long Method] RedCloth#inline_markdown_reflink has approx 7 statements
+[Long Method] RedCloth#inline_textile_image has approx 16 statements
+[Long Method] RedCloth#inline_textile_link has approx 9 statements
+[Long Method] RedCloth#inline_textile_span has approx 8 statements
+[Nested Iterators] RedCloth#inline_textile_span has nested iterators
+[Utility Function] RedCloth#lT doesn't depend on instance state
+[Utility Function] RedCloth#no_textile doesn't depend on instance state
+[Feature Envy] RedCloth#no_textile uses :text more than self
+[Long Method] RedCloth#pba has approx 22 statements
+[Feature Envy] RedCloth#pba uses :style and :text more than self
+[Long Method] RedCloth#rip_offtags has approx 22 statements
+[Feature Envy] RedCloth#rip_offtags uses :codepre more than self
+[Long Parameter List] RedCloth#textile_bq has 4 parameters
+[Long Parameter List] RedCloth#textile_fn_ has 5 parameters
+[Feature Envy] RedCloth#textile_fn_ uses :atts more than self
+[Long Parameter List] RedCloth#textile_p has 4 parameters
+[Long Method] RedCloth#to_html has approx 24 statements
+[Utility Function] RedCloth#v_align doesn't depend on instance state
+[Feature Envy] RedCloth#v_align uses :V_ALGN_VALS more than self

data/tasks/rspec.rake

@@ -22,12 +22,12 @@ CLEAN.include(REPORT_DIR)
 
 desc "runs the specs"
 Spec::Rake::SpecTask.new(:spec) do |t|
-  t.spec_files = FileList['spec/**/*.rb']
+  t.spec_files = FileList['spec/**/*_spec.rb']
 end
 
 desc "runs the specs and reports coverage in #{REPORT_DIR}"
 Spec::Rake::SpecTask.new(:spec_rcov) do |t|
-  t.spec_files = FileList['spec/**/*.rb']
+  t.spec_files = FileList['spec/**/*_spec.rb']
   t.rcov = true
   t.rcov_dir = REPORT_DIR
   t.rcov_opts = ['--exclude', 'spec,\.autotest']

data/tasks/samples.rake

@@ -0,0 +1,15 @@
+namespace :samples do
+  files = Dir['spec/integration/*.rb'] + ['setup.rb']
+  files.each do |f|
+    fn = File.basename(f)
+    desc "run reek on sample #{fn}"
+    task fn do
+      sh "ruby -Ilib bin/reek #{f}"
+    end
+    task :all => fn
+  end
+  
+  desc 'run all samples'
+  task :all
+
+end

data/website/index.html

@@ -59,7 +59,7 @@
 </pre></p>
 
 
-	<p>(More details coming soon&#8230;)</p>
+	<p>(See reek&#8212;help for more.)</p>
 
 
 	<h2>Code Smells</h2>
@@ -96,7 +96,7 @@
 
 	<p>Comments are welcome. Send an email to <a href="mailto:kevin@rutherford-software.com">Kevin Rutherford</a></p>
     <p class="coda">
-      <a href="http://www.kevinrutherford.co.uk">Kevin Rutherford</a>, 9th September 2008<br>
+      <a href="http://www.kevinrutherford.co.uk">Kevin Rutherford</a>, 12th September 2008<br>
       Theme extended from <a href="http://rb2js.rubyforge.org/">Paul Battley</a>
     </p>
 </div>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: reek
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-09-12 00:00:00 +01:00
+date: 2008-09-14 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -51,6 +51,7 @@ files:
 - lib/reek.rb
 - lib/reek/checker.rb
 - lib/reek/class_checker.rb
+- lib/reek/file_checker.rb
 - lib/reek/method_checker.rb
 - lib/reek/options.rb
 - lib/reek/printer.rb
@@ -58,10 +59,12 @@ files:
 - lib/reek/smells.rb
 - lib/reek/version.rb
 - setup.rb
+- spec/integration_spec.rb
 - spec/reek/class_checker_spec.rb
 - spec/reek/feature_envy_spec.rb
 - spec/reek/large_class_spec.rb
 - spec/reek/long_method_spec.rb
+- spec/reek/long_parameter_list_spec.rb
 - spec/reek/method_checker_spec.rb
 - spec/reek/nested_iterators_spec.rb
 - spec/reek/options_spec.rb
@@ -69,10 +72,19 @@ files:
 - spec/reek/smell_spec.rb
 - spec/reek/uncommunicative_name_spec.rb
 - spec/reek/utility_function_spec.rb
-- spec/reek_spec.rb
+- spec/samples/optparse.rb
+- spec/samples/optparse.reek
+- spec/samples/optparse/date.rb
+- spec/samples/optparse/shellwords.rb
+- spec/samples/optparse/time.rb
+- spec/samples/optparse/uri.rb
+- spec/samples/optparse/version.rb
+- spec/samples/redcloth.rb
+- spec/samples/redcloth.reek
 - spec/spec.opts
 - spec/spec_helper.rb
 - tasks/rspec.rake
+- tasks/samples.rake
 - website/index.html
 - website/index.txt
 - website/javascripts/rounded_corners_lite.inc.js

data/spec/reek_spec.rb

@@ -1,27 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper.rb'
-
-require 'reek'
-
-describe Reek, "#analyse" do
-
-  class ReekAnalyseInner1
-    def short1(str) f(3);true end
-    def long(arga, argb, argc, argd=4) f(3);27 end
-  end
-
-  class ReekAnalyseInner2
-    def long(arga, argb, argc, argd) f(3);27 end
-    def short2(str) f(3);true end
-  end
-
-  it 'should report Long Parameter List' do
-    rpt = Reek.analyse(ReekAnalyseInner1)
-    rpt.length.should == 1
-  end
-
-  it 'should report all Long Parameter Lists' do
-    rpt = Reek.analyse(ReekAnalyseInner1, ReekAnalyseInner2)
-    rpt.length.should == 2
-  end
-
-end