ree_lib 1.3.14 → 1.3.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ebed252b6557db13e60268884fd6b1a0f405f256d28aaf18953764886ab6cb0
-  data.tar.gz: e6328fda6013213c588f834b5a0782c271c76686b8303a0f458cfac5e926c80d
+  metadata.gz: 2ecb6d379981355aad60ca8e7f67493643cc351e3f5232c2d8baa326a7630d07
+  data.tar.gz: 2530c228029eb4df4e96d6208f7a0c13c22aeb263c573e69372683f4f195449f
 SHA512:
-  metadata.gz: 06ad16d1ca9361397b0e324d8ab0d9a3a064337831384f45616dd500efb88367c84be252537d203e07ec08cb109e8f976980ff39ac2de315f96938a21edc697e
-  data.tar.gz: fa3b6b910f9855585af6f0e985720db3773d7483779f65d3907badc16711e5bfdd159abcfcd8135466a5a2c57a75645da44c79ba532e0bcd9bf777d50aa7bdd5
+  metadata.gz: b1cc7a1ffbb0a4946d8359bb24ac0340c567fe9631dd389c70dc78fba3b5812d963d7174352a0e50ea7c918e7004a2ffa9c989797673978687c7865199179eb0
+  data.tar.gz: 815c690e32475a28c02dc3bbf8b4b8808b0b23302dd0cb8e5f35322b688f26ed68f4e1d98a0c4e10a9b6d80194a5fafec15fa76d8a0e60895b394918c4446754

data/Gemfile.lock

@@ -9,7 +9,7 @@ PATH
 PATH
   remote: .
   specs:
-    ree_lib (1.3.14)
+    ree_lib (1.3.15)
       bigdecimal
       binding_of_caller
       i18n

data/lib/ree_lib/packages/ree_audit/README.md

@@ -115,7 +115,7 @@ Annotating before the check, not after, keeps a refusal in the trail as well:
 | `request_method`, `path`, `request_path` | `path` is the DSL template (stable), `request_path` is the actual path (shows the object) |
 | `params` | what the action received, after filtering |
 | `accessor` | the authenticated object — the application decides how to read it |
-| `status` | `:ok`, `:denied`, `:error` |
+| `status` | `:ok`, `:denied`, `:not_found`, `:error` |
 | `error_type`, `error_message` | present when the call failed; message truncated to 512 chars |
 | `started_at`, `duration_ms` | timing (monotonic clock) |
 | `annotations` | whatever the application attached during the call |
@@ -124,6 +124,12 @@ Annotating before the check, not after, keeps a refusal in the trail as well:
 `:permission`. A refusal to show client data is as much an audit fact as
 showing it.
 
+`:denied` and `:not_found` are split out of `:error` on purpose. A refusal by
+permission and an ordinary "there was nothing to show" are both normal outcomes;
+filing them next to a crash makes a compliance report say something broke when
+nothing did. The split follows the domain error type, so an application gets it
+without classifying anything itself.
+
 There is **no HTTP status** on the event, and that is not an oversight: the
 wrapper sits around the action call, while Roda sets the status afterwards (and,
 on an exception, in the application's `error` block). Observing it here is

data/lib/ree_lib/packages/ree_audit/package/ree_audit/beans/audit.rb

@@ -47,7 +47,7 @@ class ReeAudit::Audit
       event.status = :ok
       result
     rescue StandardError => e
-      event.status = denied?(e) ? :denied : :error
+      event.status = status_for(e)
       event.error_type = e.class.name
       event.error_message = e.message.to_s[0, MAX_ERROR_MESSAGE_LENGTH]
       raise
@@ -62,11 +62,20 @@ class ReeAudit::Audit
 
   private
 
-  # A refusal to show client data is as much an audit fact as showing it.
-  def denied?(e)
-    e.is_a?(ReeErrors::Error) && e.type == :permission
+  # A refusal to show client data is as much an audit fact as showing it — and
+  # it must not be filed next to a crash. Neither must "there was nothing to
+  # show": a domain 404 is an ordinary outcome, and reading it as a failure in a
+  # compliance report tells the reader something broke when nothing did.
+  def status_for(e)
+    return :error if !e.is_a?(ReeErrors::Error)
+
+    case e.type
+    when :permission then :denied
+    when :not_found then :not_found
+    else :error
+    end
   rescue StandardError
-    false
+    :error
   end
 
   # The trail must never be the reason a request fails.

data/lib/ree_lib/packages/ree_audit/package/ree_audit/event.rb

@@ -4,7 +4,7 @@
 # enriched by the application through ReeAudit.annotate, and handed to a sink
 # once the call is over.
 class ReeAudit::Event
-  STATUSES = [:ok, :denied, :error].freeze
+  STATUSES = [:ok, :denied, :not_found, :error].freeze
 
   attr_accessor :action_name, :package_name, :summary, :sections,
                 :request_method, :path, :request_path, :params, :accessor,

data/lib/ree_lib/packages/ree_audit/spec/ree_audit/beans/audit_spec.rb

@@ -3,11 +3,13 @@
 package_require('ree_audit/beans/audit')
 package_require('ree_audit/event')
 package_require('ree_errors/permission_error')
+package_require('ree_errors/not_found_error')
 
 RSpec.describe :audit do
   link :audit, from: :ree_audit
   link :config, from: :ree_audit
   link :permission_error, from: :ree_errors
+  link :not_found_error, from: :ree_errors
   link :logger, from: :ree_logger
 
   # Captures what the application would have persisted.
@@ -89,6 +91,18 @@ RSpec.describe :audit do
     expect(written.error_message).to eq("not allowed")
   end
 
+  # 404 предметной области — обычный исход, а не поломка: строка «нечего
+  # показать» в отчёте соответствия не должна читаться как сбой.
+  it "records a domain not-found as its own outcome, not as a failure" do
+    klass = not_found_error(:missing)
+
+    expect {
+      audit.around(event) { raise klass.new("nothing here") }
+    }.to raise_error(klass)
+
+    expect(test_sink.events.first.status).to eq(:not_found)
+  end
+
   it "records an arbitrary failure as an error and lets it through" do
     expect {
       audit.around(event) { raise ArgumentError.new("boom") }

data/lib/ree_lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ReeLib
-  VERSION = "1.3.14"
+  VERSION = "1.3.15"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ree_lib
 version: !ruby/object:Gem::Version
-  version: 1.3.14
+  version: 1.3.15
 platform: ruby
 authors:
 - Ruslan Gatiyatov