ree 1.0.28 → 1.0.30

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9d6451014359adf3959bb738c0af6d7b8409731861230587d9053ff12680a6c
-  data.tar.gz: 58d5795a1a4053195b62cc8811528f05674f8d1f292d34b59ad50a0b6ac8599a
+  metadata.gz: c26bd9f765b493214449328b06c723150c4d64a1a6198836ccdd3e92d6c38ed2
+  data.tar.gz: bec255f8119ff87b049000bb758e157d18507568d636fa4e19e6bbe363b9e4f0
 SHA512:
-  metadata.gz: '05780d456c3cada1a08ce6c5d9775054215121eb265305ab30a2b7a8b08b08528cbefc9912ea7ad6b4f46265832d5f266432f50788fdbb4fcd923d8e0025ef1d'
-  data.tar.gz: bade40ae6f6123b55a04d0eaecb9af2c9ece3a3e7b05a0ecde0e9c5bb06344a6616033ce3e236a6fa2c7da4ef3f3c0514b4c53fce84ea19bb58f0e763a67b06d
+  metadata.gz: 312e40978d8bec156f2a8bce86a84083045a8034f5436ef7f53c506806ef0044b4c29ca2a09b0233614d20f5198ac6c0babdf2484852816f0d8a3787b4e54461
+  data.tar.gz: b8c81dc9707038944f00ddc38ab4a3f269597630b1a05923df292244f4e12d5d9a8e2ceb3651f3f09003a9ed2a1bfd1eb31d47507a6cb6d05bb5a43ad717d2c1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ree (1.0.28)
+    ree (1.0.30)
       commander (~> 4.6.0)
 
 GEM

data/lib/ree/dsl/import_dsl.rb

@@ -1,21 +1,24 @@
 # frozen_string_literal  = true
 
 class Ree::ImportDsl
+  def initialize
+    setup_removed_constants
+  end
+
   def execute(klass, proc)
-    self.class.instance_exec(&proc)
-  rescue Ree::ImportDsl::UnlinkConstError => e
-    const_removed = remove_const(klass, e.const)
+    class_constant = self.class.instance_exec(&proc)
 
-    retry if const_removed
+    [
+      extract_constants(class_constant),
+      get_removed_constants
+    ]
+  rescue Ree::ImportDsl::UnlinkConstError => e
+    retry_after = remove_or_assign_const(klass, e.const)
+    retry if retry_after
   rescue NoMethodError => e
-    if e.name == :&
-      const_removed = remove_const(klass, e.receiver)
-
-      if const_removed
-        retry
-      else
-        raise Ree::Error.new("'#{e.receiver}' already linked or defined in '#{klass}'", :invalid_dsl_usage)
-      end
+    if e.name == :& || e.name == :as
+      retry_after = remove_or_assign_const(klass, e.receiver)
+      retry if retry_after
     else
       raise e
     end
@@ -27,9 +30,30 @@ class Ree::ImportDsl
     retry
   end
 
+  private def extract_constants(class_constant)
+    [class_constant] + class_constant.constants
+  end
+
+  private def setup_removed_constants
+    self.class.instance_variable_set(:@removed_constants, [])
+  end
+
+  private def get_removed_constants
+    self.class.instance_variable_get(:@removed_constants)
+  end
+
+  class RemovedConstant
+    attr_reader :name, :const
+
+    def initialize(name, const)
+      @name = name
+      @const = const
+    end
+  end
+
   class UnlinkConstError < StandardError
     attr_reader :const
-    
+
     def initialize(const)
       @const = const
     end
@@ -82,25 +106,72 @@ class Ree::ImportDsl
 
   private
 
-  def remove_const(klass, constant)
-    const_removed = false
+  def remove_or_assign_const(klass, constant)
+    retry_after = false
 
     klass.constants.each do |const_sym|
       const = klass.const_get(const_sym)
+      next if const.is_a?(ClassConstant)
 
       if constant.is_a?(Class) || constant.is_a?(Module)
         if (const.is_a?(Class) || const.is_a?(Module)) && const.name == constant.name
           klass.send(:remove_const, const_sym)
-          const_removed = true
+          store_removed_constant(const_sym, constant)
+
+          retry_after = true
           break
         end
       elsif const == constant
         klass.send(:remove_const, const_sym)
-        const_removed = true
+        store_removed_constant(const_sym, constant)
+
+        retry_after = true
         break
       end
     end
 
-    const_removed
+    return true if retry_after
+
+    const_name = if constant.is_a?(String)
+      constant.to_sym
+    elsif constant.is_a?(Class) || constant.is_a?(Module)
+      constant.name
+    else
+      raise ArgumentError.new("unknown constant: #{constant.inspect}")
+    end
+
+    if parent_constant?(klass, const_name)
+      klass.const_set(const_name, ClassConstant.new(const_name.to_s))
+      retry_after = true
+    end
+
+    retry_after
+  end
+
+  private
+
+  def store_removed_constant(name, constant)
+    return if constant.is_a?(ClassConstant)
+    get_removed_constants << RemovedConstant.new(name, constant.dup)
+  end
+
+  def parent_constant?(klass, const_name)
+    modules = klass.to_s.split("::")[0..-2]
+
+    result = modules.each_with_index.any? do |mod, index|
+      mod = Object.const_get(modules[0..index].join("::"))
+      mod.constants.include?(const_name)
+    end
+
+    result || acnchestor_constant?(klass, const_name)
+  end
+
+  def acnchestor_constant?(klass, const_name)
+    return false if klass.ancestors.include?(klass) && klass.ancestors.size == 1
+
+    klass.ancestors.any? do |anchestor|
+      next if anchestor == klass
+      anchestor.constants.include?(const_name) || acnchestor_constant?(anchestor, const_name)
+    end
   end
 end

data/lib/ree/dsl/link_import_builder.rb

@@ -11,14 +11,13 @@ class Ree::LinkImportBuilder
   # @param [Proc] proc
   # @return [ArrayOf[String]] List of names of imported constants
   def build(klass, package_name, object_name, proc)
-    result = Ree::ImportDsl.new.execute(klass, proc)
+    const_list, removed_constants = Ree::ImportDsl.new.execute(klass, proc)
 
     @packages_facade.load_package_object(package_name, object_name)
 
     package = @packages_facade.get_package(package_name)
     object = package.get_object(object_name)
-    const_list = [result] + result.constants
-    
+
     const_list.each do |const_obj|
       if object.klass.const_defined?(const_obj.name)
         set_const(klass, object.klass.const_get(const_obj.name), const_obj)
@@ -29,6 +28,8 @@ class Ree::LinkImportBuilder
       end
     end
 
+    assign_removed_constants(klass, removed_constants)
+
     const_list.map(&:name)
   end
 
@@ -37,9 +38,8 @@ class Ree::LinkImportBuilder
   # @param [Proc] proc
   # @return [ArrayOf[String]] List of names of imported constants
   def build_for_const(klass, source_const, proc)
-    result = Ree::ImportDsl.new.execute(klass, proc)
+    const_list, removed_constants = Ree::ImportDsl.new.execute(klass, proc)
     mod_const = Object.const_get(source_const.name.split("::").first)
-    const_list = [result] + result.constants
 
     const_list.each do |const_obj|
       if source_const.const_defined?(const_obj.name)
@@ -50,14 +50,28 @@ class Ree::LinkImportBuilder
         raise Ree::Error.new("'#{const_obj.name}' is not found in '#{source_const}'")
       end
     end
+
+    assign_removed_constants(klass, removed_constants)
+    nil
   end
 
   private
 
+  def assign_removed_constants(klass, removed_constants)
+    removed_constants.each do |removed_const|
+      next if klass.const_defined?(removed_const.name)
+      klass.const_set(removed_const.name, removed_const.const)
+    end
+  end
+
   def set_const(target_klass, ref_class, const_obj)
     if const_obj.get_as
       target_klass.send(:remove_const, const_obj.get_as.name) rescue nil
       target_klass.const_set(const_obj.get_as.name, ref_class)
+
+      if target_klass.const_get(const_obj.name).is_a?(Ree::ImportDsl::ClassConstant)
+        target_klass.send(:remove_const, const_obj.name)
+      end
     else
       target_klass.send(:remove_const, const_obj.name) rescue nil
       target_klass.const_set(const_obj.name, ref_class)

data/lib/ree/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ree
-  VERSION = "1.0.28"
+  VERSION = "1.0.30"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ree
 version: !ruby/object:Gem::Version
-  version: 1.0.28
+  version: 1.0.30
 platform: ruby
 authors:
 - Ruslan Gatiyatov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-04-05 00:00:00.000000000 Z
+date: 2023-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: commander