redmine_remotes 0.11.0 → 0.15.0

data/app/models/remote_tracker_fetch.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'eac_ruby_utils/core_ext'
+
+class RemoteTrackerFetch < ::EacRailsUtils::Models::Tableless
+  require_sub __FILE__, include_modules: true, require_dependency: true
+  enable_simple_cache
+  include ::EacRailsUtils::Models::FetchErrors
+
+  attribute :remote_tracker_id, ::Integer
+  belongs_to :remote_tracker, class_name: 'RemoteTracker'
+
+  validates :remote_tracker, presence: true
+  validates :start_time, presence: true
+  validates :end_time, presence: true
+  validate :remote_tracker_fetchable_validation
+
+  def save
+    ::Issue.transaction do
+      return false unless valid?
+      return false unless save_remote_issues
+      return false unless save_remote_tracker
+    end
+    true
+  end
+
+  def default_error_column
+    :remote_tracker_id
+  end
+
+  private
+
+  def end_time_uncached
+    ::Time.zone.now
+  end
+
+  def start_time_uncached
+    remote_tracker.try(:fetched_at) || end_time
+  end
+
+  def remote_tracker_fetchable_validation
+    return if remote_tracker.blank?
+    return if remote_tracker.fetchable?
+
+    errors.add(:remote_tracker, "Remote tracker \"#{remote_tracker}\" is not fetchable")
+  end
+end

data/app/models/remote_tracker_fetch/provider.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'eac_ruby_utils/core_ext'
+
+class RemoteTrackerFetch < ::EacRailsUtils::Models::Tableless
+  module Provider
+    private
+
+    def provider_issues_codes
+      remote_tracker.remote_instance.fetch_issues_changed(start_time, end_time)
+    end
+  end
+end

data/app/models/remote_tracker_fetch/remote_issues.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'eac_ruby_utils/core_ext'
+
+class RemoteTrackerFetch < ::EacRailsUtils::Models::Tableless
+  module RemoteIssues
+    private
+
+    def save_remote_issues
+      remote_issues.all? { |remote_issue| save_remote_issue(remote_issue) }
+    end
+
+    def save_remote_issue(remote_issue)
+      return true if remote_issue.update(outdated_at: end_time)
+
+      fetch_record_errors(remote_issue, default_column: default_error_column)
+      false
+    end
+
+    def remote_issues_uncached
+      provider_issues_codes.map do |code|
+        ::RemoteIssue.find_by(remote_tracker: remote_tracker,
+                              remote_code: ::RemoteIssue.remote_code_sanitize(code))
+      end.reject(&:blank?)
+    end
+  end
+end

data/app/models/remote_tracker_fetch/remote_tracker.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'eac_ruby_utils/core_ext'
+
+class RemoteTrackerFetch < ::EacRailsUtils::Models::Tableless
+  module RemoteTracker
+    private
+
+    def save_remote_tracker
+      return true if remote_tracker.update(fetched_at: end_time)
+
+      fetch_record_errors(remote_tracker, default_column: default_error_column)
+      false
+    end
+  end
+end

data/app/models/remote_user/find_local_user.rb

@@ -25,7 +25,7 @@ class RemoteUser < ActiveRecord::Base
 
     def result_by_local_user_mail_address
       condition = ::EmailAddress.arel_table[:address].matches("#{remote_login}@%")
-      ::EmailAddress.where(condition).first.try(:user)
+      ::EmailAddress.find_by(condition).try(:user)
     end
 
     def result_by_register_not_found
@@ -47,10 +47,10 @@ class RemoteUser < ActiveRecord::Base
     end
 
     def remote_tracker_result(remote_tracker)
-      ::RemoteUser.where(
+      ::RemoteUser.find_by(
         remote_tracker: remote_tracker,
         remote_login: remote_login
-      ).first.try(:local_user)
+      ).try(:local_user)
     end
 
     def remote_trackers_to_search

data/config/initializers/001_patches.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'redmine_remotes/patches/avmtrf1_rest_provider_instance'
 require 'redmine_remotes/patches/issue'
 require 'redmine_remotes/patches/issue_status'
 require 'redmine_remotes/patches/project'

data/config/locales/en.yml

@@ -22,3 +22,4 @@ en:
   label_remote_issue_statuses: Remote issue statuses
   label_remote_users: Remote users
   label_remotes: Remotes
+  menu_redmine_remotes: Remotes

data/config/locales/pt-BR.yml

@@ -22,3 +22,4 @@ pt-BR:
   label_remote_issue_statuses: Situações de demandas remotas
   label_remote_users: Usuários remotos
   label_remotes: Remotos
+  menu_redmine_remotes: Remotos

data/config/routes.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 RedmineApp::Application.routes.draw do
+  concern :active_scaffold, ActiveScaffold::Routing::Basic.new(association: true)
   get '/projects/:id/remotes', to: 'project_remote_issues#index'
   get '/projects/:id/tracker/:tracker_id/new_issue', to: 'project_remote_issues#new',
                                                      as: 'new_project_remote_issue'
@@ -9,9 +10,9 @@ RedmineApp::Application.routes.draw do
   put '/projects/:id/remote_issue/:remote_issue_id/update', to: 'project_remote_issues#update',
                                                             as: 'update_project_remote_issue'
   resources(:project_remote_issues, only: [:index])
-  resources(:remote_trackers) { as_routes }
-  resources(:remote_tracker_settings) { as_routes }
-  resources(:remote_issues) { as_routes }
-  resources(:remote_issue_statuses) { as_routes }
-  resources(:remote_users) { as_routes }
+  resources(:remote_trackers, concerns: :active_scaffold)
+  resources(:remote_tracker_settings, concerns: :active_scaffold)
+  resources(:remote_issues, concerns: :active_scaffold)
+  resources(:remote_issue_statuses, concerns: :active_scaffold)
+  resources(:remote_users, concerns: :active_scaffold)
 end

data/db/migrate/20190531171641_create_remote_trackers.rb

@@ -2,7 +2,7 @@
 
 class CreateRemoteTrackers < ActiveRecord::Migration
   def change
-    create_table :remote_trackers do |t|
+    create_table :remote_trackers do |t| # rubocop:disable Rails/CreateTableWithTimestamps
       t.string :profile
       t.string :root_url
       t.string :username

data/db/migrate/20190910182842_create_remote_users.rb

@@ -2,7 +2,7 @@
 
 class CreateRemoteUsers < ActiveRecord::Migration
   def change
-    create_table :remote_users do |t|
+    create_table :remote_users do |t| # rubocop:disable Rails/CreateTableWithTimestamps
       t.references :remote_tracker, index: true
       t.string :remote_login
       t.references :local_user, index: true

data/db/migrate/20190910203552_create_remote_issue_statuses.rb

@@ -2,7 +2,7 @@
 
 class CreateRemoteIssueStatuses < ActiveRecord::Migration
   def change
-    create_table :remote_issue_statuses do |t|
+    create_table :remote_issue_statuses do |t| # rubocop:disable Rails/CreateTableWithTimestamps
       t.references :remote_tracker, index: true
       t.references :local_tracker, index: true
       t.string :remote_name

data/db/migrate/20190912000000_create_remote_issues.rb

@@ -2,7 +2,7 @@
 
 class CreateRemoteIssues < ActiveRecord::Migration
   def change
-    create_table :remote_issues do |t|
+    create_table :remote_issues do |t| # rubocop:disable Rails/CreateTableWithTimestamps
       t.references :remote_tracker, index: true
       t.references :local_issue, index: true, nullable: true
       t.string :remote_code

data/db/migrate/20200602192120_add_outdated_at_to_remote_issues.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddOutdatedAtToRemoteIssues < ActiveRecord::Migration
+  def change
+    add_column :remote_issues, :outdated_at, :datetime
+  end
+end

data/db/migrate/20200602194753_add_fetched_at_to_remote_issues.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddFetchedAtToRemoteIssues < ActiveRecord::Migration
+  def change
+    add_column :remote_issues, :fetched_at, :timestamp
+  end
+end

data/db/migrate/20200602203020_add_fetched_at_to_remote_trackers.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddFetchedAtToRemoteTrackers < ActiveRecord::Migration
+  def change
+    add_column :remote_trackers, :fetched_at, :datetime
+  end
+end

data/lib/redmine_remotes/esosti/entities/issue.rb

@@ -6,8 +6,19 @@ module RedmineRemotes
   module Esosti
     module Entities
       class Issue < ::Avmtrf1::Esosti::Entities::Issue
+        EXTRA_DESCRIPTION_BEFORE = { reported_by: 'Relatado por', affected_person: 'Pessoa afetada',
+                                     type_description: 'Tipo de solicitação' }.freeze
+
+        def human_view_url
+          instance.issue_human_view_url(uid)
+        end
+
         def author_login
-          attributes.fetch('CREATEDBY').if_present { |v| v.gsub(/@[^@]+\z/, '') }
+          mail_local_part(attributes.fetch('CREATEDBY'))
+        end
+
+        def affected_person
+          mail_local_part(attributes.fetch('AFFECTEDPERSON'))
         end
 
         def attributes
@@ -28,17 +39,45 @@ module RedmineRemotes
           )
         end
 
+        def extra_description_before
+          {
+            'Relatado por' => "user:#{reported_by}",
+            'Pessoa afetada' => "user:#{affected_person}",
+            'Tipo de solicitação' => type_description
+          }
+        end
+
         def related_mbos
           data.first.fetch('RelatedMbos')
         end
 
+        def reported_by
+          mail_local_part(attributes.fetch('REPORTEDBY'))
+        end
+
         def status_name
           attributes.fetch('STATUS')
         end
 
         def subject
+          description.gsub(/\s+/, ' ')
+        end
+
+        def type_description
           attributes.fetch('DESCRIPTION')
         end
+
+        def uid
+          attributes.fetch('TICKETUID').fetch('content')
+        end
+
+        private
+
+        def mail_local_part(mail_address)
+          mail_address.if_present do |v|
+            /\A([^@]+)@/.if_match(v, false) { |m| m[1].downcase }.if_present(mail_address)
+          end
+        end
       end
     end
   end

data/lib/redmine_remotes/esosti/instance.rb

@@ -1,8 +1,11 @@
 # frozen_string_literal: true
 
+require 'avmtrf1/esosti/instance'
+require 'avmtrf1/esosti/raw_data_sanitizer'
+
 module RedmineRemotes
   module Esosti
-    class Instance < ::RedmineRemotes::RestProvider::Instance
+    class Instance < ::Avmtrf1::Esosti::Instance
       ISSUE_ID_PATTERN = /\A(?:ss|in)[0-9]+\z/i.freeze
 
       class << self
@@ -14,12 +17,12 @@ module RedmineRemotes
         end
       end
 
-      def build_service_url(service_url_suffix)
-        "#{root_url}/maxrest/rest#{service_url_suffix}"
+      def issue_human_view_url(ticket_uid)
+        "#{root_url}/itsm/ui/?event=loadapp&value=ms_sr&uniqueid=#{ticket_uid}"
       end
 
-      def issue_get_url_suffix(provider_issue_id)
-        "/os/MS_RMTICKET/?ticketid=#{provider_issue_id}"
+      def fetch_issues_changed(start_time, _end_time)
+        changed(start_time)
       end
     end
   end

data/lib/redmine_remotes/jira/entities/issue.rb

@@ -1,11 +1,15 @@
 # frozen_string_literal: true
 
-require 'avmtrf1/rest_provider/entity'
+require 'avmtrf1/jira/entities/issue'
 
 module RedmineRemotes
   module Jira
     module Entities
-      class Issue < ::Avmtrf1::RestProvider::Entity
+      class Issue < ::Avmtrf1::Jira::Entities::Issue
+        def human_view_url
+          instance.issue_human_view_url(code)
+        end
+
         def code
           data.fetch('key')
         end

data/lib/redmine_remotes/jira/instance.rb

@@ -1,33 +1,20 @@
 # frozen_string_literal: true
 
 require 'eac_ruby_utils/core_ext'
+require 'avmtrf1/jira/instance'
 
 module RedmineRemotes
   module Jira
-    class Instance < ::RedmineRemotes::RestProvider::Instance
-      ISSUE_ID_PATTERN = /\A([a-z][a-z0-9]+)\-(\d+)\z/i.freeze
+    class Instance < ::Avmtrf1::Jira::Instance
       DEFAULT_DESCRIPTION_FIELD = 'description'
 
-      class << self
-        def parse_issue_id(global_issue_id)
-          m = ISSUE_ID_PATTERN.match(global_issue_id)
-          return nil unless m
-
-          ::OpenStruct.new(provider_issue_id: m[0], project_id: m[1], project_issue_id: m[2])
-        end
-      end
-
-      def build_service_url(service_url_suffix)
-        "#{root_url}/rest/api/latest#{service_url_suffix}"
-      end
-
       def description_field
         remote_tracker.setting_value(::RemoteTrackerSetting::NAME_FIELD_DESCRIPTION)
                       .if_present(DEFAULT_DESCRIPTION_FIELD)
       end
 
-      def issue_get_url_suffix(provider_issue_id)
-        "/issue/#{provider_issue_id}"
+      def issue_human_view_url(issue_code)
+        "#{root_url}/browse/#{issue_code.to_s.upcase}"
       end
     end
   end

data/lib/redmine_remotes/jobs/fetch_issues.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module RedmineRemotes
+  module Jobs
+    class FetchIssues
+      enable_simple_cache
+
+      def run
+        ::Rails.logger.info("Issues to fetch: #{issues_to_fetch.count}")
+        issues_to_fetch.each { |issue| fetch_issue(issue) }
+      end
+
+      private
+
+      def issues_to_fetch_uncached
+        ::RemoteIssue.outdated
+      end
+
+      def fetch_issue(remote_issue)
+        ::Rails.logger.info 'Fetching remote issue ' \
+          "\"#{remote_issue}|\##{remote_issue.local_issue.id}\""
+        record = ::RemoteIssueFetch::Update.new(
+          remote_issue: remote_issue
+        )
+        return if record.save
+
+        ::Rails.logger.warn "Fetch failed with errors: #{record.errors.messages}"
+      end
+    end
+  end
+end

data/lib/redmine_remotes/jobs/fetch_trackers.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module RedmineRemotes
+  module Jobs
+    class FetchTrackers
+      enable_simple_cache
+
+      def run
+        ::Rails.logger.info("Trackers to fetch: #{trackers_to_fetch.count}")
+        trackers_to_fetch.each { |tracker| fetch_tracker(tracker) }
+      end
+
+      private
+
+      def fetch_tracker(remote_tracker)
+        ::Rails.logger.info "Fetch remote tracker \"#{remote_tracker}\"..."
+        record = ::RemoteTrackerFetch.new(
+          remote_tracker: remote_tracker
+        )
+        return if record.save
+
+        ::Rails.logger.warn "Fetched failed with errors: #{record.errors.messages}"
+      end
+
+      def trackers_to_fetch_uncached
+        ::RemoteTracker.where(profile: ::RemoteTracker::PROFILE_ESOSTI)
+      end
+    end
+  end
+end