redmine_plugins_helper 0.6.4 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc58802ae88b2b9bdacd3f4e197e526b8ebe0143a8e2d6d269030ac8ac6d2541
-  data.tar.gz: a064c7cfb58df6f7a588c2d9f560896d32236f37c6438fcacb894035f547bc5f
+  metadata.gz: e85f357f0bcab7126a87e73c6024417f999db4b657e39371ddc492107a6b6287
+  data.tar.gz: 85038fc7bae3559703d6f2a728a74cf8d336831c5c7ede88d4216a6b9ee26183
 SHA512:
-  metadata.gz: 2ac7da23d1fc020f8450a374299c4fb9dc079532b122c9ceb5f4a193a3a16895888ee273f72d69c60b2cbbb022da84a8d91006cef15c4216f43309a1a982eaf1
-  data.tar.gz: 400bf68c4cc3a00452b6bf67aa75f407378fa8670a89c272377ea213f53bd059f5df69aeae7f36c539beb594cd8506f3709fcd82a3669573e0526de0f68dd469
+  metadata.gz: e7b9cf889a34e7ef54f69d07175bead407b641972c0d03a7b32394758532a6944940302cafa07e29c810674935293b94a5ff2a84841bfe755f4c26720887f43d
+  data.tar.gz: cc69bb1784ad3eaa8e7a21b187dea155aabff4bea75f0611d59bf4d013a58b832a020bf15ea9ca9e8d7710cc2ddc256e87edb09410f6b2e4b7ba0456d6408fee

data/init.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'redmine'
 require 'redmine_plugins_helper/version'

data/lib/redmine_plugins_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sass-rails'
 
 module RedminePluginsHelper

data/lib/redmine_plugins_helper/fix_migrations.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RedminePluginsHelper
   class FixMigrations
     def initialize
@@ -17,6 +19,7 @@ module RedminePluginsHelper
     def check_database_version(dbv)
       lv = local_version(dbv[:timestamp])
       return unless lv && lv.count == 1 && dbv[:plugin] != lv.first[:plugin]
+
       fix_plugin_version(dbv, lv.first[:plugin])
     end
 
@@ -41,18 +44,19 @@ module RedminePluginsHelper
     def move_plugin_version(source_version, target_version)
       Rails.logger.info("Moving #{source_version} to plugin \"#{target_version}\"")
       ::ActiveRecord::SchemaMigration.find_by(version: source_version)
-        .update!(version: target_version)
+                                     .update!(version: target_version)
     end
 
     def local_version(timestamp)
       return [] unless local_versions.key?(timestamp)
+
       local_versions[timestamp]
     end
 
     def local_versions
       @local_versions = begin
         r = {}
-        Redmine::Plugin.registered_plugins.values.each do |p|
+        Redmine::Plugin.registered_plugins.each_value do |p|
           p.migrations.each do |m|
             r[m] ||= []
             r[m] << { plugin: p.id, timestamp: m, version: plugin_version(p.id, m) }
@@ -68,15 +72,16 @@ module RedminePluginsHelper
         ::RedminePluginsHelper::Migrations.db_all_versions.each do |v|
           pv = parse_plugin_version(v)
           next unless pv
+
           r << pv
         end
         r
       end
     end
 
-    def parse_plugin_version(v)
-      h = ::RedminePluginsHelper::Migrations.parse_plugin_version(v)
-      h[:version] = v if h.is_a?(Hash)
+    def parse_plugin_version(version)
+      h = ::RedminePluginsHelper::Migrations.parse_plugin_version(version)
+      h[:version] = version if h.is_a?(Hash)
       h
     end
 

data/lib/redmine_plugins_helper/migrate.rb

@@ -30,10 +30,10 @@ module RedminePluginsHelper
       ::Redmine::Plugin.migrate(plugin_name, migration_version)
     end
 
-    def migrate_plugin_version(v)
-      return if migrated?(v)
+    def migrate_plugin_version(version)
+      return if migrated?(version)
 
-      ::Redmine::Plugin.registered_plugins[v[:plugin]].migrate(v[:timestamp])
+      ::Redmine::Plugin.registered_plugins[version[:plugin]].migrate(version[:timestamp])
     end
 
     def versions_sorted
@@ -48,9 +48,10 @@ module RedminePluginsHelper
       r
     end
 
-    def migrated?(v)
-      return false unless db_versions.key?(v[:plugin])
-      db_versions[v[:plugin]].include?(v[:timestamp])
+    def migrated?(version)
+      return false unless db_versions.key?(version[:plugin])
+
+      db_versions[version[:plugin]].include?(version[:timestamp])
     end
 
     def db_versions

data/lib/redmine_plugins_helper/migrations.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module RedminePluginsHelper
   class Migrations
     class << self
       def local_versions
         r = {}
-        Redmine::Plugin.registered_plugins.values.each do |p|
+        Redmine::Plugin.registered_plugins.each_value do |p|
           p.migrations.each do |ts|
             r[p.id] ||= []
             r[p.id] << ts
@@ -17,6 +19,7 @@ module RedminePluginsHelper
         db_all_versions.each do |v|
           pv = parse_plugin_version(v)
           next unless pv
+
           r[pv[:plugin]] ||= []
           r[pv[:plugin]] << pv[:timestamp]
         end
@@ -28,9 +31,10 @@ module RedminePluginsHelper
         ::ActiveRecord::SchemaMigration.all.pluck(:version)
       end
 
-      def parse_plugin_version(v)
-        m = v.match(/^(\d+)\-(\S+)$/)
+      def parse_plugin_version(version)
+        m = version.match(/^(\d+)\-(\S+)$/)
         return nil unless m
+
         { plugin: m[2].to_sym, timestamp: m[1].to_i }
       end
     end

data/lib/redmine_plugins_helper/patches/redmine/plugin_migration_context.rb

@@ -8,7 +8,7 @@ module RedminePluginsHelper
       module PluginMigrationContextPatch
         extend ActiveSupport::Concern
 
-        def get_all_versions
+        def get_all_versions # rubocop:disable Naming/AccessorMethodName
           plugin.present? ? plugin.migrations : super
         end
 

data/lib/redmine_plugins_helper/patches/redmine/plugin_patch.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require 'eac_ruby_utils/core_ext'
+
 module RedminePluginsHelper
   module Patches
     module Redmine
@@ -12,6 +16,22 @@ module RedminePluginsHelper
         ASSETS_SUBDIRS = %w[stylesheets javascripts images].freeze
 
         module ClassMethods
+          def by_path(path)
+            plugin_id_from_path(path).if_present do |v|
+              registered_plugins[v]
+            end
+          end
+
+          def plugin_id_from_path(path)
+            path = path.to_pathname.expand_path
+            return nil unless path.to_path.start_with?(::Rails.root.to_path)
+
+            parts = path.relative_path_from(::Rails.root).each_filename.to_a
+            return nil unless parts.first == 'plugins' && parts.count >= 2
+
+            parts[1].to_sym
+          end
+
           def post_register(plugin_name, &block)
             plugin = registered_plugins[plugin_name]
             raise "Plugin not registered: #{plugin_name}" unless plugin
@@ -22,7 +42,7 @@ module RedminePluginsHelper
 
         module InstanceMethods
           def load_initializers
-            Dir["#{initializers_directory}/*.rb"].each { |f| require f }
+            Dir["#{initializers_directory}/*.rb"].sort.each { |f| require f }
           end
 
           ASSETS_SUBDIRS.each do |assert_subdir|

data/lib/redmine_plugins_helper/patches/test_case_patch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support'
 
 module RedminePluginsHelper
@@ -6,37 +8,15 @@ module RedminePluginsHelper
       extend ActiveSupport::Concern
 
       included do
-        extend ClassMethods
+        extend ::RedminePluginsHelper::TestHelper
         include InstanceMethods
-        setup { mailer_setup }
-        teardown { mailer_teadown }
-      end
-
-      module ClassMethods
-        def plugin_fixtures(plugin_name, *files)
-          fixtures_dir = File.expand_path(
-            'test/fixtures',
-            ::Redmine::Plugin.registered_plugins[plugin_name].directory
-          )
-          ActiveRecord::FixtureSet.create_fixtures(fixtures_dir, files)
-          fixtures(*files)
-        end
+        setup { the_test_config.before_each }
+        teardown { the_test_config.after_each }
       end
 
       module InstanceMethods
-        def mailer_setup
-          unless @mailer_perform_deliveries_changed
-            @mailer_perform_deliveries_changed = true
-            @mailer_perform_deliveries_was_enabled = ::ActionMailer::Base.perform_deliveries
-          end
-          ::ActionMailer::Base.perform_deliveries = false
-        end
-
-        def mailer_teadown
-          return unless @mailer_perform_deliveries_changed
-
-          ::ActionMailer::Base.perform_deliveries = @mailer_perform_deliveries_was_enabled
-          @mailer_perform_deliveries_changed = false
+        def the_test_config
+          @the_test_config ||= ::RedminePluginsHelper::TestConfig.new
         end
       end
     end
@@ -46,5 +26,5 @@ end
 unless ActiveSupport::TestCase.included_modules.include?(
   RedminePluginsHelper::Patches::TestCasePatch
 )
-  ActiveSupport::TestCase.send(:include, RedminePluginsHelper::Patches::TestCasePatch)
+  ActiveSupport::TestCase.include RedminePluginsHelper::Patches::TestCasePatch
 end

data/lib/redmine_plugins_helper/plugin_rake_task.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'eac_ruby_utils/core_ext'
+require 'rspec/core/rake_task'
+require 'shellwords'
+
+module RedminePluginsHelper
+  class PluginRakeTask
+    DEFAULT_TASK_NAME_LAST_PART = 'rspec'
+
+    class << self
+      def register(plugin_id, task_name_last_part = DEFAULT_TASK_NAME_LAST_PART)
+        new(plugin_id, task_name_last_part).register
+      end
+    end
+
+    common_constructor :plugin_id, :task_name_last_part
+
+    def register
+      ::RSpec::Core::RakeTask.new(task_full_name) do |t|
+        t.rspec_opts = ::Shellwords.join(rspec_opts)
+      end
+      Rake::Task[task_full_name].enhance ['db:test:prepare']
+    end
+
+    def task_full_name
+      "#{plugin_id}:#{task_name_last_part}"
+    end
+
+    def rspec_opts
+      ['--pattern', "plugins/#{plugin_id}/spec/**/*_spec.rb",
+       '--default-path', 'plugins/redmine_plugins_helper/spec',
+       '--require', 'spec_helper']
+    end
+  end
+end

data/lib/redmine_plugins_helper/settings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'redmine_plugins_helper'
 
 module RedminePluginsHelper
@@ -5,6 +7,7 @@ module RedminePluginsHelper
     class << self
       def default(plugin, default)
         return unless ::RedminePluginsHelper.settings_table_exist?
+
         p = plugin_current_setting_value(plugin)
         default.each do |k, v|
           p[k.to_s] = v unless p.key?(k)

data/lib/redmine_plugins_helper/status_migrations.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RedminePluginsHelper
   class StatusMigrations
     def initialize
@@ -10,7 +12,7 @@ module RedminePluginsHelper
       local_versions.each do |plugin, timestamps|
         timestamps.each do |timestamp|
           m = migrated_version?(plugin, timestamp) ? 'up' : 'down'
-          puts "#{m}\t#{plugin}\t#{timestamp}"
+          puts "#{m}\t#{plugin}\t#{timestamp}" # rubocop:disable Rails/Output
         end
       end
     end

data/lib/redmine_plugins_helper/test_config.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module RedminePluginsHelper
+  class TestConfig
+    def before_each
+      mailer_setup
+    end
+
+    def after_each
+      mailer_teadown
+    end
+
+    def mailer_setup
+      unless @mailer_perform_deliveries_changed
+        @mailer_perform_deliveries_changed = true
+        @mailer_perform_deliveries_was_enabled = ::ActionMailer::Base.perform_deliveries
+      end
+      ::ActionMailer::Base.perform_deliveries = false
+    end
+
+    def mailer_teadown
+      return unless @mailer_perform_deliveries_changed
+
+      ::ActionMailer::Base.perform_deliveries = @mailer_perform_deliveries_was_enabled
+      @mailer_perform_deliveries_changed = false
+    end
+  end
+end

data/lib/redmine_plugins_helper/test_helper.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module RedminePluginsHelper
+  module TestHelper
+    def plugin_fixtures(plugin_name, *files)
+      fixtures_dir = File.expand_path(
+        'test/fixtures',
+        ::Redmine::Plugin.registered_plugins[plugin_name].directory
+      )
+      ActiveRecord::FixtureSet.create_fixtures(fixtures_dir, files)
+      fixtures(*files)
+    end
+  end
+end

data/lib/redmine_plugins_helper/version.rb

@@ -3,5 +3,5 @@
 module RedminePluginsHelper
   AUTHOR = 'Eduardo Henrique Bogoni'
   SUMMARY = 'Helper for Redmine plugins'
-  VERSION = '0.6.4'
+  VERSION = '0.9.0'
 end

data/lib/tasks/redmine.rake

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+Rake::Task['redmine:plugins:migrate'].clear
+
+namespace :redmine do
+  desc 'Run migrations of core Redmine and installed plugins.'
+  task migrate: ['db:migrate', 'redmine:plugins:migrate:fix', 'redmine:plugins:migrate'] do
+  end
+
+  namespace :version do
+    desc 'Shows Redmine\'s version.'
+    task show: :environment do
+      puts ::Redmine::VERSION::STRING
+    end
+  end
+
+  task version: 'version:show'
+
+  namespace :plugins do
+    desc 'Migrates installed plugins.'
+    task migrate: :environment do
+      name = ENV['NAME']
+      version = nil
+      version_string = ENV['VERSION']
+      if version_string
+        if version_string =~ /^\d+$/
+          version = version_string.to_i
+          abort 'The VERSION argument requires a plugin NAME.' if name.nil?
+        else
+          abort "Invalid VERSION #{version_string} given."
+        end
+      end
+
+      begin
+        RedminePluginsHelper::Migrate.new(name, version)
+        Rake::Task['db:schema:dump'].invoke
+      rescue Redmine::PluginNotFound
+        abort "Plugin #{name} was not found."
+      end
+    end
+
+    namespace :migrate do
+      desc 'Fix migrations moved from a plugin to another'
+      task fix: :environment do
+        RedminePluginsHelper::FixMigrations.new
+      end
+
+      desc 'Show migrations status of all plugins'
+      task status: :environment do
+        RedminePluginsHelper::StatusMigrations.new
+      end
+    end
+  end
+end

data/lib/tasks/redmine_plugins_helper.rake

@@ -1,52 +1,4 @@
-Rake::Task['redmine:plugins:migrate'].clear
+# frozen_string_literal: true
 
-namespace :redmine do
-  desc 'Run migrations of core Redmine and installed plugins.'
-  task migrate: ['db:migrate', 'redmine:plugins:migrate:fix', 'redmine:plugins:migrate'] do
-  end
-
-  namespace :version do
-    desc 'Shows Redmine\'s version.'
-    task show: :environment do
-      puts ::Redmine::VERSION::STRING
-    end
-  end
-
-  task version: 'version:show'
-
-  namespace :plugins do
-    desc 'Migrates installed plugins.'
-    task migrate: :environment do
-      name = ENV['NAME']
-      version = nil
-      version_string = ENV['VERSION']
-      if version_string
-        if version_string =~ /^\d+$/
-          version = version_string.to_i
-          abort 'The VERSION argument requires a plugin NAME.' if name.nil?
-        else
-          abort "Invalid VERSION #{version_string} given."
-        end
-      end
-
-      begin
-        RedminePluginsHelper::Migrate.new(name, version)
-        Rake::Task['db:schema:dump'].invoke
-      rescue Redmine::PluginNotFound
-        abort "Plugin #{name} was not found."
-      end
-    end
-
-    namespace :migrate do
-      desc 'Fix migrations moved from a plugin to another'
-      task fix: :environment do
-        RedminePluginsHelper::FixMigrations.new
-      end
-
-      desc 'Show migrations status of all plugins'
-      task status: :environment do
-        RedminePluginsHelper::StatusMigrations.new
-      end
-    end
-  end
-end
+require 'redmine_plugins_helper/plugin_rake_task'
+::RedminePluginsHelper::PluginRakeTask.register(:redmine_plugins_helper, :test)

metadata

@@ -1,15 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: redmine_plugins_helper
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.9.0
 platform: ruby
 authors:
-- 0.6.4
+- 0.9.0
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-01 00:00:00.000000000 Z
+date: 2020-11-19 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: eac_ruby_utils
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.43'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.43'
+- !ruby/object:Gem::Dependency
+  name: launchy
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sass-rails
   requirement: !ruby/object:Gem::Requirement
@@ -24,6 +66,26 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: eac_ruby_gem_support
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.2
 description: 
 email: 
 executables: []
@@ -43,9 +105,13 @@ files:
 - lib/redmine_plugins_helper/patches/redmine/plugin_migration_context.rb
 - lib/redmine_plugins_helper/patches/redmine/plugin_patch.rb
 - lib/redmine_plugins_helper/patches/test_case_patch.rb
+- lib/redmine_plugins_helper/plugin_rake_task.rb
 - lib/redmine_plugins_helper/settings.rb
 - lib/redmine_plugins_helper/status_migrations.rb
+- lib/redmine_plugins_helper/test_config.rb
+- lib/redmine_plugins_helper/test_helper.rb
 - lib/redmine_plugins_helper/version.rb
+- lib/tasks/redmine.rake
 - lib/tasks/redmine_plugins_helper.rake
 homepage: 
 licenses: []