redmine_plugins_helper 0.10.0 → 0.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 747dc2f64ca0a3fdcbec5d50be57450f63a7c725654ee6dabee7e856c39ebac3
-  data.tar.gz: c7a1f9c07f653fec428625f5ab0486a313751b8940a322c98a6e14d34bcbafd8
+  metadata.gz: 0f7d3b510c4a42d1c78bf2d850648ee579a8a3c24adff6a8ba6ba84b91bce6be
+  data.tar.gz: bf26964cb5d67e16accf2631477d1f89373c79781d23bff661a85762d3f99a50
 SHA512:
-  metadata.gz: 8dde27c9f58ac5cdf5cc87c231b374f9d68896ea9a85c3fdf370c73ccfbd37b3deaf8e0575622c941b10f3c6d32372c632329b1e0d784d8bdc82ec639edce174
-  data.tar.gz: 74ce1473a20c49d9910de3496a6eb07a92c5a9f26f0c4d6da6d4c9ada1fb511040079473898ea519b4a8574b946ace508c0dd49fa02c7d3af74df3a08b8f031a
+  metadata.gz: cf2e3febe40f0d8246a905e0a1583d8cf68354309aa949dde4d6fdeced11a5b96dbdd65a85c9ede5ed1d9b381061f53455a2d4e116c91867fffa8528796311f7
+  data.tar.gz: c153f16bb325b0ab9356d110662727ab4e8f84e8d919b6acd4f53cf74d097ec3d7b57e12e159583dbe05681e42f1370f52a7605984d2cd694aafc9df5d84dec7

data/config/initializers/ruby_2_7_rails_4_column_dumper.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+# Reference: https://stackoverflow.com/questions/62570662/rails-4-ruby-2-7-1-schema-rb-shows-could-not-dump-table-because-of-following-f
+
+return unless RUBY_VERSION >= '2.7' && ::Rails.version < '5'
+
+module ActiveRecord
+  module ConnectionAdapters
+    module ColumnDumper
+      def prepare_column_options(column, types) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+        spec = {}
+        spec[:name]      = column.name.inspect
+        spec[:type]      = column.type.to_s
+        spec[:null]      = 'false' unless column.null
+
+        limit = column.limit || types[column.type][:limit]
+        spec[:limit]     = limit.inspect if limit
+        spec[:precision] = column.precision.inspect if column.precision
+        spec[:scale]     = column.scale.inspect if column.scale
+
+        default = schema_default(column).dup if column.has_default?
+        spec[:default] = default unless default.nil?
+
+        spec
+      end
+    end
+  end
+end

data/lib/enumerator.rb

@@ -0,0 +1,2 @@
+# frozen_string_literal: true
+# Required by "sass/utils", it fails if RUBY_VERSION == 2.7.6.

data/lib/redmine_plugins_helper/available.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RedminePluginsHelper
   module Available
     class << self
@@ -9,12 +11,18 @@ module RedminePluginsHelper
         true
       end
 
-      def model?(model_class)
-        table?(model_class.table_name)
+      def database_schema?
+        database? && ::RedminePluginsHelper::Migration.from_code.all?(&:applied?)
+      end
+
+      def model?(*model_classes)
+        table?(*model_classes.map(&:table_name))
       end
 
-      def table?(table_name)
-        database? && ::ActiveRecord::Base.connection.table_exists?(table_name)
+      def table?(*table_names)
+        return false unless database?
+
+        table_names.all? { |table_name| ::ActiveRecord::Base.connection.table_exists?(table_name) }
       end
 
       def settings?

data/lib/redmine_plugins_helper/fix_migrations.rb

@@ -2,13 +2,7 @@
 
 module RedminePluginsHelper
   class FixMigrations
-    def initialize
-      run
-    end
-
-    private
-
-    def run
+    def perform
       database_plugins_versions.each do |dbv|
         check_database_version(dbv)
       end
@@ -16,6 +10,8 @@ module RedminePluginsHelper
       Rails.logger.info("Local versions found: #{local_versions.count}")
     end
 
+    private
+
     def check_database_version(dbv)
       lv = local_version(dbv[:timestamp])
       return unless lv && lv.count == 1 && dbv[:plugin] != lv.first[:plugin]
@@ -43,8 +39,8 @@ module RedminePluginsHelper
 
     def move_plugin_version(source_version, target_version)
       Rails.logger.info("Moving #{source_version} to plugin \"#{target_version}\"")
-      ::ActiveRecord::SchemaMigration.find_by(version: source_version)
-                                     .update!(version: target_version)
+      ::ActiveRecord::SchemaMigration.where(version: source_version)
+                                     .update_all(version: target_version) # rubocop:disable Rails/SkipsModelValidations
     end
 
     def local_version(timestamp)
@@ -54,7 +50,7 @@ module RedminePluginsHelper
     end
 
     def local_versions
-      @local_versions = begin
+      @local_versions ||= begin
         r = {}
         Redmine::Plugin.registered_plugins.each_value do |p|
           p.migrations.each do |m|
@@ -67,24 +63,12 @@ module RedminePluginsHelper
     end
 
     def database_plugins_versions
-      @database_plugins_versions = begin
-        r = []
-        ::RedminePluginsHelper::Migrations.db_all_versions.each do |v|
-          pv = parse_plugin_version(v)
-          next unless pv
-
-          r << pv
-        end
-        r
+      @database_plugins_versions ||= ::RedminePluginsHelper::Migration
+                                     .from_database.select(&:plugin?).map do |m|
+        { plugin: m.plugin_id, timestamp: m.version, version: m.database_version }
       end
     end
 
-    def parse_plugin_version(version)
-      h = ::RedminePluginsHelper::Migrations.parse_plugin_version(version)
-      h[:version] = version if h.is_a?(Hash)
-      h
-    end
-
     def plugin_version(plugin_id, timestamp)
       "#{timestamp}-#{plugin_id}"
     end

data/lib/redmine_plugins_helper/migration/code.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module RedminePluginsHelper
+  class Migration
+    module Code
+      common_concern
+
+      module ClassMethods
+        # @return [Enumerable<RedminePluginsHelper::Migration>]
+        def from_code
+          from_core_code + from_plugins_code
+        end
+
+        # @return [Enumerable<RedminePluginsHelper::Migration>]
+        def from_core_code
+          ::Rails.application.paths['db/migrate'].flat_map do |path|
+            from_path_code(path)
+          end
+        end
+
+        # @return [Enumerable<RedminePluginsHelper::Migration>]
+        def from_path_code(path)
+          ::Dir["#{path}/*.rb"].map { |p| File.basename(p).match(/0*(\d+)\_/)[1].to_i }.sort
+                               .map { |version| new(PLUGIN_ID_CORE_VALUE, version) }
+        end
+
+        # @return [Enumerable<RedminePluginsHelper::Migration>]
+        def from_plugins_code
+          ::Redmine::Plugin.registered_plugins.values.flat_map do |plugin|
+            plugin.migrations.map { |version| new(plugin.id, version) }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/redmine_plugins_helper/migration/database.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module RedminePluginsHelper
+  class Migration
+    module Database
+      common_concern
+
+      DATABASE_CORE_VERSION_PARSER = /^(\d+)$/.to_parser { |m| [PLUGIN_ID_CORE_VALUE, m[1]] }
+      DATABASE_PLUGIN_VERSION_PARSER = /^(\d+)\-(\S+)$/.to_parser { |m| [m[2], m[1]] }
+      DATABASE_VERSION_PARSERS = [DATABASE_PLUGIN_VERSION_PARSER, DATABASE_CORE_VERSION_PARSER]
+                                 .freeze
+
+      module ClassMethods
+        # @return [Enumerable<RedminePluginsHelper::Migration>]
+        def from_database
+          ::ActiveRecord::SchemaMigration.create_table
+          ::ActiveRecord::SchemaMigration.all.pluck(:version).map do |version|
+            from_database_version(version)
+          end
+        end
+
+        # @return [RedminePluginsHelper::Migration]
+        def from_database_version(version)
+          DATABASE_VERSION_PARSERS
+            .lazy
+            .map { |parser| parser.parse(version).if_present { |args| new(*args) } }
+            .find(&:present?) || raise("None parser parsed \"#{version}\"")
+        end
+      end
+    end
+  end
+end

data/lib/redmine_plugins_helper/migration.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RedminePluginsHelper
+  class Migration
+    require_sub __FILE__, include_modules: true
+
+    PLUGIN_ID_CORE_VALUE = :_core_
+
+    common_constructor :plugin_id, :version do
+      self.plugin_id = plugin_id.to_sym
+      self.version = version.to_i
+    end
+
+    # @return [Boolean]
+    def applied?
+      ::ActiveRecord::SchemaMigration.create_table
+      ::ActiveRecord::SchemaMigration.where(version: database_version).any?
+    end
+
+    # @return [String]
+    def database_version
+      core? ? version.to_s : "#{version}-#{plugin_id}"
+    end
+
+    # @return [Boolean]
+    def core?
+      plugin_id == PLUGIN_ID_CORE_VALUE
+    end
+
+    # @return [Boolean]
+    def plugin?
+      !core?
+    end
+  end
+end

data/lib/redmine_plugins_helper/migrations.rb

@@ -5,38 +5,21 @@ module RedminePluginsHelper
     class << self
       def local_versions
         r = {}
-        Redmine::Plugin.registered_plugins.each_value do |p|
-          p.migrations.each do |ts|
-            r[p.id] ||= []
-            r[p.id] << ts
-          end
+        ::RedminePluginsHelper::Migration.from_code.select(&:plugin?).each do |migration|
+          r[migration.plugin_id] ||= []
+          r[migration.plugin_id] << migration.version
         end
         r
       end
 
       def db_versions
         r = {}
-        db_all_versions.each do |v|
-          pv = parse_plugin_version(v)
-          next unless pv
-
-          r[pv[:plugin]] ||= []
-          r[pv[:plugin]] << pv[:timestamp]
+        ::RedminePluginsHelper::Migration.from_database.select(&:plugin?).each do |migration|
+          r[migration.plugin_id] ||= []
+          r[migration.plugin_id] << migration.version
         end
         r
       end
-
-      def db_all_versions
-        ::ActiveRecord::SchemaMigration.create_table
-        ::ActiveRecord::SchemaMigration.all.pluck(:version)
-      end
-
-      def parse_plugin_version(version)
-        m = version.match(/^(\d+)\-(\S+)$/)
-        return nil unless m
-
-        { plugin: m[2].to_sym, timestamp: m[1].to_i }
-      end
     end
   end
 end

data/lib/redmine_plugins_helper/version.rb

@@ -3,5 +3,5 @@
 module RedminePluginsHelper
   AUTHOR = 'Eduardo Henrique Bogoni'
   SUMMARY = 'Helper for Redmine plugins'
-  VERSION = '0.10.0'
+  VERSION = '0.12.1'
 end

data/lib/tasks/redmine.rake

@@ -42,7 +42,7 @@ namespace :redmine do
     namespace :migrate do
       desc 'Fix migrations moved from a plugin to another'
       task fix: :environment do
-        RedminePluginsHelper::FixMigrations.new
+        ::RedminePluginsHelper::FixMigrations.new.perform
       end
 
       desc 'Show migrations status of all plugins'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redmine_plugins_helper
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.12.1
 platform: ruby
 authors:
-- 0.10.0
+- 0.12.1
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-06 00:00:00.000000000 Z
+date: 2022-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -110,12 +110,17 @@ files:
 - app/assets/stylesheets/plugins_autoload.scss.erb
 - config/initializers/assets.rb
 - config/initializers/backport_pg_10_support_to_rails_4.rb
+- config/initializers/ruby_2_7_rails_4_column_dumper.rb
 - init.rb
+- lib/enumerator.rb
 - lib/redmine_plugins_helper.rb
 - lib/redmine_plugins_helper/available.rb
 - lib/redmine_plugins_helper/fix_migrations.rb
 - lib/redmine_plugins_helper/hooks/add_assets.rb
 - lib/redmine_plugins_helper/migrate.rb
+- lib/redmine_plugins_helper/migration.rb
+- lib/redmine_plugins_helper/migration/code.rb
+- lib/redmine_plugins_helper/migration/database.rb
 - lib/redmine_plugins_helper/migrations.rb
 - lib/redmine_plugins_helper/patches/redmine/plugin_migration_context.rb
 - lib/redmine_plugins_helper/patches/redmine/plugin_patch.rb