redmine_plugin_kit 1.0.8 → 1.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b950fef55b36b8c083f86f9763d9528a259c42b85da7f238ac94ba9dd85ca40
-  data.tar.gz: b425a3447f2b07ded747e329d6b482010e8404a36d9842f3415aa06c5232b959
+  metadata.gz: 94857a34d940b2fccba2f613e3299cef59acc88c20c3279671831fd923c3e28e
+  data.tar.gz: 4d6e9c22ea18b5050b9084fe60b577a4cb3da032801a13a0b16f6ec99664a443
 SHA512:
-  metadata.gz: 516210aeab2395b927086b354b913eeca88e7aed1de3f7674aad6d6efb0bcd602897eefd28f108c00d13519f9cb27df51167638937516ec3d9793577ad52d3c9
-  data.tar.gz: 4579bbdaed1f2dec0bce766f18bd3344398f303c5417b8944312945a63894a750cad7f4fce3d41bb2ebd5082e06ccc5f3aa4f6ae26ff8e56d042b27cce205f0d
+  metadata.gz: 90fe0d769fa01295f8dea757cff3aa5f9dc48005c8ee4ea356b6cdece1da7e0330f11020359cee3f9cb53c587eaa95281c7b7d1493d4a95be8cad1e7dbe26ad9
+  data.tar.gz: f3d7a85ab307ffe4425229878f41581e03a04a833e34f626e8336ae52005e6f2a04be166517d6fcdb6b32489ceda1d08ba2d58ebef77f3265547c71a9ebf605f

data/lib/redmine_plugin_kit/loader.rb

@@ -89,11 +89,34 @@ module RedminePluginKit
 
       files.reverse! if reverse
       files.each do |f|
-        Rails.autoloaders.main.ignore << f if Rails.version > '6.0' && ignore_autoload
+        if Rails.version > '6.0' && ignore_autoload
+          Rails.autoloaders.main.ignore << f
+          # Such a file registers itself in a registry that lives on a module
+          # Zeitwerk rebuilds on every reload (Redmine::FieldFormat). The
+          # registration is lost with the old module, and require would be a
+          # no-op the second time round - the custom field then falls back to a
+          # plain text field showing the raw id. Reloading the file restores it.
+          #
+          # NOTE: the require below stays as it is, so booting behaves exactly as
+          # before and does not depend on when to_prepare runs. Loading the file
+          # again in the first prepare run is harmless: these files only define a
+          # class and register it under a fixed name.
+          reload_on_prepare f
+        end
+
         require f
       end
     end
 
+    # Load the file again after every code reload.
+    #
+    # The block keeps the order of the surrounding loop, which matters because
+    # formats may inherit from each other (CompanyFormat < ContactFormat) - a
+    # subclass loaded before its parent raises NameError.
+    def reload_on_prepare(file)
+      ActiveSupport::Reloader.to_prepare { load file }
+    end
+
     def incompatible?(plugins = [])
       plugins.each do |plugin|
         raise "\n\033[31m#{plugin_id} plugin cannot be used with #{plugin} plugin.\033[0m" if Redmine::Plugin.installed? plugin

data/lib/redmine_plugin_kit/plugin_base.rb

@@ -38,6 +38,19 @@ module RedminePluginKit
 
       private
 
+      # Enforce a plugin's REQUIRED_ALPHANODES_PLUGINS (an array of plugin ids it
+      # hard-depends on). Called from setup! which runs via the
+      # after_plugins_loaded hook, i.e. AFTER every plugin is registered - so the
+      # alphabetical plugin load order is irrelevant here.
+      #
+      # This is why AlphaNodes plugins declare dependencies on other redmine_*
+      # plugins via REQUIRED_ALPHANODES_PLUGINS instead of requires_redmine_plugin:
+      # requires_redmine_plugin runs while init.rb is loaded (during alphabetical
+      # registration) and therefore only works for dependencies that load earlier,
+      # such as additionals / additional_tags. A dependency that loads later (e.g.
+      # redmine_automation depending on redmine_reporting) would raise
+      # PluginNotFound even though it is installed. To see a plugin's hard
+      # AlphaNodes dependencies, look at its REQUIRED_ALPHANODES_PLUGINS constant.
       # rubocop: disable Style/RaiseArgs
       def setup_required_plugins
         return unless defined? self::REQUIRED_ALPHANODES_PLUGINS

data/lib/redmine_plugin_kit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RedminePluginKit
-  VERSION = '1.0.8'
+  VERSION = '1.0.9'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redmine_plugin_kit
 version: !ruby/object:Gem::Version
-  version: 1.0.8
+  version: 1.0.9
 platform: ruby
 authors:
 - AlphaNodes