redmine_github_hook 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c30863fa492b92934b5a26ac38859b3c914a7521
-  data.tar.gz: 9f87ea3e8368290abcc8ffe8d6a0e2620189292e
+  metadata.gz: 80d3b1fb7dfd0ba831f64fa058e41c143c2a3d85
+  data.tar.gz: c1437776bd70f444d30d5c26c4928aa3fef21908
 SHA512:
-  metadata.gz: aeb53b9b14fcf449a6d27fc3e7b6f747b0b735605a35f67321687f5f7acdf699dff8e6fb29f39740225a50bd6f21c7ef6bc8ea869c06d2f404547107ea4fe8a0
-  data.tar.gz: ae96c35e10d754a00acbd373ec0e89eb3875b1c7764b0c25a7f9602b39d92d24e59bbd3ddf66a002615ec945406e856522d1ca652edec8fba8dbc539df32da78
+  metadata.gz: d44d1a781d5a714324fe7ec938d8df9f6607783efe6004ebb418a13cad9d56cd1df6f178ad342f276c01bdab51cd8e9928654447d298f657e90780b8f21daf9b
+  data.tar.gz: 81d3e3cf4e3aaa09e0837196158d4aa32aec72e620b65b5bf6f909b8aad3a6314631e15d4eff42c927ab564f80b34a8107576e299da1f31a17ba1107f9b46fd9

data/Gemfile

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in redmine_github_hook.gemspec
-gemspec
+# Use the gems defined in the plugins gemspec
+gemspec(:path => File.dirname(__FILE__))

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2010 Jakob Skjerning
+Copyright (c) 2014 Jakob Skjerning
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -11,24 +11,46 @@ If your shared repository is on a remote machine - for example on GitHub - this
 That approach works perfectly fine, but is a bit heavy-handed and cumbersome. The Redmine GitHub Hook plugin allows GitHub to notify your Redmine installation when changes have been pushed to a repository, triggering an update of your local repository and Redmine data only when it is actually necessary.
 
 
-## Installation
+## Getting started
 
-1. Installing the plugin
-   1. Install the [json gem](http://json.rubyforge.org/) on the machine where Redmine is running.
-   2. Follow the plugin installation procedure outlined in the [Redmine wiki](http://www.redmine.org/wiki/redmine/Plugins).
-      * Make sure that Redmine GitHub Hook is installed in a directory named `redmine_github_hook`
-   3. Restart your Redmine.
-   4. If you already have a local Git repository set up and working from Redmine go to step 3, otherwise continue at step 2.
+### 1. Install the plugin
 
-2. Adding a Git repository to a project (note, this should work whether you want to use Redmine GitHub Hook or not). Simply follow the instructions for [keeping your git repository in sync](http://www.redmine.org/wiki/redmine/HowTo_keep_in_sync_your_git_repository_for_redmine).
+You have two options for installing the plugin:
 
-3. Connecting GitHub to Redmine
-   1. Go to the repository Settings interface on GitHub.
-   2. Under "Webhooks & Services" add a new "WebHook". The "Payload URL" needs to be of the format: `[redmine_url]/github_hook` (for example `http://redmine.example.com/github_hook`).
-      1. By default, GitHub Hook assumes your GitHub repository name is the same as the project identifier in your Redmine installation. If this is not the case, you can specify the actual Redmine project identifier in the Post-Receive URL by using the format `[redmine_url]/github_hook?project_id=[identifier]` (for example `http://redmine.example.com/github_hook?project_id=my_project`).
-      2. In most cases, just having the "push" event trigger the webhook should suffice, but you are free to customize the events as you desire.
+#### A: As a RubyGem
 
-That's it. GitHub will now send a HTTP POST to the Redmine GitHub Hook plugin whenever changes are pushed to GitHub. The plugin then takes care of pulling the changes to the local repository and updating the Redmine database with them.
+1. Add the gem to your Gemfile.local:
+   `gem "redmine_github_hook"`
+2. `bundle`
+3. Restart your Redmine
+
+#### B: As a plugin
+
+1. Follow the plugin installation procedure outlined in the [Redmine wiki](http://www.redmine.org/wiki/redmine/Plugins).
+  * Make sure that Redmine GitHub Hook is installed in a directory named `redmine_github_hook`
+  * Easiest way: change in your plugins directory and pull with git: `git clone git://github.com/koppen/redmine_github_hook.git`
+2. Restart your Redmine.
+
+### 2. Add the repository to Redmine
+
+Adding a Git repository to a project (note, this should work whether you want to use Redmine GitHub Hook or not).
+
+1. Simply follow the instructions for [keeping your git repository in sync](http://www.redmine.org/wiki/redmine/HowTo_keep_in_sync_your_git_repository_for_redmine).
+ * You don't need to set up a cron task as described in the Redmine instructions.
+
+### 3. Connecting GitHub to Redmine
+
+1. Go to the repository Settings interface on GitHub.
+2. Under "Webhooks & Services" add a new "WebHook". The "Payload URL" needs to be of the format: `[redmine_url]/github_hook` (for example `http://redmine.example.com/github_hook`).
+   * By default, GitHub Hook assumes your GitHub repository name is the same as the *project identifier* in your Redmine installation.
+     * If this is not the case, you can specify the actual Redmine project identifier in the Post-Receive URL by using the format `[redmine_url]/github_hook?project_id=[identifier]` (for example `http://redmine.example.com/github_hook?project_id=my_project`).
+     * GitHub Hook will then update **all repositories** in the specified project. *Be aware, that this process may take a while if you have many repositories in your project.*
+     * If you want GitHub Hook to **only update the current repository** you can specify it with an additional parameter in the Post-Receive URL by using the format `[redmine_url]/github_hook?project_id=[identifier]&repository_id=[repository]` (for example `http://redmine.example.com/github_hook?project_id=my_project&repository_id=my_repo`).
+     * If you want GitHub Hook to **only update the current repository** you can specify it with an additional parameter in the Post-Receive URL by using the format `[redmine_url]/github_hook?project_id=[identifier]&repository_id=[repository]` (for example `http://redmine.example.com/github_hook?project_id=my_project&repository_id=my_repo`).
+   * In most cases, just having the "push" event trigger the webhook should suffice, but you are free to customize the events as you desire.
+   * *Note: Make sure you're adding a Webhook - which is what Redmine Github Hook expects. GitHub has some builtin Redmine integration; that's not what you're looking for.*
+
+That's it. GitHub will now send a HTTP POST to the Redmine GitHub Hook plugin whenever changes are pushed to GitHub. The plugin then takes care of pulling the changes to the local repositories and updating the Redmine database with them.
 
 
 ## Assumptions
@@ -66,9 +88,18 @@ This means you need to add its SSH keys on GitHub. If the user doesn't already h
 The user running Redmine needs permissions to read and write to the local repository on the server.
 
 
+## What happens
+
+The interactions between the different parts of the process is outlined in the following sequence diagram:
+
+![sequence](https://cloud.githubusercontent.com/assets/6480/3311503/3a789390-f6c5-11e3-804d-d5ca2562799f.png)
+
+(Diagram made with [http://bramp.github.io/js-sequence-diagrams/](js-sequence-diagrams)).
+
+
 ## License
 
-Copyright (c) 2009-2013 Jakob Skjerning
+Copyright (c) 2009-2014 Jakob Skjerning
 
 Permission is hereby granted, free of charge, to any person
 obtaining a copy of this software and associated documentation

data/app/controllers/github_hook_controller.rb

@@ -1,21 +1,14 @@
 require 'json'
 
 class GithubHookController < ApplicationController
-
-  GIT_BIN = Redmine::Configuration['scm_git_command'] || "git"
   skip_before_filter :verify_authenticity_token, :check_if_login_required
 
   def index
     if request.post?
-      repositories = find_repositories
-
-      repositories.each do |repository|
-        # Fetch the changes from Github
-        update_repository(repository)
-
-        # Fetch the new changesets into Redmine
-        repository.fetch_changesets
-      end
+      payload = JSON.parse(params[:payload] || '{}')
+      updater = GithubHook::Updater.new(payload, params)
+      updater.logger = logger
+      updater.call
     end
 
     render(:text => 'OK')
@@ -24,94 +17,4 @@ class GithubHookController < ApplicationController
   def welcome
     # Render the default layout
   end
-
-  private
-
-  def system(command)
-    Kernel.system(command)
-  end
-
-  # Executes shell command. Returns true if the shell command exits with a
-  # success status code.
-  #
-  # If directory is given the current directory will be changed to that
-  # directory before executing command.
-  def exec(command, directory)
-    logger.debug { "GithubHook: Executing command: '#{command}'" }
-
-    # Get a path to a temp file
-    logfile = Tempfile.new('github_hook_exec')
-    logfile.close
-
-    full_command = "#{command} > #{logfile.path} 2>&1"
-    success = if directory.present?
-      Dir.chdir(directory) do
-        system(full_command)
-      end
-    else
-      system(full_command)
-    end
-
-    output_from_command = File.readlines(logfile.path)
-    if success
-      logger.debug { "GithubHook: Command output: #{output_from_command.inspect}"}
-    else
-      logger.error { "GithubHook: Command '#{command}' didn't exit properly. Full output: #{output_from_command.inspect}"}
-    end
-
-    return success
-  ensure
-    logfile.unlink
-  end
-
-  def git_command(command)
-    GIT_BIN + " #{command}"
-  end
-
-  # Fetches updates from the remote repository
-  def update_repository(repository)
-    command = git_command('fetch origin')
-    if exec(command, repository.url)
-      command = git_command("fetch origin \"+refs/heads/*:refs/heads/*\"")
-      exec(command, repository.url)
-    end
-  end
-
-  # Gets the project identifier from the querystring parameters and if that's not supplied, assume
-  # the Github repository name is the same as the project identifier.
-  def get_identifier
-    identifier = get_project_name
-    raise ActiveRecord::RecordNotFound, "Project identifier not specified" if identifier.nil?
-    return identifier
-  end
-
-  # Attempts to find the project name. It first looks in the params, then in the
-  # payload if params[:project_id] isn't given.
-  def get_project_name
-    payload = JSON.parse(params[:payload] || '{}')
-    params[:project_id] || (payload['repository'] ? payload['repository']['name'] : nil)
-  end
-
-  # Finds the Redmine project in the database based on the given project identifier
-  def find_project
-    identifier = get_identifier
-    project = Project.find_by_identifier(identifier.downcase)
-    raise ActiveRecord::RecordNotFound, "No project found with identifier '#{identifier}'" if project.nil?
-    return project
-  end
-
-  # Returns the Redmine Repository object we are trying to update
-  def find_repositories
-    project = find_project
-    repositories = project.repositories.select do |repo|
-      repo.is_a?(Repository::Git)
-    end
-
-    if repositories.nil? or repositories.length == 0
-      raise TypeError, "Project '#{project.to_s}' ('#{project.identifier}') has no repository"
-    end
-
-    return repositories
-  end
-
 end

data/app/services/github_hook/updater.rb

@@ -0,0 +1,152 @@
+module GithubHook
+  class Updater
+    GIT_BIN = Redmine::Configuration['scm_git_command'] || "git"
+
+    attr_writer :logger
+
+    def initialize(payload, params = {})
+      @payload = payload
+      @params = params
+    end
+
+    def call
+      repositories = find_repositories
+
+      repositories.each do |repository|
+        tg1 = Time.now
+        # Fetch the changes from Github
+        update_repository(repository)
+        tg2 = Time.now
+
+        tr1 = Time.now
+        # Fetch the new changesets into Redmine
+        repository.fetch_changesets
+        tr2 = Time.now
+
+        logger.info { "  GithubHook: Redmine repository updated: #{repository.identifier} (Git: #{time_diff_milli(tg1,tg2)}ms, Redmine: #{time_diff_milli(tr1,tr2)}ms)" }
+      end
+    end
+
+    private
+
+    class NullLogger
+      def debug(*_); end
+      def info(*_); end
+      def warn(*_); end
+      def error(*_); end
+    end
+
+    attr_reader :params, :payload
+
+    # Executes shell command. Returns true if the shell command exits with a
+    # success status code.
+    #
+    # If directory is given the current directory will be changed to that
+    # directory before executing command.
+    def exec(command, directory)
+      logger.debug { "  GithubHook: Executing command: '#{command}'" }
+
+      # Get a path to a temp file
+      logfile = Tempfile.new('github_hook_exec')
+      logfile.close
+
+      full_command = "#{command} > #{logfile.path} 2>&1"
+      success = if directory.present?
+        Dir.chdir(directory) do
+          system(full_command)
+        end
+      else
+        system(full_command)
+      end
+
+      output_from_command = File.readlines(logfile.path)
+      if success
+        logger.debug { "  GithubHook: Command output: #{output_from_command.inspect}"}
+      else
+        logger.error { "  GithubHook: Command '#{command}' didn't exit properly. Full output: #{output_from_command.inspect}"}
+      end
+
+      return success
+    ensure
+      logfile.unlink if logfile && logfile.respond_to?(:unlink)
+    end
+
+    # Finds the Redmine project in the database based on the given project identifier
+    def find_project
+      identifier = get_identifier
+      project = Project.find_by_identifier(identifier.downcase)
+      raise ActiveRecord::RecordNotFound, "No project found with identifier '#{identifier}'" if project.nil?
+      return project
+    end
+
+    # Returns the Redmine Repository object we are trying to update
+    def find_repositories
+      project = find_project
+      repositories = project.repositories.select do |repo|
+        repo.is_a?(Repository::Git)
+      end
+
+      if repositories.nil? or repositories.length == 0
+        raise TypeError, "Project '#{project.to_s}' ('#{project.identifier}') has no repository"
+      end
+
+      # if a specific repository id is passed in url parameter "repository_id", then try to find it in
+      # the list of current project repositories and use only this and not all to pull changes from
+      # (issue #54)
+      if params.has_key?(:repository_id)
+        param_repo = repositories.select do |repo|
+          repo.identifier == params[:repository_id]
+        end
+
+        if param_repo.nil? or param_repo.length == 0
+          logger.info { "  GithubHook: The repository '#{params[:repository_id]}' isn't in the list of projects repos. Updating all repos instead." }
+
+        else
+          repositories = param_repo
+        end
+      end
+
+      return repositories
+    end
+
+    # Gets the project identifier from the querystring parameters and if that's not supplied, assume
+    # the Github repository name is the same as the project identifier.
+    def get_identifier
+      identifier = get_project_name
+      raise ActiveRecord::RecordNotFound, "Project identifier not specified" if identifier.nil?
+      return identifier
+    end
+
+    # Attempts to find the project name. It first looks in the params, then in the
+    # payload if params[:project_id] isn't given.
+    def get_project_name
+      params[:project_id] || (payload['repository'] ? payload['repository']['name'] : nil)
+    end
+
+    def git_command(command)
+      GIT_BIN + " #{command}"
+    end
+
+    def logger
+      @logger || NullLogger.new
+    end
+
+    def system(command)
+      Kernel.system(command)
+    end
+
+    def time_diff_milli(start, finish)
+      ((finish - start) * 1000.0).round(1)
+    end
+
+    # Fetches updates from the remote repository
+    def update_repository(repository)
+      command = git_command('fetch origin')
+      if exec(command, repository.url)
+        command = git_command("fetch origin \"+refs/heads/*:refs/heads/*\"")
+        exec(command, repository.url)
+      end
+    end
+
+  end
+end

data/init.rb

@@ -4,5 +4,7 @@ Redmine::Plugin.register :redmine_github_hook do
   name 'Redmine Github Hook plugin'
   author 'Jakob Skjerning'
   description 'This plugin allows your Redmine installation to receive Github post-receive notifications'
+  url 'https://github.com/koppen/redmine_github_hook'
+  author_url 'http://mentalized.net'
   version RedmineGithubHook::VERSION
 end

data/lib/redmine_github_hook/version.rb

@@ -1,3 +1,3 @@
 module RedmineGithubHook
-  VERSION = "2.0.0"
+  VERSION = "2.1.0"
 end

data/test/functional/github_hook_controller_test.rb

@@ -68,129 +68,35 @@ class GithubHookControllerTest < ActionController::TestCase
     Project.stubs(:find_by_identifier).with('github').returns(project)
 
     # Make sure we don't run actual commands in test
-    @controller.expects(:system).never
+    GithubHook::Updater.any_instance.expects(:system).never
     Repository.expects(:fetch_changesets).never
   end
 
-  def mock_descriptor(kind, contents = [])
-    descriptor = mock(kind)
-    descriptor.expects(:readlines).returns(contents)
-    descriptor
-  end
-
-  def do_post(payload = nil)
-    payload = json if payload.nil?
-    payload = payload.to_json if payload.is_a?(Hash)
-    post :index, :payload => payload
-  end
-
-  def test_should_use_the_repository_name_as_project_identifier
-    Project.expects(:find_by_identifier).with('github').returns(project)
-    @controller.stubs(:exec).returns(true)
-    do_post
-  end
-
-  def test_should_fetch_changes_from_origin
-    Project.expects(:find_by_identifier).with('github').returns(project)
-    @controller.expects(:exec).with("git fetch origin", repository.url)
-    do_post
-  end
-
-  def test_should_reset_repository_when_fetch_origin_succeeds
-    Project.expects(:find_by_identifier).with('github').returns(project)
-    @controller.expects(:exec).with("git fetch origin", repository.url).returns(true)
-    @controller.expects(:exec).with("git fetch origin \"+refs/heads/*:refs/heads/*\"", repository.url)
-    do_post
-  end
-
-  def test_should_not_reset_repository_when_fetch_origin_fails
-    Project.expects(:find_by_identifier).with('github').returns(project)
-    @controller.expects(:exec).with("git fetch origin", repository.url).returns(false)
-    @controller.expects(:exec).with("git reset --soft refs\/remotes\/origin\/master", repository.url).never
-    do_post
-  end
-
-  def test_should_use_project_identifier_from_request
-    Project.expects(:find_by_identifier).with('redmine').returns(project)
-    @controller.stubs(:exec).returns(true)
-    post :index, :project_id => 'redmine', :payload => json
-  end
-
-  def test_should_return_404_if_project_identifier_not_found
-    assert_raises ActiveRecord::RecordNotFound do
-      post :index
-    end
-  end
-
-  def test_should_downcase_identifier
-    # Redmine project identifiers are always downcase
-    Project.expects(:find_by_identifier).with('redmine').returns(project)
-    @controller.stubs(:exec).returns(true)
-    post :index, :project_id => 'ReDmInE', :payload => json
+  def do_post
+    post :index, :payload => json
   end
 
   def test_should_render_ok_when_done
-    @controller.expects(:update_repository).returns(true)
-    do_post
-    assert_response :success
-    assert_equal 'OK', @response.body
-  end
-
-  def test_should_fetch_changesets_into_the_repository
-    @controller.expects(:update_repository).returns(true)
-    repository.expects(:fetch_changesets).returns(true)
-
+    GithubHook::Updater.any_instance.expects(:update_repository).returns(true)
     do_post
     assert_response :success
     assert_equal 'OK', @response.body
   end
 
-  def test_should_return_404_if_project_identifier_not_given
-    assert_raises ActiveRecord::RecordNotFound do
-      do_post :repository => {}
-    end
-  end
-
-  def test_should_return_404_if_project_not_found
-    assert_raises ActiveRecord::RecordNotFound do
-      Project.expects(:find_by_identifier).with('foobar').returns(nil)
-      do_post :repository => {:name => 'foobar'}
-    end
-  end
-
-  def test_should_return_500_if_project_has_no_repository
-    assert_raises TypeError do
-      project = mock('project', :to_s => 'My Project', :identifier => 'github')
-      project.expects(:repositories).returns([])
-      Project.expects(:find_by_identifier).with('github').returns(project)
-      do_post :repository => {:name => 'github'}
-    end
-  end
-
-  def test_should_return_500_if_repository_is_not_git
-    assert_raises TypeError do
-      project = mock('project', :to_s => 'My Project', :identifier => 'github')
-      repository = Repository::Subversion.new
-      project.expects(:repositories).at_least(1).returns([repository])
-      Project.expects(:find_by_identifier).with('github').returns(project)
-      do_post :repository => {:name => 'github'}
-    end
-  end
-
   def test_should_not_require_login
-    @controller.expects(:update_repository).returns(true)
+    GithubHook::Updater.any_instance.expects(:update_repository).returns(true)
     @controller.expects(:check_if_login_required).never
     do_post
   end
 
   def test_exec_should_log_output_from_git_as_debug_when_things_go_well
-    @controller.expects(:system).at_least(1).returns(true)
+    GithubHook::Updater.any_instance.expects(:system).at_least(1).returns(true)
     @controller.logger.expects(:debug).at_least(1)
     do_post
   end
 
   def test_exec_should_log_output_from_git_as_error_when_things_go_sour
-    @controller.expects(:system).at_least(1).returns(false)
+    GithubHook::Updater.any_instance.expects(:system).at_least(1).returns(false)
     @controller.logger.expects(:error).at_least(1)
     do_post
   end

data/test/unit/github_hook/updater_test.rb

@@ -0,0 +1,174 @@
+require 'test_helper'
+
+require 'test/unit'
+require 'mocha'
+
+class GithubHookUpdaterTest < Test::Unit::TestCase
+
+  def project
+    return @project if @project
+
+    @project ||= Project.new
+    @project.repositories << repository
+    @project
+  end
+
+  def repository
+    return @repository if @repository
+
+    @repository ||= Repository::Git.new(:identifier => "redmine")
+    @repository.stubs(:fetch_changesets).returns(true)
+    @repository
+  end
+
+  def payload
+    # Ruby hash with the parsed data from the JSON payload
+    {"before"=>"5aef35982fb2d34e9d9d4502f6ede1072793222d", "repository"=>{"url"=>"http://github.com/defunkt/github", "name"=>"github", "description"=>"You're lookin' at it.", "watchers"=>5, "forks"=>2, "private"=>1, "owner"=>{"email"=>"chris@ozmm.org", "name"=>"defunkt"}}, "commits"=>[{"id"=>"41a212ee83ca127e3c8cf465891ab7216a705f59", "url"=>"http://github.com/defunkt/github/commit/41a212ee83ca127e3c8cf465891ab7216a705f59", "author"=>{"email"=>"chris@ozmm.org", "name"=>"Chris Wanstrath"}, "message"=>"okay i give in", "timestamp"=>"2008-02-15T14:57:17-08:00", "added"=>["filepath.rb"]}, {"id"=>"de8251ff97ee194a289832576287d6f8ad74e3d0", "url"=>"http://github.com/defunkt/github/commit/de8251ff97ee194a289832576287d6f8ad74e3d0", "author"=>{"email"=>"chris@ozmm.org", "name"=>"Chris Wanstrath"}, "message"=>"update pricing a tad", "timestamp"=>"2008-02-15T14:36:34-08:00"}], "after"=>"de8251ff97ee194a289832576287d6f8ad74e3d0", "ref"=>"refs/heads/master"}
+  end
+
+  def build_updater(payload, options = {})
+    updater = GithubHook::Updater.new(payload, options)
+    updater.stubs(:exec).returns(true)
+    updater
+  end
+
+  def updater
+    return @memoized_updater if @memoized_updater
+    @memoized_updater = build_updater(payload)
+  end
+
+  def setup
+    Project.stubs(:find_by_identifier).with('github').returns(project)
+
+    # Make sure we don't run actual commands in test
+    GithubHook::Updater.any_instance.expects(:system).never
+    Repository.expects(:fetch_changesets).never
+  end
+
+  def teardown
+    @memoized_updater = nil
+  end
+
+  def test_uses_repository_name_as_project_identifier
+    Project.expects(:find_by_identifier).with('github').returns(project)
+    updater.call
+  end
+
+  def test_fetches_changes_from_origin
+    updater.expects(:exec).with("git fetch origin", repository.url)
+    updater.call
+  end
+
+  def test_resets_repository_when_fetch_origin_succeeds
+    updater.expects(:exec).with("git fetch origin", repository.url).returns(true)
+    updater.expects(:exec).with("git fetch origin \"+refs/heads/*:refs/heads/*\"", repository.url)
+    updater.call
+  end
+
+  def test_resets_repository_when_fetch_origin_fails
+    updater.expects(:exec).with("git fetch origin", repository.url).returns(false)
+    updater.expects(:exec).with("git reset --soft refs\/remotes\/origin\/master", repository.url).never
+    updater.call
+  end
+
+  def test_uses_project_identifier_from_request
+    Project.expects(:find_by_identifier).with('redmine').returns(project)
+    updater = build_updater(payload, {:project_id => 'redmine'})
+    updater.call
+  end
+
+  def test_updates_all_repositories_by_default
+    another_repository = Repository::Git.new
+    another_repository.expects(:fetch_changesets).returns(true)
+    project.repositories << another_repository
+
+    updater = build_updater(payload)
+    updater.expects(:exec).with("git fetch origin", repository.url)
+    updater.call
+  end
+
+  def test_updates_only_the_specified_repository
+    another_repository = Repository::Git.new
+    another_repository.expects(:fetch_changesets).never
+    project.repositories << another_repository
+
+    updater = build_updater(payload, {:repository_id => 'redmine'})
+    updater.expects(:exec).with("git fetch origin", repository.url)
+    updater.call
+  end
+
+  def test_updates_all_repositories_if_specific_repository_is_not_found
+    another_repository = Repository::Git.new
+    another_repository.expects(:fetch_changesets).returns(true)
+    project.repositories << another_repository
+
+    updater = build_updater(payload, {:repository_id => 'redmine or something'})
+    updater.expects(:exec).with("git fetch origin", repository.url)
+    updater.call
+  end
+
+  def test_raises_record_not_found_if_project_identifier_not_found
+    assert_raises ActiveRecord::RecordNotFound do
+      updater = build_updater({})
+      updater.call
+    end
+  end
+
+  def test_raises_record_not_found_if_project_identifier_not_given
+    assert_raises ActiveRecord::RecordNotFound do
+      updater = build_updater(payload.merge({"repository" => {}}))
+      updater.call
+    end
+  end
+
+  def test_raises_record_not_found_if_project_not_found
+    assert_raises ActiveRecord::RecordNotFound do
+      Project.expects(:find_by_identifier).with('foobar').returns(nil)
+      updater = build_updater(payload, {:project_id => "foobar"})
+      updater.call
+    end
+  end
+
+  def test_downcases_identifier
+    # Redmine project identifiers are always downcase
+    Project.expects(:find_by_identifier).with('redmine').returns(project)
+    updater = build_updater(payload, {:project_id => 'ReDmInE'})
+    updater.call
+  end
+
+  def test_fetches_changesets_into_the_repository
+    updater.expects(:update_repository).returns(true)
+    repository.expects(:fetch_changesets).returns(true)
+    updater.call
+  end
+
+  def test_raises_type_error_if_project_has_no_repository
+    assert_raises TypeError do
+      project = mock('project', :to_s => 'My Project', :identifier => 'github')
+      project.expects(:repositories).returns([])
+      Project.expects(:find_by_identifier).with('github').returns(project)
+      updater.call
+    end
+  end
+
+  def test_raises_type_error_if_repository_is_not_git
+    assert_raises TypeError do
+      project = mock('project', :to_s => 'My Project', :identifier => 'github')
+      repository = Repository::Subversion.new
+      project.expects(:repositories).at_least(1).returns([repository])
+      Project.expects(:find_by_identifier).with('github').returns(project)
+      updater.call
+    end
+  end
+
+  def test_logs_if_a_logger_is_given
+    updater = GithubHook::Updater.new(payload)
+    updater.stubs(:exec).returns(true)
+
+    logger = stub('Logger')
+    logger.expects(:info).at_least_once
+    updater.logger = logger
+
+    updater.call
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redmine_github_hook
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Jakob Skjerning
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-27 00:00:00.000000000 Z
+date: 2014-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,7 @@ files:
 - Rakefile
 - app/controllers/github_hook_controller.rb
 - app/helpers/git_hook_helper.rb
+- app/services/github_hook/updater.rb
 - app/views/github_hook/welcome.html.erb
 - config/routes.rb
 - init.rb
@@ -61,6 +62,7 @@ files:
 - redmine_github_hook.gemspec
 - test/functional/github_hook_controller_test.rb
 - test/test_helper.rb
+- test/unit/github_hook/updater_test.rb
 homepage: ''
 licenses:
 - MIT
@@ -89,4 +91,4 @@ summary: Allow your Redmine installation to be notified when changes have been p
 test_files:
 - test/functional/github_hook_controller_test.rb
 - test/test_helper.rb
-has_rdoc: 
+- test/unit/github_hook/updater_test.rb