redmine_extensions 0.1.14 → 0.1.15

data/spec/redmine/test/functional/sessions_controller_test.rb

@@ -0,0 +1,138 @@
+# Redmine - project management software
+# Copyright (C) 2006-2016  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.expand_path('../../test_helper', __FILE__)
+
+class SessionsControllerTest < Redmine::ControllerTest
+  include Redmine::I18n
+  tests WelcomeController
+
+  fixtures :users, :email_addresses
+
+  def setup
+    Rails.application.config.redmine_verify_sessions = true
+  end
+
+  def teardown
+    Rails.application.config.redmine_verify_sessions = false
+  end
+
+  def test_session_token_should_be_updated
+    token = Token.create!(:user_id => 2, :action => 'session', :created_on => 10.hours.ago, :updated_on => 10.hours.ago)
+    created = token.reload.created_on
+
+    get :index, :session => {:user_id => 2, :tk => token.value}
+    assert_response :success
+    token.reload
+    assert_equal created.to_i, token.created_on.to_i
+    assert_not_equal created.to_i, token.updated_on.to_i
+    assert token.updated_on > created
+  end
+
+  def test_user_session_should_not_be_reset_if_lifetime_and_timeout_disabled
+    created = 2.years.ago
+    token = Token.create!(:user_id => 2, :action => 'session', :created_on => created, :updated_on => created)
+
+    with_settings :session_lifetime => '0', :session_timeout => '0' do
+      get :index, :session => {:user_id => 2, :tk => token.value}
+      assert_response :success
+    end
+  end
+
+  def test_user_session_without_token_should_be_reset
+    get :index, :session => {:user_id => 2}
+    assert_redirected_to 'http://test.host/login?back_url=http%3A%2F%2Ftest.host%2F'
+  end
+
+  def test_expired_user_session_should_be_reset_if_lifetime_enabled
+    created = 2.days.ago
+    token = Token.create!(:user_id => 2, :action => 'session', :created_on => created, :updated_on => created)
+
+    with_settings :session_timeout => '720' do
+      get :index, :session => {:user_id => 2, :tk => token.value}
+      assert_redirected_to 'http://test.host/login?back_url=http%3A%2F%2Ftest.host%2F'
+    end
+  end
+
+  def test_valid_user_session_should_not_be_reset_if_lifetime_enabled
+    created = 3.hours.ago
+    token = Token.create!(:user_id => 2, :action => 'session', :created_on => created, :updated_on => created)
+
+    with_settings :session_timeout => '720' do
+      get :index, :session => {:user_id => 2, :tk => token.value}
+      assert_response :success
+    end
+  end
+
+  def test_expired_user_session_should_be_reset_if_timeout_enabled
+    created = 4.hours.ago
+    token = Token.create!(:user_id => 2, :action => 'session', :created_on => created, :updated_on => created)
+
+    with_settings :session_timeout => '60' do
+      get :index, :session => {:user_id => 2, :tk => token.value}
+      assert_redirected_to 'http://test.host/login?back_url=http%3A%2F%2Ftest.host%2F'
+    end
+  end
+
+  def test_valid_user_session_should_not_be_reset_if_timeout_enabled
+    created = 10.minutes.ago
+    token = Token.create!(:user_id => 2, :action => 'session', :created_on => created, :updated_on => created)
+
+    with_settings :session_timeout => '60' do
+      get :index, :session => {:user_id => 2, :tk => token.value}
+      assert_response :success
+    end
+  end
+
+  def test_expired_user_session_should_be_restarted_if_autologin
+    created = 2.hours.ago
+    token = Token.create!(:user_id => 2, :action => 'session', :created_on => created, :updated_on => created)
+
+    with_settings :session_lifetime => '720', :session_timeout => '60', :autologin => 7 do
+      autologin_token = Token.create!(:user_id => 2, :action => 'autologin', :created_on => 1.day.ago)
+      @request.cookies['autologin'] = autologin_token.value
+
+      get :index, :session => {:user_id => 2, :tk => token.value}
+      assert_equal 2, session[:user_id]
+      assert_response :success
+      assert_not_equal token.value, session[:tk]
+    end
+  end
+
+  def test_expired_user_session_should_set_locale
+    set_language_if_valid 'it'
+    user = User.find(2)
+    user.language = 'fr'
+    user.save!
+    created = 4.hours.ago
+    token = Token.create!(:user_id => 2, :action => 'session', :created_on => created, :updated_on => created)
+
+    with_settings :session_timeout => '60' do
+      get :index, :session => {:user_id => user.id, :tk => token.value}
+      assert_redirected_to 'http://test.host/login?back_url=http%3A%2F%2Ftest.host%2F'
+      assert_include "Veuillez vous reconnecter", flash[:error]
+      assert_equal :fr, current_language
+    end
+  end
+
+  def test_anonymous_session_should_not_be_reset
+    with_settings :session_lifetime => '720', :session_timeout => '60' do
+      get :index
+      assert_response :success
+    end
+  end
+end

data/spec/redmine/test/integration/api_test/search_test.rb

@@ -0,0 +1,92 @@
+# Redmine - project management software
+# Copyright (C) 2006-2016  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.expand_path('../../../test_helper', __FILE__)
+
+class Redmine::ApiTest::SearchTest < Redmine::ApiTest::Base
+  fixtures :projects, :projects_trackers,
+           :enabled_modules, :roles, :users, :members, :member_roles,
+           :issues, :trackers, :issue_statuses, :enumerations,
+           :workflows,
+           :custom_fields, :custom_values,
+           :custom_fields_projects, :custom_fields_trackers,
+           :repositories, :changesets
+
+  test "GET /search.xml should return xml content" do
+    get '/search.xml'
+
+    assert_response :success
+    assert_equal 'application/xml', @response.content_type
+  end
+
+  test "GET /search.json should return json content" do
+    get '/search.json'
+
+    assert_response :success
+    assert_equal 'application/json', @response.content_type
+
+    json = ActiveSupport::JSON.decode(response.body)
+    assert_kind_of Hash, json
+    assert_kind_of Array, json['results']
+  end
+
+  test "GET /search.xml without query strings should return empty results" do
+    get '/search.xml', :q => '', :all_words => ''
+
+    assert_response :success
+    assert_select 'result', 0
+  end
+
+  test "GET /search.xml with query strings should return results" do
+    issue = Issue.generate!(:subject => 'searchapi')
+
+    get '/search.xml', :q => 'searchapi', :all_words => ''
+
+    assert_response :success
+
+    assert_select 'results[type=array]' do
+      assert_select 'result', 1
+
+      assert_select 'result' do
+        assert_select 'id',          :text => issue.id.to_s
+        assert_select 'title',       :text => "Bug ##{issue.id} (New): searchapi"
+        assert_select 'type',        :text => 'issue'
+        assert_select 'url',         :text => "http://www.example.com/issues/#{issue.id}"
+        assert_select 'description', :text => ''
+        assert_select 'datetime'
+      end
+    end
+  end
+
+  test "GET /search.xml should paginate" do
+    issue = (0..10).map {Issue.generate! :subject => 'search_with_limited_results'}.reverse.map(&:id)
+
+    get '/search.json', :q => 'search_with_limited_results', :limit => 4
+    json = ActiveSupport::JSON.decode(response.body)
+    assert_equal 11, json['total_count']
+    assert_equal 0, json['offset']
+    assert_equal 4, json['limit']
+    assert_equal issue[0..3], json['results'].map {|r| r['id']}
+
+    get '/search.json', :q => 'search_with_limited_results', :offset => 8, :limit => 4
+    json = ActiveSupport::JSON.decode(response.body)
+    assert_equal 11, json['total_count']
+    assert_equal 8, json['offset']
+    assert_equal 4, json['limit']
+    assert_equal issue[8..10], json['results'].map {|r| r['id']}
+  end
+end

data/spec/redmine/test/integration/routing/imports_test.rb

@@ -0,0 +1,36 @@
+# Redmine - project management software
+# Copyright (C) 2006-2016  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.expand_path('../../../test_helper', __FILE__)
+
+class RoutingImportsTest < Redmine::RoutingTest
+  def test_imports
+    should_route 'GET /issues/imports/new' => 'imports#new'
+    should_route 'POST /imports' => 'imports#create'
+
+    should_route 'GET /imports/4ae6bc' => 'imports#show', :id => '4ae6bc'
+
+    should_route 'GET /imports/4ae6bc/settings' => 'imports#settings', :id => '4ae6bc'
+    should_route 'POST /imports/4ae6bc/settings' => 'imports#settings', :id => '4ae6bc'
+
+    should_route 'GET /imports/4ae6bc/mapping' => 'imports#mapping', :id => '4ae6bc'
+    should_route 'POST /imports/4ae6bc/mapping' => 'imports#mapping', :id => '4ae6bc'
+
+    should_route 'GET /imports/4ae6bc/run' => 'imports#run', :id => '4ae6bc'
+    should_route 'POST /imports/4ae6bc/run' => 'imports#run', :id => '4ae6bc'
+  end
+end

data/spec/redmine/test/integration/sessions_test.rb

@@ -0,0 +1,97 @@
+# Redmine - project management software
+# Copyright (C) 2006-2016  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.expand_path('../../test_helper', __FILE__)
+
+class SessionsTest < Redmine::IntegrationTest
+  fixtures :users, :email_addresses, :roles
+
+  def setup
+    Rails.application.config.redmine_verify_sessions = true
+  end
+
+  def teardown
+    Rails.application.config.redmine_verify_sessions = false
+  end
+
+  def test_change_password_kills_sessions
+    log_user('jsmith', 'jsmith')
+
+    jsmith = User.find(2)
+    jsmith.password = "somenewpassword"
+    jsmith.save!
+
+    get '/my/account'
+    assert_response 302
+    assert flash[:error].match(/Your session has expired/)
+  end
+
+  def test_lock_user_kills_sessions
+    log_user('jsmith', 'jsmith')
+
+    jsmith = User.find(2)
+    assert jsmith.lock!
+    assert jsmith.activate!
+
+    get '/my/account'
+    assert_response 302
+    assert flash[:error].match(/Your session has expired/)
+  end
+
+  def test_update_user_does_not_kill_sessions
+    log_user('jsmith', 'jsmith')
+
+    jsmith = User.find(2)
+    jsmith.firstname = 'Robert'
+    jsmith.save!
+
+    get '/my/account'
+    assert_response 200
+  end
+
+  def test_change_password_generates_a_new_token_for_current_session
+    log_user('jsmith', 'jsmith')
+    assert_not_nil token = session[:tk]
+
+    get '/my/password'
+    assert_response 200
+    post '/my/password', :password => 'jsmith',
+                         :new_password => 'secret123',
+                         :new_password_confirmation => 'secret123'
+    assert_response 302
+    assert_not_equal token, session[:tk]
+
+    get '/my/account'
+    assert_response 200
+  end
+
+  def test_simultaneous_sessions_should_be_valid
+    first = open_session do |session|
+      session.post "/login", :username => 'jsmith', :password => 'jsmith'
+    end
+    other = open_session do |session|
+      session.post "/login", :username => 'jsmith', :password => 'jsmith'
+    end
+
+    first.get '/my/account'
+    assert_equal 200, first.response.response_code
+    first.post '/logout'
+
+    other.get '/my/account'
+    assert_equal 200, other.response.response_code
+  end
+end

data/spec/redmine/test/ui/custom_fields_test_ui.rb

@@ -0,0 +1,38 @@
+# Redmine - project management software
+# Copyright (C) 2006-2016  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.expand_path('../base', __FILE__)
+
+class Redmine::UiTest::CustomFieldsTest < Redmine::UiTest::Base
+  fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
+           :trackers, :projects_trackers, :enabled_modules, 
+           :custom_fields, :custom_values, :custom_fields_trackers
+
+  def test_reordering_should_redirect_to_index
+    assert_equal 1, UserCustomField.find(4).position
+    log_user 'admin', 'admin'
+    visit '/custom_fields'
+
+    # click 'User' tab
+    page.first('a#tab-UserCustomField').click
+    # click 'Move down' link on the first row
+    page.first('td.reorder a:nth-child(3)').click
+
+    assert_equal "/custom_fields?tab=UserCustomField", URI.parse(current_url).request_uri
+    assert_equal 2, UserCustomField.find(4).position
+  end
+end

data/spec/redmine/test/unit/attachment_transaction_test.rb

@@ -0,0 +1,76 @@
+# encoding: utf-8
+#
+# Redmine - project management software
+# Copyright (C) 2006-2016  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.expand_path('../../test_helper', __FILE__)
+
+class AttachmentTest < ActiveSupport::TestCase
+  fixtures :users, :email_addresses, :projects, :roles, :members, :member_roles,
+           :enabled_modules, :issues, :trackers, :attachments
+
+  self.use_transactional_fixtures = false
+
+  def setup
+    set_tmp_attachments_directory
+  end
+
+  def test_rollback_after_create_should_remove_file_from_disk
+    diskfile = nil
+
+    Attachment.transaction do
+      a = Attachment.new(:container => Issue.find(1),
+                         :file => uploaded_test_file("testfile.txt", "text/plain"),
+                         :author => User.find(1))
+      a.save!
+      diskfile = a.diskfile
+      assert File.exist?(diskfile)
+      raise ActiveRecord::Rollback
+    end
+    assert !File.exist?(diskfile)
+  end
+
+  def test_destroy_should_remove_file_from_disk_after_commit
+    a = Attachment.new(:container => Issue.find(1),
+                       :file => uploaded_test_file("testfile.txt", "text/plain"),
+                       :author => User.find(1))
+    a.save!
+    diskfile = a.diskfile
+    assert File.exist?(diskfile)
+
+    Attachment.transaction do
+      a.destroy
+      assert File.exist?(diskfile)
+    end
+    assert !File.exist?(diskfile)
+  end
+
+  def test_rollback_after_destroy_should_not_remove_file_from_disk
+    a = Attachment.new(:container => Issue.find(1),
+                       :file => uploaded_test_file("testfile.txt", "text/plain"),
+                       :author => User.find(1))
+    a.save!
+    diskfile = a.diskfile
+    assert File.exist?(diskfile)
+
+    Attachment.transaction do
+      a.destroy
+      raise ActiveRecord::Rollback
+    end
+    assert File.exist?(diskfile)
+  end
+end