redmine_airbrake_backend 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e94a784058235695f5420da63caf59103aadd0e2f9479dc7ad6da0619b296035
-  data.tar.gz: 8dfb3a85f877301c7507c8066000d0e5677cb8df86d937243c55fce9963ba9d4
+  metadata.gz: ad74c889a328309514b6b3cb0b00fe1ce3082da85407f551d3ab66e63de88d9a
+  data.tar.gz: fc95ca0035740ec48e17aa67704d229b597597594ed570cf44accc5f0658846b
 SHA512:
-  metadata.gz: 56af38387d929c822fe89205f77a05590ebc6e9bd4a7354791548821edff783b252bb0a7f5846b2116163a21c5afd35a98fe251b335d6c700cbaadf97f7b5f84
-  data.tar.gz: e53f9f81f788630b003c6fa2f1cd4c6cb135c22b2f9578f40a22f3091d97ec595439c003faaf6023aa14a0df1bd1503f5788ce4f23d50a7a1e96c1f76f87c645
+  metadata.gz: af872b06365c8a32957c40503697a7f98e63e22e0f53f3cc9e9ed7af0d3a268f270fb5589ca6c5f4340648a45c9b49233ef64dd2dc737cdae54c0b02ce487813
+  data.tar.gz: 6db261719fba67208e7de4b7191659b772ee5737100598f913f132948e39e3bc6de16c138c1761d874b3a135d94eef6ca06441c03e35a980c71b3fb6e206ccc9

data/CHANGELOG.md

@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.4.1] - 2019-08-26
+### Fixed
+- Typo in variable name
+- Description syntax for source links without line number
+
 ## [1.4.0] - 2019-08-26
 ### Fixed
 - Mapping of backtrace elements to repository entries

data/app/helpers/airbrake_helper.rb

@@ -67,17 +67,19 @@ module AirbrakeHelper
     file = element.root.undefined? ? element.file : "[#{element.root.upcase}_ROOT]#{element.file}"
 
     if element.line.blank?
-      "@#{ile}@"
+      "@#{file}@"
     else
       "@#{file}:#{element.line}@"
     end
   end
 
   def airbrake_backtrace_element_markup_with_repository(repository, element)
+    file = element.line.present? ? "#{element.file}#L#{element.line}" : element.file
+
     if repository.identifier.blank?
-      "source:\"#{element.file}#L#{element.line}\""
+      "source:\"#{file}\""
     else
-      "source:\"#{repository.identifier}|#{element.file}#L#{element.line}\""
+      "source:\"#{repository.identifier}|#{file}\""
     end
   end
 end

data/lib/redmine_airbrake_backend/version.rb

@@ -2,5 +2,5 @@
 
 module RedmineAirbrakeBackend
   # Version of this gem
-  VERSION = '1.4.0'
+  VERSION = '1.4.1'
 end

data/test/test_helper.rb

@@ -4,3 +4,5 @@ require 'rails'
 require 'rails/test_help'
 
 Bundler.require(*Rails.groups)
+
+$LOAD_PATH.unshift(*Rails::Engine::Configuration.new(File.expand_path('..',  __dir__)).eager_load_paths)

data/test/unit/airbrake_helper_test.rb

@@ -0,0 +1,50 @@
+require_relative '../test_helper'
+
+require 'airbrake_helper'
+
+class AirbrakeHelperTest < ActiveSupport::TestCase
+  include AirbrakeHelper
+
+  class Repository
+    attr_reader :identifier
+
+    def initialize(options = {})
+      @identifier = options[:identifier]
+    end
+  end
+
+  test 'airbrake_backtrace_element_markup_without_repository' do
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/PROJECT_ROOT/foo/bar.rb', line: 10)
+    assert_equal('@[PROJECT_ROOT]/foo/bar.rb:10@', airbrake_backtrace_element_markup_without_repository(be))
+
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/GEM_ROOT/foo/bar.rb', line: 10)
+    assert_equal('@[GEM_ROOT]/foo/bar.rb:10@', airbrake_backtrace_element_markup_without_repository(be))
+
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/PROJECT_ROOT/foo/bar.rb', function: 'foo')
+    assert_equal('@[PROJECT_ROOT]/foo/bar.rb@', airbrake_backtrace_element_markup_without_repository(be))
+
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/foo/bar.rb', line: 10)
+    assert_equal('@/foo/bar.rb:10@', airbrake_backtrace_element_markup_without_repository(be))
+
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/foo/bar.rb', function: 'foo')
+    assert_equal('@/foo/bar.rb@', airbrake_backtrace_element_markup_without_repository(be))
+  end
+
+  test 'airbrake_backtrace_element_markup_with_repository' do
+    r = Repository.new(identifier: nil)
+
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/PROJECT_ROOT/foo/bar.rb', line: 10)
+    assert_equal('source:"/foo/bar.rb#L10"', airbrake_backtrace_element_markup_with_repository(r, be))
+
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/PROJECT_ROOT/foo/bar.rb')
+    assert_equal('source:"/foo/bar.rb"', airbrake_backtrace_element_markup_with_repository(r, be))
+
+    r = Repository.new(identifier: 'foo')
+
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/PROJECT_ROOT/foo/bar.rb', line: 10)
+    assert_equal('source:"foo|/foo/bar.rb#L10"', airbrake_backtrace_element_markup_with_repository(r, be))
+
+    be = RedmineAirbrakeBackend::BacktraceElement.new(file: '/PROJECT_ROOT/foo/bar.rb')
+    assert_equal('source:"foo|/foo/bar.rb"', airbrake_backtrace_element_markup_with_repository(r, be))
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redmine_airbrake_backend
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Florian Schwab
@@ -145,6 +145,7 @@ files:
 - lib/tasks/test.rake
 - redmine_airbrake_backend.gemspec
 - test/test_helper.rb
+- test/unit/airbrake_helper_test.rb
 - test/unit/notice_test.rb
 homepage: https://gitlab.com/ydkn/redmine_airbrake_backend
 licenses:
@@ -171,4 +172,5 @@ specification_version: 4
 summary: This plugin provides the necessary API to use Redmine as a Airbrake backend
 test_files:
 - test/test_helper.rb
+- test/unit/airbrake_helper_test.rb
 - test/unit/notice_test.rb