redmine_airbrake_backend 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b609db8df7b543900de190e58b947f287767f8add9e3b67b2010f358367b139
-  data.tar.gz: 95e5a3453fd9736df2cc0ad566990fa04739eae0404a171825f2d661c7936af8
+  metadata.gz: bd9ed3cb0664c977824beee01de24dabd2883bba7bbaa0df8dbe1bfdbfd6ca47
+  data.tar.gz: 4d52088e65e445ab788d459ef88d88395716fd544e85ea97a15082198f586c11
 SHA512:
-  metadata.gz: 9add4edc3af06753ea4f6de1876f65c5824b149e72e9cae14b73e714739e91216d667fd38515a24689b5677ad5fee521afa316f833e8e92d989390153b1306e8
-  data.tar.gz: c3fe3ba17ab5863424b017a8f94e69f20dfe5e9b62992d498aa9438f199ddd112a5a2c8f069d3e1e675006bb42c58475b3761c34b13a96c5c29ad353e77933d5
+  metadata.gz: 2a17ebe81cdb4aac103031e7ee8920f33a0a23ed9075a1deb0f48b288ebb0c3fd24b91580b83c62c36d805c096a240d467ac6d488b6a75e38ebc4e9db7bdf398
+  data.tar.gz: dec97c57aab26ddd559c0680eae89ed05b810866755866b0ae8e326a6438a314423c5d31adb32e96f91d4ecd116b20473cfcd5450184819a3eac061c8b1604b0

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.2.1 (2018-01-29)
+### Features
+  - All responses are formatted as JSON
+
 ## 1.2.0 (2018-01-17)
 ### Features
   - Support airbrake token based authentication

data/app/controllers/airbrake_controller.rb

@@ -3,9 +3,8 @@ require 'redmine_airbrake_backend/notice'
 
 # Controller with airbrake related stuff
 class AirbrakeController < ::ApplicationController
-  class InvalidRequest < StandardError; end
-
   skip_before_action :verify_authenticity_token
+  skip_before_action :session_expiration, :user_setup, :check_if_login_required, :set_localization, :check_password_change
 
   prepend_before_action :find_project
   prepend_before_action :parse_key
@@ -19,8 +18,6 @@ class AirbrakeController < ::ApplicationController
 
   after_action :cleanup_tempfiles
 
-  rescue_from InvalidRequest, with: :render_bad_request
-
   private
 
   def find_project
@@ -38,16 +35,30 @@ class AirbrakeController < ::ApplicationController
       @key = JSON.parse(params[:key]).with_indifferent_access rescue nil
     end
 
-    invalid_request!('No or invalid API key') if @key.blank? || @key[:key].blank?
-    params[:key] = @key[:key]
+    render_error('No or invalid API key format', :unauthorized) if @key.blank? || @key[:key].blank?
+  end
+
+  def authorize
+    User.current = User.find_by_api_key(@key[:key])
+
+    if User.current.blank? || User.current.anonymous?
+      render_error('Failed to authenticate', :unauthorized)
+
+      return
+    end
+
+    return if User.current.allowed_to?({ controller: params[:controller], action: params[:action] }, @project)
+
+    render_error('Access Denied', :forbidden)
   end
 
   def find_tracker
     @tracker = record_for(@project.trackers, :tracker)
-    invalid_request!('No or invalid tracker') if @tracker.blank?
+
+    render_error('No or invalid tracker', :failed_dependency) if @tracker.blank?
 
     # Check notice ID field
-    invalid_request!('Custom field for notice hash not available on selected tracker') if @tracker.custom_fields.find_by(id: notice_hash_field.id).blank?
+    render_error('Custom field for notice hash not available on selected tracker', :failed_dependency) if @tracker.custom_fields.find_by(id: notice_hash_field.id).blank?
   end
 
   def find_category
@@ -66,14 +77,10 @@ class AirbrakeController < ::ApplicationController
     @repository = @project.repositories.find_by(identifier: (@key[:repository] || ''))
   end
 
-  def invalid_request!(message)
-    raise InvalidRequest.new(message)
-  end
-
-  def render_bad_request(error)
-    ::Rails.logger.warn(error.message)
+  def render_error(error, status = :internal_server_error)
+    ::Rails.logger.warn(error)
 
-    render text: error.message, status: :bad_request
+    render json: { error: { message: error } }, status: status
   end
 
   def render_airbrake_response

data/lib/redmine_airbrake_backend/version.rb

@@ -1,4 +1,4 @@
 module RedmineAirbrakeBackend
   # Version of this gem
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redmine_airbrake_backend
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Florian Schwab
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-17 00:00:00.000000000 Z
+date: 2018-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails